Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

2009-04-30 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: As I mentioned in the bug report, what is the benefit of this? General best practise - no particular bug. Note the full proposed patch was bad. Bad practice would be to change an API, based on a

svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

2009-04-29 Thread markt
Author: markt Date: Wed Apr 29 10:22:00 2009 New Revision: 769734 URL: http://svn.apache.org/viewvc?rev=769734view=rev Log: Reduce scope - partial application of patch by Jens Kapitza from bug 46999 Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java Modified:

Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

2009-04-29 Thread Filip Hanik - Dev Lists
As I mentioned in the bug report, what is the benefit of this? Filip ma...@apache.org wrote: Author: markt Date: Wed Apr 29 10:22:00 2009 New Revision: 769734 URL: http://svn.apache.org/viewvc?rev=769734view=rev Log: Reduce scope - partial application of patch by Jens Kapitza from bug 46999

Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

2009-04-29 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: As I mentioned in the bug report, what is the benefit of this? General best practise - no particular bug. Note the full proposed patch was bad. Mark - To unsubscribe, e-mail:

Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

2009-04-29 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: As I mentioned in the bug report, what is the benefit of this? General best practise - no particular bug. Note the full proposed patch was bad. Bad practice would be to change an API, based on a report for general practice. It