mod_jk doesn't make the setting of reply_timeout effective.

2006-02-13 Thread Hidenori Yukawa

I am using mod_jk 1.2.15.
It set if to workers.properties.
---
worker.ap1.type=ajp13
worker.ap1.host=192.168.0.3
worker.ap1.port=8009
worker.ap1.recovery_options=0 or 3
worker.ap1.retries=1
worker.ap1.reply_timeout=3
---

I set reply_timeout=3(30sec) by mod_jk1.2.15.
And, The JSP page that return the result after the sleep had been done
for 3 minutes was displayed. 

At recovery_options=0 or 2, 503 Service Temporarily Unavailable will be 
displayed in about 30 seconds. This is a result the same as the expectation. 

At recovery_options=1 or 3, 502 Bad Gateway will be displayed in about 3 minutes. 
This is not a result the same as the expectation. 
At this time, I want you to be going to be displayed in about 30 seconds as 502 Bad Gateway.



mod_jk 1.2.13 was a result the same as the expectation regardless of 
recovery_options value.
Thanks in advance.

Regards.
Hidenori Yukawa

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Building Tomcat 5.0

2006-02-13 Thread Bob Herrmann

I'm trying to update the build script for 5.0

Has anyone seen this, it seems the 'get' in ant downloads a corrupt file,
while the browser or command line tools get it right.

ie.

project
   target name='b'
   get dest=ant-mx4j.tar.gz src=${src}/
   /target
/project

$  ant  -f b.xml
-Dsrc=http://easynews.dl.sourceforge.net/sourceforge/mx4j/mx4j-2.1.1.tar.gz
b

$ cksum  mx4j-2.1.1.tar.gz
768509745 4585483 mx4j-2.1.1.tar.gz

$ cksum cksum mx4j-2.1.1.tar.gz-firefox
552602649 4587837 mx4j-2.1.1.tar.gz-mozilla

Why do I always get the edge cases?

-bob


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r376730 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/buf/CharChunk.java

2006-02-13 Thread Remy Maucherat

Costin Manolache wrote:

Well, long time ago CharChunk and ByteChunk were supposed to be just an
implementation
detail of MessageBytes - which was supposed to hide the detail of chars and
bytes and avoid the strings.
But they were supposed to work together, and stay kind of consistent.


I am not against it, as other parts of the code assume the default HTTP 
encoding when dealing with bytes. User code can use toChars or toString 
to force character conversion whenever needed, so it looks reasonably safe.



Sorry :-)

I guess it had something to do with  jdk compat ? Well, too lazy to search -
but
I doubt any reason would be valid today, most VMs have this.


No idea, you said no because it would break API compatibility, or 
something like it. So I thought this was a misunderstanding about what 
the change was about.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



problem building 5.5.15

2006-02-13 Thread Eric Lenio
All -

Apologies in advance if this should go to tomcat-users but I'm
suspecting a problem with the way the source code is being distributed
so I'm starting here.

I downloaded the source file for 5.5.15 and built it.  After installing
it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
was expecting.

So I followed instructions, exactly, from
http://tomcat.apache.org/tomcat-5.5-doc/building.html to build directly
from subversion.  The build went
fine.  But version.sh still says 5.5.0.0.  I was expecting to have
5.5.15.

So, did I really just build 5.5.0.0?  There was a bug that was
supposedly fixed in 5.5.15 that I was experiencing, and I still see this
bug when I use this 5.5.0.0 which leads me to conclude I did not
really build 5.5.15.

Note: I can't use the binary 5.5.15 package because I have a requirement
to patch JNDIRealm.java, that's why I am starting from the source code.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377432 - in /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster: ClusterChannel.java group/ group/GroupChannel.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 09:33:22 2006
New Revision: 377432

URL: http://svn.apache.org/viewcvs?rev=377432view=rev
Log:
Infrastructure for a group layer, this is the way to abstract away membership 
and replication logic from the cluster object, as the cluster object, the 
replication valve and the manager are responsible for session replication 
logic, the channel is responsible for replication and membership.


Added:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java

Added: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java?rev=377432view=auto
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
 (added)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
 Mon Feb 13 09:33:22 2006
@@ -0,0 +1,27 @@
+/*
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.cluster;
+
+/**
+ * Channel interface
+ * A channel is an object that manages a group of members.
+ * It manages a complete cluster group, both membership and replication.
+ * @author Filip Hanik
+ * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
+ */
+public interface ClusterChannel {
+
+}

Added: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java?rev=377432view=auto
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java
 (added)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java
 Mon Feb 13 09:33:22 2006
@@ -0,0 +1,32 @@
+/*
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.cluster.group;
+
+
+import org.apache.catalina.cluster.ClusterChannel;
+
+/**
+ * Channel interface
+ * A channel is an object that manages a group of members.
+ * It manages a complete cluster group, both membership and replication.
+ * @author Filip Hanik
+ * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
+ */
+public class GroupChannel implements ClusterChannel {
+public GroupChannel() {
+}
+
+}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote:
 All -
 
 Apologies in advance if this should go to tomcat-users but I'm
 suspecting a problem with the way the source code is being distributed
 so I'm starting here.
 
 I downloaded the source file for 5.5.15 and built it.  After installing
 it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
 was expecting.
This is the default version number set in build.properties.default

The behaviour you see is expected and can be changed by setting the
appropriate ant properties.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Eric Lenio
OK thanks for the tip.  Is there a document that goes into detail
on this?

On Mon, Feb 13, 2006 at 07:35:42PM +, Mark Thomas wrote:
 Eric Lenio wrote:
  All -
  
  Apologies in advance if this should go to tomcat-users but I'm
  suspecting a problem with the way the source code is being distributed
  so I'm starting here.
  
  I downloaded the source file for 5.5.15 and built it.  After installing
  it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
  was expecting.
 This is the default version number set in build.properties.default
 
 The behaviour you see is expected and can be changed by setting the
 appropriate ant properties.
 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Request parameters straight after authentication

2006-02-13 Thread Mark Thomas
Kevin McCormack wrote:
 Possible Fix?
 ==
 I looked through the Tomcat 5.5.12 source code and ended up in the
 org.apache.catalina.authentication.FormAuthenticator class and noticed
 that there is no code there to save the request parameters from the
 original request into the saved request in the saveRequest() mehtod
 and to copy them into the final 'new' request in the restoreRequest()
 method. Am I missing something here?
Yep, lines 478 to 490 of the current version of FormAuthenticator

 Conclusion
 
 I believe that this is a bug and that I have found a fix for it but
 I'm not a Tomcat expert and would like someone who knows the code to
 verify that a) this is a bug and b) that it has not been fixed
 somewhere else that I am unaware of. I'm willing to raise a bug and
 post the fixed code if desired.
This might be a bug but your fix is the wrong way to do it. You have
to assume a request parameter encoding and that causes i18n problems.

Is your setting of maxSavePostSize appropriate?

If you are convinced you have a bug, a test case (as simple as
possible ready to run war with all source code) will greatly increase
the chances that someone looks at it.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote:
 OK thanks for the tip.  Is there a document that goes into detail
 on this?
BUILDING.TXT and http://tomcat.apache.org/tomcat-5.5-doc/building.html
are the main documents. Documentation patches are always welcome.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat errors.

2006-02-13 Thread Angel Prieto
Hello, what do you want to mean when you say this question belongs as 
per? I can't find it. Could you please me tell me the full url?


Thanks in advance.

Mark Thomas escribió:

Ángel Prieto wrote:
  

Hello, I'm having some problems with apache+tomcat with this configuration:
Could anyone tell me something about it?



The question belongs on the users list as per
http://tomcat.apache.org/lists.html

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377486 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:04:20 2006
New Revision: 377486

URL: http://svn.apache.org/viewcvs?rev=377486view=rev
Log:
Use constants instead of hard coding values

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java?rev=377486r1=377485r2=377486view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 Mon Feb 13 13:04:20 2006
@@ -257,8 +257,8 @@
  * @throws java.lang.Exception if a IO error occurs
  */
 public void start() throws java.lang.Exception {
-start(1);
-start(2);
+start(MembershipService.MBR_RX);
+start(MembershipService.MBR_RX);
 registerMBean();
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377488 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:10:41 2006
New Revision: 377488

URL: http://svn.apache.org/viewcvs?rev=377488view=rev
Log:
oops, use the correct values

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java?rev=377488r1=377487r2=377488view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 Mon Feb 13 13:10:41 2006
@@ -258,7 +258,7 @@
  */
 public void start() throws java.lang.Exception {
 start(MembershipService.MBR_RX);
-start(MembershipService.MBR_RX);
+start(MembershipService.MBR_TX);
 registerMBean();
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377499 - in /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp: ReplicationTransmitter.java SimpleTcpCluster.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:39:52 2006
New Revision: 377499

URL: http://svn.apache.org/viewcvs?rev=377499view=rev
Log:
more code cleanup

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java?rev=377499r1=377498r2=377499view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
 Mon Feb 13 13:39:52 2006
@@ -415,11 +415,9 @@
 
 /**
  * Send data to one member
- * FIXME set filtering messages
  * @see 
org.apache.catalina.cluster.ClusterSender#sendMessage(org.apache.catalina.cluster.ClusterMessage,
 org.apache.catalina.cluster.Member)
  */
-public void sendMessage(ClusterMessage message, Member member)
-throws java.io.IOException {   
+public void sendMessage(ClusterMessage message, Member member) throws 
IOException {   
 long time = 0 ;
 if(doTransmitterProcessingStats) {
 time = System.currentTimeMillis();
@@ -440,47 +438,21 @@
  * Send to all senders at same cluster domain as message from address
  * @param message Cluster message to send
  * @since 5.5.10
- * FIXME Refactor with sendMessage get a sender list from
  */
-public void sendMessageClusterDomain(ClusterMessage message) 
- throws java.io.IOException {
-long time = 0;
-if (doTransmitterProcessingStats) {
-time = System.currentTimeMillis();
-}
-try {
-String domain = message.getAddress().getDomain();
-if(domain == null)
-throw new RuntimeException(Domain at member not set);
-ClusterData data = serialize(message);
-IDataSender[] senders = getSenders();
-for (int i = 0; i  senders.length; i++) {
-
-IDataSender sender = senders[i];
-if(domain.equals(sender.getDomain())) {
-try {
-boolean success = sendMessageData(data, sender);
-} catch (Exception x) {
-//THIS WILL NEVER HAPPEN, as sendMessageData swallows 
the error
-}
-}
-}
-} finally {
-// FIXME better exception handling
-if (doTransmitterProcessingStats) {
-addProcessingStats(time);
-}
-}
+public void sendMessageClusterDomain(ClusterMessage message) throws 
IOException {
+sendMessage(message,true);
 
 }
 
+public void sendMessage(ClusterMessage message) throws IOException {
+sendMessage(message,false);
+}
+
 /**
  * send message to all senders (broadcast)
  * @see 
org.apache.catalina.cluster.ClusterSender#sendMessage(org.apache.catalina.cluster.ClusterMessage)
- * FIXME Refactor with sendMessageClusterDomain!
  */
-public void sendMessage(ClusterMessage message)
-throws java.io.IOException {
+public void sendMessage(ClusterMessage message, boolean domainOnly) throws 
IOException {
 long time = 0;
 if (doTransmitterProcessingStats) {
 time = System.currentTimeMillis();
@@ -491,19 +463,19 @@
 for (int i = 0; i  senders.length; i++) {
 
 IDataSender sender = senders[i];
-try {
-sendMessageData(data, sender);
-} catch (Exception x) {
-// FIXME remember exception and send it at finally
-}
+//domain filter
+String domain = message.getAddress().getDomain();
+if ( domainOnly  !(domain.equals(sender.getDomain())) ) 
continue;
+sendMessageData(data, sender);
 }
 } finally {
-// FIXME better exception handling
 if (doTransmitterProcessingStats) {
 addProcessingStats(time);
 }
 }
 }
+
+
 
 /**
  * start the sender and register transmitter mbean
@@ -828,9 +800,9 @@
  * @throws java.io.IOException If an error occurs
  */
 protected boolean sendMessageData(ClusterData data,
-   IDataSender sender) throws 
java.io.IOException {
+  IDataSender sender) {
 if (sender 

DO NOT REPLY [Bug 38637] New: - IP address of the HttpSession owner

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38637.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38637

   Summary: IP address of the HttpSession owner
   Product: Tomcat 5
   Version: 5.5.9
  Platform: All
OS/Version: other
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


hi,

This is not a bug, just a suggestion.

Sometimes it is necessary to back trace session data to the originating client.
It would be really useful if StandardSession has IP address of the client as a
property. 

Thanks in advance,
Vlad

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r377486 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread Peter Rossbach

Is that correct that you use now at McastService the same constant?

Before it was start(1) and start(2)

Peter
[EMAIL PROTECTED]



Am 13.02.2006 um 22:04 schrieb [EMAIL PROTECTED]:


Author: fhanik
Date: Mon Feb 13 13:04:20 2006
New Revision: 377486

URL: http://svn.apache.org/viewcvs?rev=377486view=rev
Log:
Use constants instead of hard coding values

Modified:
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java


Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/ 
apache/catalina/cluster/mcast/McastService.java
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/ 
cluster/src/share/org/apache/catalina/cluster/mcast/ 
McastService.java?rev=377486r1=377485r2=377486view=diff
== 

--- tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java (original)
+++ tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java Mon Feb 13 13:04:20 2006

@@ -257,8 +257,8 @@
  * @throws java.lang.Exception if a IO error occurs
  */
 public void start() throws java.lang.Exception {
-start(1);
-start(2);
+start(MembershipService.MBR_RX);
+start(MembershipService.MBR_RX);
 registerMBean();
 }




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r377486 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread Peter Rossbach

Ohh,

I see you have later correct this past bug. Thanks!

Are your current big changes not a very high risk to break the  
cluster functionaliy again?
Why we not going inside a branch or a cluster2 module? Currently a  
lot of user work very successfully with the tomcat 5.5.15 cluster. It  
was my fault last year to changes to quick a lot.


Regards
Peter
[EMAIL PROTECTED]



Am 14.02.2006 um 07:37 schrieb Peter Rossbach:


Is that correct that you use now at McastService the same constant?

Before it was start(1) and start(2)

Peter
[EMAIL PROTECTED]



Am 13.02.2006 um 22:04 schrieb [EMAIL PROTECTED]:


Author: fhanik
Date: Mon Feb 13 13:04:20 2006
New Revision: 377486

URL: http://svn.apache.org/viewcvs?rev=377486view=rev
Log:
Use constants instead of hard coding values

Modified:
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java


Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/ 
apache/catalina/cluster/mcast/McastService.java
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/ 
modules/cluster/src/share/org/apache/catalina/cluster/mcast/ 
McastService.java?rev=377486r1=377485r2=377486view=diff
= 
=
--- tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java (original)
+++ tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java Mon Feb 13 13:04:20 2006

@@ -257,8 +257,8 @@
  * @throws java.lang.Exception if a IO error occurs
  */
 public void start() throws java.lang.Exception {
-start(1);
-start(2);
+start(MembershipService.MBR_RX);
+start(MembershipService.MBR_RX);
 registerMBean();
 }




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Mladen Turk

Eric Lenio wrote:

All -

Apologies in advance if this should go to tomcat-users but I'm
suspecting a problem with the way the source code is being distributed
so I'm starting here.

I downloaded the source file for 5.5.15 and built it.  After installing
it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
was expecting.



You will need to edit the build/build.properties.default
and adjust the version numbers to preferred version.

It's up to RM to adjust them before releasing or building.
We don't have actual version number inside the SVN, although
we might add some sort of

property file=version.current/
in the build.xml that would contain only version flags:

# - Vesion Control Flags -
version.major=5
version.minor=5
version.build=1
version.patch=16
#Set the pretty version name
version=5.5.16-dev


Since that still implies that RM will still have to
edit that file before releasing, you might as well create
a build.properties file with the upper content.

The easiest thing would be to have a separate version
property file updated regularly upon releases.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]