svn commit: r910850 - /tomcat/site/trunk/xdocs/download-native.xml

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 08:05:52 2010
New Revision: 910850

URL: http://svn.apache.org/viewvc?rev=910850view=rev
Log:
Update to 1.1.20

Modified:
tomcat/site/trunk/xdocs/download-native.xml

Modified: tomcat/site/trunk/xdocs/download-native.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/download-native.xml?rev=910850r1=910849r2=910850view=diff
==
--- tomcat/site/trunk/xdocs/download-native.xml (original)
+++ tomcat/site/trunk/xdocs/download-native.xml Wed Feb 17 08:05:52 2010
@@ -49,28 +49,28 @@
   div class=linksspan class=labelSource (please choose the 
correct format for your platform)/span/div
   ul
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz
-Native 1.1.19 Source Release tar.gz
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz
+Native 1.1.20 Source Release tar.gz
   /a (e.g. Unix, Linux, Mac OS)
 ul class=attributes
   lispan class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP/a]
   /span/li
   lispan class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.md5;MD5/a]
   /span/li
 /ul
 /li
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-win32-src.zip
-Native 1.1.19 Source Release zip
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip
+Native 1.1.20 Source Release zip
   /a (e.g. Windows)
 ul class=attributes
   lispan class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-win32-src.zip.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip.asc;PGP/a]
   /span/li
   lispan class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-win32-src.zip.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip.md5;MD5/a]
   /span/li
 /ul
 /li
@@ -79,7 +79,7 @@
 /ul
 pYou can find binaries release too/p
 pYou may download them from
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/binariesHERE/a
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.20/binariesHERE/a
 /p
 
   /subsection
@@ -98,17 +98,17 @@
 
 pcode
 % pgpk -a KEYSbr /
-% pgpv tomcat-native-1.1.19-src.tar.gz.ascbr /
+% pgpv tomcat-native-1.1.20-src.tar.gz.ascbr /
 /code
 emor/embr /
 code
 % pgp -ka KEYSbr /
-% pgp tomcat-native-1.1.19-src.tar.gz.ascbr /
+% pgp tomcat-native-1.1.20-src.tar.gz.ascbr /
 /code
 emor/embr /
 code
 % gpg --import KEYSbr /
-% gpg --verify tomcat-native-1.1.19-src.tar.gz.asc
+% gpg --verify tomcat-native-1.1.20-src.tar.gz.asc
 /code/p
 
 pAlternatively, you can verify the MD5 signature (hash value) on the 
files.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910851 - /tomcat/site/trunk/docs/download-native.html

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 08:06:34 2010
New Revision: 910851

URL: http://svn.apache.org/viewvc?rev=910851view=rev
Log:
Update to 1.1.20

Modified:
tomcat/site/trunk/docs/download-native.html

Modified: tomcat/site/trunk/docs/download-native.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-native.html?rev=910851r1=910850r2=910851view=diff
==
--- tomcat/site/trunk/docs/download-native.html (original)
+++ tomcat/site/trunk/docs/download-native.html Wed Feb 17 08:06:34 2010
@@ -273,35 +273,35 @@
 /div
   ul
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz
-Native 1.1.19 Source Release tar.gz
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz
+Native 1.1.20 Source Release tar.gz
   /a (e.g. Unix, Linux, Mac OS)
 ul class=attributes
   li
 span class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP/a]
   /span
 /li
   li
 span class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.md5;MD5/a]
   /span
 /li
 /ul
 /li
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-win32-src.zip
-Native 1.1.19 Source Release zip
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip
+Native 1.1.20 Source Release zip
   /a (e.g. Windows)
 ul class=attributes
   li
 span class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-win32-src.zip.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip.asc;PGP/a]
   /span
 /li
   li
 span class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-win32-src.zip.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip.md5;MD5/a]
   /span
 /li
 /ul
@@ -311,7 +311,7 @@
 /ul
 pYou can find binaries release too/p
 pYou may download them from
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/binariesHERE/a
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.20/binariesHERE/a
 /p
 
   /blockquote
@@ -350,19 +350,19 @@
 p
 code
 % pgpk -a KEYSbr/
-% pgpv tomcat-native-1.1.19-src.tar.gz.ascbr/
+% pgpv tomcat-native-1.1.20-src.tar.gz.ascbr/
 /code
 emor/em
 br/
 code
 % pgp -ka KEYSbr/
-% pgp tomcat-native-1.1.19-src.tar.gz.ascbr/
+% pgp tomcat-native-1.1.20-src.tar.gz.ascbr/
 /code
 emor/em
 br/
 code
 % gpg --import KEYSbr/
-% gpg --verify tomcat-native-1.1.19-src.tar.gz.asc
+% gpg --verify tomcat-native-1.1.20-src.tar.gz.asc
 /code
 /p
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: jk/cluster - intelligent systems load

2010-02-17 Thread Mladen Turk

On 02/16/2010 06:57 PM, Costin Manolache wrote:


I think the main driver for replacing ajp is the 2-directional protocols -
and if we
replace it, why invent a new protocol and not just adopt SPDY, which has all
we need.



Totally agree.
Both JK and AJP originate from days when the single server behind
web server was the common topology and when there was no async processing.
Beside SPDY, which some ASF folks that made a significant contribution
to the original HTTP specs consider as unperfect, there is BWTP proposal
(http://bwtp.wikidot.com/)

Extending exiting protocols or just doing a 'quick hacks' like I
see with many projects trying to address those issues will not
work in the long run. At the end you will be faced with the
clean drawing board.



Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48756] I am not finding commons-collections-3.1.jar in tomcat 5.5.28

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48756

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from Mark Thomas ma...@apache.org 2010-02-17 08:42:55 UTC ---
This is by design. Tomcat 5.5.x no longer depends on commons-collections.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910877 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/deploy/ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 09:20:59 2010
New Revision: 910877

URL: http://svn.apache.org/viewvc?rev=910877view=rev
Log:
Add Lifecycle to Container, Server and Service
Remove casts instanceof tests and any other code this makes unnecessary

Modified:
tomcat/trunk/java/org/apache/catalina/Container.java
tomcat/trunk/java/org/apache/catalina/Server.java
tomcat/trunk/java/org/apache/catalina/Service.java
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/core/StandardHost.java
tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/trunk/java/org/apache/catalina/core/StandardService.java
tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java
tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/trunk/java/org/apache/catalina/startup/Embedded.java
tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/trunk/java/org/apache/catalina/startup/UserConfig.java

tomcat/trunk/java/org/apache/catalina/valves/CometConnectionManagerValve.java

tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java

Modified: tomcat/trunk/java/org/apache/catalina/Container.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Container.java?rev=910877r1=910876r2=910877view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Container.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Container.java Wed Feb 17 09:20:59 
2010
@@ -81,7 +81,7 @@
  * @version $Revision$ $Date$
  */
 
-public interface Container {
+public interface Container extends Lifecycle {
 
 
 // - Manifest Constants

Modified: tomcat/trunk/java/org/apache/catalina/Server.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Server.java?rev=910877r1=910876r2=910877view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Server.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Server.java Wed Feb 17 09:20:59 2010
@@ -45,7 +45,7 @@
  * @version $Revision$ $Date$
  */
 
-public interface Server {
+public interface Server extends Lifecycle {
 
 
 // - Properties

Modified: tomcat/trunk/java/org/apache/catalina/Service.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Service.java?rev=910877r1=910876r2=910877view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Service.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Service.java Wed Feb 17 09:20:59 2010
@@ -34,7 +34,7 @@
  * @version $Revision$ $Date$
  */
 
-public interface Service {
+public interface Service extends Lifecycle {
 
 // - Properties
 

Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=910877r1=910876r2=910877view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Wed Feb 17 
09:20:59 2010
@@ -787,10 +787,10 @@
 children.put(child.getName(), child);
 
 // Start child
-if (started  startChildren  (child instanceof Lifecycle)) {
+if (started  startChildren) {
 boolean success = false;
 try {
-((Lifecycle) child).start();
+child.start();
 success = true;
 } catch (LifecycleException e) {
 log.error(ContainerBase.addChild: start: , e);
@@ -919,14 +919,14 @@
 children.remove(child.getName());
 }
 
-if (started  (child instanceof Lifecycle)) {
+if (started) {
 try {
 if( child instanceof ContainerBase ) {
 if( ((ContainerBase)child).started ) {
-((Lifecycle) child).stop();
+child.stop();
 }
 } else {
-((Lifecycle) child).stop();
+child.stop();
 }
 } catch (LifecycleException 

svn commit: r910879 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationServletRegistration.java

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 09:21:30 2010
New Revision: 910879

URL: http://svn.apache.org/viewvc?rev=910879view=rev
Log:
Remove unused imports

Modified:

tomcat/trunk/java/org/apache/catalina/core/ApplicationServletRegistration.java

Modified: 
tomcat/trunk/java/org/apache/catalina/core/ApplicationServletRegistration.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationServletRegistration.java?rev=910879r1=910878r2=910879view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/core/ApplicationServletRegistration.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/core/ApplicationServletRegistration.java 
Wed Feb 17 09:21:30 2010
@@ -21,11 +21,9 @@
 import java.util.Collections;
 import java.util.Enumeration;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.Map;
 import java.util.Set;
 
-import javax.servlet.HttpMethodConstraintElement;
 import javax.servlet.MultipartConfigElement;
 import javax.servlet.ServletConfig;
 import javax.servlet.ServletRegistration;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910883 - in /tomcat/trunk/java/org/apache/catalina: core/ContainerBase.java core/StandardServer.java core/StandardService.java mbeans/ServerLifecycleListener.java

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 09:38:07 2010
New Revision: 910883

URL: http://svn.apache.org/viewvc?rev=910883view=rev
Log:
More lifecycle clean-up

Modified:
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/trunk/java/org/apache/catalina/core/StandardService.java
tomcat/trunk/java/org/apache/catalina/mbeans/ServerLifecycleListener.java

Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=910883r1=910882r2=910883view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Wed Feb 17 
09:38:07 2010
@@ -123,7 +123,7 @@
  */
 
 public abstract class ContainerBase
-implements Container, Lifecycle, MBeanRegistration {
+implements Container, MBeanRegistration {
 
 private static final org.apache.juli.logging.Log log=
 org.apache.juli.logging.LogFactory.getLog( ContainerBase.class );

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardServer.java?rev=910883r1=910882r2=910883view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardServer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Wed Feb 17 
09:38:07 2010
@@ -34,7 +34,6 @@
 import javax.management.ObjectName;
 
 import org.apache.catalina.Context;
-import org.apache.catalina.Lifecycle;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.LifecycleListener;
 import org.apache.catalina.Server;
@@ -57,9 +56,8 @@
  * @author Craig R. McClanahan
  * @version $Revision$ $Date$
  */
-public final class StandardServer
-implements Lifecycle, Server, MBeanRegistration 
- {
+public final class StandardServer implements Server, MBeanRegistration {
+
 private static final Log log = LogFactory.getLog(StandardServer.class);

 

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardService.java?rev=910883r1=910882r2=910883view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardService.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardService.java Wed Feb 17 
09:38:07 2010
@@ -49,9 +49,8 @@
  * @author Craig R. McClanahan
  */
 
-public class StandardService
-implements Lifecycle, Service, MBeanRegistration 
- {
+public class StandardService implements Service, MBeanRegistration {
+
 private static final Log log = LogFactory.getLog(StandardService.class);

 

Modified: 
tomcat/trunk/java/org/apache/catalina/mbeans/ServerLifecycleListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/ServerLifecycleListener.java?rev=910883r1=910882r2=910883view=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/ServerLifecycleListener.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/ServerLifecycleListener.java 
Wed Feb 17 09:38:07 2010
@@ -302,7 +302,7 @@
 context.addContainerListener(this);
 if (context instanceof StandardContext) {
 ((StandardContext) context).addPropertyChangeListener(this);
-((StandardContext) context).addLifecycleListener(this);
+context.addLifecycleListener(this);
 }
 
 // If the context is privileged, give a reference to it



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48757] New: Tomcat deletes content of symbolic links on undeploy of application.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48757

   Summary: Tomcat deletes content of symbolic links on undeploy
of application.
   Product: Tomcat 6
   Version: 6.0.24
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: rad...@gmail.com


Tomcat on Linux.

1. Modify context to allow linking. E.g. set option allowLinking=true.

2. Deploy war file.

3. Wait until it is unzipped.

4. Enter into web app directory.

5. Create symbolic link to another directory for example
ln -s /home/tomcat/images images

6. Now you can browse images via web browser. E.g. they are served by Tomcat.

7. Undeploy war application.

8. Expected behavior is to delete only symbolic link, but content of
/home/tomcat/images is also deleted.

On *Nix when do rm -fr app, symbolic link images will be deleted, but directory
and content pointed by this link will stay. So I assume that everybody expects
the same behavior when Tomcat undeploys given application.


Workaround is to change ownership of linked directory.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat Native 1.1.20 released

2010-02-17 Thread Mladen Turk

The Apache Tomcat team announces the immediate availability of Apache
Tomcat Native 1.1.20 stable.
This release includes a fix for JVM crash on Tomcat shutdown.

Please refer to the change log for the list of changes:
http://tomcat.apache.org/native-doc/miscellaneous/changelog.html

Downloads:
http://tomcat.apache.org/download-native.cgi


Thank you,
--
The Apache Tomcat Team


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910934 - /tomcat/native/branches/1.1.x/xdocs/news/2010.xml

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 12:00:13 2010
New Revision: 910934

URL: http://svn.apache.org/viewvc?rev=910934view=rev
Log:
Add 1.1.20 release note

Modified:
tomcat/native/branches/1.1.x/xdocs/news/2010.xml

Modified: tomcat/native/branches/1.1.x/xdocs/news/2010.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/news/2010.xml?rev=910934r1=910933r2=910934view=diff
==
--- tomcat/native/branches/1.1.x/xdocs/news/2010.xml (original)
+++ tomcat/native/branches/1.1.x/xdocs/news/2010.xml Wed Feb 17 12:00:13 2010
@@ -31,6 +31,13 @@
 
 section name=2010 News amp; Status
 br /
+a name=20100217.1
+h317 February - TC-Native-1.1.20 released/h3
+/a
+pThe Apache Tomcat team is proud to announce the immediate availability
+of Tomcat Native 1.1.20. This is a stable release adding some bug fixes.
+/p
+br /
 a name=20100108.1
 h38 January - TC-Native-1.1.19 released/h3
 /a



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910937 - /tomcat/native/branches/1.1.x/xdocs/index.xml

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 12:04:39 2010
New Revision: 910937

URL: http://svn.apache.org/viewvc?rev=910937view=rev
Log:
Update the front page

Modified:
tomcat/native/branches/1.1.x/xdocs/index.xml

Modified: tomcat/native/branches/1.1.x/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/index.xml?rev=910937r1=910936r2=910937view=diff
==
--- tomcat/native/branches/1.1.x/xdocs/index.xml (original)
+++ tomcat/native/branches/1.1.x/xdocs/index.xml Wed Feb 17 12:04:39 2010
@@ -45,13 +45,13 @@
 br /
 ul
 
-lia href=news/2010.html#20100108.18 January 2010 - bTC-Native-1.1.19 
released/b/a
-pThe Apache Tomcat team is proud to announce the immediate availability of 
Tomcat Native 1.1.19 Stable.
+lia href=news/2010.html#2010217.117 February 2010 - bTC-Native-1.1.20 
released/b/a
+pThe Apache Tomcat team is proud to announce the immediate availability of 
Tomcat Native 1.1.20 Stable.
 /p
-pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz;TC-native
 1.1.19 release sources/a
- | a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.19-src.tar.gz.asc;PGP
 signature/a
+pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz;TC-native
 1.1.19 release sources/a
+ | a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP
 signature/a
 /p
-pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/binaries/;binaries/a
 for selected platforms.
+pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/binaries/;binaries/a
 for selected platforms.
 /p
 /li
 /ul



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910939 - in /tomcat/site/trunk: docs/download-native.html xdocs/download-native.xml

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 12:09:08 2010
New Revision: 910939

URL: http://svn.apache.org/viewvc?rev=910939view=rev
Log:
Fix 1.1.20 links

Modified:
tomcat/site/trunk/docs/download-native.html
tomcat/site/trunk/xdocs/download-native.xml

Modified: tomcat/site/trunk/docs/download-native.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-native.html?rev=910939r1=910938r2=910939view=diff
==
--- tomcat/site/trunk/docs/download-native.html (original)
+++ tomcat/site/trunk/docs/download-native.html Wed Feb 17 12:09:08 2010
@@ -273,35 +273,35 @@
 /div
   ul
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz
 Native 1.1.20 Source Release tar.gz
   /a (e.g. Unix, Linux, Mac OS)
 ul class=attributes
   li
 span class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP/a]
   /span
 /li
   li
 span class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz.md5;MD5/a]
   /span
 /li
 /ul
 /li
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-win32-src.zip
 Native 1.1.20 Source Release zip
   /a (e.g. Windows)
 ul class=attributes
   li
 span class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-win32-src.zip.asc;PGP/a]
   /span
 /li
   li
 span class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-win32-src.zip.md5;MD5/a]
   /span
 /li
 /ul

Modified: tomcat/site/trunk/xdocs/download-native.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/download-native.xml?rev=910939r1=910938r2=910939view=diff
==
--- tomcat/site/trunk/xdocs/download-native.xml (original)
+++ tomcat/site/trunk/xdocs/download-native.xml Wed Feb 17 12:09:08 2010
@@ -49,28 +49,28 @@
   div class=linksspan class=labelSource (please choose the 
correct format for your platform)/span/div
   ul
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz
 Native 1.1.20 Source Release tar.gz
   /a (e.g. Unix, Linux, Mac OS)
 ul class=attributes
   lispan class=pgp
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP/a]
   /span/li
   lispan class=md5
-[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-src.tar.gz.md5;MD5/a]
+[a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz.md5;MD5/a]
   /span/li
 /ul
 /li
 li class=download
-  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.19/source/tomcat-native-1.1.20-win32-src.zip
+  a 
href=[preferred]/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-win32-src.zip
 Native 1.1.20 Source Release zip
   /a (e.g. Windows)
 ul class=attributes
   lispan class=pgp
-[a 

svn commit: r910940 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 12:11:43 2010
New Revision: 910940

URL: http://svn.apache.org/viewvc?rev=910940view=rev
Log:
Update main index with 1.1.20 release

Modified:
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/xdocs/index.xml

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=910940r1=910939r2=910940view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Wed Feb 17 12:11:43 2010
@@ -255,14 +255,14 @@
 tr
 td bgcolor=#525D76
 font color=#ff face=arial,helvetica,sanserif
-a name=Tomcat Native 1.1.19 Released
-strongTomcat Native 1.1.19 Released/strong
+a name=Tomcat Native 1.1.20 Released
+strongTomcat Native 1.1.20 Released/strong
 /a
 /font
 /td
 td align=right bgcolor=#525D76
 font color=#ff face=arial,helvetica.sanserif
-strong2010-01-05/strong
+strong2010-02-17/strong
 /font
 /td
 /tr
@@ -271,12 +271,12 @@
 p
 blockquote
 p
-The Apache Tomcat Project is proud to announce the release of version 1.1.19 
of Tomcat Native.
+The Apache Tomcat Project is proud to announce the release of version 1.1.20 
of Tomcat Native.
 This version is principally a bugfix release.
 /p
 p align=center
 a href=download-native.cgiDownload/a |
-a href=native-doc/miscellaneous/changelog.htmlChangeLog for 1.1.19/a
+a href=native-doc/miscellaneous/changelog.htmlChangeLog for 1.1.20/a
 /p
 /blockquote
 /p

Modified: tomcat/site/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/index.xml?rev=910940r1=910939r2=910940view=diff
==
--- tomcat/site/trunk/xdocs/index.xml (original)
+++ tomcat/site/trunk/xdocs/index.xml Wed Feb 17 12:11:43 2010
@@ -41,14 +41,14 @@
 /p
 /section
 
-section name=Tomcat Native 1.1.19 Released rtext=2010-01-05
+section name=Tomcat Native 1.1.20 Released rtext=2010-02-17
 p
-The Apache Tomcat Project is proud to announce the release of version 1.1.19 
of Tomcat Native.
+The Apache Tomcat Project is proud to announce the release of version 1.1.20 
of Tomcat Native.
 This version is principally a bugfix release.
 /p
 p align=center
 a href=download-native.cgiDownload/a |
-a href=native-doc/miscellaneous/changelog.htmlChangeLog for 1.1.19/a
+a href=native-doc/miscellaneous/changelog.htmlChangeLog for 1.1.20/a
 /p
 /section
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910943 - /tomcat/native/trunk/xdocs/miscellaneous/changelog-1.1.x.xml

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 12:16:04 2010
New Revision: 910943

URL: http://svn.apache.org/viewvc?rev=910943view=rev
Log:
Copy the 1.1.x changelog

Modified:
tomcat/native/trunk/xdocs/miscellaneous/changelog-1.1.x.xml

Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog-1.1.x.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog-1.1.x.xml?rev=910943r1=910942r2=910943view=diff
==
--- tomcat/native/trunk/xdocs/miscellaneous/changelog-1.1.x.xml (original)
+++ tomcat/native/trunk/xdocs/miscellaneous/changelog-1.1.x.xml Wed Feb 17 
12:16:04 2010
@@ -36,6 +36,27 @@
   new documentation project for Tomcat Native was started.
   /p
 /section
+section name=Changes between 1.1.19 and 1.1.20
+  changelog
+fix
+  bug48584/bug: Prevent crashing JVM on shutdown. (mturk)
+/fix
+  /changelog
+/section
+section name=Changes between 1.1.18 and 1.1.19
+  changelog
+fix
+  Update windows resource files to correct version. (mturk)
+/fix
+fix
+  bug48129/bug: Fix build with OpenSSL 1.0.0-beta3.
+  Patch provided by Tomas Mraz. (mturk, rjung)
+/fix
+update
+  Add detection of the Mac OS X JVM. (rjung)
+/update
+  /changelog
+/section
 section name=Changes between 1.1.17 and 1.1.18
   changelog
 fix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JK 1.2.29-dev Available for testing

2010-02-17 Thread Mladen Turk

On 02/11/2010 12:15 PM, Mladen Turk wrote:


Test snapshot for 1.2.29 is available at
http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/



So far no comments, so I suppose everything works like a charm.
Since we have postponed this release mostly because core
developers are busy bees for a long time,
I plan to tag and propose a release next Monday (Feb 22nd)


Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910947 - /tomcat/trunk/build.properties.default

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 12:28:13 2010
New Revision: 910947

URL: http://svn.apache.org/viewvc?rev=910947view=rev
Log:
Update to latest native connector

Modified:
tomcat/trunk/build.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=910947r1=910946r2=910947view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Feb 17 12:28:13 2010
@@ -76,7 +76,7 @@
 
jdt.loc.2=http://download.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
 
 # - Tomcat native library -
-tomcat-native.version=1.1.19
+tomcat-native.version=1.1.20
 tomcat-native.home=${base.path}/tomcat-native-${tomcat-native.version}
 tomcat-native.tar.gz=${tomcat-native.home}/tomcat-native.tar.gz
 
tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/${tomcat-native.version}/source/tomcat-native-${tomcat-native.version}-src.tar.gz



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2010-02-17 Thread buildbot
The Buildbot has detected a new failure of tomcat-trunk on ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/135

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: 
Build Source Stamp: [branch tomcat/trunk] 910947
Blamelist: markt

BUILD FAILED: failed compile

sincerely,
 -The ASF Buildbot


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-17 Thread sebb
On 17/02/2010, Mladen Turk mt...@apache.org wrote:
 On 02/17/2010 05:12 AM, Konstantin Kolinko wrote:

  2010/2/10 Mladen Turkmt...@apache.org:
 
   Apache Tomcat Native 1.1.20 is:
  
   [x] Stable - no major issues, no regressions
  
 
  Tested win32 binaries only.
 
 
  Minor: *.md5 and *.sha1 files should have  * between checksum and
  filename, because those files are binary.  md5sum/sha1sum that I am
  using were saying that the checksums are wrong without that change.
 
 

  OK. I'll use the `md5sum --binary ...` in the future
  You can do the same however when checking

BTW, it's pretty easy to use Ant to create the hashes.
For example:

target name=_hash unless=hash.skip
echo message=Creating MD5 for ${path}/
basename property=_base file=${path}/
checksum algorithm=MD5 file=${path} property=md5/
echo message=${md5} *${_base} file=${path}.md5/
echo message=Creating SHA for ${path}/
checksum algorithm=SHA file=${path} property=sha/
echo message=${sha} *${_base} file=${path}.sha/
/target


  Regards
  --
  ^TM


 -
  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
  For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910969 - /tomcat/trunk/build.properties.default

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 13:44:28 2010
New Revision: 910969

URL: http://svn.apache.org/viewvc?rev=910969view=rev
Log:
Hold off on update until archive syncs (should be no more than 24 hrs)

Modified:
tomcat/trunk/build.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=910969r1=910968r2=910969view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Feb 17 13:44:28 2010
@@ -76,7 +76,7 @@
 
jdt.loc.2=http://download.eclipse.org/eclipse/downloads/drops/${jdt.release}/ecj-${jdt.version}.jar
 
 # - Tomcat native library -
-tomcat-native.version=1.1.20
+tomcat-native.version=1.1.19
 tomcat-native.home=${base.path}/tomcat-native-${tomcat-native.version}
 tomcat-native.tar.gz=${tomcat-native.home}/tomcat-native.tar.gz
 
tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/${tomcat-native.version}/source/tomcat-native-${tomcat-native.version}-src.tar.gz



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910974 - in /tomcat/trunk/java/org/apache: catalina/startup/Catalina.java juli/ClassLoaderLogManager.java

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 13:51:37 2010
New Revision: 910974

URL: http://svn.apache.org/viewvc?rev=910974view=rev
Log:
Improve logging behaviour when shutdown occurs via a shutdownhook. If present, 
use Catalina's shutdown hook to shutdown Tomcat and JULI. This enables them to 
be shutdown in the correct order.

Modified:
tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Catalina.java?rev=910974r1=910973r2=910974view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Catalina.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Wed Feb 17 
13:51:37 2010
@@ -28,11 +28,13 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.logging.LogManager;
 
 import org.apache.catalina.Container;
 import org.apache.catalina.Lifecycle;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.core.StandardServer;
+import org.apache.juli.ClassLoaderLogManager;
 import org.apache.tomcat.util.digester.Digester;
 import org.apache.tomcat.util.digester.Rule;
 import org.xml.sax.Attributes;
@@ -572,6 +574,15 @@
 shutdownHook = new CatalinaShutdownHook();
 }
 Runtime.getRuntime().addShutdownHook(shutdownHook);
+
+// If JULI is being used, disable JULI's shutdown hook since
+// shutdown hooks run in parallel and log messages may be lost
+// if JULI's hook completes before the CatalinaShutdownHook()
+LogManager logManager = LogManager.getLogManager();
+if (logManager instanceof ClassLoaderLogManager) {
+((ClassLoaderLogManager) logManager).setUseShutdownHook(
+false);
+}
 }
 } catch (Throwable t) {
 // This will fail on JDK 1.2. Ignoring, as Tomcat can run
@@ -652,6 +663,13 @@
 Catalina.this.stop();
 }
 
+// If JULI is used, shut JULI down *after* the server shuts down
+// so log messages aren't lost
+LogManager logManager = LogManager.getLogManager();
+if (logManager instanceof ClassLoaderLogManager) {
+((ClassLoaderLogManager) logManager).shutdown();
+}
+
 }
 
 }

Modified: tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java?rev=910974r1=910973r2=910974view=diff
==
--- tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java (original)
+++ tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java Wed Feb 17 
13:51:37 2010
@@ -50,25 +50,8 @@
 
 @Override
 public void run() {
-// The JVM us being shutdown. Make sure all loggers for all class
-// loaders are shutdown
-for (ClassLoaderLogInfo clLogInfo : classLoaderLoggers.values()) {
-for (Logger logger : clLogInfo.loggers.values()) {
-resetLogger(logger);
-}
-}
-}
-
-private void resetLogger(Logger logger) {
-
-Handler[] handlers = logger.getHandlers();
-for (Handler handler : handlers) {
-logger.removeHandler(handler);
-try {
-handler.close();
-} catch (Exception e) {
-// Ignore
-}
+if (useShutdownHook) {
+shutdown();
 }
 }
 
@@ -105,7 +88,29 @@
  */
 protected ThreadLocalString prefix = new ThreadLocalString();
 
+
+/**
+ * Determines if the shutdown hook is used to perform any necessary
+ * clean-up such as flushing buffered handlers on JVM shutdown. Defaults to
+ * codetrue/code but may be set to false if another component ensures
+ * that 
+ */
+protected boolean useShutdownHook = true;
+
 
+// - Properties
+
+
+public boolean isUseShutdownHook() {
+return useShutdownHook;
+}
+
+
+public void setUseShutdownHook(boolean useShutdownHook) {
+this.useShutdownHook = useShutdownHook;
+}
+
+
 // - Public Methods
 
 
@@ -294,7 +299,35 @@
 readConfiguration(is, Thread.currentThread().getContextClassLoader());
 
 }
+
+
+/**
+ * Shuts down the logging system.
+ */
+public 

buildbot success in ASF Buildbot on tomcat-trunk

2010-02-17 Thread buildbot
The Buildbot has detected a restored build of tomcat-trunk on ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/136

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: 
Build Source Stamp: [branch tomcat/trunk] 910969
Blamelist: markt

Build succeeded!

sincerely,
 -The ASF Buildbot


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r910975 - in /tomcat/trunk/java/org/apache/catalina: manager/ManagerServlet.java startup/Catalina.java

2010-02-17 Thread markt
Author: markt
Date: Wed Feb 17 13:53:08 2010
New Revision: 910975

URL: http://svn.apache.org/viewvc?rev=910975view=rev
Log:
More (minor) lifecycle clean-up

Modified:
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java?rev=910975r1=910974r2=910975view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java Wed Feb 
17 13:53:08 2010
@@ -46,7 +46,6 @@
 import org.apache.catalina.Context;
 import org.apache.catalina.Engine;
 import org.apache.catalina.Host;
-import org.apache.catalina.Lifecycle;
 import org.apache.catalina.Manager;
 import org.apache.catalina.Role;
 import org.apache.catalina.Server;

Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Catalina.java?rev=910975r1=910974r2=910975view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Catalina.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Wed Feb 17 
13:53:08 2010
@@ -31,7 +31,6 @@
 import java.util.logging.LogManager;
 
 import org.apache.catalina.Container;
-import org.apache.catalina.Lifecycle;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.core.StandardServer;
 import org.apache.juli.ClassLoaderLogManager;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JK 1.2.29-dev Available for testing

2010-02-17 Thread Rainer Jung

Hi Mladen,

On 17.02.2010 13:23, Mladen Turk wrote:

On 02/11/2010 12:15 PM, Mladen Turk wrote:


Test snapshot for 1.2.29 is available at
http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/



So far no comments, so I suppose everything works like a charm.
Since we have postponed this release mostly because core
developers are busy bees for a long time,
I plan to tag and propose a release next Monday (Feb 22nd)


thanks for rolling. Did you see BZ 48742, which seems to be a 
show-stopper regression.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911020 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2010-02-17 Thread rjung
Author: rjung
Date: Wed Feb 17 15:32:26 2010
New Revision: 911020

URL: http://svn.apache.org/viewvc?rev=911020view=rev
Log:
BZ48223: Propagate correct backend error code to IIS.

Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=911020r1=911019r2=911020view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Wed Feb 17 15:32:26 2010
@@ -2180,7 +2180,7 @@
 }
 else {
 rc = HSE_STATUS_SUCCESS;
-lpEcb-dwHttpStatusCode = HTTP_STATUS_OK;
+lpEcb-dwHttpStatusCode = s.http_response_status;
 if (JK_IS_DEBUG_LEVEL(logger))
 jk_log(logger, JK_LOG_DEBUG,
service() returned OK);

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=911020r1=911019r2=911020view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Wed Feb 17 15:32:26 2010
@@ -86,6 +86,9 @@
 then 1024 sockets. (mturk)
   /fix
   fix
+bug48223/bug: IIS: Propagate correct backend error code to IIS. 
(rjung)
+  /fix
+  fix
 bug47867/bug: IIS: crash during startup, when compiled with VS2008
 and workers.properties contains unsupported properties.
 Patch provided by Indrek Juhani (rjung)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48223] IIS Logs HTTP status code 200 instead of error code

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48223

Rainer Jung rainer.j...@kippdata.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Rainer Jung rainer.j...@kippdata.de 2010-02-17 15:33:57 
UTC ---
Patch committed in r911020. Will be released with 1.2.29.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JK 1.2.29-dev Available for testing

2010-02-17 Thread Mladen Turk

On 02/17/2010 04:24 PM, Rainer Jung wrote:


thanks for rolling. Did you see BZ 48742, which seems to be a
show-stopper regression.



Nope, didn't see that, and it looks like a regression.
I'll fix that and make another test run on Friday.


Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911062 - /tomcat/jk/trunk/native/common/jk_ajp_common.c

2010-02-17 Thread mturk
Author: mturk
Date: Wed Feb 17 16:38:52 2010
New Revision: 911062

URL: http://svn.apache.org/viewvc?rev=911062view=rev
Log:
Fix BZ48742. Only SEND_BODY_CHUNK is invalid after FORWARD_REQUEST

Modified:
tomcat/jk/trunk/native/common/jk_ajp_common.c

Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_ajp_common.c?rev=911062r1=911061r2=911062view=diff
==
--- tomcat/jk/trunk/native/common/jk_ajp_common.c (original)
+++ tomcat/jk/trunk/native/common/jk_ajp_common.c Wed Feb 17 16:38:52 2010
@@ -1765,13 +1765,13 @@
 JK_TRACE_ENTER(l);
 
 if (ae-last_op == JK_AJP13_FORWARD_REQUEST 
-code != JK_AJP13_SEND_HEADERS) {
+code == JK_AJP13_SEND_BODY_CHUNK) {
 /* We have just send a request but received something
- * that is not response.
+ * that probably originates from buffered response.
  */
  if (JK_IS_DEBUG_LEVEL(l)) {
  jk_log(l, JK_LOG_DEBUG,
-Expecting AJP13_SEND HEADERS, received (%d), code);
+Unexpected AJP13_SEND_BODY_CHUNK);
  }
  JK_TRACE_EXIT(l);
  return JK_AJP13_ERROR;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48742] Can't upload file with mod_jk 1.2.29-dev.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48742

--- Comment #2 from Mladen Turk mt...@apache.org 2010-02-17 16:43:58 UTC ---
Should be fixed in the SVN by the r48742
Can you check the SVN HEAD and confirm that's the case

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48742] Can't upload file with mod_jk 1.2.29-dev.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48742

--- Comment #3 from Mladen Turk mt...@apache.org 2010-02-17 16:45:19 UTC ---
Actually it's fixed in the r911062

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48543] [Patch] More flexibility in specifying -Dcatalina.config

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48543

Rob S. rsli...@sfu.ca changed:

   What|Removed |Added

Summary|More flexibility in |[Patch] More flexibility in
   |specifying  |specifying
   |-Dcatalina.config   |-Dcatalina.config

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: jk/cluster - intelligent systems load

2010-02-17 Thread Costin Manolache
On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turk mt...@apache.org wrote:

 On 02/16/2010 06:57 PM, Costin Manolache wrote:


 I think the main driver for replacing ajp is the 2-directional protocols -
 and if we
 replace it, why invent a new protocol and not just adopt SPDY, which has
 all
 we need.


 Totally agree.
 Both JK and AJP originate from days when the single server behind
 web server was the common topology and when there was no async processing.
 Beside SPDY, which some ASF folks that made a significant contribution
 to the original HTTP specs consider as unperfect, there is BWTP proposal
 (http://bwtp.wikidot.com/)


SPDY has quite a few problems - but it's still an improvement over AJP and
adds
2-directional and mulitplexing to HTTP - which is what we need. The main
problem with a protocol is getting enough critical mass to overcome it's
problems -
HTTP is not perfect either.

The reasons I suggest using SPDY as a replacement for AJP - and supporting
SPDY
out-of-box in tomcat:
- it does what we need
- there is one browser supporting it - and likely to take advantage of it
- probably there will be at least one large domain using it :-)
- There is also a mod_spdy for apache, and I'm sure there will be more.

Regarding problems, my list is not very big:

- requirements for compression and SSL - we don't need this for
apache-tomcat communication.
But it's easy to extend or configure the protocol to skip it / negotiate.

- right now they only want to do it over 443 ( i.e. use CONNECT method ) to
make sure proxies won't
get in the way. Apparently UPDATE doesn't work in some places. That's also
something we can
extend - and seems to be due more to the desire to get something deployed.

- of course - the current next-protocol SSL extension is out of question for
java - which has problems
even with the SSL session ticket. We might be able to support it with
APR/openssl.

- some cosmetic issues - I would prefer protobufs or thrift instead of
yet-another binary format,
sending the url as a header seems strange, binary header could be smaller,
the server push is also
a bit more complex than it should be. I don't think any matters, working
around http is much worse.

- I'm waiting for the flow control to be finalized - but seems reasonable.




 Extending exiting protocols or just doing a 'quick hacks' like I
 see with many projects trying to address those issues will not
 work in the long run. At the end you will be faced with the
 clean drawing board.


There is never a 'clean drawing board', or a perfect protocol. Any new
protocol needs
to be adopted and needs to deal with existing infrastructure - proxies,
blocked ports,
timeouts in NATs, etc.

BWTP doesn't seem so much better - mostly cosmetics. It's also more focused
as a
websocket - not as a browser-proxy-server protocol. And the list of
implementations and
potential adoption matters a lot for protocols.


( BTW: I write this wearing my own hat, my work on tomcat-lite and spdy is
on my own time, etc )

Costin






 Regards
 --
 ^TM

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: jk/cluster - intelligent systems load

2010-02-17 Thread Mladen Turk

On 02/17/2010 07:37 PM, Costin Manolache wrote:

On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turkmt...@apache.org  wrote:


The reasons I suggest using SPDY as a replacement for AJP - and supporting
SPDY


I have nothing against SPDY and it really looks cool,
but IMHO it's doesn't look and feel like the rest of RFC
protocol specifications.
If you can push those guys to create a well known RFC-like
doc, I'm sure that overall internet community will benefit
from it.

OTOH we are discussing this 'protocol thing' for years instead like
you noticed we concentrate on the tasks we wish to do.
Think if we start from the protocol side we will stay there (nowhere)
for few more years (although SPDY might be even more then we need).


Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] New: Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

   Summary: Tomcat breaks in serving large files (=1.8MB) under
high load and high threading.
   Product: Tomcat 6
   Version: 6.0.16
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: arcanef...@gmail.com


When serving a 1.8MB file, Tomcat 6.0.16-6.0.20 (all versions tested), will
occasionally throw a BadFileNumber exception and only serve part of the file.
The rate of occurrence is roughly a few times a day under high load, but we
have stress tools which can reliably reproduce this issue, and multiple
continuous wget connections can reproduce the issue, as well.

We are serving a large SWF application, although this may affect arbitrary
binary data. To reproduce this issue, serve a large file (at least 1.8MB, in
our case), and continuously request the file over a period of several hours to
a few days; this issue happens intermittently, but it is reproducible.

This problem is especially critical to us, as we use apache as a cache in front
of tomcat. For whatever reason, apache aggressively caches this bad data and
never again requests the file, although this is probably another unrelated
problem. In this configuration, however, after the file has gone bad, all users
get served corrupt files, causing the application to break entirely. 

This was reported in 2008 here, but the issue was dismissed:
http://mail-archives.apache.org/mod_mbox/tomcat-dev/200808.mbox/%3cbug-45601...@https.issues.apache.org/bugzilla/%3E

The fix provided here works to resolve the issue, but our IT department cannot
support a custom-rolled version of tomcat indefinitely. It's not a sustainable
solution, and this issue should affect other users. We are not sure why the fix
works, but it does resolve our completely reproducible scenario. Ideally, then,
someone with more knowledge of tomcat could understand why this fix works and
what, exactly, it's solving, and then integrate this into the main tomcat
release line.

Here is how the error appears in the logs:
Feb 16, 2010 1:25:59 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet default threw exception
java.io.IOException: Bad file number
at java.io.FileInputStream.readBytes(Native Method)
at java.io.FileInputStream.read(FileInputStream.java:199)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:256)
at java.io.BufferedInputStream.read(BufferedInputStream.java:317)
at java.io.FilterInputStream.read(FilterInputStream.java:90)
at
org.apache.catalina.servlets.DefaultServlet.copyRange(DefaultServlet.java:1968)
at
org.apache.catalina.servlets.DefaultServlet.copy(DefaultServlet.java:1714)
at
org.apache.catalina.servlets.DefaultServlet.serveResource(DefaultServlet.java:809)
at
org.apache.catalina.servlets.DefaultServlet.doGet(DefaultServlet.java:325)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:568)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at
org.apache.catalina.ha.session.JvmRouteBinderValve.invoke(JvmRouteBinderValve.java:209)
at
org.apache.catalina.ha.tcp.ReplicationValve.invoke(ReplicationValve.java:347)
at
org.terracotta.modules.tomcat.tomcat_5_5.SessionValve55.invoke(SessionValve55.java:57)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
at java.lang.Thread.run(Thread.java:619)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

Stefan Kendall arcanef...@gmail.com changed:

   What|Removed |Added

 CC||arcanef...@gmail.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: jk/cluster - intelligent systems load

2010-02-17 Thread Costin Manolache
On Wed, Feb 17, 2010 at 11:58 AM, Mladen Turk mt...@apache.org wrote:

 On 02/17/2010 07:37 PM, Costin Manolache wrote:

 On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turkmt...@apache.org  wrote:


 The reasons I suggest using SPDY as a replacement for AJP - and supporting
 SPDY


 I have nothing against SPDY and it really looks cool,
 but IMHO it's doesn't look and feel like the rest of RFC
 protocol specifications.
 If you can push those guys to create a well known RFC-like
 doc, I'm sure that overall internet community will benefit
 from it.


SPDY is still in development - there is an open mailing list and
quite a few proposals/changes/discussions. I would guess
the end result will end up as a RFC-like. Feel free to join the
mailing list and push or volunteer for anything :-)

The implementations - chrome, mod_spdy are also open source
and with ASF-like license.




 OTOH we are discussing this 'protocol thing' for years instead like
 you noticed we concentrate on the tasks we wish to do.
 Think if we start from the protocol side we will stay there (nowhere)
 for few more years (although SPDY might be even more then we need).


I think what matters is having a working SPDY implementation in tomcat,
inter-operable
with chrome/mod_spdy/google. If we start with this we'll probably make
more progress than by discussing protocols :-)


Costin




 Regards
 --
 ^TM

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

Remy Maucherat r...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Remy Maucherat r...@apache.org 2010-02-17 22:07:35 UTC ---
An exact duplicate already exists, so no need to open a new bug. Mark's
comments are also perfectly sensible, don't you agree ?

*** This bug has been marked as a duplicate of bug 45601 ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 45601] Static Content Corruption

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45601

Remy Maucherat r...@apache.org changed:

   What|Removed |Added

 CC||arcanef...@gmail.com

--- Comment #2 from Remy Maucherat r...@apache.org 2010-02-17 22:07:35 UTC ---
*** Bug 48760 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 45601] Static Content Corruption

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45601

--- Comment #3 from Mark Thomas ma...@apache.org 2010-02-17 22:23:24 UTC ---
If you see this error then the users list is the best place to figure out what
is going wrong.

I'm quite happy to apply a patch to fix a problem I can't reproduce providing
that:
- there is a logical explanation for a) why the problem is occurring and b) how
the patch addresses it
- the patch is confirmed to fix the issue in an environment where the issue can
be produced
- the patch isn't going to cause a regression for other use cases

If the discussion on the users list can provide satisfactory answers to all of
the above points feel free to re-open this issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #2 from Stefan Kendall arcanef...@gmail.com 2010-02-17 23:04:19 
UTC ---
(In reply to comment #1)
 An exact duplicate already exists, so no need to open a new bug. Mark's
 comments are also perfectly sensible, don't you agree ?
 
 *** This bug has been marked as a duplicate of bug 45601 ***

That bug was resolved invalid, and none of the response comments are helpful or
correct in any way. This IS an issue, and it's reproducible. The original
poster did not give a reproducible scenario, and I believe I have. As such, I
believe that the previous ticket should be reopened with this exact test
scenario as proof of the bug (high load, large binary file), or this ticket
should stay open as it stands.

This bug is critically damaging our successful deployment under Tomcat, and
it's something that needs to be resolved, rather than closed because those
involved don't understand the problem. A reproducible bug is a bug whether it
is understandable or not.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #3 from Mark Thomas ma...@apache.org 2010-02-17 23:17:09 UTC ---
(In reply to comment #2)
 This IS an issue, and it's reproducible.

Being reproducible is not sufficient, on its own, to make it a Tomcat bug.
There are plenty of other possible causes. Please see
https://issues.apache.org/bugzilla/show_bug.cgi?id=45601#c3 and follow the
advice there.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #4 from Stefan Kendall arcanef...@gmail.com 2010-02-17 23:33:50 
UTC ---
(In reply to comment #3)
 (In reply to comment #2)
  This IS an issue, and it's reproducible.
 
 Being reproducible is not sufficient, on its own, to make it a Tomcat bug.
 There are plenty of other possible causes. Please see
 https://issues.apache.org/bugzilla/show_bug.cgi?id=45601#c3 and follow the
 advice there.

The only advice is this:

A Google search suggests that a lack of OS resources could also be a cause of
this error. Given that the environment is highly threaded, and taking this to
also mean highly loaded, this looks more like a JVM/OS issue to me.

Resource usage is next to nothing on the servers I've run against. Furthermore,
even if this is an OS/JVM issue, will you simply drop all claims of support for
Solaris? I've tested against multiple JVM versions, and this does not seem to
affect the performance of Tomcat. This may only be an issue with Solaris, but
if the price of Solaris support is a a negligible performance impact, then
why not implement the fix, noting that it only corrects the Solaris
environment? Not integrating a fix because it should work is absurd from a
practical, 'my-business-application-really-needs-to-work-or-I'll-lose-money'
mindset.

You claim that the fix would exacerbate the issue, which it did not. Clearly,
the issue is not well-enough understood to make such sweeping statements. I do
not have the time to spend the next month researching the internals of Tomcat
and Solaris to understand why this specific test scenario fails repeatedly. As
an pragmatic person, I fail to understand why a clear solution for a popular
server operating system backed by Sun with a slow release cycle with minimal
negative impact would be rejected.

I claim that unless someone can prove that the fix is explicitly harmful, with
actual test data, the fix should be implemented, as it has been proven
explicitly helpful with actual test data.

Is this not a rational argument?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48742] Can't upload file with mod_jk 1.2.29-dev.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48742

--- Comment #4 from Eiji Takahashi mashm...@gmail.com 2010-02-17 23:54:43 UTC 
---
I applied r911062, and verified this issue.
Uploading went well.

Thanks!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48742] Can't upload file with mod_jk 1.2.29-dev.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48742

Eiji Takahashi mashm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #5 from Remy Maucherat r...@apache.org 2010-02-17 23:59:55 UTC ---
What the patch will do is that it disables the content cache, which is used for
small files. As a result, only big files will be accessed, and apparently your
great/mature/stable OS does not like that usage pattern.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #6 from Mark Thomas ma...@apache.org 2010-02-18 00:01:04 UTC ---
https://issues.apache.org/bugzilla/show_bug.cgi?id=45601#c3 sets out the
circumstances under which the patch would be applied and points to a resource
to help figure out the necessary information. If you choose not to go down that
route, that is your choice.

Without an understanding of why the problem occurs and how the patch addresses
it there is no certainty that the root cause will be fixed or that other users
won't see regressions.

Given the patch does address it for you, there are ways to reduce the burden of
running a patched Tomcat version to no more than a couple of minutes of
additional work per upgrade. Again, the users list can help with this.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #7 from Stefan Kendall arcanef...@gmail.com 2010-02-18 00:03:42 
UTC ---
(In reply to comment #5)
 What the patch will do is that it disables the content cache, which is used 
 for
 small files. As a result, only big files will be accessed, and apparently your
 great/mature/stable OS does not like that usage pattern.

I have no particular fondness for Solaris, but I'm not a fool. I understand
that it's a major server OS, and for it to simply not-be-supported is
completely unacceptable. If the benefits of the fix (removes complete breakage)
outweighs the costs of implementing the fix (negligable performance loss,
solvable with bigger hardware?), then I think the fix should be implemented.

Tell me how my argument is incorrect, please.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #8 from Stefan Kendall arcanef...@gmail.com 2010-02-18 00:21:18 
UTC ---
(In reply to comment #6)
 https://issues.apache.org/bugzilla/show_bug.cgi?id=45601#c3 sets out the
 circumstances under which the patch would be applied and points to a resource
 to help figure out the necessary information. If you choose not to go down 
 that
 route, that is your choice.
 
 Without an understanding of why the problem occurs and how the patch addresses
 it there is no certainty that the root cause will be fixed or that other users
 won't see regressions.
 
 Given the patch does address it for you, there are ways to reduce the burden 
 of
 running a patched Tomcat version to no more than a couple of minutes of
 additional work per upgrade. Again, the users list can help with this.

Mark, I will address your concerns in turn.

1.) This is clearly an issue *with Tomcat*. For every person that chooses to
serve a large file through Tomcat, should they also lose months of productivity
to obscure, hard to trace down bugs that have been documented and reproduced?
As network connections and bandwidth continually improve, the chance that
businesses choose to send down bigger, richer files is likely to increase
(think larger images, swfs, etc.). As such, this is clearly an issue if Tomcat
expects to continue being a viable Servlet container. Tomcat solves a number of
problems for a number of people, but if it cannot support the growing trends in
web development (more data, richer data), then surely it will fail. Failing to
address this issue not only hurts the product as a whole, but it sets a
dangerous precedent for all future bug finds.

2.) Would you like performance metrics with a week of constant load, or real
world usage data to confirm my claims? I can provide all of that, but as I am
not a Tomcat developer, I cannot give you a mathematical proof as to why the
fix works. The original posters ideas were discarded, so I cannot say why
exactly the fix works. I do know, however, that for two built deployments of
Tomcat 1.6.16-latest, one with the fix and one without, I can reliably
reproduce the problem on the unpatched version with load generation tools (and
wget), and I cannot reproduce the problem on the patched version (even with 
unrealistically high load).

3.) So then, you agree that there's a simple solution to the root cause of my
problem, and it's a small change to the source base? As an application
developer, I cannot suddenly become responsible for the entirety of the Tomcat
code base. If you extend this scenario, any small problem *you* or *I* can not
understand thoroughly should be self-maintained, correct? As problems increase,
the reliability of the main Tomcat distribution would then become questionable. 

Conclusion:

I submit that unless the problem can be proven harmful (via whatever automated
test systems currently exist, or real life usage data), then the patch should
be implemented. If no such tests exist, or no one can prove the patch harmful
to the stability of Tomcat, then why not implement? There is a strong business
case to implement the patch, and there is a weak case against implementation. 

If this does cause regressions for any party, then they can log an issue as I
did. Remember that the optimization has not always existed, so at some point,
the implementation of the optimization DID cause regressions, but you just
didn't see it. This optimization removal would be an undoing of a -problem-
introduced into the tomcat source in 5.5, rather than an out-of-nowhere fix
that may cause issues. Regressions weren't a concern in 5.5, and they shouldn't
be a concern now, when real data is involved to prove the fix viable and the
previous optimization unstable.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48763] New: AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

   Summary: AJP Connectors fail when POST requests don't have a
Content-Length header
   Product: Tomcat 6
   Version: 6.0.24
  Platform: All
OS/Version: All
Status: NEW
  Severity: major
  Priority: P2
 Component: Connectors
AssignedTo: dev@tomcat.apache.org
ReportedBy: bgstew...@covad.net


This problem occurs with both the Java and APR connectors of the coyote AJP
package. The symptom is, when an AJP connection is reused for multiple POST
requests, sporadic errors occur on the second and subsequent requests.


The classes org.apache.coyote.ajp.AjpProcessor and
org.apache.coyote.ajp.AjpAprProcessor look for a positive value in the
Content-Length header to determine whether to read the first Ajp chunk of a
request body.

The http spec says The presence of a message-body in a request is signaled by
the inclusion of a Content-Length or Transfer-Encoding header field in the
request's header fields. Web service clients generated by Apache Axis2 are one
source of POST requests that have no Content-Length header.

When a client sends a POST request with no Content-Length header, these classes
emit a spurious GET_BODY_CHUNK request on the AJP connection. The first request
on the AJP connection will usually succeed, but for subsequent requests over
the same connection the protocol gets confused, sometimes processing headers as
bodies, and so on.

One symptom of this that I have seen mentioned elsewhere is that web-service
requests are rejected for bad UTF-8 characters.


A patch that worked for me was to change the doRead() method of the
SocketInputBuffer inner-class, to check for the presence of Transfer-Encoding
or Content-Length.

The problem is similar for the Java AJP and the APR AJP, and the same fix seems
to work for both.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48760] Tomcat breaks in serving large files (=1.8MB) under high load and high threading.

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48760

--- Comment #9 from Remy Maucherat r...@apache.org 2010-02-18 00:34:58 UTC ---
Une cacheObjectMaxSize=0 on the Context element and stop wasting your time
posting nonsense ...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911246 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-17 Thread kkolinko
Author: kkolinko
Date: Thu Feb 18 01:59:12 2010
New Revision: 911246

URL: http://svn.apache.org/viewvc?rev=911246view=rev
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911246r1=911245r2=911246view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 01:59:12 2010
@@ -77,7 +77,7 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48613
   Only attempt APR initialization if the Listener has been specified
   http://svn.apache.org/viewvc?rev=904224view=rev
-  +1: fhanik, markt
+  +1: fhanik, markt, kkolinko
   -1: 
 
 * Fix the maven stuff for the maven repo.
@@ -170,9 +170,9 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48616
   This is a regression caused by the fix for
   https://issues.apache.org/bugzilla/show_bug.cgi?id=42390
-  JspFragments are scriptless, so do need to declare or sync scripting
+  JspFragments are scriptless, so no need to declare or sync scripting
   variables for fragments. Since errors in syncing the scripting variables for
-  JSP FRagments caused 48616  42390, this fixes both these bugs too.
+  JSP Fragments caused 48616  42390, this fixes both these bugs too.
   https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c21
   (https://issues.apache.org/bugzilla/attachment.cgi?id=24992)
   +1: kkolinko, markt



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911247 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-17 Thread kkolinko
Author: kkolinko
Date: Thu Feb 18 02:45:18 2010
New Revision: 911247

URL: http://svn.apache.org/viewvc?rev=911247view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911247r1=911246r2=911247view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 02:45:18 2010
@@ -290,8 +290,10 @@
 * More memory leak prevent - ResourceBundle
   http://svn.apache.org/viewvc?rev=909097view=rev (original)
   http://svn.apache.org/viewvc?rev=909525view=rev (improvements)
-  +1: markt
+  +1: markt, kkolinko
   -1: 
+kkolinko: Calling ResourceBundle.clearCache(CL) would work on any Java
+6+ JVM, not only Sun's
 
 * Improvements for WebappClassLoader#clearThreadLocalMap:
   http://svn.apache.org/viewvc?rev=908002view=rev
@@ -341,11 +343,11 @@
   Handle case where WebDAV resource is in directory listing but is not
   accessible
   http://svn.apache.org/viewvc?rev=909636view=rev
-  +1: markt
+  +1: markt, kkolinko
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48371
-  Take acocunt of comments when working out where to insert generated web.xml 
+  Take account of comments when working out where to insert generated web.xml 
   http://people.apache.org/~markt/patches/2010-02-13-bug48371.patch
   +1: markt
   -1: 
@@ -374,7 +376,7 @@
   Prevent AccessControlException if first access is to a JSP that uses a
   FunctionMapper
   http://svn.apache.org/viewvc?rev=910442view=rev
-  +1: markt
+  +1: markt, kkolinko
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48582
@@ -389,6 +391,8 @@
   http://svn.apache.org/viewvc?rev=910485view=rev
   +1: markt
   -1: 
+   kkolinko: mark User constructor as protected, replace ArrayList argument
+with a List, and maybe address sebb's comments to r910485 on dev@
 
 * Various manifest improvements
   
http://people.apache.org/~markt/patches/2010-02-16-manifest-improvements.patch



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: HttpSessionActivationListener sessionDidActivate not called on cluster node startup

2010-02-17 Thread David Rees
Resending to dev - first two posts to users have netted no response.

I've entered a bug, too:
https://issues.apache.org/bugzilla/show_bug.cgi?id=48717

Any ideas, guys?  Having this work would greatly simplify life for me,
but I've looked at the code a bit and can't figure out why it doesn't
work...

-Dave

On Mon, Feb 8, 2010 at 6:46 PM, David Rees dree...@gmail.com wrote:
 Hi,

 I've got an application where I need to keep track of all the active
 user sessions.  Using both the HttpSessionActivationListener +
 HttpSessionListener interfaces seemed like an easy way to be able to
 keep track of all sessions.

 The issue I've come across is that HttpSessionActivationListener
 sessionDidActivate is not called when a node is started up and joins
 or rejoins the cluster so that node loses track of all the existing
 sessions.

 The issue is the same on both Tomcat 6.0.24 and 5.5.28.

 Searching the archives seem seem to turn up the same issue (in fact a
 post from me nearly a year ago when I had the same problem but forgot
 about!).

 I did find an existing bug report, but it was marked fixed way back in 2005.

 https://issues.apache.org/bugzilla/show_bug.cgi?id=35916

 I tried the same configuration as posted there, but still got the same 
 results.

 Anyone got this working or have any suggestions on how to work around
 this issue?

 Thanks

 Dave


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48763] AJP Connectors fail when POST requests don't have a Content-Length header

2010-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48763

--- Comment #1 from Mladen Turk mt...@apache.org 2010-02-18 05:06:08 UTC ---
Are there any chance to see the patch that fixed this for you?

Also which mod_jk you are using. Latest stable (1.2.28) should have
fixed C-L == 0 issues that can lead to the cross context data corruption.
However those fixes mostly address the missing body, not quite all the
C-L == 0 cases, so I'd like to see the patch that solves this.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911255 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-17 Thread mturk
Author: mturk
Date: Thu Feb 18 05:25:01 2010
New Revision: 911255

URL: http://svn.apache.org/viewvc?rev=911255view=rev
Log:
Cast some votest for the stuff I was able to review

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=911255r1=911254r2=911255view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 18 05:25:01 2010
@@ -71,13 +71,13 @@
 * Remove @Deprecated annotations from javax.servlet.jsp.JspContext
   Part of http://svn.apache.org/viewvc?rev=899635view=rev
   
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/JspContext.java?view=diffr1=899634r2=899635pathrev=899635
-  +1: kkolinko, markt
+  +1: kkolinko, markt, mturk
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48613
   Only attempt APR initialization if the Listener has been specified
   http://svn.apache.org/viewvc?rev=904224view=rev
-  +1: fhanik, markt, kkolinko
+  +1: fhanik, markt, kkolinko, mturk
   -1: 
 
 * Fix the maven stuff for the maven repo.
@@ -90,7 +90,7 @@
 
 * Add some debug logging where exceptions where previously swallowed
   http://svn.apache.org/viewvc?rev=904834view=rev
-  +1: markt, kkolinko
+  +1: markt, kkolinko, mturk
   -1:
 
 * Fix various EL TCK failures
@@ -158,7 +158,7 @@
   Provide option to stop server if there is an error during init
   Port of Filip's patch from trunk
   http://svn.apache.org/viewvc?view=revisionrevision=752323
-  +1: markt, kkolinko
+  +1: markt, kkolinko, mturk
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48645
@@ -175,7 +175,7 @@
   JSP Fragments caused 48616  42390, this fixes both these bugs too.
   https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c21
   (https://issues.apache.org/bugzilla/attachment.cgi?id=24992)
-  +1: kkolinko, markt
+  +1: kkolinko, markt, mturk
   -1:
 
 
@@ -183,20 +183,20 @@
   Prevent exception on shutdown
   Port of r896193 and r905343
   http://people.apache.org/~markt/patches/2010-02-01-bug48612.patch
-  +1: markt, kkolinko
+  +1: markt, kkolinko, mturk
   -1: 
   
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48653
   RemoteIpValve : request.secure and request.scheme are not forced to false
   and http if X-Forwarded-Proto=http
   Patch provided by Cyrille Le Clerc
-  +1: markt
+  +1: markt, mturk
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48039
   Return from StandardService.start() immediately if service is already started
   http://svn.apache.org/viewvc?rev=905728view=rev
-  +1: markt, kkolinko
+  +1: markt, kkolinko, mturk
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48050
@@ -263,7 +263,7 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170
   Remove unnecessary syncs that cause issues under load
   http://svn.apache.org/viewvc?rev=907825view=rev
-  +1: markt, kkolinko
+  +1: markt, kkolinko, mturk
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48694
@@ -382,7 +382,7 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48582
   Avoid NPE on background compile
   http://svn.apache.org/viewvc?rev=910471view=rev
-  +1: markt, kkolinko
+  +1: markt, kkolinko, mturk
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48589



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911256 - /tomcat/native/branches/1.1.x/xdocs/index.xml

2010-02-17 Thread mturk
Author: mturk
Date: Thu Feb 18 05:37:46 2010
New Revision: 911256

URL: http://svn.apache.org/viewvc?rev=911256view=rev
Log:
Update remaining 1.1.19 link

Modified:
tomcat/native/branches/1.1.x/xdocs/index.xml

Modified: tomcat/native/branches/1.1.x/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/index.xml?rev=911256r1=911255r2=911256view=diff
==
--- tomcat/native/branches/1.1.x/xdocs/index.xml (original)
+++ tomcat/native/branches/1.1.x/xdocs/index.xml Thu Feb 18 05:37:46 2010
@@ -48,7 +48,7 @@
 lia href=news/2010.html#2010217.117 February 2010 - bTC-Native-1.1.20 
released/b/a
 pThe Apache Tomcat team is proud to announce the immediate availability of 
Tomcat Native 1.1.20 Stable.
 /p
-pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz;TC-native
 1.1.19 release sources/a
+pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz;TC-native
 1.1.20 release sources/a
  | a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/source/tomcat-native-1.1.20-src.tar.gz.asc;PGP
 signature/a
 /p
 pDownload the a 
href=http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/binaries/;binaries/a
 for selected platforms.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r911257 - /tomcat/site/trunk/README.txt

2010-02-17 Thread mturk
Author: mturk
Date: Thu Feb 18 05:50:44 2010
New Revision: 911257

URL: http://svn.apache.org/viewvc?rev=911257view=rev
Log:
Add a quick howto for updating native and connector docs

Modified:
tomcat/site/trunk/README.txt

Modified: tomcat/site/trunk/README.txt
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/README.txt?rev=911257r1=911256r2=911257view=diff
==
--- tomcat/site/trunk/README.txt (original)
+++ tomcat/site/trunk/README.txt Thu Feb 18 05:50:44 2010
@@ -42,3 +42,27 @@
 svn up
 
 to have the changes reflected on the Tomcat web site.
+
+Merging connectors documentation
+
+Tomcat Native and JK connector have their own documentation that
+needs to get updated on release. Beside updating release notes and
+download page that should reflect the current stable, it is needed
+to copy those documents as well.
+Currently this is manual procedure that involves copying connector
+documentation and modifying symbolic links
+
+When releasing Tomcat native create a new native-doc-x.y.z directory
+and upload the documentation created with calling ant inside
+native's xdoc directory.
+Once you have done that update the symlink to point to that new location.
+Inside  /www/tomcat.apache.org/ directory, execute:
+
+ln -sf native-doc-x.y.x native-doc
+
+Similar should be done for JK connector documentation with the exception
+that all symbolic link for the connectors-doc should point to the
+connectors-doc-x.y.z
+
+ln -sf connectors-doc-x.y.x connectors-doc
+



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org