Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 28/02/2012 21:29, Mark Thomas wrote: On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: On 2/28/2012 11:39 AM, Mark Thomas wrote: You may also be able to help with some problems I am having getting non-blocking behaviour between messages with NIO. I'm not 100% clear what is happening

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 11:31, Mark Thomas wrote: On 28/02/2012 21:29, Mark Thomas wrote: On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: On 2/28/2012 11:39 AM, Mark Thomas wrote: You may also be able to help with some problems I am having getting non-blocking behaviour between messages with NIO.

Re: svn commit: r1295286 - in /tomcat/trunk/java/org/apache/catalina/websocket: LocalStrings.properties WsFrame.java

2012-03-01 Thread Mark Thomas
On 01/03/2012 03:56, Konstantin Kolinko wrote: 2012/3/1 ma...@apache.org: Author: markt Date: Wed Feb 29 21:24:59 2012 New Revision: 1295286 snip/ Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java URL:

svn commit: r1295572 - in /tomcat/trunk/java/org/apache/catalina/websocket: LocalStrings.properties WsFrame.java

2012-03-01 Thread markt
Author: markt Date: Thu Mar 1 14:10:44 2012 New Revision: 1295572 URL: http://svn.apache.org/viewvc?rev=1295572view=rev Log: Explicit handling for end of stream. Based on review input from kkolinko Modified: tomcat/trunk/java/org/apache/catalina/websocket/LocalStrings.properties

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
On 3/1/2012 5:33 AM, Mark Thomas wrote: On 01/03/2012 11:31, Mark Thomas wrote: On 28/02/2012 21:29, Mark Thomas wrote: On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: On 2/28/2012 11:39 AM, Mark Thomas wrote: You may also be able to help with some problems I am having getting

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part of Poller.processKey() Thoughts and/or comments? Not knowing the NIO code very well, there might be a better way to achieve the same result that I haven't seen. Mark [1]

Publishing taglibs mini-site

2012-03-01 Thread Jeremy Boynes
Is there any information lying around on how to update the taglibs site? Is taglibs-parent/site.xml actually used or is everything in the site module? What's the process for publishing? Where does it deploy to? Is a vote needed before push? Do we want to preview changes online or is a review

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 15:03, Filip Hanik - Dev Lists wrote: I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part of Poller.processKey() Thoughts and/or comments? Not knowing the NIO code very well, there might be a better way to achieve the same

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
Mark, what buffer size are you referring to increase for the web socket tests to all pass? Filip On 3/1/2012 9:42 AM, Mark Thomas wrote: On 01/03/2012 15:03, Filip Hanik - Dev Lists wrote: I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part

DO NOT REPLY [Bug 52804] New: Make PoolProperties implement Cloneable.

2012-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52804 Bug #: 52804 Summary: Make PoolProperties implement Cloneable. Product: Tomcat Modules Version: unspecified Platform: All OS/Version: All Status: NEW

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 17:13, Filip Hanik - Dev Lists wrote: Mark, what buffer size are you referring to increase for the web socket tests to all pass? Sorry, should have been clearer about that. In o.a.c.websocket.MessageInbound // 2MB - like maxPostSize private int byteBufferMaxSize =

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
I see, MessageInbound has hard coded receive buffers. Got it Filip On 3/1/2012 10:13 AM, Filip Hanik - Dev Lists wrote: Mark, what buffer size are you referring to increase for the web socket tests to all pass? Filip On 3/1/2012 9:42 AM, Mark Thomas wrote: On 01/03/2012 15:03, Filip Hanik

DO NOT REPLY [Bug 52805] New: Update to ECJ 3.7.2

2012-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52805 Bug #: 52805 Summary: Update to ECJ 3.7.2 Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
On 2/28/2012 11:39 AM, Mark Thomas wrote: Thanks for the feedback. You may also be able to help with some problems I am having getting non-blocking behaviour between messages with NIO. I'm not 100% clear what is happening yet, but I think it is something like: - HTTP GET (with upgrade request

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:01, Filip Hanik - Dev Lists wrote: Alright, now that I'm all squared away with Autobahn and test cases running. Is there a specific unit test you have to produce this behavior? That would help me for digging through it. Assuming you are running trunk, then what you'll

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:00, Filip Hanik - Dev Lists wrote: I see, MessageInbound has hard coded receive buffers. Got it They are configurable, they just aren't currently configured. I've been meaning to apply a patch that would add some commented out configuration to the examples webapp so it can just

Re: WebSocket status

2012-03-01 Thread Costin Manolache
On Thu, Mar 1, 2012 at 9:54 AM, Mark Thomas ma...@apache.org wrote: On 01/03/2012 17:13, Filip Hanik - Dev Lists wrote: Mark, what buffer size are you referring to increase for the web socket tests to all pass? Sorry, should have been clearer about that. In o.a.c.websocket.MessageInbound

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:22, Costin Manolache wrote: On Thu, Mar 1, 2012 at 9:54 AM, Mark Thomas ma...@apache.org wrote: On 01/03/2012 17:13, Filip Hanik - Dev Lists wrote: Mark, what buffer size are you referring to increase for the web socket tests to all pass? Sorry, should have been clearer

svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-01 Thread fhanik
Author: fhanik Date: Thu Mar 1 18:27:56 2012 New Revision: 1295724 URL: http://svn.apache.org/viewvc?rev=1295724view=rev Log: Allow the examples to configure the buffer on the fly Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/EchoMessage.java

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:27, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 18:27:56 2012 New Revision: 1295724 URL: http://svn.apache.org/viewvc?rev=1295724view=rev Log: Allow the examples to configure the buffer on the fly Guess you beat me to it. The config needs to be commented out

svn commit: r1295734 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/EchoMessage.java

2012-03-01 Thread markt
Author: markt Date: Thu Mar 1 18:49:38 2012 New Revision: 1295734 URL: http://svn.apache.org/viewvc?rev=1295734view=rev Log: Remove trailing whitespace Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/EchoMessage.java Modified:

svn commit: r1295735 - /tomcat/trunk/webapps/examples/WEB-INF/web.xml

2012-03-01 Thread markt
Author: markt Date: Thu Mar 1 18:50:13 2012 New Revision: 1295735 URL: http://svn.apache.org/viewvc?rev=1295735view=rev Log: Comment out AutoBahn required buffer increase by default Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml Modified:

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #46 from Johno Crawford jo...@sulake.com 2012-03-01 19:13:34 UTC --- Created attachment 28408 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28408 Overrides for connection open and close I am currently working on an

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-01 Thread Filip Hanik - Dev Lists
On 3/1/2012 11:42 AM, Mark Thomas wrote: On 01/03/2012 18:27, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 18:27:56 2012 New Revision: 1295724 URL: http://svn.apache.org/viewvc?rev=1295724view=rev Log: Allow the examples to configure the buffer on the fly Guess you beat me to it.

svn commit: r1295768 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

2012-03-01 Thread fhanik
Author: fhanik Date: Thu Mar 1 20:15:24 2012 New Revision: 1295768 URL: http://svn.apache.org/viewvc?rev=1295768view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=52804 Implement useful interfaces for storing and copying the properties Modified:

DO NOT REPLY [Bug 52804] Make PoolProperties implement Cloneable.

2012-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52804 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: Publishing taglibs mini-site

2012-03-01 Thread Olivier Lamy
euh as there isn't any distributionManagement- site this will go no where Maybe do as I have done for the maven plugin see http://tomcat.apache.org/maven-plugin.html so versionned documentation is published. http://tomcat.apache.org/maven-plugin-${project.version} Pom content: site

[Tomcat Wiki] Update of PageD'Accueil by Roger Mbiama

2012-03-01 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The PageD'Accueil page has been changed by Roger Mbiama: http://wiki.apache.org/tomcat/PageD%27Accueil?action=diffrev1=1rev2=2 ## For more information, please see

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2800 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
hi Mark, sorry, I know you posted this earlier, thanks for reposting it to set me straight. Yes, it can make sense that you see the behavior you are. But in theory you shouldn't. If you call readSocket(false,bytes,off,maxRead), all the socket does is that it checks in the OS socket buffer to

svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-01 Thread fhanik
Author: fhanik Date: Thu Mar 1 23:05:51 2012 New Revision: 1295978 URL: http://svn.apache.org/viewvc?rev=1295978view=rev Log: Fix WebSocket's non blocking call http://tomcat.markmail.org/thread/drj7zgq2csfdnvoh#query:+page:1+mid:y4dheqpm2wx5xzba+state:results Modified:

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2801 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-01 Thread Johno Crawford
On 2/03/2012 12:05 AM, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 23:05:51 2012 New Revision: 1295978 URL: http://svn.apache.org/viewvc?rev=1295978view=rev Log: Fix WebSocket's non blocking call

Re: svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-01 Thread Filip Hanik - Dev Lists
Thanks for that John, I'll fix that too. Filip On 3/1/2012 4:42 PM, Johno Crawford wrote: On 2/03/2012 12:05 AM, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 23:05:51 2012 New Revision: 1295978 URL: http://svn.apache.org/viewvc?rev=1295978view=rev Log: Fix WebSocket's non

svn commit: r1295998 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

2012-03-01 Thread fhanik
Author: fhanik Date: Thu Mar 1 23:46:09 2012 New Revision: 1295998 URL: http://svn.apache.org/viewvc?rev=1295998view=rev Log: Fix access to poller registration Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2802 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #47 from Johno Crawford jo...@sulake.com 2012-03-02 01:57:32 UTC --- (In reply to comment #46) Created attachment 28408 [details] Overrides for connection open and close I am currently working on an example for websockets.

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-03-01 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-03-01 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community