[Bug 54239] Extensible EL Interpreter

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239 --- Comment #18 from Sheldon Shao xs...@ebay.com --- Hi Mark, The code has been refined. Test cases and document also have been provided. Could you please take a look ? -- You are receiving this mail because: You are the assignee for

[Bug 54262] An empty absolute-ordering / should turn off all web-fragments

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54262 --- Comment #3 from Violeta Georgieva violet...@apache.org --- Created attachment 29811 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29811action=edit Patch proposal -- You are receiving this mail because: You are the assignee

[Bug 54262] An empty absolute-ordering / should turn off all web-fragments

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54262 --- Comment #4 from Violeta Georgieva violet...@apache.org --- Created attachment 29812 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29812action=edit Test case -- You are receiving this mail because: You are the assignee for

[Bug 54262] An empty absolute-ordering / should turn off all web-fragments

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54262 --- Comment #5 from Violeta Georgieva violet...@apache.org --- Please find attached a patch proposal and a test case for it. Any comments will be appreciated. Regards Violeta -- You are receiving this mail because: You are the assignee

[Bug 54372] New: Digest Authentication fails on Safari and IE8/9

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54372 Bug ID: 54372 Summary: Digest Authentication fails on Safari and IE8/9 Product: Tomcat 7 Version: 7.0.34 Hardware: Macintosh Status: NEW Severity: normal

[Bug 54372] Digest Authentication fails on Safari and IE8/9

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54372 Johan Borchers jborch...@crimsonwing.com changed: What|Removed |Added OS||All ---

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate-eoln (in module tomcat-7.0.x) failed

2013-01-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate-eoln has an issue affecting its community

[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2013-01-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community

svn commit: r1428869 - /tomcat/trunk/test/org/apache/el/util/Tester.java

2013-01-04 Thread markt
Author: markt Date: Fri Jan 4 14:11:53 2013 New Revision: 1428869 URL: http://svn.apache.org/viewvc?rev=1428869view=rev Log: Fix line endings Modified: tomcat/trunk/test/org/apache/el/util/Tester.java (contents, props changed) Modified: tomcat/trunk/test/org/apache/el/util/Tester.java

svn commit: r1428870 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/el/util/Tester.java

2013-01-04 Thread markt
Author: markt Date: Fri Jan 4 14:13:37 2013 New Revision: 1428870 URL: http://svn.apache.org/viewvc?rev=1428870view=rev Log: Fix line endings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/el/util/Tester.java (contents, props changed)

[Bug 54372] Digest Authentication fails on Safari and IE8/9

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54372 --- Comment #2 from Mark Thomas ma...@apache.org --- The likely suspect is the new lightweight HTTP header parser that we switched to in 7.0.33. The question at the moment is whether it is the parser or the client that is non-spec

[Bug 54372] Digest Authentication fails on Safari and IE8/9

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54372 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1428959 - in /tomcat/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ modules/jdbc-pool/ modules/jdbc-pool/doc/ webapps/manager/WEB-INF/jsp/

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 16:37:54 2013 New Revision: 1428959 URL: http://svn.apache.org/viewvc?rev=1428959view=rev Log: s/2012/2013/g Modified: tomcat/trunk/NOTICE tomcat/trunk/java/org/apache/catalina/manager/Constants.java

svn commit: r1428969 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ modules/jdbc-pool/ modules/jdbc-pool/doc/ webapps/manager/WEB-INF/jsp/

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 16:45:13 2013 New Revision: 1428969 URL: http://svn.apache.org/viewvc?rev=1428969view=rev Log: s/2012/2013/g Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/NOTICE

svn commit: r1428973 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ webapps/docs/tribes/ webapps/manager/WEB-INF/jsp/

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 16:53:02 2013 New Revision: 1428973 URL: http://svn.apache.org/viewvc?rev=1428973view=rev Log: s/2012/2013/g Modified: tomcat/tc6.0.x/trunk/NOTICE tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/Constants.java

svn commit: r1428977 - in /tomcat/site/trunk/xdocs: legal.xml stylesheets/tomcat-site.xsl stylesheets/tomcat.css

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 16:57:22 2013 New Revision: 1428977 URL: http://svn.apache.org/viewvc?rev=1428977view=rev Log: s/2012/2013/g Modified: tomcat/site/trunk/xdocs/legal.xml tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl

svn commit: r1428985 - in /tomcat/site/trunk: README.txt build.properties.default build.xml

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 17:04:58 2013 New Revision: 1428985 URL: http://svn.apache.org/viewvc?rev=1428985view=rev Log: Remove support for Tomcat 5 from the site build script Modified: tomcat/site/trunk/README.txt tomcat/site/trunk/build.properties.default

svn commit: r1428988 - in /tomcat/site/trunk: ./ docs/ docs/stylesheets/

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 17:10:55 2013 New Revision: 1428988 URL: http://svn.apache.org/viewvc?rev=1428988view=rev Log: Regenerate the site after year update Several pages (such as ci.html) still had Tomcat 5.5 in their menus. It is now fixed. Fix indent in README.txt Modified:

svn commit: r1428993 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 17:32:18 2013 New Revision: 1428993 URL: http://svn.apache.org/viewvc?rev=1428993view=rev Log: Review of r1428643 Align implememntation between IS_SECURITY_ENABLED true and false branches (essentially add i18n to the IS_SECURITY_ENABLED==true branch). Add the

Seeking guidance on use of apache commons classes

2013-01-04 Thread Brian Burch
On 29/11/12 16:11, Brian Burch wrote: On 29/11/12 14:37, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly Mark Thomas ma...@apache.org changed: What

Re: Seeking guidance on use of apache commons classes

2013-01-04 Thread Konstantin Kolinko
2013/1/4 Brian Burch br...@pingtoo.com: On 29/11/12 16:11, Brian Burch wrote: On 29/11/12 14:37, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly Mark Thomas

Re: Seeking guidance on use of apache commons classes

2013-01-04 Thread Mark Thomas
On 04/01/2013 19:58, Konstantin Kolinko wrote: 2013/1/4 Brian Burch br...@pingtoo.com: On 29/11/12 16:11, Brian Burch wrote: Once I got there, I discovered that org.apache.catalina.util.Base64 doesn't currently have any methods to decode a StringReader or String object. HTTP headers are

svn commit: r1429123 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java

2013-01-04 Thread markt
Author: markt Date: Fri Jan 4 20:55:34 2013 New Revision: 1429123 URL: http://svn.apache.org/viewvc?rev=1429123view=rev Log: Make HTTP DIGEST authentication header parsing tolerant of known buggy clients. Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

svn commit: r1429124 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java webapps/docs/changelog.

2013-01-04 Thread markt
Author: markt Date: Fri Jan 4 21:01:00 2013 New Revision: 1429124 URL: http://svn.apache.org/viewvc?rev=1429124view=rev Log: Make HTTP DIGEST authentication header parsing tolerant of known buggy clients. Modified: tomcat/tc7.0.x/trunk/ (props changed)

[Bug 54338] Class cast exception in tagPlugin Set generated code

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54338 Mark Thomas ma...@apache.org changed: What|Removed |Added Attachment #29786|application/octet-stream|text/plain

[Bug 54338] Class cast exception in tagPlugin Set generated code

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54338 --- Comment #4 from Mark Thomas ma...@apache.org --- It is not a question of what is appropriate or what is best, the JSTL specification requires that an EL coerce is used. I'm looking at this now. The test case is going to need some work.

buildbot failure in ASF Buildbot on tomcat-trunk

2013-01-04 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3720 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1429153 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Set.java

2013-01-04 Thread markt
Author: markt Date: Fri Jan 4 22:04:04 2013 New Revision: 1429153 URL: http://svn.apache.org/viewvc?rev=1429153view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54338 Correctly coerce the value to the expected type when using the tag plug-in for the JSTL set tag Modified:

svn commit: r1429156 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/tagplugins/jstl/core/Set.java webapps/docs/changelog.xml

2013-01-04 Thread markt
Author: markt Date: Fri Jan 4 22:08:43 2013 New Revision: 1429156 URL: http://svn.apache.org/viewvc?rev=1429156view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54338 Correctly coerce the value to the expected type when using the tag plug-in for the JSTL set tag. Patch

[Bug 54338] Class cast exception in tagPlugin Set generated code

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54338 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 54340] Form-based authentication + url rewriting does not work

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54340 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 53584] Forms authentication without cookies requires double submission in 6.0.33

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53584 Mark Thomas ma...@apache.org changed: What|Removed |Added CC||k...@emweb.be ---

[Bug 54361] Deploy release zip to Maven repository

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54361 --- Comment #2 from Mark Thomas ma...@apache.org --- Putting full binaries in a Maven repo still seems wrong to me. That said, managing the central repo is not my problem and - based on the presence of a number of binaries for a range of

[Bug 54361] Deploy release zip to Maven repository

2013-01-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54361 Mark Thomas ma...@apache.org changed: What|Removed |Added Attachment #29799|0 |1 is

[OT] Patch mime-type in Bugzilla (was: Bug 54361)

2013-01-04 Thread Konstantin Kolinko
2013/1/5 bugzi...@apache.org: https://issues.apache.org/bugzilla/show_bug.cgi?id=54361 Mark Thomas ma...@apache.org changed: What|Removed |Added Attachment #29799|0

buildbot success in ASF Buildbot on tomcat-trunk

2013-01-04 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3721 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1429167 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java

2013-01-04 Thread kkolinko
Author: kkolinko Date: Fri Jan 4 23:13:00 2013 New Revision: 1429167 URL: http://svn.apache.org/viewvc?rev=1429167view=rev Log: Further review of ApplicationFilterConfig. Inline the setFilterDef() method. In the constructor the filterDef is never null and there is no need to care about

Re: Seeking guidance on use of apache commons classes

2013-01-04 Thread Brian Burch
On 04/01/13 19:58, Konstantin Kolinko wrote: 2013/1/4 Brian Burch br...@pingtoo.com: On 29/11/12 16:11, Brian Burch wrote: On 29/11/12 14:37, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not

svn commit: r1429172 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationFilterConfig.java webapps/docs/changelog.xml

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 00:07:05 2013 New Revision: 1429172 URL: http://svn.apache.org/viewvc?rev=1429172view=rev Log: Merged revisions r1428993 r1429167 from tomcat/trunk: Followup to r1428645 1. in ApplicationFilterConfig.release(): Align implementation between

svn commit: r1429173 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 00:38:08 2013 New Revision: 1429173 URL: http://svn.apache.org/viewvc?rev=1429173view=rev Log: When running with a SecurityManager, make sure that reference to a Servlet instance is removed from a static cache when its init() or destroy() methods fail.

svn commit: r1429179 - /tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 01:04:56 2013 New Revision: 1429179 URL: http://svn.apache.org/viewvc?rev=1429179view=rev Log: Simplify, as the method names are case-sensitive. Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java Modified:

svn commit: r1429180 - /tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 01:10:57 2013 New Revision: 1429180 URL: http://svn.apache.org/viewvc?rev=1429180view=rev Log: Simplify. We are returning null on failure, so there is no need to check whether it is not-null before returning it. Modified:

svn commit: r1429182 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 01:33:20 2013 New Revision: 1429182 URL: http://svn.apache.org/viewvc?rev=1429182view=rev Log: Fix wrong argument of StandardWrapper.remove() in case when singleThreadModel and instancePool are used. Modified:

svn commit: r1429186 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardWrapper.java webapps/docs/changelog.xml

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 01:43:28 2013 New Revision: 1429186 URL: http://svn.apache.org/viewvc?rev=1429186view=rev Log: Merged revisions r1429173 r1429182 from tomcat/trunk: Fix leak of servlet instances when running with SecurityManager: a) In case when initServlet() or destroy() fail.

svn commit: r1429192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-01-04 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 02:01:36 2013 New Revision: 1429192 URL: http://svn.apache.org/viewvc?rev=1429192view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: