svn commit: r1717530 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java

Author: markt Date: Tue Dec 1 21:06:20 2015 New Revision: 1717530 URL: http://svn.apache.org/viewvc?rev=1717530=rev Log: Attempt to fix a Gump issue Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java

[Bug 58657] Spring DeferredResult errorResult response not returned in async servlet 3.1 mode

https://bz.apache.org/bugzilla/show_bug.cgi?id=58657 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1717517 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/config/context.xml webapps/docs

Author: markt Date: Tue Dec 1 20:32:52 2015 New Revision: 1717517 URL: http://svn.apache.org/viewvc?rev=1717517=rev Log: Review comments from kkolinko for useRelativeRedirects implementation Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1717515 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/config/context.xml webapps/docs/config/sys

Author: markt Date: Tue Dec 1 20:32:15 2015 New Revision: 1717515 URL: http://svn.apache.org/viewvc?rev=1717515=rev Log: Review comments from kkolinko for useRelativeRedirects implementation Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

svn commit: r1717523 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

Author: markt Date: Tue Dec 1 20:46:03 2015 New Revision: 1717523 URL: http://svn.apache.org/viewvc?rev=1717523=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58657 Exceptions in the Servlet 3.1 [Read|Write]Listener do not need to be immediately fatal to the connection. Allow an

[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled

https://bz.apache.org/bugzilla/show_bug.cgi?id=57489 --- Comment #15 from Mark Thomas --- I can't reproduce this using the current 8.0.x code. There is a fix that looks related: bug 58624 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled

https://bz.apache.org/bugzilla/show_bug.cgi?id=57489 Mark Thomas changed: What|Removed |Added Status|REOPENED|NEEDINFO -- You are

svn commit: r1717528 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java

Author: markt Date: Tue Dec 1 21:05:15 2015 New Revision: 1717528 URL: http://svn.apache.org/viewvc?rev=1717528=rev Log: Attempt to fix a Gump issue Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java Modified:

svn commit: r1717548 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_30: ./ build.properties.default webapps/docs/changelog.xml

Author: markt Date: Tue Dec 1 22:28:34 2015 New Revision: 1717548 URL: http://svn.apache.org/viewvc?rev=1717548=rev Log: Tag 8.0.30 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_30/ (props changed) - copied from r1717545, tomcat/tc8.0.x/trunk/ Modified:

svn commit: r1717547 - /tomcat/tc8.0.x/tags/TOMAT_8_0_30/

Author: markt Date: Tue Dec 1 22:28:21 2015 New Revision: 1717547 URL: http://svn.apache.org/viewvc?rev=1717547=rev Log: Wrong name Removed: tomcat/tc8.0.x/tags/TOMAT_8_0_30/ - To unsubscribe, e-mail:

svn commit: r1717529 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java

Author: markt Date: Tue Dec 1 21:05:49 2015 New Revision: 1717529 URL: http://svn.apache.org/viewvc?rev=1717529=rev Log: Attempt to fix a Gump issue Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java

svn commit: r1717520 - /tomcat/trunk/webapps/docs/changelog.xml

Author: markt Date: Tue Dec 1 20:38:12 2015 New Revision: 1717520 URL: http://svn.apache.org/viewvc?rev=1717520=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1717546 - in /tomcat/tc8.0.x/tags/TOMAT_8_0_30: ./ build.properties.default webapps/docs/changelog.xml

Author: markt Date: Tue Dec 1 22:26:20 2015 New Revision: 1717546 URL: http://svn.apache.org/viewvc?rev=1717546=rev Log: Tag 8.0.30 Added: tomcat/tc8.0.x/tags/TOMAT_8_0_30/ (props changed) - copied from r1717545, tomcat/tc8.0.x/trunk/ Modified:

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #17 from Mark Thomas --- Review comments fixed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

svn commit: r1717518 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/config/context.xml webapps/docs

Author: markt Date: Tue Dec 1 20:33:57 2015 New Revision: 1717518 URL: http://svn.apache.org/viewvc?rev=1717518=rev Log: Review comments from kkolinko for useRelativeRedirects implementation Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r11394 [1/2] - in /dev/tomcat/tomcat-8/v8.0.30: ./ bin/ bin/embed/ bin/extras/ src/

Author: markt Date: Tue Dec 1 22:56:03 2015 New Revision: 11394 Log: Upload 8.0.30 ready for voting. Added: dev/tomcat/tomcat-8/v8.0.30/ dev/tomcat/tomcat-8/v8.0.30/KEYS (with props) dev/tomcat/tomcat-8/v8.0.30/README.html (with props)

svn commit: r11393 - /release/tomcat/tomcat-8/v8.0.28/

Author: markt Date: Tue Dec 1 22:37:50 2015 New Revision: 11393 Log: Remove 8.0.28 from mirrors Removed: release/tomcat/tomcat-8/v8.0.28/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

svn commit: r11394 [2/2] - in /dev/tomcat/tomcat-8/v8.0.30: ./ bin/ bin/embed/ bin/extras/ src/

Added: dev/tomcat/tomcat-8/v8.0.30/bin/extras/catalina-ws.jar.asc == --- dev/tomcat/tomcat-8/v8.0.30/bin/extras/catalina-ws.jar.asc (added) +++ dev/tomcat/tomcat-8/v8.0.30/bin/extras/catalina-ws.jar.asc Tue Dec 1

[VOTE] Release Apache Tomcat 8.0.30

The proposed Apache Tomcat 8.0.30 release is now available for voting. The main changes since 8.0.29 are: - Location headers for redirects now use relative URIs. This can be controlled by Context with the useRelativeRedirects attribute. - Correct a regression in 8.0.29 that broke redirects

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #16 from Konstantin Kolinko --- Thank you. Minor things 1. JMX 2. As Servlet Specification javadoc [1] explicitly says "servlet container must convert the relative URL to an absolute URL before sending

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.

[GitHub] tomcat pull request:

Github user shenjie1993 commented on the pull request: https://github.com/apache/tomcat/commit/548d60449a40248e9b7fb2a8103a5e4419d6c290#commitcomment-14726647 why we should maintain three StringManager in catalina.tribes.util, naming and tomcat.util.res, or why we need special

[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled

https://bz.apache.org/bugzilla/show_bug.cgi?id=57489 Barry Coughlan changed: What|Removed |Added Resolution|FIXED |---

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/213 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1717388 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apache/catalina/websocket/ webapps/ex

Author: violetagg Date: Tue Dec 1 08:34:55 2015 New Revision: 1717388 URL: http://svn.apache.org/viewvc?rev=1717388=rev Log: Merged revision 1717385 from tomcat/trunk: Fixed findbugs issues Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1717392 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

Author: markt Date: Tue Dec 1 09:20:22 2015 New Revision: 1717392 URL: http://svn.apache.org/viewvc?rev=1717392=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Modified:

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r1717386 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apache/catalina/valves/rewrite/ java/

Author: violetagg Date: Tue Dec 1 08:17:31 2015 New Revision: 1717386 URL: http://svn.apache.org/viewvc?rev=1717386=rev Log: Merged revision 1717385 from tomcat/trunk: Fixed findbugs issues Modified: tomcat/tc8.0.x/trunk/ (props changed)

[Bug 58655] IllegalStateException: calling HttpServletResponse#sendRedirect() with RemoteIpFilter

https://bz.apache.org/bugzilla/show_bug.cgi?id=58655 --- Comment #6 from Cristian Klein --- Are you sure this works? The "Location" header eventually has to contain the absolute URL. [1] If this is left to the "non-RemoteIpFilter" code, wouldn't the scheme be filled

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #13 from Mark Thomas --- It appears that ProxyPassReverse only rewrites absolute URLs. That will be a problem for redirects of the form /some/path Tomcat generates redirects like this in a few places and we can

[Bug 58655] IllegalStateException: calling HttpServletResponse#sendRedirect() with RemoteIpFilter

https://bz.apache.org/bugzilla/show_bug.cgi?id=58655 --- Comment #7 from Mark Thomas --- RFC2616 is obsolete. See RFC7231. -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 58657] Spring DeferredResult errorResult response not returned in async servlet 3.1 mode

https://bz.apache.org/bugzilla/show_bug.cgi?id=58657 --- Comment #10 from Mark Thomas --- A little more information for anyone researching this in the future. Once Tomcat encounters an error, it normally closes the connection. How quickly it does this depends on the severity

svn commit: r1717445 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Author: markt Date: Tue Dec 1 15:18:09 2015 New Revision: 1717445 URL: http://svn.apache.org/viewvc?rev=1717445=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58657 Exceptions in the Servlet 3.1 [Read|Write]Listener do not need to be immediately fatal to the connection. Allow an

svn commit: r1717418 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/ test/org

Author: markt Date: Tue Dec 1 13:00:14 2015 New Revision: 1717418 URL: http://svn.apache.org/viewvc?rev=1717418=rev Log: Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 Make relative redirects configurable Modified: tomcat/trunk/java/org/apache/catalina/Context.java

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #14 from Mark Thomas --- I can get Tomcat to send a suitable relative redirect for directories but not context roots. I don't see a way around this. Any relative redirect from from /foo to /foo/ is going to have

svn commit: r1717422 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyot

Author: markt Date: Tue Dec 1 13:07:02 2015 New Revision: 1717422 URL: http://svn.apache.org/viewvc?rev=1717422=rev Log: Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 Make relative redirects configurable Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1717416 - in /tomcat/trunk: build.properties.default webapps/docs/changelog.xml

Author: kkolinko Date: Tue Dec 1 12:56:45 2015 New Revision: 1717416 URL: http://svn.apache.org/viewvc?rev=1717416=rev Log: Update to Checkstyle 6.13 Modified: tomcat/trunk/build.properties.default tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/build.properties.default

svn commit: r1717419 - in /tomcat/tc8.0.x/trunk: ./ build.properties.default webapps/docs/changelog.xml

Author: kkolinko Date: Tue Dec 1 13:01:43 2015 New Revision: 1717419 URL: http://svn.apache.org/viewvc?rev=1717419=rev Log: Update to Checkstyle 6.13 Merged r1717416 from tomcat/trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/build.properties.default

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1717421 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyot

Author: markt Date: Tue Dec 1 13:04:50 2015 New Revision: 1717421 URL: http://svn.apache.org/viewvc?rev=1717421=rev Log: Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 Make relative redirects configurable Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1717439 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

Author: markt Date: Tue Dec 1 13:34:47 2015 New Revision: 1717439 URL: http://svn.apache.org/viewvc?rev=1717439=rev Log: Make socket final Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Modified:

buildbot success in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/214 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58655] IllegalStateException: calling HttpServletResponse#sendRedirect() with RemoteIpFilter

https://bz.apache.org/bugzilla/show_bug.cgi?id=58655 --- Comment #8 from Konstantin Kolinko --- Is there a reason why one uses RemoteIpFilter ? There exists a RemoteIpValve that can be used instead. 1. There are redirects that are performed before a request reaches the