[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497

--- Comment #7 from Wai-Kau Lo  ---
Created attachment 34543
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34543=edit
Test web application

Attached is a self-contained web application that can be used to replicate the
issue.

After deploying the test.war file on a Tomcat Server of version 8.5.5 (or
higher up to 8.5.9), access the following two URLs in sequence:

1) http://localhost:8080/test/test/page1.jsp
You will receive a NullPointerException from page2.jsp as expected.
java.lang.NullPointerException
org.apache.jsp.test.page2_jsp._jspService(page2_jsp.java:151)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)



2) http://localhost:8080/test/test/page1.jsp?childName=name
Instead of the expected response shown below

Parent Name: Parent1 
Child Name: name contains 4 characters

you will receive the following JspException:
javax.servlet.jsp.JspException: No getter method for property: "children" of
bean: "form"
org.apache.struts.taglib.TagUtils.lookup(TagUtils.java:987)
   
org.apache.struts.taglib.logic.IterateTag.doStartTag(IterateTag.java:232)
   
org.apache.struts.taglib.nested.logic.NestedIterateTag.doStartTag(NestedIterateTag.java:73)
org.apache.jsp.test.page2_jsp._jspService(page2_jsp.java:135)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
..

This is caused by the "corrupted" nested:iterate tag instance cached in the tag
pool after processing the first URL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1775535 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread Mark Thomas
On 21/12/2016 19:06, csuth...@apache.org wrote:
> Author: csutherl
> Date: Wed Dec 21 19:06:02 2016
> New Revision: 1775535
> 
> URL: http://svn.apache.org/viewvc?rev=1775535=rev
> Log:
> Reverting change for EE reference, 8 was right

Thanks.

Mark


> 
> Modified:
> tomcat/site/trunk/docs/whichversion.html
> 
> Modified: tomcat/site/trunk/docs/whichversion.html
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775535=1775534=1775535=diff
> ==
> --- tomcat/site/trunk/docs/whichversion.html (original)
> +++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 19:06:02 2016
> @@ -451,7 +451,7 @@ builds on Tomcat 8.0.x and implements th
>  4.0 specification and will also implement the
>  JSP 2.4?, EL 3.1?, WebSocket 1.2?
>   and JASPIC 1.1  specifications once work starts 
> on 
> -updating those specifications for Java EE 9. In addition to this, it 
> includes 
> +updating those specifications for Java EE 8. In addition to this, it 
> includes 
>  the following significant improvements:
>  
>  
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1775522 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread csutherl
Author: csutherl
Date: Wed Dec 21 18:14:56 2016
New Revision: 1775522

URL: http://svn.apache.org/viewvc?rev=1775522=rev
Log:
Adding missing JASPIC spec implementation note for tomcat 8.5

Modified:
tomcat/site/trunk/docs/whichversion.html

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775522=1775521=1775522=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:14:56 2016
@@ -486,6 +486,14 @@ to that, it includes the following signi
 
 
 
+
+Apache Tomcat 8.5.x supports the same Servlet, JSP, EL, and
+Web Socket Specification versions as Apache Tomcat 8.0.x. In addition to that, 
+it also implements the JASPIC 1.1 specification. There are 
+significant changes in many areas under the hood, resulting in improved 
+performance, stability, and total cost of ownership.  Please refer to the 
+Apache Tomcat 8.5 Changelog for details.
+
 
 
 Apache Tomcat 7.x



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1775524 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread csutherl
Author: csutherl
Date: Wed Dec 21 18:21:52 2016
New Revision: 1775524

URL: http://svn.apache.org/viewvc?rev=1775524=rev
Log:
Updating instances of 'Web Socket' to remove the space and correctly state 
'WebSocket' which is consistent with the table at the top of this page and the 
spec

Modified:
tomcat/site/trunk/docs/whichversion.html

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775524=1775523=1775524=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:21:52 2016
@@ -449,7 +449,7 @@ run stably for extended periods of time.
 Apache Tomcat 9.x is the current focus of development, it
 builds on Tomcat 8.0.x and implements the current draft of the Servlet
 4.0 specification and will also implement the
-JSP 2.4?, EL 3.1?, Web Socket 1.2?
+JSP 2.4?, EL 3.1?, WebSocket 1.2?
  and JASPIC 1.1  specifications once work starts on 
 updating those specifications for Java EE 9. In addition to this, it includes 
 the following significant improvements:
@@ -475,7 +475,7 @@ the following significant improvements:
 
 Apache Tomcat 8.x builds on Tomcat 7.0.x and implements the
 Servlet 3.1, JSP 2.3, EL 3.0
-and Web Socket 1.1 specifications. In addition
+and WebSocket 1.1 specifications. In addition
 to that, it includes the following significant improvements:
 
 
@@ -488,7 +488,7 @@ to that, it includes the following signi
 
 
 Apache Tomcat 8.5.x supports the same Servlet, JSP, EL, and
-Web Socket Specification versions as Apache Tomcat 8.0.x. In addition to that, 
+WebSocket Specification versions as Apache Tomcat 8.0.x. In addition to that, 
 it also implements the JASPIC 1.1 specification. There are 
 significant changes in many areas under the hood, resulting in improved 
 performance, stability, and total cost of ownership.  Please refer to the 
@@ -504,7 +504,7 @@ Apache Tomcat 8.5 Changelog for details.
 Apache Tomcat 7.x builds upon the improvements made in
 Tomcat 6.0.x and implements the Servlet 3.0,
 JSP 2.2, EL 2.2 and
-Web Socket 1.1 specifications. In addition
+WebSocket 1.1 specifications. In addition
 to that, it includes the following improvements:
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread csutherl
Author: csutherl
Date: Wed Dec 21 18:18:32 2016
New Revision: 1775523

URL: http://svn.apache.org/viewvc?rev=1775523=rev
Log:
Added missing JASPIC spec implementation note for tomcat 9.0 and updated an 
incorrect reference to Java EE 8.

Modified:
tomcat/site/trunk/docs/whichversion.html

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775523=1775522=1775523=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:18:32 2016
@@ -449,10 +449,10 @@ run stably for extended periods of time.
 Apache Tomcat 9.x is the current focus of development, it
 builds on Tomcat 8.0.x and implements the current draft of the Servlet
 4.0 specification and will also implement the
-JSP 2.4?, EL 3.1? and
-Web Socket 1.2? specifications once work starts on updating
-those specifications for Java EE 8. In addition to this, it includes the
-following significant improvements:
+JSP 2.4?, EL 3.1?, Web Socket 1.2?
+ and JASPIC 1.1  specifications once work starts on 
+updating those specifications for Java EE 9. In addition to this, it includes 
+the following significant improvements:
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread Mark Thomas
On 21/12/2016 18:18, csuth...@apache.org wrote:
> Author: csutherl
> Date: Wed Dec 21 18:18:32 2016
> New Revision: 1775523
> 
> URL: http://svn.apache.org/viewvc?rev=1775523=rev
> Log:
> Added missing JASPIC spec implementation note for tomcat 9.0 and updated an 
> incorrect reference to Java EE 8.

That reference is correct. Tomcat 9 implements specs from Java EE 8.
There has been little to no movement on a number of specs. Based on past
experience there may be some last minute maintenance releases just
before javaEE 8 goes final.

Mark


> 
> Modified:
> tomcat/site/trunk/docs/whichversion.html
> 
> Modified: tomcat/site/trunk/docs/whichversion.html
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775523=1775522=1775523=diff
> ==
> --- tomcat/site/trunk/docs/whichversion.html (original)
> +++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:18:32 2016
> @@ -449,10 +449,10 @@ run stably for extended periods of time.
>  Apache Tomcat 9.x is the current focus of development, it
>  builds on Tomcat 8.0.x and implements the current draft of the 
> Servlet
>  4.0 specification and will also implement the
> -JSP 2.4?, EL 3.1? and
> -Web Socket 1.2? specifications once work starts on updating
> -those specifications for Java EE 8. In addition to this, it includes the
> -following significant improvements:
> +JSP 2.4?, EL 3.1?, Web Socket 1.2?
> + and JASPIC 1.1  specifications once work starts 
> on 
> +updating those specifications for Java EE 9. In addition to this, it 
> includes 
> +the following significant improvements:
>  
>  
>  
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread Coty Sutherland
> That reference is correct. Tomcat 9 implements specs from Java EE 8.

Ah, I'll fix it. Sorry.

On Wed, Dec 21, 2016 at 2:00 PM, Mark Thomas  wrote:
> On 21/12/2016 18:18, csuth...@apache.org wrote:
>> Author: csutherl
>> Date: Wed Dec 21 18:18:32 2016
>> New Revision: 1775523
>>
>> URL: http://svn.apache.org/viewvc?rev=1775523=rev
>> Log:
>> Added missing JASPIC spec implementation note for tomcat 9.0 and updated an 
>> incorrect reference to Java EE 8.
>
> That reference is correct. Tomcat 9 implements specs from Java EE 8.
> There has been little to no movement on a number of specs. Based on past
> experience there may be some last minute maintenance releases just
> before javaEE 8 goes final.
>
> Mark
>
>
>>
>> Modified:
>> tomcat/site/trunk/docs/whichversion.html
>>
>> Modified: tomcat/site/trunk/docs/whichversion.html
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775523=1775522=1775523=diff
>> ==
>> --- tomcat/site/trunk/docs/whichversion.html (original)
>> +++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:18:32 2016
>> @@ -449,10 +449,10 @@ run stably for extended periods of time.
>>  Apache Tomcat 9.x is the current focus of development, it
>>  builds on Tomcat 8.0.x and implements the current draft of the 
>> Servlet
>>  4.0 specification and will also implement the
>> -JSP 2.4?, EL 3.1? and
>> -Web Socket 1.2? specifications once work starts on updating
>> -those specifications for Java EE 8. In addition to this, it includes the
>> -following significant improvements:
>> +JSP 2.4?, EL 3.1?, Web Socket 1.2?
>> + and JASPIC 1.1  specifications once work starts 
>> on
>> +updating those specifications for Java EE 9. In addition to this, it 
>> includes
>> +the following significant improvements:
>>  
>>
>>  
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1775535 - /tomcat/site/trunk/docs/whichversion.html

2016-12-21 Thread csutherl
Author: csutherl
Date: Wed Dec 21 19:06:02 2016
New Revision: 1775535

URL: http://svn.apache.org/viewvc?rev=1775535=rev
Log:
Reverting change for EE reference, 8 was right

Modified:
tomcat/site/trunk/docs/whichversion.html

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775535=1775534=1775535=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 19:06:02 2016
@@ -451,7 +451,7 @@ builds on Tomcat 8.0.x and implements th
 4.0 specification and will also implement the
 JSP 2.4?, EL 3.1?, WebSocket 1.2?
  and JASPIC 1.1  specifications once work starts on 
-updating those specifications for Java EE 9. In addition to this, it includes 
+updating those specifications for Java EE 8. In addition to this, it includes 
 the following significant improvements:
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JASPIC Specification info missing from a few places

2016-12-21 Thread Mark Thomas
On 21/12/2016 19:33, Coty Sutherland wrote:
> Hi all,
> 
> I've been looking at the specifications listings on the
> whichversions.html page and noticed JASPIC was missing, but is
> implemented in 8.5+. I've added it on the site, but then I noticed
> that it's also missing from the specifications page here:
> https://wiki.apache.org/tomcat/Specifications. I don't think I have
> access to the wiki, can someone fix that?

Yes. We need you MoinMoin ID for the Tomcat wiki.

> I was going to file a bug,
> and then noticed that JASPIC is also missing from the descriptions on
> the page here: https://bz.apache.org/bugzilla/enter_bug.cgi

BZ account name? I'll add you as an admin

Mark


> 
> 
> 
> Thanks,
> Coty
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



JASPIC Specification info missing from a few places

2016-12-21 Thread Coty Sutherland
Hi all,

I've been looking at the specifications listings on the
whichversions.html page and noticed JASPIC was missing, but is
implemented in 8.5+. I've added it on the site, but then I noticed
that it's also missing from the specifications page here:
https://wiki.apache.org/tomcat/Specifications. I don't think I have
access to the wiki, can someone fix that? I was going to file a bug,
and then noticed that JASPIC is also missing from the descriptions on
the page here: https://bz.apache.org/bugzilla/enter_bug.cgi



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JASPIC Specification info missing from a few places

2016-12-21 Thread Coty Sutherland
> Yes. We need you MoinMoin ID for the Tomcat wiki.

Ah. OK, I created an account for the wiki (I didn't see the sign up
link before). It's "Coty Sutherland", if you need that.

> BZ account name? I'll add you as an admin

Awesome, thanks. It's `csuth...@redhat.com`.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "AdminGroup" by markt

2016-12-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "AdminGroup" page has been changed by markt:
https://wiki.apache.org/tomcat/AdminGroup?action=diff=11=12

Comment:
+= Coty Sutherland

   * VioletaGeorgieva
   * JeanFredericClere
   * KeiichiFujino
+  * CotySutherland
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "Specifications" by CotySutherland

2016-12-21 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "Specifications" page has been changed by CotySutherland:
https://wiki.apache.org/tomcat/Specifications?action=diff=42=43

Comment:
Adding missing JASPIC section as it was implemented in tomcat 8.5

  ||Online Javadoc: || [[http://docs.oracle.com/javaee/7/api/|Java EE 7]] || ||
  ||Minimum Tomcat version: || 7.0.47, 8.0.0 || 7.0.56, 8.0.13 ||
  
+ == Java Authentication Service Provider Interface for Containers 
Specification ==
+ 
+ JASPIC 1.1 is the second maintenance release, Maintenance Release B, of 
JASPIC 1.0 (JSR 196).
+ 
+ ||Spec versions: || JASPIC 1.0 || JASPIC 1.1 ||
+ ||Main page: ||<-2> [[http://www.jcp.org/en/jsr/summary?id=196|JSR196]] ||
+ ||Java.net project: ||<-2> 
[[http://java.net/projects/jaspic-spec/|jaspic-spec ]]||
+ ||Stable: || Final Release || Maintenance Release B ||
+ ||Date: || 10 Oct, 2007 || 12 Jun, 2013 ||
+ ||Download Page: || 
[[http://jcp.org/aboutJava/communityprocess/final/jsr196/index.html|Overview]]<>[[http://download.oracle.com/otndocs/jcp/jaspic-1.0-fr-oth-JSpec/index.html|Direct
 Download]] || 
[[https://jcp.org/aboutJava/communityprocess/mrel/jsr196/index.html|Overview]]<>[[http://download.oracle.com/otndocs/jcp/jaspic-1_1-mrel2-eval-spec/index.html|Direct
 Download]] ||
+ ||Online Javadoc: ||<-2> [[http://docs.oracle.com/javaee/7/api/|Java EE 7]] ||
+ ||Minimum Tomcat version: ||<-2> 8.5.0 ||
+ 
  == See Also ==
  
   * [[TomcatVersions|Tomcat Versions]]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JASPIC Specification info missing from a few places

2016-12-21 Thread Coty Sutherland
> Is there a space there? I'm assuming not since none of the others have
> one. If it does, we'll need to figure out how to handle that.

That was my fault; I fixed it and am able to edit.

> You should be able to add components now.

I just updated the description. Should I also add a component for
JASPIC, or just leave it lumped together in the 'Specification APIs'
component? There isn't a component for JSP and Servlet, but there are
ones for WebSocket and EL, so I'm not sure what the convention is.

On Wed, Dec 21, 2016 at 3:59 PM, Mark Thomas  wrote:
> On 21/12/2016 20:15, Coty Sutherland wrote:
>>> Yes. We need you MoinMoin ID for the Tomcat wiki.
>>
>> Ah. OK, I created an account for the wiki (I didn't see the sign up
>> link before). It's "Coty Sutherland", if you need that.
>
> Is there a space there? I'm assuming not since none of the others have
> one. If it does, we'll need to figure out how to handle that.
>
>>> BZ account name? I'll add you as an admin
>>
>> Awesome, thanks. It's `csuth...@redhat.com`.
>
> You should be able to add components now.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JASPIC Specification info missing from a few places

2016-12-21 Thread Mark Thomas
On 21/12/2016 20:15, Coty Sutherland wrote:
>> Yes. We need you MoinMoin ID for the Tomcat wiki.
> 
> Ah. OK, I created an account for the wiki (I didn't see the sign up
> link before). It's "Coty Sutherland", if you need that.

Is there a space there? I'm assuming not since none of the others have
one. If it does, we'll need to figure out how to handle that.

>> BZ account name? I'll add you as an admin
> 
> Awesome, thanks. It's `csuth...@redhat.com`.

You should be able to add components now.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497

Remy Maucherat  changed:

   What|Removed |Added

  Attachment #34540|0   |1
is obsolete||

--- Comment #8 from Remy Maucherat  ---
Created attachment 34544
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34544=edit
Reuse exclusion and try/finally for simple tags

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org