Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-02-06 Thread Martin Grigorov
Hi Violeta, On Mon, Feb 6, 2017 at 8:55 PM, Violeta Georgieva wrote: > Hi, > > Currently JSR356 provides possibility to add message handlers in order to > receive web socket > messages but there is no way to instruct the web socket implementation to > suspend for a while >

svn commit: r1781976 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml

2017-02-06 Thread violetagg
Author: violetagg Date: Tue Feb 7 07:43:58 2017 New Revision: 1781976 URL: http://svn.apache.org/viewvc?rev=1781976=rev Log: ws police Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/

svn commit: r1781975 - /tomcat/trunk/webapps/docs/changelog.xml

2017-02-06 Thread violetagg
Author: violetagg Date: Tue Feb 7 07:39:38 2017 New Revision: 1781975 URL: http://svn.apache.org/viewvc?rev=1781975=rev Log: ws police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-02-06 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.

Re: svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread therealneworld
On Mon, Feb 6, 2017 at 6:08 PM, Mark Thomas wrote: > On 06/02/17 22:55, Mark Thomas wrote: >> >> On 06/02/17 21:20, therealnewo...@gmail.com wrote: >>> >>> Mark, >>> >>> If there is anything I can do to help work on the patch I will, >>> however as I mentioned in the bug I don't

Re: svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread therealneworld
On Mon, Feb 6, 2017 at 6:08 PM, Mark Thomas wrote: > On 06/02/17 22:55, Mark Thomas wrote: >> >> On 06/02/17 21:20, therealnewo...@gmail.com wrote: >>> >>> Mark, >>> >>> If there is anything I can do to help work on the patch I will, >>> however as I mentioned in the bug I don't

Re: svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread Mark Thomas
On 06/02/17 22:55, Mark Thomas wrote: On 06/02/17 21:20, therealnewo...@gmail.com wrote: Mark, If there is anything I can do to help work on the patch I will, however as I mentioned in the bug I don't have a windows environment so I am basically useless if that is where the issues exist.

Re: svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread Mark Thomas
On 06/02/17 21:20, therealnewo...@gmail.com wrote: Mark, If there is anything I can do to help work on the patch I will, however as I mentioned in the bug I don't have a windows environment so I am basically useless if that is where the issues exist. Yes, this is Windows. The problem with

Re: svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread therealneworld
Mark, If there is anything I can do to help work on the patch I will, however as I mentioned in the bug I don't have a windows environment so I am basically useless if that is where the issues exist. -nate On Mon, Feb 6, 2017 at 4:03 PM, Mark Thomas wrote: > On 06/02/17

Re: svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread Mark Thomas
On 06/02/17 21:01, ma...@apache.org wrote: Author: markt Date: Mon Feb 6 21:01:09 2017 New Revision: 1781952 URL: http://svn.apache.org/viewvc?rev=1781952=rev Log: Follow-up to r1781943 Fix build errors on Windows Confirmed that terminated threads are removed from the hash The patch isn't

svn commit: r1781952 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c

2017-02-06 Thread markt
Author: markt Date: Mon Feb 6 21:01:09 2017 New Revision: 1781952 URL: http://svn.apache.org/viewvc?rev=1781952=rev Log: Follow-up to r1781943 Fix build errors on Windows Confirmed that terminated threads are removed from the hash Modified: tomcat/native/trunk/native/include/ssl_private.h

svn commit: r1781944 - in /tomcat/native/trunk: native/srclib/VERSIONS xdocs/miscellaneous/changelog.xml

2017-02-06 Thread markt
Author: markt Date: Mon Feb 6 20:38:08 2017 New Revision: 1781944 URL: http://svn.apache.org/viewvc?rev=1781944=rev Log: Update minimum recommended OpenSSL version to 1.0.2k Modified: tomcat/native/trunk/native/srclib/VERSIONS tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

svn commit: r1781943 - in /tomcat/native/trunk: native/include/ssl_private.h native/os/win32/system.c native/src/ssl.c native/src/sslcontext.c native/src/sslnetwork.c native/src/sslutils.c xdocs/misce

2017-02-06 Thread markt
Author: markt Date: Mon Feb 6 20:37:00 2017 New Revision: 1781943 URL: http://svn.apache.org/viewvc?rev=1781943=rev Log: Ensure that the per thread error hash maintained by OpenSSL is cleaned up as individual threads exit to ensure it does not grow too large. Patch provided by Nate Clark.

AuthConfigProvider initialization while constructing the authenticator

2017-02-06 Thread Violeta Georgieva
Hi, With the current implementation if there is AuthConfigProvider we will initialize it once and then we will use it. However if such AuthConfigProvider is not available, on every request we will spend time in redundant search operation to find AuthConfigProvider that is not available. What do

svn commit: r1781939 - in /tomcat/trunk/webapps/docs: changelog.xml index.xml

2017-02-06 Thread csutherl
Author: csutherl Date: Mon Feb 6 20:10:47 2017 New Revision: 1781939 URL: http://svn.apache.org/viewvc?rev=1781939=rev Log: Add Specification and Javadoc references for JASPIC to the Docs application. Modified: tomcat/trunk/webapps/docs/changelog.xml (contents, props changed)

Read events suspend/resume logic in websocket impl to achieve backpressure

2017-02-06 Thread Violeta Georgieva
Hi, Currently JSR356 provides possibility to add message handlers in order to receive web socket messages but there is no way to instruct the web socket implementation to suspend for a while the incoming messages (backpressure) so that the application is able to process the already delivered

svn commit: r1781934 - in /tomcat/tc8.5.x/trunk/webapps/docs: changelog.xml index.xml

2017-02-06 Thread csutherl
Author: csutherl Date: Mon Feb 6 19:54:02 2017 New Revision: 1781934 URL: http://svn.apache.org/viewvc?rev=1781934=rev Log: Add Specification and Javadoc references for JASPIC to the Docs application. Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

[GitHub] tomcat issue #41: Check and update session record if one already exists.

2017-02-06 Thread JohnKiel
Github user JohnKiel commented on the issue: https://github.com/apache/tomcat/pull/41 If you use SELECT FOR UPDATE, then you'll also need to start and commit a transaction, with the overhead that entails. If the record is modified or even deleted between the time the SELECT query

[Bug 60597] Add ability to set cipher suites for websocket client connections

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60597 --- Comment #9 from Michael Orr --- Ok, thanks for the feedback. I'll work on a patch to pass in an SSLEngine instance and deprecate/remove the old constants. -- You are receiving this mail because: You are the

[GitHub] tomcat issue #41: Check and update session record if one already exists.

2017-02-06 Thread ChristopherSchultz
Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/41 You should use SELECT ... FOR UPDATE instead of SELECT / UPDATE. Much less code and transactionally-safe. Also, if you use SELECT ... FOR UPDATE, you can use ResultSet.moveToInsertRow to

Tagging Tomcat 6

2017-02-06 Thread Violeta Georgieva
Hi, I want to prepare Tomcat 6.0.51 for voting, but I want to ask whether I should wait for a new tc native release. What do you think? Thanks, Violeta

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #17 from Coty Sutherland --- OK, cool. So unless someone else objects to the patch as-is, I'll commit it to 7.0.x - 8.5.x shortly. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #16 from Remy Maucherat --- -1 as well for any additional characters. People who are that desperate to run into trouble can patch Tomcat easily. -- You are receiving this mail because: You are the assignee for

[Bug 60688] Tomcat should skip or handle module-info.class when scanning for annotations

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60688 Mark Thomas changed: What|Removed |Added Target Milestone||-

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #15 from eolivelli --- OK Mark at this moment I'm running a patch in production to make all the characters allowed. I have evidence only on troubles for curly braches and pipe characters so the patch looks

Re: svn commit: r1781649 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2017-02-06 Thread Mark Thomas
On 04/02/17 10:09, kkoli...@apache.org wrote: Author: kkolinko Date: Sat Feb 4 10:09:18 2017 New Revision: 1781649 URL: http://svn.apache.org/viewvc?rev=1781649=rev Log: https://bz.apache.org/bugzilla/show_bug.cgi?id=60613 Move changelog for r1781620 to correct version, Thanks for fixing

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #14 from Mark Thomas --- You need to make a case for each of those to added to the potentially allowed list. Without any such justification, I am -1 on expanding it beyond the current three allowed characters. --

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #13 from eolivelli --- Coty, the patch looks good to me, can you please add the following chars to the list of allowed characters ? '\"' (double quote) '#' (sharp) '<' (left angle bracket) '>' (right angle

[Bug 60694] New: Potential NullPointerException in AuthenticatorBase.getJaspicProvider()

2017-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60694 Bug ID: 60694 Summary: Potential NullPointerException in AuthenticatorBase.getJaspicProvider() Product: Tomcat 8 Version: 8.5.11 Hardware: All OS: All