[Bug 60963] Optimize class loading for unpackWARs=false case
https://bz.apache.org/bugzilla/show_bug.cgi?id=60963 --- Comment #8 from Thomas Meyer--- (In reply to Christopher Schultz from comment #7) > (In reply to Thomas Meyer from comment #6) > > Regarding ZipInputStreamWithPosition: > > I think you found the ugly part of this patch. I guess your suggestion > > wouldn't work, because ZipInputStream will construct itself with a new > > PushBackInputstream and the provided input stream as decorated object. > > Passing the input stream as you suggest would result in a > > PushBackInputStream with an PushBackInputStreamWithPosition as decorated > > object, which is wrong for our intention here. > > By setting the decorated object after the super constructor has finished we > > replace the PushbsckInputStream with our implementation. > > I'm sorry, I don't follow. What's the problem with the superclass's > constructor using the PushbackCountingInputStream instead of handing it an > undecorated InputStream, and then replacing it after the constructor has > completed? Yes, exactly this is what is happening: "super(new PushbackInputStream(in, 512), new Inflater(true), 512);" In the super constructor. > Does the superclass constructor do something with the InputStream that we > don't want to happen to the PushbackCountingInputStream? Yes, it decorates the passed InputStream with a PushBackInputStream. > > I would think that "bytesread" would be incorrect (initialized to zero) if > the superclass constructor performs a read. Don't you want those reads to be > counted? Theoretically we want those bytes to be counted, but the ZipInputStream doesn't read anything in it's construction phase, that's why the whole "fast forward skipping works at all". And yes this is a somewhat hackish solution but it works. I did also look at what commons-compress provides but their implementation also doesn't have a callback for the event "new PK entry in the InputStream reached" -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61003] New: Secure Websocket client hides Exception on error, and throws an IllegalStateException instead
https://bz.apache.org/bugzilla/show_bug.cgi?id=61003 Bug ID: 61003 Summary: Secure Websocket client hides Exception on error, and throws an IllegalStateException instead Product: Tomcat 8 Version: 8.5.11 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: WebSocket Assignee: dev@tomcat.apache.org Reporter: a...@activeviam.com Target Milestone: Created attachment 34924 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34924=edit The stack trace We encounter the following exception (full stack attached) instead of a proper exception, such as a time out: java.lang.IllegalStateException: Concurrent write operations are not permitted at org.apache.tomcat.websocket.AsyncChannelWrapperSecure.write(AsyncChannelWrapperSecure.java:116) AsyncChannelWrapperSecure javadoc interestingly states "This needs a lot more testing before it can be considered robust.", and indeed this class seems to be the cause of the issue. More details about what I suspect is going on: If you take a closer look at WsRemoteEndpointImplBase.sendMessageBlock line 313, you will find this section: for (MessagePart mp : messageParts) { writeMessagePart(mp); if (!bsh.getSendResult().isOK()) { messagePartInProgress.release(); Throwable t = bsh.getSendResult().getException(); // Bug alert!! Here we will write again, but may not have reset the writing flag of AsyncChannelWrapperSecure to false wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, t.getMessage()), new CloseReason(CloseCodes.CLOSED_ABNORMALLY, t.getMessage())); throw new IOException (t); } which is problematic: The writeMessagePart method will eventually call doWrite of WsRemoteEndpointImplClient, which will simply return in case of exceptions: try { channel.write(byteBuffer).get(timeout, TimeUnit.MILLISECONDS); } catch (InterruptedException | ExecutionException | TimeoutException e) { handler.onResult(new SendResult(e)); return; } So here, when the get fails, the WriteTask of AsyncChannelWrapperSecure, will not have finished, and so will not have unset its write flag, meaning that the wsSession.doClose call done in WsRemoteEndpointImplBase.sendMessageBlock will fail to write. Moreover, the write flag of the WriteTask is not reset in the finally block, meaning that any other exception thrown by the write task will cause the completion of the future, but will not allow to write in the ws either, causing another failure. This will mean that it will fail to throw the actual cause of the exception stored in the SendResult. Side Note: the ReadTask seems to suffer of the same disease, not sure if it is immune to it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 Chuck Caldaralechanged: What|Removed |Added Resolution|FIXED |INVALID Status|CLOSED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r19194 - /dev/tomcat/tomcat-8/v8.5.14/ /release/tomcat/tomcat-8/v8.5.14/
Author: markt Date: Tue Apr 18 10:10:00 2017 New Revision: 19194 Log: Release 8.5.14 Added: release/tomcat/tomcat-8/v8.5.14/ - copied from r19193, dev/tomcat/tomcat-8/v8.5.14/ Removed: dev/tomcat/tomcat-8/v8.5.14/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r19193 - /dev/tomcat/tomcat-9/v9.0.0.M20/ /release/tomcat/tomcat-9/v9.0.0.M20/
Author: markt Date: Tue Apr 18 10:09:21 2017 New Revision: 19193 Log: Release 9.0.0.M20 Added: release/tomcat/tomcat-9/v9.0.0.M20/ - copied from r19192, dev/tomcat/tomcat-9/v9.0.0.M20/ Removed: dev/tomcat/tomcat-9/v9.0.0.M20/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE][RESULT] Release Apache Tomcat 8.5.14
The following votes were cast: Binding: +1: markt, remm, violetagg, kjujino, mgrigorov, rjung Non-binding: +1: huxing Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE][RESULT] Release Apache Tomcat 9.0.0.M20
The following votes were cast: Binding: +1: violetagg, remm, markt, kfujino, mgrigorov, rjung Non-binding: +1: huxing The vote therefore passes. Thanks to everyone who helped with this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 zosrothkochanged: What|Removed |Added Status|RESOLVED|CLOSED Resolution|INVALID |FIXED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-310) mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
Francis ANDRE created MTOMCAT-310: - Summary: mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy Key: MTOMCAT-310 URL: https://issues.apache.org/jira/browse/MTOMCAT-310 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat6, tomcat7 Affects Versions: 2.2 Environment: C:\MXW\DEMOS\MI-4.1.1\Demos Webapps\smartBasic>C:\ASF\apache-maven-3.2.5\bin\mvn --version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T18:29:23+01:00) Maven home: C:\ASF\apache-maven-3.2.5 Java version: 1.7.0_51, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_51\jre Default locale: fr_FR, platform encoding: Cp1252 OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" Reporter: Francis ANDRE Assignee: Olivier Lamy (*$^¨%`£) Attachments: pom.xml, warassembly.xml Hi Using a pom.xml that build a war using the maven-assembly-plugin to produce the war, the tomcat6-maven-plugin rejects to deploy the war for the reason that the pom is not packaged as a war. [DEBUG] Configuring mojo org.apache.tomcat.maven:tomcat6-maven-plugin:2.2:deploy from plugin realm ClassRealm[plugin>org .apache.tomcat.maven:tomcat6-maven-plugin:2.2, parent: sun.misc.Launcher$AppClassLoader@631d75b9] [DEBUG] Configuring mojo 'org.apache.tomcat.maven:tomcat6-maven-plugin:2.2:deploy' with basic configurator --> [DEBUG] (f) charset = ISO-8859-1 [DEBUG] (f) contextFile = C:\MXW\DEMOS\MI-4.1.1\Demos Webapps\smartBasic\target\smartBasic-4.1.1\META-INF\context.xml [DEBUG] (f) ignorePackaging = false [DEBUG] (f) mode = war [DEBUG] (f) packaging = pom [DEBUG] (f) path = /smartBasic [DEBUG] (f) server = Tomcat6 [DEBUG] (f) update = false [DEBUG] (f) url = http://localhost:8080/manager [DEBUG] (f) version = 2.2 [DEBUG] (f) warFile = C:\MXW\DEMOS\MI-4.1.1\Demos Webapps\smartBasic\target\smartBasic-4.1.1.war [DEBUG] (f) settings = org.apache.maven.execution.SettingsAdapter@7ec5ab2 [DEBUG] -- end configuration -- [INFO] Ne traite pas un projet de packaging non war -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 Mark Thomaschanged: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #5 from Mark Thomas --- This is an issue with the Maven plug-in (or your usage of it), not Tomcat. The Maven plug-in uses Jira to track issues. You need to open an issue at https://issues.apache.org/jira/browse/MTOMCAT -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 zosrothkochanged: What|Removed |Added Target Milestone|default |--- Product|Tomcat 6|Tomcat 7 Component|Manager application |Manager Version|6.0.51 |7.0.77 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 --- Comment #4 from zosrothko--- Hi That's the same issue for tomcat7-maven-plugin [INFO] <<< tomcat7-maven-plugin:2.2:deploy (default-cli) < package @ smartBasic <<< [INFO] [INFO] --- tomcat7-maven-plugin:2.2:deploy (default-cli) @ smartBasic --- [INFO] Ne traite pas un projet de packaging non war -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 --- Comment #3 from Violeta Georgieva--- Hi, Please consider upgrading your Tomcat instances as Apache Tomcat 6 has reached End of Life. http://tomcat.apache.org/tomcat-60-eol.html Regards, Violeta -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 zosrothkochanged: What|Removed |Added OS||All --- Comment #2 from zosrothko --- [DEBUG] Configuring mojo org.apache.tomcat.maven:tomcat6-maven-plugin:2.2:deploy from plugin realm ClassRealm[plugin>org .apache.tomcat.maven:tomcat6-maven-plugin:2.2, parent: sun.misc.Launcher$AppClassLoader@631d75b9] [DEBUG] Configuring mojo 'org.apache.tomcat.maven:tomcat6-maven-plugin:2.2:deploy' with basic configurator --> [DEBUG] (f) charset = ISO-8859-1 [DEBUG] (f) contextFile = C:\MXW\DEMOS\MI-4.1.1\Demos Webapps\smartBasic\target\smartBasic-4.1.1\META-INF\context.xml [DEBUG] (f) ignorePackaging = false [DEBUG] (f) mode = war [DEBUG] (f) packaging = pom [DEBUG] (f) path = /smartBasic [DEBUG] (f) server = Tomcat6 [DEBUG] (f) update = false [DEBUG] (f) url = http://localhost:8080/manager [DEBUG] (f) version = 2.2 [DEBUG] (f) warFile = C:\MXW\DEMOS\MI-4.1.1\Demos Webapps\smartBasic\target\smartBasic-4.1.1.war [DEBUG] (f) settings = org.apache.maven.execution.SettingsAdapter@7ec5ab2 [DEBUG] -- end configuration -- [INFO] Ne traite pas un projet de packaging non war -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 --- Comment #1 from zosrothko--- Created attachment 34922 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34922=edit pom.xml -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61001] New: mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy
https://bz.apache.org/bugzilla/show_bug.cgi?id=61001 Bug ID: 61001 Summary: mvn tomcat6:deploy on a pom with a war assemply ==> no war to deploy Product: Tomcat 6 Version: 6.0.51 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Manager application Assignee: dev@tomcat.apache.org Reporter: francis.andre.kampb...@orange.fr Target Milestone: default Created attachment 34921 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34921=edit war.assembly Hi Using a pom.xml that build a war using the maven-assembly-plugin to produce the war, the tomcat6-maven-plugin rejects to deploy the war for the reason that the pom is not packaged as a war. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org