Re: [VOTE] Release Apache Tomcat 9.0.0.M24

2017-07-19 Thread Huxing Zhang 
The proposed 9.0.0.M24 release is:
[ ] Broken - do not release
[ X ] Alpha - go ahead and release as 9.0.0.M24

Unit test passed.
Our test web application runs fine.
New feature tomcat-web.xml works fine.

--
From:Mark Thomas 
Time:2017 Jul 18 (Tue) 19:43
To:Tomcat Developers List 
Subject:[VOTE] Release Apache Tomcat 9.0.0.M24


The proposed Apache Tomcat 9.0.0.M24 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

Note that the 9.0.0.M23 release vote was cancelled due to a regression.

The major changes compared to the 9.0.0.M22 release are:

- Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting
  down cleanly.

- Add LoadBalancerDrainingValve, a Valve designed to reduce the amount
  of time required for a node to drain its authenticated users.

- When generating JSP runtime error messages that quote the relevant JSP
  source code, switch from using the results of the JSP page parsing
  process to using the JSR 045 source map data to identify the correct
  part of the JSP source from the stack trace. This significantly
  reduces the memory footprint of Jasper in development mode, provides a
  small performance improvement for error page generation and enables
  source quotes to continue to be provided after a Tomcat restart.

- Add support for a Tomcat specific deployment descriptor,
  /WEB-INF/tomcat-web.xml

Along with lots of other bug fixes and improvements.


For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M24/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1143/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M24/

The proposed 9.0.0.M24 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 9.0.0.M24

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Incorrect tag name "TONCAT_9_0_0_M23" in github mirror

2017-07-19 Thread Huxing Zhang 
Hi,

I've noticed that there is a incorrect tag name "TONCAT_9_0_0_M23"  in github 
mirror:

https://github.com/apache/tomcat/tree/TONCAT_9_0_0_M23

I've checked the svn repo, looks like it has been corrected already:

https://svn.apache.org/viewvc/tomcat/tags/

It seems that the change in svn repo is not synced to github mirror.

Any idea how to fix that?
---
Thanks,
Huxing

[Bug 60523] Reduce number of network packets that server sends to client via WebSocket connection

2017-07-19 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60523

--- Comment #8 from Joseph Dean  ---
I'm experiencing the same behavior. The client library I use to send data to my
server over websockets properly bundles the payload length and payload in a
single tcp datagram. Data coming from my tomcat server is always sending two
datagrams for a single message: one with 2 bytes of payload which is the
websocket header + payload length, and the 2nd which is the payload.

>From what I can see the doWrite(SendHandler, long, ByteBuffer...) sends each
provided buffer in a separate frame. We can see inside this method it invokes:

for (ByteBuffer buffer : buffers) {
  socketWrapper.write(true, buffer);
  // Snip
  socketWrapper.setWriteTimeout(timeout);
  socketWrapper.flush(true);
}

The original patch allocates a new buffer to place both the header and payload
in a single buffer before handing it to this method, which resolves the network
behavior but results in extra memory copies. Perhaps the more correct solution
is to modify WsRemoteEndpointImplServer::doWrite to only do a single socket
flush after writing all provided buffers?

The protocol I'm working on sends numerous very small packets; about 90% of my
traffic is TCP header overhead. Doubling the number of packets thus nearly
doubles my overall bandwidth usage. This is extremely important to my
application.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61316] Test files used by TestEncodingDetector test are broken in src.zip, src.tar.gz [8.5.18]

2017-07-19 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

Christopher Schultz  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Christopher Schultz  ---
Could this be a svn client problem?

$ svn pget svn:mime-type test/webapp/jsp/encoding/bom-none-prolog-none.jspx
text/plain; charset=UTF-8
$ svn pget svn:eol-style test/webapp/jsp/encoding/bom-none-prolog-none.jspx
native

$ svn pget svn:mime-type
test/webapp/jsp/encoding/bom-utf16be-prolog-utf16le.jspx
text/plain; charset=UTF-16BE
$ svn pget svn:eol-style
test/webapp/jsp/encoding/bom-utf16be-prolog-utf16le.jspx
svn: warning: W200017: Property 'svn:eol-style' not found on
'test/webapp/jsp/encoding/bom-utf16be-prolog-utf16le.jspx'
svn: E20: A problem occurred; see other errors for details

Should the eol-style be set for any of these files? Should the mime-type be
application/binary, or do we trust svn clients not to botch the encoding?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1802405 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/CachedResource.java java/org/apache/catalina/webresources/StandardRoot.java webapps/docs/changelog.xml webapps

2017-07-19 Thread markt 
Author: markt
Date: Wed Jul 19 15:41:38 2017
New Revision: 1802405

URL: http://svn.apache.org/viewvc?rev=1802405=rev
Log:
Performance improvements for service loader look-ups (and look-ups of other 
class loader resources) when the web application is deployed in a packed WAR 
file.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/CachedResource.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/config/host.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jul 19 15:41:38 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1

svn commit: r1802404 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/webresources/CachedResource.java java/org/apache/catalina/webresources/StandardRoot.java webapps/docs/changelog.xml webapps

2017-07-19 Thread markt 
Author: markt
Date: Wed Jul 19 15:40:34 2017
New Revision: 1802404

URL: http://svn.apache.org/viewvc?rev=1802404=rev
Log:
Performance improvements for service loader look-ups (and look-ups of other 
class loader resources) when the web application is deployed in a packed WAR 
file.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/CachedResource.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/host.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jul 19 15:40:34 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216

svn commit: r1802403 - in /tomcat/trunk: java/org/apache/catalina/webresources/CachedResource.java java/org/apache/catalina/webresources/StandardRoot.java webapps/docs/changelog.xml webapps/docs/confi

2017-07-19 Thread markt 
Author: markt
Date: Wed Jul 19 15:39:49 2017
New Revision: 1802403

URL: http://svn.apache.org/viewvc?rev=1802403=rev
Log:
Performance improvements for service loader look-ups (and look-ups of other 
class loader resources) when the web application is deployed in a packed WAR 
file.

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/host.xml

Modified: tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java?rev=1802403=1802402=1802403=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/CachedResource.java Wed 
Jul 19 15:39:49 2017
@@ -92,23 +92,26 @@ public class CachedResource implements W
 return true;
 }
 
-WebResource webResourceInternal = root.getResourceInternal(
-webAppPath, useClassLoaderResources);
-if (!webResource.exists() && webResourceInternal.exists()) {
-return false;
-}
+// Assume resources inside WARs will not change
+if (!root.isPackedWarFile()) {
+WebResource webResourceInternal = root.getResourceInternal(
+webAppPath, useClassLoaderResources);
+if (!webResource.exists() && webResourceInternal.exists()) {
+return false;
+}
 
-// If modified date or length change - resource has changed / been
-// removed etc.
-if (webResource.getLastModified() != getLastModified() ||
-webResource.getContentLength() != getContentLength()) {
-return false;
-}
+// If modified date or length change - resource has changed / been
+// removed etc.
+if (webResource.getLastModified() != getLastModified() ||
+webResource.getContentLength() != getContentLength()) {
+return false;
+}
 
-// Has a resource been inserted / removed in a different resource set
-if (webResource.getLastModified() != 
webResourceInternal.getLastModified() ||
-webResource.getContentLength() != 
webResourceInternal.getContentLength()) {
-return false;
+// Has a resource been inserted / removed in a different resource 
set
+if (webResource.getLastModified() != 
webResourceInternal.getLastModified() ||
+webResource.getContentLength() != 
webResourceInternal.getContentLength()) {
+return false;
+}
 }
 
 nextCheck = ttl + now;
@@ -133,9 +136,15 @@ public class CachedResource implements W
 return true;
 }
 
-// At this point, always expire the entry as re-populating it is likely
-// to be as expensive as validating it.
-return false;
+// Assume resources inside WARs will not change
+if (root.isPackedWarFile()) {
+nextCheck = ttl + now;
+return true;
+} else {
+// At this point, always expire the entry and re-populating it is
+// likely to be as expensive as validating it.
+return false;
+}
 }
 
 protected long getNextCheck() {

Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java?rev=1802403=1802402=1802403=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Wed 
Jul 19 15:39:49 2017
@@ -642,6 +642,18 @@ public class StandardRoot extends Lifecy
 return result;
 }
 
+
+
+/*
+ * Returns true if and only if all the resources for this web application
+ * are provided via a packed WAR file. It is used to optimise cache
+ * validation in this case on the basis that the WAR file will not change.
+ */
+protected boolean isPackedWarFile() {
+return main instanceof WarResourceSet && preResources.isEmpty() && 
postResources.isEmpty();
+}
+
+
 // --- JMX 
Lifecycle
 @Override
 protected String getDomainInternal() {

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1802403=1802402=1802403=diff
==
---

Re: [VOTE] Release Apache Tomcat 8.5.18

2017-07-19 Thread Konstantin Kolinko 
2017-07-18 16:58 GMT+03:00 Mark Thomas :
> The proposed Apache Tomcat 8.5.18 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Enable TLS connectors to use Java key stores that contain multiple
>   keys where each key has a separate password. Based on a patch by Frank
>   Taffelt.
>
> - Make asynchronous error handling more robust. In particular ensure
>   that onError() is called for any registered AsyncListeners after an
>   I/O error on a non-container thread.
>
> - Sync SSL session access for the APR connector to prevent errors when
>   accessing the session.
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1144/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/
>
> The proposed 8.5.18 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.18

Smoke testing OK.
JUnit test - OK except one (Java 8u141 32-bit x all connectors, Windows 10)

Notes:

1. apache-tomcat-8.5.18.exe is not signed.
I guess that "Code signing service currently unavailable" issue that
Mark mentioned 2017-06-21 is still not cleared.

https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

2. TestEncodingDetector test is failing, as its data files are broken
in src.zip that I tested, do not match the svn tag.

I filed this issue into Bugzilla,
https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2017-07-19 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 mins 3 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=true -Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170719.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170719/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170719-native-src.tar.gz
 -Dtest.repor
 ts=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170719-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x

[Bug 61316] New: Test files used by TestEncodingDetector test are broken in src.zip, src.tar.gz [8.5.18]

2017-07-19 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

Bug ID: 61316
   Summary: Test files used by TestEncodingDetector test are
broken in src.zip, src.tar.gz [8.5.18]
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: knst.koli...@gmail.com
  Target Milestone: 

Testing 8.5.18 (Release candidate) from apache-tomcat-8.5.18-src.zip
the following test is consistently failing:

org.apache.jasper.compiler.TestEncodingDetector

Testing on Windows 10, Java 8/Java 7 x all connectors - all are failing.

Comparing unpacked -src.zip with fresh checkout of the tag,
the files used by this test differ.

>svn st
M   test\webapp\jsp\encoding\bom-none-prolog-utf16be.jspx
M   test\webapp\jsp\encoding\bom-none-prolog-utf16le.jspx
M   test\webapp\jsp\encoding\bom-utf16be-prolog-none.jsp
M   test\webapp\jsp\encoding\bom-utf16be-prolog-none.jspx
M   test\webapp\jsp\encoding\bom-utf16be-prolog-utf16be.jspx
M   test\webapp\jsp\encoding\bom-utf16be-prolog-utf16le.jspx
M   test\webapp\jsp\encoding\bom-utf16be-prolog-utf8.jspx
M   test\webapp\jsp\encoding\bom-utf16le-prolog-none.jsp
M   test\webapp\jsp\encoding\bom-utf16le-prolog-none.jspx
M   test\webapp\jsp\encoding\bom-utf16le-prolog-utf16be.jspx
M   test\webapp\jsp\encoding\bom-utf16le-prolog-utf16le.jspx
M   test\webapp\jsp\encoding\bom-utf16le-prolog-utf8.jspx

The list of diffing files is the same for -src.zip and -src.tar.gz.


Looking into the files from src.zip with a hex editor
(e.g. bom-none-prolog-utf16be.jspx), I see sequences like
000D 0A00 0D0A

These '0D0A' sequences apparently originate from LF -> CRLF conversion that
treated these 16-bit files as 8-bit ones.

Looking into the files from src.tar.gz, I see
000A 000A

All line wraps are doubled - there are additional empty lines everywhere.

The correct file in svn repository has
000D 000A

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org