Re: Session attribute listeners inconsistency

2018-02-15 Thread Konstantin Kolinko
2018-02-16 0:35 GMT+03:00 Mark Thomas : > Hi, > > I've been looking at: > https://bz.apache.org/bugzilla/show_bug.cgi?id=43866 > > In short, this bug is looking for a way to tell Tomcat an object set as > a session attribute has been mutated and therefore needs to be >

Re: Responsive Website for tomcat.apache.org

2018-02-15 Thread Konstantin Kolinko
2018-02-06 21:58 GMT+03:00 Igal @ Lucee.org : > > Also, can anyone confirm if they can still see the menu in Print? And if so, > on what platform/browser? I can not reproduce that. Yes, I see the menu. Both in Firefox and in Chrome, latest. (58.0, 64.0) You need to have wide

svn commit: r1824298 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/CompressionConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 11:39:29 2018 New Revision: 1824298 URL: http://svn.apache.org/viewvc?rev=1824298=rev Log: Prevent Tomcat from applying gzip compression to content that is already compressed with brotli compression. Patch provided by burka. Modified: tomcat/tc8.5.x/trunk/

svn commit: r1824300 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 11:47:33 2018 New Revision: 1824300 URL: http://svn.apache.org/viewvc?rev=1824300=rev Log: Prevent Tomcat from applying gzip compression to content that is already compressed with brotli compression. Patch provided by burka. Modified: tomcat/tc7.0.x/trunk/

svn commit: r1824297 - in /tomcat/trunk: java/org/apache/coyote/CompressionConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 11:38:11 2018 New Revision: 1824297 URL: http://svn.apache.org/viewvc?rev=1824297=rev Log: Prevent Tomcat from applying gzip compression to content that is already compressed with brotli compression. Patch provided by burka. This closes #99 Modified:

[GitHub] tomcat pull request #99: Don't gzip brotli compressed content

2018-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/99 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1824302 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/SecureNio2Channel.java java/org/apache/tomcat/util/net/SecureNioChannel.java webapps/docs/changelog.xml

2018-02-15 Thread remm
Author: remm Date: Thu Feb 15 12:09:29 2018 New Revision: 1824302 URL: http://svn.apache.org/viewvc?rev=1824302=rev Log: Overflow during handshake is an invalid situation, so fix the NIO handshake. Also improve the error message with the actual status. Modified: tomcat/tc8.5.x/trunk/

[Bug 62104] New: Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28)

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 Bug ID: 62104 Summary: Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28) Product: Tomcat 8 Version: 8.5.28

Re: svn commit: r1824297 - in /tomcat/trunk: java/org/apache/coyote/CompressionConfig.java webapps/docs/changelog.xml

2018-02-15 Thread Konstantin Kolinko
2018-02-15 14:38 GMT+03:00 : > Author: markt > Date: Thu Feb 15 11:38:11 2018 > New Revision: 1824297 > > URL: http://svn.apache.org/viewvc?rev=1824297=rev > Log: > Prevent Tomcat from applying gzip compression to content that is already > compressed with brotli compression. >

svn commit: r1824299 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 11:46:48 2018 New Revision: 1824299 URL: http://svn.apache.org/viewvc?rev=1824299=rev Log: Prevent Tomcat from applying gzip compression to content that is already compressed with brotli compression. Patch provided by burka. Modified: tomcat/tc8.0.x/trunk/

[GitHub] tomcat issue #99: Don't gzip brotli compressed content

2018-02-15 Thread burka
Github user burka commented on the issue: https://github.com/apache/tomcat/pull/99 Thanks @markt-asf :+1: --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

[Bug 62103] New: s390x tomcat docker container should use IBM JVM and not openJDK which is very slow on systemz

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62103 Bug ID: 62103 Summary: s390x tomcat docker container should use IBM JVM and not openJDK which is very slow on systemz Product: Tomcat 7 Version: 7.0.84 Hardware: Other

svn commit: r1824301 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SecureNio2Channel.java java/org/apache/tomcat/util/net/SecureNioChannel.java webapps/docs/changelog.xml

2018-02-15 Thread remm
Author: remm Date: Thu Feb 15 12:05:55 2018 New Revision: 1824301 URL: http://svn.apache.org/viewvc?rev=1824301=rev Log: Overflow during handshake is an invalid situation, so fix the NIO handshake. Also improve the error message with the actual status. Modified:

[Bug 62103] s390x tomcat docker container should use IBM JVM and not openJDK which is very slow on systemz

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62103 Coty Sutherland changed: What|Removed |Added Resolution|--- |INVALID

svn commit: r1824312 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/CompressionConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 14:26:11 2018 New Revision: 1824312 URL: http://svn.apache.org/viewvc?rev=1824312=rev Log: Correct regression in r1824298 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/CompressionConfig.java

Re: svn commit: r1824297 - in /tomcat/trunk: java/org/apache/coyote/CompressionConfig.java webapps/docs/changelog.xml

2018-02-15 Thread Mark Thomas
On 15/02/18 13:14, Konstantin Kolinko wrote: > 2018-02-15 14:38 GMT+03:00 : >> Author: markt >> Date: Thu Feb 15 11:38:11 2018 >> New Revision: 1824297 >> >> URL: http://svn.apache.org/viewvc?rev=1824297=rev >> Log: >> Prevent Tomcat from applying gzip compression to content

svn commit: r1824311 - in /tomcat/trunk: java/org/apache/coyote/CompressionConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 14:25:33 2018 New Revision: 1824311 URL: http://svn.apache.org/viewvc?rev=1824311=rev Log: Correct regression in r1824297 Modified: tomcat/trunk/java/org/apache/coyote/CompressionConfig.java tomcat/trunk/webapps/docs/changelog.xml Modified:

[Bug 62104] Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28)

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1

svn commit: r1824315 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 14:31:35 2018 New Revision: 1824315 URL: http://svn.apache.org/viewvc?rev=1824315=rev Log: Correct regression in r1824300 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

svn commit: r1824313 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 14:30:49 2018 New Revision: 1824313 URL: http://svn.apache.org/viewvc?rev=1824313=rev Log: Correct regression in r1824299 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

[Bug 62104] Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28)

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 --- Comment #2 from Remy Maucherat --- The problem is that ContextConfig.authenticatorConfig is not appropriate with the login API (which was introduced later). Assuming the webapp has no security constraints, before r1823310

Git repo for training content

2018-02-15 Thread Mark Thomas
Hi, Now the date and venue are fixed for the training course (I need to publish them) we need somewhere to put the training material. After some research my plan is to use reveal.js and GitHub pages. This means we'll need a GitHib repo. I therefore plan to request an ASF GitHub repo -

Re: Git repo for training content

2018-02-15 Thread Rémy Maucherat
On Thu, Feb 15, 2018 at 4:57 PM, Mark Thomas wrote: > Hi, > > Now the date and venue are fixed for the training course (I need to > publish them) we need somewhere to put the training material. > > After some research my plan is to use reveal.js and GitHub pages. This > means

svn commit: r1824323 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-02-15 Thread remm
Author: remm Date: Thu Feb 15 16:05:48 2018 New Revision: 1824323 URL: http://svn.apache.org/viewvc?rev=1824323=rev Log: 62104: Fix programmatic login regression as the NonLoginAuthenticator has to be set for it to work (if no login method is specified). Modified:

svn commit: r1824360 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 20:21:56 2018 New Revision: 1824360 URL: http://svn.apache.org/viewvc?rev=1824360=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 Fix programmatic login regression as the NonLoginAuthenticator has to be set for it to work (if no login method is

svn commit: r1824365 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 21:04:23 2018 New Revision: 1824365 URL: http://svn.apache.org/viewvc?rev=1824365=rev Log: Simplify. No functional change. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java Modified:

svn commit: r1824359 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 20:20:42 2018 New Revision: 1824359 URL: http://svn.apache.org/viewvc?rev=1824359=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 Fix programmatic login regression as the NonLoginAuthenticator has to be set for it to work (if no login method is

[Bug 62104] Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28)

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 --- Comment #4 from Remy Maucherat --- Thanks, I was waiting for a bit of testing before backporting. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62104] Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28)

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 --- Comment #5 from Mark Thomas --- Sorry, didn't mean to step on your toes. I know that code fairly well so I was confident your patch was correct. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1824357 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 20:15:15 2018 New Revision: 1824357 URL: http://svn.apache.org/viewvc?rev=1824357=rev Log: Update comment Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java URL:

svn commit: r1824358 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 20:19:16 2018 New Revision: 1824358 URL: http://svn.apache.org/viewvc?rev=1824358=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 Fix programmatic login regression as the NonLoginAuthenticator has to be set for it to work (if no login method is

[Bug 62104] Unable to login with HttpServletRequest.login(String, String) due to missing Authenticator (Tomcat 8.5.28)

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62104 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 61998] tomcat: dead loop in the processing of SSL handshake

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61998 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

buildbot failure in on tomcat-trunk

2018-02-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3069 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 43866] add support for session attribute propagation without calls to DeltaSession.setAttribute

2018-02-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=43866 --- Comment #2 from Mark Thomas --- I think a better way to implement this is via manager options that control calls to listeners when setAttribute() is called with the already bound value. As I looked into this I noticed

svn commit: r1824372 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-02-15 Thread markt
Author: markt Date: Thu Feb 15 21:46:25 2018 New Revision: 1824372 URL: http://svn.apache.org/viewvc?rev=1824372=rev Log: Silence a couple of SpotBugs false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified:

Session attribute listeners inconsistency

2018-02-15 Thread Mark Thomas
Hi, I've been looking at: https://bz.apache.org/bugzilla/show_bug.cgi?id=43866 In short, this bug is looking for a way to tell Tomcat an object set as a session attribute has been mutated and therefore needs to be replicated. The 'standard' way to do this is by calling setAttribute() but this

buildbot success in on tomcat-trunk

2018-02-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3071 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler