[Bug 62389] Add ipv6 loopback address to the default internalProxies

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62389 --- Comment #3 from Konstantin Kolinko --- ::1 should be added to the list as well, like we do for RemoteAddrValve. When Tomcat runs with APR connector, request.getRemoteAddr() returns "::1" when accessed from localhost. This value can be

buildbot success in on tomcat-7-trunk

2018-06-04 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1113 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1832895 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/RemoteIpValve.java test/org/apache/catalina/valves/TestRemoteIpValve.java

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 21:00:34 2018 New Revision: 1832895 URL: http://svn.apache.org/viewvc?rev=1832895=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57926 Restore the original X-Forwarded-By and X-Forwarded-For headers after processing along with the other original

buildbot failure in on tomcat-7-trunk

2018-06-04 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1112 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1832885 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/ java/org/apache/catalina/valves/ test/org/apache/catalina/filters/ test/org/apache/catalina/valves/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 19:02:26 2018 New Revision: 1832885 URL: http://svn.apache.org/viewvc?rev=1832885=rev Log: Correctly handle the case when the request passes through one or more trustedProxies but no internalProxies. Based on a patch by zhanhb Modified: tomcat/tc7.0.x/trunk/

svn commit: r1832884 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/ java/org/apache/catalina/valves/ test/org/apache/catalina/filters/ test/org/apache/catalina/valves/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 19:01:26 2018 New Revision: 1832884 URL: http://svn.apache.org/viewvc?rev=1832884=rev Log: Correctly handle the case when the request passes through one or more trustedProxies but no internalProxies. Based on a patch by zhanhb Modified: tomcat/tc8.0.x/trunk/

svn commit: r1832883 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/filters/ java/org/apache/catalina/valves/ test/org/apache/catalina/filters/ test/org/apache/catalina/valves/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 18:59:46 2018 New Revision: 1832883 URL: http://svn.apache.org/viewvc?rev=1832883=rev Log: Correctly handle the case when the request passes through one or more trustedProxies but no internalProxies. Based on a patch by zhanhb Modified: tomcat/tc8.5.x/trunk/

[GitHub] tomcat pull request #45: Update RemoteIpValve.java

2018-06-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/45 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832882 - in /tomcat/trunk: java/org/apache/catalina/filters/ java/org/apache/catalina/valves/ test/org/apache/catalina/filters/ test/org/apache/catalina/valves/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 18:57:59 2018 New Revision: 1832882 URL: http://svn.apache.org/viewvc?rev=1832882=rev Log: Correctly handle the case when the request passes through one or more trustedProxies but no internalProxies. Based on a patch by zhanhb This closes #45 Modified:

[Bug 56148] support (multiple) ocsp stapling

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56148 --- Comment #3 from Christopher Schultz --- Looks like Java 9 has OCSP stapling[1]. See slide 47. Looks like you can just set a system preference and magically you get OCSP stapling. [1]

[Bug 62122] undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62122 Christopher Schultz changed: What|Removed |Added Status|RESOLVED|REOPENED

[Bug 62122] undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62122 --- Comment #3 from Christopher Schultz --- Re-opening original BZ issue. Seems like this needs to be fixed by capping the OpenSSL version number used in the #ifdef. jballon, would you mind actually testing your proposed solution? -- You

[Bug 62428] undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62428 Christopher Schultz changed: What|Removed |Added Resolution|--- |DUPLICATE

[Bug 62122] undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62122 --- Comment #2 from Christopher Schultz --- *** Bug 62428 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62428] undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62428 jbal...@akamai.com changed: What|Removed |Added OS|Mac OS X 10.1 |Linux -- You are receiving this

[Bug 62428] New: undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62428 Bug ID: 62428 Summary: undefined symbol: SSL_COMP_free_compression_methods Product: Tomcat Native Version: 1.2.14 Hardware: PC OS: Mac OS X 10.1 Status: NEW

[Bug 62420] Documents

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62420 Coty Sutherland changed: What|Removed |Added Resolution|WORKSFORME |INVALID -- You are receiving this

[Bug 62420] Documents

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62420 jfclere changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Bug 62122] undefined symbol: SSL_COMP_free_compression_methods

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62122 jfclere changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 62094] Certificate verification using CRL with Tomcat APR connector does not work

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62094 --- Comment #2 from jfclere --- a diff -u would be more easy to review... I can't find CRL FIX in the attachement -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62221] OCSP response processing uses always the first entry in the response

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62221 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1832863 - /tomcat/native/trunk/native/src/sslutils.c

2018-06-04 Thread jfclere
Author: jfclere Date: Mon Jun 4 16:02:26 2018 New Revision: 1832863 URL: http://svn.apache.org/viewvc?rev=1832863=rev Log: follow up for r1832832... more mod_ssl arrangements. Modified: tomcat/native/trunk/native/src/sslutils.c Modified: tomcat/native/trunk/native/src/sslutils.c URL:

svn commit: r1832857 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/digester/Digester.java webapps/docs/changelog.xml

2018-06-04 Thread csutherl
Author: csutherl Date: Mon Jun 4 15:09:26 2018 New Revision: 1832857 URL: http://svn.apache.org/viewvc?rev=1832857=rev Log: Fix potential NullPointerException in replaceSystemProperties() seemingly caused by changing StringManager sm declaration to static Modified: tomcat/tc8.5.x/trunk/

svn commit: r1832856 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java webapps/docs/changelog.xml

2018-06-04 Thread csutherl
Author: csutherl Date: Mon Jun 4 15:07:57 2018 New Revision: 1832856 URL: http://svn.apache.org/viewvc?rev=1832856=rev Log: Fix potential NullPointerException in replaceSystemProperties() seemingly caused by changing StringManager sm declaration to static Modified:

[GitHub] tomcat issue #77: Removed findbugs bad practice warnings by making classes f...

2018-06-04 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/77 These have been resolved since this PR was opened. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

[GitHub] tomcat pull request #77: Removed findbugs bad practice warnings by making cl...

2018-06-04 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/77 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #49: Fix parser to fail if leading zeros in IPv4 part of IPv6 a...

2018-06-04 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/49 Thanks for the patch. Sorry it took a while to apply it. Due to our delays I had to adapt things a little. Fixed in: - trunk for 9.0.9 onwards - 8.5.x for 8.5.32 onwards - 8.0.x for

[GitHub] tomcat pull request #49: Fix parser to fail if leading zeros in IPv4 part of...

2018-06-04 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/49 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832846 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 13:20:53 2018 New Revision: 1832846 URL: http://svn.apache.org/viewvc?rev=1832846=rev Log: Improve IPv6 validation by ensuring that IPv4-Mapped IPv6 addresses do not contain leading zeros in the IPv4 part. Based on a patch by Katya Stoycheva. Modified:

svn commit: r1832845 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 13:20:20 2018 New Revision: 1832845 URL: http://svn.apache.org/viewvc?rev=1832845=rev Log: Improve IPv6 validation by ensuring that IPv4-Mapped IPv6 addresses do not contain leading zeros in the IPv4 part. Based on a patch by Katya Stoycheva. Modified:

svn commit: r1832844 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/ webapps/docs/

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 13:19:52 2018 New Revision: 1832844 URL: http://svn.apache.org/viewvc?rev=1832844=rev Log: Improve IPv6 validation by ensuring that IPv4-Mapped IPv6 addresses do not contain leading zeros in the IPv4 part. Based on a patch by Katya Stoycheva. Modified:

svn commit: r1832843 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/HttpParser.java java/org/apache/tomcat/util/http/parser/LocalStrings.properties test/org/apache/tomcat/util/http/parser

2018-06-04 Thread markt
Author: markt Date: Mon Jun 4 13:18:54 2018 New Revision: 1832843 URL: http://svn.apache.org/viewvc?rev=1832843=rev Log: Improve IPv6 validation by ensuring that IPv4-Mapped IPv6 addresses do not contain leading zeros in the IPv4 part. Based on a patch by Katya Stoycheva. Modified:

svn commit: r1832832 - /tomcat/native/trunk/native/src/sslutils.c

2018-06-04 Thread jfclere
Author: jfclere Date: Mon Jun 4 12:47:18 2018 New Revision: 1832832 URL: http://svn.apache.org/viewvc?rev=1832832=rev Log: adjust the X509_STORE_CTX_get1_issuer() to X509_STORE_CTX_get0_current_issuer() like in mod_ssl httpd. Modified: tomcat/native/trunk/native/src/sslutils.c Modified:

[Bug 62146] Support to add customized KeyManager like "trustManagerClassName" did.

2018-06-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62146 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-06-04 Thread Mark Thomas
On 04/06/18 10:06, Mark Thomas wrote: > Rather than just apply the fix, I'm going to take another look at how > bnd is integrated into the build process. I want to see if there is a > better way to do it. What I was looking for was a way to generate the manifest independently of re-packaging

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-06-04 Thread Mark Thomas
.7.3a-201803300640/ecj-4.7.3a.jar > -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar > -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar > > -Dtest.openssl.path=/srv/gump/public/workspace/ope