Re: New design for the Tomcat website
On 1/3/2019 3:47 PM, Igal Sapir wrote: I added a dropdown to the menu with an icon "A" that opens up a slider that lets you choose a font size (12px, 16, 20). I actually changed it so it's more granular ATM - 12 through 20px with step 1. Opening the Console tab in the browser's Developer Tools shows the font size. Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 Steve Demy changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED|REOPENED --- Comment #2 from Steve Demy --- Tomcat 9.0.14 runs as expected using a transplanted 9.0.13 catalina.sh. It starts, stops and restarts using systemd (systemctl start|stop|restart tomcat). When the server is running netstat shows: tcp6 0 0 :::8080 :::*LISTEN 1038/java tcp6 0 0 127.0.0.1:8005 :::*LISTEN 1038/java tcp6 0 0 :::8009 :::*LISTEN 1038/java unix 2 [ ] STREAM CONNECTED 215671038/java OTOH, using the 9.0.14 version of catalina.sh, and after a fresh system reboot, Tomcat starts normally (similar netstat results) until the first stop. Any subsequent start results in a start/stop loop where the server is running only momentarily during each 10s restart loop. Configuration is default. There are no user webapps nor changes to the default conf/server.xml file. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63056] New: JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37
https://bz.apache.org/bugzilla/show_bug.cgi?id=63056 Bug ID: 63056 Summary: JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37 Product: Tomcat 9 Version: 9.0.14 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: a...@labkey.com Target Milestone: - Created attachment 36364 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36364=edit Archive with simple jsp and bash script Starting with 9.0.14 and 8.5.37, JspC seems to ignore the value of the "uriroot" (aka "webroot") property, as mentioned in post http://mail-archives.apache.org/mod_mbox/tomcat-users/201901.mbox/%3C0317090c-2fab-e04c-1450-6b9ebe0beae7%40labkey.com%3E This change breaks the JSP pre-compilation step of our build, and likely others that use the pattern shown in the JspC JavaDoc example configuration: https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/jasper/JspC.html I've attached a .tgz archive that contains a simple jsp and a bash script that illustrate the problem. The command line used in that bash script is: java -cp /usr/local/apache-tomcat-9.0.14/lib/jasper.jar:/usr/local/apache-tomcat-9.0.14/lib/jasper-el.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-util.jar:/usr/local/apache-tomcat-9.0.14/lib/jsp-api.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-jni.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-api.jar:/usr/local/apache-tomcat-9.0.14/lib/servlet-api.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-util-scan.jar:/usr/local/apache-ant-1.9.13/lib/ant.jar:/usr/local/apache-tomcat-9.0.14/bin/tomcat-juli.jar:/usr/local/apache-tomcat-9.0.14/lib/el-api.jar org.apache.jasper.JspC -source 11 -target 11 -d output -webapp webapp Thanks, Adam -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: POEditor admins
Thanks Mark! If you need a hand to synchronize the content between source and POEditor projects later, I'd like to volunteer for that. I expect the job should be done very carefully though. ;-) Cheers, Woonsan On Wed, Jan 2, 2019 at 6:17 PM Mark Thomas wrote: > > Hi, > > I've just added Woonsan to the admins group for the Tomcat project. If > any other committers want admin rights please create an account if you > don't have one and ping this thread. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On 1/3/2019 12:09 PM, Mark Thomas wrote: On 03/01/2019 17:38, Igal Sapir wrote: Looking at other ASF sites like Kafka, Pulsar, and Spark I don't see the ASF logo at the top - is that really a requirement? Tomcat is popular and its brand is recognizable. ASF logo and trademark notice are there, just not at the top of every page. This shows what is required: https://whimsy.apache.org/site/ (and how compliant various projects are) Good to know. Kafka's compliance is the same as the current Tomcat, and Spark's is at 100%. Note: The current Tomcat non-compliance is deliberate because the associated image was out of date again. I haven't checked to see if it has been updated and the link restored. I'd very much like to see the "Support Apache" button at the top. The ASF logo is nice to have but I'm happy with it where it is (it could even be smaller). I moved the Support Apache icon to the top so we can see how it looks. I'd also echo the comments that have been made regarding font size. I bought a high resolution monitor so I could get lots of text on the screen. I really dislike the current trend of towards larger and larger fonts. What is the best way to put users in control so those that like large fonts have large fonts and those that want lots of text have lots of text? Here's an experiment - I added a dropdown to the menu with an icon "A" that opens up a slider that lets you choose a font size (12px, 16, 20). The size is persisted with localStorage which is supported by all modern browsers, though a cookie can be used instead. I also improved the social media icons and margins on very small screens per Leon's feedback. The Search box can be collapse to preserve screen space and only open up when the search icon is clicked. Please be sure to reload the page, and keep in mind that this is a mockup where not everything is working 100% yet: http://people.apache.org/~isapir/mockups/tomcat-site-1/ Best, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1850271 - in /tomcat/trunk: java/org/apache/catalina/valves/HealthCheckValve.java webapps/docs/changelog.xml
Author: remm
Date: Thu Jan 3 23:06:38 2019
New Revision: 1850271
URL: http://svn.apache.org/viewvc?rev=1850271=rev
Log:
Add very simple health check valve.
Added:
tomcat/trunk/java/org/apache/catalina/valves/HealthCheckValve.java (with
props)
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Added: tomcat/trunk/java/org/apache/catalina/valves/HealthCheckValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/HealthCheckValve.java?rev=1850271=auto
==
--- tomcat/trunk/java/org/apache/catalina/valves/HealthCheckValve.java (added)
+++ tomcat/trunk/java/org/apache/catalina/valves/HealthCheckValve.java Thu Jan
3 23:06:38 2019
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.valves;
+
+import java.io.IOException;
+
+import javax.servlet.ServletException;
+
+import org.apache.catalina.connector.Request;
+import org.apache.catalina.connector.Response;
+import org.apache.tomcat.util.buf.MessageBytes;
+
+
+/**
+ * Simple Valve that responds to cloud orchestrators health checks.
+ */
+public class HealthCheckValve extends ValveBase {
+
+private static final String UP =
+"{\n" +
+" \"status\": \"UP\",\n" +
+" \"checks\": []\n" +
+"}";
+private String path = "/health";
+
+public HealthCheckValve() {
+super(true);
+}
+
+public final String getPath() {
+return path;
+}
+
+public final void setPath(String path) {
+this.path = path;
+}
+
+@Override
+public void invoke(Request request, Response response)
+throws IOException, ServletException {
+MessageBytes requestPathMB = request.getRequestPathMB();
+if (requestPathMB.equals(path)) {
+response.setContentType("application/json");
+response.getOutputStream().print(UP);
+} else {
+getNext().invoke(request, response);
+}
+}
+}
Propchange: tomcat/trunk/java/org/apache/catalina/valves/HealthCheckValve.java
--
svn:eol-style = native
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1850271=1850270=1850271=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 3 23:06:38 2019
@@ -77,6 +77,9 @@
URL may be used for the docBase as this has not been the
case for quite some time. (markt)
+
+Add basic health check valve. (remm)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On 03/01/2019 17:38, Igal Sapir wrote: > Looking at other ASF sites like Kafka, Pulsar, and Spark I don't see the > ASF logo at the top - is that really a requirement? Tomcat is popular > and its brand is recognizable. ASF logo and trademark notice are there, > just not at the top of every page. This shows what is required: https://whimsy.apache.org/site/ (and how compliant various projects are) Note: The current Tomcat non-compliance is deliberate because the associated image was out of date again. I haven't checked to see if it has been updated and the link restored. I'd very much like to see the "Support Apache" button at the top. The ASF logo is nice to have but I'm happy with it where it is (it could even be smaller). I'd also echo the comments that have been made regarding font size. I bought a high resolution monitor so I could get lots of text on the screen. I really dislike the current trend of towards larger and larger fonts. What is the best way to put users in control so those that like large fonts have large fonts and those that want lots of text have lots of text? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On 1/3/2019 8:23 AM, Rémy Maucherat wrote: On Thu, Jan 3, 2019 at 2:59 AM Igal Sapir wrote: I am working on a new design for the Tomcat website and wanted some preliminary feedback. You can see the first mockup at http://people.apache.org/~isapir/mockups/tomcat-site-1/ It's a start, but the bottom of the page looks less polished to me. The ASF logo should probably be on top as well as the "misc" items. Putting everything in the navbar would require a vertical navigation bar like the old one. Otherwise, everything will be too small for usability. Looking at other ASF sites like Kafka, Pulsar, and Spark I don't see the ASF logo at the top - is that really a requirement? Tomcat is popular and its brand is recognizable. ASF logo and trademark notice are there, just not at the top of every page. I also miss the current menu, but it's really a trend I guess :( So a compromise would be if all items are in menus always visible at the top. The navbar is "sticky" as you've probably noticed. When you scroll down the page the navbar shrinks in size and stays at the top. There is limited space there so if we want the new layout we need to pick and choose what stays at the top and what goes in the footer. I'm not really in a rush to have the site replaced though since then the new look would have to be propagated to everything (docs, manager, etc), which means more work. The plan is to encapsulate the design elements so that it's easy to propagate. Best, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On 1/3/2019 8:18 AM, Emmanuel Bourg wrote: I miss the left menu, I know it isn't the current trend but it allows quick access to the main resources of the site (and since the last redesign it folds into a hamburger button when there isn't enough space). That's a design decision that we need to make. I personally think that this new layout is more modern and that a complete redesign is long past due. Also the font is bigger and reduces the number of lines visible. Are you looking on a mobile device or on a desktop? For me, when reading code I usually want to see more lines, but when reading text I care less about the number of lines and want it more readable without zooming in. On the current site I usually zoom in. On this one it is comfortable without zoom. Keep in mind that most of those elements come from the Bootstrap framework, meaning that they are battle tested for usability with millions of deployments. Thanks, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On 1/3/2019 4:29 AM, Leon Rosenberg wrote: Hi Igal, looks good! Two small things though: Quick tested the mobile (responsive) version on an iphone, latest safari, the text seems too far on the left side (no margin between screenend and text). Can send you screenshots if required. Also I find that youtube and twitter icons look misplaced. I noticed that margin/padding thing too on a small device in portrait mode. I'm surprised that that's the default for Bootstrap 4, but didn't want to spend time on that before I get some feedback on the general design. The social media icons were taken from the official sites and are not the same size so they look weird. It was more of a placeholder. I should have clarified better that this is a mockup ;) Best, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On 1/3/2019 5:10 AM, Tim Funk wrote: I noticed that too ... but since the "integrity" attribute is present, it doesn't seem as much a concern. I did notice a few inline "p style="text-align: center;" which seems to be better suited to a class element. But since they seem to be downloads - Keeping them left aligned would work too. Or possibly adding "btn btn-primary" for the download links (but it that is done, the change log links might look out of place, but class="btn btn-secondary" might work for the change log links too) -Tim Quick prototyping with snippets copied from current site etc. Will be all cleaned up once a design is agreed upon. Thanks, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
On Thu, Jan 3, 2019 at 2:59 AM Igal Sapir wrote: > Hi Tomcat team, > > I am working on a new design for the Tomcat website and wanted some > preliminary feedback. > > You can see the first mockup at > http://people.apache.org/~isapir/mockups/tomcat-site-1/ > > Please let me know your thoughts. > It's a start, but the bottom of the page looks less polished to me. The ASF logo should probably be on top as well as the "misc" items. I also miss the current menu, but it's really a trend I guess :( So a compromise would be if all items are in menus always visible at the top. I'm not really in a rush to have the site replaced though since then the new look would have to be propagated to everything (docs, manager, etc), which means more work. Rémy
Re: New design for the Tomcat website
Le 03/01/2019 à 02:59, Igal Sapir a écrit : > I am working on a new design for the Tomcat website and wanted some > preliminary feedback. > > You can see the first mockup at > http://people.apache.org/~isapir/mockups/tomcat-site-1/ > > Please let me know your thoughts. I miss the left menu, I know it isn't the current trend but it allows quick access to the main resources of the site (and since the last redesign it folds into a hamburger button when there isn't enough space). Also the font is bigger and reduces the number of lines visible. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New design for the Tomcat website
Rainer, On Thu, Jan 3, 2019 at 3:13 AM Rainer Jung wrote: > I like the modern design but there are at least 5 objects loaded from 5 > non-apache.org-domains (jquery, cloudflare, bootstrapcdn, googleapis, > gstatic). Personally I would prefer if we wouldn't trigger requests to > non-apache.org-domains. > That is only for quick prototyping so that I can get feedback on the design before moving forward. All of the resources will be concatenated, minified, and delivered from the Tomcat site when done. Thank you for the feedback, Igal
Re: New design for the Tomcat website
I noticed that too ... but since the "integrity" attribute is present, it doesn't seem as much a concern. I did notice a few inline "p style="text-align: center;" which seems to be better suited to a class element. But since they seem to be downloads - Keeping them left aligned would work too. Or possibly adding "btn btn-primary" for the download links (but it that is done, the change log links might look out of place, but class="btn btn-secondary" might work for the change log links too) -Tim On Thu, Jan 3, 2019 at 6:13 AM Rainer Jung wrote: > I like the modern design but there are at least 5 objects loaded from 5 > non-apache.org-domains (jquery, cloudflare, bootstrapcdn, googleapis, > gstatic). Personally I would prefer if we wouldn't trigger requests to > non-apache.org-domains. > >
Re: New design for the Tomcat website
Hi Igal, looks good! Two small things though: Quick tested the mobile (responsive) version on an iphone, latest safari, the text seems too far on the left side (no margin between screenend and text). Can send you screenshots if required. Also I find that youtube and twitter icons look misplaced. kind regards Leon On Thu, Jan 3, 2019 at 12:13 PM Rainer Jung wrote: > Thanks Igal, > > Am 03.01.2019 um 02:59 schrieb Igal Sapir: > > Hi Tomcat team, > > > > I am working on a new design for the Tomcat website and wanted some > > preliminary feedback. > > > > You can see the first mockup at > > http://people.apache.org/~isapir/mockups/tomcat-site-1/ > > > > Please let me know your thoughts. > > I like the modern design but there are at least 5 objects loaded from 5 > non-apache.org-domains (jquery, cloudflare, bootstrapcdn, googleapis, > gstatic). Personally I would prefer if we wouldn't trigger requests to > non-apache.org-domains. > > Regards, > > Rainer > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: New design for the Tomcat website
Thanks Igal, Am 03.01.2019 um 02:59 schrieb Igal Sapir: Hi Tomcat team, I am working on a new design for the Tomcat website and wanted some preliminary feedback. You can see the first mockup at http://people.apache.org/~isapir/mockups/tomcat-site-1/ Please let me know your thoughts. I like the modern design but there are at least 5 objects loaded from 5 non-apache.org-domains (jquery, cloudflare, bootstrapcdn, googleapis, gstatic). Personally I would prefer if we wouldn't trigger requests to non-apache.org-domains. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
