[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #11 from Peter --- If I copy a new war in the appBase directory,nothing happens. No message in the log file. The war does not get unpacked and started until I restart the tomcat. If I upload a new war-file with the Tomcat Manager Webapp, the warfile gets unpacked and started. This behavior is consistant with all my debian based servers. I just did some tests in different environments: - unpack original apache-tomcat-9.0.14.tar.gz - add startStopThreads="0" to the host element of server.xml - start tomcat with openjdk11 (on all systems the same one) - copy a war-file to the appBase directory. I was using two environments: 1) my Laptop (Ubuntu with Kernel 4.18, Intel Core i7) 2) Debian server with Kernel 3.16.39 (on blade with AMD Opteron 6376 Processors) On the Laptop deployment of the war file is working, on the server not. The same test without startStopThreads="0": => war on both systems get deployed Same test with apache-tomcat-9.0.13.tar.gz and startStopThreads="0" => war on both systems get deployed -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-apr has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 5 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-apr : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-APR -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-APR/logs The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr (Type: Build) Work ended in a state of : Failed Elapsed: 20 mins 13 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dtest.temp=output/test-tmp-APR -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Dtest.exclude=**/TestFlushableGZIPOutputStream.java -Dtest.excludePerformance=true -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.j ar -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dexecute.test.apr=true -Dexecute.test.bio=false -Dtest.reports=output/logs-APR -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-1.2-1.0.2/dest-20190117/lib -Dtest.relaxTiming=true -Dexecute.test.nio=false -Dtest.accesslog=true -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20190117.jar -Deasymock.jar=/srv/gump/packages/easymock3/easymock-3.6.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/wo
svn commit: r1851494 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/connector/LocalStrings.properties java/org/apache/catalina/core/AprLifecycleListener
Author: csutherl
Date: Thu Jan 17 02:25:03 2019
New Revision: 1851494
URL: http://svn.apache.org/viewvc?rev=1851494&view=rev
Log:
Log a message when using a Connector that requires Apr without enabling the
AprLifecycleListener first
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1851494&r1=1851493&r2=1851494&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Thu Jan 17
02:25:03 2019
@@ -957,8 +957,12 @@ public class Connector extends Lifecycle
setParseBodyMethods(getParseBodyMethods());
}
+if (protocolHandler.isAprRequired() &&
!AprLifecycleListener.isInstanceCreated()) {
+throw new
LifecycleException(sm.getString("coyoteConnector.protocolHandlerNoAprListener",
+getProtocolHandlerClassName()));
+}
if (protocolHandler.isAprRequired() &&
!AprLifecycleListener.isAprAvailable()) {
-throw new
LifecycleException(sm.getString("coyoteConnector.protocolHandlerNoApr",
+throw new
LifecycleException(sm.getString("coyoteConnector.protocolHandlerNoAprLibrary",
getProtocolHandlerClassName()));
}
if (AprLifecycleListener.isAprAvailable() &&
AprLifecycleListener.getUseOpenSSL() &&
Modified:
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties?rev=1851494&r1=1851493&r2=1851494&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties
[UTF-8] Thu Jan 17 02:25:03 2019
@@ -29,7 +29,8 @@ coyoteConnector.parseBodyMethodNoTrace=T
coyoteConnector.protocolHandlerDestroyFailed=Protocol handler destroy failed
coyoteConnector.protocolHandlerInitializationFailed=Protocol handler
initialization failed
coyoteConnector.protocolHandlerInstantiationFailed=Protocol handler
instantiation failed
-coyoteConnector.protocolHandlerNoApr=The configured protocol [{0}] requires
the APR/native library which is not available
+coyoteConnector.protocolHandlerNoAprListener=The configured protocol [{0}]
requires the AprLifecycleListener which is not available
+coyoteConnector.protocolHandlerNoAprLibrary=The configured protocol [{0}]
requires the APR/native library which is not available
coyoteConnector.protocolHandlerPauseFailed=Protocol handler pause failed
coyoteConnector.protocolHandlerResumeFailed=Protocol handler resume failed
coyoteConnector.protocolHandlerStartFailed=Protocol handler start failed
Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java?rev=1851494&r1=1851493&r2=1851494&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java Thu
Jan 17 02:25:03 2019
@@ -421,4 +421,8 @@ public class AprLifecycleListener
return useOpenSSL;
}
+public static boolean isInstanceCreated() {
+return instanceCreated;
+}
+
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1851494&r1=1851493&r2=1851494&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 17 02:25:03 2019
@@ -84,6 +84,10 @@
Correct a bug exposed in 9.0.14 and ensure that the Tomcat terminates
in
a timely manner when running as a service. (markt)
+
+Log a message when using a Connector that requires Apr without enabling
+the AprLifecycleListener first. (csutherl)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk has an issue affecting its community integration.
This issue affects 4 projects,
and has been outstanding for 10 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk : Tomcat 9.x, a web server implementing the Java Servlet
4.0,
...
- tomcat-trunk-test-apr : Tomcat 9.x, a web server implementing the Java
Servlet 4.0,
...
- tomcat-trunk-test-nio : Tomcat 9.x, a web server implementing the Java
Servlet 4.0,
...
- tomcat-trunk-test-nio2 : Tomcat 9.x, a web server implementing the Java
Servlet 4.0,
...
Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
-DEBUG- Dependency on junit exists, no need to add for property junit.jar.
-INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps]
-INFO- Failed with reason build failed
-DEBUG- Extracted fallback artifacts from Gump Repository
The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
-Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH:
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar:/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar:/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar:/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar
-
[javac] symbol: class ExtensibilityElement
[javac] location: class ServiceRefFactory
[javac]
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java:328:
error: cannot find symbol
[javac] for (ExtensibilityElement ext : extensions) {
[javac] ^
[javac] symbol: class ExtensibilityElement
[javac] location: class ServiceRefFactory
[javac]
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java:329:
error: cannot find symbol
[javac] if (ext instanceof SOAPAddress) {
[javac]^
[javac] symbol: class SOAPAddress
[javac] location: class ServiceRefFactory
[javac]
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java:330:
error: cannot find symbol
[javac] SOAPAddress addr = (SOAPAddress) ext;
[javac] ^
[javac] symbol: class SOAPAddress
[javac] location: class ServiceRefFactory
[javac]
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java:330:
error: cannot find symbol
[javac] SOAPAddress addr = (SOAPAddress) ext;
[javac] ^
[javac] symbol: class SOAPAddress
[javac] location: class ServiceRefFactory
[javac]
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/naming/factory/webservices/ServiceRefFactor
[Bug 63080] New: Support rfc7239 Forwarded header
https://bz.apache.org/bugzilla/show_bug.cgi?id=63080 Bug ID: 63080 Summary: Support rfc7239 Forwarded header Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: bclo...@pivotal.io Target Milestone: Tomcat supports some "X-Forwarded-*" headers with RemoteIpValve and RemoteIpFilter. Tomcat could support the rfc7239 specification and its "Forwarded" header. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1851463 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/
Author: markt Date: Wed Jan 16 15:59:46 2019 New Revision: 1851463 URL: http://svn.apache.org/viewvc?rev=1851463&view=rev Log: Refactor - simplification Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/AbstractStream.java tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Stream.java tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/StreamProcessor.java tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/StreamStateMachine.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Jan 16 15:59:46 2019 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205 3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,176276
svn commit: r1851461 - in /tomcat/trunk/java/org/apache/coyote/http2: AbstractStream.java Http2AsyncUpgradeHandler.java Http2UpgradeHandler.java Stream.java StreamStateMachine.java
Author: markt
Date: Wed Jan 16 15:55:46 2019
New Revision: 1851461
URL: http://svn.apache.org/viewvc?rev=1851461&view=rev
Log:
Refactor - simplification
Modified:
tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java
tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/Stream.java
tomcat/trunk/java/org/apache/coyote/http2/StreamStateMachine.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java?rev=1851461&r1=1851460&r2=1851461&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java Wed Jan 16
15:55:46 2019
@@ -38,13 +38,19 @@ abstract class AbstractStream {
private final Set childStreams = Collections.newSetFromMap(new
ConcurrentHashMap<>());
private long windowSize =
ConnectionSettingsBase.DEFAULT_INITIAL_WINDOW_SIZE;
+
+AbstractStream(Integer identifier) {
+this.identifier = identifier;
+}
+
+
final Integer getIdentifier() {
return identifier;
}
-AbstractStream(Integer identifier) {
-this.identifier = identifier;
+final int getIdAsInt() {
+return identifier.intValue();
}
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java?rev=1851461&r1=1851460&r2=1851461&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java Wed
Jan 16 15:55:46 2019
@@ -195,7 +195,7 @@ public class Http2AsyncUpgradeHandler ex
}
}
if (writeable) {
-ByteUtil.set31Bits(header, 5, stream.getIdentifier().intValue());
+ByteUtil.set31Bits(header, 5, stream.getIdAsInt());
int orgLimit = data.limit();
data.limit(data.position() + len);
socketWrapper.write(BlockingMode.BLOCK, protocol.getWriteTimeout(),
@@ -223,7 +223,7 @@ public class Http2AsyncUpgradeHandler ex
ByteUtil.setThreeBytes(frame2, 0, 4);
frame2[3] = FrameType.WINDOW_UPDATE.getIdByte();
ByteUtil.set31Bits(frame2, 9, increment);
-ByteUtil.set31Bits(frame2, 5, stream.getIdentifier().intValue());
+ByteUtil.set31Bits(frame2, 5, stream.getIdAsInt());
socketWrapper.write(BlockingMode.SEMI_BLOCK,
protocol.getWriteTimeout(),
TimeUnit.MILLISECONDS, null, SocketWrapperBase.COMPLETE_WRITE,
errorCompletion,
ByteBuffer.wrap(frame), ByteBuffer.wrap(frame2));
@@ -301,7 +301,7 @@ public class Http2AsyncUpgradeHandler ex
}
}
if (writeable) {
-ByteUtil.set31Bits(header, 5,
sendfile.stream.getIdentifier().intValue());
+ByteUtil.set31Bits(header, 5, sendfile.stream.getIdAsInt());
sendfile.mappedBuffer.limit(sendfile.mappedBuffer.position() +
frameSize);
socketWrapper.write(BlockingMode.SEMI_BLOCK,
protocol.getWriteTimeout(),
TimeUnit.MILLISECONDS, sendfile,
SocketWrapperBase.COMPLETE_WRITE_WITH_COMPLETION,
@@ -362,7 +362,7 @@ public class Http2AsyncUpgradeHandler ex
}
}
if (writeable) {
-ByteUtil.set31Bits(header, 5,
sendfile.stream.getIdentifier().intValue());
+ByteUtil.set31Bits(header, 5, sendfile.stream.getIdAsInt());
sendfile.mappedBuffer.limit(sendfile.mappedBuffer.position() +
frameSize);
socketWrapper.write(BlockingMode.SEMI_BLOCK,
protocol.getWriteTimeout(),
TimeUnit.MILLISECONDS, sendfile,
SocketWrapperBase.COMPLETE_WRITE_WITH_COMPLETION,
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1851461&r1=1851460&r2=1851461&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Wed Jan
16 15:55:46 2019
@@ -601,7 +601,7 @@ class Http2UpgradeHandler extends Abstra
if (log.isDebugEnabled()) {
log.debug(headerFrameBuffers.getPayload().limit() + "
bytes");
}
-ByteUtil.set31Bits(headerFrameBuffers.getHeader
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #10 from Remy Maucherat --- Except the use of startStopThreads="0" which uses parallel deployment, this looks like a default configuration. There is nothing which radically changes in the deployer with parallel deployment here. And the executor refactoring, although the prime suspect since it's a big change, simply uses an executor somewhere else. You can also test simpler scenarios. Does dropping a war into the host appBase auto deploys it ? If so, the most likely problem is the undeployment, if it is not clean then the same webapp will never be deployed again until a restart. Can you verify if the undeploy is clean using JMX ? (you should see beans for the deployed webapps, and other beans will give out their state) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 51294] Since 7.0.12 do not work option unpackWARs=true for WARs outside appBase
On 16/01/2019 12:56, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=51294 > > --- Comment #30 from Caroline Webb --- > I read comments carefully that also referable about option unpackWARs=true for > WARs outside appBase since 7.0.12 do not work. Keep sharing and providing > solutions to users. Account blocked. I'm in the process of deleting this and any other comments they may have made. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 51294] Since 7.0.12 do not work option unpackWARs=true for WARs outside appBase
https://bz.apache.org/bugzilla/show_bug.cgi?id=51294 --- Comment #30 from Caroline Webb --- I read comments carefully that also referable about option unpackWARs=true for WARs outside appBase since 7.0.12 do not work. Keep sharing and providing solutions to users. Caroline, http://www.personalstatementfolks.co.uk/ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #9 from Peter --- Hi, her is my server.xml file. Like mentioned before, I do use exactly the same with Tomcat 9.0.13 and 9.0.14. If I remove the attribute startStopThreads="0" from the host element, autodeployment is working on 9.014. Best regard Peter P.S. Thank's a lot for the support. I really do appreciate your work. Tomcat is a great pice of software which I am using already for many years. -- -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #8 from Mark Thomas --- Just a thought. I can't reproduce it either. Neither did a code inspection suggest any potential configuration that would cause it. Peter - can you provide the server.xml file for the 9.0.14 install that exhibits this issue please. xx out any sensitive values such as passwords. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #7 from Remy Maucherat --- (In reply to Mark Thomas from comment #5) > Related to the server executor refactoring? That sounds like it, but I cannot reproduce the issue using the steps and configuration given. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #5 from Mark Thomas --- Related to the server executor refactoring? --- Comment #6 from Mark Thomas --- Related to the server executor refactoring? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63078] autodeploy in Tomcat 9.0.14 is not working anymore
https://bz.apache.org/bugzilla/show_bug.cgi?id=63078 --- Comment #5 from Mark Thomas --- Related to the server executor refactoring? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
