[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2019-01-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2019-01-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-apr has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-01-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2019-01-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-nio has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio (in module tomcat-8.5.x) failed

2019-01-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-nio has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2019-01-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-23 Thread Rainer Jung
Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when OpenSSL provides the TLS functionality for the NIO and NIO2 connectors) Various other fixes and

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-23 Thread Igal Sapir
On 1/23/2019 1:56 PM, Mark Thomas wrote: On 23/01/2019 21:48, bugzi...@apache.org wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 --- Comment #14 from Mark Thomas --- Created attachment 36389 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36389=edit Tomcat 9 patch to

buildbot failure in on tomcat-7-trunk

2019-01-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1244 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-23 Thread Mark Thomas
On 23/01/2019 21:55, VP Brand wrote: Sorry. No idea why my mail client picked that senders address. I must have hit the wrong button. Mark > On 23/01/2019 21:48, bugzi...@apache.org wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 >> >> --- Comment #14 from Mark Thomas --- >>

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-23 Thread VP Brand
On 23/01/2019 21:48, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 > > --- Comment #14 from Mark Thomas --- > Created attachment 36389 > --> https://bz.apache.org/bugzilla/attachment.cgi?id=36389=edit > Tomcat 9 patch to retain app provided content-type > >

[Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 --- Comment #14 from Mark Thomas --- Created attachment 36389 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36389=edit Tomcat 9 patch to retain app provided content-type The application provided content-type is only retained if no

svn commit: r1851985 - /tomcat/trunk/test/org/apache/coyote/TestResponse.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 21:39:11 2019 New Revision: 1851985 URL: http://svn.apache.org/viewvc?rev=1851985=rev Log: Add a test case for BZ 62912 Modified: tomcat/trunk/test/org/apache/coyote/TestResponse.java Modified: tomcat/trunk/test/org/apache/coyote/TestResponse.java URL:

[Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 Mark Thomas changed: What|Removed |Added Severity|critical|enhancement --- Comment #13 from Mark

[Bug 63003] Tomcat is closing async connection prematurely when shutdown is initiated.

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63003 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: svn commit: r1851983 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/ java/org/apache/coyote/

2019-01-23 Thread Mark Thomas
On 23/01/2019 21:07, ma...@apache.org wrote: > Author: markt > Date: Wed Jan 23 21:07:10 2019 > New Revision: 1851983 > > URL: http://svn.apache.org/viewvc?rev=1851983=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63003 > Extend the unloadDelay attribute on a Context to include

svn commit: r1851983 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/ java/org/apache/coyote/http

2019-01-23 Thread markt
Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1851983=1851982=1851983=diff ==

svn commit: r1851983 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/ java/org/apache/coyote/http

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 21:07:10 2019 New Revision: 1851983 URL: http://svn.apache.org/viewvc?rev=1851983=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63003 Extend the unloadDelay attribute on a Context to include in-flight asynchronous requests. Modified:

svn commit: r1851948 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/ test/org/apache/tomcat/unittest/

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 16:36:02 2019 New Revision: 1851948 URL: http://svn.apache.org/viewvc?rev=1851948=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63003 Extend the unloadDelay attribute on a Context to include in-flight asynchronous requests. Modified:

svn commit: r1851947 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/ test/org/apache/tomcat/unittest/ webapps/doc

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 16:33:47 2019 New Revision: 1851947 URL: http://svn.apache.org/viewvc?rev=1851947=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63003 Extend the unloadDelay attribute on a Context to include in-flight asynchronous requests. Modified:

[Bug 63104] As per servlet api doc ServletContext.getResource should throw MalformedURLException but for some urls tomcat 8 is throwing IllegalArgumentException which is deviation for api.

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63104 Mark Thomas changed: What|Removed |Added OS||All Resolution|---

[Bug 62992] Error on Method Call PropertyNotFoundException inside component

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62992 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO

[Bug 63026] JNDIRealm fails to authenticate user with 2 trailing spaces CN

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63026 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1851942 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java test/org/apache/catalina/realm/TestJNDIRealmConvertToHexEscape.java webapps/docs/changelog.xml webapps

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:19:07 2019 New Revision: 1851942 URL: http://svn.apache.org/viewvc?rev=1851942=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63026 Add a new attribute, forceDnHexEscape, to the JNDIRealm that forces escaping in the String representation of a

svn commit: r1851941 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java test/org/apache/catalina/realm/TestJNDIRealmConvertToHexEscape.java webapps/docs/changelog.xml webapps

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:11:07 2019 New Revision: 1851941 URL: http://svn.apache.org/viewvc?rev=1851941=rev Log: Add a new attribute, forceDnHexEscape, to the JNDIRealm that forces escaping in the String representation of a distinguished name to use the \nn form. This may avoid issues

svn commit: r1851940 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:10:26 2019 New Revision: 1851940 URL: http://svn.apache.org/viewvc?rev=1851940=rev Log: Refactor to simplify the fix for BZ 63026 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java

svn commit: r1851939 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:09:37 2019 New Revision: 1851939 URL: http://svn.apache.org/viewvc?rev=1851939=rev Log: Refactor to simplify the fix for BZ 63026 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java

svn commit: r1851938 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/realm/TestJNDIRealm.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:08:06 2019 New Revision: 1851938 URL: http://svn.apache.org/viewvc?rev=1851938=rev Log: Fix indenting Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/realm/TestJNDIRealm.java Propchange:

svn commit: r1851937 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/realm/TestJNDIRealm.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:07:37 2019 New Revision: 1851937 URL: http://svn.apache.org/viewvc?rev=1851937=rev Log: Fix indenting Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catalina/realm/TestJNDIRealm.java Propchange:

svn commit: r1851933 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/ test/org/apache/catalina/authenticator/ webapps/docs/ webapps/docs/config/

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 15:01:09 2019 New Revision: 1851933 URL: http://svn.apache.org/viewvc?rev=1851933=rev Log: Make the removal of leading and trailing whitespace from credentials passed to BASIC authentication configurable via a new attribute, trimCredentials on the

buildbot success in on tomcat-trunk

2019-01-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3974 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1851928 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java test/org/apache/catalina/realm/TestJNDIRealmConvertToHexEscape.java webapps/docs/changelog.xml webapps/docs/confi

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 14:45:34 2019 New Revision: 1851928 URL: http://svn.apache.org/viewvc?rev=1851928=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63026 Add a new attribute, forceDnHexEscape, to the JNDIRealm that forces escaping in the String representation of a

svn commit: r1851926 - /tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 14:36:07 2019 New Revision: 1851926 URL: http://svn.apache.org/viewvc?rev=1851926=rev Log: Play nicely with folks extending this class Modified: tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java Modified:

svn commit: r1851924 - /tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 14:27:00 2019 New Revision: 1851924 URL: http://svn.apache.org/viewvc?rev=1851924=rev Log: Fix Javadoc error. Note https://bugs.openjdk.java.net/browse/JDK-8031625 Modified: tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java Modified:

buildbot failure in on tomcat-trunk

2019-01-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3973 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1851921 - /tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 14:06:06 2019 New Revision: 1851921 URL: http://svn.apache.org/viewvc?rev=1851921=rev Log: Refactor to simplify the fix for BZ 63026 Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Modified:

svn commit: r1851919 - /tomcat/trunk/test/org/apache/catalina/realm/TestJNDIRealm.java

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 14:01:38 2019 New Revision: 1851919 URL: http://svn.apache.org/viewvc?rev=1851919=rev Log: Fix indenting Modified: tomcat/trunk/test/org/apache/catalina/realm/TestJNDIRealm.java Modified: tomcat/trunk/test/org/apache/catalina/realm/TestJNDIRealm.java URL:

svn commit: r1851916 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ test/org/apache/catalina/authenticator/ webapps/docs/ webapps/docs/config/

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 13:57:50 2019 New Revision: 1851916 URL: http://svn.apache.org/viewvc?rev=1851916=rev Log: Make the removal of leading and trailing whitespace from credentials passed to BASIC authentication configurable via a new attribute, trimCredentials on the

[Bug 63104] New: As per servlet api doc ServletContext.getResource should throw MalformedURLException but for some urls tomcat 8 is throwing IllegalArgumentException which is deviation for api.

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63104 Bug ID: 63104 Summary: As per servlet api doc ServletContext.getResource should throw MalformedURLException but for some urls tomcat 8 is throwing IllegalArgumentException which is

Fwd: File descriptors leak when using websocket client

2019-01-23 Thread vtarasov
Hello! We have file descriptors leak when we use websocket client. Our environment: 1. spring-boot 2.0.6 2. tomcat-embed 8.5.34 3. ubuntu 16.04 How to reproduce: 1. Connect to websocket server with using of WsWebSocketContainer (after this step we will have WsSession and

Re: UMASK in "catalina.sh"

2019-01-23 Thread Mark Thomas
On 23/01/2019 12:02, Martin Knoblauch wrote: > Hi Mark, > > thanks a lot. So, now I know the code was added in revision 1713174. The > real question I have is into which releases this went. > > OK, in this case I see it went into 8.5 and 9.0 from the beginning. But say > a change went into

Re: UMASK in "catalina.sh"

2019-01-23 Thread Martin Knoblauch
Hi Mark, thanks a lot. So, now I know the code was added in revision 1713174. The real question I have is into which releases this went. OK, in this case I see it went into 8.5 and 9.0 from the beginning. But say a change went into 9.0.12 - is there a way to find that from SVN? Cheers Martin

Re: UMASK in "catalina.sh"

2019-01-23 Thread Mark Thomas
On 23/01/2019 10:57, Martin Knoblauch wrote: > Hi, > > sorry for the noise, but maybe you are quicker than me rummaging through > SVN :-) > > I would like to know when the following code snippet was added to > "catalina.sh":

UMASK in "catalina.sh"

2019-01-23 Thread Martin Knoblauch
Hi, sorry for the noise, but maybe you are quicker than me rummaging through SVN :-) I would like to know when the following code snippet was added to "catalina.sh": # Set UMASK unless it has been overridden if [ -z "$UMASK" ]; then UMASK="0027" fi umask $UMASK I see it in current 9.0.x

[Bug 63103] Consider removing "source.jsp" from examples

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63103 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1851897 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml webapps/examples/WEB-INF/classes/examples/ShowSource.java webapps/examples/WEB-INF/jsp/example-taglib.tld webap

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 09:12:12 2019 New Revision: 1851897 URL: http://svn.apache.org/viewvc?rev=1851897=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63103 Remove the unused source.jsp file and associated tag from the examples web application as it is no longer used.

svn commit: r1851896 - in /tomcat/tc8.5.x/trunk: ./ build.xml webapps/docs/changelog.xml webapps/examples/WEB-INF/classes/examples/ShowSource.java webapps/examples/WEB-INF/jsp/example-taglib.tld webap

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 09:04:50 2019 New Revision: 1851896 URL: http://svn.apache.org/viewvc?rev=1851896=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63103 Remove the unused source.jsp file and associated tag from the examples web application as it is no longer used.

svn commit: r1851895 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml webapps/examples/WEB-INF/classes/examples/ShowSource.java webapps/examples/WEB-INF/jsp/example-taglib.tld webapps/examples

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 09:03:45 2019 New Revision: 1851895 URL: http://svn.apache.org/viewvc?rev=1851895=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63103 Remove the unused source.jsp file and associated tag from the examples web application as it is no longer used.

[Bug 63103] Consider removing "source.jsp" from examples

2019-01-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63103 --- Comment #1 from Mark Thomas --- I don't think there is much of a security argument for removing this JSP since it can only expose source code for files that are in the examples app and all that source is already publicly available.

[Tomcat Wiki] Update of "ContributorsGroup" by markt

2019-01-23 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "ContributorsGroup" page has been changed by markt: https://wiki.apache.org/tomcat/ContributorsGroup?action=diff=33=34 Comment: += GarretWilson * developintelligence *

svn commit: r1851891 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2019-01-23 Thread markt
Author: markt Date: Wed Jan 23 08:24:11 2019 New Revision: 1851891 URL: http://svn.apache.org/viewvc?rev=1851891=rev Log: Move bz 63401 entry to correct version Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml URL: