svn commit: r1853051 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/LocalStrings.properties java/org/apache/catalina/tribes/membership/StaticMembershipService.java webapps/docs/changel

2019-02-05 Thread kfujino 
Author: kfujino
Date: Wed Feb  6 07:46:54 2019
New Revision: 1853051

URL: http://svn.apache.org/viewvc?rev=1853051=rev
Log:
Add feature that discover local member from the static member list.
This makes the same static member configuration available on all cluster nodes.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties

tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties?rev=1853051=1853050=1853051=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties 
[UTF-8] (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties 
[UTF-8] Wed Feb  6 07:46:54 2019
@@ -61,5 +61,5 @@ staticMembershipProvider.pingThread.fail
 staticMembershipProvider.replyRequest.ignored=Message[{0}] is ignored.
 staticMembershipProvider.startMembership.noReplies=Received 0 replies, 
probably a timeout.
 staticMembershipProvider.stopMembership.sendFailed=Unable to send stop 
membership message.
-
+staticMembershipService.noLocalMember=There is no localMember in static member 
list.
 staticMembershipService.stopFail=Unable to stop the static membership service, 
level: [{0}]

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java?rev=1853051=1853050=1853051=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
 Wed Feb  6 07:46:54 2019
@@ -18,7 +18,9 @@
 package org.apache.catalina.tribes.membership;
 
 import java.io.IOException;
+import java.net.InetAddress;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Properties;
 
 import javax.management.ObjectName;
@@ -107,7 +109,10 @@ public class StaticMembershipService ext
 @Override
 public void setLocalMemberProperties(String listenHost, int listenPort,
 int securePort, int udpPort) {
+properties.setProperty("tcpListenHost", listenHost);
+properties.setProperty("tcpListenPort", String.valueOf(listenPort));
 try {
+findLocalMember();
 localMember.setHostname(listenHost);
 localMember.setPort(listenPort);
 localMember.setSecurePort(securePort);
@@ -223,4 +228,21 @@ public class StaticMembershipService ext
 private String getMembershipName() {
 return channel.getName()+"-"+"StaticMembership";
 }
+
+private void findLocalMember() throws IOException {
+if (this.localMember != null) return;
+String listenHost = properties.getProperty("tcpListenHost");
+String listenPort = properties.getProperty("tcpListenPort");
+
+// find local member from static members
+for (StaticMember staticMember : this.staticMembers) {
+if (Arrays.equals(InetAddress.getByName(listenHost).getAddress(), 
staticMember.getHost())
+&& Integer.valueOf(listenPort) == staticMember.getPort()) {
+this.localMember = staticMember;
+break;
+}
+}
+if (this.localMember == null)  throw new 
IllegalStateException(sm.getString("staticMembershipService.noLocalMember"));
+staticMembers.remove(this.localMember);
+}
 }
\ No newline at end of file

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1853051=1853050=1853051=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Feb  6 07:46:54 2019
@@ -45,6 +45,14 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Add feature that discover local member from the static member list.
+(kfujino)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-apr (in module tomcat-8.5.x) failed

2019-02-05 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.5.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 120 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.5.x-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.5.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.5.x/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.5.x/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-test-apr/gump_work/build_tomcat-8.5.x_tomcat-tc8.5.x-test-apr.html
Work Name: build_tomcat-8.5.x_tomcat-tc8.5.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 18 mins 41 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.5.x/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR -Dexecute.test.nio2=false 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.5.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-1.2-1.1.1/dest-20190206/lib
 -Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dtest.op
 enssl.path=/srv/gump/public/workspace/openssl-1.1.1/dest-20190206/bin/openssl 
-Dexecute.test.bio=false -Dexecute.test.apr=true -Dtest.excludePerformance=true 
-Deasymock.jar=/srv/gump/packages/easymock3/easymock-3.6.jar 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.5.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.5.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/bu

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-02-05 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 15 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dsaaj-api.jar=/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar 
-Djaxrpc-lib.jar=/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar 
-Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190206/bin/openssl
 -Dexecute
 .test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dexecute.test.apr=false 
-Dwsdl4j-lib.jar=/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar 
-Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja

Re: Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-05 Thread Romain Manni-Bucau 
As an user c sounds ok. Worse case maybe keep it for 1 release with some
comm to have time to migrate if relevant.

Le mar. 5 févr. 2019 à 20:10, Rémy Maucherat  a écrit :

> On Tue, Feb 5, 2019 at 7:58 PM Mark Thomas  wrote:
>
> > Hi,
> >
> > org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES
> >
> > The above system property was added to address an issue with Tomcat's
> > WebSocket implementation not passing the TCK. Tomcat was sending empty
> > messages when the TCK wasn't expecting a message to be sent.
> >
> > Now that we have access to the TCK I have been able to track down the
> > root cause of these failures.
> >
> > The root cause is this code in WsRemoteEndpointImplBase:
> > ...
> > } else if (encoder instanceof Encoder.TextStream) {
> > try (Writer w = getSendWriter()) {
> > ((Encoder.TextStream) encoder).encode(obj, w);
> > }
> > }
> >
> > The call to getSendWriter() triggers the state change that a write has
> > started. Then the exception is thrown and because of the
> > try-with-resources close() is called. That triggers the end of message
> > state change hence a zero length message is written.
> >
> > The STREAMS_DROP_EMPTY_MESSAGES causes all empty messages (not just in
> > this error case) to be dropped.
> >
> > I'm currently thinking that handling of this error case and
> > STREAMS_DROP_EMPTY_MESSAGES should be decoupled. The idea is that, in
> > the above case, obtaining the Writer is delayed until the encoder tries
> > to write bytes.
> >
> > If the above change is implemented then what should be happen to
> > STREAMS_DROP_EMPTY_MESSAGES?
> > a) keep it as is
> > b) deprecate it and remove it in 10.x
> > c) remove it now
> >
> > I'm leaning towards b)
> >
>
> You could probably do c) as the only purpose was to stick to the TCK
> behavior. When there is no spec, the TCK is supposed to be the referee (and
> I don't really see why empty messages are useful).
>
> Rémy
>
>
> >
> > Thoughts?
> >
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>

Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)

2019-02-05 Thread Igal Sapir 
On Tue, Feb 5, 2019 at 11:12 AM Emmanuel Bourg  wrote:

> Le 05/02/2019 à 19:02, Igal Sapir a écrit :
>
> > Do you get any "missing ciphers" errors or not even that?  I always get
> > some test cases fail due to mismatching ciphers, which I accept as false
> > positives, so I wonder about that.
>
> Yes that's normal, some ciphers are disabled in Debian (IDEA and ARIA).
> There is a patch adjusting the tests accordingly:
>
>
> https://salsa.debian.org/java-team/tomcat8/blob/master/debian/patches/0021-dont-test-unsupported-ciphers.patch
>
> Emmanuel Bourg
>

I see.  That makes sense, thanks.

What do you guys think if I add a system property like
`test.unimplementedciphers` with an empty default, which can be used, e.g.:

test.unimplementedciphers=ARIA,IDEA

Then any cipher that has in its name the substring ARIA or IDEA will be
skipped?

Igal

Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)

2019-02-05 Thread Igal Sapir 
On Tue, Feb 5, 2019 at 10:02 AM Igal Sapir  wrote:

> Emmanuel,
>
> On 2/5/2019 6:27 AM, Emmanuel Bourg wrote:
>
> > 
> > Tested on Debian with OpenJDK 11.0.2, OpenSSL 1.1.1a and Tomcat Native
> > 1.2.21. No failure on the 3 test suites.
>
> Do you get any "missing ciphers" errors or not even that?  I always get
> some test cases fail due to mismatching ciphers, which I accept as false
> positives, so I wonder about that.
>

Log entries of failed test cases can be seen at:
https://github.com/isapir/scrapbook/blob/master/tomcat-test-failed-ciphers-20190205.log

Igal

Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)

2019-02-05 Thread Emmanuel Bourg 
Le 05/02/2019 à 19:02, Igal Sapir a écrit :

> Do you get any "missing ciphers" errors or not even that?  I always get
> some test cases fail due to mismatching ciphers, which I accept as false
> positives, so I wonder about that.

Yes that's normal, some ciphers are disabled in Debian (IDEA and ARIA).
There is a patch adjusting the tests accordingly:

https://salsa.debian.org/java-team/tomcat8/blob/master/debian/patches/0021-dont-test-unsupported-ciphers.patch

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-05 Thread Rémy Maucherat 
On Tue, Feb 5, 2019 at 7:58 PM Mark Thomas  wrote:

> Hi,
>
> org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES
>
> The above system property was added to address an issue with Tomcat's
> WebSocket implementation not passing the TCK. Tomcat was sending empty
> messages when the TCK wasn't expecting a message to be sent.
>
> Now that we have access to the TCK I have been able to track down the
> root cause of these failures.
>
> The root cause is this code in WsRemoteEndpointImplBase:
> ...
> } else if (encoder instanceof Encoder.TextStream) {
> try (Writer w = getSendWriter()) {
> ((Encoder.TextStream) encoder).encode(obj, w);
> }
> }
>
> The call to getSendWriter() triggers the state change that a write has
> started. Then the exception is thrown and because of the
> try-with-resources close() is called. That triggers the end of message
> state change hence a zero length message is written.
>
> The STREAMS_DROP_EMPTY_MESSAGES causes all empty messages (not just in
> this error case) to be dropped.
>
> I'm currently thinking that handling of this error case and
> STREAMS_DROP_EMPTY_MESSAGES should be decoupled. The idea is that, in
> the above case, obtaining the Writer is delayed until the encoder tries
> to write bytes.
>
> If the above change is implemented then what should be happen to
> STREAMS_DROP_EMPTY_MESSAGES?
> a) keep it as is
> b) deprecate it and remove it in 10.x
> c) remove it now
>
> I'm leaning towards b)
>

You could probably do c) as the only purpose was to stick to the TCK
behavior. When there is no spec, the TCK is supposed to be the referee (and
I don't really see why empty messages are useful).

Rémy


>
> Thoughts?
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 8.5.38

2019-02-05 Thread Igal Sapir 
On Tue, Feb 5, 2019 at 4:22 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.38 release is now available for voting.
>
> The major changes compared to the 8.5.37 release are:
>
>  - Update the packaged version of the Tomcat Native Library to 1.2.21
>to pick up the memory leak fixes when using NIO/NIO2 with OpenSSL.
>
>  - Correct a regression in the fix for 53737 that did not correctly
>scan the web application directory structure for JSPs.
>
>  - Improve HTTP/2 timeout handling
>
>
> Along with lots of other bug fixes and improvements.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.38/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1203/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
>
> The proposed 8.5.38 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.38
>

Tested on Ubuntu 18.04 with Java 1.8u192 and Native 1.2.21

Igal

Proposed change to STREAMS_DROP_EMPTY_MESSAGES system property

2019-02-05 Thread Mark Thomas 
Hi,

org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES

The above system property was added to address an issue with Tomcat's
WebSocket implementation not passing the TCK. Tomcat was sending empty
messages when the TCK wasn't expecting a message to be sent.

Now that we have access to the TCK I have been able to track down the
root cause of these failures.

The root cause is this code in WsRemoteEndpointImplBase:
...
} else if (encoder instanceof Encoder.TextStream) {
try (Writer w = getSendWriter()) {
((Encoder.TextStream) encoder).encode(obj, w);
}
}

The call to getSendWriter() triggers the state change that a write has
started. Then the exception is thrown and because of the
try-with-resources close() is called. That triggers the end of message
state change hence a zero length message is written.

The STREAMS_DROP_EMPTY_MESSAGES causes all empty messages (not just in
this error case) to be dropped.

I'm currently thinking that handling of this error case and
STREAMS_DROP_EMPTY_MESSAGES should be decoupled. The idea is that, in
the above case, obtaining the Writer is delayed until the encoder tries
to write bytes.

If the above change is implemented then what should be happen to
STREAMS_DROP_EMPTY_MESSAGES?
a) keep it as is
b) deprecate it and remove it in 10.x
c) remove it now

I'm leaning towards b)

Thoughts?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Test Case Ciphers (was: Release Apache Tomcat 8.5.38)

2019-02-05 Thread Igal Sapir 

Emmanuel,

On 2/5/2019 6:27 AM, Emmanuel Bourg wrote:



Tested on Debian with OpenJDK 11.0.2, OpenSSL 1.1.1a and Tomcat Native
1.2.21. No failure on the 3 test suites.


Do you get any "missing ciphers" errors or not even that?  I always get 
some test cases fail due to mismatching ciphers, which I accept as false 
positives, so I wonder about that.


Thanks,

Igal




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.38

2019-02-05 Thread Emmanuel Bourg 
Le 05/02/2019 à 13:22, Mark Thomas a écrit :

> The proposed 8.5.38 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.38

Tested on Debian with OpenJDK 11.0.2, OpenSSL 1.1.1a and Tomcat Native
1.2.21. No failure on the 3 test suites.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Jakarta EE - WebSocket TCK (nightly)

2019-02-05 Thread Mark Thomas 
On 04/02/2019 16:09, Rémy Maucherat wrote:
> On Fri, Feb 1, 2019 at 5:14 PM Rémy Maucherat  wrote:
> 
>> On Fri, Feb 1, 2019 at 4:50 PM Mark Thomas  wrote:



>> Will have to look at it again then.
>>
> 
> Ok, I think I was completely ignoring the Tomcat client back then, instead
> using Tyrus, to avoid mixing client and server issues together. So after
> investigating, it looks like a race condition on the session being in the
> process of being closed and a message being received by the client
> concurrently. I put a proposal in the wiki (all tests pass with it).

I think the root cause is different. With the configured system
properties timeouts are checked every ~10 seconds. The tests expect a
timeout to occur between 4 & 8 seconds. There is a ~40% chance of the
test passing during a run which explains the intermittent nature.

I've updated the wiki with the necessary configuration.

There are a couple of things these tests have highlighted that I think
are worthy of more discussion. I'll start new threads for those.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat-native pull request #4: Fixing Client Certificate Based Authenticatio...

2019-02-05 Thread milindt 
GitHub user milindt opened a pull request:

https://github.com/apache/tomcat-native/pull/4

Fixing Client Certificate Based Authentication for Certificates without 
OCSP OID id-ad-ocsp

## Issue:

Certificate base authentication was failing on Tomcat 9. The connection 
used to get reset(RST) without any prior or post warnings. After some initial 
debugging using Wireshark, I came to know that the initial handshake was 
successful, yet the connection was ended abruptly by the tomcat server. So I 
had to look into the Tomcat native 
wrapper(1.2.19)(http://tomcat.apache.org/native-doc/) over OpenSSL to debug the 
issue further.

## RCA:
1. After a lot of debugging I came to know that the origin of the failure 
was not the Client Certificate Authentication part. Though client 
authentication was successful every time, some other module was changing the 
error code from 0 to 50(source: 
`tomcat-native-1.2.19-src/native/src/sslutils.c`, functions: `handshake` and 
`SSL_callback_SSL_verify`)
2. On referring the error code from 
[here](https://github.com/openssl/openssl/blob/master/include/openssl/x509_vfy.h),
 I came to know OCSP verification part was causing the application 
failure(Error code `X509_V_ERR_APPLICATION_VERIFICATION`). OCSP reference: 
https://en.wikipedia.org/wiki/Online_Certificate_Status_Protocol
3. On debugging further, I found that client certificate was missing the 
OCSP URI info from one of the extensions(Authority Information Access OR 
NID_info_access). Refer following URL for more info on 
extensions(https://www.openssl.org/docs/man1.1.0/crypto/X509_get_ext_d2i.html)
4. From these RFCs(https://tools.ietf.org/html/rfc5280 and 
https://tools.ietf.org/html/rfc2560) I confirmed that the OCSP URI Info(OID 
id-ad-ocsp) may or may not be included in the certificate by the issuer.
5. This causes the OCSP verification to fail, causing the connection 
reset(source: `tomcat-native-1.2.19-src/native/src/sslutils.c`, function: 
ssl_ocsp_request). I could confirm from the code that OCSP verification was 
done, even though ocsp_urls were empty(a null check was present)
6. On searching for the source online, I found the code annotations for 
[sslutils.c](https://github.com/apache/tomcat-native/blame/3cd7fdceee92c53ca726ffee33b49bf2c77acaba/native/src/sslutils.c#L1096)
7. With help of that I could locate the exact 
[changeset](https://github.com/apache/tomcat-native/commit/23c205ceb277f73fd95d093adbc2c4890c574c1b?diff=split)
 which caused the trouble.
8. On inspecting the Tomcat Native code further(source: 
`tomcat-native-1.2.19-src/native/src/sslutils.c`, functions: ssl_ocsp_request, 
decode_OCSP_url and parse_ASN1_Sequence) I was able to pin point the root cause.
9. The decode_OCSP_url function returns a null value if parse_ASN1_Sequence 
returns a non-zero value(failure case). But even when OCSP oid is missing from 
the certificate extension, parse_ASN1_Sequence returns a zero(success case), 
making decode_OCSP_url to return a non null value, which in turn makes 
ssl_ocsp_request validate an empty OCSP URL.

## Fix:
In the Tomcat Native code(source: 
tomcat-native-1.2.19-src/native/src/sslutils.c, functions: ssl_ocsp_request, 
decode_OCSP_url and parse_ASN1_Sequence), parse_ASN1_Sequence also modifies the 
number of OCSP URLs found. We can add additional check in decode_OCSP_url that 
if numofresponses ==0, then also return NULL. This will make ssl_ocsp_request 
skip the unnecessary OCSP verification, when OSCP URL info is missing from the 
client certificate.

## Testing:
1. Apply the fix, recompile the tc native source using `make` and `make 
install` 
2. Replace the recompiled libs (OpenSSL and APR) 
3. Restart Tomcat, make sure startup is without any warnings and errors
4. Make sure connection over the connector configured for Client 
Certificate Authentication is not resetting anymore


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milindt/tomcat-native trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-native/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit 8d068e4b8a41f94d3f49e413ff84d6638e440811
Author: milindt 
Date:   2019-02-05T12:44:31Z

Fixing Client Certificate Based Authentication with Certificates without 
OCSP OID id-ad-ocsp in Authority Information Access(NID_info_access) Extension




---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.16

2019-02-05 Thread Emmanuel Bourg 
Le 04/02/2019 à 18:00, Mark Thomas a écrit :

> The proposed 9.0.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.16

Tested on Debian with OpenJDK 11.0.2, OpenSSL 1.1.1a and Tomcat Native
1.2.21. No failure on the 3 test suites.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 8.5.38

2019-02-05 Thread Mark Thomas 
The proposed Apache Tomcat 8.5.38 release is now available for voting.

The major changes compared to the 8.5.37 release are:

 - Update the packaged version of the Tomcat Native Library to 1.2.21
   to pick up the memory leak fixes when using NIO/NIO2 with OpenSSL.

 - Correct a regression in the fix for 53737 that did not correctly
   scan the web application directory structure for JSPs.

 - Improve HTTP/2 timeout handling


Along with lots of other bug fixes and improvements.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.38/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1203/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_38/

The proposed 8.5.38 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.38

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r32340 - in /dev/tomcat/tomcat-8/v8.5.38: ./ bin/ bin/embed/ bin/extras/ src/

2019-02-05 Thread markt 
Author: markt
Date: Tue Feb  5 12:21:05 2019
New Revision: 32340

Log:
Upload 8.5.38 for voting

Added:
dev/tomcat/tomcat-8/v8.5.38/
dev/tomcat/tomcat-8/v8.5.38/KEYS
dev/tomcat/tomcat-8/v8.5.38/README.html
dev/tomcat/tomcat-8/v8.5.38/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.5.38/bin/
dev/tomcat/tomcat-8/v8.5.38/bin/README.html
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-deployer.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-deployer.zip.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-deployer.zip.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-fulldocs.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-windows-x64.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-windows-x64.zip.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-windows-x86.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38-windows-x86.zip.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.exe   (with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.exe.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.exe.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.zip   (with props)
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.zip.asc
dev/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.zip.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/embed/
dev/tomcat/tomcat-8/v8.5.38/bin/embed/apache-tomcat-8.5.38-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.38/bin/embed/apache-tomcat-8.5.38-embed.tar.gz.asc

dev/tomcat/tomcat-8/v8.5.38/bin/embed/apache-tomcat-8.5.38-embed.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/embed/apache-tomcat-8.5.38-embed.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.38/bin/embed/apache-tomcat-8.5.38-embed.zip.asc
dev/tomcat/tomcat-8/v8.5.38/bin/embed/apache-tomcat-8.5.38-embed.zip.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/extras/
dev/tomcat/tomcat-8/v8.5.38/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-8/v8.5.38/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-8/v8.5.38/bin/extras/catalina-jmx-remote.jar.sha512
dev/tomcat/tomcat-8/v8.5.38/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.5.38/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.5.38/bin/extras/catalina-ws.jar.sha512
dev/tomcat/tomcat-8/v8.5.38/src/
dev/tomcat/tomcat-8/v8.5.38/src/apache-tomcat-8.5.38-src.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.5.38/src/apache-tomcat-8.5.38-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.38/src/apache-tomcat-8.5.38-src.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.38/src/apache-tomcat-8.5.38-src.zip   (with props)
dev/tomcat/tomcat-8/v8.5.38/src/apache-tomcat-8.5.38-src.zip.asc
dev/tomcat/tomcat-8/v8.5.38/src/apache-tomcat-8.5.38-src.zip.sha512

Added: dev/tomcat/tomcat-8/v8.5.38/KEYS
==
--- dev/tomcat/tomcat-8/v8.5.38/KEYS (added)
+++ dev/tomcat/tomcat-8/v8.5.38/KEYS Tue Feb  5 12:21:05 2019
@@ -0,0 +1,616 @@
+This file contains the PGP keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache developers: please ensure that your key is also available via the
+PGP keyservers (such as pgpkeys.mit.edu).
+
+
+Type Bits/KeyIDDate   User ID
+pub  2048/F22C4FED 2001/07/02 Andy Armstrong 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: PGPfreeware 7.0.3 for non-commercial use 
+
+mQGiBDtAWuURBADZ0KUEyUkSUiTA09e7tvEbX25STsjxrR+DNTainCls+XlkVOij
+gBv216lqge9tIsS0L6hCP4OQbFf/64qVtJssX4QXdyiZGb5wpmcj0Mz602Ew8r+N
+I0S5NvmogoYWW7BlP4r61jNxO5zrr03KaijM5r4ipJdLUxyOmM6P2jRPUwCg/5gm
+bpqiYl7pXX5FgDeB36tmD+UD/06iLqOnoiKO0vMbOk7URclhCObMNrHqxTxozMTS
+B9soYURbIeArei+plYo2n+1qB12ayybjhVu3uksXRdT9bEkyxMfslvLbIpDAG8Cz

svn commit: r1852996 - in /tomcat/tc8.5.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2019-02-05 Thread markt 
Author: markt
Date: Tue Feb  5 12:01:42 2019
New Revision: 1852996

URL: http://svn.apache.org/viewvc?rev=1852996=rev
Log:
Increment version number for next development cycle

Modified:
tomcat/tc8.5.x/trunk/build.properties.default
tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/build.properties.default?rev=1852996=1852995=1852996=diff
==
--- tomcat/tc8.5.x/trunk/build.properties.default (original)
+++ tomcat/tc8.5.x/trunk/build.properties.default Tue Feb  5 12:01:42 2019
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=8
 version.minor=5
-version.build=38
+version.build=39
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default?rev=1852996=1852995=1852996=diff
==
--- tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default Tue Feb  5 12:01:42 
2019
@@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repos
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=8.5.38
+maven.asf.release.deploy.version=8.5.39
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1852996=1852995=1852996=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Tue Feb  5 12:01:42 2019
@@ -44,7 +44,9 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1852987 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_38: ./ build.properties.default webapps/docs/changelog.xml

2019-02-05 Thread markt 
Author: markt
Date: Tue Feb  5 11:40:12 2019
New Revision: 1852987

URL: http://svn.apache.org/viewvc?rev=1852987=rev
Log:
Tag 8.5.38

Added:
tomcat/tc8.5.x/tags/TOMCAT_8_5_38/   (props changed)
  - copied from r1852986, tomcat/tc8.5.x/trunk/
Modified:
tomcat/tc8.5.x/tags/TOMCAT_8_5_38/build.properties.default
tomcat/tc8.5.x/tags/TOMCAT_8_5_38/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
bugtraq:append = false

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
--- bugtraq:logregex (added)
+++ bugtraq:logregex Tue Feb  5 11:40:12 2019
@@ -0,0 +1,2 @@
+(https?\://(bz|issues)\.apache\.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+)
+(\d+)

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
bugtraq:message = Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
bugtraq:url = https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
--- svn:ignore (added)
+++ svn:ignore Tue Feb  5 11:40:12 2019
@@ -0,0 +1,8 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml
+temp

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_38/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Tue Feb  5 11:40:12 2019
@@ -0,0 +1,2 @@
+/tomcat/tc8.0.x/trunk:1809644
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1

Re: [VOTE] Release Apache Tomcat 9.0.16

2019-02-05 Thread Mark Thomas 
On 04/02/2019 17:00, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.16 release is now available for voting.
> 
> The major changes compared to the 9.0.14 release are:
> 
>  - Update the packaged version of the Tomcat Native Library to 1.2.21
>to pick up the memory leak fixes when using NIO/NIO2 with OpenSSL.
> 
>  - Remove extras (JMX remote listener and web services object factories)
>and merge them back into the core build.
> 
>  - Correct a regression in the fix for 53737 that did not correctly
>scan the web application directory structure for JSPs.
> 
>  - Improve HTTP/2 timeout handling
> 
> 
> Along with lots of other bug fixes and improvements.
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1202/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_16/
> 
> The proposed 9.0.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.16

Unit tests pass for NIO, NIO2 and APR/native with Tomcat Native 1.2.21
on Linux, OSX and Windows.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.16

2019-02-05 Thread Keiichi Fujino 
2019年2月5日(火) 2:00 Mark Thomas :

> The proposed Apache Tomcat 9.0.16 release is now available for voting.
>
> The major changes compared to the 9.0.14 release are:
>
>  - Update the packaged version of the Tomcat Native Library to 1.2.21
>to pick up the memory leak fixes when using NIO/NIO2 with OpenSSL.
>
>  - Remove extras (JMX remote listener and web services object factories)
>and merge them back into the core build.
>
>  - Correct a regression in the fix for 53737 that did not correctly
>scan the web application directory structure for JSPs.
>
>  - Improve HTTP/2 timeout handling
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1202/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_16/
>
> The proposed 9.0.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.16
>
>
+1
Tested on test apps (enable session replication).

-
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-- 
Keiichi.Fujino

Re: [VOTE] Release Apache Tomcat 9.0.16

2019-02-05 Thread Rémy Maucherat 
On Mon, Feb 4, 2019 at 6:00 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.16 release is now available for voting.
>
> The major changes compared to the 9.0.14 release are:
>
>  - Update the packaged version of the Tomcat Native Library to 1.2.21
>to pick up the memory leak fixes when using NIO/NIO2 with OpenSSL.
>
>  - Remove extras (JMX remote listener and web services object factories)
>and merge them back into the core build.
>
>  - Correct a regression in the fix for 53737 that did not correctly
>scan the web application directory structure for JSPs.
>
>  - Improve HTTP/2 timeout handling
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1202/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_16/
>
> The proposed 9.0.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.16
>
>
Rémy