[Bug 55243] Add special search string for nested roles

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=55243 --- Comment #3 from isabelladom --- https://app.grammarly.com/ddocs/428003256;>click here https://www.google.com/ [url=https://www.google.com/]click to go[/url] www.google.com -- You are receiving this mail because: You are the assignee

[Bug 55559] UserDatabaseRealm enhacement: may use local JNDI

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=9 --- Comment #4 from isabelladom --- https://www.google.com/ good work -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #9 from isabelladom --- https://app.grammarly.com/ddocs/428003256;>click here https://www.google.com/ [url=https://www.google.com/]click to go[/url] www.google.com -- You are receiving this mail because: You are the assignee

[GitHub] [tomcat] nightwatchcyber commented on issue #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
nightwatchcyber commented on issue #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#issuecomment-473127992 I updated the pull request - let me if that works This is an automated

[GitHub] [tomcat] nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265823838 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are:

[GitHub] [tomcat] nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265823823 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are:

[GitHub] [tomcat] nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265823804 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are:

[GitHub] [tomcat] nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
nightwatchcyber commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265823744 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are:

Re: [VOTE] Release Apache Tomcat 8.5.39

2019-03-14 Thread Igal Sapir
On 3/14/2019 6:43 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.39 release is now available for voting. The proposed 8.5.39 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.39 Tested on Windows 10 and Ubuntu 18.04 Best, Igal

Re: Default Number of Test Threads

2019-03-14 Thread Igal Sapir
On 3/14/2019 12:51 PM, Mark Thomas wrote: On 14/03/2019 19:26, Igal Sapir wrote: Does test.threads default to 1 for a reason? Mostly historical. The tests weren't originally designed to run in parallel. If there is no objection, I would like to set the default to the number of available CPU

Re: Default Number of Test Threads

2019-03-14 Thread Mark Thomas
On 14/03/2019 19:26, Igal Sapir wrote: > Does test.threads default to 1 for a reason? Mostly historical. The tests weren't originally designed to run in parallel. > If there is no objection, I would like to set the default to the number > of available CPU Threads.  It looks like that can be done

[GitHub] [tomcat] markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265734162 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are: -config -

[GitHub] [tomcat] markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265734995 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are: -config -

[GitHub] [tomcat] markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265735188 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are: -config -

[GitHub] [tomcat] markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
markt-asf commented on a change in pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#discussion_r265735282 ## File path: webapps/docs/ssi-howto.xml ## @@ -146,27 +146,53 @@ false. The directives are: -config -

Default Number of Test Threads

2019-03-14 Thread Igal Sapir
Does test.threads default to 1 for a reason? If there is no objection, I would like to set the default to the number of available CPU Threads.  It looks like that can be done with a custom Ant task which should be fairly simple to implement. Best, Igal

[tomcat] branch 7.0.x updated: Remove duplicated comments

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 3a97c8c Remove duplicated comments 3a97c8c is

[tomcat] branch 8.5.x updated: Remove duplicated comments

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9f04cf0 Remove duplicated comments 9f04cf0 is

[GitHub] [tomcat] markt-asf merged pull request #148: Remove duplicated comments

2019-03-14 Thread GitBox
markt-asf merged pull request #148: Remove duplicated comments URL: https://github.com/apache/tomcat/pull/148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[tomcat] branch master updated: Remove duplicated comments

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5841c03 Remove duplicated comments new

[GitHub] [tomcat] markt-asf commented on issue #148: Remove duplicated comments

2019-03-14 Thread GitBox
markt-asf commented on issue #148: Remove duplicated comments URL: https://github.com/apache/tomcat/pull/148#issuecomment-473021367 No reason. It looks like a leftover from the last major redesign. This is an automated

[GitHub] [tomcat] toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling

2019-03-14 Thread GitBox
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473018240 I fixed the missing calls to PooledConnection#validate(int). While reading the code I was kind of unsure whether I should call

Re: [VOTE] Release Apache Tomcat 9.0.17

2019-03-14 Thread Igal Sapir
On 3/13/2019 11:23 AM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.17 release is now available for voting. The proposed 9.0.17 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.17 Tested on Ubuntu 18.04 and Windows 10

buildbot success in on tomcat-trunk

2019-03-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4136 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat] branch 7.0.x updated: Add missing alias names to CharsetCache list of known charsets

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new f0fc43c Add missing alias names to CharsetCache

[tomcat] branch 8.5.x updated: Add missing alias names to CharsetCache list of known charsets

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 86e453f Add missing alias names to CharsetCache

[tomcat] branch master updated: Add missing alias names to CharsetCache list of known charsets

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 21ddc57 Add missing alias names to CharsetCache

Re: buildbot failure in on tomcat-trunk

2019-03-14 Thread Mark Thomas
On 14/03/2019 14:06, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/4135 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for

Re: GitHub Issues / GitHub PRs / Bugzilla

2019-03-14 Thread Mark Thomas
On 14/03/2019 15:21, Coty Sutherland wrote: > On Thu, Mar 14, 2019 at 11:14 AM Coty Sutherland > wrote: > >> On Thu, Mar 14, 2019 at 8:39 AM Mark Thomas wrote: >> >>> It is early days but my impression is that the move to git has triggered >>> an increase in conversations that end up split

Re: ApacheCon Berlin 2019 track?

2019-03-14 Thread Myrle Krantz
Thank you so much Mark!! Tomcat devs, I look forward to seeing you in Berlin! Best, Myrle On Thu, Mar 14, 2019 at 5:28 PM Mark Thomas wrote: > On 10/03/2019 19:59, Myrle Krantz wrote: > > Hey Tomcat! > > > > ApacheCon EU this year is going to be from October 22-24 in Berlin, I'm > > looking

Re: ApacheCon Berlin 2019 track?

2019-03-14 Thread Rémy Maucherat
On Thu, Mar 14, 2019 at 5:28 PM Mark Thomas wrote: > On 10/03/2019 19:59, Myrle Krantz wrote: > > Hey Tomcat! > > > > ApacheCon EU this year is going to be from October 22-24 in Berlin, I'm > > looking for some great tracks for this year. Tomcat is doing a track in > > Las Vegas this year

Re: ApacheCon Berlin 2019 track?

2019-03-14 Thread Mark Thomas
On 10/03/2019 19:59, Myrle Krantz wrote: > Hey Tomcat! > > ApacheCon EU this year is going to be from October 22-24 in Berlin, I'm > looking for some great tracks for this year. Tomcat is doing a track in > Las Vegas this year (Thank you for chairing in Vegas Jean-Frederic!). Is > anyone

buildbot success in on tomcat-7-trunk

2019-03-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1286 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: GitHub Issues / GitHub PRs / Bugzilla

2019-03-14 Thread Coty Sutherland
On Thu, Mar 14, 2019 at 11:14 AM Coty Sutherland wrote: > On Thu, Mar 14, 2019 at 8:39 AM Mark Thomas wrote: > >> It is early days but my impression is that the move to git has triggered >> an increase in conversations that end up split between a GitHub PR and >> Bugzilla. >> >> Personally, I'm

Re: GitHub Issues / GitHub PRs / Bugzilla

2019-03-14 Thread Coty Sutherland
On Thu, Mar 14, 2019 at 8:39 AM Mark Thomas wrote: > It is early days but my impression is that the move to git has triggered > an increase in conversations that end up split between a GitHub PR and > Bugzilla. > > Personally, I'm not finding it unmanageable at this point but it does > feel a

buildbot failure in on tomcat-trunk

2019-03-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4135 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 7.0.x updated: Fix backport of <> which is not supported in Java 6

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new b277f1f Fix backport of <> which is not supported

[VOTE] Release Apache Tomcat 8.5.39

2019-03-14 Thread Mark Thomas
The proposed Apache Tomcat 8.5.39 release is now available for voting. The major changes compared to the 8.5.38 release are: - The APR/Native connector now supports both OpenSSL and JSSE TLS configuration syntax (NIO and NIO2 already support this) - Various improvements to NIO2 - Various

buildbot failure in on tomcat-7-trunk

2019-03-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1285 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[GitHub] [tomcat] nightwatchcyber opened a new pull request #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
nightwatchcyber opened a new pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138 Fixing: https://bz.apache.org/bugzilla/show_bug.cgi?id=63184 This is an automated

[GitHub] [tomcat] markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184)

2019-03-14 Thread GitBox
markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#issuecomment-472856732 Close unintentionally during svn->git migration. This is an automated message

[Bug 63235] Defer potentially expensive Charset.availableCharsets() call

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 89cbf02 Fix

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b10ceba Fix

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4debebe Fix

[GitHub] [tomcat] markt-asf merged pull request #146: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235

2019-03-14 Thread GitBox
markt-asf merged pull request #146: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235 URL: https://github.com/apache/tomcat/pull/146 This is an automated message from the Apache Git Service. To respond to the

GitHub Issues / GitHub PRs / Bugzilla

2019-03-14 Thread Mark Thomas
It is early days but my impression is that the move to git has triggered an increase in conversations that end up split between a GitHub PR and Bugzilla. Personally, I'm not finding it unmanageable at this point but it does feel a little disorganized. I'm wondering if we need clearer guidelines

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 Lifecycle

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 1d3931d Fix

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 Lifecycle

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new e992e52 Fix

[GitHub] [tomcat] wilkinsona commented on issue #146: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235

2019-03-14 Thread GitBox
wilkinsona commented on issue #146: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235 URL: https://github.com/apache/tomcat/pull/146#issuecomment-472829112 In addition to the improved startup time, this change has an even bigger positive impact on Tomcat's memory footprint. With

[GitHub] [tomcat] wilkinsona edited a comment on issue #146: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235

2019-03-14 Thread GitBox
wilkinsona edited a comment on issue #146: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63235 URL: https://github.com/apache/tomcat/pull/146#issuecomment-472829112 In addition to the improved startup time, this change has an even bigger positive impact on Tomcat's memory footprint.

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 Lifecycle

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c3fccde Fix

[Bug 63196] Add sane default value for RemoteIpValue#protocolHeader

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63196 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 --- Comment #8 from Remy Maucherat --- We should probably recommend using PRs for multiple simple changes like this one. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r32919 - in /dev/tomcat/tomcat-8/v8.5.39: ./ bin/ bin/embed/ bin/extras/ src/

2019-03-14 Thread markt
Author: markt Date: Thu Mar 14 11:53:34 2019 New Revision: 32919 Log: Upload 8.5.39 for voting Added: dev/tomcat/tomcat-8/v8.5.39/ dev/tomcat/tomcat-8/v8.5.39/KEYS dev/tomcat/tomcat-8/v8.5.39/README.html dev/tomcat/tomcat-8/v8.5.39/RELEASE-NOTES

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63196

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 8564f1d Fix

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63196

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 16ca5f1 Fix

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 --- Comment #7 from AnhT --- (In reply to Mark Thomas from comment #6) > The log levels for the JMX (de-)registration messages have been addressed in: > - master for 9.0.18 onwards > - 8.5.x for 8.5.40 onwards > - 7.0.x for 7.0.94 onwards > >

buildbot success in on tomcat-85-trunk

2019-03-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1697 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 --- Comment #6 from Mark Thomas --- The log levels for the JMX (de-)registration messages have been addressed in: - master for 9.0.18 onwards - 8.5.x for 8.5.40 onwards - 7.0.x for 7.0.94 onwards I'll look at the Lifecycle issues next but

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63249

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new d01c6a1 Fix

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63249

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 18b16d5 Fix

[tomcat] branch 8.5.x updated: Increment version number for next development cycle

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3f5625f Increment version number for next

[tomcat] tag 8.5.39 created (now f481565)

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 8.5.39 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at f481565 (commit) This tag includes the following new commits: new f481565 Tag 8.5.39 The 1 revisions listed

[tomcat] 01/01: Tag 8.5.39

2019-03-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 8.5.39 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f481565d959dc5a5eae1576cc294774c8683b4dc Author: Mark Thomas AuthorDate: Thu Mar 14 10:50:05 2019 + Tag 8.5.39 ---

Re: [VOTE] Release Apache Tomcat 9.0.17

2019-03-14 Thread Mark Thomas
On 13/03/2019 18:23, Mark Thomas wrote: > The proposed 9.0.17 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.17 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

[GitHub] [tomcat] toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling

2019-03-14 Thread GitBox
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-472791041 Good catch, I will fix this. This is an automated message from the Apache Git Service.

[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling

2019-03-14 Thread GitBox
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-472779046 If testOnConnect is true or initSQL is set, we need validate the connection( with VALIDATE_INIT) when reconnecting.

Re: [VOTE] Release Apache Tomcat 9.0.17

2019-03-14 Thread Rémy Maucherat
On Wed, Mar 13, 2019 at 7:23 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.17 release is now available for voting. > > The major changes compared to the 9.0.16 release are: > > - The APR/Native connector now supports both OpenSSL and JSSE TLS > configuration syntax (NIO and NIO2

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 --- Comment #5 from AnhT --- (In reply to AnhT from comment #3) > Hi, Mark Thomas. Thank you very much for your prompt response. > There are other 6 inconsistent logging practices shown below, and I think > the ERROR level is more appropriate

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 --- Comment #4 from AnhT --- Hi, Mark Thomas. Thank you very much for your prompt response. There are other inconsistent logging practices shown below, and I think the ERROR level is more appropriate to following 6 log statements.

[Bug 63249] Inconsistent log level practices

2019-03-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63249 --- Comment #3 from AnhT --- Hi, Mark Thomas. Thank you very much for your prompt response. There are other 6 inconsistent logging practices shown below, and I think the ERROR level is more appropriate to them.

[GitHub] [tomcat] samslow opened a new pull request #148: Remove duplicated comments

2019-03-14 Thread GitBox
samslow opened a new pull request #148: Remove duplicated comments URL: https://github.com/apache/tomcat/pull/148 Signed-off-by: samslow I don't know why this comments is here. If there is a reason why the comment is here and I do not know, Abort this PR and Teach me if you