buildbot failure in on tomcat-trunk

2020-04-02 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5083 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 7.0.x updated: Improve code coverage

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 301929b Improve code coverage 301929b is

[tomcat] branch 9.0.x updated: Improve code coverage

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 34eefd0 Improve code coverage 34eefd0 is

[tomcat] branch 8.5.x updated: Improve code coverage

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3031d06 Improve code coverage 3031d06 is

[tomcat] branch master updated: Improve code coverage

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 58b0fbc Improve code coverage 58b0fbc is

buildbot success in on tomcat-9-trunk

2020-04-02 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/147 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot success in on tomcat-trunk

2020-04-02 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5082 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

Time to tag 10.0.0-M4, 9.0.34, 8.5.54

2020-04-02 Thread Mark Thomas
Hi all, I've reviewed the open Bugzilla issues and Pull Requests and I think we are in a position to tag the April round of releases. I'll start this process later today or tomorrow as time allows. Mark - To unsubscribe,

buildbot failure in on tomcat-9-trunk

2020-04-02 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/146 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[GitHub] [tomcat] markt-asf closed pull request #249: Support for default values in property value expressions

2020-04-02 Thread GitBox
markt-asf closed pull request #249: Support for default values in property value expressions URL: https://github.com/apache/tomcat/pull/249 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] markt-asf commented on issue #249: Support for default values in property value expressions

2020-04-02 Thread GitBox
markt-asf commented on issue #249: Support for default values in property value expressions URL: https://github.com/apache/tomcat/pull/249#issuecomment-607903803 Thanks for thr PR. A variation has been applied to all currently supported branches.

[tomcat] branch master updated: Remove deprecated code.

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2ada85d Remove deprecated code. 2ada85d is

[tomcat] branch 7.0.x updated: Deprecate the org.apache.catalina.tribes.dns_lookups system property

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new ebdb601 Deprecate the

[tomcat] branch 8.5.x updated: Deprecate the org.apache.catalina.tribes.dns_lookups system property

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 72c5ba8 Deprecate the

[tomcat] branch 9.0.x updated: Deprecate the org.apache.catalina.tribes.dns_lookups system property

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d3ae1dc Deprecate the

[tomcat] branch master updated: Deprecate the org.apache.catalina.tribes.dns_lookups system property

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e64d3d7 Deprecate the

Re: Remaining Tomcat 10 items

2020-04-02 Thread Mark Thomas
On 02/04/2020 15:02, Rémy Maucherat wrote: > On Fri, Mar 27, 2020 at 6:13 PM Mark Thomas > wrote: > > On 26/03/2020 16:47, Rémy Maucherat wrote: > > On Mon, Mar 23, 2020 at 10:37 AM Rémy Maucherat > >

[tomcat] branch master updated: Fix checkstyle

2020-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 951c6ea Fix checkstyle 951c6ea is described

[tomcat] branch 7.0.x updated: Support for default values in property value expressions

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new c4e9cad Support for default values in property

[tomcat] branch 8.5.x updated: Support for default values in property value expressions

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new dcf3193 Support for default values in property

[tomcat] branch 9.0.x updated: Support for default values in property value expressions

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new cdfea5d Support for default values in property

[tomcat] branch master updated: Support for default values in property value expressions

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 6f356df Support for default values in property

Re: Remaining Tomcat 10 items

2020-04-02 Thread Rémy Maucherat
On Fri, Mar 27, 2020 at 6:13 PM Mark Thomas wrote: > On 26/03/2020 16:47, Rémy Maucherat wrote: > > On Mon, Mar 23, 2020 at 10:37 AM Rémy Maucherat > > wrote: > > > > - Remove the use of system properties to control configuration > > wherever possible. > > I

[tomcat] branch 7.0.x updated: Added extension point for custom delta requests

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new db89a2a Added extension point for custom delta

[GitHub] [tomcat] markt-asf commented on issue #257: Added extension point for custom delta requests

2020-04-02 Thread GitBox
markt-asf commented on issue #257: Added extension point for custom delta requests URL: https://github.com/apache/tomcat/pull/257#issuecomment-607859022 Thanks for the additional PR. I've back-ported the original fix to 9.0.x, 8.5.x and 7.0.x along with a comment that explains why the

[GitHub] [tomcat] markt-asf closed pull request #257: Added extension point for custom delta requests

2020-04-02 Thread GitBox
markt-asf closed pull request #257: Added extension point for custom delta requests URL: https://github.com/apache/tomcat/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please

[tomcat] branch 9.0.x updated: Added extension point for custom delta requests

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 40a5f17 Added extension point for custom delta

[tomcat] branch 8.5.x updated: Added extension point for custom delta requests

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d3dc830 Added extension point for custom delta

[tomcat] branch master updated: Add a comment to explain code that might appear to be unnecessary.

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c42a118 Add a comment to explain code that

[GitHub] [tomcat] lkirchev commented on issue #252: 8.5.x

2020-04-02 Thread GitBox
lkirchev commented on issue #252: 8.5.x URL: https://github.com/apache/tomcat/pull/252#issuecomment-607819295 Thanks a lot Mark! I didn't expect to merge the PR when I added the last commit, I just wanted to bring it most closely to a state you can reuse.

buildbot failure in on tomcat-trunk

2020-04-02 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5080 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[GitHub] [tomcat] markt-asf closed pull request #252: 8.5.x

2020-04-02 Thread GitBox
markt-asf closed pull request #252: 8.5.x URL: https://github.com/apache/tomcat/pull/252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] markt-asf commented on issue #252: 8.5.x

2020-04-02 Thread GitBox
markt-asf commented on issue #252: 8.5.x URL: https://github.com/apache/tomcat/pull/252#issuecomment-607806850 Thanks. While I'm not merging this specific PR I do want to assure you that the PR was very helpful in resolving this. Having a concrete proposal to work from is much easier than

[tomcat] branch 8.5.x updated: Expose the HttpServletRequest to CookieProcessor.generateHeader()

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new e81d0ff Expose the HttpServletRequest to

[tomcat] branch 9.0.x updated: Expose the HttpServletRequest to CookieProcessor.generateHeader()

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new fcda8f4 Expose the HttpServletRequest to

[tomcat] branch master updated: Add credit.

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ed8531b Add credit. ed8531b is described below

[tomcat] branch master updated: Expose the HttpServletRequest to CookieProcessor.generateHeader()

2020-04-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 623b2c9 Expose the HttpServletRequest to

[tomcat] branch master updated: Add a new flag in Catalina for errors on init

2020-04-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 62efcf7 Add a new flag in Catalina for errors on

[GitHub] [tomcat] lkirchev commented on issue #252: 8.5.x

2020-04-02 Thread GitBox
lkirchev commented on issue #252: 8.5.x URL: https://github.com/apache/tomcat/pull/252#issuecomment-607765082 Thanks a lot Mark! Yes, you are right, I overlooked the dependency I introduced. I added another commit with a proposal for replacing o.a.c.c.Request with HttpServletRequest.

[GitHub] [tomcat] markt-asf commented on issue #252: 8.5.x

2020-04-02 Thread GitBox
markt-asf commented on issue #252: 8.5.x URL: https://github.com/apache/tomcat/pull/252#issuecomment-607731339 I can see why this is necessary and I support making the necessary changes to Tomcat to support solving this problem. The patch as proposed cannot be applied as the o.a.t.util