[GitHub] [tomcat] biya-bi commented on issue #266: Fix typo in exception message about quote character in repository path

2020-04-08 Thread GitBox
biya-bi commented on issue #266: Fix typo in exception message about quote character in repository path URL: https://github.com/apache/tomcat/pull/266#issuecomment-610995670 All the pleasure is mine Mark! This is an

[tomcat] 02/03: BZ 64311 Add debug logging to aid investigation of test failures

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9e05ecd57dab026964df496d238f446cc1ceaeb1 Author: Mark Thomas AuthorDate: Wed Apr 8 15:47:47 2020 +0100 BZ 64311 Add

[tomcat] 03/03: BZ 64311. Allow for java.net.preferIPv4Stack in APR AnyLocalAddress test

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f83a9928c1dc0c4e34d96c2e1c44deecc68475a8 Author: Mark Thomas AuthorDate: Wed Apr 8 16:10:20 2020 +0100 BZ 64311.

[tomcat] 01/03: BZ 64311 - Prevent test from hanging if client fails to connect

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ddf1dc84147d023bd3a9560f7c49e35628383187 Author: Mark Thomas AuthorDate: Wed Apr 8 15:46:01 2020 +0100 BZ 64311 -

[tomcat] branch 9.0.x updated (5e0dd5d -> f83a992)

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 5e0dd5d Add an extra field to keep around the configured protocol new ddf1dc8 BZ 64311 - Prevent test from

svn commit: r38860 - /dev/tomcat/tomcat-8/v8.5.54/ /release/tomcat/tomcat-8/v8.5.54/

2020-04-08 Thread markt
Author: markt Date: Wed Apr 8 15:45:34 2020 New Revision: 38860 Log: Release Apache Tomcat 8.5.54 Added: release/tomcat/tomcat-8/v8.5.54/ - copied from r38859, dev/tomcat/tomcat-8/v8.5.54/ Removed: dev/tomcat/tomcat-8/v8.5.54/

Nexus: Promotion Completed

2020-04-08 Thread Nexus Repository Manager
Message from: https://repository.apache.orgDeployer properties:"userAgent" = "maven-artifact/2.2.1 (Java 1.7.0_80; Windows 8.1 6.3)""userId" = "markt""ip" = "86.190.55.221"Details:The following artifacts have been promoted to the "Releases" [id=releases]

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

2020-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 --- Comment #5 from Michael Osipov --- Since all tests pass, this check for threading support can be dropped sooner or later? The threading support is required for OpenSSL < 1.1.0 only. -- You are receiving this mail because: You are the

[tomcat] branch master updated: BZ 64311. Allow for java.net.preferIPv4Stack in APR AnyLocalAddress test

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 765f944 BZ 64311. Allow for

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

2020-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Nexus: Promotion Completed

2020-04-08 Thread Nexus Repository Manager
Message from: https://repository.apache.orgDeployer properties:"userAgent" = "maven-artifact/2.2.1 (Java 1.8.0_242; Windows 10 10.0)""userId" = "markt""ip" = "86.190.55.221"Details:The following artifacts have been promoted to the "Releases" [id=releases]

svn commit: r38858 - /dev/tomcat/tomcat-10/v10.0.0-M4/ /release/tomcat/tomcat-10/v10.0.0-M4/

2020-04-08 Thread markt
Author: markt Date: Wed Apr 8 15:39:20 2020 New Revision: 38858 Log: Release Apache Tomcat 10.0.0-M4 Added: release/tomcat/tomcat-10/v10.0.0-M4/ - copied from r38857, dev/tomcat/tomcat-10/v10.0.0-M4/ Removed: dev/tomcat/tomcat-10/v10.0.0-M4/

[VOTE][RESULT] Release Apache Tomcat 10.0.0-M4

2020-04-08 Thread Mark Thomas
The following votes were cast: Binding: +1: remm, mgrigorov, eboourg, csutherl No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. - To unsubscribe, e-mail:

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

2020-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 --- Comment #3 from Mark Thomas --- Ah. That explains it. I can reproduce this now. I've fixed the hang on failure. I'll look at the failure next. -- You are receiving this mail because: You are the assignee for the bug.

[tomcat] 02/02: BZ 64311 Add debug logging to aid investigation of test failures

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4c456b17c49ef9bdeef49af96f273e07b9c5db00 Author: Mark Thomas AuthorDate: Wed Apr 8 15:47:47 2020 +0100 BZ 64311 Add

[tomcat] 01/02: BZ 64311 - Prevent test from hanging if client fails to connect

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 01d748c1d51c5e568cdb3cc6540527708e7c3e59 Author: Mark Thomas AuthorDate: Wed Apr 8 15:46:01 2020 +0100 BZ 64311 -

[tomcat] branch master updated (8cdd497 -> 4c456b1)

2020-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 8cdd497 Add an extra field to keep around the configured protocol new 01d748c BZ 64311 - Prevent test from

Re: API Change - Connector.java Constructor

2020-04-08 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 8:42 PM Mark Thomas wrote: > On 07/04/2020 19:03, Filip Hanik wrote: > > > > > > On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat > > wrote: > > > > > > Does the connector need to know about the actual implementations? > > > > > > Ideally

[VOTE][RESULT] Release Apache Tomcat 9.0.34

2020-04-08 Thread Mark Thomas
The following votes were cast: Binding: +1: remm, mgrigorov, eboourg, csutherl No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. - To unsubscribe, e-mail:

Nexus: Promotion Completed

2020-04-08 Thread Nexus Repository Manager
Message from: https://repository.apache.orgDeployer properties:"userAgent" = "maven-artifact/2.2.1 (Java 1.8.0_242; Windows 10 10.0)""userId" = "markt""ip" = "86.190.55.221"Details:The following artifacts have been promoted to the "Releases" [id=releases]

[VOTE][RESULT] Release Apache Tomcat 8.5.54

2020-04-08 Thread Mark Thomas
The following votes were cast: Binding: +1: mgrigorov, remm, schultz No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. - To unsubscribe, e-mail:

svn commit: r38859 - /dev/tomcat/tomcat-9/v9.0.34/ /release/tomcat/tomcat-9/v9.0.34/

2020-04-08 Thread markt
Author: markt Date: Wed Apr 8 15:43:00 2020 New Revision: 38859 Log: Release Apache Tomcat 9.0.34 Added: release/tomcat/tomcat-9/v9.0.34/ - copied from r38858, dev/tomcat/tomcat-9/v9.0.34/ Removed: dev/tomcat/tomcat-9/v9.0.34/

[GitHub] [tomcat] ChristopherSchultz commented on issue #269: Use parameterized collection constructors where possible

2020-04-08 Thread GitBox
ChristopherSchultz commented on issue #269: Use parameterized collection constructors where possible URL: https://github.com/apache/tomcat/pull/269#issuecomment-611038366 Many of these instances are to protect private collections from being modified. For example, in

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

2020-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 --- Comment #7 from Michael Osipov --- What do you think about the erratic behavior of APR in regards of the address family when this feature is enabled or disabled? Our fault or APR's? -- You are receiving this mail because: You are the

[tomcat-jakartaee-migration] 01/04: Split the CLI handling from the main migration class

2020-04-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 0a52c66b751e3245fad11faf85f7dbfa4343bac9 Author: Emmanuel Bourg AuthorDate: Wed Apr 8 18:55:17 2020

[tomcat-jakartaee-migration] 03/04: Test with an invalid profile

2020-04-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 75de6b5d61afac8e13621cffe63df892e602df26 Author: Emmanuel Bourg AuthorDate: Wed Apr 8 23:18:23 2020

[tomcat-jakartaee-migration] branch master updated (54c1fe1 -> 70a9455)

2020-04-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. from 54c1fe1 Avoid deprecation warning new 0a52c66 Split the CLI handling from the main

[tomcat-jakartaee-migration] 04/04: Wrap the lines in the README file

2020-04-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 70a94559e5a288d30f0794210c100e21d950d40b Author: Emmanuel Bourg AuthorDate: Wed Apr 8 23:22:45 2020

[tomcat-jakartaee-migration] 02/04: Ant task for the migration tool

2020-04-08 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 44521e8f1f4beb84ce1e7780481eb3ee19e7e2bd Author: Emmanuel Bourg AuthorDate: Wed Apr 8 22:46:02 2020

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

2020-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 --- Comment #6 from Mark Thomas --- Yes, I think that check is safe to remove. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

Re: sources repository for taglibs-standard-impl/specs-1.2.5-migrated-0.0.1

2020-04-08 Thread Olivier Lamy
Hi Migration results are available here: - https://github.com/olamy/taglibs-standard - https://github.com/olamy/taglibs-parent - https://github.com/olamy/taglibs-site Please note taglibs-standard include some strange tags probably coming from csv2svn migration but they were already there in svn.

Re: sources repository for taglibs-standard-impl/specs-1.2.5-migrated-0.0.1

2020-04-08 Thread Olivier Lamy
Just in case I created rdc as well https://github.com/olamy/taglibs-rdc On Thu, 9 Apr 2020 at 10:53, Olivier Lamy wrote: > Hi > Migration results are available here: > - https://github.com/olamy/taglibs-standard > - https://github.com/olamy/taglibs-parent > -

[tomcat] branch 9.0.x updated: Add an extra field to keep around the configured protocol

2020-04-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5e0dd5d Add an extra field to keep around the

[GitHub] [tomcat] michael-o commented on a change in pull request #270: Bulk operation can be used instead of iteration

2020-04-08 Thread GitBox
michael-o commented on a change in pull request #270: Bulk operation can be used instead of iteration URL: https://github.com/apache/tomcat/pull/270#discussion_r405300164 ## File path: java/org/apache/catalina/core/ApplicationContext.java ## @@ -1350,9 +1350,7 @@

[GitHub] [tomcat] larsgrefer commented on issue #270: Bulk operation can be used instead of iteration

2020-04-08 Thread GitBox
larsgrefer commented on issue #270: Bulk operation can be used instead of iteration URL: https://github.com/apache/tomcat/pull/270#issuecomment-610789454 Using `addAll` allows the target collection to grow to the correct size in advance.

[tomcat] branch master updated: Add an extra field to keep around the configured protocol

2020-04-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8cdd497 Add an extra field to keep around the

[GitHub] [tomcat] larsgrefer opened a new pull request #273: Use enhanced for loops where possible

2020-04-08 Thread GitBox
larsgrefer opened a new pull request #273: Use enhanced for loops where possible URL: https://github.com/apache/tomcat/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tomcat] larsgrefer commented on a change in pull request #272: Loop can be terminated after condition is met

2020-04-08 Thread GitBox
larsgrefer commented on a change in pull request #272: Loop can be terminated after condition is met URL: https://github.com/apache/tomcat/pull/272#discussion_r405473870 ## File path: java/org/apache/catalina/realm/RealmBase.java ## @@ -756,10 +756,11 @@ public void