[GitHub] [tomcat-maven-plugin] markt-asf commented on a change in pull request #32: support tomcat 8.5

markt-asf commented on a change in pull request #32: URL: https://github.com/apache/tomcat-maven-plugin/pull/32#discussion_r458305303 ## File path: tomcat8-maven-plugin/pom.xml ## @@ -137,12 +137,12 @@ org.apache.tomcat.embed tomcat-embed-logging-juli -

[tomcat] branch master updated: Simpler way to determine Graal runtime

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 098c4c8 Simpler way to determine Graal runtime

[GitHub] [tomcat] rotty3000 commented on pull request #323: fix module names to reflect Jakarta EE origin

rotty3000 commented on pull request #323: URL: https://github.com/apache/tomcat/pull/323#issuecomment-662054802 I saw :) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] markt-asf commented on pull request #323: fix module names to reflect Jakarta EE origin

markt-asf commented on pull request #323: URL: https://github.com/apache/tomcat/pull/323#issuecomment-662032441 Heads up. The Jakarta EE JPMS names are currently a moving target. At least one person thinks there is a policy that the JPMS names should not have the ".api" on the end. I am

[GitHub] [tomcat-maven-plugin] liudongmiao opened a new pull request #32: support tomcat 8.5

liudongmiao opened a new pull request #32: URL: https://github.com/apache/tomcat-maven-plugin/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

Just FYI, I found that if I build when the aqute-bnd and aqute-bndlib packages are installed from Fedora (version 3.5) then the classes are *not* included in the jar, but if I remove them and use the aqute-bnd version that tomcat requires (version 5.1) then they are present. On Tue, Jul 21, 2020

Re: Changing the name of the default branch in our git repos

На пт, 26.06.2020 г. в 23:41 Rémy Maucherat написа: > > On Fri, Jun 26, 2020 at 4:48 PM Mark Thomas wrote: >> >> Hi, >> >> Picking up this thread again I see a range of views. "main" seems to be >> the most popular although several folks suggested "10.0.x" and "use >> whatever GitHub use". There

[GitHub] [tomcat-maven-plugin] liudongmiao commented on pull request #32: support tomcat 8.5

liudongmiao commented on pull request #32: URL: https://github.com/apache/tomcat-maven-plugin/pull/32#issuecomment-662209229 Thanks for review. However, I cannot make run-its works well, even tomcat7-maven-plugin doesn't work on my devices.

[GitHub] [tomcat-maven-plugin] liudongmiao commented on a change in pull request #30: Tc9.x Initial suport for Tomact9

liudongmiao commented on a change in pull request #30: URL: https://github.com/apache/tomcat-maven-plugin/pull/30#discussion_r458502517 ## File path: tomcat9-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat9/run/RunMojo.java ## @@ -479,18 +480,23 @@ private

[tomcat] 02/02: Avoid reflection for default instantiation

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f4dac6846c548144799b1c3f33aba4eb320a3413 Author: Filip Hanik AuthorDate: Mon Jul 13 12:43:55 2020 -0700 Avoid

[tomcat] branch 9.0.x updated: Parent classloader has to be resolved first.

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 77efc02 Parent classloader has to be resolved

[tomcat] 01/02: Simpler way to determine Graal runtime

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6a73695fa6d024ed9fc4adeb32073cbd94309c51 Author: Filip Hanik AuthorDate: Tue Jul 21 14:04:57 2020 -0700 Simpler way

[tomcat] branch 9.0.x updated (5157388 -> f4dac68)

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 5157388 fix module names to reflect Java EE origin new 6a73695 Simpler way to determine Graal runtime new

[GitHub] [tomcat] markt-asf commented on a change in pull request #323: fix module names to reflect Jakarta EE origin

markt-asf commented on a change in pull request #323: URL: https://github.com/apache/tomcat/pull/323#discussion_r458009648 ## File path: res/bnd/catalina.jar.tmp.bnd ## @@ -55,15 +55,15 @@ Export-Package: \ access=32;\ version=${Bundle-Version};\

JAX-RPC and Tomcat 10

All, JAX-RPC has been removed in Jakarta EE 9. Implementations are free to continue supporting it if they wish. My preference would be to remove JAX-RPS support in Tomcat 10. I am working on this at the moment and am wondering how to handle the JAX-RPC elements we can't entirely remove. There

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On 21/07/2020 12:43, Coty Sutherland wrote: > Hi Mark, > > On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas > wrote: > > On 20/07/2020 18:20, Coty Sutherland wrote: > > This commit is problematic :( It's broken some projects that depend on > > Tomcat because now

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #8 from Christopher Schultz --- Seems like an awful hack. Perhaps instead we should have a configuration attribute like dontWrapKeyManager="true|false" and them simply do not wrap in the first place. Or is the wrapping required

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On Tue, Jul 21, 2020 at 7:52 AM Mark Thomas wrote: > On 21/07/2020 12:43, Coty Sutherland wrote: > > Hi Mark, > > > > On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas > > wrote: > > > > On 20/07/2020 18:20, Coty Sutherland wrote: > > > This commit is problematic :(

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

Hi Mark, On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas wrote: > On 20/07/2020 18:20, Coty Sutherland wrote: > > This commit is problematic :( It's broken some projects that depend on > > Tomcat because now the tomcat-coyote.jar doesn't contain the > > org.apache.tomcat.util.net.jsse or > >

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #7 from jfclere --- Created attachment 37367 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37367=edit improved? patch. Check for FIPS to prevent regressions... -- You are receiving this mail because: You are the

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On 20/07/2020 18:20, Coty Sutherland wrote: > This commit is problematic :( It's broken some projects that depend on > Tomcat because now the tomcat-coyote.jar doesn't contain the > org.apache.tomcat.util.net.jsse or > org.apache.tomcat.util.modeler.modules packages which results in >

[tomcat] branch master updated (17dab7a -> 577d39f)

This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 17dab7a Fix regression in fix for BZ 64540. add 577d39f Add a dedicated loader for generated code No new

[tomcat] branch master updated: Fix regression in fix for BZ 64540.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 17dab7a Fix regression in fix for BZ 64540.

[tomcat] branch 9.0.x updated: Fix regression in fix for BZ 64540.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1366462 Fix regression in fix for BZ 64540.

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On 21/07/2020 09:47, Mark Thomas wrote: > On 20/07/2020 18:20, Coty Sutherland wrote: >> This commit is problematic :( It's broken some projects that depend on >> Tomcat because now the tomcat-coyote.jar doesn't contain the >> org.apache.tomcat.util.net.jsse or >>

[tomcat] branch 9.0.x updated: Add a dedicated loader for generated code

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b8669f7 Add a dedicated loader for generated code

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #6 from jfclere --- Note the ciphers list is needed for FIPS. -- You are receiving this mail because: You are the assignee for the bug.

[GitHub] [tomcat] stokito commented on a change in pull request #316: Use lowercase HTML tags and attributes. Add quotes around attributes.

stokito commented on a change in pull request #316: URL: https://github.com/apache/tomcat/pull/316#discussion_r457980335 ## File path: webapps/ROOT/index.jsp ## @@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/"); - +

Re: JAX-RPC and Tomcat 10

Hi Mark, e) c as default + add a toggle to behave as a? (thinking to container extending tomcat where this shouldn't fail probably) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: JAX-RPC and Tomcat 10

On 21/07/2020 14:26, Romain Manni-Bucau wrote: > Hi Mark, > > e) c as default + add a toggle to behave as a? (thinking to container > extending tomcat where this shouldn't fail probably) So keep the attributes in ContextService and friends that record the JAX-RPC so they are accessible to

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

That looks like an issue that will need fixing in Fedora's build system. > Annotation scanning and the multipart upload API will be broken if those > packages are missing. > Hm, OK. I'll look into that and I guess other changes to ensure the Fedora build isn't breaking stuff. I need to figure

[Bug 64540] switch from bndwrap task to bnd task

https://bz.apache.org/bugzilla/show_bug.cgi?id=64540 --- Comment #4 from rotty3000 --- For the record, this was not really a bug. The packages were in fact in the jar. I confirmed with a binary check before and after the change and the jar is unchanged except for the manifest and the

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #9 from Remy Maucherat --- (In reply to Christopher Schultz from comment #8) > Seems like an awful hack. > > Perhaps instead we should have a configuration attribute like > dontWrapKeyManager="true|false" and them simply do not

[tomcat] branch 9.0.x updated: fix module names to reflect Java EE origin

This is an automated email from the ASF dual-hosted git repository. rotty3000 pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5157388 fix module names to reflect Java EE

[GitHub] [tomcat] rotty3000 merged pull request #322: fix module names to reflect Java EE origin

rotty3000 merged pull request #322: URL: https://github.com/apache/tomcat/pull/322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On 21/07/2020 14:06, Coty Sutherland wrote: > Oh yeah, you're right. They were included in the ASF binaries, but > Fedora (and Debian I guess) built their own bits and that's where the > classes came up missing. I wasn't able to identify *why* the classes > weren't present, only that it was the

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On Tue, Jul 21, 2020 at 9:15 AM Mark Thomas wrote: > On 21/07/2020 14:06, Coty Sutherland wrote: > > > > > Oh yeah, you're right. They were included in the ASF binaries, but > > Fedora (and Debian I guess) built their own bits and that's where the > > classes came up missing. I wasn't able to

Re: JAX-RPC and Tomcat 10

Yes, was thinking to tomee in particular since it does not use tomcat as a lib but really as the container so if the container fails then it can become hard if not "disabl-able" somehow (at least with subclassing or something programmatic). Romain Manni-Bucau @rmannibucau

[GitHub] [tomcat] rotty3000 commented on pull request #323: fix module names to reflect Jakarta EE origin

rotty3000 commented on pull request #323: URL: https://github.com/apache/tomcat/pull/323#issuecomment-661903666 See updates. This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

On 21/07/2020 14:21, Coty Sutherland wrote: > On Tue, Jul 21, 2020 at 9:15 AM Mark Thomas > wrote: > > On 21/07/2020 14:06, Coty Sutherland wrote: > > > > > Oh yeah, you're right. They were included in the ASF binaries, but > > Fedora (and Debian I

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

Hey all, Thanks for looking into this. I made sure using a binary comparison tool that the jars did in fact contained the correct bits before and after all my changes. But Mark is correct that some of the previously private packages are actually used externally and I had some changes coming to

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #10 from jfclere --- kmf.getProvider().getInfo() also gives "Sun JSSE provider (FIPS mode, crypto provider SunPKCS11-NSSfips" so indexOf("FIPS") != -1 would also work there. -- You are receiving this mail because: You are the

Re: Native Image - Reflectionless Concept

We've had some discussions around this, mostly high level about where this could go. At this point, anyone strongly opposed to ship a light weight jar? Do we feel the value is or is not there compared to the maintenance of it? Filip On 7/13/20 2:59 PM, Filip Hanik wrote: for discussion,

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 jfclere changed: What|Removed |Added Attachment #37364|0 |1 is obsolete|

[tomcat] branch master updated: Avoid reflection for default instantiation

This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c08bf81 Avoid reflection for default