https://bz.apache.org/bugzilla/show_bug.cgi?id=64944
Bug ID: 64944
Summary: Incorrect bytesSent metric when compression is enabled
Product: Tomcat 9
Version: 9.0.39
Hardware: PC
OS: Linux
Status: NEW
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532284639
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532283784
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
https://bz.apache.org/bugzilla/show_bug.cgi?id=64943
Bug ID: 64943
Summary: [Patch] Add support for Unix Domain Sockets to
org.apache.coyote.http11.Http11AprProtocol
Product: Tomcat 10
Version: unspecified
Hardware: PC
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532272524
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532274020
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532251226
##
File path: java/org/apache/tomcat/jni/Address.java
##
@@ -40,8 +40,9 @@
/**
* Create apr_sockaddr_t from hostname, address family, and
https://bz.apache.org/bugzilla/show_bug.cgi?id=64942
Bug ID: 64942
Summary: [Patch] Expose support for Unix Domain Sockets in APR
v1.6 and up.
Product: Tomcat Native
Version: unspecified
Hardware: PC
OS:
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532254706
##
File path: java/org/apache/tomcat/jni/Address.java
##
@@ -40,8 +40,9 @@
/**
* Create apr_sockaddr_t from hostname, address family, and
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532254789
##
File path: native/include/tcn.h
##
@@ -281,11 +281,20 @@ typedef struct {
#define APR_INET6 APR_INET
#endif
+#ifdef APR_UNIX
#define
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532255441
##
File path: native/src/network.c
##
@@ -79,6 +80,17 @@ static apr_status_t sp_socket_cleanup(void *data)
(*s->net->cleanup)(s->opaque);
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532256127
##
File path: java/org/apache/tomcat/util/IntrospectionUtils.java
##
@@ -136,6 +138,19 @@ public static boolean setProperty(Object o, String name,
String
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532274717
##
File path: java/org/apache/tomcat/util/IntrospectionUtils.java
##
@@ -136,6 +138,19 @@ public static boolean setProperty(Object o, String name,
String
minfrin commented on pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#issuecomment-735430773
Bugzilla here: https://bz.apache.org/bugzilla/show_bug.cgi?id=64942
This is an automated message from the
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532265524
##
File path: java/org/apache/tomcat/util/IntrospectionUtils.java
##
@@ -136,6 +138,19 @@ public static boolean setProperty(Object o, String name,
String
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532267605
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532249132
##
File path: java/org/apache/tomcat/jni/Address.java
##
@@ -40,8 +40,9 @@
/**
* Create apr_sockaddr_t from hostname, address family, and
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532255441
##
File path: native/src/network.c
##
@@ -79,6 +80,17 @@ static apr_status_t sp_socket_cleanup(void *data)
(*s->net->cleanup)(s->opaque);
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532261117
##
File path: native/src/network.c
##
@@ -79,6 +80,17 @@ static apr_status_t sp_socket_cleanup(void *data)
(*s->net->cleanup)(s->opaque);
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532261154
##
File path: native/src/network.c
##
@@ -316,6 +337,11 @@ TCN_IMPLEMENT_CALL(jint, Socket, bind)(TCN_STDARGS, jlong
sock,
TCN_ASSERT(sock != 0);
minfrin commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-735452576
> Is this complete from your POV? I'd like to give this a spin next month on
FreeBSD.
> Did you run some numbers how it compares for your usecase against
localhost?
It's
michael-o commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-735453352
So you have shared machine where everyone can snoop on localhost? Since the
socket files will be owned by a Tomcat system user you want to add HTTPd to
that group to make it
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532269203
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532273756
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
https://bz.apache.org/bugzilla/show_bug.cgi?id=64941
--- Comment #7 from Mark Thomas ---
Cut it out both of you. There is no need for that sort of language.
Everyone who contributes to this community is expected to follow the code of
conduct:
http://www.apache.org/foundation/policies/conduct
minfrin opened a new pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8
This patch adds support for Unix Domain Sockets, that was added to APR v1.6.
This consists of the addition of the APR_UNIX family, as well as adding a
cleanup to remove the socket file on
https://bz.apache.org/bugzilla/show_bug.cgi?id=64943
--- Comment #1 from Graham Leggett ---
PR: https://github.com/apache/tomcat/pull/382
--
You are receiving this mail because:
You are the assignee for the bug.
-
To
https://bz.apache.org/bugzilla/show_bug.cgi?id=64941
--- Comment #8 from Michael Osipov ---
(In reply to Mark Thomas from comment #7)
> Cut it out both of you. There is no need for that sort of language.
>
> Everyone who contributes to this community is expected to follow the code of
> conduct:
minfrin opened a new pull request #382:
URL: https://github.com/apache/tomcat/pull/382
First implementation added to
org.apache.coyote.http11.Http11AprProtocol.
Depends on https://github.com/apache/tomcat-native/pull/8.
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532253902
##
File path: native/src/info.c
##
@@ -198,6 +198,9 @@ static void fill_ainfo(JNIEnv *e, jobject obj,
apr_sockaddr_t *info)
if (info->family ==
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532253991
##
File path: native/src/network.c
##
@@ -79,6 +80,15 @@ static apr_status_t sp_socket_cleanup(void *data)
(*s->net->cleanup)(s->opaque);
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532265195
##
File path: java/org/apache/tomcat/util/IntrospectionUtils.java
##
@@ -136,6 +138,19 @@ public static boolean setProperty(Object o, String name,
String
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532268550
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -347,22 +352,27 @@ public String getName() {
private String getNameInternal() {
minfrin commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-735456090
> So you have shared machine where everyone can snoop on localhost? Since
the socket files will be owned by a Tomcat system user you want to add HTTPd to
that group to make it
Sumithkr opened a new pull request #381:
URL: https://github.com/apache/tomcat/pull/381
Add this document on documentation page
[Tomcat.docx](https://github.com/apache/tomcat/files/5612520/Tomcat.docx)
This is an
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532263073
##
File path: native/src/network.c
##
@@ -316,6 +337,11 @@ TCN_IMPLEMENT_CALL(jint, Socket, bind)(TCN_STDARGS, jlong
sock,
TCN_ASSERT(sock != 0);
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532264241
##
File path: native/src/network.c
##
@@ -316,6 +337,11 @@ TCN_IMPLEMENT_CALL(jint, Socket, bind)(TCN_STDARGS, jlong
sock,
TCN_ASSERT(sock != 0);
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532267259
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532271195
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the
https://bz.apache.org/bugzilla/show_bug.cgi?id=64850
--- Comment #6 from Graham Leggett ---
For reference, unix domain socket support has been proposed to tomcat-native
here: https://bz.apache.org/bugzilla/show_bug.cgi?id=64942
--
You are receiving this mail because:
You are the assignee for
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532251725
##
File path: native/include/tcn.h
##
@@ -281,11 +281,20 @@ typedef struct {
#define APR_INET6 APR_INET
#endif
+#ifdef APR_UNIX
#define
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532265150
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -347,22 +352,27 @@ public String getName() {
private String getNameInternal() {
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532272524
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
43 matches
Mail list logo
