TCK Signature for EL API

2021-03-31 Thread Volodymyr Siedlecki
Hello,

It appears the TCK Signature tests will not be relaxed (see 1 & 2),
and I'm wondering how Tomcat will proceed with the bnd annotation in
the EL API? Will it be removed in the next release?

Thank you,

Volodymyr

1) https://github.com/eclipse-ee4j/jakartaee-tck/issues/643 (Scott's
last comment)2) TCK Thread:
https://www.eclipse.org/lists/jakartaee-tck-dev/threads.html#01235


[Bug 65211] Posix incompatible changes in shell scripts / Potential license violation

2021-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65211

--- Comment #3 from garb...@gmx.de ---
@Christopher: yes, you are absolutely right. I hesitated but in the end I
wanted to make sure that this information reaches the project.

>From my perspective Micro Focus is using the advantage of having a well-crafted
solution (Tomcat) without giving back to the community. So I wanted to report
this.

@Konstantin: thanks a lot for your thorough analysis and the suggestions. I
linked them from the ticket that I created at Micro Focus.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65124] Inefficient generated JSP code

2021-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124

--- Comment #10 from John Engebretson  ---
Good plan... our initial deployment had to be rolled back because I broke some
weird syntax in tag fragments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.45

2021-03-31 Thread Romain Manni-Bucau
+1 (non binding), tested on a few projects

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mer. 31 mars 2021 à 12:58, Martin Grigorov  a
écrit :

> On Tue, Mar 30, 2021 at 1:52 PM Mark Thomas  wrote:
>
> > The proposed Apache Tomcat 9.0.45 release is now available for voting.
> >
> > The notable changes compared to the 9.0.44 release are:
> >
> > - Fix a regression in 9.0.44 that meant that an error during an
> >asynchronous read broke all future asynchronous reads associated with
> >the same request instance.
> >
> > - Prevent concurrent calls to ServletInputStream.isReady() corrupting
> >the input buffer.
> >
> > - Update the packaged version of Tomcat Native to 1.2.27 to pick up
> >binaries built with OpenSSL 1.1.1k
> >
> > Along with lots of other bug fixes and improvements.
> >
> > For full details, see the changelog:
> > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.45/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1305/
> > The tag is:
> > https://github.com/apache/tomcat/tree/9.0.45
> > 4dcf07fd1b53d3934d408060c6ef1ea13894c16f
> >
> > The proposed 9.0.45 release is:
> > [ ] Broken - do not release
> > [ X ] Stable - go ahead and release as 9.0.45
> >
>
> Regards,
> Martin
>
>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>


Re: [VOTE] Release Apache Tomcat 8.5.65

2021-03-31 Thread Rémy Maucherat
On Tue, Mar 30, 2021 at 3:13 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.65 release is now available for voting.
>
> The notable changes compared to the 8.5.64 release are:
>
> - Fix a regression in 8.5.64 that meant that an error during an
>asynchronous read broke all future asynchronous reads associated with
>the same request instance.
>
> - Prevent concurrent calls to ServletInputStream.isReady() corrupting
>the input buffer.
>
> - Update the packaged version of Tomcat Native to 1.2.27 to pick up
>binaries built with OpenSSL 1.1.1k
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.65/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1306/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.65
> 752c1b9221f7d51a9f0f13d5ce83540589e228e4
>
> The proposed 8.5.65 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.65
>
> Rémy


Re: Tag Tomcat 7

2021-03-31 Thread Violeta Georgieva
На ср, 31.03.2021 г. в 11:46 ч. Mark Thomas  написа:
>
> On 31/03/2021 08:36, Konstantin Kolinko wrote:
> > ср, 31 мар. 2021 г. в 08:25, Violeta Georgieva :
> >>
> >> Hi,
> >>
> >> Later today I'm going to prepare Tomcat 7 for a release/vote.
> >> Please reply here if you need more time for additional fixes.
> >
> > There is a bug introduced in Tomcat Native 1.2.27 (regression in
> > handling of a configuration error).
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=65181#c8
> >
> > I wonder whether we want or can reroll a Tomcat Native release now, or
> > will wait for the next update of OpenSSL in a few months as usual.
>
> I could re-roll a Tomcat Native release now. I don't think it is
> necessary for 10.0.x, 9.0.x or 8.5.x but I can see the benefit in fixing
> it for what is likely to be the final 7.0.x release.
>

Yep if you can do that it will be great.
I'll postpone the release.

Thanks,
Violeta


Re: [VOTE] Release Apache Tomcat 10.0.5

2021-03-31 Thread Martin Grigorov
On Tue, Mar 30, 2021 at 11:46 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.5 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.4 are:
>
> - Fix a regression in 10.0.4 that meant that an error during an
>asynchronous read broke all future asynchronous reads associated with
>the same request instance.
>
> - Prevent concurrent calls to ServletInputStream.isReady() corrupting
>the input buffer.
>
> - Update the packaged version of Tomcat Native to 1.2.27 to pick up
>binaries built with OpenSSL 1.1.1k
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.5/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1304
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.5
> 328d87e3d1ef41c46b5173114e30d37394bd68b9
>
> The proposed 10.0.5 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 10.0.5 (stable)
>

Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.65

2021-03-31 Thread Martin Grigorov
On Tue, Mar 30, 2021 at 4:13 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.65 release is now available for voting.
>
> The notable changes compared to the 8.5.64 release are:
>
> - Fix a regression in 8.5.64 that meant that an error during an
>asynchronous read broke all future asynchronous reads associated with
>the same request instance.
>
> - Prevent concurrent calls to ServletInputStream.isReady() corrupting
>the input buffer.
>
> - Update the packaged version of Tomcat Native to 1.2.27 to pick up
>binaries built with OpenSSL 1.1.1k
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.65/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1306/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.65
> 752c1b9221f7d51a9f0f13d5ce83540589e228e4
>
> The proposed 8.5.65 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.65
>

Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.45

2021-03-31 Thread Martin Grigorov
On Tue, Mar 30, 2021 at 1:52 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.45 release is now available for voting.
>
> The notable changes compared to the 9.0.44 release are:
>
> - Fix a regression in 9.0.44 that meant that an error during an
>asynchronous read broke all future asynchronous reads associated with
>the same request instance.
>
> - Prevent concurrent calls to ServletInputStream.isReady() corrupting
>the input buffer.
>
> - Update the packaged version of Tomcat Native to 1.2.27 to pick up
>binaries built with OpenSSL 1.1.1k
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.45/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1305/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.45
> 4dcf07fd1b53d3934d408060c6ef1ea13894c16f
>
> The proposed 9.0.45 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.45
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.45

2021-03-31 Thread Rémy Maucherat
On Tue, Mar 30, 2021 at 12:52 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.45 release is now available for voting.
>
> The notable changes compared to the 9.0.44 release are:
>
> - Fix a regression in 9.0.44 that meant that an error during an
>asynchronous read broke all future asynchronous reads associated with
>the same request instance.
>
> - Prevent concurrent calls to ServletInputStream.isReady() corrupting
>the input buffer.
>
> - Update the packaged version of Tomcat Native to 1.2.27 to pick up
>binaries built with OpenSSL 1.1.1k
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.45/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1305/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.45
> 4dcf07fd1b53d3934d408060c6ef1ea13894c16f
>
> The proposed 9.0.45 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.45
>
> Rémy


[Bug 65124] Inefficient generated JSP code

2021-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124

--- Comment #9 from Mark Thomas  ---
Just a heads up that I am going to be spending some time improving the code
coverage of the unit tests for the Generator class before looking at options to
address issues 1 and 3. There are a lot of edge cases being handled in that
class and I want to cover more of them with tests before I start changing
things.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tag Tomcat 7

2021-03-31 Thread Mark Thomas

On 31/03/2021 08:36, Konstantin Kolinko wrote:

ср, 31 мар. 2021 г. в 08:25, Violeta Georgieva :


Hi,

Later today I'm going to prepare Tomcat 7 for a release/vote.
Please reply here if you need more time for additional fixes.


There is a bug introduced in Tomcat Native 1.2.27 (regression in
handling of a configuration error).
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181#c8

I wonder whether we want or can reroll a Tomcat Native release now, or
will wait for the next update of OpenSSL in a few months as usual.


I could re-roll a Tomcat Native release now. I don't think it is 
necessary for 10.0.x, 9.0.x or 8.5.x but I can see the benefit in fixing 
it for what is likely to be the final 7.0.x release.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat-jakartaee-migration] branch master updated: Better wording

2021-03-31 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git


The following commit(s) were added to refs/heads/master by this push:
 new a96fe39  Better wording
a96fe39 is described below

commit a96fe391f7723cac481fa03c7668fbb48f721176
Author: remm 
AuthorDate: Wed Mar 31 10:42:07 2021 +0200

Better wording
---
 CHANGES.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGES.md b/CHANGES.md
index 669b1b2..15b96ab 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -3,7 +3,7 @@
 ## 0.3.0 (in progress)
 
 - Fix [#14](https://github.com/apache/tomcat-jakartaee-migration/issues/14). 
Do not migrate `javax.xml.(registry|rpc)` namespaces. (mgrigorov)
-- The class transformer will now validate that its rewrite exists in the 
runtime environment (remm)
+- The class transformer will now validate that the target classes in the 
Jakarta namespace exist in the runtime environment (remm)
 
 ## 0.2.0
 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Cosmetic change

2021-03-31 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 443cbf4  Cosmetic change
443cbf4 is described below

commit 443cbf493d95c9b47d39ad0a8a1e93715bda2206
Author: remm 
AuthorDate: Wed Mar 31 08:39:57 2021 +0200

Cosmetic change
---
 java/org/apache/catalina/loader/WebappLoader.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/loader/WebappLoader.java 
b/java/org/apache/catalina/loader/WebappLoader.java
index a7d8693..a9d5ccc 100644
--- a/java/org/apache/catalina/loader/WebappLoader.java
+++ b/java/org/apache/catalina/loader/WebappLoader.java
@@ -370,8 +370,9 @@ public class WebappLoader extends LifecycleMBeanBase 
implements Loader{
 ClassFileTransformer transformer = null;
 try {
 EESpecProfile profile = 
EESpecProfile.valueOf(getJakartaConverter());
-// FIXME: transformer = new ClassConverter(profile); after 
0.2
 transformer = 
ClassConverter.class.getConstructor(EESpecProfile.class).newInstance(profile);
+// FIXME: after Migration 0.3
+//transformer = new 
ClassConverter(EESpecProfile.valueOf(getJakartaConverter()));
 } catch (InvocationTargetException | NoSuchMethodException | 
IllegalArgumentException ignored) {
 // Use default value with no argument constructor
 transformer = new ClassConverter();

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.0.5

2021-03-31 Thread Rémy Maucherat
On Tue, Mar 30, 2021 at 10:46 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.5 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.4 are:
>
> - Fix a regression in 10.0.4 that meant that an error during an
>asynchronous read broke all future asynchronous reads associated with
>the same request instance.
>
> - Prevent concurrent calls to ServletInputStream.isReady() corrupting
>the input buffer.
>
> - Update the packaged version of Tomcat Native to 1.2.27 to pick up
>binaries built with OpenSSL 1.1.1k
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.5/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1304
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.5
> 328d87e3d1ef41c46b5173114e30d37394bd68b9
>
> The proposed 10.0.5 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.5 (stable)
>
> We should probably consider moving the migration tool to 1.0 if it "works".

Rémy


Re: Tag Tomcat 7

2021-03-31 Thread Konstantin Kolinko
ср, 31 мар. 2021 г. в 08:25, Violeta Georgieva :
>
> Hi,
>
> Later today I'm going to prepare Tomcat 7 for a release/vote.
> Please reply here if you need more time for additional fixes.

There is a bug introduced in Tomcat Native 1.2.27 (regression in
handling of a configuration error).
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181#c8

I wonder whether we want or can reroll a Tomcat Native release now, or
will wait for the next update of OpenSSL in a few months as usual.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org