cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655088342
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
https://bz.apache.org/bugzilla/show_bug.cgi?id=65390
--- Comment #6 from Mark Thomas ---
Just following up in this as we'd really like to catch regressions like this in
the ~3 working day window between the release candidate being available and the
release vote concluding.
It is great that you
https://bz.apache.org/bugzilla/show_bug.cgi?id=65387
--- Comment #18 from Mark Thomas ---
Just following up in this as we'd really like to catch regressions like this in
the ~3 working day window between the release candidate being available and the
release vote concluding.
It is great that you
All,
Despite the extra tests I added to improve code coverage to almost 100%
for JSP code generation, the changes I made to remove unnecessary code
have triggered a couple of regressions. There is no easy way to avoid
these regressions.
Given the above do we want to pull forward the July
rmaucher commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-865007741
This looks good enough to put it in. I can probably think about enhancements
late. The only thing that I'm really wondering about is why the
UserDatabaseRealm did not get
cklein05 commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-865024538
> The only thing that I'm really wondering about is why the
UserDatabaseRealm did not get arbitrary attributes.
My first focus was on UserDatabaseRealm and JDNIRealm.
On Mon, Jun 21, 2021 at 12:17 PM Mark Thomas wrote:
>
> All,
>
> Despite the extra tests I added to improve code coverage to almost 100%
> for JSP code generation, the changes I made to remove unnecessary code
> have triggered a couple of regressions. There is no easy way to avoid
> these
https://bz.apache.org/bugzilla/show_bug.cgi?id=65390
--- Comment #7 from tk...@ai-ag.de ---
Hallo Mark,
first I’d like to thank you for your very fast response on our bug report :)
We use tomcat-embedded and pull it from a maven repository.
If you made your release candidates available via a
cklein05 commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-865053410
Please, wait at least until I've pushed my latest changes. Also, JDBC stuff
in DataSourceRealm needs some adjustments in order not to put arbitrary
`java.sql` objects into the
rmaucher commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-865049209
No, the Tomcat project is not responsible for Jakarta and has no control
over it, so we cannot make that change.
I'm perfectly fine as it is, you're not supposed to do
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 98d61c1 Fix typos
new fa24edd Improve French translations (remm)
new 2b92581 Improvements to Korean
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit fa24eddfc49cc2e19b4cd4606a4eb3b7d55fed98
Author: Mark Thomas
AuthorDate: Mon Jun 21 17:34:12 2021 +0100
Improve
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 2b925814e6af699d4ea6f740d408310389fee03a
Author: Mark Thomas
AuthorDate: Mon Jun 21 17:37:50 2021 +0100
Improvements
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new b651945 Make fields accessible to sub-classes
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 86b9958 Make fields accessible to sub-classes of
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 2b92581 Improvements to Korean translations. (woonsan)
add e40d778 Make fields accessible to sub-classes of
Author: markt
Date: Mon Jun 21 16:14:49 2021
New Revision: 48451
Log:
Drop Apache Tomcat 9.0.46 from mirror system
Removed:
release/tomcat/tomcat-9/v9.0.46/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For
Author: markt
Date: Mon Jun 21 16:14:14 2021
New Revision: 48450
Log:
Drop Apache Tomcat 10.0.6 from mirror system
Removed:
release/tomcat/tomcat-10/v10.0.6/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For
On 21/06/2021 14:16, Rémy Maucherat wrote:
On Mon, Jun 21, 2021 at 12:17 PM Mark Thomas wrote:
All,
Despite the extra tests I added to improve code coverage to almost 100%
for JSP code generation, the changes I made to remove unnecessary code
have triggered a couple of regressions. There is
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655202844
##
File path: java/org/apache/catalina/realm/GenericPrincipal.java
##
@@ -304,10 +333,165 @@ public void logout() throws Exception {
}
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655204617
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
cklein05 commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-864868657
> So you basically want to protect the admin/developer to shoot in the foot?
Yes, as it may hurt badly. Also, only these _denied attributes_ makes using
the (otherwise
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655222693
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655222693
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655234294
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655239478
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655173166
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655173373
##
File path: java/org/apache/catalina/realm/JNDIRealm.java
##
@@ -469,6 +474,19 @@
*/
protected boolean useContextClassLoader = true;
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655174381
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-864846238
>
>
> > Can you please explain the purpose of the `deniedAttributes`? Why is it
necessary, what is the usecase for?
>
> _Denied Attributes_ is the internal term of
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655190479
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655192559
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -572,6 +801,21 @@ protected void startInternal() throws LifecycleException {
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655175314
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -572,6 +801,21 @@ protected void startInternal() throws LifecycleException {
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655176832
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655177819
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655178151
##
File path: java/org/apache/catalina/TomcatPrincipal.java
##
@@ -47,4 +48,58 @@
* exception to LoginContext
*/
void
michael-o commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655182143
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
michael-o edited a comment on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-864846238
>
>
> > Can you please explain the purpose of the `deniedAttributes`? Why is it
necessary, what is the usecase for?
>
> _Denied Attributes_ is the internal
cklein05 commented on a change in pull request #428:
URL: https://github.com/apache/tomcat/pull/428#discussion_r655188601
##
File path: java/org/apache/catalina/realm/DataSourceRealm.java
##
@@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() {
}
+/**
+
39 matches
Mail list logo
