Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Rémy Maucherat
On Wed, 2007-10-17 at 05:47 +0200, Peter Rossbach wrote: Hi Remy, I think the patch is incomplete this line seem not correct: +else + JRE_HOME=/usr +fi better +else + JRE_HOME=/usr/bin/java +fi The path to the Java executable is $JRE_HOME/bin/java, so

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Peter Rossbach
Hi Remy, but is'nt /usr/lib/java the correct value to JRE_HOME ? Regards Peter Am 17.10.2007 um 13:10 schrieb Rémy Maucherat: On Wed, 2007-10-17 at 05:47 +0200, Peter Rossbach wrote: Hi Remy, I think the patch is incomplete this line seem not correct: +else + JRE_HOME=/usr +

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Tim Funk
There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter happy since he can symlink my_program_that_i_can_see_in_ps to java. -Tim Rémy Maucherat wrote: On Wed, 2007-10-17 at

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Peter Rossbach
+1 for that env variable, but also autodetection must be implemented Peter Am 17.10.2007 um 13:28 schrieb Tim Funk: There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Rémy Maucherat
On Wed, 2007-10-17 at 07:28 -0400, Tim Funk wrote: There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter happy since he can symlink my_program_that_i_can_see_in_ps to java.

DO NOT REPLY [Bug 43530] - Bad links on Apache Tomcat 6.0 Documentation Index

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43530. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Tomcat6 BUILDING.txt misunderstood?

2007-10-17 Thread DI Roman Fiedler
Hi List, tomcat6 Building.txt says: * Download a Java Development Kit (JDK) release (version 1.5.x or later) from: http://java.sun.com/j2se/ I tried it with 1.6 (which is later than 1.5.x) and it failed. With 1.5 it worked. Did I misunderstand the line or should 1.6 have worked also?

Re: Tomcat6 BUILDING.txt misunderstood?

2007-10-17 Thread Yoav Shapira
Hi DI, On 10/17/07, DI Roman Fiedler [EMAIL PROTECTED] wrote: If misunderstood: Change line to Download a Java Development Kit (JDK) release (version 1.5.x) from: If error: search for it? It's an error: the build is intended to work with Java 1.5 and later, including Java 1.6, but it

Re: Tomcat6 BUILDING.txt misunderstood?

2007-10-17 Thread DI Roman Fiedler
Yoav Shapira wrote: Hi DI, On 10/17/07, DI Roman Fiedler [EMAIL PROTECTED] wrote: If misunderstood: Change line to Download a Java Development Kit (JDK) release (version 1.5.x) from: If error: search for it? It's an error: the build is intended to work with Java 1.5 and later,

Re: Tomcat6 BUILDING.txt misunderstood?

2007-10-17 Thread Paul Shemansky
My Fellow Code Monkeys, You may have noticed I recommended for a push to change the build to a Maven 2 structure. Before starting a Mavenization discussion thread, I wanted to investigate the entire build process. My first day here, I noticed that we are downloading DBCP source files and

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Rainer Jung
jean-frederic clere wrote: Rémy Maucherat wrote: On Wed, 2007-10-17 at 07:28 -0400, Tim Funk wrote: There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter happy since he can

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread jean-frederic clere
Rémy Maucherat wrote: On Wed, 2007-10-17 at 07:28 -0400, Tim Funk wrote: There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter happy since he can symlink

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread jean-frederic clere
Rainer Jung wrote: jean-frederic clere wrote: Rémy Maucherat wrote: On Wed, 2007-10-17 at 07:28 -0400, Tim Funk wrote: There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter

DO NOT REPLY [Bug 43641] New: - Using the bind attribute for Membership tag causes Multicast to break

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 43641] - Using the bind attribute for Membership tag causes Multicast to break

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 43642] - Add prestartminSpareThreads attribute for Executor

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43642. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 43642] New: - Add prestartminSpareThreads attribute for Executor

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43642. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 43643] New: - Setting the executor attribute in a connector that does not support the executor attribute causes a

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43643. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 43643] - Setting the executor attribute in a connector that does not support the executor attribute causes a

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43643. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: Tomcat6 BUILDING.txt misunderstood?

2007-10-17 Thread Filip Hanik - Dev Lists
Paul Shemansky wrote: My Fellow Code Monkeys, You may have noticed I recommended for a push to change the build to a Maven 2 structure. Before starting a Mavenization discussion thread, I wanted to investigate the entire build process. My first day here, I noticed that we are downloading DBCP

svn commit: r585538 - /tomcat/sandbox/gdev6x/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 08:34:53 2007 New Revision: 585538 URL: http://svn.apache.org/viewvc?rev=585538view=rev Log: http://issues.apache.org/bugzilla/show_bug.cgi?id=43641 Modified: tomcat/sandbox/gdev6x/java/org/apache/catalina/tribes/membership/McastServiceImpl.java Modified:

svn commit: r585541 - /tomcat/sandbox/gdev6x/java/org/apache/catalina/core/StandardThreadExecutor.java

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 08:41:20 2007 New Revision: 585541 URL: http://svn.apache.org/viewvc?rev=585541view=rev Log: http://issues.apache.org/bugzilla/show_bug.cgi?id=43642 Modified: tomcat/sandbox/gdev6x/java/org/apache/catalina/core/StandardThreadExecutor.java Modified:

Re: Tomcat6 BUILDING.txt misunderstood?

2007-10-17 Thread Paul Shemansky
On 10/17/07, Filip Hanik - Dev Lists [EMAIL PROTECTED] wrote: Paul Shemansky wrote: My Fellow Code Monkeys, . My first day here, I noticed that we are downloading DBCP source files and compiling them with the Tomcat build. In my humble opinion, I think it would be nice to just include

svn commit: r585542 - /tomcat/sandbox/gdev6x/java/org/apache/coyote/http11/Http11NioProtocol.java

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 08:42:52 2007 New Revision: 585542 URL: http://svn.apache.org/viewvc?rev=585542view=rev Log: http://issues.apache.org/bugzilla/show_bug.cgi?id=43634 Modified: tomcat/sandbox/gdev6x/java/org/apache/coyote/http11/Http11NioProtocol.java Modified:

svn commit: r585604 - in /tomcat/tc6.0.x/trunk: STATUS java/org/apache/coyote/http11/Http11NioProtocol.java

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 10:51:44 2007 New Revision: 585604 URL: http://svn.apache.org/viewvc?rev=585604view=rev Log: Fix property setter for keystore type Modified: tomcat/tc6.0.x/trunk/STATUS tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Modified:

svn commit: r585606 - in /tomcat/sandbox/gdev6x: build.properties.default java/org/apache/catalina/core/StandardServer.java

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 10:54:15 2007 New Revision: 585606 URL: http://svn.apache.org/viewvc?rev=585606view=rev Log: Forward port from 6.0 Modified: tomcat/sandbox/gdev6x/build.properties.default tomcat/sandbox/gdev6x/java/org/apache/catalina/core/StandardServer.java Modified:

svn commit: r585610 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 11:00:23 2007 New Revision: 585610 URL: http://svn.apache.org/viewvc?rev=585610view=rev Log: proposed bug fix Modified: tomcat/tc6.0.x/trunk/STATUS Modified: tomcat/tc6.0.x/trunk/STATUS URL:

DO NOT REPLY [Bug 43641] - Using the bind attribute for Membership tag causes Multicast to break

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

svn commit: r585616 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread pero
Author: pero Date: Wed Oct 17 11:14:09 2007 New Revision: 585616 URL: http://svn.apache.org/viewvc?rev=585616view=rev Log: add my vote Modified: tomcat/tc6.0.x/trunk/STATUS Modified: tomcat/tc6.0.x/trunk/STATUS URL:

DO NOT REPLY [Bug 43641] - Using the bind attribute for Membership tag causes Multicast to break

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 43641] - Using the bind attribute for Membership tag causes Multicast to break

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Paul Shemansky
Dear Fellow Tomcat Developers, As you may have already noticed, I recently joined the ASF and the Tomcat Developer's List. I have been a Maven 2 user since 2005, and I previously used Ant for all of my projects. I suffered through many hardships migrating from Ant to Maven, but in my humble

svn commit: r585708 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 14:39:15 2007 New Revision: 585708 URL: http://svn.apache.org/viewvc?rev=585708view=rev Log: proposed fix Modified: tomcat/tc6.0.x/trunk/STATUS Modified: tomcat/tc6.0.x/trunk/STATUS URL:

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Rémy Maucherat
On Wed, 2007-10-17 at 16:21 -0400, Paul Shemansky wrote: It is not my intention to start a flame war between Ant and Maven users, but merely to propose Maven 2 to this group, and respectfully use this thread to discuss the advantages and disadvantages of switching Tomcat's build process within

svn commit: r585707 - /tomcat/sandbox/gdev6x/java/org/apache/catalina/startup/ConnectorCreateRule.java

2007-10-17 Thread fhanik
Author: fhanik Date: Wed Oct 17 14:38:24 2007 New Revision: 585707 URL: http://svn.apache.org/viewvc?rev=585707view=rev Log: http://issues.apache.org/bugzilla/show_bug.cgi?id=43643 Modified: tomcat/sandbox/gdev6x/java/org/apache/catalina/startup/ConnectorCreateRule.java Modified:

DO NOT REPLY [Bug 43643] - Setting the executor attribute in a connector that does not support the executor attribute causes a

2007-10-17 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43643. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Filip Hanik - Dev Lists
Rémy Maucherat wrote: On Wed, 2007-10-17 at 16:21 -0400, Paul Shemansky wrote: It is not my intention to start a flame war between Ant and Maven users, but merely to propose Maven 2 to this group, and respectfully use this thread to discuss the advantages and disadvantages of switching

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Filip Hanik - Dev Lists
lemme give you my feedback and some history Paul Shemansky wrote: Dear Fellow Tomcat Developers, As you may have already noticed, I recently joined the ASF and the Tomcat Developer's List. I have been a Maven 2 user since 2005, and I previously used Ant for all of my projects. I suffered

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Costin Manolache
-1 as well on switching to maven as default ( or back to many source tree 'modules' ). But if you want to create a maven build file ( or a Makefile, or eclipse/netbeans projects, etc :-) that builds tomcat - I personally don't see a problem with that - as long as it doesn't require moving code

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Mark Thomas
Paul Shemansky wrote: Key features that may be useful to us are : - The Standard Directory Layout - Specifically, multi-module builds. This might make managing individual components easier for catalina, coyote, naming, jsp/servlet api/implementation, connector, etc. might isn't a compelling

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Wendy Smoak
On 10/17/07, Filip Hanik - Dev Lists [EMAIL PROTECTED] wrote: We currently have a distribute to Maven repo in place. The most current version is in the sandbox, that would allow us to publish to the central ASF repo with signed JAR's. This allows(will allow) other projects that do use Maven,

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Konstantin Kolinko
Hi, Paul! Just a suggestion how to start (seeing all the opinions around): You may start playing in some sandbox, creating a directory structure there, and pulling branches of tomcat code through the use of svn:externals property. It is called creating a view. Having done that, it will be more

svn commit: r585875 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread pero
Author: pero Date: Wed Oct 17 22:41:23 2007 New Revision: 585875 URL: http://svn.apache.org/viewvc?rev=585875view=rev Log: add my vote Modified: tomcat/tc6.0.x/trunk/STATUS Modified: tomcat/tc6.0.x/trunk/STATUS URL:

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Peter Rossbach
Yes! I can't see that maven build is better choice. Peter Vote -1 for build with maven! Am 18.10.2007 um 00:45 schrieb Mark Thomas: Paul Shemansky wrote: Key features that may be useful to us are : - The Standard Directory Layout - Specifically, multi-module builds. This might make

svn commit: r585876 - /tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc

2007-10-17 Thread mturk
Author: mturk Date: Wed Oct 17 22:50:50 2007 New Revision: 585876 URL: http://svn.apache.org/viewvc?rev=585876view=rev Log: Fix compilation. Add missing backslash Modified: tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc Modified:

svn commit: r585877 - /tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc

2007-10-17 Thread mturk
Author: mturk Date: Wed Oct 17 22:56:42 2007 New Revision: 585877 URL: http://svn.apache.org/viewvc?rev=585877view=rev Log: Fix compilation. Properly quote the strings Modified: tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc Modified: