Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Mark Thomas
Konstantin Kolinko wrote: I've created a patch to clean them: https://issues.apache.org/bugzilla/attachment.cgi?id=21797 Many thanks. What is the history of this code before rev. 389146 of 2006-03-27 when /tomcat/tc6.0.x/trunk was created? As I recall, the whole EL implementation was provid

svn commit: r646196 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-08 Thread fhanik
Author: fhanik Date: Tue Apr 8 23:43:37 2008 New Revision: 646196 URL: http://svn.apache.org/viewvc?rev=646196&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=64619

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Konstantin Kolinko
Surely, there are irregularities. There are many places where java.lang.Class instance is not a parameter to the method, but obtained in place by calling obj.getClass(). In such cases comparing object's class against primitive type classes is meaningless. I've created a patch to clean them: http

DO NOT REPLY [Bug 44766] Tomcat's EL implementation doesn' t coerce custom Number subclasses

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44766 --- Comment #2 from Konstantin Kolinko <[EMAIL PROTECTED]> 2008-04-08 18:39:52 PST --- Created an attachment (id=21797) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21797) Code cleanup for org.apache.el.* - removes attemp

Re: svn commit: r646106 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Remy Maucherat
On Tue, 2008-04-08 at 22:26 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Tue Apr 8 15:26:05 2008 > New Revision: 646106 > > URL: http://svn.apache.org/viewvc?rev=646106&view=rev > Log: > Better patch for 44766. I still can't see why the original code listed the > classes individually.

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-08 Thread Filip Hanik - Dev Lists
ignore my prev email about the mem leak, I wasn't up to current in trunk, and was running into something else Filip [EMAIL PROTECTED] wrote: Author: markt Date: Mon Apr 7 15:47:54 2008 New Revision: 645722 URL: http://svn.apache.org/viewvc?rev=645722&view=rev Log: All of the issues I was see

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-08 Thread Filip Hanik - Dev Lists
just taking a quick look at the patch, this is a memory leak. the buffer will simply grow larger and larger until an OOM happens, if one keeps marking the buffer when I am more awake, I'll help out on this, it's very easy to reproduce http://people.apache.org/~fhanik/upload-mark.jsp Filip [EMA

DO NOT REPLY [Bug 44354] cookies= false not honored when jsessionid comes from a cookie

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44354 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r646121 - /tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c

2008-04-08 Thread markt
Author: markt Date: Tue Apr 8 15:52:49 2008 New Revision: 646121 URL: http://svn.apache.org/viewvc?rev=646121&view=rev Log: Fix bug 44436. Make sure -dev is reported in logs for dev builds. Align version message with mod_jk. Patch provided by Tim Whittington (with a very minor tweak) Modified:

DO NOT REPLY [Bug 44436] Report standardised versions on ISAPI redirector init

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44436 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 44438] Extended logging for ISAPI redirector request init

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44438 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r646111 - /tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c

2008-04-08 Thread markt
Author: markt Date: Tue Apr 8 15:38:19 2008 New Revision: 646111 URL: http://svn.apache.org/viewvc?rev=646111&view=rev Log: Fix bug 44438. Provide additional debug logging during initialisation. Patch provided by Tim Whittington. Modified: tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugi

svn commit: r646106 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread markt
Author: markt Date: Tue Apr 8 15:26:05 2008 New Revision: 646106 URL: http://svn.apache.org/viewvc?rev=646106&view=rev Log: Better patch for 44766. I still can't see why the original code listed the classes individually. Modified: tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java Modi

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Mark Thomas
Konstantin Kolinko wrote: Well, obviously the new code is not equivalent to the old one, because Long.TYPE and other TYPE constants are the classes for the primitive types (long, int etc.), and those are not an instance of java.lang.Number. Yep my bad. I mis-read what my IDE was telling me. Tha

svn commit: r646102 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread markt
Author: markt Date: Tue Apr 8 15:17:34 2008 New Revision: 646102 URL: http://svn.apache.org/viewvc?rev=646102&view=rev Log: Revert previous fix as it needs correcting. Modified: tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java Modified: tomcat/trunk/java/org/apache/el/lang/ELArithmeti

DO NOT REPLY [Bug 44448] Invalid Response if HTTP Status = 304

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=8 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Konstantin Kolinko
Well, obviously the new code is not equivalent to the old one, because Long.TYPE and other TYPE constants are the classes for the primitive types (long, int etc.), and those are not an instance of java.lang.Number. >From the sources: o.a.el.lang.ELArithmetic.isNumberType() is used in o.a.el.la

DO NOT REPLY [Bug 44766] Tomcat's EL implementation doesn' t coerce custom Number subclasses

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44766 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-08 14:23:38 PST --- I've committed a fix to trunk. The original code is a mystery to me too at the minute. I'll propose this for 6.0.x once people on the list have had a coupl

svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread markt
Author: markt Date: Tue Apr 8 14:25:04 2008 New Revision: 646076 URL: http://svn.apache.org/viewvc?rev=646076&view=rev Log: This fixes 44766 but I can't see why the code was written as originally coded. Any light much appreciated. I'll give it a couple of days and then, assuming there are no ob

Re: Web Service deployed on Tomcat stops responding after sometime

2008-04-08 Thread Jim Manico
You want tomcat-users, not tomcat developers. This list is for folks who are building the Tomcat product. You will not get an answer here. - Jim Hi, I haven't used Tomcat before and is the first time I am using it. I have Web Service that is deployed on Tomcat 5 installed on my local system.

Web Service deployed on Tomcat stops responding after sometime

2008-04-08 Thread whitesox12
Hi, I haven't used Tomcat before and is the first time I am using it. I have Web Service that is deployed on Tomcat 5 installed on my local system. Web Service I am using Spring, Hibernate. The issue I am facing is after deploying a service all works fine. As soon as I leave the service idle mea

DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #22 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-08 09:20:30 PST --- Those were meant to be either or options. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving th

DO NOT REPLY [Bug 44777] additional entries in logging.properties ignored

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44777 Mass Dosage <[EMAIL PROTECTED]> changed: What|Removed |Added Resolution|WORKSFORME |INVALID --- C

DO NOT REPLY [Bug 44777] additional entries in logging.properties ignored

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44777 Rainer Jung <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 44777] additional entries in logging.properties ignored

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44777 Mass Dosage <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED]

DO NOT REPLY [Bug 44777] New: additional entries in logging. properties ignored

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44777 Summary: additional entries in logging.properties ignored Product: Tomcat 6 Version: 6.0.16 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priori

DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #21 from John V Denley <[EMAIL PROTECTED]> 2008-04-08 02:16:55 PST --- Mark Thomas stated: "Short term fix options: - add %JAVA_HOME%\bin to the PATH - copy %JAVA_HOME%\bin\mscvr71.dll to a folder on the path" surely if

DO NOT REPLY [Bug 44463] GUI deploy in manager webapp fails due to missing common-io dependency

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44463 Rainer Jung <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r645793 - /tomcat/current/tc5.5.x/STATUS.txt

2008-04-08 Thread rjung
Author: rjung Date: Tue Apr 8 01:43:24 2008 New Revision: 645793 URL: http://svn.apache.org/viewvc?rev=645793&view=rev Log: Fix BZ 44463: War file upload in manager webapp fails due to missing commons-io dependency. Added commons-io 1.4. Part 3/3 Modified: tomcat/current/tc5.5.x/STATUS.txt

svn commit: r645792 - in /tomcat/container/tc5.5.x/webapps: docs/changelog.xml manager/build.xml

2008-04-08 Thread rjung
Author: rjung Date: Tue Apr 8 01:42:44 2008 New Revision: 645792 URL: http://svn.apache.org/viewvc?rev=645792&view=rev Log: Fix BZ 44463: War file upload in manager webapp fails due to missing commons-io dependency. Added commons-io 1.4. Part 2 Modified: tomcat/container/tc5.5.x/webapps/docs

svn commit: r645791 - in /tomcat/build/tc5.5.x: build.properties.default build.xml

2008-04-08 Thread rjung
Author: rjung Date: Tue Apr 8 01:42:02 2008 New Revision: 645791 URL: http://svn.apache.org/viewvc?rev=645791&view=rev Log: Fix BZ 44463: War file upload in manager webapp fails due to missing commons-io dependency. Added commons-io 1.4. Part 1 Modified: tomcat/build/tc5.5.x/build.properties

DO NOT REPLY [Bug 44775] restart

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44775 Olivier Jaquemet <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 44775] New: restart

2008-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44775 Summary: restart Product: Tomcat 5 Version: Unknown Platform: PC OS/Version: Windows Vista Status: NEW Severity: normal Priority: P2 Component: Catal