DO NOT REPLY [Bug 46907] Jasper with log4j in web-app classpath and debug level enabled prevents reading HTTP POST stream from JSP

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46907





--- Comment #12 from Mark Thomas ma...@apache.org  2009-07-23 23:18:42 PST ---
I have removed the debug logging (of the request parameters) that caused the
input stream to be consumed in trunk. The patch has been proposed for 5.5.x and
6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797425 - in /tomcat/trunk: build.xml dist.xml extras.xml

2009-07-24 Thread rjung
Author: rjung
Date: Fri Jul 24 12:14:05 2009
New Revision: 797425

URL: http://svn.apache.org/viewvc?rev=797425view=rev
Log:
Correct build.properties.default file name in
more build files and explain more explicit how
the customization files work.

Modified:
tomcat/trunk/build.xml
tomcat/trunk/dist.xml
tomcat/trunk/extras.xml

Modified: tomcat/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=797425r1=797424r2=797425view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Fri Jul 24 12:14:05 2009
@@ -20,8 +20,15 @@
 
   !-- = Initialize Property Values === --
 
-  !-- See build.properties.default in the top level directory for all 
--
-  !-- property values you must customize for successful building!!!--
+  !-- We read customizable properties from the file 
build.properties.default --
+  !-- and also from build.properties if it exists.  
 --
+  !-- The values in build.properties have stronger preference.  
 --
+  !-- If you want to customize your build, you can either change the values   
 --
+  !-- directly in the default file, or create a new build.properties and set  
 --
+  !-- the values there. This way you don't have to change a file which is 
part --
+  !-- of the original project source code.
 --
+  !-- See build.properties.default in the top level directory for some  
 --
+  !-- property values you may customize.  
 --
   property file=${user.home}/build.properties/
   property file=build.properties/
 

Modified: tomcat/trunk/dist.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=797425r1=797424r2=797425view=diff
==
--- tomcat/trunk/dist.xml (original)
+++ tomcat/trunk/dist.xml Fri Jul 24 12:14:05 2009
@@ -20,8 +20,15 @@
 
   !-- = Initialize Property Values === --
 
-  !-- See build.properties.sample in the top level directory for all --
-  !-- property values you must customize for successful building!!!--
+  !-- We read customizable properties from the file 
build.properties.default --
+  !-- and also from build.properties if it exists.  
 --
+  !-- The values in build.properties have stronger preference.  
 --
+  !-- If you want to customize your build, you can either change the values   
 --
+  !-- directly in the default file, or create a new build.properties and set  
 --
+  !-- the values there. This way you don't have to change a file which is 
part --
+  !-- of the original project source code.
 --
+  !-- See build.properties.default in the top level directory for some  
 --
+  !-- property values you may customize.  
 --
   property file=${user.home}/build.properties/
   property file=build.properties/
 

Modified: tomcat/trunk/extras.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/extras.xml?rev=797425r1=797424r2=797425view=diff
==
--- tomcat/trunk/extras.xml (original)
+++ tomcat/trunk/extras.xml Fri Jul 24 12:14:05 2009
@@ -20,8 +20,15 @@
 
   !-- = Initialize Property Values === --
 
-  !-- See build.properties.sample in the top level directory for all --
-  !-- property values you must customize for successful building!!!--
+  !-- We read customizable properties from the file 
build.properties.default --
+  !-- and also from build.properties if it exists.  
 --
+  !-- The values in build.properties have stronger preference.  
 --
+  !-- If you want to customize your build, you can either change the values   
 --
+  !-- directly in the default file, or create a new build.properties and set  
 --
+  !-- the values there. This way you don't have to change a file which is 
part --
+  !-- of the original project source code.
 --
+  !-- See build.properties.default in the top level directory for some  
 --
+  !-- property values you may customize.  
 --
   property file=${user.home}/build.properties/
   property file=build.properties/
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-24 Thread Rainer Jung
On 23.07.2009 20:43, sebb wrote:
 On 23/07/2009, ma...@apache.org ma...@apache.org wrote:
 Author: markt
  Date: Thu Jul 23 17:15:55 2009
  New Revision: 797151

  URL: http://svn.apache.org/viewvc?rev=797151view=rev
  Log:
  Correct the file name

  Modified:
 tomcat/trunk/build.xml

  Modified: tomcat/trunk/build.xml
  URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=797151r1=797150r2=797151view=diff
  
 ==
  --- tomcat/trunk/build.xml (original)
  +++ tomcat/trunk/build.xml Thu Jul 23 17:15:55 2009
  @@ -20,7 +20,7 @@

!-- = Initialize Property Values === 
 --

  -  !-- See build.properties.sample in the top level directory for all
  --
  +  !-- See build.properties.default in the top level directory for all   
   --
!-- property values you must customize for successful building!!!
 --
 
 AFAICT there's no *need* to customise any values, so may I suggest:
 
 s/for all/for/
 s/you must/you may need to/

I fixed the file name in the other two build files also, and made the
text more explicit. I hope everyone is satisfied ...

See: https://svn.apache.org/viewcvs.cgi?view=revrev=797425

Regards,

Rainer



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-24 Thread sebb
On 24/07/2009, Rainer Jung rainer.j...@kippdata.de wrote:
 On 23.07.2009 20:43, sebb wrote:
   On 23/07/2009, ma...@apache.org ma...@apache.org wrote:
   Author: markt
Date: Thu Jul 23 17:15:55 2009
New Revision: 797151
  
URL: http://svn.apache.org/viewvc?rev=797151view=rev
Log:
Correct the file name
  
Modified:
   tomcat/trunk/build.xml
  
Modified: tomcat/trunk/build.xml
URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=797151r1=797150r2=797151view=diff

 ==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Thu Jul 23 17:15:55 2009
@@ -20,7 +20,7 @@
  
  !-- = Initialize Property Values 
 === --
  
-  !-- See build.properties.sample in the top level directory for all 
 --
+  !-- See build.properties.default in the top level directory for 
 all --
  !-- property values you must customize for successful building!!! 
--
  
   AFAICT there's no *need* to customise any values, so may I suggest:
  
   s/for all/for/
   s/you must/you may need to/


 I fixed the file name in the other two build files also, and made the
  text more explicit. I hope everyone is satisfied ...

+1

  See: https://svn.apache.org/viewcvs.cgi?view=revrev=797425

That's much clearer; thanks!

  Regards,


  Rainer




  -
  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
  For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797528 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/

2009-07-24 Thread fhanik
Author: fhanik
Date: Fri Jul 24 15:24:52 2009
New Revision: 797528

URL: http://svn.apache.org/viewvc?rev=797528view=rev
Log:
Add in Linux special case for performance optimization around locking.
Set default queue to be the fair one
Remove unused code


Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java

tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java

tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=797528r1=797527r2=797528view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Jul 24 15:24:52 2009
@@ -353,10 +353,16 @@
 attribute name=fairQueue required=false
   p(boolean) Set to true if you wish that calls to getConnection should 
be treated
  fairly in a true FIFO fashion. This uses the 
codeorg.apache.tomcat.jdbc.pool.FairBlockingQueue/code 
- implementation for the list of the idle connections. The default 
value is codefalse/code.
+ implementation for the list of the idle connections. The default 
value is codetrue/code.
  This flag is required when you want to use asynchronous connection 
retrieval.br/
- During performance tests, the fairQueue does very well on a multi 
core Solaris system,
- but performs terribly on a Linux Fedora 11 system. On Linux we 
recommend setting this to false. 
+ Setting this flag ensures that threads receive connections in the 
order they arrive.br/
+ During performance tests, there is a very large difference in how 
locks
+ and lock waiting is implemented. When codefairQueue=true/code
+ there is a decision making process based on what operating system the 
system is running.
+ If the system is running on Linux (property 
codeos.name=Linux/code.
+ To disable this Linux specific behavior and still use the fair queue, 
simply add the property
+ 
codeorg.apache.tomcat.jdbc.pool.FairBlockingQueue.ignoreOS=true/code to 
your system properties
+ before the connection pool classes are loaded.
   /p
 /attribute
 

Modified: 
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=797528r1=797527r2=797528view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Fri Jul 24 15:24:52 2009
@@ -148,6 +148,9 @@
 if (idle instanceof FairBlockingQueue) {
 FuturePooledConnection pcf = 
((FairBlockingQueuePooledConnection)idle).pollAsync();
 return new ConnectionFuture(pcf);
+} else if (idle instanceof MultiLockFairBlockingQueue) {
+FuturePooledConnection pcf = 
((MultiLockFairBlockingQueuePooledConnection)idle).pollAsync();
+return new ConnectionFuture(pcf);
 } else {
 throw new SQLException(Connection pool is misconfigured, doesn't 
support async retrieval. Set the 'fair' property to 'true');
 }
@@ -306,21 +309,6 @@
 }
 
 /**
- * If the connection pool gets garbage collected, lets make sure we clean 
up
- * and close all the connections.
- * {...@inheritdoc}
- */
-@Override
-protected void finalize() throws Throwable {
-//Runnable closer = new Runnable() {
-//public void run() {
-//close(true);
-//}
-//};
-//this.cancellator.execute(closer);
-}
-
-/**
  * Closes the pool and all disconnects all idle connections
  * Active connections will be closed upon the {...@link 
java.sql.Connection#close close} method is called
  * on the underlying connection instead of being returned to the pool
@@ -381,6 +369,7 @@
 //make space for 10 extra in case we flow over a bit
 if (properties.isFairQueue()) {
 idle = new FairBlockingQueuePooledConnection();
+//idle = new MultiLockFairBlockingQueuePooledConnection();
 } else {
 idle = new 
ArrayBlockingQueuePooledConnection(properties.getMaxActive(),properties.isFairQueue());
 }

Modified: 

svn commit: r797529 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java BorrowWaitTest.java DefaultTestCase.java TestConcurrency.java

2009-07-24 Thread fhanik
Author: fhanik
Date: Fri Jul 24 15:25:17 2009
New Revision: 797529

URL: http://svn.apache.org/viewvc?rev=797529view=rev
Log:
update test cases

Modified:

tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java

tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java

tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java

tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java

Modified: 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java?rev=797529r1=797528r2=797529view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
 Fri Jul 24 15:25:17 2009
@@ -38,7 +38,6 @@
 this.datasource.getPoolProperties().setRemoveAbandoned(true);
 this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
 Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
 assertEquals(Number of connections active/busy should be 
1,1,datasource.getPool().getActive());
 Thread.sleep(2000);
 assertEquals(Number of connections active/busy should be 
0,0,datasource.getPool().getActive());
@@ -56,7 +55,6 @@
 this.datasource.getPoolProperties().setRemoveAbandoned(true);
 this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
 Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
 assertEquals(Number of connections active/busy should be 
1,1,datasource.getPool().getActive());
 Thread.sleep(2000);
 assertEquals(Number of connections active/busy should be 
1,1,datasource.getPool().getActive());
@@ -75,7 +73,6 @@
 this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
 
this.datasource.getPoolProperties().setJdbcInterceptors(ResetAbandonedTimer.class.getName());
 Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
 assertEquals(Number of connections active/busy should be 
1,1,datasource.getPool().getActive());
 for (int i=0; i20; i++) {
 Thread.sleep(200);
@@ -97,7 +94,6 @@
 this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
 Connection[] con = new Connection[size];
 con[0] = datasource.getConnection();
-long start = System.currentTimeMillis();
 assertEquals(Number of connections active/busy should be 
1,1,datasource.getPool().getActive());
 for (int i=1; i25; i++) {
 con[i] = datasource.getConnection();

Modified: 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java?rev=797529r1=797528r2=797529view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
 Fri Jul 24 15:25:17 2009
@@ -32,10 +32,10 @@
 this.datasource.setMaxActive(1);
 this.datasource.setMaxWait(wait);
 Connection con = datasource.getConnection();
-long start = System.currentTimeMillis();
 try {
 Connection con2 = datasource.getConnection();
 assertFalse(This should not happen, connection should be 
unavailable.,true);
+con2.close();
 }catch (SQLException x) {
 long delta = System.currentTimeMillis();
 boolean inrange = Math.abs(wait-delta)  1000;

Modified: 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java?rev=797529r1=797528r2=797529view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
 Fri Jul 24 15:25:17 2009
@@ -52,6 +52,7 @@
 public org.apache.tomcat.jdbc.pool.DataSource createDefaultDataSource() {
 org.apache.tomcat.jdbc.pool.DataSource datasource = null;
 PoolConfiguration p = new DefaultProperties();
+p.setFairQueue(false);
 p.setJmxEnabled(false);
 p.setTestWhileIdle(false);
 

Re: svn commit: r797529 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java BorrowWaitTest.java DefaultTestCase.java TestConcurrency.java

2009-07-24 Thread sebb
On 24/07/2009, fha...@apache.org fha...@apache.org wrote:
 Author: fhanik
  Date: Fri Jul 24 15:25:17 2009
  New Revision: 797529

  URL: http://svn.apache.org/viewvc?rev=797529view=rev
  Log:
  update test cases

  Modified:
 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java

  Modified: 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
  URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java?rev=797529r1=797528r2=797529view=diff
  
 ==
  --- 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
  (original)
  +++ 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
  Fri Jul 24 15:25:17 2009
  @@ -38,7 +38,6 @@
  this.datasource.getPoolProperties().setRemoveAbandoned(true);
  this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
  Connection con = datasource.getConnection();
  -long start = System.currentTimeMillis();
  assertEquals(Number of connections active/busy should be 
 1,1,datasource.getPool().getActive());
  Thread.sleep(2000);
  assertEquals(Number of connections active/busy should be 
 0,0,datasource.getPool().getActive());
  @@ -56,7 +55,6 @@
  this.datasource.getPoolProperties().setRemoveAbandoned(true);
  this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
  Connection con = datasource.getConnection();
  -long start = System.currentTimeMillis();
  assertEquals(Number of connections active/busy should be 
 1,1,datasource.getPool().getActive());
  Thread.sleep(2000);
  assertEquals(Number of connections active/busy should be 
 1,1,datasource.getPool().getActive());
  @@ -75,7 +73,6 @@
  this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
  
 this.datasource.getPoolProperties().setJdbcInterceptors(ResetAbandonedTimer.class.getName());
  Connection con = datasource.getConnection();
  -long start = System.currentTimeMillis();
  assertEquals(Number of connections active/busy should be 
 1,1,datasource.getPool().getActive());
  for (int i=0; i20; i++) {
  Thread.sleep(200);
  @@ -97,7 +94,6 @@
  this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
  Connection[] con = new Connection[size];
  con[0] = datasource.getConnection();
  -long start = System.currentTimeMillis();
  assertEquals(Number of connections active/busy should be 
 1,1,datasource.getPool().getActive());
  for (int i=1; i25; i++) {
  con[i] = datasource.getConnection();

  Modified: 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
  URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java?rev=797529r1=797528r2=797529view=diff
  
 ==
  --- 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
  (original)
  +++ 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
  Fri Jul 24 15:25:17 2009
  @@ -32,10 +32,10 @@
  this.datasource.setMaxActive(1);
  this.datasource.setMaxWait(wait);
  Connection con = datasource.getConnection();
  -long start = System.currentTimeMillis();
  try {
  Connection con2 = datasource.getConnection();
  assertFalse(This should not happen, connection should be 
 unavailable.,true);
  +con2.close();
  }catch (SQLException x) {
  long delta = System.currentTimeMillis();
  boolean inrange = Math.abs(wait-delta)  1000;

  Modified: 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
  URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java?rev=797529r1=797528r2=797529view=diff
  
 ==
  --- 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
  (original)
  +++ 
 tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultTestCase.java
  Fri Jul 24 15:25:17 2009
  @@ -52,6 +52,7 @@
  public org.apache.tomcat.jdbc.pool.DataSource createDefaultDataSource() {
  

DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996





--- Comment #19 from Jerome Louvel jerome.lou...@noelios.com  2009-07-24 
10:00:31 PST ---
Some Restlet users encountered a very similar issue: their sometimes get
requests with an empty content (the POST/PUT entity is somehow lost).

I was able to reproduce the issue with load testing and chaining GET/PUT calls.
It seemed to me that Tomcat broke some connections, while still allowing the
Servlet request to go through. 

This was tested with Tomcat 5.5.27, Tomcat 6.0.18 and Tomcat 6.0.20. The exact
same WAR deployed in Jetty 6.1 doesn't have any issue.

See history of our issue here:
http://restlet.tigris.org/issues/show_bug.cgi?id=843

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47566] Update to NSIS 2.45

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47566





--- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com  2009-07-24 
10:51:34 PST ---
Thank you for the reminder.

By the way, Ant downloads from downloads.sourceforge.net are currently broken,
because their site does not properly encode URL in Location: header when
providing a redirect.

That is currently being tracked as
https://sourceforge.net/apps/trac/sourceforge/ticket/2628

A temporary workaround would be to use a mirror, instead of the main site.
E.g., to define
base-sf.loc=http://sunet.dl.sourceforge.net
in build.properties

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797596 - /tomcat/trunk/build.properties.default

2009-07-24 Thread kkolinko
Author: kkolinko
Date: Fri Jul 24 18:31:58 2009
New Revision: 797596

URL: http://svn.apache.org/viewvc?rev=797596view=rev
Log:
Update to NSIS 2.45
https://issues.apache.org/bugzilla/show_bug.cgi?id=47566

This version adds support for the upcoming release of Microsoft Windows 7
Release notes: http://sourceforge.net/project/shownotes.php?release_id=688043

Modified:
tomcat/trunk/build.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=797596r1=797595r2=797596view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Fri Jul 24 18:31:58 2009
@@ -78,12 +78,12 @@
 
commons-pool-src.loc=${base-commons.loc}/pool/source/commons-pool-1.5.2-src.tar.gz
 
 # - NSIS, version 2.0 or later -
-nsis.home=${base.path}/nsis-2.44
+nsis.home=${base.path}/nsis-2.45
 nsis.exe=${nsis.home}/makensis.exe
 nsis.installoptions.dll=${nsis.home}/Plugins/InstallOptions.dll
 nsis.nsexec.dll=${nsis.home}/Plugins/nsExec.dll
 nsis.nsisdl.dll=${nsis.home}/Plugins/NSISdl.dll
-nsis.loc=${base-sf.loc}/nsis/nsis-2.44.zip
+nsis.loc=${base-sf.loc}/nsis/nsis-2.45.zip
 
 # - Commons Daemon, version 1.0-Alpha or later -
 commons-daemon.home=${base.path}/commons-daemon-1.0.1



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r797528 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/

2009-07-24 Thread sebb
On 24/07/2009, fha...@apache.org fha...@apache.org wrote:
 Author: fhanik
  Date: Fri Jul 24 15:24:52 2009
  New Revision: 797528

  URL: http://svn.apache.org/viewvc?rev=797528view=rev
  Log:
  Add in Linux special case for performance optimization around locking.
  Set default queue to be the fair one
  Remove unused code


  Modified:
 tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java
 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

  Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
  URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=797528r1=797527r2=797528view=diff
  
 ==
  --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
  +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Jul 24 15:24:52 2009
  @@ -353,10 +353,16 @@
  attribute name=fairQueue required=false
p(boolean) Set to true if you wish that calls to getConnection 
 should be treated
   fairly in a true FIFO fashion. This uses the 
 codeorg.apache.tomcat.jdbc.pool.FairBlockingQueue/code
  - implementation for the list of the idle connections. The default 
 value is codefalse/code.
  + implementation for the list of the idle connections. The default 
 value is codetrue/code.
   This flag is required when you want to use asynchronous connection 
 retrieval.br/
  - During performance tests, the fairQueue does very well on a multi 
 core Solaris system,
  - but performs terribly on a Linux Fedora 11 system. On Linux we 
 recommend setting this to false.
  + Setting this flag ensures that threads receive connections in the 
 order they arrive.br/
  + During performance tests, there is a very large difference in how 
 locks
  + and lock waiting is implemented. When codefairQueue=true/code
  + there is a decision making process based on what operating system 
 the system is running.
  + If the system is running on Linux (property 
 codeos.name=Linux/code.
  + To disable this Linux specific behavior and still use the fair 
 queue, simply add the property
  + 
 codeorg.apache.tomcat.jdbc.pool.FairBlockingQueue.ignoreOS=true/code to 
 your system properties
  + before the connection pool classes are loaded.
/p
  /attribute


  Modified: 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
  URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=797528r1=797527r2=797528view=diff
  
 ==
  --- 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
  (original)
  +++ 
 tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
  Fri Jul 24 15:24:52 2009
  @@ -148,6 +148,9 @@
  if (idle instanceof FairBlockingQueue) {
  FuturePooledConnection pcf = 
 ((FairBlockingQueuePooledConnection)idle).pollAsync();
  return new ConnectionFuture(pcf);
  +} else if (idle instanceof MultiLockFairBlockingQueue) {
  +FuturePooledConnection pcf = 
 ((MultiLockFairBlockingQueuePooledConnection)idle).pollAsync();
  +return new ConnectionFuture(pcf);
  } else {
  throw new SQLException(Connection pool is misconfigured, 
 doesn't support async retrieval. Set the 'fair' property to 'true');
  }
  @@ -306,21 +309,6 @@
  }

  /**
  - * If the connection pool gets garbage collected, lets make sure we 
 clean up
  - * and close all the connections.
  - * {...@inheritdoc}
  - */
  -@Override
  -protected void finalize() throws Throwable {
  -//Runnable closer = new Runnable() {
  -//public void run() {
  -//close(true);
  -//}
  -//};
  -//this.cancellator.execute(closer);
  -}
  -
  -/**
   * Closes the pool and all disconnects all idle connections
   * Active connections will be closed upon the {...@link 
 java.sql.Connection#close close} method is called
   * on the underlying connection instead of being returned to the pool
  @@ -381,6 +369,7 @@
  //make space for 10 extra in case we flow over a bit
  if (properties.isFairQueue()) {
  idle = new FairBlockingQueuePooledConnection();
  +//idle = new 

svn commit: r797604 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-24 Thread kkolinko
Author: kkolinko
Date: Fri Jul 24 19:00:30 2009
New Revision: 797604

URL: http://svn.apache.org/viewvc?rev=797604view=rev
Log:
proposal

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=797604r1=797603r2=797604view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Fri Jul 24 19:00:30 2009
@@ -87,3 +87,12 @@
   http://svn.apache.org/viewvc?view=revrevision=797168
   +1: markt, kkolinko
   -1: 
+
+* https://issues.apache.org/bugzilla/show_bug.cgi?id=47566
+  Update to NSIS 2.45
+  http://svn.apache.org/viewvc?rev=797596view=rev
+  +1: kkolinko
+  -1:
+  kkolinko: Now it also requires the following patch, but I hope that
+  sourceforge.net will fix their error:
+http://svn.apache.org/viewvc?rev=797600view=rev



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797607 - /tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java

2009-07-24 Thread markt
Author: markt
Date: Fri Jul 24 19:06:54 2009
New Revision: 797607

URL: http://svn.apache.org/viewvc?rev=797607view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824
Need to use canonical rather than binary form when writing code

Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java?rev=797607r1=797606r2=797607view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java Fri Jul 24 
19:06:54 2009
@@ -379,7 +379,7 @@
  * Determine whether to use the expected type's textual name or, if 
it's
  * a primitive, the name of its correspondent boxed type.
  */
-String targetType = expectedType.getName();
+String targetType = getCanonicalName(expectedType);
 String primitiveConverterMethod = null;
 if (expectedType.isPrimitive()) {
 if (expectedType.equals(Boolean.TYPE)) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797611 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-07-24 Thread markt
Author: markt
Date: Fri Jul 24 19:10:17 2009
New Revision: 797611

URL: http://svn.apache.org/viewvc?rev=797611view=rev
Log:
Propose fix for 41824

Modified:
tomcat/current/tc5.5.x/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=797611r1=797610r2=797611view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Fri Jul 24 19:10:17 2009
@@ -96,3 +96,9 @@
   kkolinko: Now it also requires the following patch, but I hope that
   sourceforge.net will fix their error:
 http://svn.apache.org/viewvc?rev=797600view=rev
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824
+  Need to use canonical rather than binary form when writing code
+  http://svn.apache.org/viewvc?rev=797607view=rev
+  +1: markt
+  -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=797611r1=797610r2=797611view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jul 24 19:10:17 2009
@@ -182,3 +182,9 @@
   kkolinko: Now it also requires the following patch, but I hope that
   sourceforge.net will fix their error:
 http://svn.apache.org/viewvc?rev=797600view=rev
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824
+  Need to use canonical rather than binary form when writing code
+  http://svn.apache.org/viewvc?rev=797607view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 41824] Unable to use nested type in TLD

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41824





--- Comment #2 from Mark Thomas ma...@apache.org  2009-07-24 12:10:36 PST ---
This has been fixed in trunk and proposed for 5.5.x and 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797616 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default sign.sh

2009-07-24 Thread fhanik
Author: fhanik
Date: Fri Jul 24 19:15:31 2009
New Revision: 797616

URL: http://svn.apache.org/viewvc?rev=797616view=rev
Log:
up the version

Modified:
tomcat/trunk/modules/jdbc-pool/build.properties.default
tomcat/trunk/modules/jdbc-pool/sign.sh

Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.properties.default?rev=797616r1=797615r2=797616view=diff
==
--- tomcat/trunk/modules/jdbc-pool/build.properties.default (original)
+++ tomcat/trunk/modules/jdbc-pool/build.properties.default Fri Jul 24 19:15:31 
2009
@@ -27,7 +27,7 @@
 # - Vesion Control Flags -
 version.major=1
 version.minor=0
-version.build=6
+version.build=7
 version.patch=
 version.suffix=
 

Modified: tomcat/trunk/modules/jdbc-pool/sign.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/sign.sh?rev=797616r1=797615r2=797616view=diff
==
--- tomcat/trunk/modules/jdbc-pool/sign.sh (original)
+++ tomcat/trunk/modules/jdbc-pool/sign.sh Fri Jul 24 19:15:31 2009
@@ -15,7 +15,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-VERSION=v1.0.6
+VERSION=v1.0.7
 for i in $(find output/release/$VERSION -name *.zip -o -name *.tar.gz); do
   echo Signing $i
   echo $1|gpg --passphrase-fd 0 -a -b $i



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996


Filip Hanik fha...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO




--- Comment #20 from Filip Hanik fha...@apache.org  2009-07-24 12:46:34 PST 
---
I ran this through a TCP monitor, and at the time of the request that failed
(ie, it had 0 parameters, here is what it looks like


REQUEST
8
POST /test/action HTTP/1.1
Accept: */*
Accept-Language: en-us
Referer: http://10.0.2.2:8082/test/#send
Content-Type: application/x-www-form-urlencoded; charset=UTF-8
Accept-Encoding: gzip, deflate
User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; WOW64;
Trident/4.0; GTB6; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR
3.5.30729)
Host: 10.0.2.2:8082
Content-Length: 25
Connection: Keep-Alive
Cache-Control: no-cache
Cookie: JSESSIONID=A6DABF8D3A1FEB0A173CCD78D8CD8BE8


8

The request says there should be a 25 byte content length, but there are no
parameters in the request.
Another (succesful request looks like this)




SUCCESSFUL REQUEST
8
POST /test/action HTTP/1.1
Accept: */*
Accept-Language: en-us
Referer: http://10.0.2.2:8082/test/#send
Content-Type: application/x-www-form-urlencoded; charset=UTF-8
Accept-Encoding: gzip, deflate
User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; WOW64;
Trident/4.0; GTB6; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR
3.5.30729)
Host: 10.0.2.2:8082
Content-Length: 25
Connection: Keep-Alive
Cache-Control: no-cache
Cookie: JSESSIONID=A6DABF8D3A1FEB0A173CCD78D8CD8BE8

param1=Loremparam2=ipsum
8

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996





--- Comment #21 from Filip Hanik fha...@apache.org  2009-07-24 12:52:43 PST 
---
Created an attachment (id=24034)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24034)
Output from wireshark, shows no body

Same with an example from Wireshark, there is no body in the request

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 42996] POST with nio connector results in missing variables

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42996





--- Comment #22 from Filip Hanik fha...@apache.org  2009-07-24 12:54:06 PST 
---
(In reply to comment #19)
 Some Restlet users encountered a very similar issue: their sometimes get
 requests with an empty content (the POST/PUT entity is somehow lost).
 
 I was able to reproduce the issue with load testing and chaining GET/PUT 
 calls.
 It seemed to me that Tomcat broke some connections, while still allowing the
 Servlet request to go through. 
 
 This was tested with Tomcat 5.5.27, Tomcat 6.0.18 and Tomcat 6.0.20. The exact
 same WAR deployed in Jetty 6.1 doesn't have any issue.
 
 See history of our issue here:
 http://restlet.tigris.org/issues/show_bug.cgi?id=843

Jerome, do you want to work with me to help setup a test case.
That way I can try to reproduce it. I was able to reproduce the error with the
test case provided, but it clearly shows that the client is not sending any
body.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r797686 - /tomcat/trunk/modules/jdbc-pool/build.xml

2009-07-24 Thread fhanik
Author: fhanik
Date: Fri Jul 24 23:08:32 2009
New Revision: 797686

URL: http://svn.apache.org/viewvc?rev=797686view=rev
Log:
Add missing files to distribution

Modified:
tomcat/trunk/modules/jdbc-pool/build.xml

Modified: tomcat/trunk/modules/jdbc-pool/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=797686r1=797685r2=797686view=diff
==
--- tomcat/trunk/modules/jdbc-pool/build.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/build.xml Fri Jul 24 23:08:32 2009
@@ -250,6 +250,8 @@
 include name=build.xml/
 include name=build.properties.default/
 include name=doc/*.xml/
+   include name=doc/*.xsl/
+   include name=resources/MANIFEST.MF/
 include name=LICENSE/
 include name=NOTICE/
   /fileset
@@ -261,6 +263,8 @@
 include name=build.xml/
 include name=build.properties.default/
 include name=doc/*.xml/
+   include name=doc/*.xsl/
+   include name=resources/MANIFEST.MF/
 include name=LICENSE/
 include name=NOTICE/
   /fileset



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



jdbc-pool 1.0.7 release candidate

2009-07-24 Thread Filip Hanik - Dev Lists

http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/

Same thing here, if all checks out well, plan a vote mid next week

Filip



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: 5.5.28 release candidate

2009-07-24 Thread sebb
On 24/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote:
 http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/

There is no .zip version of apache-tomcat-5.5.28-fulldocs.tar.gz

The source archives contain the file

container/webapps/admin/images/Thumbs.db

which does not belong in the archive.

Also, the file

container/modules/storeconfig-ha/test/conf/catalina.keystore

is different in the .zip and .tar.gz versions of the archives.

Looks like a packaging error - perhaps accidental EOL conversion?

There are no NOTICE or LICENSE files in the top-level of the source archives.

The binary archives contain the files
   bin/jsvc.tar.gz
   bin/tomcat-native.tar.gz
which appears to be source code only.

When the EXE is unpacked, there is no RELEASE-NOTES file in the
top-level directory where one would expect to find it.

The server.xml file in the EXE is different from the one in the bin
file and appears to be an old version.

Likewise, the file tomcat-users.xml looks wrong - it says that there
is no user with the manager role, yet it contains the following entry:

user name=admin password= roles=admin,manager /

  I have not run the TCK on this yet
  Plan on vote mid to late next week

  Filip

 -
  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
  For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: 5.5.28 release candidate

2009-07-24 Thread Filip Hanik - Dev Lists

how much of that is different from 5.5.27?

Filip

On 07/24/2009 05:44 PM, sebb wrote:

On 24/07/2009, Filip Hanik - Dev Listsdevli...@hanik.com  wrote:
   

http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/
 


There is no .zip version of apache-tomcat-5.5.28-fulldocs.tar.gz

The source archives contain the file

container/webapps/admin/images/Thumbs.db

which does not belong in the archive.

Also, the file

container/modules/storeconfig-ha/test/conf/catalina.keystore

is different in the .zip and .tar.gz versions of the archives.

Looks like a packaging error - perhaps accidental EOL conversion?

There are no NOTICE or LICENSE files in the top-level of the source archives.

The binary archives contain the files
bin/jsvc.tar.gz
bin/tomcat-native.tar.gz
which appears to be source code only.

When the EXE is unpacked, there is no RELEASE-NOTES file in the
top-level directory where one would expect to find it.

The server.xml file in the EXE is different from the one in the bin
file and appears to be an old version.

Likewise, the file tomcat-users.xml looks wrong - it says that there
is no user with the manager role, yet it contains the following entry:

user name=admin password= roles=admin,manager /

   

  I have not run the TCK on this yet
  Plan on vote mid to late next week

  Filip

-
  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
  For additional commands, e-mail: dev-h...@tomcat.apache.org


 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


   




DO NOT REPLY [Bug 47576] New: Javadoc errors - Exception name misspelt

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47576

   Summary: Javadoc errors - Exception name misspelt
   Product: Tomcat 7
   Version: trunk
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Modules: jdbc-pool
AssignedTo: dev@tomcat.apache.org
ReportedBy: s...@apache.org


The files

FairBlockingQueue.java
MultiLockFairBlockingQueue.java

use

* @throws UnsupportedOperation

This should be

* @throws UnsupportedOperationException

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47577] New: Unused imports and other compilation warnings

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47577

   Summary: Unused imports and other compilation warnings
   Product: Tomcat 7
   Version: trunk
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: minor
  Priority: P2
 Component: Modules: jdbc-pool
AssignedTo: dev@tomcat.apache.org
ReportedBy: s...@apache.org


Created an attachment (id=24035)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24035)
List of Eclipse compiler warnings

Several files have unused imports, use raw types or have other minor problems.

See attached file for details.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47576] Javadoc errors - Exception name misspelt

2009-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47576





--- Comment #1 from Sebb s...@apache.org  2009-07-24 17:40:06 PST ---
Created an attachment (id=24036)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24036)
Patch to fix Exception names

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org