DO NOT REPLY [Bug 50738] Manager.initInternal not invoked on context reload

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738 --- Comment #2 from Martin Grotzke martin.grot...@googlemail.com 2011-02-09 02:59:46 EST --- For tomcat6 init was called on context reload (actually it's done in StandardContext.start: if (!initialized) init();). If it's intended that

DO NOT REPLY [Bug 39740] semi-colon ; isn't allowed as a query argument separator

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=39740 --- Comment #11 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 03:07:24 EST --- (In reply to comment #10) until the W3C finally declares ';' as the correct syntax, and not some obtuse footnote that contradicts their spec. I

DO NOT REPLY [Bug 50738] Manager.initInternal not invoked on context reload

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 03:10:55 EST --- how do I know that I need to invoke initInternal by myself Why do you need to invoke it? -- Configure bugmail:

svn commit: r1068787 - in /tomcat/site/trunk: docs/security-5.html docs/security-6.html docs/security-7.html xdocs/security-5.xml xdocs/security-6.xml xdocs/security-7.xml

2011-02-09 Thread jfclere
Author: jfclere Date: Wed Feb 9 08:25:51 2011 New Revision: 1068787 URL: http://svn.apache.org/viewvc?rev=1068787view=rev Log: See http://www.oracle.com/technetwork/topics/security/alert-cve-2010-4476-305811.html Modified: tomcat/site/trunk/docs/security-5.html

DO NOT REPLY [Bug 50738] Manager.initInternal not invoked on context reload

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738 --- Comment #4 from Martin Grotzke martin.grot...@googlemail.com 2011-02-09 03:40:13 EST --- As I'm doing my initialization in initInternal:

Duplicate events in Lifecycle?

2011-02-09 Thread Konstantin Kolinko
1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see the following two lines: fireLifecycleEvent(STOP_EVENT, null); setState(LifecycleState.STOPPING); Unless I miss something it means that STOP_EVENT is fired twice, once by the fireLifecycleEvent() call and second

DO NOT REPLY [Bug 50738] Manager.initInternal not invoked on context reload

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738 --- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 04:21:13 EST --- (In reply to comment #4) That was working fine for tomcat6. Should initialization be moved to startInternal? Another solution could be to move

svn commit: r1068808 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

2011-02-09 Thread kkolinko
Author: kkolinko Date: Wed Feb 9 09:35:16 2011 New Revision: 1068808 URL: http://svn.apache.org/viewvc?rev=1068808view=rev Log: Followup to r1068549 - add annotations. I thought about moving ErrorHandler instance creation outside the retry loop, but actually that is not needed: looping happens

DO NOT REPLY [Bug 50738] Manager.initInternal not invoked on context reload

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738 --- Comment #6 from Martin Grotzke martin.grot...@googlemail.com 2011-02-09 04:40:28 EST --- I just overwrote destroyInternal and debugged/logged, but it seems to be not called for me, neither on context reload nor during stop (CTRL-C).

DO NOT REPLY [Bug 50734] 400 Bad Request when there are no web applications deployed on Tomcat 6.0.32

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50734 --- Comment #2 from violet...@apache.org 2011-02-09 04:42:50 EST --- Created an attachment (id=26626) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26626) 400 Bad Request issue - patch proposal Hi, Patch is made based on Tomcat

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #12 from Olivier Costet ocos...@zenprise.com 2011-02-09 04:59:37 EST --- Hi Filip, I would have thought the second callback could be implemented in the same class is the (Extended)RpcCallback, but at any rate it's your call. I

DO NOT REPLY [Bug 50743] New: Cache results to speed up Checkstyle #build

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50743 Summary: Cache results to speed up Checkstyle #build Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: enhancement

Re: Duplicate events in Lifecycle?

2011-02-09 Thread Mark Thomas
On 09/02/2011 09:14, Konstantin Kolinko wrote: 1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see the following two lines: fireLifecycleEvent(STOP_EVENT, null); setState(LifecycleState.STOPPING); Unless I miss something it means that STOP_EVENT is fired

Re: Duplicate events in Lifecycle?

2011-02-09 Thread Konstantin Kolinko
2011/2/9 Mark Thomas ma...@apache.org: On 09/02/2011 09:14, Konstantin Kolinko wrote: 1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see the following two lines:         fireLifecycleEvent(STOP_EVENT, null);         setState(LifecycleState.STOPPING); Unless I miss

svn commit: r1068862 - /tomcat/trunk/java/org/apache/catalina/startup/Embedded.java

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 12:26:24 2011 New Revision: 1068862 URL: http://svn.apache.org/viewvc?rev=1068862view=rev Log: Prevent duplicate event messages Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java Modified:

Re: [VOTE] Release Tomcat 5.5.33 Build

2011-02-09 Thread Jim Jagielski
+1 On Feb 8, 2011, at 8:22 AM, Jim Jagielski wrote: Retagged, rerolled and reuploaded... ;) On Feb 8, 2011, at 8:04 AM, Jim Jagielski wrote: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

DO NOT REPLY [Bug 50744] New: When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work.

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 Summary: When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work. Product: Tomcat 5 Version: 5.5.32 Platform: Other OS/Version: AIX

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 Sridhar Murthy murt...@us.ibm.com changed: What|Removed |Added Summary|When Tomcat was updated |When Tomcat was

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #1 from Sridhar Murthy murt...@us.ibm.com 2011-02-09 10:23:33 EST --- The download source for Tomcat 5.5.32 is: http://archive.apache.org/dist/tomcat/tomcat-5/v5.5.32/bin/ The files that were downloaded are: _1_)

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 Sridhar Murthy murt...@us.ibm.com changed: What|Removed |Added CC|

svn commit: r1068989 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

2011-02-09 Thread fhanik
Author: fhanik Date: Wed Feb 9 17:39:24 2011 New Revision: 1068989 URL: http://svn.apache.org/viewvc?rev=1068989view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 Move the callback outside try/catch to avoid duplicate callbacks Modified:

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #13 from Filip Hanik fha...@apache.org 2011-02-09 12:40:16 EST --- (In reply to comment #12) Hi Filip, I would have thought the second callback could be implemented in the same class is the (Extended)RpcCallback, but at

svn commit: r1068996 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

2011-02-09 Thread fhanik
Author: fhanik Date: Wed Feb 9 17:47:13 2011 New Revision: 1068996 URL: http://svn.apache.org/viewvc?rev=1068996view=rev Log: remove loop that should not be used at all. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Modified:

Re: svn commit: r1068808 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

2011-02-09 Thread Filip Hanik - Dev Lists
I'm glad you commented, there should be no looping at all. It was a left over from a previous proposal fixed in r1068996 Filip On 2/9/2011 2:35 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Wed Feb 9 09:35:16 2011 New Revision: 1068808 URL:

svn commit: r1069016 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 18:25:48 2011 New Revision: 1069016 URL: http://svn.apache.org/viewvc?rev=1069016view=rev Log: Better comments Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java URL:

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 13:26:54 EST --- (In reply to comment #0) Catalina logs have some errors and I have attached the log to this BUG report). There is no attachment. Without seeing

Re: Duplicate events in Lifecycle?

2011-02-09 Thread Mark Thomas
On 09/02/2011 11:32, Konstantin Kolinko wrote: 2011/2/9 Mark Thomas ma...@apache.org: On 09/02/2011 09:14, Konstantin Kolinko wrote: 1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see the following two lines: fireLifecycleEvent(STOP_EVENT, null);

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Status|NEW

svn commit: r1069032 - /tomcat/trunk/java/org/apache/catalina/Lifecycle.java

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 19:01:20 2011 New Revision: 1069032 URL: http://svn.apache.org/viewvc?rev=1069032view=rev Log: add some arrows to the diagram Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java URL:

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #4 from Sridhar Murthy murt...@us.ibm.com 2011-02-09 14:02:44 EST --- Created an attachment (id=26628) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26628) Catalina Log -- Configure bugmail:

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 Sridhar Murthy murt...@us.ibm.com changed: What|Removed |Added Status|RESOLVED|REOPENED

DO NOT REPLY [Bug 50747] New: CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 Summary: CometProcessor does not flush and close HTTP/1.0 requests Product: Tomcat 7 Version: 7.0.8 Platform: PC Status: NEW Severity: normal

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 14:23:42 EST --- From the log: Feb 8, 2011 8:40:32 PM org.apache.coyote.http11.Http11BaseProtocol init INFO: Initializing Coyote HTTP/1.1 on http-8080 Feb 8, 2011

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #7 from Sridhar Murthy murt...@us.ibm.com 2011-02-09 14:26:44 EST --- Created an attachment (id=26629) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26629) This server.xml works correctly for both SSL and non-SSL

svn commit: r1069056 - in /tomcat/trunk: java/org/apache/catalina/connector/MapperListener.java java/org/apache/catalina/util/LifecycleBase.java webapps/docs/changelog.xml

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 19:46:49 2011 New Revision: 1069056 URL: http://svn.apache.org/viewvc?rev=1069056view=rev Log: Add further checks that LifecycleBase sub-classes are correctly changing state. Modified: tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java

svn commit: r1069060 - /tomcat/trunk/webapps/docs/changelog.xml

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 19:50:37 2011 New Revision: 1069060 URL: http://svn.apache.org/viewvc?rev=1069060view=rev Log: Correct the package name Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 Frank Schroeder frank.schroe...@gmail.com changed: What|Removed |Added OS/Version||All

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 15:39:00 EST --- String data = ...; response.setCharacterEncoding(UTF-8); response.setContentLength(data.length()); PrintWriter writer = response.getWriter();

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 --- Comment #3 from Mark Thomas ma...@apache.org 2011-02-09 15:48:04 EST --- Tomcat could be a little smarter here. We currently ignore a call to setContentLength() after a call to getWriter(). However, we only have to ignore the content

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 --- Comment #4 from Frank Schroeder frank.schroe...@gmail.com 2011-02-09 15:55:29 EST --- Sure, I can try that. While you're at it you can also check the encoding as it wasn't set as well. The content type was OK. The reason I had this

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 --- Comment #5 from Mark Thomas ma...@apache.org 2011-02-09 16:16:04 EST --- You can't change the encoding once the writer has been obtained since the encoding is used to create the writer. -- Configure bugmail:

DO NOT REPLY [Bug 50748] New: Ignoring setContentLength( ) when using writer is incomplete

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50748 Summary: Ignoring setContentLength( ) when using writer is incomplete Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 16:54:08 EST --- (In reply to comment #3) Tomcat could be a little smarter here. For reference: I filed bug 50748 to deal with setContentLength() improvements.

svn commit: r1069131 - in /tomcat/trunk: java/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 21:56:14 2011 New Revision: 1069131 URL: http://svn.apache.org/viewvc?rev=1069131view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 Allow the content length header to be set up to the point the response is committed when a writer is used.

svn commit: r1069135 - /tomcat/trunk/webapps/docs/changelog.xml

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 22:00:08 2011 New Revision: 1069135 URL: http://svn.apache.org/viewvc?rev=1069135view=rev Log: The bug number changed Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

DO NOT REPLY [Bug 50747] CometProcessor does not flush and close HTTP/1.0 requests

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 50748] Ignoring setContentLength( ) when using writer is incomplete

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50748 Mark Thomas ma...@apache.org changed: What|Removed |Added CC|

DO NOT REPLY [Bug 50748] Ignoring setContentLength( ) when using writer is incomplete

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50748 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1069166 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 23:13:00 2011 New Revision: 1069166 URL: http://svn.apache.org/viewvc?rev=1069166view=rev Log: Ensure NamingResources follows correct lifecycle Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified:

svn commit: r1069170 - in /tomcat/trunk: java/org/apache/catalina/util/RequestUtil.java test/org/apache/catalina/util/TestRequestUtil.java webapps/docs/changelog.xml

2011-02-09 Thread markt
Author: markt Date: Wed Feb 9 23:41:32 2011 New Revision: 1069170 URL: http://svn.apache.org/viewvc?rev=1069170view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50721 Correctly handle URL decoding where the URL ends in %nn. Patch (for fix) provided by Christof Marti.

DO NOT REPLY [Bug 50721] RequestUtil.URLDecode() throws IllegalArgumentException for URLs with %xx-Code as last character

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50721 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 48717] Session listeners not called on cluster node start

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48717 David Rees dree...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #8 from Sridhar Murthy murt...@us.ibm.com 2011-02-09 20:54:40 EST --- Hi Konstantin: If all the configuartions required for the Tomcat to start services on both SSL port ( 8443) and non-SSL port (8080) are put in place in

DO NOT REPLY [Bug 50744] When Tomcat was updated from version 5.5.27 to 5.5.32, SSL support for Tomcat does not work on AIX 5.3 TL-11 SP-2

2011-02-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744 --- Comment #9 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-09 21:30:57 EST --- Created an attachment (id=26630) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26630) 2011-02-11_tc55_50744_JSSESocketFactory.patch (In