[jira] [Updated] (MTOMCAT-87) Make http protocol configurable for the embedded Tomcat

2011-09-12 Thread Adrien C (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien C updated MTOMCAT-87:


Attachment: (was: http-protocol.patch)

 Make http protocol configurable for the embedded Tomcat
 ---

 Key: MTOMCAT-87
 URL: https://issues.apache.org/jira/browse/MTOMCAT-87
 Project: Maven 2.x Tomcat Plugin
  Issue Type: New Feature
Reporter: Adrien C
 Attachments: http-protocol.patch


 tomcat maven plugin 1.1 sets HTTP connector with default HTTP/1.1 protocol. 
 Being able to set another protocol (ex: 
 org.apache.coyote.http11.Http11NioProtocol) would be useful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Updated] (MTOMCAT-87) Make http protocol configurable for the embedded Tomcat

2011-09-12 Thread Adrien C (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien C updated MTOMCAT-87:


Attachment: http-protocol.patch

Patch with granted ASF license.

 Make http protocol configurable for the embedded Tomcat
 ---

 Key: MTOMCAT-87
 URL: https://issues.apache.org/jira/browse/MTOMCAT-87
 Project: Maven 2.x Tomcat Plugin
  Issue Type: New Feature
Reporter: Adrien C
 Attachments: http-protocol.patch


 tomcat maven plugin 1.1 sets HTTP connector with default HTTP/1.1 protocol. 
 Being able to set another protocol (ex: 
 org.apache.coyote.http11.Http11NioProtocol) would be useful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Assigned] (MTOMCAT-87) Make http protocol configurable for the embedded Tomcat

2011-09-12 Thread Olivier Lamy (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy reassigned MTOMCAT-87:
---

Assignee: Olivier Lamy

 Make http protocol configurable for the embedded Tomcat
 ---

 Key: MTOMCAT-87
 URL: https://issues.apache.org/jira/browse/MTOMCAT-87
 Project: Maven 2.x Tomcat Plugin
  Issue Type: New Feature
Reporter: Adrien C
Assignee: Olivier Lamy
 Fix For: 2.0

 Attachments: http-protocol.patch


 tomcat maven plugin 1.1 sets HTTP connector with default HTTP/1.1 protocol. 
 Being able to set another protocol (ex: 
 org.apache.coyote.http11.Http11NioProtocol) would be useful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Updated] (MTOMCAT-87) Make http protocol configurable for the embedded Tomcat

2011-09-12 Thread Olivier Lamy (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy updated MTOMCAT-87:


Fix Version/s: 2.0

 Make http protocol configurable for the embedded Tomcat
 ---

 Key: MTOMCAT-87
 URL: https://issues.apache.org/jira/browse/MTOMCAT-87
 Project: Maven 2.x Tomcat Plugin
  Issue Type: New Feature
Reporter: Adrien C
Assignee: Olivier Lamy
 Fix For: 2.0

 Attachments: http-protocol.patch


 tomcat maven plugin 1.1 sets HTTP connector with default HTTP/1.1 protocol. 
 Being able to set another protocol (ex: 
 org.apache.coyote.http11.Http11NioProtocol) would be useful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1169647 - /tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java

2011-09-12 Thread olamy
Author: olamy
Date: Mon Sep 12 08:33:41 2011
New Revision: 1169647

URL: http://svn.apache.org/viewvc?rev=1169647view=rev
Log:
[MTOMCAT-87] Make http protocol configurable for the embedded Tomcat
Submitted by Adrien C

Modified:

tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java

Modified: 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
URL: 
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java?rev=1169647r1=1169646r2=1169647view=diff
==
--- 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
 (original)
+++ 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
 Mon Sep 12 08:33:41 2011
@@ -20,19 +20,6 @@ package org.apache.tomcat.maven.plugin;
  */
 
 
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.IOException;
-import java.net.InetAddress;
-import java.net.MalformedURLException;
-import java.net.URL;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-
 import org.apache.catalina.Context;
 import org.apache.catalina.Engine;
 import org.apache.catalina.Host;
@@ -56,7 +43,6 @@ import org.codehaus.plexus.classworlds.r
 import org.codehaus.plexus.classworlds.realm.DuplicateRealmException;
 import org.codehaus.plexus.util.DirectoryScanner;
 import org.codehaus.plexus.util.FileUtils;
-
 import org.w3c.dom.Document;
 import org.w3c.dom.NamedNodeMap;
 import org.w3c.dom.Node;
@@ -65,10 +51,22 @@ import org.xml.sax.SAXException;
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.InetAddress;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
 
 /**
  * Abstract goal that provides common configuration for embedded Tomcat goals.
- * 
+ *
  * @author Jurgen Lust
  * @author Mark Hobson markhob...@gmail.com
  * @version $Id: AbstractRunMojo.java 14033 2011-05-04 17:51:15Z bimargulies $
@@ -82,7 +80,7 @@ public abstract class AbstractRunMojo
 
 /**
  * The packaging of the Maven project that this goal operates upon.
- * 
+ *
  * @parameter expression = ${project.packaging}
  * @required
  * @readonly
@@ -91,55 +89,59 @@ public abstract class AbstractRunMojo
 
 /**
  * The directory to create the Tomcat server configuration under.
- * 
+ *
  * @parameter expression=${project.build.directory}/tomcat
  */
 private File configurationDir;
 
 /**
  * The port to run the Tomcat server on.
- * 
+ *
  * @parameter expression=${maven.tomcat.port} default-value=8080
  */
 private int port;
-
+
 /**
  * The AJP port to run the Tomcat server on.
- * By default it's 0 this means won't be started. 
- * The ajp connector will be started only for value  0. 
- * @since 1.2
+ * By default it's 0 this means won't be started.
+ * The ajp connector will be started only for value  0.
+ *
  * @parameter expression=${maven.tomcat.ajp.port} default-value=0
+ * @since 1.2
  */
 private int ajpPort;
-
+
 /**
  * The AJP protocol to run the Tomcat server on.
- * By default it's ajp. 
- * NOTE The ajp connector will be started only if {@link #ajpPort}  0. 
- * @since 1.2
+ * By default it's ajp.
+ * NOTE The ajp connector will be started only if {@link #ajpPort}  0.
+ *
  * @parameter expression=${maven.tomcat.ajp.protocol} default-value=ajp
- */
+ * @since 1.2
+ */
 private String ajpProtocol;
-
+
 /**
  * The https port to run the Tomcat server on.
- * By default it's 0 this means won't be started. 
- * The https connector will be started only for value  0. 
- * @since 1.0
+ * By default it's 0 this means won't be started.
+ * The https connector will be started only for value  0.
+ *
  * @parameter expression=${maven.tomcat.httpsPort} default-value=0
+ * @since 1.0
  */
 private int httpsPort;
 
 /**
  * The character encoding to use for decoding URIs.
- * @since 1.0
+ *
  * @parameter expression=${maven.tomcat.uriEncoding} 
default-value=ISO-8859-1
+ * @since 1.0
  */
 private String uriEncoding;
 
 /**
  * List of System properties to pass to the Tomcat 

svn commit: r1169648 - in /tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin: AbstractRunMojo.java ExternalRepositoriesReloadableWebappLoader.java

2011-09-12 Thread olamy
Author: olamy
Date: Mon Sep 12 08:34:05 2011
New Revision: 1169648

URL: http://svn.apache.org/viewvc?rev=1169648view=rev
Log:
change @since 1.2 to @since 2.0 : as with the relocation to ASF version has 
been bumped to 2.0

Modified:

tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java

tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/ExternalRepositoriesReloadableWebappLoader.java

Modified: 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
URL: 
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java?rev=1169648r1=1169647r2=1169648view=diff
==
--- 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
 (original)
+++ 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java
 Mon Sep 12 08:34:05 2011
@@ -107,7 +107,7 @@ public abstract class AbstractRunMojo
  * The ajp connector will be started only for value  0.
  *
  * @parameter expression=${maven.tomcat.ajp.port} default-value=0
- * @since 1.2
+ * @since 2.0
  */
 private int ajpPort;
 
@@ -117,7 +117,7 @@ public abstract class AbstractRunMojo
  * NOTE The ajp connector will be started only if {@link #ajpPort}  0.
  *
  * @parameter expression=${maven.tomcat.ajp.protocol} default-value=ajp
- * @since 1.2
+ * @since 2.0
  */
 private String ajpProtocol;
 
@@ -271,7 +271,7 @@ public abstract class AbstractRunMojo
  * @todo adopt documentation once Tomcat 7 is supported (MTOMCAT-62)
  * @see a 
href=http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/catalina/startup/Embedded.html;org.apache.catalina.startup.Embedded/a
  * @see a 
href=http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html;org.apache.catalina.startup.Tomcat/a
- * @since 1.2
+ * @since 2.0
  */
 private boolean useNaming;
 
@@ -281,7 +281,7 @@ public abstract class AbstractRunMojo
  * in your context file.
  *
  * @parameter expression=${maven.tomcat.contextReloadable} 
default-value=false
- * @since 1.2
+ * @since 2.0
  */
 protected boolean contextReloadable;
 
@@ -298,7 +298,7 @@ public abstract class AbstractRunMojo
  * By default it's HTTP/1.1.
  *
  * @parameter expression=${maven.tomcat.protocol} 
default-value=HTTP/1.1
- * @since 1.2
+ * @since 2.0
  */
 private String protocol;
 

Modified: 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/ExternalRepositoriesReloadableWebappLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/ExternalRepositoriesReloadableWebappLoader.java?rev=1169648r1=1169647r2=1169648view=diff
==
--- 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/ExternalRepositoriesReloadableWebappLoader.java
 (original)
+++ 
tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/ExternalRepositoriesReloadableWebappLoader.java
 Mon Sep 12 08:34:05 2011
@@ -34,7 +34,7 @@ import java.util.Map;
  * context reloads.
  *
  * @author Ryan Connolly
- * @since 1.2
+ * @since 2.0
  * @version $Id: ExternalRepositoriesReloadableWebappLoader.java 13551 
2011-02-09 16:05:47Z olamy $
  */
 public class ExternalRepositoriesReloadableWebappLoader



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Closed] (MTOMCAT-87) Make http protocol configurable for the embedded Tomcat

2011-09-12 Thread Olivier Lamy (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy closed MTOMCAT-87.
---

Resolution: Fixed

fixed rev 1169647.
Thanks for the patch !

 Make http protocol configurable for the embedded Tomcat
 ---

 Key: MTOMCAT-87
 URL: https://issues.apache.org/jira/browse/MTOMCAT-87
 Project: Maven 2.x Tomcat Plugin
  Issue Type: New Feature
Reporter: Adrien C
Assignee: Olivier Lamy
 Fix For: 2.0

 Attachments: http-protocol.patch


 tomcat maven plugin 1.1 sets HTTP connector with default HTTP/1.1 protocol. 
 Being able to set another protocol (ex: 
 org.apache.coyote.http11.Http11NioProtocol) would be useful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Created] (MTOMCAT-97) rename current tomcat maven plugin to tomcat6 and add tomcat7

2011-09-12 Thread Olivier Lamy (JIRA)
rename current tomcat maven plugin to tomcat6 and add tomcat7 
--

 Key: MTOMCAT-97
 URL: https://issues.apache.org/jira/browse/MTOMCAT-97
 Project: Maven 2.x Tomcat Plugin
  Issue Type: Task
Reporter: Olivier Lamy
Assignee: Olivier Lamy


To prevent confusion for users, I'd like to rename the current version which 
supports tomcat 6 to tomcat6 and add tomcat 7 support in tomcat7.
users will have now to use tomcat6:run instead tomcat:run.
Btw users will have to add a pluginGroup entry in ~/.m2/settings.xml as the 
used groupId is not automatically discovered by maven core.
Any objections ?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-87) Make http protocol configurable for the embedded Tomcat

2011-09-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102507#comment-13102507
 ] 

Hudson commented on MTOMCAT-87:
---

Integrated in TomcatMavenPlugin #8 (See 
[https://builds.apache.org/job/TomcatMavenPlugin/8/])
[MTOMCAT-87] Make http protocol configurable for the embedded Tomcat
Submitted by Adrien C

olamy : http://svn.apache.org/viewvc/?view=revrev=1169647
Files : 
* 
/tomcat/maven-plugin/trunk/tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/AbstractRunMojo.java


 Make http protocol configurable for the embedded Tomcat
 ---

 Key: MTOMCAT-87
 URL: https://issues.apache.org/jira/browse/MTOMCAT-87
 Project: Maven 2.x Tomcat Plugin
  Issue Type: New Feature
Reporter: Adrien C
Assignee: Olivier Lamy
 Fix For: 2.0

 Attachments: http-protocol.patch


 tomcat maven plugin 1.1 sets HTTP connector with default HTTP/1.1 protocol. 
 Being able to set another protocol (ex: 
 org.apache.coyote.http11.Http11NioProtocol) would be useful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1169674 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread kkolinko
Author: kkolinko
Date: Mon Sep 12 10:10:54 2011
New Revision: 1169674

URL: http://svn.apache.org/viewvc?rev=1169674view=rev
Log:
Followup to r1169453
Remove svn:mergeinfo on DefaultInstanceManager.java
Record r1169447 as merged on /tc7.0.x/trunk
Only svn:mergeinfo properties are changed.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java  
 (props changed)

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 12 10:10:54 2011
@@ -1 +1 @@
-/tomcat/trunk:1156171,1156276,1156304,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394
+/tomcat/trunk:1156171,1156276,1156304,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447

Propchange: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
('svn:mergeinfo' removed)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-12 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -ERROR- No such project [tomcat-7.0.x] for property.
 -ERROR- Cannot resolve relative  to *unknown* [tomcat-7.0.x] for checkstyle.jar
 -ERROR- Unhandled Property: checkstyle.jar on: Ant on 
Project:tomcat-tc7.0.x-test
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 29 mins 20 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-12092011.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-12092011-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-12092011-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-12092011.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/worksp
 ace/commons-dbcp-1.x -Dcheckstyle.jar=*Unset* 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-12092011.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp
 

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-12 Thread Konstantin Kolinko
2011/9/12 Bill Barker billwbar...@verizon.net:
 What is happening is that checkstyle stopped building in Gump about 3 weeks
 ago, so tomcat-trunk and tomcat-7.0.x wouldn't build in Gump since the
 checkstyle jar was missing. Since the build and test targets for these
 projects only look to see if the file is there (to decide if it needs to
 download it),
 I changed Gump to look for a file that is always there (but
 isn't related to checkstyle).  So this message is the result of 3 weeks of
 Gump not running tests.  Until checkstyle fixes their build, the Tomcat
 checkstyle projects still won't run in Gump.

As far as I remember tc7.0.x/trunk build files,  it will look for
checkstyle.jar only if validation was requested.

Thus that property setting is actually non needed in all projects
there, except  tomcat-*-validate one.

(I won't bother with it though until we have a successful run of the tests).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1169674 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread Rainer Jung
Which commands should we typically use to merge from trunk to tc7?
How would we cherry-pick the changes we want to merge?

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-09-12 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -DEBUG- Dependency on tomcat-trunk exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 29 mins 9 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-12092011.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-12092011-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-12092011-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-12092011.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar
 -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/worksp
 ace/commons-dbcp-1.x 
-Dcheckstyle.jar=/srv/gump/public/workspace/tomcat-trunk/BUILDING.txt 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-12092011.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-tr
 

Re: svn commit: r1169674 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread Konstantin Kolinko
2011/9/12 Rainer Jung rainer.j...@kippdata.de:
 Which commands should we typically use to merge from trunk to tc7?
 How would we cherry-pick the changes we want to merge?


The rule is that merge command should be invoked from root of the
project (the /tc7.0.x/trunk directory here),  so that mergeinfo
property is updated only there.

Regarding cherry-picking:
svn:mergeinfo only means that the revision mentioned in mergeinfo will
be skipped when you will do a re-merge with a range of revisions that
includes the one.

If you mean cherry-picking as selecting some files among those
committed in some revision:

- If omitted files do not make sense on tc7 (e.g. an update to
changelog.xml), you would just revert the changes on them before
committing to TC7/TC6, but will mark the whole revision as merged.

- If omitted files do make sense (e.g. original change included both
http and ajp connectors, and you are merging changes to http
connector, but are skipping ajp ones leaving them for a later commit)
then you mark only that subtree as merged (invoke merge not from
root).

If you mean cherry-picking as selecting some revisions from a range,
you would specify revision numbers during merge operation. Thus far
the practice was that you specifically specify what single revisions
you are merging, and thus those single revisions are added to the
svn:mergeinfo on project root.  I do not mind using ranges instead of
single revisions.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1169674 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread Rainer Jung
Thanks Konstantin!

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1166290 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread Konstantin Kolinko
2011/9/7 Mark Thomas ma...@apache.org:
 On 07/09/2011 19:49, Konstantin Kolinko wrote:
 2011/9/7  ma...@apache.org:
 Author: markt
 Date: Wed Sep  7 18:11:20 2011
 New Revision: 1166290

 URL: http://svn.apache.org/viewvc?rev=1166290view=rev
 Log:
 Add a simple annotation cache to improve performance for applications that 
 use lots of non-poolable tags.

 1. I think most classes do not have annotations. If I understand
 correctly the code allocates new ArrayList() for each class. Maybe we
 can optimize for classes that do not have annotations?
 (E.g. using a shared instance of Collections.emptyList()).

 That would be simple to do.

Ok, I like how you did it.

 2. I wonder when the cache is cleared. E.g. if we are in development
 mode or have enabled unloading unused JSPs in JspServlet
 configuration. If I understand correctly it accumulates references to
 Class objects but never releases them.

 When the context is stopped.

This issue is still pending.
Though I think it concerns only development mode, and benefits of this
cache out-weight the resource leak.


3. Regarding the instances not created through the instance manager:
http://svn.apache.org/viewvc?rev=1166775view=rev

The code is now skipping annotations in those classes.
The old code would scan them for preDestroy annotations.
I have not looked what behaviour is required by the specs here, but I
think that the old behaviour was more correct.

4. There is code that calls setAccessible() for Method, e.g.:

Method postConstruct = (Method) entry.getAccessibleObject();
boolean accessibility = postConstruct.isAccessible();
postConstruct.setAccessible(true);
postConstruct.invoke(instance);
postConstruct.setAccessible(accessibility);

There will be a race condition if several threads are changing
(setting or restoring) the method accessibility flag on the same
Method right before invoke() or isAccessible() calls.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-09-12 Thread Konstantin Kolinko
2011/9/12 Bill Barker billbar...@apache.org:
 To whom it may engage...

 This is an automated request, but not an unsolicited one. For
 more information please visit http://gump.apache.org/nagged.html,
 and/or contact the folk at gene...@gump.apache.org.

 Project tomcat-trunk-test has an issue affecting its community integration.
 This issue affects 1 projects,
  and has been outstanding for 2 runs.
 The current state of this project is 'Failed', with reason 'Build Failed'.
 For reference only, the following projects are affected by this:
    - tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
 3.1,
    ...


 Full details are available at:
    
 http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html



1. There is only one failure in this Gump run:
org.apache.catalina.comet.TestCometProcessor + NIO

BIO tests have run successfully

The failure here is
[[[
Testsuite: org.apache.catalina.comet.TestCometProcessor
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 16.805 sec
- Standard Error -
(...) (no error messages here)
-  ---
Testcase: testSimpleCometClient took 10.702 sec
Testcase: testCometConnectorStop took 6.081 sec
FAILED
null
junit.framework.AssertionFailedError
at 
org.apache.catalina.comet.TestCometProcessor.testCometConnectorStop(TestCometProcessor.java:164)
]]]
File:
  
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.catalina.comet.TestCometProcessor.NIO.txt.html


2. I was running the tests locally for current trunk. (Win7 (64bit) +
32-bit JDK 6u26 + native 1.1.22 32-bit) x BIO,NIO,APR

The same test failed, but with different connector and in different way.
All other tests have run successfully.

Failed TestCometProcessor + APR
Apparently there was NPE during shutdown.
[[[
Testsuite: org.apache.catalina.comet.TestCometProcessor
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 21,099 sec
- Standard Error -
(...) (First test has run OK. Here is the second test:)
12.09.2011 17:02:23 org.apache.catalina.core.AprLifecycleListener init
INFO: Loaded APR based Apache Tomcat Native library 1.1.22.
12.09.2011 17:02:23 org.apache.catalina.core.AprLifecycleListener init
INFO: APR capabilities: IPv6 [false], sendfile [true], accept filters
[false], random [true].
12.09.2011 17:02:24 org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler [http-apr-8002]
12.09.2011 17:02:24 org.apache.catalina.core.StandardService startInternal
INFO: Starting service Tomcat
12.09.2011 17:02:24 org.apache.catalina.core.StandardEngine startInternal
INFO: Starting Servlet Engine: Apache Tomcat/8.0.0-dev
12.09.2011 17:02:24 org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler [http-apr-8002]
12.09.2011 17:02:24 org.apache.tomcat.util.net.AprEndpoint allocatePoller
INFO: Failed to create poller with specified size of 8192
12.09.2011 17:02:24 org.apache.tomcat.util.net.AprEndpoint allocatePoller
INFO: Failed to create poller with specified size of 8192
12.09.2011 17:02:27 org.apache.coyote.AbstractProtocol stop
INFO: Stopping ProtocolHandler [http-apr-8002]
12.09.2011 17:02:28 org.apache.coyote.AbstractProtocol destroy
INFO: Destroying ProtocolHandler [http-apr-8002]
12.09.2011 17:02:28
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler process
SEVERE: null
java.lang.NullPointerException
at 
org.apache.tomcat.util.net.AprEndpoint.getPoller(AprEndpoint.java:197)
at 
org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.release(Http11AprProtocol.java:219)
at 
org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.release(Http11AprProtocol.java:179)
at 
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:531)
at 
org.apache.tomcat.util.net.AprEndpoint$SocketEventProcessor.run(AprEndpoint.java:1869)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
12.09.2011 17:02:30 org.apache.catalina.core.StandardService stopInternal
INFO: Stopping service Tomcat
12.09.2011 17:02:30 org.apache.catalina.startup.ExpandWar deleteDir
SEVERE: [D:\(...)\output\tomcat8\test-tmp\logs] could not be
completely deleted. The presence of the remaining files may cause
problems
(...)(two more copies of cannot delete test-tmp message. It is irrelevant).
-  ---

Testcase: testSimpleCometClient took 14,705 sec
Testcase: testCometConnectorStop took 6,371 sec
FAILED

junit.framework.AssertionFailedError:
at 
org.apache.catalina.comet.TestCometProcessor.testCometConnectorStop(TestCometProcessor.java:164)


Best regards,
Konstantin Kolinko


svn commit: r1169796 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java

2011-09-12 Thread fhanik
Author: fhanik
Date: Mon Sep 12 15:25:13 2011
New Revision: 1169796

URL: http://svn.apache.org/viewvc?rev=1169796view=rev
Log:
typo in decorator
https://issues.apache.org/bugzilla/show_bug.cgi?id=48392


Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java?rev=1169796r1=1169795r2=1169796view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
 Mon Sep 12 15:25:13 2011
@@ -127,7 +127,7 @@ public class StatementDecoratorIntercept
 result = constructor.newInstance(new Object[] { statementProxy });
 statementProxy.setActualProxy(result);
 statementProxy.setConnection(proxy);
-statementProxy.setConnection(constructor);
+statementProxy.setConstructor(constructor);
 return result;
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 48392] jdbc-pool is not returning the proxied connection in resultSet and statement

2011-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48392

Filip Hanik fha...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #8 from Filip Hanik fha...@apache.org 2011-09-12 15:25:29 UTC ---
Thank you
Fixed in r1169796

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of RecentChanges by KonstantinKolinko

2011-09-12 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The RecentChanges page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/RecentChanges?action=diffrev1=6rev2=7

Comment:
Assign acl to protect the page

+ #acl LeoSimons:read,write,admin,delete,revert AdminGroup:read,write All:read
  ##language:en
  This page contains a list of recent changes in this wiki of '''PageCount 
pages''' (more system information on SystemInfo). For changes on other wikis, 
see OpenWiki:WikiSites/Aggregation.
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn propchange: r1164482 - svn:log

2011-09-12 Thread kkolinko
Author: kkolinko
Revision: 1164482
Modified property: svn:log

Modified: svn:log at Mon Sep 12 23:31:34 2011
--
--- svn:log (original)
+++ svn:log Mon Sep 12 23:31:34 2011
@@ -0,0 +1,4 @@
+Backport of r1164480:
+
+Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51550
+Use context error pages where possible e.g. for authenticator errors


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn propchange: r1137753 - svn:log

2011-09-12 Thread kkolinko
Author: kkolinko
Revision: 1137753
Modified property: svn:log

Modified: svn:log at Tue Sep 13 00:08:20 2011
--
--- svn:log (original)
+++ svn:log Tue Sep 13 00:08:20 2011
@@ -1,3 +1,3 @@
 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51395
 Fix memory leak triggered when an application that includes a SAXParserFactory 
is the first web application to be loaded.
-Fix part 1 of 2 for CVE-2011-2481
+Fix part 1 of 3 for CVE-2011-2481


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn propchange: r1138776 - svn:log

2011-09-12 Thread kkolinko
Author: kkolinko
Revision: 1138776
Modified property: svn:log

Modified: svn:log at Tue Sep 13 00:08:37 2011
--
--- svn:log (original)
+++ svn:log Tue Sep 13 00:08:37 2011
@@ -1 +1,2 @@
 Revert r1137753 - I have a better soution in mind
+Fix part 2 of 3 for CVE-2011-2481


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn propchange: r1138788 - svn:log

2011-09-12 Thread kkolinko
Author: kkolinko
Revision: 1138788
Modified property: svn:log

Modified: svn:log at Tue Sep 13 00:08:54 2011
--
--- svn:log (original)
+++ svn:log Tue Sep 13 00:08:54 2011
@@ -1,3 +1,3 @@
 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51395
 Better fix for memory leak that aligns ContextConfig with TldConfig
-Fix part 2 of 2 for CVE-2011-2481
+Fix part 3 of 3 for CVE-2011-2481


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1169985 - in /tomcat/site/trunk: docs/maven-plugin.html xdocs/maven-plugin.xml

2011-09-12 Thread kkolinko
Author: kkolinko
Date: Tue Sep 13 00:30:14 2011
New Revision: 1169985

URL: http://svn.apache.org/viewvc?rev=1169985view=rev
Log:
svn:eol-style=native

Modified:
tomcat/site/trunk/docs/maven-plugin.html   (props changed)
tomcat/site/trunk/xdocs/maven-plugin.xml   (props changed)

Propchange: tomcat/site/trunk/docs/maven-plugin.html
--
svn:eol-style = native

Propchange: tomcat/site/trunk/xdocs/maven-plugin.xml
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1169987 - in /tomcat/site/trunk: docs/security-7.html xdocs/security-7.xml xdocs/stylesheets/tomcat-site.xsl

2011-09-12 Thread kkolinko
Author: kkolinko
Date: Tue Sep 13 00:37:44 2011
New Revision: 1169987

URL: http://svn.apache.org/viewvc?rev=1169987view=rev
Log:
* security-7.xml:
  The history of the fix for CVE-2011-2481 was a bit more complicated. Add 
missed revision number.
* tomcat-site.xsl:
  Add new tag revlink as a more simple markup for links to svn revisions.
  See security-7.xml for an example.

Modified:
tomcat/site/trunk/docs/security-7.html
tomcat/site/trunk/xdocs/security-7.xml
tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl

Modified: tomcat/site/trunk/docs/security-7.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-7.html?rev=1169987r1=1169986r2=1169987view=diff
==
--- tomcat/site/trunk/docs/security-7.html (original)
+++ tomcat/site/trunk/docs/security-7.html Tue Sep 13 00:37:44 2011
@@ -537,11 +537,10 @@
view and/or alter the web.xml, context.xml and tld files of other web
applications deployed on the Tomcat instance./p
 
-pThis was fixed in
-   a href=http://svn.apache.org/viewvc?rev=1137753amp;view=rev;
-   revision 1137753/a and
-   a href=http://svn.apache.org/viewvc?rev=1138788amp;view=rev;
-   revision 1138788/a and ./p
+pThis was first fixed in
+   a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1137753;revision 
1137753/a, 
+   but reverted in a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1138776;revision 
1138776/a and
+   finally fixed in a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1138788;revision 
1138788/a./p
 
 pThis was identified by the Tomcat security team on 20 June 2011 and
made public on 12 August 2011./p

Modified: tomcat/site/trunk/xdocs/security-7.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-7.xml?rev=1169987r1=1169986r2=1169987view=diff
==
--- tomcat/site/trunk/xdocs/security-7.xml (original)
+++ tomcat/site/trunk/xdocs/security-7.xml Tue Sep 13 00:37:44 2011
@@ -190,11 +190,10 @@
view and/or alter the web.xml, context.xml and tld files of other web
applications deployed on the Tomcat instance./p
 
-pThis was fixed in
-   a href=http://svn.apache.org/viewvc?rev=1137753amp;view=rev;
-   revision 1137753/a and
-   a href=http://svn.apache.org/viewvc?rev=1138788amp;view=rev;
-   revision 1138788/a and ./p
+pThis was first fixed in
+   revlink rev=1137753revision 1137753/revlink, 
+   but reverted in revlink rev=1138776revision 1138776/revlink and
+   finally fixed in revlink rev=1138788revision 1138788/revlink./p
 
 pThis was identified by the Tomcat security team on 20 June 2011 and
made public on 12 August 2011./p

Modified: tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl?rev=1169987r1=1169986r2=1169987view=diff
==
--- tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl (original)
+++ tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl Tue Sep 13 00:37:44 2011
@@ -17,6 +17,7 @@
 
   !-- Defined parameters (overrideable) --
   xsl:paramname=relative-path select='.'/
+  xsl:paramname=revlink   
select='http://svn.apache.org/viewvc?view=revamp;rev='/
 
   !-- Defined variables (non-overrideable) --
   xsl:variable name=body-bg   select='#ff'/
@@ -333,6 +334,13 @@
 /div
   /xsl:template
 
+  !-- Link to a SVN revision report --
+  !-- It is similar to rev tag in tomcat-docs.xsl, but allows arbitrary 
text inside --
+  xsl:template match=revlink
+  xsl:variable name=linkxsl:value-of select=$revlink/xsl:value-of 
select=@rev//xsl:variable
+  a href={$link}xsl:apply-templates//a
+  /xsl:template
+
   !-- specially process td tags ala site.vsl --
   xsl:template match=table[@class='detail-table']/tr/td
 td bgcolor={$table-td-bg} valign=top align=left



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51726] configure reports cannot remove `libtoolT': No such file or directory

2011-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51726

Eiji Takahashi ei...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID
 OS/Version||All

--- Comment #1 from Eiji Takahashi ei...@apache.org 2011-09-13 00:55:33 UTC 
---
'libtoolT' is created and removed by config.status.
config.status removes previous 'libtoolT' prior to creating new file.

If you create the configure script using buildconf.sh on your system, for
example CentOS6, the generated script creates following script.(CentOS6
contains aclocal-1.11.1.) 
-snippet of config.status
1487
1488 cfgfile=${ofile}T
1489 trap $RM \$cfgfile\; exit 1 1 2 15
1490 $RM $cfgfile
1491
1492 cat _LT_EOF  $cfgfile
1493 #! $SHELL
1494
---
You get the following message because the rm command has no option.
 rm: libtoolT: No such file or directory

If you use aclocal-1.10, the configure script creates following script.
-
1323
1324 cfgfile=${ofile}T
1325 trap $RM -f \$cfgfile\; exit 1 1 2 15
1326 $RM -f $cfgfile
1327
1328 cat _LT_EOF  $cfgfile
1329 #! $SHELL
1330
---
You don't get the above message because the rm command has the -f option.

regards.

Eiji

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1169992 - in /tomcat/site/trunk: docs/security-7.html xdocs/security-7.xml xdocs/stylesheets/tomcat-site.xsl

2011-09-12 Thread kkolinko
Author: kkolinko
Date: Tue Sep 13 01:04:36 2011
New Revision: 1169992

URL: http://svn.apache.org/viewvc?rev=1169992view=rev
Log:
tomcat-site.xsl:
  Copy rev and bug tags from tomcat-docs.xls.
  Add cve tag for links to CVE pages.
security-7.xml:
  Simplify markup.

Modified:
tomcat/site/trunk/docs/security-7.html
tomcat/site/trunk/xdocs/security-7.xml
tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl

Modified: tomcat/site/trunk/docs/security-7.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-7.html?rev=1169992r1=1169991r2=1169992view=diff
==
--- tomcat/site/trunk/docs/security-7.html (original)
+++ tomcat/site/trunk/docs/security-7.html Tue Sep 13 01:04:36 2011
@@ -343,9 +343,7 @@
/ul
 /p
 
-pThis was fixed in revision
-   a href=http://svn.apache.org/viewvc?rev=1162958amp;view=rev;
-   1162958/a./p
+pThis was fixed in a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1162958;revision 
1162958/a./p
 
 pThis was reported publicly on 20th August 2011./p
 
@@ -354,7 +352,7 @@
 pMitigation options:/p  
 ul
   liUpgrade to Tomcat 7.0.21/li
-  liApply the appropriate a 
href=http://svn.apache.org/viewvc?rev=1162958amp;view=rev;patch/a
+  liApply the appropriate a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1162958;patch/a
 /li
   liConfigure both Tomcat and the reverse proxy to use a shared secret
(requiredSecret attribute in
@@ -410,9 +408,7 @@
this vulnerability.
 /p
 
-pThis was fixed in revision
-   a href=http://svn.apache.org/viewvc?rev=1153379amp;view=rev;
-   1153379/a./p
+pThis was fixed in a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1153379;revision 
1153379/a./p
 
 pThis was identified by Wilfried Weissmann on 20 July 2011 and made 
public
on 12 August 2011./p
@@ -476,16 +472,11 @@
 /p
 
 pThis was fixed in revisions
-   a href=http://svn.apache.org/viewvc?rev=1145383amp;view=rev;
-   1145383/a,
-   a href=http://svn.apache.org/viewvc?rev=1145489amp;view=rev;
-   1145489/a,
-   a href=http://svn.apache.org/viewvc?rev=1145571amp;view=rev;
-   1145571/a,
-   a href=http://svn.apache.org/viewvc?rev=1145694amp;view=rev;
-   1145694/a and
-   a href=http://svn.apache.org/viewvc?rev=1146005amp;view=rev;
-   1146005/a./p
+   a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1145383;1145383/a,
+   a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1145489;1145489/a,
+   a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1145571;1145571/a,
+   a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1145694;1145694/a and
+   a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1146005;1146005/a./p
 
 pThis was identified by the Tomcat security team on 7 July 2011 and
made public on 13 July 2011./p
@@ -514,9 +505,7 @@
do not have these permissions but are able to read log files may be able
to discover a user's password./p
 
-pThis was fixed in
-   a href=http://svn.apache.org/viewvc?rev=1140070amp;view=rev;
-   revision 1140070/a./p
+pThis was fixed in a 
href=http://svn.apache.org/viewvc?view=revamp;rev=1140070;revision 
1140070/a./p
 
 pThis was identified by Polina Genova on 14 June 2011 and
made public on 27 June 2011./p
@@ -529,8 +518,8 @@
 /p
 
 pThe re-factoring of XML validation for Tomcat 7.0.x re-introduced the
-   vulnerability previously reported as
-   a href=http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0783; 
rel=nofollowCVE-2009-0783/a. This was initially
+   vulnerability previously reported as a 
href=http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0783; 
rel=nofollowCVE-2009-0783/a.
+   This was initially
a href=https://issues.apache.org/bugzilla/show_bug.cgi?id=51395;
reported/a as a memory leak. If a web application is the first web
application loaded, this bugs allows that web application to potentially

Modified: tomcat/site/trunk/xdocs/security-7.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-7.xml?rev=1169992r1=1169991r2=1169992view=diff
==
--- tomcat/site/trunk/xdocs/security-7.xml (original)
+++ tomcat/site/trunk/xdocs/security-7.xml Tue Sep 13 01:04:36 2011
@@ -29,8 +29,7 @@
 
 pstrongImportant: Authentication bypass and information disclosure
/strong
-   a href=http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-3190;
-   rel=nofollowCVE-2011-3190/a/p
+   cveCVE-2011-3190/cve/p
 
 pApache Tomcat supports the AJP protocol which is used with reverse
proxies to pass requests and associated data about the request from the
@@ -50,9 +49,7 @@
/ul
 /p
 
-pThis was fixed in revision
-   a 

DO NOT REPLY [Bug 51726] configure reports cannot remove `libtoolT': No such file or directory

2011-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51726

--- Comment #2 from Christopher Schultz ch...@christopherschultz.net 
2011-09-13 02:48:58 UTC ---
Eiji, does this mean there is a problem with aclocal (I have Debian Squeeze,
with aclocal 1.11.1), then? Or is is a problem with the use of that tool?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org