Re: svn commit: r1292127 - /tomcat/native/trunk/native/src/sslext.c

2012-02-22 Thread Mladen Turk
On 02/22/2012 05:52 AM, cos...@apache.org wrote: Author: costin + if (len TCN_BUFFER_SZ) { + return -1; + } Suppose that the len is presumed to always be shorter then 8K. char * requestedTicket = apr_pcalloc(tcssl-pool, len); suppose this can be be just

DO NOT REPLY [Bug 51177] javax.el.MapELResolver getType returns class of kept object instead of Object.class

2012-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51177 Michael Heinen mhn4...@googlemail.com changed: What|Removed |Added CC|

DO NOT REPLY [Bug 52735] Request.getRemoteAddr() throw NullPointerException

2012-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52735 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|REOPENED

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Costin Manolache
On Tue, Feb 21, 2012 at 11:11 PM, Mladen Turk mt...@apache.org wrote: On 02/22/2012 06:17 AM, Costin Manolache wrote: Mladen: please let me know if you want to further review the change or should I merge it to the branch. Well I personally would not merge that into 1.1.x branch. It would

svn commit: r1292337 - /tomcat/native/trunk/native/src/sslext.c

2012-02-22 Thread costin
Author: costin Date: Wed Feb 22 15:06:05 2012 New Revision: 1292337 URL: http://svn.apache.org/viewvc?rev=1292337view=rev Log: Fix indentation, comments. Modified: tomcat/native/trunk/native/src/sslext.c Modified: tomcat/native/trunk/native/src/sslext.c URL:

svn commit: r1292338 - /tomcat/trunk/java/org/apache/catalina/loader/VirtualWebappLoader.java

2012-02-22 Thread kkolinko
Author: kkolinko Date: Wed Feb 22 15:10:06 2012 New Revision: 1292338 URL: http://svn.apache.org/viewvc?rev=1292338view=rev Log: Explicitly ignore empty tokens in the value of VirtualWebappLoader#virtualClasspath Modified:

[ANN] Apache Tomcat 7.0.26 released

2012-02-22 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.26 This release is primarily a bug fix release and includes numerous bug fixes compared to version 7.0.25. The notable bug fixes include: * Improved code@HandlesTypes/code processing which no longer loads all

svn commit: r1292342 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/loader/VirtualWebappLoader.java webapps/docs/changelog.xml webapps/docs/config/context.xml webapps/docs/config/loader.xml

2012-02-22 Thread kkolinko
Author: kkolinko Date: Wed Feb 22 15:24:25 2012 New Revision: 1292342 URL: http://svn.apache.org/viewvc?rev=1292342view=rev Log: Merged revisions r1292334 r1292338 from tomcat/trunk: Explicitly ignore empty tokens in the value of VirtualWebappLoader#virtualClasspath Document that

svn commit: r1292345 - /tomcat/trunk/webapps/docs/config/context.xml

2012-02-22 Thread kkolinko
Author: kkolinko Date: Wed Feb 22 15:32:03 2012 New Revision: 1292345 URL: http://svn.apache.org/viewvc?rev=1292345view=rev Log: Fix nesting of p and ul elements. Wrap long line. Modified: tomcat/trunk/webapps/docs/config/context.xml Modified: tomcat/trunk/webapps/docs/config/context.xml

svn commit: r1292347 - /tomcat/trunk/webapps/docs/config/context.xml

2012-02-22 Thread kkolinko
Author: kkolinko Date: Wed Feb 22 15:35:46 2012 New Revision: 1292347 URL: http://svn.apache.org/viewvc?rev=1292347view=rev Log: Split long lines Modified: tomcat/trunk/webapps/docs/config/context.xml Modified: tomcat/trunk/webapps/docs/config/context.xml URL:

svn commit: r1292349 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/config/context.xml

2012-02-22 Thread kkolinko
Author: kkolinko Date: Wed Feb 22 15:37:47 2012 New Revision: 1292349 URL: http://svn.apache.org/viewvc?rev=1292349view=rev Log: Merged revisions 1292345-1292347 from tomcat/trunk: Fix nesting of p and ul elements. Wrap long lines. Modified: tomcat/tc7.0.x/trunk/ (props changed)

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Mladen Turk
On 02/22/2012 03:54 PM, Costin Manolache wrote: On Tue, Feb 21, 2012 at 11:11 PM, Mladen Turkmt...@apache.org wrote: Well I personally would not merge that into 1.1.x branch. It would be a bit weird to have 1.1.22 as is, and 1.1.23 with whole bunch of new features and API's. That's not why

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 8:13 AM, Mladen Turk mt...@apache.org wrote: On 02/22/2012 03:54 PM, Costin Manolache wrote: On Tue, Feb 21, 2012 at 11:11 PM, Mladen Turkmt...@apache.org wrote: Well I personally would not merge that into 1.1.x branch. It would be a bit weird to have 1.1.22 as

Re: SPDY support

2012-02-22 Thread Costin Manolache
First part submitted. For the second: what is the process for adding a dependency ? jzlib is BSD - I added it to 'download' and build.properties. I can make it optional (i.e. skip building the code that depend on it if jzlib is missing ), but it doesn't seem to be worth it. Do automatic builders

Re: SPDY support

2012-02-22 Thread Mark Thomas
On 22/02/2012 16:51, Costin Manolache wrote: First part submitted. For the second: what is the process for adding a dependency ? Why do you need the dependency? jzlib is BSD - I added it to 'download' and build.properties. LICENSE and NOTICE need updating as well (multiple locations). So

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas ma...@apache.org wrote: On 22/02/2012 16:51, Costin Manolache wrote: First part submitted. For the second: what is the process for adding a dependency ? Why do you need the dependency? Spdy requires header compression - with a pre-defined

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Mladen Turk
On 02/22/2012 05:47 PM, Costin Manolache wrote: On Wed, Feb 22, 2012 at 8:13 AM, Mladen Turkmt...@apache.org wrote: One thing I would appreciate help with: I would like to have an option to statically link openssl and apr into the tc-native .so - I mean use openssl.a, apr.a. You mean for

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 9:12 AM, Mladen Turk mt...@apache.org wrote: On 02/22/2012 05:47 PM, Costin Manolache wrote: On Wed, Feb 22, 2012 at 8:13 AM, Mladen Turkmt...@apache.org wrote: One thing I would appreciate help with: I would like to have an option to statically link openssl and

Re: SPDY support

2012-02-22 Thread Konstantin Kolinko
2012/2/22 Costin Manolache cos...@gmail.com: On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas ma...@apache.org wrote: On 22/02/2012 16:51, Costin Manolache wrote: First part submitted. For the second: what is the process for adding a dependency ? Why do you need the dependency? Spdy

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2012/2/22 Costin Manolache cos...@gmail.com: On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas ma...@apache.org wrote: On 22/02/2012 16:51, Costin Manolache wrote: First part submitted. For the second: what

Re: SPDY support

2012-02-22 Thread Mark Thomas
On 22/02/2012 18:41, Costin Manolache wrote: On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2012/2/22 Costin Manolache cos...@gmail.com: On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas ma...@apache.org wrote: On 22/02/2012 16:51, Costin Manolache wrote:

Tomcat with mod_jk becomes irresponsive after working for awhile

2012-02-22 Thread Ofer Israeli
All, I have a deployment on Windows 2003 Server using Apache 2.2.16, Tomcat 5.5.30 and mod_jk 1.2.31. Apache and Tomcat reside on the same machine. The communication is fine for days / weeks, but at some point all requests to the server (to Apache) that use mod_jk return HTTP 503. The error

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Mladen Turk
On 02/22/2012 07:22 PM, Costin Manolache wrote: On Wed, Feb 22, 2012 at 9:12 AM, Mladen Turkmt...@apache.org wrote: However, not sure why you wish to do that. Many distros already provide tomcat-native so there's no real point for doing that, especially since we should not distribute unix

svn commit: r1292453 - in /tomcat/trunk/java/org/apache/catalina/websocket: StreamInbound.java WsInputStream.java

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:19:07 2012 New Revision: 1292453 URL: http://svn.apache.org/viewvc?rev=1292453view=rev Log: Review of r1291507 Fix one issue and add some comments to clarify why some odd looking things are indeed safe. Modified:

svn commit: r1292454 - in /tomcat/trunk/java/org/apache/catalina/websocket: StreamInbound.java WsOutbound.java

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:19:48 2012 New Revision: 1292454 URL: http://svn.apache.org/viewvc?rev=1292454view=rev Log: Further review of r1291507. Pass WsInputStream instead of InputStream and use actual payload lengths. Modified:

Re: Tomcat with mod_jk becomes irresponsive after working for awhile

2012-02-22 Thread Mark Thomas
On 22/02/2012 19:02, Ofer Israeli wrote: All, This is the dev list, not the users list. This question does not belong on this list. Further, I see you already posted to the users list. Please do not cross post. Mark I have a deployment on Windows 2003 Server using Apache 2.2.16, Tomcat

svn commit: r1292456 - in /tomcat/trunk/java/org/apache: catalina/websocket/ coyote/http11/upgrade/

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:20:46 2012 New Revision: 1292456 URL: http://svn.apache.org/viewvc?rev=1292456view=rev Log: Check for unexpected EOS. Close the connection if one is seen. Modified: tomcat/trunk/java/org/apache/catalina/websocket/StreamInbound.java

svn commit: r1292457 - in /tomcat/trunk: java/org/apache/catalina/websocket/MessageInbound.java java/org/apache/catalina/websocket/WsOutbound.java test/org/apache/catalina/websocket/TestWebSocket.java

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:21:43 2012 New Revision: 1292457 URL: http://svn.apache.org/viewvc?rev=1292457view=rev Log: Reduce visibility Modified: tomcat/trunk/java/org/apache/catalina/websocket/MessageInbound.java tomcat/trunk/java/org/apache/catalina/websocket/WsOutbound.java

svn commit: r1292459 - in /tomcat/trunk/java/org/apache: coyote/http11/ coyote/spdy/ tomcat/spdy/ tomcat/util/net/

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:22:51 2012 New Revision: 1292459 URL: http://svn.apache.org/viewvc?rev=1292459view=rev Log: Fix trailing whitespace and import order Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java

svn commit: r1292461 - /tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContextProxy.java

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:23:31 2012 New Revision: 1292461 URL: http://svn.apache.org/viewvc?rev=1292461view=rev Log: Add missing license header Modified: tomcat/trunk/java/org/apache/tomcat/spdy/SpdyContextProxy.java Modified:

DO NOT REPLY [Bug 52735] Request.getRemoteAddr() throw NullPointerException

2012-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52735 minde sun minde@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r1292463 - /tomcat/trunk/res/checkstyle/org-import-control.xml

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 19:26:43 2012 New Revision: 1292463 URL: http://svn.apache.org/viewvc?rev=1292463view=rev Log: Keep checkstyle happy w.r.t. spdy Modified: tomcat/trunk/res/checkstyle/org-import-control.xml Modified: tomcat/trunk/res/checkstyle/org-import-control.xml URL:

DO NOT REPLY [Bug 52735] Request.getRemoteAddr() throw NullPointerException

2012-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52735 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

DO NOT REPLY [Bug 52735] Request.getRemoteAddr() throw NullPointerException

2012-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52735 --- Comment #8 from minde sun minde@gmail.com 2012-02-22 20:16:30 UTC --- I actually just found a bug from org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:272) as the following statement long

svn commit: r1292498 - /tomcat/trunk/java/org/apache/catalina/websocket/WsInputStream.java

2012-02-22 Thread markt
Author: markt Date: Wed Feb 22 20:41:00 2012 New Revision: 1292498 URL: http://svn.apache.org/viewvc?rev=1292498view=rev Log: Fix silly error Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsInputStream.java Modified:

RE: Tomcat with mod_jk becomes irresponsive after working for awhile

2012-02-22 Thread Ofer Israeli
Mark Thomas wrote: On 22/02/2012 19:02, Ofer Israeli wrote: All, This is the dev list, not the users list. This question does not belong on this list. Further, I see you already posted to the users list. Please do not cross post. Mark Hi Mark, The reason I posted here as well as the

RE: Tomcat with mod_jk becomes irresponsive after working for awhile

2012-02-22 Thread Caldarale, Charles R
From: Ofer Israeli [mailto:of...@checkpoint.com] Subject: RE: Tomcat with mod_jk becomes irresponsive after working for awhile The reason I posted here as well as the users list is that I think there may be a bug in the Tomcat connector. Should I procede in a different manner? Yes, the

svn commit: r1292598 - in /tomcat/trunk/java/org/apache/catalina/websocket: StreamInbound.java WsFrame.java WsFrameHeader.java WsInputStream.java WsOutbound.java

2012-02-22 Thread markt
Author: markt Date: Thu Feb 23 00:40:02 2012 New Revision: 1292598 URL: http://svn.apache.org/viewvc?rev=1292598view=rev Log: Refactor Added: tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java - copied, changed from r1292498,

svn commit: r1292600 - /tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java

2012-02-22 Thread markt
Author: markt Date: Thu Feb 23 00:40:42 2012 New Revision: 1292600 URL: http://svn.apache.org/viewvc?rev=1292600view=rev Log: Refactor Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java URL:

svn commit: r1292601 - in /tomcat/trunk/java/org/apache/catalina/websocket: StreamInbound.java WsInputStream.java

2012-02-22 Thread markt
Author: markt Date: Thu Feb 23 00:41:22 2012 New Revision: 1292601 URL: http://svn.apache.org/viewvc?rev=1292601view=rev Log: Handle ping frames in the middle of fragmented messages Modified: tomcat/trunk/java/org/apache/catalina/websocket/StreamInbound.java

svn commit: r1292602 - in /tomcat/trunk/java/org/apache/catalina/websocket: MessageInbound.java StreamInbound.java WsOutbound.java

2012-02-22 Thread markt
Author: markt Date: Thu Feb 23 00:42:05 2012 New Revision: 1292602 URL: http://svn.apache.org/viewvc?rev=1292602view=rev Log: Tighten up UTF-8 handling Modified: tomcat/trunk/java/org/apache/catalina/websocket/MessageInbound.java

Re: WebSocket progress report

2012-02-22 Thread Petr Praus
On Mon, Feb 20, 2012 at 16:19, Mark Thomas ma...@apache.org wrote: On 20/02/2012 21:28, Petr Praus wrote: I'm glad to hear that. BTW, Jonathan quite significantly overhauled our implementation over the weekend. The WebSocketFrame no longer buffers data but just stores a reference to

svn commit: r1292671 - in /tomcat/trunk/java/org/apache: coyote/spdy/SpdyAprNpnHandler.java tomcat/jni/SSLExt.java tomcat/spdy/CompressDeflater6.java

2012-02-22 Thread costin
Author: costin Date: Thu Feb 23 07:03:52 2012 New Revision: 1292671 URL: http://svn.apache.org/viewvc?rev=1292671view=rev Log: Add decompress support and the npn handler. Assuming you compile the right jni library it should (basicaly) work with chrome and firefox. Lots of missing features:

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 10:47 AM, Mark Thomas ma...@apache.org wrote: On 22/02/2012 18:41, Costin Manolache wrote: On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2012/2/22 Costin Manolache cos...@gmail.com: On Wed, Feb 22, 2012 at 8:57 AM, Mark