Re: svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-02 Thread Mark Thomas
On 01/03/2012 23:47, Filip Hanik - Dev Lists wrote: Thanks for that John, I'll fix that too. That probably explains the Comet failures we have been seeing in the unit tests. Excellent. Mark Filip On 3/1/2012 4:42 PM, Johno Crawford wrote: On 2/03/2012 12:05 AM, fha...@apache.org wrote:

Re: WebSocket status

2012-03-02 Thread Mark Thomas
On 01/03/2012 22:55, Filip Hanik - Dev Lists wrote: You can't register on a selector using another thread. Bingo. That explains it. Is that documented anywhere? I don't recall reading it but I may well have missed it. Looking at the code, it looks like HTTP would have been unaffected which is

Re: [Tomcat Wiki] Update of PageD'Accueil by Roger Mbiama

2012-03-02 Thread Pid
On 01/03/2012 20:42, Apache Wiki wrote: Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The PageD'Accueil page has been changed by Roger Mbiama: http://wiki.apache.org/tomcat/PageD%27Accueil?action=diffrev1=1rev2=2 ## For

svn commit: r1296102 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProtocol.java webapps/docs/changelog.xml

2012-03-02 Thread markt
Author: markt Date: Fri Mar 2 09:38:33 2012 New Revision: 1296102 URL: http://svn.apache.org/viewvc?rev=1296102view=rev Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-02 Thread Mark Thomas
On 02/03/2012 00:13, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2802 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: [VOTE] Release Apache Tomcat Native 1.1.23

2012-03-02 Thread jean-frederic clere
On 02/28/2012 03:39 PM, Mladen Turk wrote: [+1] Released Tested on Fedora16 compiled on Solaris/HPUX/RHEL4/5. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

svn commit: r1296171 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

2012-03-02 Thread markt
Author: markt Date: Fri Mar 2 12:41:03 2012 New Revision: 1296171 URL: http://svn.apache.org/viewvc?rev=1296171view=rev Log: Remove unused imports Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Modified:

svn commit: r1296172 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java ajp/AbstractAjpProtocol.java http11/Http11AprProtocol.java http11/Http11NioProtocol.java http11/Http11Protocol.jav

2012-03-02 Thread markt
Author: markt Date: Fri Mar 2 12:41:54 2012 New Revision: 1296172 URL: http://svn.apache.org/viewvc?rev=1296172view=rev Log: No need for an upgrade specific poll method. Delete some more code :) Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-03-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #48 from Johno Crawford jo...@sulake.com 2012-03-02 12:53:06 UTC --- Created attachment 28410 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28410 Improved echo example Please find attached proposal for improved

DO NOT REPLY [Bug 52811] New: HttpServletResponse.setContentType() parses the content type incorrectly

2012-03-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52811 Bug #: 52811 Summary: HttpServletResponse.setContentType() parses the content type incorrectly Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version:

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-02 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2803 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: svn commit: r1296172 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java ajp/AbstractAjpProtocol.java http11/Http11AprProtocol.java http11/Http11NioProtocol.java http11/Http11Protocol

2012-03-02 Thread Johno Crawford
Hi Mark, Quick question regarding web socket socket states, using the BIO connector I have observed the socket state never transitions to UPGRADED.. Is this the expected behaviour? Cheers, Johno On 2/03/2012 1:41 PM, ma...@apache.org wrote: Author: markt Date: Fri Mar 2 12:41:54 2012 New

Re: WebSocket status

2012-03-02 Thread Filip Hanik - Dev Lists
On 3/2/2012 2:13 AM, Mark Thomas wrote: You can't register on a selector using another thread. Bingo. That explains it. Is that documented anywhere? I'm not sure if the java.nio documentation says it, I think it does. The Selector object is not thread safe. trying to manipulate interestops and

Re: svn commit: r1296172 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java ajp/AbstractAjpProtocol.java http11/Http11AprProtocol.java http11/Http11NioProtocol.java http11/Http11Protocol

2012-03-02 Thread Mark Thomas
On 02/03/2012 13:17, Johno Crawford wrote: Hi Mark, Quick question regarding web socket socket states, using the BIO connector I have observed the socket state never transitions to UPGRADED.. Is this the expected behaviour? Short answer: yes. Longer answer: In this case state is the state

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-02 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2804 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[RESULT] Was: [VOTE] Release Apache Tomcat Native 1.1.23

2012-03-02 Thread Mladen Turk
With my implicit +1 we 4 +1's (Henri, Filip, Jean-Frederic and I) and no other votes. I declare vote as passed. On 02/28/2012 03:39 PM, Mladen Turk wrote: Version 1.1.23 is both bugfix release with couple of additional features that does not change ABI (namely OCSP and pkcs12 support). The

svn commit: r517 - in /release/tomcat/tomcat-connectors/native: ./ 1.1.23/ 1.1.23/binaries/ 1.1.23/source/

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 15:11:32 2012 New Revision: 517 Log: Add 1.1.23 artefacts Added: release/tomcat/tomcat-connectors/native/1.1.23/ release/tomcat/tomcat-connectors/native/1.1.23/binaries/

svn commit: r517 - in /release/tomcat/tomcat-connectors/native: ./ 1.1.23/ 1.1.23/binaries/ 1.1.23/source/

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 15:11:32 2012 New Revision: 517 Log: Add 1.1.23 artefacts Added: release/tomcat/tomcat-connectors/native/1.1.23/ release/tomcat/tomcat-connectors/native/1.1.23/binaries/

svn commit: r1296246 - in /tomcat/native/branches/1.1.x: build.properties.default native/include/tcn_version.h xdocs/index.xml xdocs/news/2012.xml

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 15:21:34 2012 New Revision: 1296246 URL: http://svn.apache.org/viewvc?rev=1296246view=rev Log: Update version and release info Modified: tomcat/native/branches/1.1.x/build.properties.default tomcat/native/branches/1.1.x/native/include/tcn_version.h

svn commit: r1296248 - /tomcat/site/trunk/xdocs/index.xml

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 15:29:15 2012 New Revision: 1296248 URL: http://svn.apache.org/viewvc?rev=1296248view=rev Log: Add 1.1.23 release section Modified: tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/xdocs/index.xml URL:

svn commit: r1296249 - /tomcat/site/trunk/docs/index.html

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 15:29:35 2012 New Revision: 1296249 URL: http://svn.apache.org/viewvc?rev=1296249view=rev Log: Add 1.1.23 release section Modified: tomcat/site/trunk/docs/index.html Modified: tomcat/site/trunk/docs/index.html URL:

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-03-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 Johno Crawford jo...@sulake.com changed: What|Removed |Added Attachment #28408|0 |1 is

svn commit: r1296257 - in /tomcat/site/trunk: docs/download-native.html xdocs/download-native.xml

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 15:48:42 2012 New Revision: 1296257 URL: http://svn.apache.org/viewvc?rev=1296257view=rev Log: Update 1.1.23 download section Modified: tomcat/site/trunk/docs/download-native.html tomcat/site/trunk/xdocs/download-native.xml Modified:

Re: svn commit: r1296172 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java ajp/AbstractAjpProtocol.java http11/Http11AprProtocol.java http11/Http11NioProtocol.java http11/Http11Protocol

2012-03-02 Thread Johno Crawford
On 2/03/2012 2:52 PM, Mark Thomas wrote: On 02/03/2012 13:17, Johno Crawford wrote: Hi Mark, Quick question regarding web socket socket states, using the BIO connector I have observed the socket state never transitions to UPGRADED.. Is this the expected behaviour? Short answer: yes. Longer

svn commit: r1296284 - in /tomcat/trunk: build.properties.default build.xml

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 16:21:18 2012 New Revision: 1296284 URL: http://svn.apache.org/viewvc?rev=1296284view=rev Log: Use simpler tomcat-native distribution which comes with 1.1.23+ Modified: tomcat/trunk/build.properties.default tomcat/trunk/build.xml Modified:

svn commit: r1296302 - /tomcat/trunk/build.xml

2012-03-02 Thread mturk
Author: mturk Date: Fri Mar 2 16:44:37 2012 New Revision: 1296302 URL: http://svn.apache.org/viewvc?rev=1296302view=rev Log: Catch downloaded dist Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-02 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2806 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

[ANN] Apache Tomcat Native 1.1.23 released

2012-03-02 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.1.23 stable. Please refer to the change log for the list of changes: http://tomcat.apache.org/native-doc/miscellaneous/changelog.html Downloads: http://tomcat.apache.org/download-native.cgi Please allow up to

svn commit: r1296388 - in /tomcat/trunk/java/org/apache: catalina/websocket/StreamInbound.java coyote/AbstractProtocol.java coyote/http11/upgrade/UpgradeInbound.java

2012-03-02 Thread markt
Author: markt Date: Fri Mar 2 19:07:01 2012 New Revision: 1296388 URL: http://svn.apache.org/viewvc?rev=1296388view=rev Log: Implement notification of open and close for WebSocket connections. Patch provided by Johno Crawford. Modified:

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-03-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #50 from Mark Thomas ma...@apache.org 2012-03-02 19:10:05 UTC --- (In reply to comment #49) Created attachment 28411 [details] Overrides for connection open and close Patch applied (with some minor tweaks). Many thanks. I

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-03-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #51 from Mark Thomas ma...@apache.org 2012-03-02 19:15:40 UTC --- (In reply to comment #48) Created attachment 28410 [details] Improved echo example Patch applied. Many thanks. -- Configure bugmail:

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-02 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2807 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-02 Thread sebb
On 1 March 2012 18:27, fha...@apache.org wrote: Author: fhanik Date: Thu Mar  1 18:27:56 2012 New Revision: 1295724 URL: http://svn.apache.org/viewvc?rev=1295724view=rev Log: Allow the examples to configure the buffer on the fly Modified:    

instrumenting classes compiled from JSP

2012-03-02 Thread Louis
Hi, If I want to dynamically instrument classes compiled from JSP pages, what is the best places to begin with? From my understanding, the process of JSP handling appears to work as follows: 1 The first request for a JSP page triggers the compilation of the page with Jasper. 2 The class

instrumenting classes compiled from JSP

2012-03-02 Thread Louis
My Tomcat is 7.0.x, forgot mentioning. Louis Hi, If I want to dynamically instrument classes compiled from JSP pages, what is the best places to begin with? From my understanding, the process of JSP handling appears to work as follows: 1 The first request for a JSP page triggers the

ApplicationContextFacade

2012-03-02 Thread Steven Adriaensen
Hey, I was reading through the Tomcat source code, trying to figure out how the tomcat internals are protected against unauthorized access from servlets. One thing I noticed was the fact that the servlets gain access to the StandardContext through the ApplicationContextFacade, which seems to act

DO NOT REPLY [Bug 52815] New: ROOT Service

2012-03-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52815 Bug #: 52815 Summary: ROOT Service Product: Tomcat 7 Version: 7.0.26 Platform: PC OS/Version: Windows Vista Status: NEW Severity: normal

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2012-03-02 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community

[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-03-02 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community