[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 11 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 3 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-06082012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-06082012.jar:/srv/gump/public/workspace/junit/dist/junit-06082012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-06082012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-*[0-9T].jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-06082012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-06082012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-06082012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-06082012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:461: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.init(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at
[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 11 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 2 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-06082012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-06082012.jar:/srv/gump/public/workspace/junit/dist/junit-06082012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-06082012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-*[0-9T].jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-06082012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-06082012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-06082012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-06082012-dep.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:450: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.init(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:163) at
[Bug 53654] JSP file is always recompiled for using file based TLD URL
https://issues.apache.org/bugzilla/show_bug.cgi?id=53654 --- Comment #2 from viola.lu viola...@gmail.com --- Created attachment 29169 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29169action=edit handle file:/ Pls review the patch -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53654] JSP file is always recompiled for using file based TLD URL
https://issues.apache.org/bugzilla/show_bug.cgi?id=53654 --- Comment #3 from viola.lu viola...@gmail.com --- Now compile only handles taglib jar file as jar:/file:/***.jar!/META-INF/taglib.tld or /WEB-INF/taglib.tld, but if tag lib file exists as expanded folder for example: file:/***.jar/META-INF/taglib.tld, Compiler.isOutDated() will return true and compile jsp always. So provide this patch to make it can handle file:/ URL also -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53664] New: Minor JNDI Howto document enhancement concerning mail properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=53664 Priority: P2 Bug ID: 53664 Assignee: dev@tomcat.apache.org Summary: Minor JNDI Howto document enhancement concerning mail properties Severity: enhancement Classification: Unclassified OS: Linux Reporter: mdegg...@gmail.com Hardware: PC Status: NEW Version: 6.0.35 Component: Documentation Product: Tomcat 6 Created attachment 29174 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29174action=edit SVN diff against current Tomcat 6 branch When configuring mail sessions via JNDI and the Resource element, there is no mention of a password attribute. This attribute is useful if you wish Tomcat to manage the remote connection. One such use case is where the source code to the web application is not available, but requires authenticated connection to an external mail server. Tomcat has this capability in the default org.apache.naming.factory.MailSessionFactory class, but it's not documented. The proposed patch amends the jndi-howto document with this information. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53665] New: Minor JNDI Howto document enhancement concerning mail properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=53665 Priority: P2 Bug ID: 53665 Assignee: dev@tomcat.apache.org Summary: Minor JNDI Howto document enhancement concerning mail properties Severity: enhancement Classification: Unclassified OS: Linux Reporter: mdegg...@gmail.com Hardware: PC Status: NEW Version: trunk Component: Documentation Product: Tomcat 7 Created attachment 29175 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29175action=edit SVN diff against current Tomcat 7 branch When configuring mail sessions via JNDI and the Resource element, there is no mention of a password attribute. This attribute is useful if you wish Tomcat to manage the remote connection. One such use case is where the source code to the web application is not available, but requires authenticated connection to an external mail server. Tomcat has this capability in the default org.apache.naming.factory.MailSessionFactory class, but it's not documented. The proposed patch amends the jndi-howto document with this information. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1369969 - /tomcat/trunk/modules/jdbc-pool/build.properties.default
Author: fhanik
Date: Mon Aug 6 20:14:13 2012
New Revision: 1369969
URL: http://svn.apache.org/viewvc?rev=1369969view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=53649 fix compiler warnings
Modified:
tomcat/trunk/modules/jdbc-pool/build.properties.default
Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.properties.default?rev=1369969r1=1369968r2=1369969view=diff
==
--- tomcat/trunk/modules/jdbc-pool/build.properties.default (original)
+++ tomcat/trunk/modules/jdbc-pool/build.properties.default Mon Aug 6 20:14:13
2012
@@ -37,8 +37,8 @@ version.suffix=
# contexts by the various build scripts.
base.path=${basedir}/includes
-compile.source=1.5
-compile.target=1.5
+compile.source=1.7
+compile.target=1.7
compile.debug=true
# - Settings for Junit test database.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53649] build jdbc-pool: bootstrap class path not set in conjunction with -source 1.5
https://issues.apache.org/bugzilla/show_bug.cgi?id=53649 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Filip Hanik fha...@apache.org --- Fixed in r1369969 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1370074 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java test/jav
Author: fhanik
Date: Tue Aug 7 00:14:50 2012
New Revision: 1370074
URL: http://svn.apache.org/viewvc?rev=1370074view=rev
Log:
Implement equals/hashCode so that they survive connection closure
Added:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
(with props)
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java?rev=1370074r1=1370073r2=1370074view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Tue Aug 7 00:14:50 2012
@@ -17,6 +17,7 @@
package org.apache.tomcat.jdbc.pool;
import java.lang.reflect.Method;
+import java.lang.reflect.Proxy;
import java.sql.SQLException;
/**
@@ -44,10 +45,26 @@ public class DisposableConnectionFacade
public void reset(ConnectionPool parent, PooledConnection con) {
}
+
+
+@Override
+public int hashCode() {
+return System.identityHashCode(this);
+}
+
+@Override
+public boolean equals(Object obj) {
+return this==obj;
+}
+
@Override
public Object invoke(Object proxy, Method method, Object[] args)
throws Throwable {
-if (getNext()==null) {
+if (compare(EQUALS_VAL, method)) {
+return this.equals(Proxy.getInvocationHandler(args[0]));
+} else if (compare(HASHCODE_VAL, method)) {
+return this.hashCode();
+} else if (getNext()==null) {
if (compare(ISCLOSED_VAL, method)) {
return Boolean.TRUE;
}
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java?rev=1370074r1=1370073r2=1370074view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
Tue Aug 7 00:14:50 2012
@@ -67,6 +67,16 @@ public abstract class JdbcInterceptor im
public static final String ISVALID_VAL = isValid;
/**
+ * {@link java.lang.Object#equals(Object)}
+ */
+public static final String EQUALS_VAL = equals;
+
+/**
+ * {@link java.lang.Object#hashCode()}
+ */
+public static final String HASHCODE_VAL = hashCode;
+
+/**
* Properties for this interceptor.
*/
protected MapString,InterceptorProperty properties = null;
Added:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java?rev=1370074view=auto
==
---
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
(added)
+++
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
Tue Aug 7 00:14:50 2012
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.jdbc.test;
+
+import java.lang.management.ManagementFactory;
+import java.sql.Connection;
+import java.util.Hashtable;
+
+import javax.sql.PooledConnection;
+
+import org.apache.tomcat.jdbc.pool.ConnectionPool;
+import org.apache.tomcat.jdbc.test.driver.Driver;
+
+public class EqualsHashCodeTest extends
svn commit: r1370075 - in /tomcat/tc7.0.x/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/ test/java/org/apache/tomcat/jdbc/test/
Author: fhanik
Date: Tue Aug 7 00:15:50 2012
New Revision: 1370075
URL: http://svn.apache.org/viewvc?rev=1370075view=rev
Log:
implement equals and hashCode so that they survive connection closure
Added:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
(with props)
Modified:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
Modified:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java?rev=1370075r1=1370074r2=1370075view=diff
==
---
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
(original)
+++
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Tue Aug 7 00:15:50 2012
@@ -17,6 +17,7 @@
package org.apache.tomcat.jdbc.pool;
import java.lang.reflect.Method;
+import java.lang.reflect.Proxy;
import java.sql.SQLException;
/**
@@ -44,10 +45,26 @@ public class DisposableConnectionFacade
public void reset(ConnectionPool parent, PooledConnection con) {
}
+
+
+@Override
+public int hashCode() {
+return System.identityHashCode(this);
+}
+
+@Override
+public boolean equals(Object obj) {
+return this==obj;
+}
+
@Override
public Object invoke(Object proxy, Method method, Object[] args)
throws Throwable {
-if (getNext()==null) {
+if (compare(EQUALS_VAL, method)) {
+return this.equals(Proxy.getInvocationHandler(args[0]));
+} else if (compare(HASHCODE_VAL, method)) {
+return this.hashCode();
+} else if (getNext()==null) {
if (compare(ISCLOSED_VAL, method)) {
return Boolean.TRUE;
}
Modified:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java?rev=1370075r1=1370074r2=1370075view=diff
==
---
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
(original)
+++
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
Tue Aug 7 00:15:50 2012
@@ -67,6 +67,16 @@ public abstract class JdbcInterceptor im
public static final String ISVALID_VAL = isValid;
/**
+ * {@link java.lang.Object#equals(Object)}
+ */
+public static final String EQUALS_VAL = equals;
+
+/**
+ * {@link java.lang.Object#hashCode()}
+ */
+public static final String HASHCODE_VAL = hashCode;
+
+/**
* Properties for this interceptor.
*/
protected MapString,InterceptorProperty properties = null;
Added:
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java?rev=1370075view=auto
==
---
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
(added)
+++
tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java
Tue Aug 7 00:15:50 2012
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.jdbc.test;
+
+import java.lang.management.ManagementFactory;
+import java.sql.Connection;
+import java.util.Hashtable;
+
+import javax.sql.PooledConnection;
+
+import
RE: tomat-jdbc hashCode
Fixed in r1370074 and r1370075 http://svn.apache.org/viewvc?rev=1370075view=rev http://svn.apache.org/viewvc?rev=1370074view=rev -Original Message- From: Filip Hanik Mailing Lists [mailto:devli...@hanik.com] Sent: Monday, July 30, 2012 5:58 AM To: Tomcat Developers List Subject: Re: tomat-jdbc hashCode nope, I will fix that Filip - Original Message - From: Romain Manni-Bucau rmannibu...@gmail.com To: Tomcat Developers List dev@tomcat.apache.org Sent: Tuesday, July 24, 2012 5:18:32 PM Subject: tomat-jdbc hashCode Hi, just noticed tomcat jdbc doesn't manage hashCode if the connection is already close (it is in org.apache.tomcat.jdbc.pool.JdbcInterceptor). Any reason to do so? - Romain - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
