[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath
[ https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481281#comment-13481281 ] Loïc Guerrin commented on MTOMCAT-173: -- Hello, I have the same issue with tomcat7-maven-plugin:2.0. But it's during an integration test with junit. I have the structure below: / -- project-domain -- project-webapp The module project-domain isn't added to the classpath and the startup of the tomcat fails. In the maven debug log I see too 'skip adding artifact project-domain as it's in reactors'. In DefaultClassLoaderEntriesCalculator#calculateClassPathEntries at line 116, the method isInProjectReferences rejects the project-domain as it's in projectReferences of project-webapp. So is it possible to add a cheap workaround like a configuration parameter 'forceIncludeProjectReferences' in order to add those project references to module classpath? Thanks. Direct dependencies are not added to classpath -- Key: MTOMCAT-173 URL: https://issues.apache.org/jira/browse/MTOMCAT-173 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat6, tomcat7 Affects Versions: 2.0 Reporter: Arne Franken Assignee: Olivier Lamy (*$^¨%`£) in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct dependencies are not added, the log message says skip adding artifact + artifact.getArtifactId() + as it's in reactors. In my case, it's a jar that is configured as a direct dependency. When the Webapp starts, the Jar is missing from the Classpath and the startup fails. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] New: currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 Priority: P2 Bug ID: 54036 Assignee: dev@tomcat.apache.org Summary: currentThreadsBusy issue in centos 6 Severity: critical Classification: Unclassified OS: Linux Reporter: vigo...@gmail.com Hardware: PC Status: NEW Version: 7.0.32 Component: Connectors Product: Tomcat 7 Hi, since when centos 6 went out I've tryed to switch some of my server from centos 5.x to 6.x I currently own 13 servers with tomcat installed , thse servers have a very high load, and contain only 1 servlet never reloaded/unloaded which print out static content (no cookie/session) i use the compiled JNI (with apr ) , initially everythin was 1 servlet inside tomcat, now i have directly embedded tomcat into the servlet, the issue is: when i have tomcat (jdk from 1.6.x to 1.7.x doesn't change) and the load become a bit intense (about 600 req/sec ) the currentThreadsBusy become very high till maxes out (220 currentThreadsBusy) and stay at that value, seems that threads have some issue in closing ( i've inserted an atomic timer in servlets to monitor if these remains up, and cuncurrent executions calculated by this timer remain between 1 or 2 !!) and that's right because cpu usage is at 0.3%! same identical configuration in a server with centos 5.x run fine with about 15 threads busy serving about 8k requests/second with cpu usage of about 35% (even if cuncurrent servlet in execution are usually 1 or 2 here too), seems that tomcat have some issue detaching the thread, i supposed that was my fault of some configuration (even if i'm not so dumb on that ) the ni found that this guy have the same problem : http://efreedom.com/Question/1-7296648/Tomcat-Centos-CurrentThreadsBusy-Issue no one seems to have a solution, initially i thought that was because centos 6 was pretty recent so maybe the issue would be fixed in earlyer releases of tomcat, but we are at 7.0.32 and the problem persist.. when i have time i want to try to help in developement of tomcat (i'm learning a bit of his internal syntax while working on it.. ) but at this moment i don't even have time to sleep.. nor to provide some easily reproducible test case , also because this need a bit of load from different sources, but if you have suggestions i can try to implements and let you know if works , best i can do now is to attach thread dump of the current bugged execution (with all threads stuck here at org.apache.tomcat.jni.Socket.recvbb(Native Method) at org.apache.coyote.http11.InternalAprInputBuffer.fill(InternalAprInputBuffer.java:575) at org.apache.coyote.http11.InternalAprInputBuffer.parseRequestLine(InternalAprInputBuffer.java:134) please let me know.. at this moment i'm again going to reinstall centos 5.x on that server and give up, because i need this server up and working today.. but anyway this issues must be fixed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #1 from francesco vigo...@gmail.com --- Created attachment 29506 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29506action=edit thread dump thread dump of tomcat when providing the issue described ( incredibly high currentThreadsBusy ) which causes unusable tomcat installation -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 54036] currentThreadsBusy issue in centos 6
after further investigation seems that the problem is really at this point: at org.apache.tomcat.jni.Socket.recvbb(Native Method) at org.apache.coyote.http11.InternalAprInputBuffer.fill(InternalAprInputBuffer.java:575) each threads hang at this position till timeout and timeout on each connections i just wonder why this doesn't happen in centos 5.x and instead is bugged in centos 6.x probably some EOT/EOF signal didn't pass through APR/JNI ? 2012/10/22 bugzi...@apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #1 from francesco vigo...@gmail.com --- Created attachment 29506 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29506action=edit thread dump thread dump of tomcat when providing the issue described ( incredibly high currentThreadsBusy ) which causes unusable tomcat installation -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #2 from francesco vigo...@gmail.com --- after further investigation seems that the problem is really at this point: at org.apache.tomcat.jni.Socket.recvbb(Native Method) at org.apache.coyote.http11.InternalAprInputBuffer.fill(InternalAprInputBuffer.java:575) each threads hang at this position till timeout and timeout on each connections i just wonder why this doesn't happen in centos 5.x and instead is bugged in centos 6.x probably some EOT/EOF signal didn't pass through APR/JNI ? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-taglibs-standard has an issue affecting its community
integration.
This issue affects 2 projects,
and has been outstanding for 141 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard : Standard Taglib
- tomcat-taglibs-standard-install : JSP Taglibs
Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-INFO- Optional dependency httpunit failed with reason build failed
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
install
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
to
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO]
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO]
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Connectors |Library Version|7.0.32 |unspecified Product|Tomcat 7|Tomcat Native --- Comment #3 from Mark Thomas ma...@apache.org --- Changing component. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #4 from francesco vigo...@gmail.com --- Hi Mark do you mean to change connector? i've tryed changing to BIO but the problem persist.. i have 220 threads blocked at this point: at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:150) at java.net.SocketInputStream.read(SocketInputStream.java:121) at org.apache.coyote.http11.InternalInputBuffer.fill(InternalInputBuffer.java:516) at org.apache.coyote.http11.InternalInputBuffer.fill(InternalInputBuffer.java:501) i have no other solution than change os for tomcat server, but anyway having tomcat UNCOMPATIBLE (because this bug make the system very susceptible to even small DDoS ) with the new CENTOS = 6 is a BIG ISSUE i think. , apache benchmark didn't show the issue in bot APR and BIO , ( keepalive is off (value=1) but the problem show up only when lot of external ip connect) maybe this is due on how the system handle tcp connections closing at lower levels ? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #5 from francesco vigo...@gmail.com --- i understood sorry u meant that you have changed location of the report (i'm not very used to send bug reports) no problem :) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO Component|Library |Connectors Version|unspecified |7.0.32 Product|Tomcat Native |Tomcat 7 --- Comment #6 from Mark Thomas ma...@apache.org --- If this occurs across multiple connectors then this is not an APR/native bug. Moving back. Please provide a reproducible test case. Without one, this will get closed as INVALID. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #7 from francesco vigo...@gmail.com --- you are the good tomcat programmer , how i can write a reproducible case if you cannot reproduce the volume of requests i'm getting (these are TCP connections not udp so i don't know how these can be simulated as coming from multiple different sources (maybe with something like playing with NAT in iptables) ) i am not the only one who has this issue, is someone use tomcat live with centos 6 and have more than 100 visit /seconds should have faced this issue too... the test case doesn't need to be built because happens always on centos = 6 (and probably on RHEL but i haven't tested before) , threads didn't close at the end of connections but at the socket timeout, so if you have high connection rate from different sources the thread pool become exhausted soon.. if you know how to reproduce these multiple connections i'm almost sure that also the HelloWorld servlet would works as test case in centos 6 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54036] currentThreadsBusy issue in centos 6
https://issues.apache.org/bugzilla/show_bug.cgi?id=54036 --- Comment #8 from Pid bugzi...@pidster.com --- Which versions of APR and Java are installed on the Centos 5 and 6 systems? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401092 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java
Author: markt
Date: Mon Oct 22 21:48:32 2012
New Revision: 1401092
URL: http://svn.apache.org/viewvc?rev=1401092view=rev
Log:
FindBugs: Avoid possible NPE.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Connector.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1401092r1=1401091r2=1401092view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Mon Oct 22
21:48:32 2012
@@ -765,7 +765,11 @@ public class Connector extends Lifecycle
*/
public void setURIEncoding(String URIEncoding) {
this.URIEncoding = URIEncoding;
- this.URIEncodingLower = URIEncoding.toLowerCase(Locale.US);
+ if (URIEncoding == null) {
+ URIEncodingLower = null;
+ } else {
+ this.URIEncodingLower = URIEncoding.toLowerCase(Locale.US);
+ }
setProperty(uRIEncoding, URIEncoding);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401093 - /tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java
Author: markt Date: Mon Oct 22 21:50:00 2012 New Revision: 1401093 URL: http://svn.apache.org/viewvc?rev=1401093view=rev Log: Remove unnecessary SuppressWarnings Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java?rev=1401093r1=1401092r2=1401093view=diff == --- tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java (original) +++ tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java Mon Oct 22 21:50:00 2012 @@ -156,7 +156,6 @@ public class CsrfPreventionFilter extend HttpSession session = req.getSession(false); -@SuppressWarnings(unchecked) LruCacheString nonceCache = (session == null) ? null : (LruCacheString) session.getAttribute( Constants.CSRF_NONCE_SESSION_ATTR_NAME); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401101 - /tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
Author: markt
Date: Mon Oct 22 22:00:48 2012
New Revision: 1401101
URL: http://svn.apache.org/viewvc?rev=1401101view=rev
Log:
Remove some out of date Javadoc and an unnecessary constructor.
Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java?rev=1401101r1=1401100r2=1401101view=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java Mon Oct 22
22:00:48 2012
@@ -48,9 +48,6 @@ import org.apache.tomcat.util.res.String
/**
- * pA strongModelMBean/strong implementation for the
- * codeorg.apache.catalina.core.StandardServer/code component./p
- *
* @author Amy Roh
* @version $Id$
*/
@@ -69,25 +66,6 @@ public class MBeanFactory {
private static final MBeanServer mserver = MBeanUtils.createServer();
-// --- Constructors
-
-
-/**
- * Construct a codeModelMBean/code with default
- * codeModelMBeanInfo/code information.
- *
- * @exception javax.management.MBeanException if the initializer of an
- * object throws an exception
- * @exception javax.management.RuntimeOperationsException if an
- * IllegalArgumentException occurs
- */
-public MBeanFactory() {
-
-super();
-
-}
-
-
// - Attributes
/**
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401103 - in /tomcat/trunk/java/org/apache/catalina/tribes: MembershipService.java transport/PooledSender.java
Author: markt
Date: Mon Oct 22 22:03:00 2012
New Revision: 1401103
URL: http://svn.apache.org/viewvc?rev=1401103view=rev
Log:
Javadoc fixes
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/MembershipService.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/PooledSender.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/MembershipService.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/MembershipService.java?rev=1401103r1=1401102r2=1401103view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/MembershipService.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/MembershipService.java Mon Oct
22 22:03:00 2012
@@ -67,7 +67,6 @@ public interface MembershipService {
* the listener will start to receive membership events.
* @param level - level MBR_RX stops listening for members, level MBR_TX
* stops broad casting the server
- * @throws java.lang.Exception if the service fails to stop
* @throws java.lang.IllegalArgumentException if the level is incorrect.
*/
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/PooledSender.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/PooledSender.java?rev=1401103r1=1401102r2=1401103view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/transport/PooledSender.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/transport/PooledSender.java
Mon Oct 22 22:03:00 2012
@@ -139,16 +139,11 @@ public abstract class PooledSender exten
public void setLimit(int limit) {
this.limit = limit;
}
-/**
- * @return
- */
+
public int getInUsePoolSize() {
return inuse.size();
}
-/**
- * @return
- */
public int getInPoolSize() {
return notinuse.size();
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401104 - /tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
Author: markt
Date: Mon Oct 22 22:04:34 2012
New Revision: 1401104
URL: http://svn.apache.org/viewvc?rev=1401104view=rev
Log:
FindBugs: Protect against NPE
Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1401104r1=1401103r2=1401104view=diff
==
--- tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Mon Oct 22
22:04:34 2012
@@ -678,7 +678,7 @@ public abstract class AbstractProtocol i
sm.getString(abstractConnectionHandler.error), e);
}
// Don't try to add upgrade processors back into the pool
-if (!processor.isUpgrade()) {
+if (processor !=null !processor.isUpgrade()) {
release(socket, processor, true, false);
}
return SocketState.CLOSED;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54010] Suggestion for code improvement (avoiding potential bug)
https://issues.apache.org/bugzilla/show_bug.cgi?id=54010 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Connector:Coyote|Connectors Version|5.5.36 |trunk Product|Tomcat 5|Tomcat 8 Target Milestone|--- | Severity|normal |enhancement --- Comment #1 from Mark Thomas ma...@apache.org --- Tomcat 5.5.x is no longer supported. Looking at the mod_jk, I don't see how there could ever be a problem here but there is scope for removing the additional unnecessary calls. Moving this to Tomcat 8.0.x and marking as an enhancement. This will most likely get be applied to 8.0.x only, as part of the ongoing clean-up of the code base for the 8.0.x branch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401114 - in /tomcat/trunk: java/org/apache/coyote/ajp/AbstractAjpProcessor.java webapps/docs/changelog.xml
Author: markt Date: Mon Oct 22 22:48:38 2012 New Revision: 1401114 URL: http://svn.apache.org/viewvc?rev=1401114view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54010 Remove some unnecessary code (duplicate calls to configure the scheme as https for AJP requests originally received over HTTPS). Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1401114r1=1401113r2=1401114view=diff == --- tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Mon Oct 22 22:48:38 2012 @@ -768,20 +768,17 @@ public abstract class AbstractAjpProcess break; case Constants.SC_A_SSL_CERT : -request.scheme().setString(https); // SSL certificate extraction is lazy, moved to JkCoyoteHandler requestHeaderMessage.getBytes(certificates); break; case Constants.SC_A_SSL_CIPHER : -request.scheme().setString(https); requestHeaderMessage.getBytes(tmpMB); request.setAttribute(SSLSupport.CIPHER_SUITE_KEY, tmpMB.toString()); break; case Constants.SC_A_SSL_SESSION : -request.scheme().setString(https); requestHeaderMessage.getBytes(tmpMB); request.setAttribute(SSLSupport.SESSION_ID_KEY, tmpMB.toString()); Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1401114r1=1401113r2=1401114view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Mon Oct 22 22:48:38 2012 @@ -105,6 +105,11 @@ default value will never go above 2 regardless of available processors. (fhanik) /scode + fix +bug54010/bug: Remove some unnecessary code (duplicate calls to +configure the scheme as https for AJP requests originally received over +HTTPS). (markt) + /fix /changelog /subsection subsection name=Web applications - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54010] Suggestion for code improvement (avoiding potential bug)
https://issues.apache.org/bugzilla/show_bug.cgi?id=54010 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Mark Thomas ma...@apache.org --- Fixed in 8.0.x and will be included in 8.0.0 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54010] Suggestion for code improvement (avoiding potential bug)
https://issues.apache.org/bugzilla/show_bug.cgi?id=54010 --- Comment #3 from Dongcai Shen shensiu...@gmail.com --- Thank Mark for your efforts. The credit of this vulnerability should be given to this bug report: https://issues.apache.org/bugzilla/show_bug.cgi?id=36883 They discovered the bug but only fixed in the httpd site and left the problem in tomcat intact. Now the problem at the tomcat part is also fixed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3481 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1401114 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot
Re: Resources - merging back the changes
2012/10/17 Mark Thomas ma...@apache.org:
On 17/10/2012 15:07, Konstantin Kolinko wrote:
1. Are PreResource and PostResource able to inject individual files?
Not yet, but that should be relatively simple to implement.
2. I am -1 on removal of VirtualWebappLoader.
The feature of injecting additional classpath entries into
WebappClassLoader.super.addURL() is an important one and I use it a
lot to inject external dependent libraries into web applications.
I do not like your approach as a replacement, because classpath
entries handling (jars handling) in URLClassLoader and in
WebappClassLoader is based on different requirements. I think that
URLClassLoader serves better for external libraries
Could you expand on this please. I'm struggling to see the difference
between using the VirtualWebappLoader and mapping JARs into WEB-INF/lib
and directories containing classes onto WEB-INF/classes
There is a difference,
but after thinking about it I am removing my veto.
1. If I consider the following two operations
a. adding a library to the classpath
b. maintaining it as a proper webapplication resource
if a. is all that I need, then having (a. + b.) will have an
additional overhead.
What VirtualWebappLoader does is essentially similar to putting a
library into $CATALINA_BASE/shared.
I know of the following overheads:
1.1.) An additional resource participates in resource lookups
In my use case I insert a dozen of libraries into the classpath. I do
not use VirtualWebappLoader directly, I am calling the API that it
uses - WebappLoader.addRepository().
Looking at the example of Tomcat 7 aliases, if you have 100 aliases
then every resource lookup will perform a linear search through all
the aliases.
Regarding my question of injecting individual files into resources -
maybe it would be better to support collections of individual files
rather than files themselves. E.g. wrap a dozen of libraries into
single collection for /WEB-INF/lib.
This way the individual libraries will be enumerated only when one is
searching for something with a prefix of /WEB-INF/lib. Searching for
any other prefix will skip the libraries.
1.2.) WebappClassLoader#closeJARs(..)
WebappClassLoader closes unused JARs after some time of inactivity.
Discussed here:
https://issues.apache.org/bugzilla/show_bug.cgi?id=52448
I do not see much sense in this jar closing feature. Anyway,
URLClassLoader keeps its jars open.
(Not much of an issue, though. If it were a real nuisance, we can make
it configurable).
2. There will be small difference with handling of
VirtualWebappLoader#setSearchVirtualFirst( ) property.
With VirtualWebappLoader and searchVirtualFirst=true the order of
precedence when looking of a class is
{external classes and libs, webapp classes, webapp libs}.
With webresources I think the order will be different, because
WEB-INF/classes takes precedence over WEB-INF/lib:
{external classes, webapp classes, external libs, webapp libs}.
It is a little nuance. I do not think there will be much confusion from it.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401162 - /tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
Author: kfujino Date: Tue Oct 23 05:08:46 2012 New Revision: 1401162 URL: http://svn.apache.org/viewvc?rev=1401162view=rev Log: Add getSessionIdsFull operation to mbeans-descriptor. listSessionIdsFull no longer exist. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml Modified: tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1401162r1=1401161r2=1401162view=diff == --- tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml (original) +++ tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml Tue Oct 23 05:08:46 2012 @@ -614,10 +614,10 @@ impact=ACTION returnType=java.lang.String/ operation - name=listSessionIdsFull - description=Return the list of active session ids + name=getSessionIdsFull + description=Returns the list of all sessions IDS (primary, backup and proxy). impact=ACTION - returnType=java.lang.String/ + returnType=java.util.Set/ operation name=processExpires description=Invalidate all sessions that have expired.s - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1401163 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/mbeans-descriptors.xml webapps/docs/changelog.xml
Author: kfujino Date: Tue Oct 23 05:14:42 2012 New Revision: 1401163 URL: http://svn.apache.org/viewvc?rev=1401163view=rev Log: Add getSessionIdsFull operation to mbeans-descriptor. listSessionIdsFull no longer exist. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1401163r1=1401162r2=1401163view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml Tue Oct 23 05:14:42 2012 @@ -629,10 +629,10 @@ impact=ACTION returnType=java.lang.String/ operation - name=listSessionIdsFull - description=Return the list of active session ids + name=getSessionIdsFull + description=Returns the list of all sessions IDS (primary, backup and proxy). impact=ACTION - returnType=java.lang.String/ + returnType=java.util.Set/ operation name=processExpires description=Invalidate all sessions that have expired.s Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1401163r1=1401162r2=1401163view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Oct 23 05:14:42 2012 @@ -80,6 +80,14 @@ /fix /changelog /subsection + subsection name=Cluster +changelog + fix +Add getSessionIdsFull operation to mbeans-descriptor. listSessionIdsFull +no longer exist. (kfujino) + /fix +/changelog + /subsection /section section name=Tomcat 7.0.32 (markt) rtext=2012-10-09 subsection name=Catalina - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3482 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1401162 Blamelist: kfujino Build succeeded! sincerely, -The Buildbot
[Bug 54040] New: I found my flex application doesn't work anymore after tomcat version 7.0.27
https://issues.apache.org/bugzilla/show_bug.cgi?id=54040 Priority: P2 Bug ID: 54040 Assignee: dev@tomcat.apache.org Summary: I found my flex application doesn't work anymore after tomcat version 7.0.27 Severity: normal Classification: Unclassified Reporter: charith.c...@gmail.com Hardware: PC Status: NEW Version: 7.0.28 Component: Connectors Product: Tomcat 7 I found my flex application doesn't work anymore after tomcat version 7.0.28. Please help me to get through this. I tried many things without any success. Here is my configurations. Blaze - 4.x Tomcat - Latest - 7.0.28 Java 7 Application just hangs without any error or anything. It works until 7.0.27. I checked tomcat release notes (http://tomcat.apache.org/tomcat-7.0-doc/changelog.html) and isolated problem up to Coyote jar file. When I replace Coyote.jar and catalina.jar from version 7.0.27 to 7.0.28 it works properly. Then I checked only having catalina.jar from previous version still getting this problem. So I think it has something to do with changes done for Coyote. i.e. 52858: Correct fix for high CPU load (fhanik) 53138: Broken Sendfile on SSL introduced in 7.0.27 (fhanik) 52055: Additional fix required to ensure that InputFilters are recycled between requests. (markt) 53061: Fix a problem in the NIO connector whereby if the poller was under low but consistent load (1 request/per second and always less than 1 second between requests) timeouts never took place. (markt) 53063: When using an Executor with BIO, use the executor's maxThreads as the default for maxConnections. (markt) 53119: Prevent buffer overflow errors being reported when a client disconnects before the response has been fully written from an AJP connection using the APR/native connector. (markt) 53169: Allow developers to avoid chunked encoding for a response of unknown length by setting the Connection: close header. Based on a patch suggested by Philippe Marschall. (markt) 53173: Properly count down maxConnections (fhanik) Update default value of pollerThreadCount for the NIO connector. The new default value will never go above 2 regardless of available processors. (fhanik) Allow to retrieve the current connectionCount via getter from the endpoint and as JMX attribute of the ThreadPool mbean. (rjung) Correct an edge case where Comet END events were not send to connected clients when the Tomcat connector was stopped. (markt) 53406: Fix possible stack overflow on connection close when using Comet. (fhanik) Improve InternalNioInputBuffer.parseHeaders(). (kkolinko) Implement maxHeaderCount attribute on Connector. It is equivalent of LimitRequestFields directive of Apache HTTPD. Default value is 100. (kkolinko) Please guide me to a solution. Thanks in advance. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/872 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1401163 Blamelist: kfujino Build succeeded! sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
