Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-10-24 Thread Mark Thomas
On 24/10/2012 00:13, build...@apache.org wrote:
 The Buildbot has detected a new failure on builder tomcat-trunk while 
 building ASF Buildbot.
 Full details are available at:
  http://ci.apache.org/builders/tomcat-trunk/builds/3484
 
 Buildbot URL: http://ci.apache.org/
 
 Buildslave for this Build: bb-vm_ubuntu
 
 Build Reason: scheduler
 Build Source Stamp: [branch tomcat/trunk] 1401503
 Blamelist: markt
 
 BUILD FAILED: failed compile_1

This worked locally on Windows before I did the commit but I didn't test
on Linux. I also see failures locally on Linux. I suspect a \ vs / issue
but I'll dig into this now.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-10-24 Thread Mark Thomas
On 24/10/2012 09:35, Mark Thomas wrote:
 On 24/10/2012 00:13, build...@apache.org wrote:
 The Buildbot has detected a new failure on builder tomcat-trunk while 
 building ASF Buildbot.
 Full details are available at:
  http://ci.apache.org/builders/tomcat-trunk/builds/3484

 Buildbot URL: http://ci.apache.org/

 Buildslave for this Build: bb-vm_ubuntu

 Build Reason: scheduler
 Build Source Stamp: [branch tomcat/trunk] 1401503
 Blamelist: markt

 BUILD FAILED: failed compile_1
 
 This worked locally on Windows before I did the commit but I didn't test
 on Linux. I also see failures locally on Linux. I suspect a \ vs / issue
 but I'll dig into this now.

Nope. I got that bit right :).

The issue is an older svn client that leaves .svn directories all over
the place which then breaks the test.

Looking at options now...

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401584 - /tomcat/trunk/java/org/apache/jasper/JspC.java

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 08:48:45 2012
New Revision: 1401584

URL: http://svn.apache.org/viewvc?rev=1401584view=rev
Log:
Remove uninformative Javadoc

Modified:
tomcat/trunk/java/org/apache/jasper/JspC.java

Modified: tomcat/trunk/java/org/apache/jasper/JspC.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?rev=1401584r1=1401583r2=1401584view=diff
==
--- tomcat/trunk/java/org/apache/jasper/JspC.java (original)
+++ tomcat/trunk/java/org/apache/jasper/JspC.java Wed Oct 24 08:48:45 2012
@@ -1256,8 +1256,6 @@ public class JspC extends Task implement
 
 /**
  * Executes the compilation.
- *
- * @throws JasperException If an error occurs
  */
 @Override
 public void execute() {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2012-10-24 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/3485

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1401584
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot





[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-10-24 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 8.x, a web server implementing Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 35 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-24102012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-24102012.jar:/srv/gump/public/workspace/junit/dist/junit-24102012.jar:/srv/gump/
 
public/workspace/junit/dist/junit-dep-24102012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-14.0-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-24102012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-24102012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-24102012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-24102012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

proxyflags:

setproxy:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar

downloadzip:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 5.7-SNAPSHOT on 2347 files
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/changelog.xml:99: Line 
matches the illegal pattern '\s+$'.

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:469: Got 1 errors and 0 
warnings.

Total time: 34 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 05000624102012, vmgump.apache.org:vmgump:05000624102012
Gump E-mail Identifier (unique within run) #42.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401628 - /tomcat/trunk/webapps/docs/changelog.xml

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 11:39:20 2012
New Revision: 1401628

URL: http://svn.apache.org/viewvc?rev=1401628view=rev
Log:
Whitespace police - thanks Gump

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1401628r1=1401627r2=1401628view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Oct 24 11:39:20 2012
@@ -96,7 +96,7 @@
 Implement a new Resources implementation that merges Aliases,
 VirtualLoader, VirtualDirContext, JAR resources and external
 repositories into a single framework rather than a separate one for 
each
-feature. (markt) 
+feature. (markt)
   /add
 /changelog
   /subsection



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401696 - in /tomcat/trunk: java/org/apache/catalina/webresources/FileResourceSet.java test/org/apache/catalina/webresources/TestFileResourceSet.java

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 14:03:42 2012
New Revision: 1401696

URL: http://svn.apache.org/viewvc?rev=1401696view=rev
Log:
Some leading '/' consistency

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/FileResourceSet.java
tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSet.java

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/FileResourceSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/FileResourceSet.java?rev=1401696r1=1401695r2=1401696view=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/FileResourceSet.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/FileResourceSet.java Wed 
Oct 24 14:03:42 2012
@@ -77,7 +77,7 @@ public class FileResourceSet extends Abs
 public WebResource getResource(String path) {
 checkPath(path);
 
-String webAppMount = '/' + getWebAppMount();
+String webAppMount = getWebAppMount();
 WebResourceRoot root = getRoot();
 if (path.equals(webAppMount)) {
 File f = file(, true);
@@ -97,7 +97,7 @@ public class FileResourceSet extends Abs
 if (path.charAt(path.length() - 1) != '/') {
 path = path + '/';
 }
-String webappMount = '/' + getWebAppMount();
+String webappMount = getWebAppMount();
 
 if (webappMount.startsWith(path)) {
 webappMount = webappMount.substring(path.length());
@@ -117,7 +117,7 @@ public class FileResourceSet extends Abs
 if (path.charAt(path.length() - 1) != '/') {
 path = path + '/';
 }
-String webappMount = '/' + getWebAppMount();
+String webappMount = getWebAppMount();
 
 if (webappMount.startsWith(path)) {
 webappMount = webappMount.substring(path.length());

Modified: 
tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSet.java?rev=1401696r1=1401695r2=1401696view=diff
==
--- tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSet.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSet.java 
Wed Oct 24 14:03:42 2012
@@ -33,19 +33,19 @@ public class TestFileResourceSet extends
 root.setWebResourceSet(webResourceSet);
 
 WebResourceSet f1 = new FileResourceSet(root,
-test/webresources/dir1/f1.txt, f1.txt, );
+test/webresources/dir1/f1.txt, /f1.txt, );
 root.addPreResources(f1);
 
 WebResourceSet f2 = new FileResourceSet(root,
-test/webresources/dir1/f2.txt, f2.txt, );
+test/webresources/dir1/f2.txt, /f2.txt, );
 root.addPreResources(f2);
 
 WebResourceSet d1f1 = new FileResourceSet(root,
-test/webresources/dir1/d1/d1-f1.txt, d1/d1-f1.txt, );
+test/webresources/dir1/d1/d1-f1.txt, /d1/d1-f1.txt, );
 root.addPreResources(d1f1);
 
 WebResourceSet d2f1 = new FileResourceSet(root,
-test/webresources/dir1/d2/d2-f1.txt, d2/d2-f1.txt, );
+test/webresources/dir1/d2/d2-f1.txt, /d2/d2-f1.txt, );
 root.addPreResources(d2f1);
 
 return root;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54046] JVM crashed with EXCEPTION_ACCESS_VIOLATION, problematic frame C [tcnative-1.dll+0x57d0]

2012-10-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54046

Christopher Schultz ch...@christopherschultz.net changed:

   What|Removed |Added

  Attachment #29507|application/octet-stream|text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-10-24 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-taglibs-standard has an issue affecting its community 
integration.
This issue affects 2 projects,
 and has been outstanding for 145 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard :  Standard Taglib
- tomcat-taglibs-standard-install :  JSP Taglibs


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Optional dependency httpunit failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
install 
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
 to 
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing 
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing 
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] 
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO] 
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking 
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource

[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 

svn commit: r1401792 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 17:34:14 2012
New Revision: 1401792

URL: http://svn.apache.org/viewvc?rev=1401792view=rev
Log:
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Fix copy/paste error and use correct attribute name
Based on a patch by Sheldon Shao

Modified:
tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java

Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java?rev=1401792r1=1401791r2=1401792view=diff
==
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java Wed Oct 
24 17:34:14 2012
@@ -67,7 +67,7 @@ public final class Out implements TagPlu
 ctxt.generateJavaSource(boolean  + strEscapeXmlName +  = true;);
 if(hasEscapeXml){
 ctxt.generateJavaSource(strEscapeXmlName +  = 
Boolean.parseBoolean(();
-ctxt.generateAttribute(default);
+ctxt.generateAttribute(escapeXml);
 ctxt.generateJavaSource().toString()););
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401808 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 18:19:16 2012
New Revision: 1401808

URL: http://svn.apache.org/viewvc?rev=1401808view=rev
Log:
Remainder of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Value is coerced to boolean in ctx.generateAttribute() so no need for 
additional conversion
Based on a patch by Sheldon Shao

Modified:
tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java

Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java?rev=1401808r1=1401807r2=1401808view=diff
==
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java Wed Oct 
24 18:19:16 2012
@@ -66,9 +66,9 @@ public final class Out implements TagPlu
 //if the escapeXml is specified, assign the value to it;
 ctxt.generateJavaSource(boolean  + strEscapeXmlName +  = true;);
 if(hasEscapeXml){
-ctxt.generateJavaSource(strEscapeXmlName +  = 
Boolean.parseBoolean(();
+ctxt.generateJavaSource(strEscapeXmlName +  = );
 ctxt.generateAttribute(escapeXml);
-ctxt.generateJavaSource().toString()););
+ctxt.generateJavaSource(;);
 }
 
 //main part.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401813 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/tagplugins/jstl/core/Out.java webapps/docs/changelog.xml

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 18:25:47 2012
New Revision: 1401813

URL: http://svn.apache.org/viewvc?rev=1401813view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Fix copy/paste error and use correct attribute name
Value is coerced to boolean in ctx.generateAttribute() so no need for 
additional conversion
Patch by Sheldon Shao

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1401792,1401808

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java?rev=1401813r1=1401812r2=1401813view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java 
Wed Oct 24 18:25:47 2012
@@ -66,9 +66,9 @@ public final class Out implements TagPlu
 //if the escapeXml is specified, assign the value to it;
 ctxt.generateJavaSource(boolean  + strEscapeXmlName +  = true;);
 if(hasEscapeXml){
-ctxt.generateJavaSource(strEscapeXmlName +  = 
Boolean.parseBoolean(();
-ctxt.generateAttribute(default);
-ctxt.generateJavaSource().toString()););
+ctxt.generateJavaSource(strEscapeXmlName +  = );
+ctxt.generateAttribute(escapeXml);
+ctxt.generateJavaSource(;);
 }
 
 //main part. 

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1401813r1=1401812r2=1401813view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Oct 24 18:25:47 2012
@@ -78,6 +78,12 @@
 any similar sequence with a odd number of - characters) was not
 correctly parsed. (markt)
   /fix
+  fix
+bug54011/bug: Fix a bug in the tag plug-in for
+codelt;c:outgt;/code that triggered a JSP compilation error if 
the
+codeescapeXml/code attribute was used. Patch provided by Sheldon
+Shao. (markt)
+  /fix
 /changelog
   /subsection
   subsection name=Cluster



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401814 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 18:32:56 2012
New Revision: 1401814

URL: http://svn.apache.org/viewvc?rev=1401814view=rev
Log:
Follow up to https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Simplify code.
Based on a patch by Sheldon Shao

Modified:
tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java

Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java?rev=1401814r1=1401813r2=1401814view=diff
==
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java Wed Oct 
24 18:32:56 2012
@@ -18,6 +18,10 @@
 
 package org.apache.jasper.tagplugins.jstl.core;
 
+import java.io.IOException;
+
+import javax.servlet.jsp.JspWriter;
+
 import org.apache.jasper.compiler.tagplugin.TagPlugin;
 import org.apache.jasper.compiler.tagplugin.TagPluginContext;
 
@@ -72,20 +76,20 @@ public final class Out implements TagPlu
 }
 
 //main part.
-ctxt.generateJavaSource(if(null !=  + strValName +){);
-ctxt.generateJavaSource(if( + strEscapeXmlName + ){);
-ctxt.generateJavaSource( + strValName +  = 
org.apache.jasper.tagplugins.jstl.Util.escapeXml( + strValName + ););
-ctxt.generateJavaSource(});
-ctxt.generateJavaSource(out.write( + strValName + ););
-ctxt.generateJavaSource(}else{);
-ctxt.generateJavaSource(if(null !=  + strDefName + ){);
-ctxt.generateJavaSource(if( + strEscapeXmlName + ){);
-ctxt.generateJavaSource( + strDefName +  = 
org.apache.jasper.tagplugins.jstl.Util.escapeXml( + strDefName + ););
-ctxt.generateJavaSource(});
-ctxt.generateJavaSource(out.write( + strDefName + ););
-ctxt.generateJavaSource(}else{);
-ctxt.generateBody();
-ctxt.generateJavaSource(});
-ctxt.generateJavaSource(});
+ctxt.generateJavaSource(
+org.apache.jasper.tagplugins.jstl.core.Out.output(out,  +
+strValName + ,  + strDefName + ,  + strEscapeXmlName +
+););
+}
+
+public static void output(JspWriter out, String value, String defaultValue,
+boolean escapeXml) throws IOException {
+String v = value != null ? value : defaultValue;
+if (v != null) {
+if(escapeXml){
+v = org.apache.jasper.tagplugins.jstl.Util.escapeXml(v);
+}
+out.write(v);
+}
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401816 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/tagplugins/jstl/core/Out.java webapps/docs/changelog.xml

2012-10-24 Thread markt
Author: markt
Date: Wed Oct 24 18:36:01 2012
New Revision: 1401816

URL: http://svn.apache.org/viewvc?rev=1401816view=rev
Log:
Follow up to https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Simplify code.
Based on a patch by Sheldon Shao

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1401814

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java?rev=1401816r1=1401815r2=1401816view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/tagplugins/jstl/core/Out.java 
Wed Oct 24 18:36:01 2012
@@ -18,6 +18,10 @@
 
 package org.apache.jasper.tagplugins.jstl.core;
 
+import java.io.IOException;
+
+import javax.servlet.jsp.JspWriter;
+
 import org.apache.jasper.compiler.tagplugin.TagPlugin;
 import org.apache.jasper.compiler.tagplugin.TagPluginContext;
 
@@ -72,20 +76,20 @@ public final class Out implements TagPlu
 }
 
 //main part. 
-ctxt.generateJavaSource(if(null !=  + strValName +){);
-ctxt.generateJavaSource(if( + strEscapeXmlName + ){);
-ctxt.generateJavaSource( + strValName +  = 
org.apache.jasper.tagplugins.jstl.Util.escapeXml( + strValName + ););
-ctxt.generateJavaSource(});
-ctxt.generateJavaSource(out.write( + strValName + ););
-ctxt.generateJavaSource(}else{);
-ctxt.generateJavaSource(if(null !=  + strDefName + ){);
-ctxt.generateJavaSource(if( + strEscapeXmlName + ){);
-ctxt.generateJavaSource( + strDefName +  = 
org.apache.jasper.tagplugins.jstl.Util.escapeXml( + strDefName + ););
-ctxt.generateJavaSource(});
-ctxt.generateJavaSource(out.write( + strDefName + ););
-ctxt.generateJavaSource(}else{);
-ctxt.generateBody();
-ctxt.generateJavaSource(});
-ctxt.generateJavaSource(});   
+ctxt.generateJavaSource(
+org.apache.jasper.tagplugins.jstl.core.Out.output(out,  +
+strValName + ,  + strDefName + ,  + strEscapeXmlName +
+););
+}
+
+public static void output(JspWriter out, String value, String defaultValue,
+boolean escapeXml) throws IOException {
+String v = value != null ? value : defaultValue;
+if (v != null) {
+if(escapeXml){
+v = org.apache.jasper.tagplugins.jstl.Util.escapeXml(v);
+}
+out.write(v);
+}
 }
 }

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1401816r1=1401815r2=1401816view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Oct 24 18:36:01 2012
@@ -84,6 +84,10 @@
 codeescapeXml/code attribute was used. Patch provided by Sheldon
 Shao. (markt)
   /fix
+  scode
+Follow up to bug54011/bug. Simplify generated code for
+codelt;c:outgt;/code. Based on a patch by Sheldon Shao. (markt)
+  /scode
 /changelog
   /subsection
   subsection name=Cluster



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of FAQ/Connectors by ChristopherSchultz

2012-10-24 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The FAQ/Connectors page has been changed by ChristopherSchultz:
http://wiki.apache.org/tomcat/FAQ/Connectors?action=diffrev1=13rev2=14

Comment:
Re-arranged Which Connector question and added some additional information.

  
  BR
  
- Anchor(Q2)'''Which connector: mod_jserv, JK, JK2, mod_webapp or 
mod_proxy?'''
+ Anchor(Q2)'''Which connector: mod_jk or mod_proxy?'''
  
+  * mod_jk is mature, stable and extremely flexible. It is under active 
development by members of the Tomcat community.
+  * mod_proxy_ajp is distributed with Apache httpd 2.2 and later. Note that 
the communication protocol used is AJP.
+  * mod_proxy_http is a cheap way to proxy without the hassles of configuring 
JK. If you don't need some of the features of mod_jk, this is a very simple 
alternative. Note that the communication protocol used is HTTP.
+ 
+ Here are some anecdotal comments from members of the Tomcat community:
+ 
+ ''
+ I have been using mod_jk for a very long time and I saw (at the time)
+ only one reason to make the switch to mod_proxy_ajp: it is bundled
+ with Apache and so you (likely) don't have to build the module yourself.
+ 
+ That said, simple configurations are *way* more simple in
+ mod_proxy_ajp than with mod_jk, although the (somewhat) recent
+ addition of JkWorkerProperty and JkMount extensions do help quite a bit.
+ 
+ mod_proxy_ajp can also be trivially swapped-out with mod_proxy_http
+ just by changing the URLs in your ProxyPass and ProxyPassReverse
+ directives to say http:// (or https://) instead of ajp://. This might
+ help you if you need to switch protocols for debugging purposes or if
+ you suddenly need switch to HTTPS to secure the traffic without any
+ external configuration (e.g. stunnel or VPN).
+ 
+ mod_proxy also supports ProxyPassMatch which lets you use regular
+ expressions in your URL mappings, which mod_jk's JkMount does not
+ (though you *can* use LocationMatch along with SetHandler in order
+ to achieve the same result, it's a cleaner configuration with mod_proxy).
+ 
+ That said, I have found that mod_jk supports more complicated
+ configurations where I have struggled to get mod_proxy_ajp to do the
+ same. Specifically, overlapping URL spaces that must be mapped to
+ separate workers. Technically speaking, I suppose you could use lots
+ of ProxyPassMatch directives and/or have a complex regular expression
+ to direct the various URLs, but again you end up with a rather messy
+ configuration that way. Messy configurations are a maintenance risk as
+ well as at risk of becoming arcane knowledge that nobody actually
+ understands and so they are afraid to modify it for any reason.
+ 
+ Generally, mod_jk will get fixed faster than mod_proxy_ajp due to its
+ independent release cycle: the httpd folks might have a fix for a
+ problem but it doesn't get released for a while due to testing of
+ other components, etc. At this point, mod_proxy_ajp has (IMHO) reached
+ a point of stability that this is less of an issue than it used to be.
+ 
+ At this stage, there is no reason for me to move any of my projects
+ from mod_jk to mod_proxy_ajp but if I were starting from scratch, I
+ might choose mod_proxy_ajp solely due to its binary availability and
+ simple configuration. If the configuration became complicated to the
+ extent that switching to mod_jk were a good option, then I'd move.
+ 
+ As for performance, I have no data on that one way or another. I would
+ suspect that mod_jk has a slight performance advantage because it has
+ been especially designed for the purpose rather than mod_proxy_ajp
+ which must support the mod_proxy API and might have a bit more
+ plumbing code to accomplish that. I would be surprised if you could
+ detect any performance difference between the two if you were to test
+ them both faithfully and with compatible configurations. If anyone has
+ relative performance data between mod_jk and mod_proxy_ajp, I'd be
+ happy to read it.
+ ''
+ (http://markmail.org/message/u5v4aiejluzy7tde)
+ BR
+ 
+ Anchor(Q2.1)'''What about mod_jserv, mod_jk2, mod_webapp (aka warp)?'''
+ 
+ '''All of these connectors have been abandoned long ago. Do not use any of 
them.'''
+ 
+ mod_jk2 sounds like it could be an updated version of mod_jk, it is not: it 
was an abortive effort whose features have been re-incorporated into mod_jk.
+ 
+ For historical purposes, and emphasis:
+ 
+  * mod_jserv is unsupported and will not be supported in Tomcat 5 onward. 
mod_jserv was the original connector which supported the ajp protocol. '''Do 
not use mod_jserv.'''
   * Stay away from mod_webapp, aka warp. It is deprecated and unsupported due 
to lack of developer interest and there are better options such as jk and 
mod_proxy. It WILL NOT run on windows. '''Do not use mod_webapp or warp.'''
-  * mod_jserv is unsupported and will not be supported in Tomcat 5. mod_jserv 
was the original 

[Tomcat Wiki] Update of FAQ/Connectors by ChristopherSchultz

2012-10-24 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The FAQ/Connectors page has been changed by ChristopherSchultz:
http://wiki.apache.org/tomcat/FAQ/Connectors?action=diffrev1=14rev2=15

Comment:
Forgot to update TOC.

  '''Please note, jk2 is no longer supported. Please use mod_jk instead.'''
  == Questions ==
   1. [[#Q1|What is JK (or AJP)?]]
-  1. [[#Q2|Which connector: mod_jserv, JK, JK2, mod_webapp or mod_proxy?]]
+  1. [[#Q2|Which connector: mod_jk or mod_proxy?]]
+  1. [[#Q2.1|What about mod_jserv, mod_jk2, mod_webapp (aka warp)?]]
   1. [[#Q3|Why should I integrate Apache with Tomcat? (or not)]]
   1. [[#Q4|At boot, is order of start up (Apache vs Tomcat) important?]]
   1. [[#Q5|Is there any way to control the content of automatically generated 
mod_jk.conf-auto?]]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54044] AccessLogValve using stale date/time with SimpleDateFormat

2012-10-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54044

--- Comment #3 from Casey Lucas clu...@e-miles.com ---
I changed log format to the one requested (had to add a 't' to the after
{begin} and {end}:

%{X-Tomcat-Session}i,%S,%{X-Forwarded-For}i,%h,%u,%{begin:-MM-dd
HH:mm:ss.SSSZ}t,quot;%rquot;,%s,%b,%p,%{Referer}i,quot;%{User-Agent}iquot;,%T,%{begin}t,%{end}t,%{end:-MM-dd
HH:mm:ss.SSSZ}t,%D

The stuck/incorrect times in the data below are 10:00:04 and 10:05:40.  The
actual timespan was between 11:01:59 and 11:02:01. You can see that these are
not long duration requests (all less than a second.)


... ,2012-10-24 11:01:59.288-0500,GET ... ,0.080,[24/Oct/2012:11:01:59
-0500],[24/Oct/2012:11:01:59 -0500],2012-10-24 11:01:59.368-0500,80
... ,2012-10-24 11:01:59.568-0500,GET ... ,0.006,[24/Oct/2012:11:01:59
-0500],[24/Oct/2012:11:01:59 -0500],2012-10-24 11:01:59.574-0500,6
... ,2012-10-24 11:01:59.755-0500,POST ... ,0.246,[24/Oct/2012:11:01:59
-0500],[24/Oct/2012:11:02:00 -0500],2012-10-24 11:02:00.001-0500,246
... ,2012-10-24 10:05:40.932-0500,GET ... ,0.088,[24/Oct/2012:10:05:40
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.020-0500,88
... ,2012-10-24 10:00:04.020-0500,GET ... ,0.002,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.022-0500,2
... ,2012-10-24 11:01:59.753-0500,GET ... ,0.313,[24/Oct/2012:11:01:59
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.066-0500,313
... ,2012-10-24 10:00:04.072-0500,GET ... ,0.001,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.073-0500,1
... ,2012-10-24 10:05:40.813-0500,POST ... ,0.427,[24/Oct/2012:10:05:40
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.240-0500,427
... ,2012-10-24 10:00:04.227-0500,GET ... ,0.079,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.306-0500,79
... ,2012-10-24 11:02:00.370-0500,GET ... ,0.013,[24/Oct/2012:11:02:00
-0500],[24/Oct/2012:11:02:00 -0500],2012-10-24 11:02:00.383-0500,13
... ,2012-10-24 11:02:00.398-0500,GET ... ,0.001,[24/Oct/2012:11:02:00
-0500],[24/Oct/2012:11:02:00 -0500],2012-10-24 11:02:00.399-0500,1
... ,2012-10-24 11:02:00.684-0500,GET ... ,0.011,[24/Oct/2012:11:02:00
-0500],[24/Oct/2012:11:02:00 -0500],2012-10-24 11:02:00.695-0500,11
... ,2012-10-24 10:00:04.379-0500,GET ... ,0.369,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.748-0500,369
... ,2012-10-24 10:00:04.363-0500,GET ... ,0.387,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.750-0500,387
... ,2012-10-24 10:00:04.922-0500,GET ... ,0.003,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.925-0500,3
... ,2012-10-24 10:00:04.972-0500,GET ... ,0.001,[24/Oct/2012:10:00:04
-0500],[24/Oct/2012:10:00:04 -0500],2012-10-24 10:00:04.973-0500,1
... ,2012-10-24 11:02:01.089-0500,GET ... ,0.001,[24/Oct/2012:11:02:01
-0500],[24/Oct/2012:11:02:01 -0500],2012-10-24 11:02:01.090-0500,1
... ,2012-10-24 11:02:01.088-0500,GET ... ,0.008,[24/Oct/2012:11:02:01
-0500],[24/Oct/2012:11:02:01 -0500],2012-10-24 11:02:01.096-0500,8

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-10-24 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/874

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1401813
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54011] Code generation error in jstl tagPlugin Out when has escapeXml on the tagPlugin

2012-10-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Thomas ma...@apache.org ---
Many thanks for the patches. I modified the clean-up slightly and added some
test cases for trunk.

The fix was applied to trunk and 7.0.x and will be included in 7.0.33 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1401867 [3/3] - in /tomcat/sandbox/storeconfig7: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/catalina/ src/main/java/org/apache/

2012-10-24 Thread remm
Added: 
tomcat/sandbox/storeconfig7/src/main/java/org/apache/catalina/storeconfig/StoreLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/storeconfig7/src/main/java/org/apache/catalina/storeconfig/StoreLoader.java?rev=1401867view=auto
==
--- 
tomcat/sandbox/storeconfig7/src/main/java/org/apache/catalina/storeconfig/StoreLoader.java
 (added)
+++ 
tomcat/sandbox/storeconfig7/src/main/java/org/apache/catalina/storeconfig/StoreLoader.java
 Wed Oct 24 20:38:57 2012
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.storeconfig;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URL;
+
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import org.apache.tomcat.util.digester.Digester;
+import org.xml.sax.SAXException;
+
+/**
+ * 
+ * @author Peter Rossbach
+ * 
+ * bXML Format /b
+ * 
+ * pre
+ *
+ *   lt;Registry name=quot;quot; encoding=quot;UTF8quot; gt;
+ *   lt;Description tag=quot;Serverquot; standard=quot;truequot; 
default=quot;truequot;/gt; 
+ *  tagClass=quot;org.apache.catalina.core.StandardServerquot;
+ *  
storeFactory=quot;org.apache.catalina.storeconfig.StandardServerSFquot;gt;
+ *lt;TransientAttributesgt;
+ *  lt;Attributegt;lt;/Attributegt;
+ *lt;/TransientAttributesgt;
+ *lt;TransientChildsgt;
+ *  lt;Childgt;lt;/Childgt;
+ *lt;/TransientChildsgt;
+ *   lt;/Descriptiongt;
+ *   ...
+ *   lt;/Tegistrygt;
+ * 
+ * /pre
+ * 
+ * 
+ * Convention:
+ * ul
+ * liFactories at subpackage iorg.apache.catalina.core.storeconfig.xxxSF
+ * /i./li
+ * liElement name are the unique Class name/li
+ * liSF for StoreFactory/li
+ * listandard implementation is false/li
+ * /ul
+ * other things:
+ * ul
+ * liRegistry XML format is a very good option/li
+ * liStore format is not fix/li
+ * liWe hope with the parent declaration we can build recursive child store
+ * operation //dream/li
+ * liProblem is to access child data from array,collections or normal detail
+ * object/li
+ * liDefault definitions for Listener, Valve Resource? - Based on interface
+ * type!/li
+ * /ul
+ */
+public class StoreLoader {
+private static Log log = LogFactory.getLog(StoreLoader.class);
+
+/**
+ * The codeDigester/code instance used to parse registry descriptors.
+ */
+protected static Digester digester = createDigester();
+
+private StoreRegistry registry;
+
+private URL registryResource ;
+
+/**
+ * @return Returns the registry.
+ */
+public StoreRegistry getRegistry() {
+return registry;
+}
+
+/**
+ * @param registry
+ *The registry to set.
+ */
+public void setRegistry(StoreRegistry registry) {
+this.registry = registry;
+}
+
+/**
+ * Create and configure the Digester we will be using for setup store
+ * registry.
+ */
+protected static Digester createDigester() {
+long t1 = System.currentTimeMillis();
+// Initialize the digester
+Digester digester = new Digester();
+digester.setValidating(false);
+digester.setClassLoader(StoreRegistry.class.getClassLoader());
+
+// Configure the actions we will be using
+digester.addObjectCreate(Registry,
+org.apache.catalina.storeconfig.StoreRegistry, className);
+digester.addSetProperties(Registry);
+digester
+.addObjectCreate(Registry/Description,
+org.apache.catalina.storeconfig.StoreDescription,
+className);
+digester.addSetProperties(Registry/Description);
+digester.addRule(Registry/Description, new StoreFactoryRule(
+org.apache.catalina.storeconfig.StoreFactoryBase,
+storeFactoryClass,
+org.apache.catalina.storeconfig.StoreAppender,
+storeAppenderClass));
+digester.addSetNext(Registry/Description, registerDescription,
+

[jira] [Created] (MTOMCAT-183) java.lang.NoSuchMethodError: javax.xml.stream.XMLInputFactory.newFactory() error for 2.1-SNAPSHOT and 2.0-RELEASE

2012-10-24 Thread ZHANG Frank (JIRA)
ZHANG Frank created MTOMCAT-183:
---

 Summary: java.lang.NoSuchMethodError: 
javax.xml.stream.XMLInputFactory.newFactory()  error for 2.1-SNAPSHOT and 
2.0-RELEASE
 Key: MTOMCAT-183
 URL: https://issues.apache.org/jira/browse/MTOMCAT-183
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat7
Affects Versions: 2.0
 Environment: os: win7-64x  jdk: jdk1.6.0_12  maven:apache-maven-3.0.4 
Reporter: ZHANG Frank
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.1


when run tomcat7:run, errors as follow:
...
urls[45] = 
file:/C:/Users/Administrator/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
urls[46] = 
file:/C:/Users/Administrator/.m2/repository/org/sonatype/plexus/plexus-build-api/0.0.4/plexus-build-api-0.0.4.jar
Number of foreign imports: 1
import: Entry[import  from realm ClassRealm[maven.api, parent: null]]

-

at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:139)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: org.apache.maven.plugin.PluginContainerException: An API 
incompatibility was encountered while executing 
org.apache.tomcat.maven:tomcat7-maven-plugin:2.1-SNAPSHOT:run: 
java.lang.NoSuchMethodError: 
javax.xml.stream.XMLInputFactory.newFactory()Ljavax/xml/stream/XMLInputFactory;
-
realm =pluginorg.apache.tomcat.maven:tomcat7-maven-plugin:2.1-SNAPSHOT
strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
urls[0] = 
file:/C:/Users/Administrator/.m2/repository/org/apache/tomcat/maven/tomcat7-maven-plugin/2.1-SNAPSHOT/tomcat7-maven-plugin-2.1-SNAPSHOT.jar
urls[1] = 
file:/C:/Users/Administrator/.m2/repository/org/apache/tomcat/embed/tomcat-embed-core/7.0.32/tomcat-embed-core-7.0.32.jar
urls[2] = 
file:/C:/Users/Administrator/.m2/repository/org/apache/tomcat/tomcat-util/7.0.32/tomcat-util-7.0.32.jar
...

urls[45] = 
file:/C:/Users/Administrator/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
urls[46] = 
file:/C:/Users/Administrator/.m2/repository/org/sonatype/plexus/plexus-build-api/0.0.4/plexus-build-api-0.0.4.jar
Number of foreign imports: 1
import: Entry[import  from realm ClassRealm[maven.api, parent: null]]

-

at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
... 20 more
Caused by: java.lang.NoSuchMethodError: 
javax.xml.stream.XMLInputFactory.newFactory()Ljavax/xml/stream/XMLInputFactory;
at 
org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.parseContextFile(AbstractRunMojo.java:589)
at 
org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.createContext(AbstractRunMojo.java:539)
at 
org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:929)
at 
org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:478)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
... 20 more
[ERROR] 

and when using tomcat7-maven-plugin 2.0-SNAPSHOT  version. it's ok.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org