[Bug 54144] New: Processing of java.io.Reader in Out tagplugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=54144 Priority: P2 Bug ID: 54144 Assignee: dev@tomcat.apache.org Summary: Processing of java.io.Reader in Out tagplugin Severity: minor Classification: Unclassified OS: Windows XP Reporter: knst.koli...@gmail.com Hardware: PC Status: NEW Version: 7.0.32 Component: Jasper Product: Tomcat 7 Reviewing r1401816 I see two issues in tagplugin o.a.jasper.tagplugins.jstl.core.Out: The code that the plugin generates calls value.toString(), default.toString() and passes these String values to the static method Out.output(...). This new method was added in r1401816. I think the output() method should accept Objects instead of Strings, because the following is wrong: 1. The evaluation of default.toString() is not needed at all if the default is not used. 2. The JSTL spec (1.1, 1.2) says that there is special processing if value is java.io.Reader. There is no such processing in the current code. (It seems that this feature was added in JSTL 1.1). [quote] If the result of the evaluation is not a java.io.Reader object, then it is coerced to a String and is subsequently emitted into the current JspWriter object. If the result of the evaluation is a java.io.Reader object, data is first read from the Reader object and then written into the current JspWriter object. [/quote] These two issues are not new - they existed before the recent changes. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409127 - in /tomcat/tc7.0.x/trunk: java/org/apache/naming/resources/BaseDirContext.java webapps/docs/changelog.xml
Author: kkolinko Date: Wed Nov 14 09:53:04 2012 New Revision: 1409127 URL: http://svn.apache.org/viewvc?rev=1409127view=rev Log: Revert additional of final modifiers to BaseDirContext.List() that was done in r1392099. It was an API change that breaks compilation of derived classes. Especially the change of an abstract method into a final one. This class is already removed from trunk, so no need to follow up there. Modified: tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java?rev=1409127r1=1409126r2=1409127view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/BaseDirContext.java Wed Nov 14 09:53:04 2012 @@ -659,7 +659,7 @@ public abstract class BaseDirContext imp * @exception NamingException if a naming exception is encountered */ @Override -public final NamingEnumerationNameClassPair list(Name name) +public NamingEnumerationNameClassPair list(Name name) throws NamingException { return list(name.toString()); } @@ -675,7 +675,7 @@ public abstract class BaseDirContext imp * @exception NamingException if a naming exception is encountered */ @Override -public final NamingEnumerationNameClassPair list(String name) +public NamingEnumerationNameClassPair list(String name) throws NamingException { if (!aliases.isEmpty()) { Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1409127r1=1409126r2=1409127view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Nov 14 09:53:04 2012 @@ -153,6 +153,10 @@ from 2 to 3 by default and make the limit configurable via a system property. (markt) /fix + fix +Revert occasional API change in codeBaseDirContext/code class that +was done in 7.0.32. Methods should not be codefinal/code. (kkolinko) + /fix /changelog /subsection subsection name=Coyote - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-185) Possibly wrong execution phase in tomcat7:run
Jiri Peinlich created MTOMCAT-185: - Summary: Possibly wrong execution phase in tomcat7:run Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-185: --- Fix Version/s: 2.1 Summary: change phase for tomcat6/7:run to process-classes (was: Possibly wrong execution phase in tomcat7:run) change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409194 - in /tomcat/maven-plugin/trunk: tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/
Author: olamy Date: Wed Nov 14 13:35:14 2012 New Revision: 1409194 URL: http://svn.apache.org/viewvc?rev=1409194view=rev Log: [MTOMCAT-185] change phase for tomcat6/7:run to process-classes Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java?rev=1409194r1=1409193r2=1409194view=diff == --- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java (original) +++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java Wed Nov 14 13:35:14 2012 @@ -57,7 +57,7 @@ import java.util.Set; * @author Mark Hobson markhob...@gmail.com */ @Mojo( name = run, requiresDependencyResolution = ResolutionScope.TEST ) -@Execute( phase = LifecyclePhase.COMPILE ) +@Execute( phase = LifecyclePhase.PROCESS_CLASSES ) public class RunMojo extends AbstractRunMojo { Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?rev=1409194r1=1409193r2=1409194view=diff == --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java (original) +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java Wed Nov 14 13:35:14 2012 @@ -57,7 +57,7 @@ import java.util.Set; * @since 2.0 */ @Mojo( name = run, requiresDependencyResolution = ResolutionScope.TEST ) -@Execute( phase = LifecyclePhase.COMPILE ) +@Execute( phase = LifecyclePhase.PROCESS_CLASSES ) public class RunMojo extends AbstractRunMojo { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community integration. This issue affects 2 projects, and has been outstanding for 183 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-taglibs-standard : Standard Taglib - tomcat-taglibs-standard-install : JSP Taglibs Full details are available at: http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Optional dependency httpunit failed with reason build failed -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build) Work ended in a state of : Failed Elapsed: 22 secs Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings /srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml install [Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard] M2_HOME: /opt/maven2 - [INFO] [compiler:compile {execution: default-compile}] [INFO] Nothing to compile - all classes are up to date [debug] execute contextualize [INFO] [resources:testResources {execution: default-testResources}] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources [INFO] Copying 3 resources [INFO] [compiler:testCompile {execution: default-testCompile}] [INFO] No sources to compile [INFO] [surefire:test {execution: default-test}] [INFO] Tests are skipped. [INFO] [bundle:bundle {execution: default-bundle}] [INFO] [install:install {execution: default-install}] [INFO] Installing /srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar to /srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar [INFO] [bundle:install {execution: default-install}] [INFO] Parsing file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml [INFO] Installing org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar [INFO] Writing OBR metadata [INFO] [INFO] Building JSTL Implementation [INFO]task-segment: [install] [INFO] [INFO] [remote-resources:process {execution: default}] [INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking for updates from apache.snapshots [debug] execute contextualize [INFO] [resources:resources {execution: default-resources}] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 14 resources [INFO] Copying 3 resources [INFO] [compiler:compile {execution: default-compile}] [INFO] Compiling 96 source files to /srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7] error: DataSourceWrapper is not abstract and does not override abstract method getParentLogger() in CommonDataSource [INFO] 1 error [INFO] - [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7] error: DataSourceWrapper is not abstract and does not override abstract method getParentLogger() in CommonDataSource [INFO] [INFO] For more information, run Maven with the -e switch [INFO]
[jira] [Closed] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-185. -- Resolution: Fixed Yup I agree it's a better phase especially for your use cad :-) So I change that. change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409200 - in /tomcat/maven-plugin/trunk/src/site/apt: snapshot-test.apt snapshot-test.apt.vm
Author: olamy Date: Wed Nov 14 13:42:33 2012 New Revision: 1409200 URL: http://svn.apache.org/viewvc?rev=1409200view=rev Log: make this file more dynamic for diplaying current version Added: tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vm (contents, props changed) - copied, changed from r1409194, tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt Removed: tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt Copied: tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vm (from r1409194, tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt) URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vm?p2=tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vmp1=tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.aptr1=1409194r2=1409200rev=1409200view=diff == --- tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt (original) +++ tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vm Wed Nov 14 13:42:33 2012 @@ -3,7 +3,7 @@ --- Oliver Lamy --- - 2011-10-08 + 2012-11-14 --- ~~ Licensed to the Apache Software Foundation (ASF) under one @@ -37,7 +37,7 @@ Testing SNAPSHOT repositories repository idapache.snapshots/id - urlhttp://repository.apache.org/content/groups/snapshots-group//url + urlhttp://repository.apache.org/content/repositories/snapshots/url releases enabledfalse/enabled /releases @@ -51,7 +51,7 @@ Testing SNAPSHOT pluginRepository idapache.snapshots/id nameApache Snapshots/name - urlhttp://repository.apache.org/content/groups/snapshots-group//url + urlhttp://repository.apache.org/content/repositories/snapshots/url releases enabledfalse/enabled /releases @@ -73,7 +73,7 @@ Testing SNAPSHOT plugin groupIdorg.apache.tomcat.maven/groupId artifactIdtomcat6-maven-plugin/artifactId - version2.0-SNAPSHOT/version + version${project.version}/version configuration path//path /configuration @@ -81,7 +81,7 @@ Testing SNAPSHOT plugin groupIdorg.apache.tomcat.maven/groupId artifactIdtomcat7-maven-plugin/artifactId - version2.0-SNAPSHOT/version + version${project.version}/version configuration path//path /configuration Propchange: tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vm -- svn:eol-style = native Propchange: tomcat/maven-plugin/trunk/src/site/apt/snapshot-test.apt.vm -- svn:keywords = Author Date Id Revision - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409201 [4/14] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/common
(Apache Tomcat Maven Plugin 2.1-SNAPSHOT API) /TITLE -META NAME=date CONTENT=2012-11-07 +META NAME=date CONTENT=2012-11-14 LINK REL =stylesheet TYPE=text/css HREF=stylesheet.css TITLE=Style Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/apidocs/serialized-form.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/apidocs/serialized-form.html?rev=1409201r1=1409200r2=1409201view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/apidocs/serialized-form.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/apidocs/serialized-form.html Wed Nov 14 13:43:40 2012 @@ -2,13 +2,13 @@ !--NewPage-- HTML HEAD -!-- Generated by javadoc (build 1.6.0_24) on Wed Nov 07 16:45:09 EST 2012 -- +!-- Generated by javadoc (build 1.6.0_24) on Wed Nov 14 08:38:31 EST 2012 -- META http-equiv=Content-Type content=text/html; charset=UTF-8 TITLE Serialized Form (Apache Tomcat Maven Plugin 2.1-SNAPSHOT API) /TITLE -META NAME=date CONTENT=2012-11-07 +META NAME=date CONTENT=2012-11-14 LINK REL =stylesheet TYPE=text/css HREF=stylesheet.css TITLE=Style Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/archetype.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/archetype.html?rev=1409201r1=1409200r2=1409201view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/archetype.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/archetype.html Wed Nov 14 13:43:40 2012 @@ -1,6 +1,6 @@ !DOCTYPE html !-- - | Generated by Apache Maven Doxia at Nov 7, 2012 + | Generated by Apache Maven Doxia at Nov 14, 2012 | Rendered using Apache Maven Fluido Skin 1.3.0 -- html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en @@ -9,7 +9,7 @@ meta name=viewport content=width=device-width, initial-scale=1.0 / meta name=author content=Oliver Lamy / meta name=Date-Creation-mmdd content=20110113 / -meta name=Date-Revision-mmdd content=20121107 / +meta name=Date-Revision-mmdd content=20121114 / meta http-equiv=Content-Language content=en / titleApache Tomcat Maven Plugin - Tomcat Maven plugin Archetype/title link rel=stylesheet href=./css/apache-maven-fluido-1.3.0.min.css / @@ -228,7 +228,7 @@ - li id=publishDate class=pull-rightLast Published: 07 November 2012/li li class=divider pull-right|/li + li id=publishDate class=pull-rightLast Published: 14 November 2012/li li class=divider pull-right|/li li id=projectVersion class=pull-rightVersion: 2.1-SNAPSHOT/li /ul Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle-aggregate.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle-aggregate.html?rev=1409201r1=1409200r2=1409201view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle-aggregate.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle-aggregate.html Wed Nov 14 13:43:40 2012 @@ -1,13 +1,13 @@ !DOCTYPE html !-- - | Generated by Apache Maven Doxia at Nov 7, 2012 + | Generated by Apache Maven Doxia at Nov 14, 2012 | Rendered using Apache Maven Fluido Skin 1.3.0 -- html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en head meta charset=UTF-8 / meta name=viewport content=width=device-width, initial-scale=1.0 / -meta name=Date-Revision-mmdd content=20121107 / +meta name=Date-Revision-mmdd content=20121114 / meta http-equiv=Content-Language content=en / titleApache Tomcat Maven Plugin - Checkstyle Results/title link rel=stylesheet href=./css/apache-maven-fluido-1.3.0.min.css / @@ -226,7 +226,7 @@ - li id=publishDate class=pull-rightLast Published: 07 November 2012/li li class=divider pull-right|/li + li id=publishDate class=pull-rightLast Published: 14 November 2012/li li class=divider pull-right|/li li id=projectVersion class=pull-rightVersion: 2.1-SNAPSHOT/li /ul @@ -236,7 +236,7 @@ div id=bodyColumn [... 6 lines stripped ...] Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle.rss URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle.rss?rev=1409201r1=1409200r2=1409201view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/checkstyle.rss (original) +++ tomcat
[jira] [Commented] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497104#comment-13497104 ] Jiri Peinlich commented on MTOMCAT-185: --- Thank you :). change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Reopened] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) reopened MTOMCAT-185: change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409204 [5/8] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/common/
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html?rev=1409204r1=1409203r2=1409204view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html Wed Nov 14 13:48:19 2012 @@ -183,13 +183,13 @@ } } /script -a name=Dependency_Tree/adiv class=sectionh3Dependency Treea name=Dependency_Tree/a/h3ulliorg.apache.tomcat.maven:tomcat-maven-plugin-it:jar:2.1-SNAPSHOT img id=_8724676 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1763031508', '_8724676' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1763031508 style=display:nonetable border=0 class=table table-stripedtr class=athApache Tomcat Maven Plugin :: Integration Tests/th/trtr class=btdpbDescription: /bThe Tomcat Maven Plugin provides goals to manipulate WAR projects within the Tomcat servlet -container./ppbURL: /ba class=externalLink href=http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it;http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/p/td/tr/table/divullijunit:junit:jar:4.10 (compile) img id=_489059557 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1590946235', '_489059557' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1590946235 style=display:nonetable border=0 class=table table-stripedtr class=athJUnit/th/trtr class=btdpbDescription: /bJUnit is a regression testing framework written by Erich Gamma and Kent Beck. -It is used by the developer who implements unit tests in Java./ppbURL: /ba class=externalLink href=http://junit.org;http://junit.org/a/ppbProject License: /ba class=externalLink href=http://www.opensource.org/licenses/cpl1.0.txt;Common Public License Version 1.0/a/p/td/tr/table/divulliorg.hamcrest:hamcrest-core:jar:1.1 (compile) img id=_1730535 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_267989562', '_1730535' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_267989562 style=display:nonetable border=0 class=table table-stripedtr class=athHamcrest Core/th/trtr class=btdpbDescription: /bThere is currently no description associated with this project./ppbProject License: /ba class=externalLink href=http://www.opensource.org/licenses/bsd-license.php;BSD style/a/p/td/tr/table/div/li/ul/lilijunit-addo ns:junit-addons:jar:1.4 (compile) img id=_1578318584 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_710959465', '_1578318584' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_710959465 style=display:nonetable border=0 class=table table-stripedtr class=athjunit-addons/th/trtr class=btdpbDescription: /bThere is currently no description associated with this project./ppbProject License: /bNo license is defined for this project./p/td/tr/table/divullixerces:xercesImpl:jar:2.6.2 (compile) img id=_879105531 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1136629565', '_879105531' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1136629565 style=display:nonetable border=0 class=table table-stripedtr class=athxercesImpl/th/trtr class=btdpbDescription: /bThere is currently n o description associated with this project./ppbProject License: /bNo license is defined for this project./p/td/tr/table/div/lilixerces:xmlParserAPIs:jar:2.6.2 (compile) img id=_1580283821 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_413213172', '_1580283821' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_413213172 style=display:nonetable border=0 class=table table-stripedtr class=athxmlParserAPIs/th/trtr class=btdpbDescription: /bThere is currently no description associated with this project./ppbProject License: /bNo license is defined for this project./p/td/tr/table/div/li/ul/liliorg.apache.maven.shared:maven-verifier:jar:1.3 (compile) img id=_2002290526 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1465381123', '_2002290526' ); style=cursor: pointer;vertical-align:text-bottom;/im gdiv id=_1465381123 style=display:nonetable border=0 class=table table-stripedtr class=athMaven Verifier Component/th/trtr class=btdpbDescription: /bProvides a test harness for Maven integration tests./ppbURL: /ba class=externalLink
svn commit: r1409204 [8/8] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/common/
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependencies.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependencies.html?rev=1409204r1=1409203r2=1409204view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependencies.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependencies.html Wed Nov 14 13:48:19 2012 @@ -185,12 +185,12 @@ } } /script -a name=Dependency_Tree/adiv class=sectionh3Dependency Treea name=Dependency_Tree/a/h3ulliorg.apache.tomcat.maven:tomcat7-war-runner:jar:2.1-SNAPSHOT img id=_1158505822 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1902487103', '_1158505822' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1902487103 style=display:nonetable border=0 class=table table-stripedtr class=athApache Tomcat Maven Plugin :: Tomcat 7.x War Runner/th/trtr class=btdpbDescription: /bThe Tomcat Maven Plugin provides goals to manipulate WAR projects within the Tomcat servlet -container./ppbURL: /ba class=externalLink href=http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner;http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/p/td/tr/table/divullicommons-cli:commons-cli:jar:1.2 (compile) img id=_1456641684 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_905356733', '_1456641684' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_905356733 style=display:nonetable border=0 class=table table-stripedtr class=athCommons CLI/th/trtr class=btdpbDescription: /bCommons CLI provides a simple API for presenting, processing and validating a command line interface./ppbURL: /ba class=externalLink href=http://commons.apache.org/cli/;http: //commons.apache.org/cli//a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/p/td/tr/table/div/liliorg.eclipse.jdt.core.compiler:ecj:jar:3.7 (compile) img id=_308878725 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_334992800', '_308878725' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_334992800 style=display:nonetable border=0 class=table table-stripedtr class=athEclipse ECJ/th/trtr class=btdpbDescription: /bEclipse JDT Core Batch Compiler/ppbURL: /ba class=externalLink href=http://www.eclipse.org/jdt/;http://www.eclipse.org/jdt//a/ppbProject License: /ba class=externalLink href=http://www.eclipse.org/org/documents/epl-v10.php;Eclipse Public License v1.0/a/p/td/tr/table/div/liliorg.apache.tomcat.embed:tomcat-embed- core:jar:7.0.32 (compile) img id=_62781689 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1453632812', '_62781689' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1453632812 style=display:nonetable border=0 class=table table-stripedtr class=athtomcat-embed-core/th/trtr class=btdpbDescription: /bCore Tomcat implementation/ppbURL: /ba class=externalLink href=http://tomcat.apache.org/;http://tomcat.apache.org//a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;Apache License, Version 2.0/a/p/td/tr/table/div/liliorg.apache.tomcat:tomcat-util:jar:7.0.32 (compile) img id=_1547414892 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1668404311', '_1547414892' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1668404311 style=display:no netable border=0 class=table table-stripedtr class=athtomcat-util/th/trtr class=btdpbDescription: /bCommon code shared by Catalina and Jasper/ppbURL: /ba class=externalLink href=http://tomcat.apache.org/;http://tomcat.apache.org//a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;Apache License, Version 2.0/a/p/td/tr/table/divulliorg.apache.tomcat:tomcat-juli:jar:7.0.32 (compile) img id=_152092023 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_781138332', '_152092023' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_781138332 style=display:nonetable border=0 class=table table-stripedtr class=athtomcat-juli/th/trtr class=btdpbDescription: /bTomcat Core Logging Package/ppbURL: /ba class=externalLink href=http://tomcat.apache.org/;http://tomcat.apache. org//a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;Apache License, Version 2.0/a/p/td/tr/table/div/li/ul/liliorg.apache.tomcat:tomcat-coyote:jar:7.0.32 (compile) img
[jira] [Comment Edited] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497100#comment-13497100 ] Olivier Lamy (*$^¨%`£) edited comment on MTOMCAT-185 at 11/14/12 1:48 PM: -- Yup I agree it's a better phase especially for your use case :-) So I change that. NOTE you can test snapshot following instructions from here: http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/snapshot-test.html was (Author: olamy): Yup I agree it's a better phase especially for your use cad :-) So I change that. change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497109#comment-13497109 ] Jiri Peinlich commented on MTOMCAT-185: --- I can confirm, that it is fixed in the snapshot. Thank you. change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-185) change phase for tomcat6/7:run to process-classes
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497111#comment-13497111 ] Hudson commented on MTOMCAT-185: Integrated in TomcatMavenPlugin-mvn3.x #219 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/219/]) [MTOMCAT-185] change phase for tomcat6/7:run to process-classes (Revision 1409194) Result = SUCCESS olamy : http://svn.apache.org/viewvc/?view=revrev=1409194 Files : * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java change phase for tomcat6/7:run to process-classes - Key: MTOMCAT-185 URL: https://issues.apache.org/jira/browse/MTOMCAT-185 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Jiri Peinlich Assignee: Olivier Lamy (*$^¨%`£) Labels: maven, newbie Fix For: 2.1 Hello, I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere. We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat. After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with goalrun/goal and in this mojo there i found executePhasecompile/executePhase. I think that the execution phase should be set to process-classes phase and not compile phase. My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar. I checked the sources and to me it seams that the phase should be set here: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup The execution phase is set there to be compile (curretnly line 60) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath
[ https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497175#comment-13497175 ] Arne Franken commented on MTOMCAT-173: -- I just built 2.1-SNAPSHOT locally and can confirm that the issue is fixed. Thanks! Direct dependencies are not added to classpath -- Key: MTOMCAT-173 URL: https://issues.apache.org/jira/browse/MTOMCAT-173 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat6, tomcat7 Affects Versions: 2.0 Reporter: Arne Franken Assignee: Olivier Lamy (*$^¨%`£) Fix For: 2.1 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct dependencies are not added, the log message says skip adding artifact + artifact.getArtifactId() + as it's in reactors. In my case, it's a jar that is configured as a direct dependency. When the Webapp starts, the Jar is missing from the Classpath and the startup fails. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409353 - /tomcat/maven-plugin/trunk/pom.xml
Author: olamy Date: Wed Nov 14 20:10:34 2012 New Revision: 1409353 URL: http://svn.apache.org/viewvc?rev=1409353view=rev Log: minimum maven version is 2.2.1 Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1409353r1=1409352r2=1409353view=diff == --- tomcat/maven-plugin/trunk/pom.xml (original) +++ tomcat/maven-plugin/trunk/pom.xml Wed Nov 14 20:10:34 2012 @@ -43,7 +43,7 @@ project.build.sourceEncodingUTF-8/project.build.sourceEncoding maven.compiler.source1.5/maven.compiler.source maven.compiler.target1.5/maven.compiler.target -mavenVersion2.0.11/mavenVersion +mavenVersion2.2.1/mavenVersion !-- Test settings -- maven.test.redirectTestOutputToFilefalse/maven.test.redirectTestOutputToFile failsafe.version2.12.3/failsafe.version - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409354 - /tomcat/maven-plugin/trunk/pom.xml
Author: olamy Date: Wed Nov 14 20:10:43 2012 New Revision: 1409354 URL: http://svn.apache.org/viewvc?rev=1409354view=rev Log: use last maven-plugin-plugin 3.2 version Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1409354r1=1409353r2=1409354view=diff == --- tomcat/maven-plugin/trunk/pom.xml (original) +++ tomcat/maven-plugin/trunk/pom.xml Wed Nov 14 20:10:43 2012 @@ -400,7 +400,7 @@ dependency groupIdorg.apache.maven.plugin-tools/groupId artifactIdmaven-plugin-annotations/artifactId -version3.1/version +version3.2/version scopeprovided/scope /dependency @@ -614,7 +614,7 @@ plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-plugin-plugin/artifactId - version3.1/version + version3.2/version configuration skipErrorNoDescriptorsFoundtrue/skipErrorNoDescriptorsFound /configuration - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409357 - /tomcat/maven-plugin/trunk/pom.xml
Author: olamy Date: Wed Nov 14 20:10:54 2012 New Revision: 1409357 URL: http://svn.apache.org/viewvc?rev=1409357view=rev Log: use last surefire version Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1409357r1=1409356r2=1409357view=diff == --- tomcat/maven-plugin/trunk/pom.xml (original) +++ tomcat/maven-plugin/trunk/pom.xml Wed Nov 14 20:10:54 2012 @@ -46,7 +46,7 @@ mavenVersion2.2.1/mavenVersion !-- Test settings -- maven.test.redirectTestOutputToFilefalse/maven.test.redirectTestOutputToFile -failsafe.version2.12.3/failsafe.version +failsafe.version2.12.4/failsafe.version junit.version4.10/junit.version it.sleep.time2000/it.sleep.time verifier.maven.debugfalse/verifier.maven.debug @@ -596,7 +596,7 @@ plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-surefire-plugin/artifactId - version2.12.3/version + version2.12.4/version /plugin plugin groupIdorg.apache.maven.plugins/groupId - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409358 - /tomcat/maven-plugin/trunk/pom.xml
Author: olamy Date: Wed Nov 14 20:11:03 2012 New Revision: 1409358 URL: http://svn.apache.org/viewvc?rev=1409358view=rev Log: use last site plugin version 3.2 remove ssh wagon as we are now using svnpubsub Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1409358r1=1409357r2=1409358view=diff == --- tomcat/maven-plugin/trunk/pom.xml (original) +++ tomcat/maven-plugin/trunk/pom.xml Wed Nov 14 20:11:03 2012 @@ -655,14 +655,7 @@ plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-site-plugin/artifactId - version3.1/version - dependencies -dependency - groupIdorg.apache.maven.wagon/groupId - artifactIdwagon-ssh/artifactId - version2.2/version -/dependency - /dependencies + version3.2/version /plugin plugin groupIdorg.apache.maven.plugins/groupId - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1409371 [8/24] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/common
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/dependency-management.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/dependency-management.html?rev=1409371r1=1409370r2=1409371view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/dependency-management.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/dependency-management.html Wed Nov 14 20:17:41 2012 @@ -236,9 +236,9 @@ div id=bodyColumn -div class=sectionh2Project Dependency Managementa name=Project_Dependency_Management/a/h2a name=Project_Dependency_Management/adiv class=sectionh3compilea name=compile/a/h3a name=compile/apThe following is a list of compile dependencies in the DependencyManagement of this project. These dependencies can be included in the submodules to compile and run the submodule:/ptable border=0 class=table table-stripedtr class=athGroupId/ththArtifactId/ththVersion/ththType/ththLicense/th/trtr class=btdch.qos.logback/tdtda class=externalLink href=http://logback.qos.ch;logback-classic/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=atdch.qos.log back/tdtda class=externalLink href=http://logback.qos.ch;logback-core/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=btdcom.google.guava/tdtda class=externalLink href=http://code.google.com/p/guava-libraries/guava;guava/a/tdtd10.0.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-cli/tdtda class=externalLink href=http://commons.apache.org/cli/;commons-cli/a/tdtd1.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-codec/tdtda class=ex ternalLink href=http://commons.apache.org/codec/;commons-codec/a/tdtd1.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-io/tdtda class=externalLink href=http://commons.apache.org/io/;commons-io/a/tdtd2.4/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-lang/tdtda class=externalLink href=http://commons.apache.org/lang/;commons-lang/a/tdtd2.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdjunit/tdtda class=externalLink href=http://junit.org;junit/a/tdtd4.10/tdtdjar/tdtda class=externalLink href=http://www.opensource.org/licenses/cpl1.0. txtCommon Public License Version 1.0/a/td/trtr class=btdjunit-addons/tdtdjunit-addons/tdtd1.4/tdtdjar/tdtd-/td/trtr class=atdorg.apache.commons/tdtda class=externalLink href=http://commons.apache.org/compress/;commons-compress/a/tdtd1.4.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;fluent-hc/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=atdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;httpclient/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/shared/maven-archiver/;maven-archiver/a/t dtd2.4.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact;maven-artifact/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact-manager;maven-artifact-manager/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-core;maven-core/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/ licenses/LICENSE-2.0.txtThe Apache Software License,
svn commit: r1409371 [11/24] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/commo
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html?rev=1409371r1=1409370r2=1409371view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/dependencies.html Wed Nov 14 20:17:41 2012 @@ -183,13 +183,13 @@ } } /script -a name=Dependency_Tree/adiv class=sectionh3Dependency Treea name=Dependency_Tree/a/h3ulliorg.apache.tomcat.maven:tomcat-maven-plugin-it:jar:2.1-SNAPSHOT img id=_1610668851 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_679644940', '_1610668851' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_679644940 style=display:nonetable border=0 class=table table-stripedtr class=athApache Tomcat Maven Plugin :: Integration Tests/th/trtr class=btdpbDescription: /bThe Tomcat Maven Plugin provides goals to manipulate WAR projects within the Tomcat servlet -container./ppbURL: /ba class=externalLink href=http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it;http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/tomcat-maven-plugin-it/a/ppbProject License: /ba class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/p/td/tr/table/divullijunit:junit:jar:4.10 (compile) img id=_1526965573 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_501030635', '_1526965573' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_501030635 style=display:nonetable border=0 class=table table-stripedtr class=athJUnit/th/trtr class=btdpbDescription: /bJUnit is a regression testing framework written by Erich Gamma and Kent Beck. -It is used by the developer who implements unit tests in Java./ppbURL: /ba class=externalLink href=http://junit.org;http://junit.org/a/ppbProject License: /ba class=externalLink href=http://www.opensource.org/licenses/cpl1.0.txt;Common Public License Version 1.0/a/p/td/tr/table/divulliorg.hamcrest:hamcrest-core:jar:1.1 (compile) img id=_169997644 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1263540163', '_169997644' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1263540163 style=display:nonetable border=0 class=table table-stripedtr class=athHamcrest Core/th/trtr class=btdpbDescription: /bThere is currently no description associated with this project./ppbProject License: /ba class=externalLink href=http://www.opensource.org/licenses/bsd-license.php;BSD style/a/p/td/tr/table/div/li/ul/lilijuni t-addons:junit-addons:jar:1.4 (compile) img id=_462455658 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1250933813', '_462455658' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_1250933813 style=display:nonetable border=0 class=table table-stripedtr class=athjunit-addons/th/trtr class=btdpbDescription: /bThere is currently no description associated with this project./ppbProject License: /bNo license is defined for this project./p/td/tr/table/divullixerces:xercesImpl:jar:2.6.2 (compile) img id=_2085328242 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_152455335', '_2085328242' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_152455335 style=display:nonetable border=0 class=table table-stripedtr class=athxercesImpl/th/trtr class=btdpbDescription: /bThere is curre ntly no description associated with this project./ppbProject License: /bNo license is defined for this project./p/td/tr/table/div/lilixerces:xmlParserAPIs:jar:2.6.2 (compile) img id=_1955441716 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_627077197', '_1955441716' ); style=cursor: pointer;vertical-align:text-bottom;/imgdiv id=_627077197 style=display:nonetable border=0 class=table table-stripedtr class=athxmlParserAPIs/th/trtr class=btdpbDescription: /bThere is currently no description associated with this project./ppbProject License: /bNo license is defined for this project./p/td/tr/table/div/li/ul/liliorg.apache.maven.shared:maven-verifier:jar:1.3 (compile) img id=_1594487796 src=./images/icon_info_sml.gif alt=Information onclick=toggleDependencyDetail( '_1842819783', '_1594487796' ); style=cursor: pointer;vertical-align:text-bottom; /imgdiv id=_1842819783 style=display:nonetable border=0 class=table table-stripedtr class=athMaven Verifier Component/th/trtr class=btdpbDescription: /bProvides a test harness for Maven integration tests./ppbURL: /ba class=externalLink
svn commit: r1409371 [6/24] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/common
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/common-tomcat-maven-plugin/dependency-management.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/common-tomcat-maven-plugin/dependency-management.html?rev=1409371r1=1409370r2=1409371view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/common-tomcat-maven-plugin/dependency-management.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/common-tomcat-maven-plugin/dependency-management.html Wed Nov 14 20:17:41 2012 @@ -168,9 +168,9 @@ div id=bodyColumn -div class=sectionh2Project Dependency Managementa name=Project_Dependency_Management/a/h2a name=Project_Dependency_Management/adiv class=sectionh3compilea name=compile/a/h3a name=compile/apThe following is a list of compile dependencies in the DependencyManagement of this project. These dependencies can be included in the submodules to compile and run the submodule:/ptable border=0 class=table table-stripedtr class=athGroupId/ththArtifactId/ththVersion/ththType/ththLicense/th/trtr class=btdch.qos.logback/tdtda class=externalLink href=http://logback.qos.ch;logback-classic/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=atdch.qos.log back/tdtda class=externalLink href=http://logback.qos.ch;logback-core/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=btdcom.google.guava/tdtda class=externalLink href=http://code.google.com/p/guava-libraries/guava;guava/a/tdtd10.0.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-cli/tdtda class=externalLink href=http://commons.apache.org/cli/;commons-cli/a/tdtd1.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-codec/tdtda class=ex ternalLink href=http://commons.apache.org/codec/;commons-codec/a/tdtd1.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-io/tdtda class=externalLink href=http://commons.apache.org/io/;commons-io/a/tdtd2.4/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-lang/tdtda class=externalLink href=http://commons.apache.org/lang/;commons-lang/a/tdtd2.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdjunit/tdtda class=externalLink href=http://junit.org;junit/a/tdtd4.10/tdtdjar/tdtda class=externalLink href=http://www.opensource.org/licenses/cpl1.0. txtCommon Public License Version 1.0/a/td/trtr class=btdjunit-addons/tdtdjunit-addons/tdtd1.4/tdtdjar/tdtd-/td/trtr class=atdorg.apache.commons/tdtda class=externalLink href=http://commons.apache.org/compress/;commons-compress/a/tdtd1.4.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;fluent-hc/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=atdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;httpclient/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/shared/maven-archiver/;maven-archiver/a/t dtd2.4.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact;maven-artifact/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact-manager;maven-artifact-manager/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink
svn commit: r1409371 [10/24] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/commo
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-archetype/dependency-management.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-archetype/dependency-management.html?rev=1409371r1=1409370r2=1409371view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-archetype/dependency-management.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat-maven-archetype/dependency-management.html Wed Nov 14 20:17:41 2012 @@ -162,9 +162,9 @@ div id=bodyColumn -div class=sectionh2Project Dependency Managementa name=Project_Dependency_Management/a/h2a name=Project_Dependency_Management/adiv class=sectionh3compilea name=compile/a/h3a name=compile/apThe following is a list of compile dependencies in the DependencyManagement of this project. These dependencies can be included in the submodules to compile and run the submodule:/ptable border=0 class=table table-stripedtr class=athGroupId/ththArtifactId/ththVersion/ththType/ththLicense/th/trtr class=btdch.qos.logback/tdtda class=externalLink href=http://logback.qos.ch;logback-classic/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=atdch.qos.log back/tdtda class=externalLink href=http://logback.qos.ch;logback-core/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=btdcom.google.guava/tdtda class=externalLink href=http://code.google.com/p/guava-libraries/guava;guava/a/tdtd10.0.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-cli/tdtda class=externalLink href=http://commons.apache.org/cli/;commons-cli/a/tdtd1.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-codec/tdtda class=ex ternalLink href=http://commons.apache.org/codec/;commons-codec/a/tdtd1.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-io/tdtda class=externalLink href=http://commons.apache.org/io/;commons-io/a/tdtd2.4/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-lang/tdtda class=externalLink href=http://commons.apache.org/lang/;commons-lang/a/tdtd2.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdjunit/tdtda class=externalLink href=http://junit.org;junit/a/tdtd4.10/tdtdjar/tdtda class=externalLink href=http://www.opensource.org/licenses/cpl1.0. txtCommon Public License Version 1.0/a/td/trtr class=btdjunit-addons/tdtdjunit-addons/tdtd1.4/tdtdjar/tdtd-/td/trtr class=atdorg.apache.commons/tdtda class=externalLink href=http://commons.apache.org/compress/;commons-compress/a/tdtd1.4.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;fluent-hc/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=atdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;httpclient/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/shared/maven-archiver/;maven-archiver/a/t dtd2.4.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact;maven-artifact/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact-manager;maven-artifact-manager/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-core;maven-core/a/tdtd2.0.11/tdtdjar/tdtda
svn commit: r1409371 [20/24] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/commo
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-maven-plugin/dependency-management.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-maven-plugin/dependency-management.html?rev=1409371r1=1409370r2=1409371view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-maven-plugin/dependency-management.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-maven-plugin/dependency-management.html Wed Nov 14 20:17:41 2012 @@ -204,9 +204,9 @@ div id=bodyColumn -div class=sectionh2Project Dependency Managementa name=Project_Dependency_Management/a/h2a name=Project_Dependency_Management/adiv class=sectionh3compilea name=compile/a/h3a name=compile/apThe following is a list of compile dependencies in the DependencyManagement of this project. These dependencies can be included in the submodules to compile and run the submodule:/ptable border=0 class=table table-stripedtr class=athGroupId/ththArtifactId/ththVersion/ththType/ththLicense/th/trtr class=btdch.qos.logback/tdtda class=externalLink href=http://logback.qos.ch;logback-classic/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=atdch.qos.log back/tdtda class=externalLink href=http://logback.qos.ch;logback-core/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=btdcom.google.guava/tdtda class=externalLink href=http://code.google.com/p/guava-libraries/guava;guava/a/tdtd10.0.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-cli/tdtda class=externalLink href=http://commons.apache.org/cli/;commons-cli/a/tdtd1.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-codec/tdtda class=ex ternalLink href=http://commons.apache.org/codec/;commons-codec/a/tdtd1.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-io/tdtda class=externalLink href=http://commons.apache.org/io/;commons-io/a/tdtd2.4/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-lang/tdtda class=externalLink href=http://commons.apache.org/lang/;commons-lang/a/tdtd2.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdjunit/tdtda class=externalLink href=http://junit.org;junit/a/tdtd4.10/tdtdjar/tdtda class=externalLink href=http://www.opensource.org/licenses/cpl1.0. txtCommon Public License Version 1.0/a/td/trtr class=btdjunit-addons/tdtdjunit-addons/tdtd1.4/tdtdjar/tdtd-/td/trtr class=atdorg.apache.commons/tdtda class=externalLink href=http://commons.apache.org/compress/;commons-compress/a/tdtd1.4.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;fluent-hc/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=atdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;httpclient/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/shared/maven-archiver/;maven-archiver/a/t dtd2.4.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact;maven-artifact/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact-manager;maven-artifact-manager/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-core;maven-core/a/tdtd2.0.11/tdtdjar/tdtda
svn commit: r1409371 [24/24] - in /tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT: ./ apidocs/ apidocs/class-use/ apidocs/org/apache/tomcat/maven/common/config/ apidocs/org/apache/tomcat/maven/commo
Modified: tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependency-management.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependency-management.html?rev=1409371r1=1409370r2=1409371view=diff == --- tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependency-management.html (original) +++ tomcat/site/trunk/docs/maven-plugin-2.1-SNAPSHOT/tomcat7-war-runner/dependency-management.html Wed Nov 14 20:17:41 2012 @@ -166,9 +166,9 @@ div id=bodyColumn -div class=sectionh2Project Dependency Managementa name=Project_Dependency_Management/a/h2a name=Project_Dependency_Management/adiv class=sectionh3compilea name=compile/a/h3a name=compile/apThe following is a list of compile dependencies in the DependencyManagement of this project. These dependencies can be included in the submodules to compile and run the submodule:/ptable border=0 class=table table-stripedtr class=athGroupId/ththArtifactId/ththVersion/ththType/ththLicense/th/trtr class=btdch.qos.logback/tdtda class=externalLink href=http://logback.qos.ch;logback-classic/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=atdch.qos.log back/tdtda class=externalLink href=http://logback.qos.ch;logback-core/a/tdtd1.0.0/tdtdjar/tdtda class=externalLink href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License - v 1.0/a, a class=externalLink href=http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html;GNU Lesser General Public License/a/td/trtr class=btdcom.google.guava/tdtda class=externalLink href=http://code.google.com/p/guava-libraries/guava;guava/a/tdtd10.0.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-cli/tdtda class=externalLink href=http://commons.apache.org/cli/;commons-cli/a/tdtd1.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-codec/tdtda class=ex ternalLink href=http://commons.apache.org/codec/;commons-codec/a/tdtd1.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdcommons-io/tdtda class=externalLink href=http://commons.apache.org/io/;commons-io/a/tdtd2.4/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdcommons-lang/tdtda class=externalLink href=http://commons.apache.org/lang/;commons-lang/a/tdtd2.6/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdjunit/tdtda class=externalLink href=http://junit.org;junit/a/tdtd4.10/tdtdjar/tdtda class=externalLink href=http://www.opensource.org/licenses/cpl1.0. txtCommon Public License Version 1.0/a/td/trtr class=btdjunit-addons/tdtdjunit-addons/tdtd1.4/tdtdjar/tdtd-/td/trtr class=atdorg.apache.commons/tdtda class=externalLink href=http://commons.apache.org/compress/;commons-compress/a/tdtd1.4.1/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;fluent-hc/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=atdorg.apache.httpcomponents/tdtda class=externalLink href=http://hc.apache.org/httpcomponents-client;httpclient/a/tdtd4.2-alpha1/tdtdjar/tdtdLICENSE.txt/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/shared/maven-archiver/;maven-archiver/a/t dtd2.4.2/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact;maven-artifact/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=btdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-artifact-manager;maven-artifact-manager/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink href=http://www.apache.org/licenses/LICENSE-2.0.txt;The Apache Software License, Version 2.0/a/td/trtr class=atdorg.apache.maven/tdtda class=externalLink href=http://maven.apache.org/maven-core;maven-core/a/tdtd2.0.11/tdtdjar/tdtda class=externalLink
svn commit: r1409646 - /tomcat/trunk/test/org/apache/jasper/tagplugins/jstl/core/AbstractTestTag.java
Author: kkolinko Date: Thu Nov 15 04:59:41 2012 New Revision: 1409646 URL: http://svn.apache.org/viewvc?rev=1409646view=rev Log: Validate that the path to the file is correct. Modified: tomcat/trunk/test/org/apache/jasper/tagplugins/jstl/core/AbstractTestTag.java Modified: tomcat/trunk/test/org/apache/jasper/tagplugins/jstl/core/AbstractTestTag.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/tagplugins/jstl/core/AbstractTestTag.java?rev=1409646r1=1409645r2=1409646view=diff == --- tomcat/trunk/test/org/apache/jasper/tagplugins/jstl/core/AbstractTestTag.java (original) +++ tomcat/trunk/test/org/apache/jasper/tagplugins/jstl/core/AbstractTestTag.java Thu Nov 15 04:59:41 2012 @@ -18,6 +18,7 @@ package org.apache.jasper.tagplugins.jst import java.io.File; +import org.junit.Assert; import org.junit.Before; import org.apache.catalina.Context; @@ -48,6 +49,7 @@ public abstract class AbstractTestTag ex // Configure the use of the plug-in rather than the standard impl File plugin = new File( java/org/apache/jasper/tagplugins/jstl/tagPlugins.xml); +Assert.assertTrue(plugin.isFile()); ctx.getResources().createWebResourceSet( WebResourceRoot.ResourceSetType.POST, plugin.getAbsolutePath(), /WEB-INF/tagPlugins.xml, ); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54144] Processing of java.io.Reader in Out tagplugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=54144 --- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com --- 3. JSTL spec says (under Null Error Handling): If no default value is specified, it itself defaults to an empty string. In the current code: a) A null is used instead of as the value of strDefName. b) I suspect that the following check for no default value specified is incorrect: ctxt.generateJavaSource(if(); ctxt.generateAttribute(default); ctxt.generateJavaSource( != null){); One has to check whether the attribute is present, instead of checking whether its value is null. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org