svn commit: r1459671 - /tomcat/trunk/java/javax/websocket/HandshakeResponse.java

Author: markt Date: Fri Mar 22 08:55:39 2013 New Revision: 1459671 URL: http://svn.apache.org/r1459671 Log: Fix constant Modified: tomcat/trunk/java/javax/websocket/HandshakeResponse.java Modified: tomcat/trunk/java/javax/websocket/HandshakeResponse.java URL:

svn commit: r1459672 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServlet.java

Author: markt Date: Fri Mar 22 08:55:56 2013 New Revision: 1459672 URL: http://svn.apache.org/r1459672 Log: Use constant Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServlet.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServlet.java URL:

svn commit: r1459673 - in /tomcat/trunk: build.properties.default modules/jdbc-pool/build.properties.default

Author: kkolinko Date: Fri Mar 22 08:58:12 2013 New Revision: 1459673 URL: http://svn.apache.org/r1459673 Log: jdbc-pool tests need JUnit 4. Use the same version of junit as used by Tomcat. Modified: tomcat/trunk/build.properties.default

svn commit: r1459674 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default modules/jdbc-pool/build.properties.default

Author: kkolinko Date: Fri Mar 22 08:59:57 2013 New Revision: 1459674 URL: http://svn.apache.org/r1459674 Log: Merged revision 1459673 from tomcat/trunk: jdbc-pool tests need JUnit 4. Use the same version of junit as used by Tomcat. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459677 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java

Author: markt Date: Fri Mar 22 09:06:38 2013 New Revision: 1459677 URL: http://svn.apache.org/r1459677 Log: Add NPE protection and add missing filtering of POJOs. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java Modified:

svn commit: r1459680 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

Author: markt Date: Fri Mar 22 09:13:26 2013 New Revision: 1459680 URL: http://svn.apache.org/r1459680 Log: Make error messages rather more useful Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified:

svn commit: r1459681 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

Author: kkolinko Date: Fri Mar 22 09:16:06 2013 New Revision: 1459681 URL: http://svn.apache.org/r1459681 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54599 jdbc-pool: Do not expose connection password via DataSource.toString(). Based on a patch by Daniel Mikusa Modified:

svn commit: r1459683 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java webapps/docs/changelog.xml

Author: kkolinko Date: Fri Mar 22 09:22:55 2013 New Revision: 1459683 URL: http://svn.apache.org/r1459683 Log: Merged revision 1459681 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54599 jdbc-pool: Do not expose connection password via DataSource.toString(). Based on a

Re: svn commit: r1459681 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

On 22/03/2013 09:16, kkoli...@apache.org wrote: Author: kkolinko Date: Fri Mar 22 09:16:06 2013 New Revision: 1459681 URL: http://svn.apache.org/r1459681 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54599 jdbc-pool: Do not expose connection password via

[Bug 54599] DataSource password is exposed to applications via toString method

https://issues.apache.org/bugzilla/show_bug.cgi?id=54599 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

Re: svn commit: r1459681 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

2013/3/22 Mark Thomas ma...@apache.org: On 22/03/2013 09:16, kkoli...@apache.org wrote: Author: kkolinko Date: Fri Mar 22 09:16:06 2013 New Revision: 1459681 URL: http://svn.apache.org/r1459681 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54599 jdbc-pool: Do not expose

Re: svn commit: r1459681 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

On 22/03/2013 09:26, Konstantin Kolinko wrote: 2013/3/22 Mark Thomas ma...@apache.org: On 22/03/2013 09:16, kkoli...@apache.org wrote: Author: kkolinko Date: Fri Mar 22 09:16:06 2013 New Revision: 1459681 URL: http://svn.apache.org/r1459681 Log: Fix

Re: Time for 7.0.39

On 21/03/2013 22:34, Mark Thomas wrote: On 20/03/2013 20:55, Mark Thomas wrote: I plan to get the most recent FileUpload changes (if any), run the unit tests, run the TCKs and then tag 7.0.39 so that should happen some time early tomorrow if all goes well. Second attempt. Unit tests for

[Bug 53968] Database password is exposed via JMX in getDbProperties() method

https://issues.apache.org/bugzilla/show_bug.cgi?id=53968 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

[Tomcat Wiki] Trivial Update of LillyHadl by LillyHadl

Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The LillyHadl page has been changed by LillyHadl: http://wiki.apache.org/tomcat/LillyHadl New page: Senior account executive Gunnro Blixt is enthusiastic about fit training basketball,

svn commit: r1459741 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_39: ./ build.properties.default

Author: markt Date: Fri Mar 22 12:32:01 2013 New Revision: 1459741 URL: http://svn.apache.org/r1459741 Log: Tag 7.0.39 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_39/ (props changed) - copied from r1459740, tomcat/tc7.0.x/trunk/ Modified:

svn commit: r1459742 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default

Author: markt Date: Fri Mar 22 12:33:12 2013 New Revision: 1459742 URL: http://svn.apache.org/r1459742 Log: Prep for next release Modified: tomcat/tc7.0.x/trunk/build.properties.default tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Modified:

[Tomcat Wiki] Update of LocalBadContent by ChuckCaldarale

Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The LocalBadContent page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diffrev1=100rev2=101 myteethadvisor\.com najem-avtodoma\.info

buildbot success in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1146 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1459761 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java

Author: kkolinko Date: Fri Mar 22 13:34:41 2013 New Revision: 1459761 URL: http://svn.apache.org/r1459761 Log: Remove stray obsolete comment. This method has been already implemented. Modified:

svn commit: r1459769 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/interceptor/ test/java/org/apache/tomcat/jdbc/pool/interceptor/ test/java/org/apache/tomcat/jdbc/te

Author: kkolinko Date: Fri Mar 22 13:44:00 2013 New Revision: 1459769 URL: http://svn.apache.org/r1459769 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 Fix leak of statements in StatementCache interceptor. Added:

[Bug 54732] StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks

https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 --- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com --- Confirmed. The leak happens when the cache is full, so the statement that is being closed cannot be returned to the cache but has to be closed right away. Fixed in trunk

[Bug 53952] Add support for TLS 1.1 and 1.2

https://issues.apache.org/bugzilla/show_bug.cgi?id=53952 --- Comment #12 from Marcel Šebek sebe...@post.cz --- Now when there is a known practical attack against RC4 in SSL, we have no secure ciphersuite in TLS 1.0, and this issue has probably higher priority than before. What is the reason for

svn commit: r1459838 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

Author: markt Date: Fri Mar 22 15:17:51 2013 New Revision: 1459838 URL: http://svn.apache.org/r1459838 Log: Client needs to send request sub-protocols Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified:

Missing Classes in latest tomcat-embed-logging-log4j snapshot

In the latest snapshot (3/21) of tomcat-embed-logging-log4j, all of the classes in org.apache.juli.logging.* are missing. They are there in the 3/14 snapshot, and they are there in the 3/21 SOURCES snapshot, but they are not there in the 3/21 binaries snapshot. Something foobar happened here.

[VOTE] Release Apache Tomcat 7.0.39

The proposed Apache Tomcat 7.0.39 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.39/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-015/ The svn tag is:

Re: Missing Classes in latest tomcat-embed-logging-log4j snapshot

On Mar 22, 2013, at 11:28 AM, Nick Williams wrote: In the latest snapshot (3/21) of tomcat-embed-logging-log4j, all of the classes in org.apache.juli.logging.* are missing. They are there in the 3/14 snapshot, and they are there in the 3/21 SOURCES snapshot, but they are not there in the

svn commit: r1459896 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

Author: markt Date: Fri Mar 22 17:02:00 2013 New Revision: 1459896 URL: http://svn.apache.org/r1459896 Log: Add support for primitive messages (and their object equivalents) Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified:

[Bug 54337] StatementCache leaks statements/cursors

https://issues.apache.org/bugzilla/show_bug.cgi?id=54337 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

[Bug 54732] StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks

https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added CC|

Re: Unable to generate thread dumps with Tomcat service

On 03/22/2013 01:55 PM, Mark Thomas wrote: Before I raise this as a DAEMON bug could someone else on Windows confirm that triggering a thread dump doesn't work. I get: [2013-03-22 12:54:04] [error] [ 3408] The handle is invalid. whenever I try. Seems it doesn't work. I have the same log.

svn commit: r1459933 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Author: kkolinko Date: Fri Mar 22 19:13:21 2013 New Revision: 1459933 URL: http://svn.apache.org/r1459933 Log: Documentation for StatementCache interceptor. Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

svn commit: r1459943 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/doc/jdbc-pool.xml modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Author: kkolinko Date: Fri Mar 22 19:28:22 2013 New Revision: 1459943 URL: http://svn.apache.org/r1459943 Log: Merged revision 1459933 from tomcat/trunk: Documentation for StatementCache interceptor. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459946 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java

Author: kkolinko Date: Fri Mar 22 19:33:15 2013 New Revision: 1459946 URL: http://svn.apache.org/r1459946 Log: Merged revision 1459761 from tomcat/trunk: Remove stray obsolete comment. This method has been already implemented. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459952 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java

Author: kkolinko Date: Fri Mar 22 19:45:06 2013 New Revision: 1459952 URL: http://svn.apache.org/r1459952 Log: Merged revision 1432517 from tomcat/trunk: Fix threading issue reported by FindBugs - in a test class in jdbc-pool Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459959 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

Author: kkolinko Date: Fri Mar 22 19:59:02 2013 New Revision: 1459959 URL: http://svn.apache.org/r1459959 Log: Merged revision 1434757 from tomcat/trunk: Make sure changes to result are visible to all threads currently calling get() Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459965 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/core/TestAsyncContextImpl.java test/org/apache/tomcat/util/http/parser/TestMediaType.java

Author: kkolinko Date: Fri Mar 22 20:10:56 2013 New Revision: 1459965 URL: http://svn.apache.org/r1459965 Log: Merged revisions r1435126 r1435600 from tomcat/trunk: Use JUnit4 methods Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459970 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/EqualsHashCodeTest.java

Author: kkolinko Date: Fri Mar 22 20:30:31 2013 New Revision: 1459970 URL: http://svn.apache.org/r1459970 Log: Merged revision 1380376 from tomcat/trunk: Clean-up - unused code - autoboxing Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459971 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

Author: markt Date: Fri Mar 22 20:30:49 2013 New Revision: 1459971 URL: http://svn.apache.org/r1459971 Log: Hack to get the TCK to work Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified:

[Bug 54740] Aggressive scan for ServerEndpointConfig

https://issues.apache.org/bugzilla/show_bug.cgi?id=54740 --- Comment #2 from rstoyanc...@yahoo.com --- I posted questions on the EG list (http://java.net/projects/websocket-spec/lists/jsr356-experts/archive/2013-03/message/41). Hopefully this get clarified in the spec. Either way it makes sense

svn commit: r1459972 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java WsRemoteEndpointImplBase.java pojo/PojoMethodMapping.java

Author: markt Date: Fri Mar 22 20:31:29 2013 New Revision: 1459972 URL: http://svn.apache.org/r1459972 Log: Automatically encode primitives and their object equivalents. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Util.java

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1147 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1459975 [2/2] - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/

Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestQueryTimeoutInterceptor.java URL:

svn commit: r1459979 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TwoDataSources.java

Author: kkolinko Date: Fri Mar 22 20:47:21 2013 New Revision: 1459979 URL: http://svn.apache.org/r1459979 Log: Merged revision 1435760 from tomcat/trunk: Fix broken test (it has been broken for a long time) The timeout needs to be shorter than the sleep time so the connection is abandoned

svn commit: r1459987 - in /tomcat/tc7.0.x/trunk: ./ test/javax/el/ test/org/apache/catalina/comet/ test/org/apache/catalina/filters/ test/org/apache/catalina/loader/ test/org/apache/jasper/runtime/ te

Author: kkolinko Date: Fri Mar 22 21:01:52 2013 New Revision: 1459987 URL: http://svn.apache.org/r1459987 Log: Merged revision 1402683 from tomcat/trunk: Use methods from JUnit 4 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/javax/el/TestBeanELResolver.java

svn commit: r1459988 - in /tomcat/tc7.0.x/trunk: ./ res/checkstyle/checkstyle.xml

Author: kkolinko Date: Fri Mar 22 21:05:47 2013 New Revision: 1459988 URL: http://svn.apache.org/r1459988 Log: Merged revision 1435765 from tomcat/trunk: Enable checkstyle check that forbids use of JUnit 3 methods Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1459996 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Fri Mar 22 21:22:54 2013 New Revision: 1459996 URL: http://svn.apache.org/r1459996 Log: Changelog update for recent commits Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1459999 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

Author: markt Date: Fri Mar 22 21:24:02 2013 New Revision: 145 URL: http://svn.apache.org/r145 Log: Need to generate a MessageHandler for primitives Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified:

svn commit: r1460004 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

Author: markt Date: Fri Mar 22 21:30:55 2013 New Revision: 1460004 URL: http://svn.apache.org/r1460004 Log: Need to set indexPrimitive for MessageHandler to be picked up Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified:

svn commit: r1460006 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/ mo

Author: kkolinko Date: Fri Mar 22 21:33:35 2013 New Revision: 1460006 URL: http://svn.apache.org/r1460006 Log: Merged revision 1459769 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 Fix leak of statements in StatementCache interceptor. Based on patch by Bertrand

[Bug 54732] StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks

https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

svn commit: r1460021 - /tomcat/trunk/build.xml

Author: markt Date: Fri Mar 22 22:00:30 2013 New Revision: 1460021 URL: http://svn.apache.org/r1460021 Log: Need additional packages to be in util JAR for websocket Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

svn commit: r1460023 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties Util.java pojo/LocalStrings.properties pojo/PojoMessageHandlerWholeText.java pojo/PojoMethodMapping.ja

Author: markt Date: Fri Mar 22 22:01:21 2013 New Revision: 1460023 URL: http://svn.apache.org/r1460023 Log: More plumbing for handling primitives. Still some bits missing. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties

[Bug 54745] New: Tomcat JarScanning does not work when Tomcat started with Java Web Start

https://issues.apache.org/bugzilla/show_bug.cgi?id=54745 Bug ID: 54745 Summary: Tomcat JarScanning does not work when Tomcat started with Java Web Start Product: Tomcat 8 Version: trunk Hardware: All OS:

[Bug 54745] Tomcat JarScanning does not work when Tomcat started with Java Web Start

https://issues.apache.org/bugzilla/show_bug.cgi?id=54745 Nick Williams nicho...@nicholaswilliams.net changed: What|Removed |Added Attachment #30097|0 |1

[Bug 54740] Aggressive scan for ServerEndpointConfig

https://issues.apache.org/bugzilla/show_bug.cgi?id=54740 --- Comment #3 from rstoyanc...@yahoo.com --- Actually it appears that ServerEndpointConfig types should not be scanned at all. Here is an explanation by Danny on the EG: