Re: Failures in Gump

2013-08-16 Thread Stefan Bodewig
On 2013-08-16, Stefan Bodewig wrote: > It could be a classloader issue but equally well a problem with the Gump > setup. ant-junit4.jar was not part of the CLASSPATH, things look better now. There still are test failures but they seem to be genuine. Stefan --

[Bug 55399] Request English but Response Spanish Language (Default Locale)

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55399 --- Comment #8 from Guillermo Grandes --- (In reply to Mark Thomas from comment #6) > The error pages were simple to fix but fixing the HTTP response status line > is going to be more invasive. That part may end up being Tomcat 8 only > bec

[Bug 55439] New: 'catalina.sh stop -force' doesn't account for empty pid file

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55439 Bug ID: 55439 Summary: 'catalina.sh stop -force' doesn't account for empty pid file Product: Tomcat 8 Version: trunk Hardware: All OS: Linux

Re: Time for 7.0.43? Looking for a new release manager

2013-08-16 Thread Violeta Georgieva
2013/8/7 Mark Thomas wrote: > > On 07/08/2013 06:19, Konstantin Kolinko wrote: > > 2013/8/6 Mark Thomas : > > >> Feel free to make as much or as little use of this: > >> http://wiki.apache.org/tomcat/ReleaseProcess > >> > >> If anything isn't clear, let me know. > > > > The following is missing: >

[Bug 55438] Non Blocking API's onAllDataRead being called twice

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55438 --- Comment #1 from Daniel Mikusa --- One additional note about the test, if you set the "streaming" argument to "postUrl" method to "true" then the test passes. This seems to only occur when "streaming" is set to "false". -- You are rec

[Bug 55438] New: Non Blocking API's onAllDataRead being called twice

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55438 Bug ID: 55438 Summary: Non Blocking API's onAllDataRead being called twice Product: Tomcat 8 Version: trunk Hardware: PC OS: Mac OS X 10.4 Status: NEW

buildbot success in ASF Buildbot on tomcat-7-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1346 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

[Bug 55314] Provide option to allow programmatic deployment of server (WebSocket) endpoint at runtime

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55314 --- Comment #11 from Mark Thomas --- Excellent. Thanks for the feedback. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-ma

[Bug 55314] Provide option to allow programmatic deployment of server (WebSocket) endpoint at runtime

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55314 --- Comment #10 from rstoyanc...@yahoo.com --- I've tried this and it works as expected. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ---

svn commit: r1514825 - /tomcat/tc7.0.x/trunk/build.xml

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 18:00:48 2013 New Revision: 1514825 URL: http://svn.apache.org/r1514825 Log: Fix unit test failures after changes to SSL tests to use class loader to locate resources. Modified: tomcat/tc7.0.x/trunk/build.xml Modified: tomcat/tc7.0.x/trunk/build.xml URL: http

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4844 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 55434] New: The path /foo/a/a/bar causes IllegalArgumentException when WsServerContainer creates UriTemplate

2013-08-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55434 Bug ID: 55434 Summary: The path /foo/a/a/bar causes IllegalArgumentException when WsServerContainer creates UriTemplate Product: Tomcat 8 Version: trunk Hardware: PC

svn commit: r1514783 - /tomcat/tc7.0.x/trunk/modules/websocket/

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 16:42:15 2013 New Revision: 1514783 URL: http://svn.apache.org/r1514783 Log: Ignore output dir Modified: tomcat/tc7.0.x/trunk/modules/websocket/ (props changed) Propchange: tomcat/tc7.0.x/trunk/modules/websocket/ --

svn commit: r1514781 - in /tomcat/tc7.0.x/trunk/modules/websocket: ./ java/org/apache/tomcat/websocket/

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 16:37:48 2013 New Revision: 1514781 URL: http://svn.apache.org/r1514781 Log: Merge generics updates from Tomcat 8 Modified: tomcat/tc7.0.x/trunk/modules/websocket/ (props changed) tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/Asy

svn commit: r1514782 - /tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 16:38:22 2013 New Revision: 1514782 URL: http://svn.apache.org/r1514782 Log: Remove remaining uses of Java 7 from implementation code Modified: tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java Modified: to

svn commit: r1514778 - in /tomcat/trunk/java/org/apache/tomcat/websocket: AsyncChannelWrapper.java AsyncChannelWrapperNonSecure.java AsyncChannelWrapperSecure.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 16:34:45 2013 New Revision: 1514778 URL: http://svn.apache.org/r1514778 Log: Be a little more precise in the use of generics. Porting this to Tomcat 7 where <> is not allowed highlighted an issue. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/AsyncCha

svn commit: r1514752 - in /tomcat/tc7.0.x/trunk/modules/websocket/java: javax/websocket/ javax/websocket/server/ org/apache/tomcat/websocket/ org/apache/tomcat/websocket/pojo/ org/apache/tomcat/websoc

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 15:39:41 2013 New Revision: 1514752 URL: http://svn.apache.org/r1514752 Log: Remove most uses of Java 7 from implementation code Modified: tomcat/tc7.0.x/trunk/modules/websocket/java/javax/websocket/ContainerProvider.java tomcat/tc7.0.x/trunk/modules/webso

svn commit: r1514749 - in /tomcat/tc7.0.x/trunk/modules/websocket/test/org/apache/tomcat/websocket: TestWsWebSocketContainer.java TesterMessageCountClient.java pojo/TestEncodingDecoding.java pojo/Test

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 15:33:17 2013 New Revision: 1514749 URL: http://svn.apache.org/r1514749 Log: Remove use of Java 7 from test code Modified: tomcat/tc7.0.x/trunk/modules/websocket/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java tomcat/tc7.0.x/trunk/modules/we

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1342 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

Back-porting JSR-356 Progress update

2013-08-16 Thread Mark Thomas
The JSR-356 API and implementation has been back-ported to Tomcat 7. The necessary plumbing for the non-blocking support required by JSR-356 has been back-ported to Tomcat 7. All compilation errors have been resolved. The unit tests all pass. Still to do: 1. Remove any Java 7 features so the c

svn commit: r1514734 - /tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TesterSupport.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 14:38:50 2013 New Revision: 1514734 URL: http://svn.apache.org/r1514734 Log: Obtain absolute paths for SSL keystores etc. via the class loader rather than relying on using the current working directory. Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util

svn commit: r1514735 - in /tomcat/tc7.0.x/trunk/modules/websocket/test/org/apache/tomcat/websocket: TestWebSocketFrameClient.java TestWsWebSocketContainer.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 14:39:29 2013 New Revision: 1514735 URL: http://svn.apache.org/r1514735 Log: Back-porting JSR-356 Obtain absolute paths for SSL keystores etc. via the class loader rather than relying on using the current working directory. Modified: tomcat/tc7.0.x/trunk/modul

svn commit: r1514712 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/filters/TesterServletContext.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:55:17 2013 New Revision: 1514712 URL: http://svn.apache.org/r1514712 Log: Back-porting JSR-356 WebSocket unit tests need a couple of features to be implemented (or at least not throw an exception) Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/filt

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-16 Thread Mark Thomas
On 16/08/2013 14:38, Rossen Stoyanchev wrote: > On Thu, Aug 15, 2013 at 6:47 PM, Mark Thomas wrote: >> This isn't going to be quite as simple as I first thought. >> >> The WebSocket client API requires Java SE 7 or later. >> The WebSocket server API requires Java EE 6 or later. >> Java EE 6 requir

svn commit: r1514709 - /tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:44:40 2013 New Revision: 1514709 URL: http://svn.apache.org/r1514709 Log: Need to cast to the Facade Modified: tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/server/UpgradeUtil.java Modified: tomcat/tc7.0.x/trunk/modules/websocket/

svn commit: r1514707 - in /tomcat/tc7.0.x/trunk/java/org/apache: coyote/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:44:13 2013 New Revision: 1514707 URL: http://svn.apache.org/r1514707 Log: Back-porting JSR-356 Add some necessary plumbing for Servlet 3.1 based HTTP upgrade Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/tc7.0.x/trunk/

svn commit: r1514706 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/RequestFacade.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:43:23 2013 New Revision: 1514706 URL: http://svn.apache.org/r1514706 Log: Back-porting JSR-356 RequestFacade needs upgrade method too. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/RequestFacade.java Modified: tomcat/tc7.0.x/trunk/java/o

buildbot success in ASF Buildbot on tomcat-7-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1339 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-16 Thread Rossen Stoyanchev
On Thu, Aug 15, 2013 at 6:47 PM, Mark Thomas wrote: > This isn't going to be quite as simple as I first thought. > > The WebSocket client API requires Java SE 7 or later. > The WebSocket server API requires Java EE 6 or later. > Java EE 6 requires Java 6 or later. > The WebSocket server API depend

svn commit: r1514701 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:21:53 2013 New Revision: 1514701 URL: http://svn.apache.org/r1514701 Log: Back-porting JSR-356 Add upgraded flag to SocketWrapper Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Modified: tomcat/tc7.0.x/trunk/java/org/apach

svn commit: r1514700 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:19:41 2013 New Revision: 1514700 URL: http://svn.apache.org/r1514700 Log: Back-porting JSR-356 Some renaming and refactoring to make it easier to port other changes. Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java Modified: tomcat

svn commit: r1514695 - in /tomcat/tc7.0.x/trunk/java/org/apache: coyote/AbstractProtocol.java coyote/http11/AbstractHttp11Processor.java tomcat/util/net/AbstractEndpoint.java tomcat/util/net/JIoEndpoi

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:14:11 2013 New Revision: 1514695 URL: http://svn.apache.org/r1514695 Log: Back-porting JSR-356 Rename SocketState.UPGRADING -> SocketStatus.UPGRADING_TOMCAT to indicate a Tomcat proprietary HTTP upgrade is in progress Add SocketStatus.UPGRADING to indicate a Serv

svn commit: r1514689 - /tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 13:03:04 2013 New Revision: 1514689 URL: http://svn.apache.org/r1514689 Log: Back-porting JSR-356 Need to cast to Tomcat's request object to access upgrade method Modified: tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/server/UpgradeUt

svn commit: r1514688 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 12:51:45 2013 New Revision: 1514688 URL: http://svn.apache.org/r1514688 Log: Fix unit test failures. Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProces

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1337 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

svn commit: r1514674 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 12:19:31 2013 New Revision: 1514674 URL: http://svn.apache.org/r1514674 Log: vote for my own proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1514

Failures in Gump

2013-08-16 Thread Stefan Bodewig
Hi all, for some tests projects in Gump the tests fail as Ant (or rather the test runner) claims to not have found any tests, for example http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.tomcat.util.descriptor.web.TestSecurityConstraint.NIO.txt.html h

svn commit: r1514673 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-08-16 Thread schultz
Author: schultz Date: Fri Aug 16 12:16:57 2013 New Revision: 1514673 URL: http://svn.apache.org/r1514673 Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1514673&r1=1514672&r2=

svn commit: r1514670 - in /tomcat/tc7.0.x/trunk/modules/websocket/java/org/apache/tomcat/websocket/server: WsFrameServer.java WsHttpUpgradeHandler.java WsRemoteEndpointImplServer.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 12:08:06 2013 New Revision: 1514670 URL: http://svn.apache.org/r1514670 Log: Back-porting JSR-356 Switch to the AbstractServlet[In|Out]putStream implementations as they have the new Servlet 3.1 methods required that aren't part of the Servlet 3.0 API present in Tom

svn commit: r1514668 - in /tomcat/tc7.0.x/trunk/java/org/apache: catalina/connector/ coyote/ coyote/ajp/ coyote/http11/ coyote/http11/upgrade/ coyote/http11/upgrade/servlet31/

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 12:04:35 2013 New Revision: 1514668 URL: http://svn.apache.org/r1514668 Log: Back-porting JSR-356 Add the Servlet 3.1 based HTTP upgrade mechanism. The aim at this point is to enable the back-ported JSR-356 code to compile. I'm not worried (right now) about whether

[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings

2013-08-16 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742130#comment-13742130 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-177: I wonder how you generat

svn commit: r1514663 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/tomcat/ test/org/apache/catalina/core/

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 11:51:28 2013 New Revision: 1514663 URL: http://svn.apache.org/r1514663 Log: Back-porting JSR-356 Add InstanceManager to Context interface. This is required by the Servlet 3.1 based upgrade mechanism. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat

Re: Code style rules: Line length

2013-08-16 Thread Olivier Lamy
On 14 August 2013 20:41, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with tha

svn commit: r1514661 - in /tomcat/tc7.0.x/trunk/java/org/apache: catalina/connector/Request.java coyote/ActionCode.java coyote/ajp/AbstractAjpProcessor.java coyote/http11/AbstractHttp11Processor.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 11:34:57 2013 New Revision: 1514661 URL: http://svn.apache.org/r1514661 Log: Back-porting JSR-356 Rename ActionCode.UPGRADE to ActionCode.UPGRADE_TOMCAT to mark this as the Tomcat proprietary upgrade mechanism. Add a new ActionCode.UPGRADE action for the Servlet 3.1

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4842 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1514659 - in /tomcat/tc7.0.x/trunk/java/org/apache/coyote: AbstractProtocol.java http11/AbstractHttp11Processor.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 11:26:34 2013 New Revision: 1514659 URL: http://svn.apache.org/r1514659 Log: Back-porting JSR-356 Old and new upgrade mechanisms have a isUpgrade() method on the processor and they need to be differentiated. Calls to the old version can easily be replaced so do so.

svn commit: r1514655 - in /tomcat/tc7.0.x/trunk/java/org/apache: coyote/ajp/AjpAprProtocol.java coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 11:08:25 2013 New Revision: 1514655 URL: http://svn.apache.org/r1514655 Log: Back-porting JSR-356 Need to be able to register sockets for read and/or write for the APR/native Poller to implement non-blocking IO Modified: tomcat/tc7.0.x/trunk/java/org/apache/coy

svn commit: r1514653 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 11:01:40 2013 New Revision: 1514653 URL: http://svn.apache.org/r1514653 Log: Back-porting JSR-356 Add the locks to the SocketWrapper required to implement non-blocking IO Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Modified

svn commit: r1514652 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 10:58:18 2013 New Revision: 1514652 URL: http://svn.apache.org/r1514652 Log: Move method location in file for consistency Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrap

svn commit: r1514651 - in /tomcat/tc7.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 10:55:12 2013 New Revision: 1514651 URL: http://svn.apache.org/r1514651 Log: Back-porting JSR-356 Rename SocketStatus.OPEN -> SocketStatus.OPEN_READ Add SocketStatus.OPEN_WRITE Required by the changes to implement non-blocking IO. Modified: tomcat/tc7.0.x/trunk/

svn commit: r1514648 - in /tomcat/tc7.0.x/trunk/res: checkstyle/org-import-control.xml maven/tomcat-coyote.pom

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 10:51:42 2013 New Revision: 1514648 URL: http://svn.apache.org/r1514648 Log: Back-porting JSR-356 Coyote has new dependency on Servlet API because upgrade mechanism uses Servlet[In|Out]putStream. Modified: tomcat/tc7.0.x/trunk/res/checkstyle/org-import-control.

svn commit: r1514643 - /tomcat/trunk/java/javax/servlet/http/WebConnection.java

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 10:26:23 2013 New Revision: 1514643 URL: http://svn.apache.org/r1514643 Log: @since on class, no need to have it on methods as well Modified: tomcat/trunk/java/javax/servlet/http/WebConnection.java Modified: tomcat/trunk/java/javax/servlet/http/WebConnection.ja

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-16 Thread Niki Dokovski
On Fri, Aug 16, 2013 at 11:01 AM, Mark Thomas wrote: > On 16/08/2013 08:16, Niki Dokovski wrote: > > On Fri, Aug 16, 2013 at 9:54 AM, Mark Thomas wrote: > > > >> Christopher Schultz wrote: > >>> Mark, > >>> > >>> On 8/15/13 6:47 PM, Mark Thomas wrote: > This isn't going to be quite as simp

svn commit: r1514618 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties

2013-08-16 Thread markt
Author: markt Date: Fri Aug 16 08:46:32 2013 New Revision: 1514618 URL: http://svn.apache.org/r1514618 Log: Remove unused value Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.prop

Re: Code style rules: Line length

2013-08-16 Thread Konstantin Kolinko
2013/8/14 Mark Thomas : > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with that. > > There is a mix

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-16 Thread Mark Thomas
On 16/08/2013 08:16, Niki Dokovski wrote: > On Fri, Aug 16, 2013 at 9:54 AM, Mark Thomas wrote: > >> Christopher Schultz wrote: >>> Mark, >>> >>> On 8/15/13 6:47 PM, Mark Thomas wrote: This isn't going to be quite as simple as I first thought. The WebSocket client API requires Jav

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-16 Thread Mark Thomas
Nick Williams wrote: > >On Aug 15, 2013, at 5:47 PM, Mark Thomas wrote: >> My (untested) plan is as follows: >> - Create a WebSocket module >> - Back-port (i.e. copy) the trunk code to that module >> - Build just that module with Java 7 >> - Make the minimum changes necessary to get it to work >>

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-16 Thread Niki Dokovski
On Fri, Aug 16, 2013 at 9:54 AM, Mark Thomas wrote: > Christopher Schultz wrote: > >Mark, > > > >On 8/15/13 6:47 PM, Mark Thomas wrote: > >> This isn't going to be quite as simple as I first thought. > >> > >> The WebSocket client API requires Java SE 7 or later. > >> The WebSocket server API re

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4840 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source