Re: [GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed
2014-07-10 7:02 GMT+04:00 Bill Barker billbar...@apache.org: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-bio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 6 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-bio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/index.html Test org.apache.catalina.session.TestPersistentManager FAILED [[[ Testsuite: org.apache.catalina.session.TestPersistentManager Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.868 sec - Standard Error - 10-Jul-2014 02:51:45.769 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler [http-bio-127.0.0.1-auto-1] 10-Jul-2014 02:51:45.811 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service Tomcat 10-Jul-2014 02:51:45.822 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet Engine: Apache Tomcat/8.0.10-dev 10-Jul-2014 02:51:46.116 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler [http-bio-127.0.0.1-auto-1-45846] 10-Jul-2014 02:51:47.503 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler [http-bio-127.0.0.1-auto-1-45846] 10-Jul-2014 02:51:47.505 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service Tomcat 10-Jul-2014 02:51:47.526 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler [http-bio-127.0.0.1-auto-1-45846] 10-Jul-2014 02:51:47.527 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler [http-bio-127.0.0.1-auto-1-45846] - --- Testcase: backsUpOnce took 2.848 sec FAILED expected:[4AC2976017F91624B46E2D7D78F6ABE8] but was:[] junit.framework.AssertionFailedError: expected:[4AC2976017F91624B46E2D7D78F6ABE8] but was:[] at org.apache.catalina.session.TestPersistentManager.backsUpOnce(TestPersistentManager.java:88) ]]] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609435 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_10: ./ build.properties.default
Author: markt Date: Thu Jul 10 10:22:59 2014 New Revision: 1609435 URL: http://svn.apache.org/r1609435 Log: Tag 8.0.10 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_10/ - copied from r1609431, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default?rev=1609435r1=1609431r2=1609435view=diff == --- tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default (original) +++ tomcat/tc8.0.x/tags/TOMCAT_8_0_10/build.properties.default Thu Jul 10 10:22:59 2014 @@ -27,7 +27,7 @@ version.major=8 version.minor=0 version.build=10 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r5812 [2/2] - in /dev/tomcat/tomcat-8/v8.0.10: ./ bin/ bin/embed/ bin/extras/ src/
Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.tar.gz.md5 == --- dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.tar.gz.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.tar.gz.md5 Thu Jul 10 12:31:43 2014 @@ -0,0 +1 @@ +60abec76f3af0098be78355537abb97e *apache-tomcat-8.0.10-src.tar.gz \ No newline at end of file Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip == Binary file - no diff available. Propchange: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip -- svn:mime-type = application/octet-stream Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.asc == --- dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.asc Thu Jul 10 12:31:43 2014 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Version: GnuPG v1.4.9 (MingW32) + +iQIcBAABAgAGBQJTvnXIAAoJEBDAHFovYFnnTlAP/1mlySZRtH6PBA9eWkio2rG2 +FcnVjhChMIX9G570Y2heZuIV8Z5+aJ0zxDjlYKMu7KRh+f1Jx6DWVoNtOTBZh0Qh +IbFMiJNvqmD2Rm1cPmz0+2yunA76TjqaoqduDNJ3l6Y0wXnl+oaTEIB29FPJ9xSP +ztgClylavdL0ghbvKGzOj7YoM2MY9VGt2e99aiCgtBsPFBIvW3X6lcLnj2mxOXIZ +F7inE5aJ2dtTRcfuhXxiS3U1+DlhIXXodzJ2mp8eaDF7y99Txi25BXZbT4aWmPSc +O5tQ1pmI27qdV6MTMMp90FRiMiQH3QOnANEAR4/KNOxXyr48zAVGZBCJLBbGWdEK +NQo0myQ1mUKGEjknwewoFd9G3094r/QA7fbtfX3vPhSVFdDbWyCFB8ksX5G0+gMH +3Bt0Z2EX1LspeVXSij1b1ByCM8RcAtib3tB3M6ctX95+CFxhPbfWsEINWkIWRxJW +5rHBwZQ9RzpaG+dpAZqKV4iLvq94mHMbM0t45+9rvq6mfj7FjVcD3aN0Pu84pbOg +P2RbMEFHPeoJHXCNQxxZThumyIn2akLzRN4xkqz6wL/Mz4KfVXsH2jyZC/NGf57v +i638IREeNMzTMfe5bDM13skxfqrCAIHNPBq3GGdo8NeDnUl6UMZYP+KbPdG9LR+d +1DKuvPFsI4gqZ00B74bE +=W1Tn +-END PGP SIGNATURE- Added: dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.md5 == --- dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.10/src/apache-tomcat-8.0.10-src.zip.md5 Thu Jul 10 12:31:43 2014 @@ -0,0 +1 @@ +dc88454417151d55b70bb1c5340e468d *apache-tomcat-8.0.10-src.zip \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
Mark, On 7/9/14, 12:46 PM, Mark Thomas wrote: On a related topic, it would be extremely useful if the available ciphers were exposed through the native interface. Anyone with C skills fancy taking a look? My main motivation for this is that we can write a unit test that checks the mapping of OpenSSL ciphers to JSSE ciphers and highlights (by a failure) when the mapping changes (e.g. one of them adds support for a new cipher). So you want to: 1. Take a cipher suite string and run it through Rémy's JSSE code 2. Take the same cipher suite string and run it through OpenSSL 3. Compare the two resulting cipher suite lists to ensure they are the same (barring absent ciphers in each implementation) ? While step 2 could be done via JNI, it could also be done like this: System.exec(openssl ciphers cipher suites); Since OpenSSL and JSSE support different sets of ciphers out of the box, does that mean that we'll have to maintain a complicated set of allowed inconsistencies based upon the combination of JVM and OpenSSL version? For example, OpenSSL prior to 1.0.something do not have ECDHE ciphers, and at some point they became available in JSSE. Unless you have matching versions of both, you'll get a failure. I think it would be fairly chaotic. -chris signature.asc Description: OpenPGP digital signature
Re: Safe default SSL ciphers
On 10/07/2014 11:20, jean-frederic clere wrote: On 09/07/14 18:46, Mark Thomas wrote: snip/ My main motivation for this is that we can write a unit test that checks the mapping of OpenSSL ciphers to JSSE ciphers and highlights (by a failure) when the mapping changes (e.g. one of them adds support for a new cipher). There is a setCipherSuite() in the native probably adding a getCipherSuite() would do the trick. I'd expect getCipherSuite() to return the current list of ciphers in use. What I'm after is getSupportedCipherSuites() or similar. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609528 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_55: ./ build.properties.default
Author: violetagg Date: Thu Jul 10 17:54:52 2014 New Revision: 1609528 URL: http://svn.apache.org/r1609528 Log: Tag 7.0.55 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ (props changed) - copied from r1609522, tomcat/tc7.0.x/trunk/ Modified: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/build.properties.default Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:append = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:label = Bugzilla ID (optional) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- bugtraq:logregex (added) +++ bugtraq:logregex Thu Jul 10 17:54:52 2014 @@ -0,0 +1,2 @@ +(https?\://issues.apache.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+) +(\d+) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- bugtraq:message (added) +++ bugtraq:message Thu Jul 10 17:54:52 2014 @@ -0,0 +1 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:number = true Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- bugtraq:warnifnoissue = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- svn:ignore (added) +++ svn:ignore Thu Jul 10 17:54:52 2014 @@ -0,0 +1,7 @@ +.* +build.properties +logs +nbproject +output +work +*.iml Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_55/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Thu Jul 10 17:54:52 2014 @@ -0,0 +1 @@ +/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114 ,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342
[Tomcat Wiki] Update of ReleaseProcess by VioletaGeorgieva
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The ReleaseProcess page has been changed by VioletaGeorgieva: https://wiki.apache.org/tomcat/ReleaseProcess?action=diffrev1=9rev2=10 == If the vote does not pass == * Update the release date in the changelog to quot;not releasedquot; + * Drop the artifacts from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/ + * Drop the maven artifacts from the staged maven repository - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56568] Incompatible change in JSPs only permit GET POST or HEAD
https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 --- Comment #12 from Grigory gkis...@yandex.ru --- UPDATE: As of Tomcat 8.0.9 when a JSP is used to generate an error page, any HTTP method will be allowed. Good news, thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Safe default SSL ciphers
Mark, On 7/10/14, 11:01 AM, Mark Thomas wrote: On 10/07/2014 14:27, Christopher Schultz wrote: Mark, On 7/9/14, 12:46 PM, Mark Thomas wrote: On a related topic, it would be extremely useful if the available ciphers were exposed through the native interface. Anyone with C skills fancy taking a look? My main motivation for this is that we can write a unit test that checks the mapping of OpenSSL ciphers to JSSE ciphers and highlights (by a failure) when the mapping changes (e.g. one of them adds support for a new cipher). So you want to: 1. Take a cipher suite string and run it through Rémy's JSSE code 2. Take the same cipher suite string and run it through OpenSSL 3. Compare the two resulting cipher suite lists to ensure they are the same (barring absent ciphers in each implementation) ? Not what I had in mind but that would be useful too. What I wanted to do was: - get the list of ciphers from OpenSSL - check that each entry was either mapped to a JSSE cipher or in a list of known unmappable ciphers - check that every JSSE entry we expected to be mapped as was mapped To put it another way, I want a unit test that fails if JSSE or OpenSSL add or remove a cipher and/or the mapping from JSSE to OpenSSL changes so we can investigate. Okay, that sounds like what I was trying to express above, regardless of the exact method of doing so. While step 2 could be done via JNI, it could also be done like this: System.exec(openssl ciphers cipher suites); Since OpenSSL and JSSE support different sets of ciphers out of the box, does that mean that we'll have to maintain a complicated set of allowed inconsistencies based upon the combination of JVM and OpenSSL version? Nope. Just the mapping from latest OpenSSL to latest version of Java that that version of Tomcat builds with. Okay. For example, OpenSSL prior to 1.0.something do not have ECDHE ciphers, and at some point they became available in JSSE. Unless you have matching versions of both, you'll get a failure. I think it would be fairly chaotic. Which is why you work with the latest of each rather than trying to track all possible combinations. That seems reasonable. Any reason not to use openssl ciphers rather than building a JNI interface to the OpenSSL call? In order to get that list, you actually have to build an SSL context, then an SSL object in C and set it all up properly to get the list. To do it accurately, I think you might have to initialize tcnative with a certificate and all that jazz. The ciphers tool that OpenSSL ships already does all that stuff with dummy certs and/or ones that you configure somewhere (I don't feel like tracking-down all the code that loads those defaults, etc. because the OpenSSL code is so horrible). -chris signature.asc Description: OpenPGP digital signature
[Tomcat Wiki] Update of FAQ/Password by KonstantinKolinko
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The FAQ/Password page has been changed by KonstantinKolinko: https://wiki.apache.org/tomcat/FAQ/Password?action=diffrev1=9rev2=10 Comment: Add emphasis == Why are plain text passwords in the config files? == Because there is no good way to secure them. When Tomcat needs to connect to a database, it needs the original password. While the password could be encoded, there still needs to be a mechanism to decode it. And since the source to Tomcat is freely available, the attacker would know the decoding method. So at best, the password is obscured - but not really protected. Please see the user and dev list archives for flame wars about this topic. - That said, any configuration file that does contain a password needs to be appropriately secured. That means limiting access to the file so that it could be read only by the user that Tomcat process runs as and root (or the administrator on Windows). + That said, any configuration file that does contain a password needs to be appropriately secured. That means '''limiting access''' to the file so that it could be read only by the user that Tomcat process runs as and root (or the administrator on Windows). In [[http://www.catb.org/~esr/writings/cathedral-bazaar/|The Cathedral and the Bazaar]], Eric S. Raymond recounts a story where his fetchmail users asked for encrypted passwords in the .fetchmailrc file (which is almost identical to the situation posed here with server.xml). He refused [[http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s09.html|using the same arguments posed here]]: encrypting or otherwise obfuscating the password in server.xml does not provide any real security: only security by obscurity which isn't actually secure. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56709] New: No TLD files message refers to invalid property DefaultJarScanner.jarsToSkip
https://issues.apache.org/bugzilla/show_bug.cgi?id=56709 Bug ID: 56709 Summary: No TLD files message refers to invalid property DefaultJarScanner.jarsToSkip Product: Tomcat 8 Version: 8.0.9 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: robert.k...@ncogroup.com The error log entry: org.apache.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found in [file:something.jar]. Consider adding the JAR to the tomcat.util.scan.DefaultJarScanner.jarsToSkip property in CATALINA_BASE/conf/catalina.properties file. refers to an undocumented property tomcat.util.scan.DefaultJarScanner.jarsToSkip. I tried using this in my configuration, and I did not get the expected result. What is documented is tomcat.util.scan.StandardJarScanFilter.jarsToSkip. I propose that the error message be updated to reflect the actual name of the property setting. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-11 0:22 GMT+04:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-07-10 22:40 GMT+04:00 Falco Schwarz hid...@falco.me: I am seeing NPEs after reloading a web application with a custom error-page. Just downloaded the sample.war, added the following block in web.xml and thus reloaded the web application: error-page location/404.jsp/location /error-page Accessing a nonexisting page now results in NPE instead of error page being shown. After tomcat restart the error-page is shown, until the next reload of the application: I've reproduced the issue and run it with a debugger. The above scenario misses step create 404.jsp. Actually it is more severe. After reload the Mapper$ContextVersion object does not contain information on wrappers (the *wrappers fields in it contain empty lists). Thus after reload *any* page in the examples webapp is inaccessible and results in error 404. (In case of a custom error page servletContext.getRequestDispatcher(errorPage.getLocation()); call in StandardHostValve.custom() returns null ). Unfortunately, it is [x] Broken - do not release 7.0.x is also affected. I'd be better to retag after the fix. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-10 16:53 GMT+02:00 Mark Thomas ma...@apache.org:The proposed 8.0.10 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.0.10 Although it is not a blocker since it is not a regression, the NIO2 sendfile code turned out mostly broken. It should now be fixed. Rémy
Re: Time for 7.0.55
Hi, 2014-07-09 21:10 GMT+03:00 Violeta Georgieva miles...@gmail.com: Hi, 2014-07-09 17:35 GMT+03:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-07-09 6:39 GMT+04:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-07-08 13:45 GMT+04:00 Konstantin Kolinko knst.koli...@gmail.com : 2014-07-08 13:17 GMT+04:00 Mark Thomas ma...@apache.org: On 27/06/2014 17:20, Konstantin Kolinko wrote: 2014-06-27 18:16 GMT+04:00 Mark Thomas ma...@apache.org: On 23/06/2014 14:00, Violeta Georgieva wrote: 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko Mapper issues: BZ 44312: Fixed. Proposed for 6.0. BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive. Not backported. I backported testcase for it (r1604846), but neither Gump nor Testbot fail with it. BZ 56658: Not started. I plan to work on Mapper tonight and tomorrow. Any progress on this? Looking at Bugzilla, these are the only open issues for 7.0.x and I assume we want to resolve them before a 7.0.55 tag. All are fixed in Tomcat 8 a week ago. I shall backport 56653, 56658 to Tomcat 7 today. Issue 56653 fixed. This leaves 56658. Issue 56658 fixed. Mapper issues fixed. I did run testsuite with NIO connector - all OK. I think we are OK to go with a release. Thanks a lot. I'll start the tagging tomorrow. I'm receiving the following exception: [exec] [junit] Jul 10, 2014 11:33:16 PM org.apache.coyote.http11.AbstractHttp11Processor process [exec] [junit] SEVERE: Error processing request [exec] [junit] java.lang.ArrayIndexOutOfBoundsException: -1 [exec] [junit] at org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785) [exec] [junit] at org.apache.tomcat.util.http.mapper.Mapper.map(Mapper.java:662) [exec] [junit] at org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:714) [exec] [junit] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:403) [exec] [junit] at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1070) [exec] [junit] at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611) [exec] [junit] at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:314) [exec] [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [exec] [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [exec] [junit] at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [exec] [junit] at java.lang.Thread.run(Thread.java:662) The following quick patch fixes the problem: Index: C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java === --- C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (revision 1609565) +++ C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (working copy) @@ -779,18 +779,21 @@ if (version != null) { contextVersion = exactFind(contextVersions, version); } +if (contextVersion == null) { +// Return the latest version +contextVersion = contextVersions[versionCount - 1]; +} +} else if (versionCount == 1) { +contextVersion = contextVersions[0]; } -if (contextVersion == null) { -// Return the latest version -contextVersion = contextVersions[versionCount - 1]; + +if (contextVersion != null) { +mappingData.context = contextVersion.object; +mappingData.contextSlashCount = contextVersion.slashCount; +// Wrapper mapping +internalMapWrapper(contextVersion, uri, mappingData); } -mappingData.context = contextVersion.object; -mappingData.contextSlashCount = contextVersion.slashCount; - -// Wrapper mapping -internalMapWrapper(contextVersion, uri, mappingData); - } Regards, Violeta Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56710] New: IllegalStateException: The resources may not be accessed during webapp reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56710 Bug ID: 56710 Summary: IllegalStateException: The resources may not be accessed during webapp reload Product: Tomcat 8 Version: 8.0.9 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: knst.koli...@gmail.com I encountered this while testing 8.0.10 release candidate while investigating bug 56658 regression. Steps to reproduce - see Comment 3 in bug 56658, but skip step 4, https://issues.apache.org/bugzilla/show_bug.cgi?id=56658#c3 That is: cause reload of the examples webapp, but ask for index.html while reloading has not been completed yet. Expected: The request shall wait for web application reload to complete and then display the page (or error 404 in case of that bug that I was investigating). There is a loop in CoyoteAdapter that waits while context is being reloaded. Actual: A blank page is rendered, and an IllegalStateException is logged. A snippet from catalina.2014-07-11.log: [[[ 11-Jul-2014 00:45:08.124 INFO [ContainerBackgroundProcessor[StandardEngine[Catalina]]] org.apache.catalina.startup.HostConfig.reload Reloading context [/examples] 11-Jul-2014 00:45:08.125 INFO [ContainerBackgroundProcessor[StandardEngine[Catalina]]] org.apache.catalina.core.StandardContext.reload Reloading Context with name [/examples] has started 11-Jul-2014 00:45:08.164 SEVERE [http-nio-8080-exec-1] org.apache.coyote.http11.AbstractHttp11Processor.process Error processing request java.lang.IllegalStateException: The resources may not be accessed if they are not currently started at org.apache.catalina.webresources.StandardRoot.validate(StandardRoot.java:245) at org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:212) at org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:206) at org.apache.catalina.mapper.Mapper.internalMapWrapper(Mapper.java:946) at org.apache.catalina.mapper.Mapper.internalMap(Mapper.java:765) at org.apache.catalina.mapper.Mapper.map(Mapper.java:635) at org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:861) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:521) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:658) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:222) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1566) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1523) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) 11-Jul-2014 00:45:09.007 INFO [ContainerBackgroundProcessor[StandardEngine[Catalina]]] org.apache.catalina.core.StandardContext.reload Reloading Context with name [/examples] is completed ]]] A snippet from localhost.2014-07-11.log: [[[ 127.0.0.1 - - [11/Jul/2014:00:44:10 +0400] GET /examples/index.html HTTP/1.1 200 1156 127.0.0.1 - - [11/Jul/2014:00:44:21 +0400] GET /examples/index.html HTTP/1.1 304 - 127.0.0.1 - - [11/Jul/2014:00:44:21 +0400] GET /favicon.ico HTTP/1.1 304 - 127.0.0.1 - - [11/Jul/2014:00:44:24 +0400] GET /examples/index.html HTTP/1.1 304 - 127.0.0.1 - - [11/Jul/2014:00:44:50 +0400] GET /examples/index.html HTTP/1.1 404 1000 127.0.0.1 - - [11/Jul/2014:00:44:50 +0400] GET /favicon.ico HTTP/1.1 304 - 127.0.0.1 - - [11/Jul/2014:00:45:08 +0400] GET /examples/index.html HTTP/1.1 500 - 127.0.0.1 - - [11/Jul/2014:00:45:11 +0400] GET /examples/index.html HTTP/1.1 404 1000 127.0.0.1 - - [11/Jul/2014:00:45:16 +0400] GET /examples/index.html HTTP/1.1 404 1000 ]]] The 404 are from the bug that I was investigating. The 500 is from this bug. I was running with jpda debugging enabled, so webapp reload was a bit slower than usual. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609575 - in /tomcat/jk/trunk/native/common: jk_lb_worker.c jk_lb_worker.h
Author: rjung Date: Thu Jul 10 21:36:08 2014 New Revision: 1609575 URL: http://svn.apache.org/r1609575 Log: Add utility methods. Will be used in status worker during logging. Modified: tomcat/jk/trunk/native/common/jk_lb_worker.c tomcat/jk/trunk/native/common/jk_lb_worker.h Modified: tomcat/jk/trunk/native/common/jk_lb_worker.c URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_lb_worker.c?rev=1609575r1=1609574r2=1609575view=diff == --- tomcat/jk/trunk/native/common/jk_lb_worker.c (original) +++ tomcat/jk/trunk/native/common/jk_lb_worker.c Thu Jul 10 21:36:08 2014 @@ -150,6 +150,14 @@ static jk_uint64_t scm(jk_uint64_t a, jk } /* Return the string representation of the lb lock type */ +/* based on the integer representation */ +const char *jk_lb_get_lock_direct(int lblock, jk_logger_t *l) +{ +return lb_locking_type[lblock]; +} + +/* Return the string representation of the lb lock type */ +/* based on the lb worker struct */ const char *jk_lb_get_lock(lb_worker_t *p, jk_logger_t *l) { return lb_locking_type[p-lblock]; @@ -168,6 +176,14 @@ int jk_lb_get_lock_code(const char *v) } /* Return the string representation of the lb method type */ +/* based on the integer representation */ +const char *jk_lb_get_method_direct(int lbmethod, jk_logger_t *l) +{ +return lb_method_type[lbmethod]; +} + +/* Return the string representation of the lb method type */ +/* based on the lb worker struct */ const char *jk_lb_get_method(lb_worker_t *p, jk_logger_t *l) { return lb_method_type[p-lbmethod]; @@ -192,6 +208,14 @@ int jk_lb_get_method_code(const char *v) } /* Return the string representation of the balance worker state */ +/* based on the integer representation */ +const char *jk_lb_get_state_direct(int state, jk_logger_t *l) +{ +return lb_state_type[state]; +} + +/* Return the string representation of the balance worker state */ +/* based on the sub worker struct */ const char *jk_lb_get_state(lb_sub_worker_t *p, jk_logger_t *l) { return lb_state_type[p-s-state]; Modified: tomcat/jk/trunk/native/common/jk_lb_worker.h URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_lb_worker.h?rev=1609575r1=1609574r2=1609575view=diff == --- tomcat/jk/trunk/native/common/jk_lb_worker.h (original) +++ tomcat/jk/trunk/native/common/jk_lb_worker.h Thu Jul 10 21:36:08 2014 @@ -208,10 +208,13 @@ typedef struct lb_worker lb_worker_t; int JK_METHOD lb_worker_factory(jk_worker_t **w, const char *name, jk_logger_t *l); +const char *jk_lb_get_lock_direct(int lblock, jk_logger_t *l); const char *jk_lb_get_lock(lb_worker_t *p, jk_logger_t *l); int jk_lb_get_lock_code(const char *v); +const char *jk_lb_get_method_direct(int lbmethod, jk_logger_t *l); const char *jk_lb_get_method(lb_worker_t *p, jk_logger_t *l); int jk_lb_get_method_code(const char *v); +const char *jk_lb_get_state_direct(int state, jk_logger_t *l); const char *jk_lb_get_state(lb_sub_worker_t *p, jk_logger_t *l); int jk_lb_get_state_code(const char *v); const char *jk_lb_get_activation_direct(int activation, jk_logger_t *l); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56710] IllegalStateException: The resources may not be accessed during webapp reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56710 Remy Maucherat r...@apache.org changed: What|Removed |Added OS||All --- Comment #1 from Remy Maucherat r...@apache.org --- Expected: The request shall wait for web application reload to complete and then display the page (or error 404 in case of that bug that I was investigating). There is a loop in CoyoteAdapter that waits while context is being reloaded. This feature is actually a bug, the server should return a response and move on. It is not a good idea to tie up an indefinite amount of requests/threads waiting for something to happen. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.10
2014-07-11 0:27 GMT+04:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-07-11 0:22 GMT+04:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-07-10 22:40 GMT+04:00 Falco Schwarz hid...@falco.me: I am seeing NPEs after reloading a web application with a custom error-page. Just downloaded the sample.war, added the following block in web.xml and thus reloaded the web application: (...) Actually it is more severe. After reload the Mapper$ContextVersion object does not contain information on wrappers (the *wrappers fields in it contain empty lists). Thus after reload *any* page in the examples webapp is inaccessible and results in error 404. (In case of a custom error page servletContext.getRequestDispatcher(errorPage.getLocation()); call in StandardHostValve.custom() returns null ). Unfortunately, it is [x] Broken - do not release 7.0.x is also affected. I'd be better to retag after the fix. Thus far on the Mapper issues 1) This issue is regression from BZ 56658. I documented it there, https://issues.apache.org/bugzilla/show_bug.cgi?id=56658#c3 I think I know how to fix it. 2) I encountered another issue - BZ 56710 From the look at it I think that it existed for previous versions as well. I wonder why nobody reported it. I have no idea on a fix yet. 3) Issue that Violetta reported in the Time for 7.0.55 thread, http://markmail.org/message/57vijgczkqn4aopx I think I know how to fix it. Needs a test case. I wonder why I have not seen it during my test runs. 4) Searching for string Mapper across junit logs from a full TC7 test run, I see a lot of messages like Jul 09, 2014 5:19:56 PM org.apache.tomcat.util.http.mapper.Mapper findContextVersion SEVERE: No context version found: /test (The above one is from org.apache.catalina.core.TestStandardContextResources) This needs some investigation. An easy solution is to suppress those messages. (7.0.54 had those messages, but the code to display them was broken). I do not have much time tomorrow, but I will try something. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56710] IllegalStateException: The resources may not be accessed during webapp reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56710 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Remy Maucherat from comment #1) It is not a good idea (...) Ack, but some people find it useful. See bug 53024 that asked for it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609589 - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/common/ native/iis/ native/netscape/ xdocs/generic_howto/ xdocs/miscellaneous/ xdocs/reference/
Author: rjung Date: Thu Jul 10 23:27:52 2014 New Revision: 1609589 URL: http://svn.apache.org/r1609589 Log: BZ 56661: Fix Servlet API getLocalAddr(). Forward local IP address which is not part of AJP protocol via custom request attribute named AJP_LOCAL_ADDR. Currently Tomcat will handle getLocalAddr(U) like getLocalName(). Tomcat versions can now check for the new attribute and use it if available. Likely to be used by forthcoming TC 6.0.41, 7.0.55 and 8.0.11. Modified: tomcat/jk/trunk/native/apache-1.3/mod_jk.c tomcat/jk/trunk/native/apache-2.0/mod_jk.c tomcat/jk/trunk/native/common/jk_ajp_common.c tomcat/jk/trunk/native/common/jk_ajp_common.h tomcat/jk/trunk/native/common/jk_service.h tomcat/jk/trunk/native/iis/jk_isapi_plugin.c tomcat/jk/trunk/native/netscape/jk_nsapi_plugin.c tomcat/jk/trunk/xdocs/generic_howto/proxy.xml tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml tomcat/jk/trunk/xdocs/reference/apache.xml Modified: tomcat/jk/trunk/native/apache-1.3/mod_jk.c URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-1.3/mod_jk.c?rev=1609589r1=1609588r2=1609589view=diff == --- tomcat/jk/trunk/native/apache-1.3/mod_jk.c (original) +++ tomcat/jk/trunk/native/apache-1.3/mod_jk.c Thu Jul 10 23:27:52 2014 @@ -71,6 +71,7 @@ #define JK_ENV_REMOTE_USER (JK_REMOTE_USER) #define JK_ENV_AUTH_TYPE(JK_AUTH_TYPE) #define JK_ENV_LOCAL_NAME (JK_LOCAL_NAME) +#define JK_ENV_LOCAL_ADDR (JK_LOCAL_ADDR) #define JK_ENV_LOCAL_PORT (JK_LOCAL_PORT) #define JK_ENV_HTTPS(HTTPS) #define JK_ENV_CERTS(SSL_CLIENT_CERT) @@ -181,6 +182,7 @@ typedef struct char *remote_user_indicator; char *auth_type_indicator; char *local_name_indicator; +char *local_addr_indicator; char *local_port_indicator; /* @@ -827,6 +829,12 @@ static int init_ws_service(apache_privat s-server_name = get_env_string(r, (char *)ap_get_server_name(r), conf-local_name_indicator, 0); +/* get the local IP address */ +/* s-local_addr = r-connection-local_ip; */ +/* XXX : a la jk2 */ +s-local_addr = get_env_string(r, r-connection-local_ip, + conf-local_addr_indicator, 0); + /* get the real port (otherwise redirect failed) */ /* s-server_port = htons( r-connection-local_addr.sin_port ); */ /* XXX : a la jk2 */ @@ -1906,6 +1914,16 @@ static const char *jk_set_local_name_ind return NULL; } +static const char *jk_set_local_addr_indicator(cmd_parms * cmd, + void *dummy, char *indicator) +{ +server_rec *s = cmd-server; +jk_server_conf_t *conf = +(jk_server_conf_t *) ap_get_module_config(s-module_config, jk_module); +conf-local_addr_indicator = ap_pstrdup(cmd-pool, indicator); +return NULL; +} + static const char *jk_set_local_port_indicator(cmd_parms * cmd, void *dummy, char *indicator) { @@ -2315,6 +2333,8 @@ static const command_rec jk_cmds[] = { Name of the Apache environment that contains the type of authentication}, {JkLocalNameIndicator, jk_set_local_name_indicator, NULL, RSRC_CONF, TAKE1, Name of the Apache environment that contains the local name}, +{JkLocalAddrIndicator, jk_set_local_addr_indicator, NULL, RSRC_CONF, TAKE1, + Name of the Apache environment that contains the local IP address}, {JkLocalPortIndicator, jk_set_local_port_indicator, NULL, RSRC_CONF, TAKE1, Name of the Apache environment that contains the local port}, @@ -2667,6 +2687,7 @@ static void *create_jk_config(ap_pool * c-remote_user_indicator = JK_ENV_REMOTE_USER; c-auth_type_indicator = JK_ENV_AUTH_TYPE; c-local_name_indicator = JK_ENV_LOCAL_NAME; +c-local_addr_indicator = JK_ENV_LOCAL_ADDR; c-local_port_indicator = JK_ENV_LOCAL_PORT; /* Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1609589r1=1609588r2=1609589view=diff == --- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original) +++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Thu Jul 10 23:27:52 2014 @@ -106,6 +106,7 @@ #define JK_ENV_REMOTE_USER (JK_REMOTE_USER) #define JK_ENV_AUTH_TYPE(JK_AUTH_TYPE) #define JK_ENV_LOCAL_NAME (JK_LOCAL_NAME) +#define JK_ENV_LOCAL_ADDR (JK_LOCAL_ADDR) #define JK_ENV_LOCAL_PORT (JK_LOCAL_PORT) #define JK_ENV_HTTPS(HTTPS) #define JK_ENV_CERTS(SSL_CLIENT_CERT) @@ -211,6 +212,7 @@ typedef struct char *remote_user_indicator; char *auth_type_indicator; char
svn commit: r1609593 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java Constants.java
Author: rjung Date: Thu Jul 10 23:52:22 2014 New Revision: 1609593 URL: http://svn.apache.org/r1609593 Log: BZ 56661: Fix Servlet API getLocalAddr(). Use new custom request attribute AJP_LOCAL_ADDR forwarded by the next mod_jk 1.2.41 to set the local IP address returned by getLocalAddr(): Before this change Tomcat handled getLocalAddr() like getLocalName(). Needs some testing before backport. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/Constants.java Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1609593r1=1609592r2=1609593view=diff == --- tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Thu Jul 10 23:52:22 2014 @@ -486,13 +486,17 @@ public abstract class AbstractAjpProcess break; } case REQ_LOCAL_ADDR_ATTRIBUTE: { -// Copy from local name for now, which should simply be an address -request.localAddr().setString(request.localName().toString()); +// Automatically populated during prepareRequest() when using +// modern AJP forwarder, otherwise copy from local name +if (request.localAddr().isNull()) { +request.localAddr().setString(request.localName().toString()); +} break; } case REQ_REMOTEPORT_ATTRIBUTE: { // NO-OP -// This information is not available when using the AJP protocol +// Automatically populated during prepareRequest() when using +// modern AJP forwarder, otherwise not available break; } case REQ_LOCALPORT_ATTRIBUTE: { @@ -1221,13 +1225,15 @@ public abstract class AbstractAjpProcess requestHeaderMessage.getBytes(tmpMB); String v = tmpMB.toString(); /* - * AJP13 misses to forward the remotePort. - * Allow the AJP connector to add this info via - * a private request attribute. - * We will accept the forwarded data as the remote port, - * and remove it from the public list of request attributes. + * AJP13 misses to forward the local IP address and the + * remote port. Allow the AJP connector to add this info via + * private request attributes. + * We will accept the forwarded data and remove it from the + * public list of request attributes. */ -if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) { +if(n.equals(Constants.SC_A_REQ_LOCAL_ADDR)) { +request.localAddr().setString(v); +} else if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) { try { request.setRemotePort(Integer.parseInt(v)); } catch (NumberFormatException nfe) { Modified: tomcat/trunk/java/org/apache/coyote/ajp/Constants.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/Constants.java?rev=1609593r1=1609592r2=1609593view=diff == --- tomcat/trunk/java/org/apache/coyote/ajp/Constants.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/Constants.java Thu Jul 10 23:52:22 2014 @@ -81,6 +81,7 @@ public final class Constants { /** * AJP private request attributes */ +public static final String SC_A_REQ_LOCAL_ADDR = AJP_LOCAL_ADDR; public static final String SC_A_REQ_REMOTE_PORT = AJP_REMOTE_PORT; // Terminates list of attributes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 --- Comment #14 from Rainer Jung rainer.j...@kippdata.de --- I added support for the new attribute to TC 8 in r1609593. Needs some more testing before porting back to TC7 an probably 6. A full test needs a dev build of mod_jk r1609589 or later. Alternatively one can try in Apache: SetEnvIf Server_Addr (.*) AJP_LOCAL_ADDR=$1 JkEnvVar AJP_LOCAL_ADDR Which for current releases of mod_jk would send a request attribute named AJP_LOCAL_ADDR with its value set to the value of the Apache internal variable SERVER_ADDR which in turn contains the local IP address of Apache. Starting with mod_jk 1.2.41 the attribute will be set without explicit configuration. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Working tc native build
On 08.07.2014 18:14, Mark Thomas wrote: On 08/07/2014 16:39, Christopher Schultz wrote: Anyway, here's what the above tool says tcnative-1.dll requires in terms of direct dependencies: - USER32.dll - PSAPI.dll - SHLWAPI.dll - KERNEL32.dll - ADVAPI32.dll - WS2_32.dll - MSWSOCK.dll - MSVCR100.dll Is that last one the one you were concerned about? Yes. If so, what's the procedure for statically-linking that library into tcnative ... or, better yet, why is that library not necessary when using MSVS 2006 or whatever? Using VS6 or Mladen's toolkit, it builds against msvcrt.dll which is part of the base OS. For reasons I haven't dug into, later versions of Visual Studio build upon a newer version of that library and despite quite a lot of searching I haven't found a way to make later versions of Visual Studio build against the older dll. The dependency on the modern (versioned) msvcrXXX.dll only gets problematic when you need to mix binaries and libs build with different MSVC versions in the same process. For instance building modules for the Apache web server and the server itself with different MSVC versions can get you in trouble, because the msvcrXXX.dll version depends 1:1 on the MSVC version and different versions of the lib are not expected to interact nicely in the same process. In the tcnative case, this would only happen, if either the jvm itself or another native agent or library loaded into the jvm would be linked against a different msvcrXXX.dll. Concerning agents we can't be safe because we can't control what users load. Concerning the jvm I did a quick check with 1.7.0_51 64 bit on Windows 7 and depends.exe show the dependency to msvcr100.dll in bin/server/jvm.dll. The same for Java 8. So to me it looks one can only either use the old way of building against the old msvcrt.dll without version - which seems to be no longer really supported and might vanish - or sync on the msvc version that is used to build the jvm and hope they keep it stable per jvm major version. For end users the dependency on the dll is not a big problem, because Microsoft provides it for redistribution or download. Of course we can't bundle it due to license incompatibility. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 30 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140711.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/tar get/commons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20140711.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20140711.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20140711.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-18.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar setproxy: downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 5.8-SNAPSHOT on 2904 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java:966: Line matches the illegal pattern '\s+$'. BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:539: Got 1 errors and 0 warnings. Total time: 30 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2014071112, vmgump.apache.org:vmgump:2014071112 Gump E-mail Identifier (unique within run) #5. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609601 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
Author: rjung Date: Fri Jul 11 01:16:51 2014 New Revision: 1609601 URL: http://svn.apache.org/r1609601 Log: Remove trailing space to please Checkstyle and Gump. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1609601r1=1609600r2=1609601view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Fri Jul 11 01:16:51 2014 @@ -963,7 +963,7 @@ public class Nio2Endpoint extends Abstra } } }; - + public SendfileState processSendfile(Nio2SocketWrapper socket) { // Configure the send file data - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609604 - /tomcat/trunk/webapps/docs/changelog.xml
Author: rjung Date: Fri Jul 11 01:28:48 2014 New Revision: 1609604 URL: http://svn.apache.org/r1609604 Log: Add changelog entry for BZ56661, r1609593. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1609604r1=1609603r2=1609604view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri Jul 11 01:28:48 2014 @@ -60,6 +60,11 @@ will now instead use the regular socket write buffer as configured. (remm) /fix + fix +bug56661/bug: Fix codegetLocalAddr()/code for AJP connectors. +The complete fix is only available with a recent AJP forwarder like +the forthcoming mod_jk 1.2.41. (rjung) + /fix /changelog /subsection subsection name=Jasper - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609606 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AbstractAjpProcessor.java java/org/apache/coyote/ajp/Constants.java webapps/docs/changelog.xml
Author: rjung Date: Fri Jul 11 01:43:33 2014 New Revision: 1609606 URL: http://svn.apache.org/r1609606 Log: BZ 56661: Fix Servlet API getLocalAddr(). Use new custom request attribute AJP_LOCAL_ADDR forwarded by the next mod_jk 1.2.41 to set the local IP address returned by getLocalAddr(): Before this change Tomcat handled getLocalAddr() like getLocalName(). Backport of r1609593 from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1609593 Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1609606r1=1609605r2=1609606view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Fri Jul 11 01:43:33 2014 @@ -423,8 +423,11 @@ public abstract class AbstractAjpProcess break; } case REQ_LOCAL_ADDR_ATTRIBUTE: { -// Copy from local name for now, which should simply be an address -request.localAddr().setString(request.localName().toString()); +// Automatically populated during prepareRequest() when using +// modern AJP forwarder, otherwise copy from local name +if (request.localAddr().isNull()) { +request.localAddr().setString(request.localName().toString()); +} break; } case REQ_SET_BODY_REPLAY: { @@ -791,13 +794,15 @@ public abstract class AbstractAjpProcess requestHeaderMessage.getBytes(tmpMB); String v = tmpMB.toString(); /* - * AJP13 misses to forward the remotePort. - * Allow the AJP connector to add this info via - * a private request attribute. - * We will accept the forwarded data as the remote port, - * and remove it from the public list of request attributes. + * AJP13 misses to forward the local IP address and the + * remote port. Allow the AJP connector to add this info via + * private request attributes. + * We will accept the forwarded data and remove it from the + * public list of request attributes. */ -if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) { +if(n.equals(Constants.SC_A_REQ_LOCAL_ADDR)) { +request.localAddr().setString(v); +} else if(n.equals(Constants.SC_A_REQ_REMOTE_PORT)) { try { request.setRemotePort(Integer.parseInt(v)); } catch (NumberFormatException nfe) { Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java?rev=1609606r1=1609605r2=1609606view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/Constants.java Fri Jul 11 01:43:33 2014 @@ -104,6 +104,7 @@ public final class Constants { /** * AJP private request attributes */ +public static final String SC_A_REQ_LOCAL_ADDR = AJP_LOCAL_ADDR; public static final String SC_A_REQ_REMOTE_PORT = AJP_REMOTE_PORT; // Terminates list of attributes Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1609606r1=1609605r2=1609606view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri Jul 11 01:43:33 2014 @@ -208,6 +208,11 @@ Allow to configure codemaxSwallowSize/code attribute of an HTTP connector via JMX. (kkolinko) /update + fix +bug56661/bug: Fix codegetLocalAddr()/code for AJP connectors. +The complete fix is only available with a recent AJP forwarder like +the forthcoming mod_jk 1.2.41. (rjung) + /fix /changelog /subsection subsection name=Jasper - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 --- Comment #15 from Rainer Jung rainer.j...@kippdata.de --- Test looked good. Ported by to TC 7 in r1609606 and proposed for TC 6. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56661] ServletRequest#getLocalAddr() returns the hostname, not the IP address
https://issues.apache.org/bugzilla/show_bug.cgi?id=56661 Rainer Jung rainer.j...@kippdata.de changed: What|Removed |Added Component|Connectors |Connectors Version|trunk |6.0.41 Product|Tomcat 8|Tomcat 6 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1609612 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Author: rjung Date: Fri Jul 11 02:03:30 2014 New Revision: 1609612 URL: http://svn.apache.org/r1609612 Log: Fix typo. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1609612r1=1609611r2=1609612view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Fri Jul 11 02:03:30 2014 @@ -46,7 +46,7 @@ changelog fix bug56661/bug: Fix Servlet API getLocalAddr(). -Works for Tomcat 6.0.41, 7.0.55 and 8.0.11 and Apache and ISAPI +Works for Tomcat 6.0.42, 7.0.55 and 8.0.11 and Apache and ISAPI plugins. (rjung) /fix update - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-bio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-bio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-BIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-BIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/gump_work/build_tomcat-trunk_tomcat-trunk-test-bio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-bio (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 24 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140711-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140711.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140711-native-src.tar.gz -Dtest.temp=output/test-tmp-BIO -Dtest.accesslog=true -Dexecute.test.nio=false -Dexecute.test.apr=false -Dexecute.test.bio=true -Dexecute.test.n io2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140711.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servle t-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat