Deprecation of SSLCertificateChainFile

2014-08-08 Thread Matt Hauck
I have noticed that as of apache httpd version 2.4.8, mod_ssl has
deprecated SSLCertificateChainFile and has extended SSLCertificateFile to
serve the same purpose by allowing the specification of the entire
certificate chain, including the server certificate up to the root. This is
easier to maintain, on a project that has to work with configuration both
for apache httpd as well as tomcat.

When can we expect tomcat's APR connector to support these newer
configuration options as mod_ssl in httpd?

Thanks.

-- 
Matt


[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-08-08 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 25 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140808.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/comm
 
ons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20140808.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20140808.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20140808.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-19.0-SNAPSHOT.jar
-
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/doc/jdbc-pool.xml:173:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/doc/jdbc-pool.xml:178:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/doc/jdbc-pool.xml:179:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/doc/jdbc-pool.xml:182:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/doc/jdbc-pool.xml:612:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/doc/jdbc-pool.xml:613:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java:62:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java:25:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java:26:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java:27:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java:28:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java:797:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk

[Bug 53088] Give PoolCleaner TimerTask a better name

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088

--- Comment #6 from Michael Osipov 1983-01...@gmx.net ---
Finally, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56318] Oracle DB cursors are leaking when using org.apache.tomcat.jdbc.pool.DataSourceFactory

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56318

--- Comment #18 from Michael Osipov 1983-01...@gmx.net ---
The revision links to Apache Directory

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56828] New: Cluster setup stopped working after 3 months in production

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56828

Bug ID: 56828
   Summary: Cluster setup stopped working after 3 months in
production
   Product: Tomcat 6
   Version: 6.0.39
  Hardware: Other
OS: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Cluster
  Assignee: dev@tomcat.apache.org
  Reporter: krishna.saran...@gmail.com

We have J2EE war application deployed in a cluster setup having two nodes.
Tomcat 6.0.39 is installed in the both nodes having identical war deployed in
both. Its deployed in Amazon AWS environment, and the two ec2-nodes are beneath
an ELB , with session stickiness enabled for JSESSIONID. Also the two tomcat
nodes are session replication enabled too.

Following is Cluster config updated server.xml file:
=
 Cluster className=org.apache.catalina.ha.tcp.SimpleTcpCluster
channelSendOptions=6 channelStartOptions=3

Manager className=org.apache.catalina.ha.session.DeltaManager
expireSessionsOnShutdown=false notifyListenersOnReplication=true /

Channel className=org.apache.catalina.tribes.group.GroupChannel

Receiver className=org.apache.catalina.tribes.transport.nio.NioReceiver
autoBind=0 selectorTimeout=5000
maxThreads=6
address=x.x.x.x port= /
Sender
className=org.apache.catalina.tribes.transport.ReplicationTransmitter
Transport
className=org.apache.catalina.tribes.transport.nio.PooledParallelSender
timeout=6
keepAliveTime=10
keepAliveCount=0
/
/Sender
Interceptor
className=org.apache.catalina.tribes.group.interceptors.TcpPingInterceptor
staticOnly=true/
Interceptor
className=org.apache.catalina.tribes.group.interceptors.TcpFailureDetector/
Interceptor
className=org.apache.catalina.tribes.group.interceptors.StaticMembershipInterceptor
Member className=org.apache.catalina.tribes.membership.StaticMember
host=x.x.x.x
port=
   
uniqueId={0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,4}/
/Interceptor
/Channel
Valve className=org.apache.catalina.ha.tcp.ReplicationValve filter= /
Valve className=org.apache.catalina.ha.session.JvmRouteBinderValve /
ClusterListener
className=org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener/
ClusterListener
className=org.apache.catalina.ha.session.ClusterSessionListener/
/Cluster

==

Receiver ip, static member ip and unique id is different in the server.xml of
the other node in the cluster.

this was running fine in production environment for 3 months. Suddenly there
was
an exception logged like this :, and started coming up infinitely.


==
Aug 6, 2014 12:00:39 AM
org.apache.catalina.tribes.group.interceptors.TcpFailureDetector
memberDisappeared
INFO: Received
memberDisappeared[org.apache.catalina.tribes.membership.MemberImpl[tcp://10.160.40.12:,10.160.40.12,,
alive=0,id={0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4 }, payload={}, command={},
domain={}, ]] message. Will verify.
Aug 6, 2014 12:00:39 AM
org.apache.catalina.tribes.group.interceptors.TcpFailureDetector
memberDisappeared
INFO: Verification complete. Member still
alive[org.apache.catalina.tribes.membership.MemberImpl[tcp://10.160.40.12:,10.160.40.12,,
alive=0,id={0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4 }, payload={}, command={},
domain={}, ]]
Aug 6, 2014 12:00:39 AM org.apache.catalina.ha.tcp.SimpleTcpCluster send
SEVERE: Unable to send message through cluster sender.
org.apache.catalina.tribes.ChannelException: Operation has timed out(6
ms.).; Faulty members:tcp://10.160.40.12:;
at
org.apache.catalina.tribes.transport.nio.ParallelNioSender.sendMessage(ParallelNioSender.java:97)
at
org.apache.catalina.tribes.transport.nio.PooledParallelSender.sendMessage(PooledParallelSender.java:53)
at
org.apache.catalina.tribes.transport.ReplicationTransmitter.sendMessage(ReplicationTransmitter.java:80)
at
org.apache.catalina.tribes.group.ChannelCoordinator.sendMessage(ChannelCoordinator.java:76)
at
org.apache.catalina.tribes.group.ChannelInterceptorBase.sendMessage(ChannelInterceptorBase.java:75)
at
org.apache.catalina.tribes.group.ChannelInterceptorBase.sendMessage(ChannelInterceptorBase.java:75)
at
org.apache.catalina.tribes.group.interceptors.TcpFailureDetector.sendMessage(TcpFailureDetector.java:88)
at
org.apache.catalina.tribes.group.ChannelInterceptorBase.sendMessage(ChannelInterceptorBase.java:75)
at

[Bug 56828] Cluster setup stopped working after 3 months in production

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56828

KS krishna.saran...@gmail.com changed:

   What|Removed |Added

 CC||krishna.saran...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56829] New: do not override _RUNJAVA and _RUNJDB environment variables if already defined

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56829

Bug ID: 56829
   Summary: do not override _RUNJAVA and _RUNJDB environment
variables if already defined
   Product: Tomcat 6
   Version: 6.0.41
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: neeme.pr...@eesti.ee

Created attachment 31888
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=31888action=edit
patch

I'm integrating LiveRebel (http://liverebel.com) with Tomcat. I need a clean
way how to get Tomcat scripts to start LiveRebel agent instead of Tomcat (the
agent will be responsible for starting Tomcat).

Currently we are patching Tomcat scripts (catalina.sh/bat and
setclasspath.sh/bat); however, that is messy, as every time user updates
Tomcat, those changes get overwritten.

Instead, I would like to change the java executable that Tomcat scripts use
to start Tomcat.

My current solution is to set _RUNJAVA environment variable in
CATALINA_BASE/bin/setenv.sh/bat and then patch
CATALINA_HOME/bin/setclasspath.sh/bat not to override the setting if already
set (see the attached patch).
This solution is also described here:
http://zeroturnaround.com/forums/topic/trouble-setting-up-live-rebel-with-tomcat-on-ubuntu/#post-45253

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53770] tomcat-pool: always log validation query syntax errors

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53770

--- Comment #2 from Christopher Schultz ch...@christopherschultz.net ---
Filip: how about a configuration property (or probably a separate interceptor)
that can be configured with a list of local SQL error codes to treat as certain
types of errors?

This can probably be done with a custom interceptor and probably does not need
to exist in the Tomcat code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54227] maxAge should be checked on borrow

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54227

Filip Hanik fha...@apache.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #2 from Filip Hanik fha...@apache.org ---
current fix does not run initSQL or testOnConnect

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616739 - /tomcat/trunk/webapps/docs/changelog.xml

2014-08-08 Thread remm
Author: remm
Date: Fri Aug  8 13:07:02 2014
New Revision: 1616739

URL: http://svn.apache.org/r1616739
Log:
Checking changes ... Remove the system property for ciphers from the changelog 
as well.

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1616739r1=1616738r2=1616739view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Aug  8 13:07:02 2014
@@ -150,9 +150,8 @@
 the forthcoming mod_jk 1.2.41. (rjung)
   /fix
   fix
-Add new codetomcat.ssl.ciphers/code system property to define
-default ciphers, and add it in codeconf/catalina.properties/code
-defined as codeHIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5/code so
+Use default ciphers defined as
+codeHIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5/code so
 that no weak ciphers are enabled by default. (remm)
   /fix
   fix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616759 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 14:02:40 2014
New Revision: 1616759

URL: http://svn.apache.org/r1616759
Log:
Fix possible NPE highlighted by Eclipse

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java?rev=1616759r1=1616758r2=1616759view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
 Fri Aug  8 14:02:40 2014
@@ -22,11 +22,11 @@ import org.apache.juli.logging.LogFactor
 
 public class ClassLoaderUtil {
 private static final Log log = LogFactory.getLog(ClassLoaderUtil.class);
-
-private static final boolean onlyAttemptFirstLoader = 
-
Boolean.getBoolean(System.getProperty(org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader,
 false)); 
-
-public static Class loadClass(String className, ClassLoader... 
classLoaders) throws ClassNotFoundException {
+
+private static final boolean onlyAttemptFirstLoader =
+
Boolean.getBoolean(System.getProperty(org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader,
 false));
+
+public static Class? loadClass(String className, ClassLoader... 
classLoaders) throws ClassNotFoundException {
 ClassNotFoundException last = null;
 StringBuffer errorMsg = null;
 for (ClassLoader cl : classLoaders) {
@@ -47,7 +47,11 @@ public class ClassLoaderUtil {
 errorMsg.append(;);
 }
 errorMsg.append(ClassLoader:);
-errorMsg.append(cl.toString());
+if (cl == null) {
+errorMsg.append(null);
+} else {
+errorMsg.append(cl.toString());
+}
 }
 if (onlyAttemptFirstLoader) {
 break;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616760 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/ test/java/org/apache/tomcat/jdbc/pool/ test/java/org/apache/tomcat/jdbc/test/

2014-08-08 Thread fhanik
Author: fhanik
Date: Fri Aug  8 14:02:54 2014
New Revision: 1616760

URL: http://svn.apache.org/r1616760
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54227
Proper fix for max age evaluation at time of borrow. It should be done during 
borrow, not during setup. Setup does not perform proper initialization

Rename checkUser, poor name, hard to understand what the return value is

Fix unit test around pool thread renaming

Added:

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/ShouldForceReconnectTest.java
   (with props)
Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1616760r1=1616759r2=1616760view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Fri Aug  8 14:02:54 2014
@@ -279,10 +279,6 @@ public class ConnectionPool {
  * @throws SQLException if an interceptor can't be configured, if the 
proxy can't be instantiated
  */
 protected Connection setupConnection(PooledConnection con) throws 
SQLException {
-//check if it's been sitting in the pool too long
-if (con.isMaxAgeExpired()) {
-con.reconnect();
-}
 //fetch previously cached interceptor proxy - one per connection
 JdbcInterceptor handler = con.getHandler();
 if (handler==null) {
@@ -750,30 +746,20 @@ public class ConnectionPool {
 boolean setToNull = false;
 try {
 con.lock();
-boolean usercheck = con.checkUser(username, password);
-
 if (con.isReleased()) {
 return null;
 }
 
+//evaluate username/password change as well as max age 
functionality
+boolean forceReconnect = con.shouldForceReconnect(username, 
password) || con.isMaxAgeExpired();
+
 if (!con.isDiscarded()  !con.isInitialized()) {
-//attempt to connect
-try {
-con.connect();
-} catch (Exception x) {
-release(con);
-setToNull = true;
-if (x instanceof SQLException) {
-throw (SQLException)x;
-} else {
-SQLException ex  = new SQLException(x.getMessage());
-ex.initCause(x);
-throw ex;
-}
-}
+//here it states that the connection not discarded, but the 
connection is null
+//don't attempt a connect here. It will be done during the 
reconnect.
+forceReconnect = true;
 }
 
-if (usercheck) {
+if (!forceReconnect) {
 if ((!con.isDiscarded())  
con.validate(PooledConnection.VALIDATE_BORROW)) {
 //set the timestamp
 con.setTimestamp(now);

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1616760r1=1616759r2=1616760view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
 Fri Aug  8 14:02:54 2014
@@ -134,8 +134,24 @@ public class PooledConnection {
 return connectionVersion;
 }
 
+/**
+ * @deprecated use {@link #shouldForceReconnect(String, String)}
+ * method kept since it was public, to avoid changing interface. name was 
pooo
+ */
 public boolean checkUser(String username, String password) {
-if (!getPoolProperties().isAlternateUsernameAllowed()) return true;
+return !shouldForceReconnect(username, password);
+}
+/**
+ * Returns true if we must force reconnect based on credentials passed in.
+ * Returns false if {@link PoolConfiguration#isAlternateUsernameAllowed()} 
method returns false.
+ * Returns false if the username/password has not changed since this 
connection was connected
+ * @param username the username you wish to connect 

[Bug 54227] maxAge should be checked on borrow

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54227

Filip Hanik fha...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Filip Hanik fha...@apache.org ---
Fixed in r1616760

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616761 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 14:04:26 2014
New Revision: 1616761

URL: http://svn.apache.org/r1616761
Log:
Fix typo that meant logSlow was not read

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java?rev=1616761r1=1616760r2=1616761view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
 Fri Aug  8 14:04:26 2014
@@ -234,7 +234,7 @@ public class SlowQueryReport extends Abs
 final String logfailed = logFailed;
 InterceptorProperty p1 = properties.get(threshold);
 InterceptorProperty p2 = properties.get(maxqueries);
-InterceptorProperty p3 = properties.get(logSlow);
+InterceptorProperty p3 = properties.get(logslow);
 InterceptorProperty p4 = properties.get(logfailed);
 if (p1!=null) {
 setThreshold(Long.parseLong(p1.getValue()));



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616762 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 14:06:21 2014
New Revision: 1616762

URL: http://svn.apache.org/r1616762
Log:
Add missing deprecation annotation

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1616762r1=1616761r2=1616762view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
 Fri Aug  8 14:06:21 2014
@@ -138,19 +138,21 @@ public class PooledConnection {
  * @deprecated use {@link #shouldForceReconnect(String, String)}
  * method kept since it was public, to avoid changing interface. name was 
pooo
  */
+@Deprecated
 public boolean checkUser(String username, String password) {
 return !shouldForceReconnect(username, password);
 }
+
 /**
  * Returns true if we must force reconnect based on credentials passed in.
  * Returns false if {@link PoolConfiguration#isAlternateUsernameAllowed()} 
method returns false.
  * Returns false if the username/password has not changed since this 
connection was connected
  * @param username the username you wish to connect with, pass in null to 
accept the default username from {@link PoolConfiguration#getUsername()}
- * @param password the password you wish to connect with, pass in null to 
accept the default username from {@link 
org.apache.tomcat.jdbc.pool.PoolConfiguration#getPassword()} 
+ * @param password the password you wish to connect with, pass in null to 
accept the default username from {@link 
org.apache.tomcat.jdbc.pool.PoolConfiguration#getPassword()}
  * @return true is the pool must reconnect
  */
 public boolean shouldForceReconnect(String username, String password) {
-
+
 if (!getPoolProperties().isAlternateUsernameAllowed()) return false;
 
 if (username==null) username = poolProperties.getUsername();
@@ -263,7 +265,7 @@ public class PooledConnection {
 //rely on DriverManager
 log.warn(Not loading a JDBC driver as driverClassName 
property is null.);
 } else {
-driver = (java.sql.Driver) 
+driver = (java.sql.Driver)
 ClassLoaderUtil.loadClass(
 poolProperties.getDriverClassName(),
 PooledConnection.class.getClassLoader(),
@@ -334,9 +336,9 @@ public class PooledConnection {
 }
 
 /**
- * Returns true if the connection has been connected more than 
+ * Returns true if the connection has been connected more than
  * {@link PoolConfiguration#getMaxAge()} milliseconds. false otherwise.
- * @return Returns true if the connection has been connected more than 
+ * @return Returns true if the connection has been connected more than
  * {@link PoolConfiguration#getMaxAge()} milliseconds. false otherwise.
  */
 public boolean isMaxAgeExpired() {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616763 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc: naming/GenericNamingResourcesFactory.java pool/ConnectionPool.java pool/PoolProperties.java pool/interce

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 14:06:31 2014
New Revision: 1616763

URL: http://svn.apache.org/r1616763
Log:
Whitespace police

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java?rev=1616763r1=1616762r2=1616763view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
 Fri Aug  8 14:06:31 2014
@@ -59,7 +59,7 @@ public class GenericNamingResourcesFacto
 EnumerationRefAddr refs = ref.getAll();
 
 String type = ref.getClassName();
-Object o = 
+Object o =
 ClassLoaderUtil.loadClass(
 type,
 GenericNamingResourcesFactory.class.getClassLoader(),

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1616763r1=1616762r2=1616763view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Fri Aug  8 14:06:31 2014
@@ -780,10 +780,10 @@ public class ConnectionPool {
 //the connection shouldn't have to poll again.
 try {
 con.reconnect();
-int validationMode = getPoolProperties().isTestOnConnect() || 
getPoolProperties().getInitSQL()!=null ? 
-PooledConnection.VALIDATE_INIT : 
+int validationMode = getPoolProperties().isTestOnConnect() || 
getPoolProperties().getInitSQL()!=null ?
+PooledConnection.VALIDATE_INIT :
 PooledConnection.VALIDATE_BORROW;
-
+
 if (con.validate(validationMode)) {
 //set the timestamp
 con.setTimestamp(now);

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1616763r1=1616762r2=1616763view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
 Fri Aug  8 14:06:31 2014
@@ -962,7 +962,7 @@ public class PoolProperties implements P
 log.debug(Loading interceptor 
class:+PoolConfiguration.PKG_PREFIX+getClassName());
 }
 clazz = ClassLoaderUtil.loadClass(
-PoolConfiguration.PKG_PREFIX+getClassName(), 
+PoolConfiguration.PKG_PREFIX+getClassName(),
 this.getClass().getClassLoader(),
 Thread.currentThread().getContextClassLoader()
 );
@@ -971,7 +971,7 @@ public class PoolProperties implements P
 log.debug(Loading interceptor class:+getClassName());
 }
 clazz = ClassLoaderUtil.loadClass(
-getClassName(), 
+getClassName(),
 this.getClass().getClassLoader(),
 Thread.currentThread().getContextClassLoader()
 );

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java?rev=1616763r1=1616762r2=1616763view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
 (original)
+++ 

svn commit: r1616764 - in /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc: bugs/ pool/ test/

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 14:10:18 2014
New Revision: 1616764

URL: http://svn.apache.org/r1616764
Log:
Fix Checkstyle  IDE warnings. Mostly import use/order.

Modified:

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54225.java

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54227.java

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54978.java

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/ShouldForceReconnectTest.java

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestJdbcInterceptorConfigParsing.java

tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestValidationQueryTimeout.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54225.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54225.java?rev=1616764r1=1616763r2=1616764view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54225.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54225.java
 Fri Aug  8 14:10:18 2014
@@ -16,29 +16,20 @@
  */
 package org.apache.tomcat.jdbc.bugs;
 
-import java.sql.Connection;
-import java.sql.DriverManager;
 import java.sql.SQLException;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.List;
-import java.util.concurrent.ArrayBlockingQueue;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.atomic.AtomicInteger;
 
-import org.junit.Assert;
+import static org.junit.Assert.assertNull;
+
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 
-import org.apache.tomcat.jdbc.pool.ConnectionPool;
 import org.apache.tomcat.jdbc.pool.DataSource;
-import org.apache.tomcat.jdbc.pool.PoolExhaustedException;
 import org.apache.tomcat.jdbc.pool.PoolProperties;
 import org.apache.tomcat.jdbc.test.DefaultProperties;
 
-import static org.junit.Assert.assertNull;
 
 @RunWith(Parameterized.class)
 public class Bug54225 {
@@ -58,7 +49,7 @@ public class Bug54225 {
 }
 
 @Test
-public void testPool() throws SQLException, InterruptedException {
+public void testPool() throws SQLException {
 PoolProperties poolProperties = new DefaultProperties();
 poolProperties.setMinIdle(0);
 poolProperties.setInitialSize(0);

Modified: 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54227.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54227.java?rev=1616764r1=1616763r2=1616764view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54227.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54227.java
 Fri Aug  8 14:10:18 2014
@@ -16,18 +16,20 @@
  */
 package org.apache.tomcat.jdbc.bugs;
 
-import org.apache.tomcat.jdbc.pool.DataSource;
-import org.apache.tomcat.jdbc.pool.PoolProperties;
-import org.apache.tomcat.jdbc.test.DefaultProperties;
-import org.junit.Test;
-
-import javax.sql.PooledConnection;
 import java.sql.Connection;
 import java.sql.SQLException;
 
+import javax.sql.PooledConnection;
+
 import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertSame;
 
+import org.junit.Test;
+
+import org.apache.tomcat.jdbc.pool.DataSource;
+import org.apache.tomcat.jdbc.pool.PoolProperties;
+import org.apache.tomcat.jdbc.test.DefaultProperties;
+
 public class Bug54227 {
 
 

Modified: 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54978.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54978.java?rev=1616764r1=1616763r2=1616764view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54978.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/Bug54978.java
 Fri Aug  8 14:10:18 2014
@@ -16,19 +16,20 @@
  */
 package org.apache.tomcat.jdbc.bugs;
 
-import org.apache.tomcat.jdbc.pool.DataSource;
-import org.apache.tomcat.jdbc.pool.PoolProperties;
-import org.apache.tomcat.jdbc.test.DefaultProperties;
-import org.junit.Test;
-
 import java.sql.SQLException;
 
 import static org.junit.Assert.fail;
 
+import org.junit.Test;
+
+import org.apache.tomcat.jdbc.pool.DataSource;
+import org.apache.tomcat.jdbc.pool.PoolProperties;
+import org.apache.tomcat.jdbc.test.DefaultProperties;
+
 public class Bug54978 {
 
 @Test
-

svn commit: r1616767 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java

2014-08-08 Thread fhanik
Author: fhanik
Date: Fri Aug  8 14:13:50 2014
New Revision: 1616767

URL: http://svn.apache.org/r1616767
Log:
Amendment to r1616759. Thanks markt

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java?rev=1616767r1=1616766r2=1616767view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
 Fri Aug  8 14:13:50 2014
@@ -47,11 +47,7 @@ public class ClassLoaderUtil {
 errorMsg.append(;);
 }
 errorMsg.append(ClassLoader:);
-if (cl == null) {
-errorMsg.append(null);
-} else {
-errorMsg.append(cl.toString());
-}
+errorMsg.append(cl);
 }
 if (onlyAttemptFirstLoader) {
 break;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53200] Be able to use SlowQueryReport without reporting failed queries

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53200

--- Comment #3 from Filip Hanik fha...@apache.org ---
amended in r1616761

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616776 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 14:25:28 2014
New Revision: 1616776

URL: http://svn.apache.org/r1616776
Log:
Whitespace police

Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1616776r1=1616775r2=1616776view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri Aug  8 14:25:28 2014
@@ -170,16 +170,16 @@
   /attribute
 /attributes
   /subsection
-  
+
   subsection name=System Properties
 pSystem properties are JVM wide, affect all pools created in the JVM/p
 attributes
   attribute 
name=org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader 
required=false
-p(boolean) Controls classloading of dynamic classes, such as 
-   jdbc drivers, interceptors and validators. If set to false, default 
value, 
+p(boolean) Controls classloading of dynamic classes, such as
+   jdbc drivers, interceptors and validators. If set to false, default 
value,
the pool will first attempt to load using the current loader and if 
class loading fails
attempt to load using the thread context loader.
-   Set this value to try, if you wish to remain backwards compatible, 
+   Set this value to try, if you wish to remain backwards compatible,
Apache Tomcat 8.0.8 and earlier, and only attempt the current 
loader.
If not set then the default value is codefalse/code.)
 /p
@@ -609,8 +609,8 @@
 /p
 attributes
   attribute name=trace required=false
-p(boolean as String) Enable tracing of unclosed statements. 
-   When enabled and a connection is closed, and statements are not 
closed, 
+p(boolean as String) Enable tracing of unclosed statements.
+   When enabled and a connection is closed, and statements are not 
closed,
the interceptor will log all stack traces.
The default value is codefalse/code.
 /p



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56831] javax.faces.application.ViewExpiredException thrown for applications which contextRoot contains dash

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56831

Juraj Huska jhu...@redhat.com changed:

   What|Removed |Added

 CC||jhu...@redhat.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56831] New: javax.faces.application.ViewExpiredException thrown for applications which contextRoot contains dash

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56831

Bug ID: 56831
   Summary: javax.faces.application.ViewExpiredException thrown
for applications which contextRoot contains dash
   Product: Tomcat 7
   Version: 7.0.55
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: jhu...@redhat.com

Created attachment 31889
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=31889action=edit
Maven project to reproduce the issue - its simplified RichFaces project to
contain only JSF dependencies

When I deploy a JSF application (Mojarra 2.2.7), which .war name contains dash
(deployed context root contains dash as well),
javax.faces.application.ViewExpiredException is being in the first Ajax request
from such application.

The same application works if its .war does not contain dash (the context root
is without dash).

Another important thing to reproduce this is, that the error is thrown only
when you get to the app via redirect. If the application is loaded directly,
everything works. More info in steps to reproduce.

I have tried different Tomcat versions - 8.x, 7.0.30, etc. - still the same.
I have tried different JSF Mojarra versions, newer or older.

Here are the steps to reproduce:
1. download attached maven project
2. issue mvn clean package from its root directory
3. deploy simple-app.war to Tomcat
4. load localhost:8080 and then Tomcat Gui manager
5. click on the context root to load actual app
6. try to write something into input and see the ViewExpiredException

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56831] javax.faces.application.ViewExpiredException thrown for applications which contextRoot contains dash

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56831

--- Comment #1 from Juraj Huska jhu...@redhat.com ---
FYI original issue report in RichFaces issue management:
https://issues.jboss.org/browse/RF-13731

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1613897 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java

2014-08-08 Thread Filip Hanik
On Mon, Jul 28, 2014 at 1:02 AM, kkoli...@apache.org wrote:

 Author: kkolinko
 Date: Mon Jul 28 07:02:31 2014
 New Revision: 1613897

 URL: http://svn.apache.org/r1613897
 Log:
 Revert generics changes from r1613123
 The code is compiled with Java 7, so why change them?

copy/paste mistake from the tc7.0.x version


 With recommended Eclipse settings those produce compiler warnings.
 (Generic types/Redundant type arguments  warning)

Not using eclipse, and I would recommend that we don't expect our
contributors to be on a certain platform.
If we wish to enforce something, the tools should be provided within the
project itself, not depend on committers' independent platforms.
ie, the CI could complain/fail if we wish to be that strict.

Thanks for the fix.



 Modified:

 tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java

 Modified:
 tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
 URL:
 http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java?rev=1613897r1=1613896r2=1613897view=diff

 ==
 ---
 tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
 (original)
 +++
 tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java
 Mon Jul 28 07:02:31 2014
 @@ -201,13 +201,13 @@ public class FairBlockingQueueE implem
  E item = items.poll();
  if (item==null) {
  //queue is empty, add ourselves as waiters
 -ExchangeCountDownLatchE c = new
 ExchangeCountDownLatchE(1);
 +ExchangeCountDownLatchE c = new
 ExchangeCountDownLatch(1);
  waiters.addLast(c);
  //return a future that will wait for the object
 -result = new ItemFutureE(c);
 +result = new ItemFuture(c);
  } else {
  //return a future with the item
 -result = new ItemFutureE(item);
 +result = new ItemFuture(item);
  }
  } finally {
  lock.unlock();



 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




buildbot failure in ASF Buildbot on tomcat-trunk

2014-08-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/344

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1616739
Blamelist: remm

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56831] javax.faces.application.ViewExpiredException thrown for applications which contextRoot contains dash

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56831

--- Comment #2 from Mark Thomas ma...@apache.org ---
Some explanation of why you think this is a Tomcat bug would be helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616789 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml

2014-08-08 Thread fhanik
Author: fhanik
Date: Fri Aug  8 14:53:06 2014
New Revision: 1616789

URL: http://svn.apache.org/r1616789
Log:
Update changelog with recent fixes

Modified:
tomcat/trunk/modules/jdbc-pool/doc/changelog.xml

Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/changelog.xml?rev=1616789r1=1616788r2=1616789view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/changelog.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Fri Aug  8 14:53:06 2014
@@ -28,6 +28,25 @@
   /properties
 
 body
+
+section name=Tomcat JDBC Connection Pool - Apache Tomcat 8.0.10
+  subsection name=pool
+changelog
+  fixrev1616760/rev bug54227/bug Evaluate max age upon borrow 
(fhanik)/fix
+  fixrev1616644/rev bug56318/bug Ability to trace statement 
creation in StatementFinalizer (fhanik)/fix
+  fixrev1616639/rev bug53088/bug More identifiable thread name 
(fhanik)/fix
+  fixrev1616629/rev bug56789/bug getPool() returns the actual 
pool, always (fhanik)/fix
+  fixrev1616625/rev bug54978/bug Make sure proper connection 
validation always happens, regardless of config (fhanik)/fix
+  fixrev1616602/rev bug54537/bug Performance improvement in 
StatementFinalizer (fhanik)/fix
+  fixrev1616599/rev bug54395/bug Fix JDBC interceptor parsing 
bug (fhanik)/fix
+  fixrev1616595/rev bug54235/bug Disallow nested pools 
exploitating using data source (fhanik)/fix
+  fixrev1616592/rev bug54225/bug Disallow empty init SQL 
(fhanik)/fix
+  fixrev1616584/rev bug53853/bug More flexible classloading 
(fhanik)/fix
+  fixrev1616570/rev bug53200/bug Selective logging for slow 
versus failed queries (fhanik)/fix
+/changelog
+  /subsection
+/section
+
 section name=Tomcat JDBC Connection Pool 1.1.0.0
   subsection name=pool
 changelog



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56825] AuthenticatorBase not looking for Coyote Request certificate

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56825

--- Comment #2 from Mark Thomas ma...@apache.org ---
Generally we apply patches to the latest release and then back-port. Therefore
patches should be against 8.0.x.

The current patch changes import order and white space which a) makes the patch
harder to review and b) those changes would need to be reverted before the
patch was committed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56825] AuthenticatorBase not looking for Coyote Request certificate

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56825

--- Comment #3 from jlmonteiro jlmonte...@tomitribe.com ---
Thanks for reviewing.

I'll checkout the 8.0.x trunk and submit a new patch.
I'll take care as well of the formatting (including imports).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Eclipse JAR dependency

2014-08-08 Thread Mark Thomas
All,

I've been chatting on and off over the last few weeks with some folks at
$work that make extensive use of Tomcat embedded and for whom any issues
with the JAR references in the Maven POM (such as [1]) are a real pain.

The root cause of the issue is that the small (~2MB) Eclipse compiler
(JDT) JAR we use is not officially released to Maven Central by Eclipse.
One or more volunteers upload the JAR and it typically appears 2-4 weeks
after the Eclipse release.

There is a larger JAR (5.3MB) with contains the same functionality that
is officially uploaded by Eclipse. It usually appears in Maven Central
sooner that the smaller JAR.

Having discussed the pros and cons of various options I would like to
propose the following approach to be used when updating our dependency
on JDT.

1. Tomcat releases will always package the 'small' JDT JAR as they do
   today.

2. The POMs that we use when we upload a release to Maven Central will
   always include references to valid JARs that are known to already
   exist in Maven central.

3. We will not normally update Tomcat's dependency on JDT until the
   'small' JAR is available in Maven Central.

4. If we need to update the JDT dependency before the 'small' JAR is
   available in Maven central (e.g. security issue, access new features
   such as Java 9 support for testing etc.) then we will use the
   following fallback options for the POM references:
   - if the 'small' JDT JAR is not available, use the 'large' one
   - if neither the 'small' nor the 'large' JDT JARs are available
 continue to reference the pre-upadte version of the 'small' JDT
 JAR

5. The changelog should make clear which dependencies have been updated
   and which have not.

6. The tomcat-embedded-jasper.pom will continue to reference the
   'small' Eclipse JAR as a non-optional dependency by default.

I'll add this to a wiki page so we can reference it in the
build.properties.default file etc. Obviously this is only a proposal at
this stage. Feedback, questions alternative approaches etc. welcome.

Mark

[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=50604

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2014-08-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/345

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1616776
Blamelist: fhanik,markt

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of Development by markt

2014-08-08 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The Development page has been changed by markt:
https://wiki.apache.org/tomcat/Development?action=diffrev1=5rev2=6

Comment:
Add a link to the to be created JDT page

  
   * '''[[Cookies]]''' - Reviewing Tomcat's cookie support
   * '''[[BuildTcNativeWin]]''' - Building the tc native binaries for Windows
+  * '''[[JDTCoreBatchCompiler]]''' - Managing Tomcat's dependency on the 
Eclipse JDT Core Batch Compiler
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of JDTCoreBatchCompiler by markt

2014-08-08 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The JDTCoreBatchCompiler page has been changed by markt:
https://wiki.apache.org/tomcat/JDTCoreBatchCompiler

Comment:
Add the content for the JDT page

New page:
= Managing Tomcat's Dependency on the Eclipse JDT Core Batch Compiler =

== Background ==

Tomcat depends on JDT to enable it to support the compilation of JSPs while 
running on a JRE. This ensures JSP compilation works out of the box. Tomcat can 
be configured to use javac if running on a JDK but that has proved problematic 
in the past - mainly around ensuring that tools.jar is on the class path.

For folks that use Tomcat with Maven in embedded mode it is important that the 
Maven dependencies are valid and correct. There have been problems in this area 
in the past such as 
[[https://issues.apache.org/bugzilla/show_bug.cgi?id=50604|bug 50604]].

The root cause of the issue is that the small (~2MB) JDT JAR we use is not 
officially released to Maven Central by Eclipse. One or more volunteers upload 
the JAR and it typically appears 2-4 weeks after the Eclipse release.

There is a larger JAR (5.3MB) with contains the same functionality that is 
officially uploaded by Eclipse. It usually appears in Maven Central sooner that 
the smaller JAR.

== Policy ==

 1. Tomcat releases will always package the 'small' JDT JAR as they have done 
for several years.

 1. The POMs used when uploading a release to Maven Central will always include 
references to valid JARs that are known to already exist in Maven central.

 1. The POMs will continue to reference the 'small' Eclipse JAR as a 
non-optional dependency by default.

 1. Tomcat's dependency on JDT will not normally be updated until the 'small' 
JAR is available in Maven Central. At that point all the dependencies (JAR that 
ships with Tomcat, JAR defined as dependency for Jasper JARs, JAR defined as 
dependency for emebedded JARs) will be updated together.

 1. If we need to update the JDT dependency before the 'small' JAR is available 
in Maven central (e.g. security issue, access new features such as Java 9 
support for testing etc.) then we will use the following fallback options for 
the POM references:
  * if the 'small' JDT JAR is not available, use the 'large' one;
  * if neither the 'small' nor the 'large' JDT JARs are available continue to 
reference the pre-update version of the 'small' JDT JAR.

 1. The changelog should make clear which dependencies have been updated and 
which have not.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of JDTCoreBatchCompiler by markt

2014-08-08 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The JDTCoreBatchCompiler page has been changed by markt:
https://wiki.apache.org/tomcat/JDTCoreBatchCompiler?action=diffrev1=1rev2=2

Comment:
Add links to Maven central for the JARs

  
  For folks that use Tomcat with Maven in embedded mode it is important that 
the Maven dependencies are valid and correct. There have been problems in this 
area in the past such as 
[[https://issues.apache.org/bugzilla/show_bug.cgi?id=50604|bug 50604]].
  
- The root cause of the issue is that the small (~2MB) JDT JAR we use is not 
officially released to Maven Central by Eclipse. One or more volunteers upload 
the JAR and it typically appears 2-4 weeks after the Eclipse release.
+ The root cause of the issue is that the 
[[https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.eclipse.jdt.core.compiler%22%20AND%20a%3A%22ecj%22'|small
 (~2MB) JDT JAR]] we use is not officially released to Maven Central by 
Eclipse. One or more volunteers upload the JAR and it typically appears 2-4 
weeks after the Eclipse release.
  
- There is a larger JAR (5.3MB) with contains the same functionality that is 
officially uploaded by Eclipse. It usually appears in Maven Central sooner that 
the smaller JAR.
+ There is a 
[[https://search.maven.org/#search%7cga%7c1%7cg%3A%22org.eclipse.tycho%22%20AND%20a%3A%22org.eclipse.jdt.core%22|larger
 JAR (5.3MB)]] with contains the same functionality that is officially uploaded 
by Eclipse. It usually appears in Maven Central sooner that the smaller JAR.
  
  == Policy ==
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616855 - /tomcat/trunk/res/maven/tomcat-embed-jasper.pom

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 19:23:22 2014
New Revision: 1616855

URL: http://svn.apache.org/r1616855
Log:
After some testing and consideration of options, return to a non-optional 
dependency on the volunteer uploaded ECJ JAR. See 
https://wiki.apache.org/tomcat/JDTCoreBatchCompiler for more info

Modified:
tomcat/trunk/res/maven/tomcat-embed-jasper.pom

Modified: tomcat/trunk/res/maven/tomcat-embed-jasper.pom
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/maven/tomcat-embed-jasper.pom?rev=1616855r1=1616854r2=1616855view=diff
==
--- tomcat/trunk/res/maven/tomcat-embed-jasper.pom (original)
+++ tomcat/trunk/res/maven/tomcat-embed-jasper.pom Fri Aug  8 19:23:22 2014
@@ -43,10 +43,9 @@
   scopecompile/scope
 /dependency
 dependency
-  groupIdorg.eclipse.tycho/groupId
-  artifactIdorg.eclipse.jdt.core/artifactId
-  version3.10.0.v20140604-1726/version
-  optionaltrue/optional
+  groupIdorg.eclipse.jdt.core.compiler/groupId
+  artifactIdecj/artifactId
+  version4.4/version
 /dependency
   /dependencies
 /project



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616856 - /tomcat/trunk/build.properties.default

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 19:23:54 2014
New Revision: 1616856

URL: http://svn.apache.org/r1616856
Log:
Add a reminder

Modified:
tomcat/trunk/build.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1616856r1=1616855r2=1616856view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Fri Aug  8 19:23:54 2014
@@ -135,6 +135,7 @@ wsdl4j-lib.loc=${base-maven.loc}/wsdl4j/
 wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar
 
 # - Eclipse JDT, version 4.4 or later -#
+# See https://wiki.apache.org/tomcat/JDTCoreBatchCompiler before updating
 jdt.version=4.4
 jdt.release=R-4.4-201406061215
 jdt.home=${base.path}/ecj-${jdt.version}



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1616858 - /tomcat/tc7.0.x/trunk/build.properties.default

2014-08-08 Thread markt
Author: markt
Date: Fri Aug  8 19:25:52 2014
New Revision: 1616858

URL: http://svn.apache.org/r1616858
Log:
Add a reminder

Modified:
tomcat/tc7.0.x/trunk/build.properties.default

Modified: tomcat/tc7.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.properties.default?rev=1616858r1=1616857r2=1616858view=diff
==
--- tomcat/tc7.0.x/trunk/build.properties.default (original)
+++ tomcat/tc7.0.x/trunk/build.properties.default Fri Aug  8 19:25:52 2014
@@ -128,6 +128,7 @@ wsdl4j-lib.loc=${base-maven.loc}/wsdl4j/
 wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar
 
 # - Eclipse JDT, version 4.4 or later -#
+# See https://wiki.apache.org/tomcat/JDTCoreBatchCompiler before updating
 jdt.version=4.4
 jdt.release=R-4.4-201406061215
 jdt.home=${base.path}/ecj-${jdt.version}



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 50604] Incorrect dependency in jasper.pom for eclipse ecj

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50604

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Mark Thomas ma...@apache.org ---
After exploring various options the approach to be taken for this JAR going
forward has been documented here:
https://wiki.apache.org/tomcat/JDTCoreBatchCompiler

Note that this is a wiki and the details of the policy may evolve over time.
However, one part won't change and that is:
quote
The POMs used when uploading a release to Maven Central will always include
references to valid JARs that are known to already exist in Maven central.
/quote

There may be consequences as a result of this but the policy aims to minimize
them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56828] Cluster setup stopped working after 3 months in production

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56828

--- Comment #1 from Mark Thomas ma...@apache.org ---
What Java version (exactly please) was this running on?

Exactly (as precisely as possible - ideally to the second) how long was this
cluster up before it failed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2014-08-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/346

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1616789
Blamelist: fhanik

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-08-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/205

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1616858
Blamelist: markt

BUILD FAILED: failed compile

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56828] Cluster setup stopped working after 3 months in production

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56828

--- Comment #2 from Filip Hanik fha...@apache.org ---
faulty member is tcp://10.160.40.12:
is this member not responding to anything?

now there are ways around this, such as configuring replication to be async.
What happens then is that healthy nodes will keep responding to HTTP requests
instead of waiting for faulty nodes. But it will mask faulty nodes.

Your scenario here, could be that 10.160.40.12: is experiencing another
problem, such as an out of memory error or other serious problem. check for
other log errors and the health of the instance itself.

async message delivery is 

channelSendOptions=8 (fire and forget)
channelSendOptions=10 (wait for an ack or resend)

see http://tomcat.apache.org/tomcat-7.0-doc/config/cluster.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53770] tomcat-pool: always log validation query syntax errors

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53770

--- Comment #3 from Filip Hanik fha...@apache.org ---
(In reply to Christopher Schultz from comment #2)
 Filip: how about a configuration property 

that can work, but you see, you can already configure a custom validator to
handle validation. So there are means for those that have a dire need for it.

(or probably a separate
 interceptor) that can be configured with a list of local SQL error codes to
 treat as certain types of errors?
 This can probably be done with a custom interceptor and probably does not
 need to exist in the Tomcat code.

interceptors are not involved in the validation process. a custom validator is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56318] Oracle DB cursors are leaking when using org.apache.tomcat.jdbc.pool.DataSourceFactory

2014-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56318

--- Comment #19 from Filip Hanik fha...@apache.org ---
(In reply to Michael Osipov from comment #18)
 The revision links to Apache Directory

r1616644

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-08-08 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 11 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 25 mins 14 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140809-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140809.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140809-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true 
-Dexecute.test.nio=false -Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dexecute.test.nio2=t
 rue 
-Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar
 
-Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140809.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu