[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 23 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140826.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/comm ons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20140826.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20140826.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20140826.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-19.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar setproxy: downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 5.8-SNAPSHOT on 2919 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/webapps/docs/changelog.xml:51: Line matches the illegal pattern '\s+$'. BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:542: Got 1 errors and 0 warnings. Total time: 23 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 20140826060029, vmgump.apache.org:vmgump:20140826060029 Gump E-mail Identifier (unique within run) #1. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Early Access build for JDK 8u40 build 02 is available on java.net
Hi Mladen/Mark, Early Access build for JDK 8u40 build 02 http://jdk8.java.net/download.html is available on java.net. Summary of changes in JDK 8u40 build 02 are listed here. http://www.java.net/download/jdk8u40/changes/jdk8u40-b02.html Early Access Build Test Results http://www.java.net/download/openjdk/testresults/8/testresults.html . Rgds,Rory -- Rgds,Rory O'Donnell Quality Engineering Manager Oracle EMEA , Dublin, Ireland
svn commit: r1620531 - /tomcat/jk/trunk/native/common/jk_ajp_common.c
Author: rjung
Date: Tue Aug 26 08:37:45 2014
New Revision: 1620531
URL: http://svn.apache.org/r1620531
Log:
Log message consistency.
Modified:
tomcat/jk/trunk/native/common/jk_ajp_common.c
Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_ajp_common.c?rev=1620531r1=1620530r2=1620531view=diff
==
--- tomcat/jk/trunk/native/common/jk_ajp_common.c (original)
+++ tomcat/jk/trunk/native/common/jk_ajp_common.c Tue Aug 26 08:37:45 2014
@@ -2677,8 +2677,8 @@ static int JK_METHOD ajp_service(jk_endp
msg = because of an unknown reason;
rc = JK_FATAL_ERROR;
jk_log(l, JK_LOG_ERROR,
- (%s) unexpected condition err=%d recoverable=%d,
- aw-name, err, op-recoverable);
+ (%s) unexpected condition err=%d (%srecoverable),
+ aw-name, err, op-recoverable ? : un);
}
if (!op-recoverable log_error == JK_TRUE) {
jk_log(l, JK_LOG_ERROR,
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620532 - /tomcat/trunk/webapps/docs/changelog.xml
Author: rjung Date: Tue Aug 26 08:42:52 2014 New Revision: 1620532 URL: http://svn.apache.org/r1620532 Log: Remove trailing space. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1620532r1=1620531r2=1620532view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Aug 26 08:42:52 2014 @@ -48,7 +48,7 @@ subsection name=Catalina changelog add -Make the session id generator extensible by adding a +Make the session id generator extensible by adding a codeSessionIdGenerator/code interface, an abstract base class and a standard implementation. (rjung) /add - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
Sorry, fixed by r1620532 (trailing space introduced by me in changelog). Am 26.08.2014 um 07:53 schrieb Bill Barker: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 23 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140826.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/! target/c omm ons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20140826.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20140826.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20140826.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-19.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.8-SNAPSHOT.jar setproxy: downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 5.8-SNAPSHOT on 2919 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/webapps/docs/changelog.xml:51: Line matches the illegal pattern '\s+$'. BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:542: Got 1 errors and 0 warnings. Total time: 23 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 20140826060029, vmgump.apache.org:vmgump:20140826060029 Gump E-mail Identifier (unique within run) #1. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Early Access build for JDK 9 b27 is available on java.net
On 25/08/2014 12:48, Balchandra Vaidya wrote: Hi Mark, If the enhancement proposal is to java.util.zip APIs, we suggest you to send your proposal to core-libs-...@openjdk.java.net mailto:core-libs-...@openjdk.java.net mailing list to get started. Thanks. Done. Mark Regards, Balchandra On 08/22/14 04:54 PM, Mark Thomas wrote: On 22/08/2014 09:55, Rory O'Donnell Oracle, Dublin Ireland wrote: Hi Mladen/Mark, Early Access build for JDK 9 b27 https://jdk9.java.net/download/ is available on java.net, summary of changes here http://www.java.net/download/jdk9/changes/jdk9-b27.html Rory, I've been working on WebSocket permessage-deflate recently and I'm using java.util.zip.[Inflator|Defaltor] Currently, those classes do not expose an API to enable the user to choose a window size (it defaults to the maximum). How do I go about making an enhancement request to get such an API added so that we can fully implement WebSocket permessage-deflate and provide full control over the window size without having to find an alternative DEFLATE implementation? Cheers, Mark I'd also like to use this opportunity to point you to ongoing work in OpenJDK on Project Jigsaw. - JDK 9's source code is now modular: http://mail.openjdk.java.net/pipermail/jdk9-dev/2014-August/001220.html - Mark Reinhold's post providing some context is available on his blog: http://mreinhold.org/blog/jigsaw-phase-two - The first two Project Jigsaw JEPs have been posted at http://openjdk.java.net/jeps/200 http://openjdk.java.net/jeps/201 . You can also track the progress on the JEPs in the JDK Bug System now - the corresponding JBS issue for JEP 201 is https://bugs.openjdk.java.net/browse/JDK-8051619 , for example. Comments, questions, and suggestions are welcome on the jigsaw-dev mailing list. (If you haven’t already subscribed to that list then please do so first, otherwise your message will be discarded as spam.) Rgds,Rory - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT] Release Apache Tomcat 8.0.11
On 23/08/2014 15:48, Konstantin Kolinko wrote: 2014-08-22 13:10 GMT+04:00 Mark Thomas ma...@apache.org: Binding +1: markt, fhanik, olamy, remm, kkolinko Non-binding +1: Ognjen Blagojevic The vote therefore passes. I'll move the bits around and announce once the mirrors catch up. Beware that a regression has been reported: https://issues.apache.org/bugzilla/show_bug.cgi?id=56882 It is reproducible with the examples webapp. There are two questions thus far in BZ 56882: 1) Reloading a context breaks RequestDispatcher.include() and RequestDispatcher.forward(). 2) I wonder why RequestDispatcher.include() fails silently (the include.jsp test in examples webapp). We have released it now so I'll announce it but note the regression. I'll aim to tag a new 8.0.x release towards the end of this week. I'll note that in the release announcement too. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Coverity static analysis scanning
All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
Hi Mark, On Tue, Aug 26, 2014 at 12:20 PM, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I'm interested. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620546 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java
Author: markt
Date: Tue Aug 26 09:52:11 2014
New Revision: 1620546
URL: http://svn.apache.org/r1620546
Log:
Ensure info is only calculated once
Modified:
tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java?rev=1620546r1=1620545r2=1620546view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java Tue Aug
26 09:52:11 2014
@@ -60,7 +60,7 @@ public class ManagedBean implements java
* The codeModelMBeanInfo/code object that corresponds
* to this codeManagedBean/code instance.
*/
-private transient MBeanInfo info = null;
+private transient volatile MBeanInfo info = null;
private MapString,AttributeInfo attributes = new HashMap();
@@ -357,8 +357,9 @@ public class ManagedBean implements java
Lock l = mBeanInfoLock.readLock();
l.lock();
try {
-if (info != null)
+if (info != null) {
return info;
+}
} finally {
l.unlock();
}
@@ -366,34 +367,36 @@ public class ManagedBean implements java
l = mBeanInfoLock.writeLock();
l.lock();
try {
-// Create subordinate information descriptors as required
-AttributeInfo attrs[] = getAttributes();
-MBeanAttributeInfo attributes[] =
-new MBeanAttributeInfo[attrs.length];
-for (int i = 0; i attrs.length; i++)
-attributes[i] = attrs[i].createAttributeInfo();
-
-OperationInfo opers[] = getOperations();
-MBeanOperationInfo operations[] =
-new MBeanOperationInfo[opers.length];
-for (int i = 0; i opers.length; i++)
-operations[i] = opers[i].createOperationInfo();
-
-
-NotificationInfo notifs[] = getNotifications();
-MBeanNotificationInfo notifications[] =
-new MBeanNotificationInfo[notifs.length];
-for (int i = 0; i notifs.length; i++)
-notifications[i] = notifs[i].createNotificationInfo();
-
-
-// Construct and return a new ModelMBeanInfo object
-info = new MBeanInfo(getClassName(),
- getDescription(),
- attributes,
- new MBeanConstructorInfo[] {},
- operations,
- notifications);
+if (info == null) {
+// Create subordinate information descriptors as required
+AttributeInfo attrs[] = getAttributes();
+MBeanAttributeInfo attributes[] =
+new MBeanAttributeInfo[attrs.length];
+for (int i = 0; i attrs.length; i++)
+attributes[i] = attrs[i].createAttributeInfo();
+
+OperationInfo opers[] = getOperations();
+MBeanOperationInfo operations[] =
+new MBeanOperationInfo[opers.length];
+for (int i = 0; i opers.length; i++)
+operations[i] = opers[i].createOperationInfo();
+
+
+NotificationInfo notifs[] = getNotifications();
+MBeanNotificationInfo notifications[] =
+new MBeanNotificationInfo[notifs.length];
+for (int i = 0; i notifs.length; i++)
+notifications[i] = notifs[i].createNotificationInfo();
+
+
+// Construct and return a new ModelMBeanInfo object
+info = new MBeanInfo(getClassName(),
+ getDescription(),
+ attributes,
+ new MBeanConstructorInfo[] {},
+ operations,
+ notifications);
+}
return info;
} finally {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620551 - /tomcat/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Tue Aug 26 10:17:45 2014 New Revision: 1620551 URL: http://svn.apache.org/r1620551 Log: Formally Mapper belongs to Catalina in Tomcat 7. Move changelog for r1620326 to Catalina section. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1620551r1=1620550r2=1620551view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Aug 26 10:17:45 2014 @@ -52,6 +52,11 @@ codeSessionIdGenerator/code interface, an abstract base class and a standard implementation. (rjung) /add + fix +bug56882/bug: Fix regression in processing of includes and forwards +when Context have been reloaded. Tomcat was responding with HTTP Status +503 (Servlet xxx is currently unavailable). (kkolinko) + /fix /changelog /subsection subsection name=Coyote @@ -65,11 +70,6 @@ Add support for the EECDH alias when using the OpenSSL cipher syntax to define JSSE ciphers. (markt) /add - fix -bug56882/bug: Fix regression in processing of includes and forwards -when Context have been reloaded. Tomcat was responding with HTTP Status -503 (Servlet xxx is currently unavailable). (kkolinko) - /fix /changelog /subsection subsection name=Jasper - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
On 26/08/2014 10:44, Niki Dokovski wrote: Hi Mark, On Tue, Aug 26, 2014 at 12:20 PM, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I'm interested. Done. It looks like Coverity will need to approve that invite. Don't know what they will do for a non-ASF e-mail address. Mar I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[ANN] Apache Tomcat 8.0.11 (stable) available
The Apache Tomcat team announces the immediate availability of Apache Tomcat 8.0.11. Apache Tomcat 8 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language and Java WebSocket technologies. Apache Tomcat 8.0.11 includes numerous fixes for issues identified in 8.0.9 as well as a number of other enhancements and changes. The notable changes since 8.0.9 include: - Update to Tomcat Native Library version 1.1.31 to pick up the Windows binaries that are based on OpenSSL 1.0.1h - Add support for OpenSSL syntax for ciphers when using JSSE SSL connectors - Add support for the WebSocket permessage-deflate extension. This is currently limited to decompressing incoming messages on the server side. Please refer to the change log for the complete list of changes: http://tomcat.apache.org/tomcat-8.0-doc/changelog.html NOTE: A regression has been reported in 8.0.11 https://issues.apache.org/bugzilla/show_bug.cgi?id=56882 A new 8.0.12 release is expected in the next week or so to address this. Downloads: http://tomcat.apache.org/download-80.cgi Migration guides from Apache Tomcat 5.5.x, 6.0.x and 7.0.x: http://tomcat.apache.org/migration.html Enjoy! - The Apache Tomcat team [1] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
Hi Mark, 2014-08-26 12:20 GMT+03:00 Mark Thomas ma...@apache.org: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I'm interested also. Can you tell me whether it is about https://scan.coverity.com ? If so I think I can add the project to my dashboard by myself. Thanks Violeta I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
On 26/08/2014 11:38, Violeta Georgieva wrote: Hi Mark, 2014-08-26 12:20 GMT+03:00 Mark Thomas ma...@apache.org: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I'm interested also. Can you tell me whether it is about https://scan.coverity.com ? If so I think I can add the project to my dashboard by myself. It is. Let me know if you need an invite. Mark Thanks Violeta I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620558 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java
Author: markt
Date: Tue Aug 26 10:54:32 2014
New Revision: 1620558
URL: http://svn.apache.org/r1620558
Log:
Clean-up to improve readability. No functional change.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java?rev=1620558r1=1620557r2=1620558view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java Tue Aug
26 10:54:32 2014
@@ -22,7 +22,6 @@ package org.apache.tomcat.util.modeler;
import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.Map;
-import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
@@ -55,7 +54,7 @@ public class ManagedBean implements java
static final Class?[] NO_ARGS_PARAM_SIG = new Class[0];
-private ReadWriteLock mBeanInfoLock = new ReentrantReadWriteLock();
+private final ReadWriteLock mBeanInfoLock = new ReentrantReadWriteLock();
/**
* The codeModelMBeanInfo/code object that corresponds
* to this codeManagedBean/code instance.
@@ -107,17 +106,16 @@ public class ManagedBean implements java
* will be utilized.
*/
public String getClassName() {
-return (this.className);
+return this.className;
}
public void setClassName(String className) {
-Lock l = mBeanInfoLock.writeLock();
-l.lock();
+mBeanInfoLock.writeLock().lock();
try {
this.className = className;
this.info = null;
} finally {
-l.unlock();
+mBeanInfoLock.writeLock().unlock();
}
}
@@ -126,17 +124,16 @@ public class ManagedBean implements java
* The human-readable description of this MBean.
*/
public String getDescription() {
-return (this.description);
+return this.description;
}
public void setDescription(String description) {
-Lock l = mBeanInfoLock.writeLock();
-l.lock();
+mBeanInfoLock.writeLock().lock();
try {
this.description = description;
this.info = null;
} finally {
-l.unlock();
+mBeanInfoLock.writeLock().unlock();
}
}
@@ -146,7 +143,7 @@ public class ManagedBean implements java
* should be registered in the MBeanServer.
*/
public String getDomain() {
-return (this.domain);
+return this.domain;
}
public void setDomain(String domain) {
@@ -158,7 +155,7 @@ public class ManagedBean implements java
* The (optional) group to which this MBean belongs.
*/
public String getGroup() {
-return (this.group);
+return this.group;
}
public void setGroup(String group) {
@@ -171,17 +168,16 @@ public class ManagedBean implements java
* MBeans managed by a particular MBeans server.
*/
public String getName() {
-return (this.name);
+return this.name;
}
public void setName(String name) {
-Lock l = mBeanInfoLock.writeLock();
-l.lock();
+mBeanInfoLock.writeLock().lock();
try {
this.name = name;
this.info = null;
} finally {
-l.unlock();
+mBeanInfoLock.writeLock().unlock();
}
}
@@ -190,7 +186,7 @@ public class ManagedBean implements java
* The collection of notifications for this MBean.
*/
public NotificationInfo[] getNotifications() {
-return (this.notifications);
+return this.notifications;
}
@@ -214,13 +210,12 @@ public class ManagedBean implements java
}
public void setType(String type) {
-Lock l = mBeanInfoLock.writeLock();
-l.lock();
+mBeanInfoLock.writeLock().lock();
try {
this.type = type;
this.info = null;
} finally {
-l.unlock();
+mBeanInfoLock.writeLock().unlock();
}
}
@@ -244,10 +239,7 @@ public class ManagedBean implements java
* @param notification The new notification descriptor
*/
public void addNotification(NotificationInfo notification) {
-
-Lock l = mBeanInfoLock.writeLock();
-
-l.lock();
+mBeanInfoLock.writeLock().lock();
try {
NotificationInfo results[] =
new NotificationInfo[notifications.length + 1];
@@ -257,7 +249,7 @@ public class ManagedBean implements java
notifications = results;
this.info = null;
} finally {
-l.unlock();
+
svn commit: r1620559 - /tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
Author: markt
Date: Tue Aug 26 10:54:46 2014
New Revision: 1620559
URL: http://svn.apache.org/r1620559
Log:
Fix indent
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java?rev=1620559r1=1620558r2=1620559view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java Tue
Aug 26 10:54:46 2014
@@ -609,69 +609,68 @@ public class AprSocketContext {
if (sslCtx == 0) {
synchronized (AprSocketContext.class) {
-boolean serverMode = acceptor != null;
-sslCtx = SSLContext.make(getRootPool(),
-sslProtocol,
-serverMode ? SSL.SSL_MODE_SERVER : SSL.SSL_MODE_CLIENT);
+boolean serverMode = acceptor != null;
+sslCtx = SSLContext.make(getRootPool(),
+sslProtocol,
+serverMode ? SSL.SSL_MODE_SERVER :
SSL.SSL_MODE_CLIENT);
-// SSL.SSL_OP_NO_SSLv3
-int opts = SSL.SSL_OP_NO_SSLv2 |
-SSL.SSL_OP_SINGLE_DH_USE;
+// SSL.SSL_OP_NO_SSLv3
+int opts = SSL.SSL_OP_NO_SSLv2 |
+SSL.SSL_OP_SINGLE_DH_USE;
-if (!USE_TICKETS || serverMode ticketKey == null) {
-opts |= SSL.SSL_OP_NO_TICKET;
-}
+if (!USE_TICKETS || serverMode ticketKey == null) {
+opts |= SSL.SSL_OP_NO_TICKET;
+}
-SSLContext.setOptions(sslCtx, opts);
-// Set revocation
-//SSLContext.setCARevocation(sslContext,
SSLCARevocationFile, SSLCARevocationPath);
+SSLContext.setOptions(sslCtx, opts);
+// Set revocation
+//SSLContext.setCARevocation(sslContext,
SSLCARevocationFile, SSLCARevocationPath);
-// Client certificate verification - maybe make it option
-try {
-SSLContext.setCipherSuite(sslCtx, SSLCipherSuite);
+// Client certificate verification - maybe make it option
+try {
+SSLContext.setCipherSuite(sslCtx, SSLCipherSuite);
-if (serverMode) {
-if (ticketKey != null) {
-//SSLExt.setTicketKeys(sslCtx, ticketKey,
ticketKey.length);
-}
-if (certFile != null) {
-boolean rc = SSLContext.setCertificate(sslCtx,
-certFile,
-keyFile, null, SSL.SSL_AIDX_DSA);
-if (!rc) {
-throw new IOException(Can't set keys);
+if (serverMode) {
+if (ticketKey != null) {
+//SSLExt.setTicketKeys(sslCtx, ticketKey,
ticketKey.length);
}
-}
-SSLContext.setVerify(sslCtx, SSL.SSL_CVERIFY_NONE, 10);
+if (certFile != null) {
+boolean rc = SSLContext.setCertificate(sslCtx,
+certFile,
+keyFile, null, SSL.SSL_AIDX_DSA);
+if (!rc) {
+throw new IOException(Can't set keys);
+}
+}
+SSLContext.setVerify(sslCtx, SSL.SSL_CVERIFY_NONE, 10);
-if (spdyNPN != null) {
-SSLExt.setNPN(sslCtx, spdyNPN, spdyNPN.length);
-}
-} else {
-if (tlsCertVerifier != null) {
-// NONE ?
-SSLContext.setVerify(sslCtx,
-SSL.SSL_CVERIFY_NONE, 10);
+if (spdyNPN != null) {
+SSLExt.setNPN(sslCtx, spdyNPN, spdyNPN.length);
+}
} else {
-SSLContext.setCACertificate(sslCtx,
-/etc/ssl/certs/ca-certificates.crt,
-/etc/ssl/certs);
-SSLContext.setVerify(sslCtx,
-SSL.SSL_CVERIFY_REQUIRE, 10);
-}
+if (tlsCertVerifier != null) {
+// NONE ?
+SSLContext.setVerify(sslCtx,
+SSL.SSL_CVERIFY_NONE, 10);
+} else {
+
svn commit: r1620560 - /tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
Author: markt
Date: Tue Aug 26 10:55:26 2014
New Revision: 1620560
URL: http://svn.apache.org/r1620560
Log:
Fix threading issue. Multiple threads could, sequentially, create a new
sslContext when there should only be one. Identified by Coverity scan.
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java?rev=1620560r1=1620559r2=1620560view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.java Tue
Aug 26 10:55:26 2014
@@ -133,7 +133,7 @@ public class AprSocketContext {
/**
* SSL context.
*/
-private long sslCtx = 0;
+private volatile long sslCtx = 0;
TlsCertVerifier tlsCertVerifier;
@@ -608,68 +608,69 @@ public class AprSocketContext {
long getSslCtx() throws Exception {
if (sslCtx == 0) {
synchronized (AprSocketContext.class) {
+if (sslCtx == 0) {
+boolean serverMode = acceptor != null;
+sslCtx = SSLContext.make(getRootPool(),
+sslProtocol,
+serverMode ? SSL.SSL_MODE_SERVER :
SSL.SSL_MODE_CLIENT);
-boolean serverMode = acceptor != null;
-sslCtx = SSLContext.make(getRootPool(),
-sslProtocol,
-serverMode ? SSL.SSL_MODE_SERVER :
SSL.SSL_MODE_CLIENT);
+// SSL.SSL_OP_NO_SSLv3
+int opts = SSL.SSL_OP_NO_SSLv2 |
+SSL.SSL_OP_SINGLE_DH_USE;
-// SSL.SSL_OP_NO_SSLv3
-int opts = SSL.SSL_OP_NO_SSLv2 |
-SSL.SSL_OP_SINGLE_DH_USE;
-
-if (!USE_TICKETS || serverMode ticketKey == null) {
-opts |= SSL.SSL_OP_NO_TICKET;
-}
-
-SSLContext.setOptions(sslCtx, opts);
-// Set revocation
-//SSLContext.setCARevocation(sslContext,
SSLCARevocationFile, SSLCARevocationPath);
+if (!USE_TICKETS || serverMode ticketKey == null) {
+opts |= SSL.SSL_OP_NO_TICKET;
+}
-// Client certificate verification - maybe make it option
-try {
-SSLContext.setCipherSuite(sslCtx, SSLCipherSuite);
+SSLContext.setOptions(sslCtx, opts);
+// Set revocation
+//SSLContext.setCARevocation(sslContext,
SSLCARevocationFile, SSLCARevocationPath);
+
+// Client certificate verification - maybe make it option
+try {
+SSLContext.setCipherSuite(sslCtx, SSLCipherSuite);
-if (serverMode) {
-if (ticketKey != null) {
-//SSLExt.setTicketKeys(sslCtx, ticketKey,
ticketKey.length);
-}
-if (certFile != null) {
-boolean rc = SSLContext.setCertificate(sslCtx,
-certFile,
-keyFile, null, SSL.SSL_AIDX_DSA);
-if (!rc) {
-throw new IOException(Can't set keys);
+if (serverMode) {
+if (ticketKey != null) {
+//SSLExt.setTicketKeys(sslCtx, ticketKey,
ticketKey.length);
}
-}
-SSLContext.setVerify(sslCtx, SSL.SSL_CVERIFY_NONE, 10);
+if (certFile != null) {
+boolean rc = SSLContext.setCertificate(sslCtx,
+certFile,
+keyFile, null, SSL.SSL_AIDX_DSA);
+if (!rc) {
+throw new IOException(Can't set keys);
+}
+}
+SSLContext.setVerify(sslCtx, SSL.SSL_CVERIFY_NONE,
10);
-if (spdyNPN != null) {
-SSLExt.setNPN(sslCtx, spdyNPN, spdyNPN.length);
-}
-} else {
-if (tlsCertVerifier != null) {
-// NONE ?
-SSLContext.setVerify(sslCtx,
-SSL.SSL_CVERIFY_NONE, 10);
+if (spdyNPN != null) {
+
svn commit: r1620562 - /tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java
Author: markt Date: Tue Aug 26 10:57:46 2014 New Revision: 1620562 URL: http://svn.apache.org/r1620562 Log: Remove incorrect comment Modified: tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java Modified: tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java?rev=1620562r1=1620561r2=1620562view=diff == --- tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java (original) +++ tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java Tue Aug 26 10:57:46 2014 @@ -53,7 +53,6 @@ public class TestJspServlet extends Tom // PUT requests are normally blocked for JSPs ErrorPage ep = new ErrorPage(); ep.setErrorCode(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); -// Note this location doesn't actually exist ep.setLocation(/WEB-INF/jsp/error.jsp); context.addErrorPage(ep); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-apr : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-APR -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build) Work ended in a state of : Failed Elapsed: 26 mins 8 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140826-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20140826/lib -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140826.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140826-native-src.tar.gz -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140826/bin/openssl -Dexecute.test.apr=true -Dexecute.test.bio=false -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140826.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace
svn commit: r1620577 - in /tomcat/tc7.0.x/trunk: test/org/apache/tomcat/util/http/mapper/ webapps/docs/ webapps/examples/jsp/forward/ webapps/examples/jsp/include/
Author: kkolinko
Date: Tue Aug 26 11:50:42 2014
New Revision: 1620577
URL: http://svn.apache.org/r1620577
Log:
For https://issues.apache.org/bugzilla/show_bug.cgi?id=56882
Add testcase for processing of forwards and includes when Context have been
reloaded. The bug is absent in Tomcat 7.
This is a backport of r1620326.
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapper.java
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapperWebapps.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc7.0.x/trunk/webapps/examples/jsp/forward/one.jsp
tomcat/tc7.0.x/trunk/webapps/examples/jsp/forward/two.html
tomcat/tc7.0.x/trunk/webapps/examples/jsp/include/foo.jsp
tomcat/tc7.0.x/trunk/webapps/examples/jsp/include/include.jsp
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapper.java?rev=1620577r1=1620576r2=1620577view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapper.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapper.java
Tue Aug 26 11:50:42 2014
@@ -17,11 +17,13 @@
package org.apache.tomcat.util.http.mapper;
import java.util.Arrays;
+import java.util.Collection;
import java.util.concurrent.atomic.AtomicBoolean;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
@@ -34,6 +36,8 @@ import org.apache.tomcat.util.buf.Messag
public class TestMapper extends LoggingBaseTest {
private Mapper mapper;
+private Mapper mapperForContext1;
+private Mapper mapperForContext2;
@Before
@Override
@@ -71,11 +75,11 @@ public class TestMapper extends LoggingB
mapper.addContextVersion(iowejoiejfoiew, blah7, /foo/bar,
0, context2, welcomes, null, null);
-mapper.addWrappers(
-iowejoiejfoiew,
-/foo/bar,
-0,
-Arrays.asList(new WrapperMappingInfo[] {
+CollectionWrapperMappingInfo wrappersForContext1 = Arrays
+.asList(new WrapperMappingInfo[] { new WrapperMappingInfo(/,
+context1-defaultWrapper, false, false) });
+CollectionWrapperMappingInfo wrappersForContext2 = Arrays
+.asList(new WrapperMappingInfo[] {
new WrapperMappingInfo(/fo/*, wrapper0, false,
false),
new WrapperMappingInfo(/, wrapper1, false, false),
@@ -87,7 +91,26 @@ public class TestMapper extends LoggingB
new WrapperMappingInfo(/blah/bobou/*, wrapper5,
false, false),
new WrapperMappingInfo(*.htm, wrapper6, false,
-false) }));
+false) });
+
+mapper.addWrappers(iowejoiejfoiew, /foo, 0, wrappersForContext1);
+mapperForContext1 = new Mapper();
+mapperForContext1.setContext(/foo, new String[0], null);
+for (WrapperMappingInfo wrapper : wrappersForContext1) {
+mapperForContext1.addWrapper(wrapper.getMapping(),
+wrapper.getWrapper(), wrapper.isJspWildCard(),
+wrapper.isResourceOnly());
+}
+
+mapper.addWrappers(iowejoiejfoiew, /foo/bar, 0,
+wrappersForContext2);
+mapperForContext2 = new Mapper();
+mapperForContext2.setContext(/foo/bar, new String[0], null);
+for (WrapperMappingInfo wrapper : wrappersForContext2) {
+mapperForContext2.addWrapper(wrapper.getMapping(),
+wrapper.getWrapper(), wrapper.isJspWildCard(),
+wrapper.isResourceOnly());
+}
mapper.addContextVersion(
iowejoiejfoiew,
@@ -269,11 +292,20 @@ public class TestMapper extends LoggingB
assertEquals(1, mappedContext.versions.length);
assertEquals(0, mappedContext.versions[0].name);
Object oldHost = mappedHost.object;
+Object oldContext = mappedContext.versions[0].object;
+assertEquals(context2, oldContext.toString());
+
+Object oldContext1 = mappedHost.contextList.contexts[contextPos -
1].versions[0].object;
+assertEquals(context1, oldContext1.toString());
mappingData.recycle();
mapper.map(hostMB, uriMB, null, mappingData);
assertEquals(blah7, mappingData.host.toString());
assertEquals(context2, mappingData.context.toString());
+assertEquals(wrapper5,
[Bug 56882] HTTP Status 503 - Servlet jsp is currently unavailable after Context reload
https://issues.apache.org/bugzilla/show_bug.cgi?id=56882 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com --- The test was backported to Tomcat 7 in r1620577 (to be in 7.0.56). It passes successfully. There is no such bug in Tomcat 7. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56869] Add code to collect the maximum number of backend connections
https://issues.apache.org/bugzilla/show_bug.cgi?id=56869 --- Comment #1 from Martin Knoblauch kn...@knobisoft.de --- One thought: if this metric is deemed useful, the question is whether it should be reset to zero whenever the worker is reset via the gui. The current patch does not do it. Personally I have no real preference. both ways seem to make sense. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620596 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ test/org/apache/jasper/servlet/ test/webapp/jsp/ webapps/docs/
Author: markt
Date: Tue Aug 26 13:32:45 2014
New Revision: 1620596
URL: http://svn.apache.org/r1620596
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56568
Enable any HTTP method to be used to request a JSP page that has the
isErrorPage page directive set to true.
Added:
tomcat/trunk/test/webapp/jsp/error.jsp (with props)
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java
tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java
tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java?rev=1620596r1=1620595r2=1620596view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java Tue Aug 26
13:32:45 2014
@@ -255,6 +255,11 @@ public abstract class Compiler {
// to be GC'd and save memory.
ctxt.setWriter(null);
+// Need to know if the JSP is an error page at runtime to determine
+// which HTTP methods are permitted. Error pages permit any. Normal
+// pages only permit GET, POST or HEAD.
+jsw.setErrorPage(pageInfo.isErrorPage());
+
if (log.isDebugEnabled()) {
t4 = System.currentTimeMillis();
log.debug(Generated + javaFileName + total= + (t4 - t1)
Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java?rev=1620596r1=1620595r2=1620596view=diff
==
--- tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java (original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java Tue Aug 26
13:32:45 2014
@@ -25,7 +25,6 @@ import java.security.AccessController;
import java.security.PrivilegedActionException;
import java.security.PrivilegedExceptionAction;
-import javax.servlet.DispatcherType;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletConfig;
import javax.servlet.ServletContext;
@@ -282,19 +281,6 @@ public class JspServlet extends HttpServ
HttpServletResponse response)
throws ServletException, IOException {
-String method = request.getMethod();
-
-if (!GET.equals(method) !POST.equals(method)
!HEAD.equals(method)
-!DispatcherType.ERROR.equals(request.getDispatcherType())) {
-// Specification states behaviour is undefined
-// Jasper opts to reject any other verbs, partly as they are
-// unlikely to make sense in a JSP context and partly to protect
-// against verb tampering
-response.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED,
-Localizer.getMessage(jsp.error.servlet.invalid.method));
-return;
-}
-
//jspFile may be configured as an init-param for this servlet instance
String jspUri = jspFile;
Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java?rev=1620596r1=1620595r2=1620596view=diff
==
--- tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java Tue Aug
26 13:32:45 2014
@@ -22,6 +22,7 @@ import java.io.IOException;
import java.util.HashMap;
import java.util.Map;
+import javax.servlet.DispatcherType;
import javax.servlet.RequestDispatcher;
import javax.servlet.Servlet;
import javax.servlet.ServletConfig;
@@ -103,6 +104,7 @@ public class JspServletWrapper {
private final boolean unloadAllowed;
private final boolean unloadByCount;
private final boolean unloadByIdle;
+private boolean errorPage;
/*
* JspServletWrapper for JSP pages.
@@ -399,7 +401,6 @@ public class JspServletWrapper {
}
try {
-
/*
* (3) Handle limitation of number of loaded Jsps
*/
@@ -419,6 +420,21 @@ public class JspServletWrapper {
}
}
}
+
+String method = request.getMethod();
+
+if (!GET.equals(method) !POST.equals(method)
!HEAD.equals(method)
+!DispatcherType.ERROR.equals(request.getDispatcherType())
+!isErrorPage()) {
+// Specification states behaviour is undefined
+
[Bug 56568] Incompatible change in JSPs only permit GET POST or HEAD
https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #15 from Mark Thomas ma...@apache.org --- I've added an additional check for isErrorPage. Will be in 8.0.12 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
On Tue, Aug 26, 2014 at 11:20 AM, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org Hi Mark, does the Coverity scan include mod_jk, or does it need to be added to their list? I would be interested to look into that code base a bit deeper. Thanks Martin -- -- Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de
Re: Coverity static analysis scanning
Hi Mark, Am 26.08.2014 um 11:20 schrieb Mark Thomas: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. I'm interested as well, especially if they also scan our native code, and also if they do the scans regularly to check for changes between releases etc. Thanks! Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-apr : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-APR -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build) Work ended in a state of : Failed Elapsed: 26 mins 8 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140826-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20140826/lib -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140826.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140826-native-src.tar.gz -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140826/bin/openssl -Dexecute.test.apr=true -Dexecute.test.bio=false -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140826.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace
Re: Coverity static analysis scanning
hook me up On Tuesday, August 26, 2014, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org javascript:; For additional commands, e-mail: dev-h...@tomcat.apache.org javascript:;
svn commit: r1620666 - /tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
Author: markt
Date: Tue Aug 26 17:25:21 2014
New Revision: 1620666
URL: http://svn.apache.org/r1620666
Log:
Clean-up.
Reduce visibility. Standardise formatting.
Also prep for adding new cookie parsing.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java?rev=1620666r1=1620665r2=1620666view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java Tue Aug 26
17:25:21 2014
@@ -28,9 +28,9 @@ import org.apache.tomcat.util.res.String
/**
* A collection of cookies - reusable and tuned for server side performance.
- * Based on RFC2965 ( and 2109 )
+ * Based on RFC2965 (and 2109).
*
- * This class is not synchronized.
+ * This class is not thread-safe.
*
* @author Costin Manolache
* @author kevin seguin
@@ -41,17 +41,18 @@ public final class Cookies {
private static final UserDataHelper userDataLog = new UserDataHelper(log);
-protected static final StringManager sm =
+private static final StringManager sm =
StringManager.getManager(org.apache.tomcat.util.http);
// expected average number of cookies per request
-public static final int INITIAL_SIZE=4;
-ServerCookie scookies[]=new ServerCookie[INITIAL_SIZE];
-int cookieCount=0;
-boolean unprocessed=true;
+public static final int INITIAL_SIZE = 4;
+private ServerCookie scookies[] = new ServerCookie[INITIAL_SIZE];
+private int cookieCount = 0;
+private boolean unprocessed = true;
private final MimeHeaders headers;
+
/**
* Construct a new cookie collection, that will extract
* the information from headers.
@@ -60,22 +61,21 @@ public final class Cookies {
* information from the provided headers.
*/
public Cookies(MimeHeaders headers) {
-this.headers=headers;
+this.headers = headers;
}
-/**
- * Recycle.
- */
+
public void recycle() {
-for( int i=0; i cookieCount; i++ ) {
-if( scookies[i]!=null ) {
+for (int i = 0; i cookieCount; i++) {
+if (scookies[i] != null) {
scookies[i].recycle();
}
}
-cookieCount=0;
-unprocessed=true;
+cookieCount = 0;
+unprocessed = true;
}
+
/**
* EXPENSIVE!!! only for debugging.
*/
@@ -91,98 +91,90 @@ public final class Cookies {
return sw.toString();
}
-// Indexed access
-public ServerCookie getCookie( int idx ) {
-if( unprocessed ) {
-getCookieCount(); // will also update the cookies
+/**
+ * Indexed access.
+ */
+public ServerCookie getCookie(int idx) {
+if (unprocessed) {
+// This will trigger cookie processing
+getCookieCount();
}
return scookies[idx];
}
+
public int getCookieCount() {
-if( unprocessed ) {
-unprocessed=false;
+if (unprocessed) {
+unprocessed = false;
processCookies(headers);
}
return cookieCount;
}
-// Adding cookies
-/** Register a new, initialized cookie. Cookies are recycled, and
- * most of the time an existing ServerCookie object is returned.
- * The caller can set the name/value and attributes for the cookie
+/**
+ * Register a new, initialized cookie. Cookies are recycled, and most of
the
+ * time an existing ServerCookie object is returned. The caller can set the
+ * name/value and attributes for the cookie.
*/
private ServerCookie addCookie() {
-if( cookieCount = scookies.length ) {
-ServerCookie scookiesTmp[]=new ServerCookie[2*cookieCount];
-System.arraycopy( scookies, 0, scookiesTmp, 0, cookieCount);
-scookies=scookiesTmp;
+if (cookieCount = scookies.length) {
+ServerCookie scookiesTmp[] = new ServerCookie[2*cookieCount];
+System.arraycopy(scookies, 0, scookiesTmp, 0, cookieCount);
+scookies = scookiesTmp;
}
ServerCookie c = scookies[cookieCount];
-if( c==null ) {
-c= new ServerCookie();
-scookies[cookieCount]=c;
+if (c == null) {
+c = new ServerCookie();
+scookies[cookieCount] = c;
}
cookieCount++;
return c;
}
-// code from CookieTools
-
-/** Add all Cookie found in the headers of a request.
- */
-public void processCookies( MimeHeaders headers ) {
-if( headers==null ) {
-return;// nothing to
Re: svn commit: r1620666 - /tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
On 26/08/2014 18:25, ma...@apache.org wrote:
Author: markt
Date: Tue Aug 26 17:25:21 2014
New Revision: 1620666
URL: http://svn.apache.org/r1620666
Log:
Clean-up.
Reduce visibility. Standardise formatting.
Also prep for adding new cookie parsing.
Hmm. Looks like a might have broken something with this. Looking now...
Mark
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java?rev=1620666r1=1620665r2=1620666view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java Tue Aug 26
17:25:21 2014
@@ -28,9 +28,9 @@ import org.apache.tomcat.util.res.String
/**
* A collection of cookies - reusable and tuned for server side performance.
- * Based on RFC2965 ( and 2109 )
+ * Based on RFC2965 (and 2109).
*
- * This class is not synchronized.
+ * This class is not thread-safe.
*
* @author Costin Manolache
* @author kevin seguin
@@ -41,17 +41,18 @@ public final class Cookies {
private static final UserDataHelper userDataLog = new
UserDataHelper(log);
-protected static final StringManager sm =
+private static final StringManager sm =
StringManager.getManager(org.apache.tomcat.util.http);
// expected average number of cookies per request
-public static final int INITIAL_SIZE=4;
-ServerCookie scookies[]=new ServerCookie[INITIAL_SIZE];
-int cookieCount=0;
-boolean unprocessed=true;
+public static final int INITIAL_SIZE = 4;
+private ServerCookie scookies[] = new ServerCookie[INITIAL_SIZE];
+private int cookieCount = 0;
+private boolean unprocessed = true;
private final MimeHeaders headers;
+
/**
* Construct a new cookie collection, that will extract
* the information from headers.
@@ -60,22 +61,21 @@ public final class Cookies {
* information from the provided headers.
*/
public Cookies(MimeHeaders headers) {
-this.headers=headers;
+this.headers = headers;
}
-/**
- * Recycle.
- */
+
public void recycle() {
-for( int i=0; i cookieCount; i++ ) {
-if( scookies[i]!=null ) {
+for (int i = 0; i cookieCount; i++) {
+if (scookies[i] != null) {
scookies[i].recycle();
}
}
-cookieCount=0;
-unprocessed=true;
+cookieCount = 0;
+unprocessed = true;
}
+
/**
* EXPENSIVE!!! only for debugging.
*/
@@ -91,98 +91,90 @@ public final class Cookies {
return sw.toString();
}
-// Indexed access
-public ServerCookie getCookie( int idx ) {
-if( unprocessed ) {
-getCookieCount(); // will also update the cookies
+/**
+ * Indexed access.
+ */
+public ServerCookie getCookie(int idx) {
+if (unprocessed) {
+// This will trigger cookie processing
+getCookieCount();
}
return scookies[idx];
}
+
public int getCookieCount() {
-if( unprocessed ) {
-unprocessed=false;
+if (unprocessed) {
+unprocessed = false;
processCookies(headers);
}
return cookieCount;
}
-// Adding cookies
-/** Register a new, initialized cookie. Cookies are recycled, and
- * most of the time an existing ServerCookie object is returned.
- * The caller can set the name/value and attributes for the cookie
+/**
+ * Register a new, initialized cookie. Cookies are recycled, and most of
the
+ * time an existing ServerCookie object is returned. The caller can set
the
+ * name/value and attributes for the cookie.
*/
private ServerCookie addCookie() {
-if( cookieCount = scookies.length ) {
-ServerCookie scookiesTmp[]=new ServerCookie[2*cookieCount];
-System.arraycopy( scookies, 0, scookiesTmp, 0, cookieCount);
-scookies=scookiesTmp;
+if (cookieCount = scookies.length) {
+ServerCookie scookiesTmp[] = new ServerCookie[2*cookieCount];
+System.arraycopy(scookies, 0, scookiesTmp, 0, cookieCount);
+scookies = scookiesTmp;
}
ServerCookie c = scookies[cookieCount];
-if( c==null ) {
-c= new ServerCookie();
-scookies[cookieCount]=c;
+if (c == null) {
+c = new ServerCookie();
+scookies[cookieCount] = c;
}
svn commit: r1620672 - /tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
Author: markt
Date: Tue Aug 26 17:35:17 2014
New Revision: 1620672
URL: http://svn.apache.org/r1620672
Log:
Fix refactoring snafu
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java?rev=1620672r1=1620671r2=1620672view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/Cookies.java Tue Aug 26
17:35:17 2014
@@ -145,7 +145,7 @@ public final class Cookies {
while (pos = 0) {
MessageBytes cookieValue = headers.getValue(pos);
-if (cookieValue != null cookieValue.isNull() ) {
+if (cookieValue != null !cookieValue.isNull() ) {
if (cookieValue.getType() != MessageBytes.T_BYTES ) {
Exception e = new Exception();
log.warn(Cookies: Parsing cookie as String. Expected
bytes., e);
@@ -252,7 +252,7 @@ public final class Cookies {
* RFC 2965
* JVK
*/
-protected final void processCookieHeader(byte bytes[], int off, int len){
+final void processCookieHeader(byte bytes[], int off, int len){
if (len = 0 || bytes == null) {
return;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
Hi, 2014-08-26 18:44 GMT+03:00 Rainer Jung rainer.j...@kippdata.de: Hi Mark, Am 26.08.2014 um 11:20 schrieb Mark Thomas: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. I'm interested as well, especially if they also scan our native code, and also if they do the scans regularly to check for changes between releases etc. For one of other open source projects where I participate I run their build tool by myself and then upload the results. Based on them they perform their analysis. So we can do the same for our native code. @Mark I was added successfully to the project. Violeta Thanks! Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620693 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Tue Aug 26 18:53:37 2014 New Revision: 1620693 URL: http://svn.apache.org/r1620693 Log: Add release dates Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1620693r1=1620692r2=1620693view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Aug 26 18:53:37 2014 @@ -103,7 +103,7 @@ /changelog /subsection /section -section name=Tomcat 8.0.11 (markt) +section name=Tomcat 8.0.11 (markt) rtext=2014-08-22 subsection name=Catalina changelog fix @@ -528,7 +528,7 @@ /changelog /subsection /section -section name=Tomcat 8.0.9 (markt) +section name=Tomcat 8.0.9 (markt) rtext=2014-06-24 subsection name=Catalina changelog fix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620694 - in /tomcat/site/trunk: docs/download-80.html docs/index.html docs/migration-8.html docs/oldnews.html docs/whichversion.html xdocs/download-80.xml xdocs/index.xml xdocs/migration
Author: markt Date: Tue Aug 26 18:55:13 2014 New Revision: 1620694 URL: http://svn.apache.org/r1620694 Log: Update site for 8.0.11 release Modified: tomcat/site/trunk/docs/download-80.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/migration-8.html tomcat/site/trunk/docs/oldnews.html tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/xdocs/download-80.xml tomcat/site/trunk/xdocs/index.xml tomcat/site/trunk/xdocs/migration-8.xml tomcat/site/trunk/xdocs/oldnews.xml tomcat/site/trunk/xdocs/whichversion.xml Modified: tomcat/site/trunk/docs/download-80.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1620694r1=1620693r2=1620694view=diff == --- tomcat/site/trunk/docs/download-80.html (original) +++ tomcat/site/trunk/docs/download-80.html Tue Aug 26 18:55:13 2014 @@ -204,8 +204,8 @@ div class=text a href=https://www.apache.org/dist/tomcat/tomcat-8/KEYS;KEYS/a | -a href=#8.0.98.0.9/a | -a href=[preferred]tomcat/tomcat-8/v8.0.9 rel=nofollowBrowse/a | +a href=#8.0.118.0.11/a | +a href=[preferred]tomcat/tomcat-8/v8.0.11 rel=nofollowBrowse/a | a href=http://archive.apache.org/dist/tomcat/tomcat-8;Archives/a /div @@ -251,12 +251,12 @@ /div -h3 id=8.0.98.0.9/h3 +h3 id=8.0.118.0.11/h3 div class=text p Please see the - a href=[preferred]tomcat/tomcat-8/v8.0.9/README.html rel=nofollowREADME/a + a href=[preferred]tomcat/tomcat-8/v8.0.11/README.html rel=nofollowREADME/a file for packaging information. It explains what every distribution contains. /p @@ -272,44 +272,44 @@ li -a href=[preferred]tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9.zip rel=nofollowzip/a -(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9.zip.asc;pgp/a, -a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9.zip.md5;md5/a) +a href=[preferred]tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.zip rel=nofollowzip/a +(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.zip.asc;pgp/a, +a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.zip.md5;md5/a) /li li -a href=[preferred]tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9.tar.gz rel=nofollowtar.gz/a -(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9.tar.gz.asc;pgp/a, -a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9.tar.gz.md5;md5/a) +a href=[preferred]tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.tar.gz rel=nofollowtar.gz/a +(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.tar.gz.asc;pgp/a, +a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11.tar.gz.md5;md5/a) /li li -a href=[preferred]tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-x86.zip rel=nofollow32-bit Windows zip/a -(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-x86.zip.asc;pgp/a, -a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-x86.zip.md5;md5/a) +a href=[preferred]tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x86.zip rel=nofollow32-bit Windows zip/a +(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x86.zip.asc;pgp/a, +a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x86.zip.md5;md5/a) /li li -a href=[preferred]tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-x64.zip rel=nofollow64-bit Windows zip/a -(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-x64.zip.asc;pgp/a, -a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-x64.zip.md5;md5/a) +a href=[preferred]tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x64.zip rel=nofollow64-bit Windows zip/a +(a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x64.zip.asc;pgp/a, +a href=https://www.apache.org/dist/tomcat/tomcat-8/v8.0.11/bin/apache-tomcat-8.0.11-windows-x64.zip.md5;md5/a) /li li -a href=[preferred]tomcat/tomcat-8/v8.0.9/bin/apache-tomcat-8.0.9-windows-i64.zip rel=nofollow64-bit Itanium Windows zip/a -(a
Re: Coverity static analysis scanning
On 26/08/2014 18:02, Filip Hanik wrote: hook me up Done (and for everyone else who has asked). It appears I now have admin karma for the Coverity's project for scanning Tomcat. The approach I am taking is Tomcat committers get the Maintainer/Owner role and everyone else gets the Observer role. The idea being that if someone contributes enough that we want to change their role we probably should make them a committer :) Mark On Tuesday, August 26, 2014, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org javascript:; For additional commands, e-mail: dev-h...@tomcat.apache.org javascript:; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
On 26.08.2014, at 22:19, Mark Thomas ma...@apache.org wrote: On 26/08/2014 18:02, Filip Hanik wrote: hook me up Done (and for everyone else who has asked). Thanks Mark. It appears I now have admin karma for the Coverity's project for scanning Tomcat. The approach I am taking is Tomcat committers get the Maintainer/Owner role and everyone else gets the Observer role. The idea being that if someone contributes enough that we want to change their role we probably should make them a committer :) Mark On Tuesday, August 26, 2014, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org javascript:; For additional commands, e-mail: dev-h...@tomcat.apache.org javascript:; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620706 - in /tomcat/site/trunk: ./ docs/tomcat-8.0-doc/ docs/tomcat-8.0-doc/api/ docs/tomcat-8.0-doc/api/org/apache/catalina/ docs/tomcat-8.0-doc/api/org/apache/catalina/ant/ docs/tomcat
Author: markt Date: Tue Aug 26 19:38:25 2014 New Revision: 1620706 URL: http://svn.apache.org/r1620706 Log: Update docs for 8.0.11 [This commit notification would consist of 74 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
Niki Dokovski | @nickytd On 26.08.2014, at 22:26, Niki Dokovski nick...@gmail.com wrote: On 26.08.2014, at 22:19, Mark Thomas ma...@apache.org wrote: On 26/08/2014 18:02, Filip Hanik wrote: hook me up Done (and for everyone else who has asked). Thanks Mark. It appears I now have admin karma for the Coverity's project for scanning Tomcat. The approach I am taking is Tomcat committers get the Maintainer/Owner role and everyone else gets the Observer role. The idea being that if someone contributes enough that we want to change their role we probably should make them a committer :) The observer role does not see actual ‘defects’. Only general statistic is shown on the project dashboard. Mark On Tuesday, August 26, 2014, Mark Thomas ma...@apache.org wrote: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org javascript:; For additional commands, e-mail: dev-h...@tomcat.apache.org javascript:; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RFC6265, cookie parsing and UTF-8
One of the aims of the proposed cookie changes [1] was to deal with the HTML 5 changes that mean UTF-8 can appear in cookie headers. This has some potentially large implications for Tomcat. Currently, Tomcat handles cookies as MessageBytes, processing everything in bytes and only converting to String when necessary. This is largely possible because of the assumption that everything is ASCII. Introduce UTF-8 and processing everything in bytes gets a whole lot harder. You essentially have to decode to UTF-8 to ensure that you have valid data - at a which point why not just use Strings anyway? I am currently leaning towards removing a lot of the current cookie header caching recycling and doing something along the following lines: - Lazy parsing as currently (but unless cookie based session tracking is disabled this is going to run on every request) - Convert headers to UTF-8 strings - Parse them with a new parser along the lines of o.a.t.u.http.parser - Have that parser return an array of javax.servlet.http.Cookie objects - Pass those to the app if/when requested In terms of handling RFC6265 and RFC2109 my plan is to have two parsers, share as much code as possible and switch between them based on the cookie header with the expectation that 99.9% of cookies will be parsed by the RFC6265 parser. We could add some options to this switching to enable other parsers (e.g. a Netscape parser) to be used. I'd also like to keep the current cookie parsing implementation for now. Until we are happy with the new parsing, the current implementation will be the default. Once we are happy with the new parsing we can change the default. We can add an option to switch between the current and the new parsing. Thoughts? Mark [1] https://wiki.apache.org/tomcat/Cookies - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
On 26/08/2014 20:49, Niki Dokovski wrote: The observer role does not see actual ‘defects’. Only general statistic is shown on the project dashboard. About as much use as a chocolate teapot then. I've upgraded all non-committers to contributor / viewer. Any better? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
Niki Dokovski | @nickytd On 26.08.2014, at 22:56, Mark Thomas ma...@apache.org wrote: On 26/08/2014 20:49, Niki Dokovski wrote: The observer role does not see actual ‘defects’. Only general statistic is shown on the project dashboard. About as much use as a chocolate teapot then. I've upgraded all non-committers to contributor / viewer. Any better? Much better. Now the actual issues are visible. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 24 mins 6 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140826-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140826.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140826-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140826/bin/o penssl -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140826.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-spdy.jar:/srv/gump/public/workspace
Re: Coverity static analysis scanning
Mark, On 8/26/14, 5:20 AM, Mark Thomas wrote: I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Wow, this is great. I've used FindBugs before both inside and outside of ASF projects, but this is ... just amazing. It does catch a lot of sanity-checks and complains about them. I get DEAD CODE warnings all the time (in FindBugs) for especially JDBC code when I've caught all possible exceptions and yet still have a finally block that, for example, checks a Connection reference for null and closes it in that case. While the code is technically dead, it's future-proof against someone adding another call that throws a different type of exception, re-ordering some of the operations, or making some other change and forgetting to modify the finally block, etc. It would be nice to know what the consensus is amongst the team about what to do in these cases: should all dead code segments be considered logical oversights and corrected? Or is additional sanity-checking and future-proofing a good idea? A good example is issue 45040 (https://scan3.coverity.com:8443/reports.htm#v16818/p10363/fileInstanceId=567725defectInstanceId=145101mergedDefectId=45040): a logical bug in HttpServlet that should probably remain as-is. It's in the HttpServlet.doOptions method where we build a list of acceptable HTTP verbs. /Technically/, if ALLOW_GET is set, then ALLOW_HEAD must be set and therefore checking for allow (the string of verbs we're building) for NULL is illogical. One could argue that ALLOW_HEAD should be independent of ALLOW_GET -- why can't a servlet implement doHead but not doGet -- but it probably always makes sense to check for null. Stated differently: checking for NULL never hurt anybody. -chris signature.asc Description: OpenPGP digital signature
Re: RFC6265, cookie parsing and UTF-8
Mark, On 8/26/14, 3:53 PM, Mark Thomas wrote: One of the aims of the proposed cookie changes [1] was to deal with the HTML 5 changes that mean UTF-8 can appear in cookie headers. This has some potentially large implications for Tomcat. Currently, Tomcat handles cookies as MessageBytes, processing everything in bytes and only converting to String when necessary. This is largely possible because of the assumption that everything is ASCII. Introduce UTF-8 and processing everything in bytes gets a whole lot harder. You essentially have to decode to UTF-8 to ensure that you have valid data - at a which point why not just use Strings anyway? I've always wondered why we bothered backing everything with MessageBytes when the APIs are all String-bound anyway. I am currently leaning towards removing a lot of the current cookie header caching recycling and doing something along the following lines: - Lazy parsing as currently (but unless cookie based session tracking is disabled this is going to run on every request) - Convert headers to UTF-8 strings - Parse them with a new parser along the lines of o.a.t.u.http.parser - Have that parser return an array of javax.servlet.http.Cookie objects - Pass those to the app if/when requested In terms of handling RFC6265 and RFC2109 my plan is to have two parsers, share as much code as possible and switch between them based on the cookie header with the expectation that 99.9% of cookies will be parsed by the RFC6265 parser. We could add some options to this switching to enable other parsers (e.g. a Netscape parser) to be used. I'd also like to keep the current cookie parsing implementation for now. Until we are happy with the new parsing, the current implementation will be the default. Once we are happy with the new parsing we can change the default. We can add an option to switch between the current and the new parsing. Thoughts? +1 to everything above -chris signature.asc Description: OpenPGP digital signature
svn commit: r1620743 - /tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
Author: schultz
Date: Tue Aug 26 21:41:47 2014
New Revision: 1620743
URL: http://svn.apache.org/r1620743
Log:
Fixed minor resource-leak [Coverity issue #45132].
Modified:
tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java?rev=1620743r1=1620742r2=1620743view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java Tue
Aug 26 21:41:47 2014
@@ -18,6 +18,7 @@ package org.apache.catalina.startup;
import java.io.File;
import java.io.FileInputStream;
+import java.io.IOException;
import java.io.InputStream;
import java.net.URL;
import java.util.Enumeration;
@@ -91,11 +92,18 @@ public class CatalinaProperties {
try {
properties = new Properties();
properties.load(is);
-is.close();
} catch (Throwable t) {
handleThrowable(t);
error = t;
}
+finally
+{
+try {
+is.close();
+} catch (IOException ioe) {
+log.warn(Could not close catalina.properties, ioe);
+}
+}
}
if ((is == null) || (error != null)) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Coverity static analysis scanning
Hi all Are you aware SonarQube is analysing Tomcat in Nemo for years ? http://nemo.sonarqube.org/dashboard/index/50544 310 Blocker issues, 121 Critical issues. Wondering if Coverity will provides more informations than SonarQube ? BTW, SonarQube is analysing major ASF projects for a long time now :) 2014-08-26 11:20 GMT+02:00 Mark Thomas ma...@apache.org: All, I have been pinged off-list by Coverity to say that they have set up Tomcat with a free account with their static code analysis service. I think I have the ability to send invitations so if anyone wants to take a look at the results, just reply here. I have taken a quick look and they do appear to have found some valid threading issues. There are ~350 issues in total and I don't yet have a feel for the false positive rate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1620747 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/CatalinaProperties.java
Author: schultz
Date: Tue Aug 26 21:53:11 2014
New Revision: 1620747
URL: http://svn.apache.org/r1620747
Log:
Back-ported r1620743:
- Fixed minor resource-leak [Coverity issue #45132]
_M .
Mjava/org/apache/catalina/startup/CatalinaProperties.java
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1620743
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/CatalinaProperties.java?rev=1620747r1=1620746r2=1620747view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
Tue Aug 26 21:53:11 2014
@@ -20,6 +20,7 @@ package org.apache.catalina.startup;
import java.io.File;
import java.io.FileInputStream;
+import java.io.IOException;
import java.io.InputStream;
import java.net.URL;
import java.util.Enumeration;
@@ -122,11 +123,18 @@ public class CatalinaProperties {
try {
properties = new Properties();
properties.load(is);
-is.close();
} catch (Throwable t) {
handleThrowable(t);
error = t;
}
+finally
+{
+try {
+is.close();
+} catch (IOException ioe) {
+log.warn(Could not close catalina.properties, ioe);
+}
+}
}
if ((is == null) || (error != null)) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: RFC6265, cookie parsing and UTF-8
On Tue, Aug 26, 2014 at 12:53 PM, Mark Thomas ma...@apache.org wrote: One of the aims of the proposed cookie changes [1] was to deal with the HTML 5 changes that mean UTF-8 can appear in cookie headers. This has some potentially large implications for Tomcat. Since we already are in the 8.0.x release cycle, I, as an end user/system administrator, would expect parsing would remain 100% backwards compatible for version 8.0.x+n (n=1...) Currently, Tomcat handles cookies as MessageBytes, processing everything in bytes and only converting to String when necessary. This is largely possible because of the assumption that everything is ASCII. Introduce UTF-8 and processing everything in bytes gets a whole lot harder. You essentially have to decode to UTF-8 to ensure that you have valid data - at a which point why not just use Strings anyway? I am currently leaning towards removing a lot of the current cookie header caching recycling and doing something along the following lines: all that caching/recycling is to avoid GC cycles and was in the past a crucial performance optimization. back in those days, with the hardware that was available in 06-07, we were pushing a single Tomcat instance to 60k requests per second. creating new objects was painfully expensive at that rate. - Lazy parsing as currently (but unless cookie based session tracking is disabled this is going to run on every request) but our cookies, JSESSIONID, doesn't have to be UTF-8, does it? this goes hand in hand with the SessionIdGenerator that Rainer just did, can that return UTF-8 values? So the lazy part can apply to all other cookies, meaning, don't parse it until the app requests it, just store the bytes and move on. - Convert headers to UTF-8 strings - Parse them with a new parser along the lines of o.a.t.u.http.parser - Have that parser return an array of javax.servlet.http.Cookie objects - Pass those to the app if/when requested In terms of handling RFC6265 and RFC2109 my plan is to have two parsers, share as much code as possible and switch between them based on the cookie header with the expectation that 99.9% of cookies will be parsed by the RFC6265 parser. We could add some options to this switching to enable other parsers (e.g. a Netscape parser) to be used. I like the idea of swappable parsers, with the default is the exact behavior you see now. I can see changing the default after some stabilization. I'd also like to keep the current cookie parsing implementation for now. Until we are happy with the new parsing, the current implementation will be the default. Once we are happy with the new parsing we can change the default. We can add an option to switch between the current and the new parsing. Thoughts? knock it out. Mark [1] https://wiki.apache.org/tomcat/Cookies - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: RFC6265, cookie parsing and UTF-8
2014-08-26 21:53 GMT+02:00 Mark Thomas ma...@apache.org: One of the aims of the proposed cookie changes [1] was to deal with the HTML 5 changes that mean UTF-8 can appear in cookie headers. This has some potentially large implications for Tomcat. Currently, Tomcat handles cookies as MessageBytes, processing everything in bytes and only converting to String when necessary. This is largely possible because of the assumption that everything is ASCII. Introduce UTF-8 and processing everything in bytes gets a whole lot harder. You essentially have to decode to UTF-8 to ensure that you have valid data - at a which point why not just use Strings anyway? I am currently leaning towards removing a lot of the current cookie header caching recycling and doing something along the following lines: - Lazy parsing as currently (but unless cookie based session tracking is disabled this is going to run on every request) - Convert headers to UTF-8 strings - Parse them with a new parser along the lines of o.a.t.u.http.parser - Have that parser return an array of javax.servlet.http.Cookie objects - Pass those to the app if/when requested In terms of handling RFC6265 and RFC2109 my plan is to have two parsers, share as much code as possible and switch between them based on the cookie header with the expectation that 99.9% of cookies will be parsed by the RFC6265 parser. We could add some options to this switching to enable other parsers (e.g. a Netscape parser) to be used. I'd also like to keep the current cookie parsing implementation for now. Until we are happy with the new parsing, the current implementation will be the default. Once we are happy with the new parsing we can change the default. We can add an option to switch between the current and the new parsing. Thoughts? As far as I am concerned, this could turn out badly. String manipulation is consistently the slowest thing overall other than IO, and rather often webapps use a massive amount of cookies [to the point they get errors because the HTTP header size is too small by default]. So the current processing should probably be the default [as proposed], then remain an option until it can be demonstrated this is not slower [which IMO is not possible, so it would have to remain]. Rémy
Re: svn commit: r1620596 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ test/org/apache/jasper/servlet/ test/webapp/jsp/ webapps/docs/
2014-08-26 17:32 GMT+04:00 ma...@apache.org:
Author: markt
Date: Tue Aug 26 13:32:45 2014
New Revision: 1620596
URL: http://svn.apache.org/r1620596
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56568
Enable any HTTP method to be used to request a JSP page that has the
isErrorPage page directive set to true.
Added:
tomcat/trunk/test/webapp/jsp/error.jsp (with props)
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java
tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java
tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
tomcat/trunk/test/org/apache/jasper/servlet/TestJspServlet.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java?rev=1620596r1=1620595r2=1620596view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java Tue Aug 26
13:32:45 2014
@@ -255,6 +255,11 @@ public abstract class Compiler {
// to be GC'd and save memory.
ctxt.setWriter(null);
+// Need to know if the JSP is an error page at runtime to
determine
+// which HTTP methods are permitted. Error pages permit any.
Normal
+// pages only permit GET, POST or HEAD.
+jsw.setErrorPage(pageInfo.isErrorPage());
+
Apparently this causes org.apache.jasper.TestJspC to fail with many NPEs,
as noted by Gump in tomcat-trunk-test-nio:
[junit] java.lang.NullPointerException
[junit] at
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:261)
[junit] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:361)
[junit] at org.apache.jasper.JspC.processFile(JspC.java:1217)
All other test cases completed successfully.
if (log.isDebugEnabled()) {
t4 = System.currentTimeMillis();
log.debug(Generated + javaFileName + total= + (t4 - t1)
()
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56890] New: getRealPath returns null
https://issues.apache.org/bugzilla/show_bug.cgi?id=56890 Bug ID: 56890 Summary: getRealPath returns null Product: Tomcat 8 Version: 8.0.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: f.bant...@axon-e.de There is more than one report for this kind of error. since #55837 and #55345 are marked as fixed I have to add another one for 8.0.11. Calling servletContext.getRealPath( ) - some path servletContext.getRealPath( . )- null servletContext.getRealPath( ./ ) - null servletContext.getRealPath( / )- same path s.a. servletContext.getRealPath( test ) - null At least the third one worked under tomcat 7.0.54 as I was using it in order to determine where tomcat had it's webapp directory (this isn't so clear when e.g. running from eclipse) I think most (if not all) of the null results are bugs and the behaviour was perfectly fine under tomcat 8. (Note that this code has worked in Tomcat 5, 6, 7) I would expect that this method to just do translation of the path. As I read the other bug reports it seems that tomcat tries to check if this file exists. But I think this is wrong because the concept of Java File doesn't imply that a File must exist. (It weekly implies that it could exist). So instead File has a method 'createNewFile' which clearly wouldn't be there if the file already existed. Furthermore if I wanted to check if a paricular file existed I would use file.exists(), ...canRead() and so on. Finally the specs state that this method could return under any circumstances. If taken literally this would lead to the question what good it is for anyway if it could just return null no matter what. As I read e.g. https://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/ServletRequest.html the 'null' result is there to indicate that the path to this (potential) file is not leading into the filesystem and therefor makes no sense at all. Best regards and keep up the great work Scheintod -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56891] New: fgf
https://issues.apache.org/bugzilla/show_bug.cgi?id=56891 Bug ID: 56891 Summary: fgf Product: Tomcat Modules Version: unspecified Hardware: PC Status: NEW Severity: normal Priority: P2 Component: jdbc-pool Assignee: dev@tomcat.apache.org Reporter: saurabhsx...@gmail.com ghjh -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-bio has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-bio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-BIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-BIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-bio/gump_work/build_tomcat-trunk_tomcat-trunk-test-bio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-bio (Type: Build) Work ended in a state of : Failed Elapsed: 22 mins 49 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140827.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dtest.temp=output/test-tmp-BIO -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140827/bin/ openssl -Dexecute.test.apr=false -Dexecute.test.bio=true -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140827.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 24 mins 43 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140827.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140827/bi n/openssl -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=true -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140827.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-nio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 58 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-nio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-NIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 16 mins 50 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140827.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dexecute.test.nio=true -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/pub lic/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dexecute.test.apr=false -Dexecute.test.bio=false -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20140827.jar -Dtest.temp=output/test-tmp-NIO -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140827.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 24 mins 18 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140827.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140827/bin/o penssl -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140827.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 58 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-bio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-BIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-BIO/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio (Type: Build) Work ended in a state of : Failed Elapsed: 16 mins 2 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140827.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dexecute.test.nio=false -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/pu blic/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dexecute.test.apr=false -Dexecute.test.bio=true -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20140827.jar -Dtest.temp=output/test-tmp-BIO -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140827.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
[Bug 56891] fgf
https://issues.apache.org/bugzilla/show_bug.cgi?id=56891 Chuck Caldarale chuck.caldar...@unisys.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID OS||All --- Comment #1 from Chuck Caldarale chuck.caldar...@unisys.com --- Blithering idiot. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-apr : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-APR -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build) Work ended in a state of : Failed Elapsed: 25 mins 30 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20140827/lib -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140827.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140827-native-src.tar.gz -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20140827/bin/openssl -Dexecute.test.apr=true -Dexecute.test.bio=false -Dexecute.test.nio2=false -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20140827.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
Re: Too few fatal log ststements
Dear Team, I have one query. There are different logging levels in tomcat. Does it matters alot to use right log level? I mean as a researcher I am exploring in which scenarios one should be extremely careful to use right log level. Can anyone of please throw more light on this topic. Thank You On Tue, Aug 12, 2014 at 9:04 AM, sangeeta lal sangeeta.6...@gmail.com wrote: Thanks! All of you :) Now I have much more understanding about tomcat logging. Thanks a lot! On Mon, Aug 11, 2014 at 7:26 PM, Christopher Schultz ch...@christopherschultz.net wrote: Sangeeta, On 8/11/14, 5:41 AM, sangeeta lal wrote: Actually I have data for other log levels also. Debug =600 statements, error=400 statements, trace =90 statements etc. I would usually expect in a typical project that there would be more TRACE logging statements than anything else. On the other hand, DEBUG tends to be the default log level used by most developers that I observe. There are likely many DEBUG statements in Tomcat's code that perhaps should be TRACE statements. 400 ERROR versus 600 DEBUG seems like an awfully large number of ERROR statements, but that may simply be evidence that most errors are properly-logged while there is less DEBUG logging than average. I am just curious, what could be the possible reason for having such few fatal statements. Can you give your opinion about this? There aren't too many things that ate truly /fatal/ to Tomcat. If we can read config files, mostly everything is okay. One might consider that failing to bind to a port is a fatal error, but Tomcat can start up successfully even if no connectors can start properly. This is because connectors can be configured on the fly, etc. and, in embedded contexts, the state of the container can change from within and therefore zero live connectors is no cause for alarm. Most errors don't take-down the container/JVM, so they aren't considered fatal. I wouldn't expect to see very many FATAL log messages in any product, really: the truly fatal things happen at the JVM level and would end up emitting a message to stdout and possibly bringing-down the JVM entirely (e.g. segmentation fault). If you have some /suggestions/ for what conditions might be fatal, we might be able to comment on those specifically. But, we aren't going to re-evaluate every component in Tomcat for logging to satisfy your academic curiosity about logging practices in the Tomcat source. -chris -- Regards... Sangeeta Assistant Professor CSE Department @JIIT Noida -- Regards... Sangeeta Assistant Professor CSE Department @JIIT Noida
