svn commit: r1631628 - in /tomcat/trunk: java/org/apache/catalina/ha/ClusterRuleSet.java java/org/apache/catalina/ha/session/ClusterManagerBase.java webapps/docs/changelog.xml webapps/docs/config/clus

2014-10-14 Thread kfujino
Author: kfujino
Date: Tue Oct 14 06:08:49 2014
New Revision: 1631628

URL: http://svn.apache.org/r1631628
Log:
Add support for the SessionIdGenerator to cluster manager template.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java
tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/cluster-manager.xml

Modified: tomcat/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java?rev=1631628r1=1631627r2=1631628view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java Tue Oct 14 
06:08:49 2014
@@ -91,7 +91,13 @@ public class ClusterRuleSet extends Rule
 digester.addSetNext(prefix + Manager,
 setManagerTemplate,
 org.apache.catalina.ha.ClusterManager);
-
+digester.addObjectCreate(prefix + Manager/SessionIdGenerator,
+org.apache.catalina.util.StandardSessionIdGenerator,
+className);
+digester.addSetProperties(prefix + Manager/SessionIdGenerator);
+digester.addSetNext(prefix + Manager/SessionIdGenerator,
+   setSessionIdGenerator,
+   org.apache.catalina.SessionIdGenerator);
 
 digester.addObjectCreate(prefix + Channel,
  null, // MUST be specified in the element

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java?rev=1631628r1=1631627r2=1631628view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java 
Tue Oct 14 06:08:49 2014
@@ -24,6 +24,7 @@ import org.apache.catalina.Cluster;
 import org.apache.catalina.Context;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.Loader;
+import org.apache.catalina.SessionIdGenerator;
 import org.apache.catalina.Valve;
 import org.apache.catalina.ha.CatalinaCluster;
 import org.apache.catalina.ha.ClusterManager;
@@ -199,6 +200,17 @@ public abstract class ClusterManagerBase
 copy.setSecureRandomClass(getSecureRandomClass());
 copy.setSecureRandomProvider(getSecureRandomProvider());
 copy.setSecureRandomAlgorithm(getSecureRandomAlgorithm());
+if (getSessionIdGenerator() != null) {
+try {
+SessionIdGenerator copyIdGenerator = 
sessionIdGeneratorClass.newInstance();
+
copyIdGenerator.setSessionIdLength(getSessionIdGenerator().getSessionIdLength());
+
copyIdGenerator.setJvmRoute(getSessionIdGenerator().getJvmRoute());
+copy.setSessionIdGenerator(copyIdGenerator);
+} catch (InstantiationException | IllegalAccessException e) {
+ // Ignore
+}
+}
+   
 }
 
 /**

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1631628r1=1631627r2=1631628view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Oct 14 06:08:49 2014
@@ -152,6 +152,14 @@
   /scode
 /changelog
   /subsection
+  subsection name=Cluster
+changelog
+  fix
+Add support for the codeSessionIdGenerator/code to cluster manager
+template. (kfujino)
+  /fix
+/changelog
+  /subsection
   subsection name=WebSocket
 changelog
   fix

Modified: tomcat/trunk/webapps/docs/config/cluster-manager.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/cluster-manager.xml?rev=1631628r1=1631627r2=1631628view=diff
==
--- tomcat/trunk/webapps/docs/config/cluster-manager.xml (original)
+++ tomcat/trunk/webapps/docs/config/cluster-manager.xml Tue Oct 14 06:08:49 
2014
@@ -226,5 +226,21 @@
 /attributes
   /subsection
 /section
+section name=Nested Components
+  h3All Manager Implementations/h3
+  pAll Manager implementations allow nesting of a
+  stronglt;SessionIdGeneratorgt;/strong element. It defines
+  the behavior of session id generation.  All implementations
+  of the a href=sessionidgenerator.htmlSessionIdGenerator/a allow the
+  following attributes:
+  /p
+  attributes
+attribute name=sessionIdLength required=false
+  pThe length of the session ID may be changed with the
+  

Question of new SessionIdGenerator implementation.

2014-10-14 Thread Keiichi Fujino
I have a question of new SessionIdGenerator implementation.
If reloading Manager( or Context), SessionIdGenerator is re-created based
on sessionIdGeneratorClass that is cached to Manager.
However, attributes of jvmRoute and sessionIdLength are default value.
I think these attributes are need to take over when reloading.
Or another workaround?


-- 
Keiichi.Fujino


svn commit: r1631679 - in /tomcat/trunk/java/javax/servlet: ./ http/

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 08:28:57 2014
New Revision: 1631679

URL: http://svn.apache.org/r1631679
Log:
Fix the remaining Java 8 Javadoc warnings for the Servlet API packages

Modified:
tomcat/trunk/java/javax/servlet/HttpConstraintElement.java
tomcat/trunk/java/javax/servlet/ReadListener.java
tomcat/trunk/java/javax/servlet/Registration.java
tomcat/trunk/java/javax/servlet/ServletContext.java
tomcat/trunk/java/javax/servlet/ServletContextAttributeEvent.java
tomcat/trunk/java/javax/servlet/ServletRequestWrapper.java
tomcat/trunk/java/javax/servlet/ServletResponse.java
tomcat/trunk/java/javax/servlet/ServletResponseWrapper.java
tomcat/trunk/java/javax/servlet/ServletSecurityElement.java
tomcat/trunk/java/javax/servlet/SessionCookieConfig.java
tomcat/trunk/java/javax/servlet/WriteListener.java
tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java
tomcat/trunk/java/javax/servlet/http/HttpServletRequestWrapper.java
tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java
tomcat/trunk/java/javax/servlet/http/HttpServletResponseWrapper.java
tomcat/trunk/java/javax/servlet/http/HttpSession.java
tomcat/trunk/java/javax/servlet/http/HttpSessionActivationListener.java
tomcat/trunk/java/javax/servlet/http/HttpSessionAttributeListener.java
tomcat/trunk/java/javax/servlet/http/HttpSessionBindingEvent.java
tomcat/trunk/java/javax/servlet/http/HttpSessionContext.java
tomcat/trunk/java/javax/servlet/http/HttpSessionEvent.java
tomcat/trunk/java/javax/servlet/http/Part.java
tomcat/trunk/java/javax/servlet/http/WebConnection.java

Modified: tomcat/trunk/java/javax/servlet/HttpConstraintElement.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/HttpConstraintElement.java?rev=1631679r1=1631678r2=1631679view=diff
==
--- tomcat/trunk/java/javax/servlet/HttpConstraintElement.java (original)
+++ tomcat/trunk/java/javax/servlet/HttpConstraintElement.java Tue Oct 14 
08:28:57 2014
@@ -22,8 +22,10 @@ import javax.servlet.annotation.ServletS
 import javax.servlet.annotation.ServletSecurity.TransportGuarantee;
 
 /**
+ * Equivalent of {@link javax.servlet.annotation.HttpConstraint} for
+ * programmatic configuration of security constraints.
+ *
  * @since Servlet 3.0
- * TODO SERVLET3 - Add comments
  */
 public class HttpConstraintElement {
 
@@ -46,8 +48,11 @@ public class HttpConstraintElement {
 }
 
 /**
- * Convenience constructor for {@link EmptyRoleSemantic#DENY}.
+ * Construct a constraint with an empty role semantic. Typically used with
+ * {@link EmptyRoleSemantic#DENY}.
  *
+ * @param emptyRoleSemantic The empty role semantic to apply to the newly
+ *  created constraint
  */
 public HttpConstraintElement(EmptyRoleSemantic emptyRoleSemantic) {
 this.emptyRoleSemantic = emptyRoleSemantic;
@@ -56,7 +61,12 @@ public class HttpConstraintElement {
 }
 
 /**
- * Convenience constructor to specify transport guarantee and/or roles.
+ * Construct a constraint with a transport guarantee and roles.
+ *
+ * @param transportGuarantee The transport guarantee to apply to the newly
+ *   created constraint
+ * @param rolesAllowed   The roles to associate with the newly created
+ *   constraint
  */
 public HttpConstraintElement(TransportGuarantee transportGuarantee,
 String... rolesAllowed) {
@@ -66,10 +76,15 @@ public class HttpConstraintElement {
 }
 
 /**
+ * Construct a constraint with an empty role semantic, a transport 
guarantee
+ * and roles.
  *
- * @param emptyRoleSemantic
- * @param transportGuarantee
- * @param rolesAllowed
+ * @param emptyRoleSemantic The empty role semantic to apply to the newly
+ *  created constraint
+ * @param transportGuarantee The transport guarantee to apply to the newly
+ *   created constraint
+ * @param rolesAllowed   The roles to associate with the newly created
+ *   constraint
  * @throws IllegalArgumentException if roles are specified when DENY is 
used
  */
 public HttpConstraintElement(EmptyRoleSemantic emptyRoleSemantic,
@@ -84,14 +99,26 @@ public class HttpConstraintElement {
 this.rolesAllowed = rolesAllowed;
 }
 
+/**
+ * TODO
+ * @return TODO
+ */
 public EmptyRoleSemantic getEmptyRoleSemantic() {
 return emptyRoleSemantic;
 }
 
+/**
+ * TODO
+ * @return TODO
+ */
 public TransportGuarantee getTransportGuarantee() {
 return transportGuarantee;
 }
 
+/**
+ * TODO
+ * @return TODO
+ */
 public String[] getRolesAllowed() {
 return rolesAllowed;
 }

Modified: 

buildbot failure in ASF Buildbot on tomcat-trunk

2014-10-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/543

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1631628
Blamelist: kfujino

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631717 - in /tomcat/trunk/java/javax/el: BeanNameResolver.java ELContext.java ELContextEvent.java ELProcessor.java ELResolver.java EvaluationListener.java ExpressionFactory.java Function

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 11:03:22 2014
New Revision: 1631717

URL: http://svn.apache.org/r1631717
Log:
Fix the remaining Javadoc warnings for the EL API when building  with Java 8.

Modified:
tomcat/trunk/java/javax/el/BeanNameResolver.java
tomcat/trunk/java/javax/el/ELContext.java
tomcat/trunk/java/javax/el/ELContextEvent.java
tomcat/trunk/java/javax/el/ELProcessor.java
tomcat/trunk/java/javax/el/ELResolver.java
tomcat/trunk/java/javax/el/EvaluationListener.java
tomcat/trunk/java/javax/el/ExpressionFactory.java
tomcat/trunk/java/javax/el/FunctionMapper.java
tomcat/trunk/java/javax/el/MethodExpression.java
tomcat/trunk/java/javax/el/ValueExpression.java

Modified: tomcat/trunk/java/javax/el/BeanNameResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/BeanNameResolver.java?rev=1631717r1=1631716r2=1631717view=diff
==
--- tomcat/trunk/java/javax/el/BeanNameResolver.java (original)
+++ tomcat/trunk/java/javax/el/BeanNameResolver.java Tue Oct 14 11:03:22 2014
@@ -26,16 +26,24 @@ public abstract class BeanNameResolver {
 
 /**
  * Can this resolver resolve the given bean name?
+ *
+ * @param beanName The bean name to resolve
+ *
+ * @return This default implementation always returns codefalse/code
  */
-public boolean isNameResolved(@SuppressWarnings(unused) String beanName) 
{
+public boolean isNameResolved(String beanName) {
 return false;
 }
 
 
 /**
  * Returns the named bean.
+ *
+ * @param beanName The bean name to return
+ *
+ * @return This default implementation always returns codenull/code
  */
-public Object getBean(@SuppressWarnings(unused) String beanName) {
+public Object getBean(String beanName) {
 return null;
 }
 
@@ -44,9 +52,11 @@ public abstract class BeanNameResolver {
  * Sets a value of a bean of the given name. If the named bean does not
  * exist and {@link #canCreateBean} returns codetrue/code then a bean
  * is created with the given value.
+ *
+ * @param beanName The name of the bean to be set/create
+ * @param valueThe value of the bean to set/create
  */
-public void setBeanValue(@SuppressWarnings(unused) String beanName,
-@SuppressWarnings(unused) Object value)
+public void setBeanValue(String beanName, Object value)
 throws PropertyNotWritableException{
 throw new PropertyNotWritableException();
 }
@@ -54,16 +64,26 @@ public abstract class BeanNameResolver {
 
 /**
  * Is the named bean read-only?
+ *
+ * @param beanName The name of the bean of interest
+ *
+ * @return codetrue/code if the bean is read only, otherwise
+ * codefalse/code
  */
-public boolean isReadOnly(@SuppressWarnings(unused) String beanName) {
+public boolean isReadOnly(String beanName) {
 return true;
 }
 
 
 /**
  * Is it permitted to create a bean of the given name?
+ *
+ * @param beanName The name of the bean of interest
+ *
+ * @return codetrue/code if the bean may be created, otherwise
+ * codefalse/code
  */
-public boolean canCreateBean(@SuppressWarnings(unused) String beanName) {
+public boolean canCreateBean(String beanName) {
 return false;
 }
 }

Modified: tomcat/trunk/java/javax/el/ELContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ELContext.java?rev=1631717r1=1631716r2=1631717view=diff
==
--- tomcat/trunk/java/javax/el/ELContext.java (original)
+++ tomcat/trunk/java/javax/el/ELContext.java Tue Oct 14 11:03:22 2014
@@ -47,6 +47,11 @@ public abstract class ELContext {
 }
 
 /**
+ * Mark the given property as resolved and notfy any interested listeners.
+ *
+ * @param base The base object on which the property was found
+ * @param property The property that was resolved
+ *
  * @since EL 3.0
  */
 public void setPropertyResolved(Object base, Object property) {
@@ -60,6 +65,11 @@ public abstract class ELContext {
 
 // Can't use Class? because API needs to match specification
 /**
+ * Add an object to this EL context under the given key.
+ *
+ * @param key   The key under which to store the object
+ * @param contextObject The object to add
+ *
  * @throws NullPointerException
  *  If the supplied key or context is codenull/code
  */
@@ -78,6 +88,12 @@ public abstract class ELContext {
 
 // Can't use Class? because API needs to match specification
 /**
+ * Obtain the context object for the given key.
+ *
+ * @param key The key of the required context object
+ *
+ * @return The value of the context object associated with the given key
+ *
  

Re: Question of new SessionIdGenerator implementation.

2014-10-14 Thread Konstantin Kolinko
2014-10-14 10:12 GMT+04:00 Keiichi Fujino kfuj...@apache.org:
 I have a question of new SessionIdGenerator implementation.
 If reloading Manager( or Context), SessionIdGenerator is re-created based
 on sessionIdGeneratorClass that is cached to Manager.
 However, attributes of jvmRoute and sessionIdLength are default value.
 I think these attributes are need to take over when reloading.
 Or another workaround?

Looking at ManagerBase.startInternal(), I think that

1) jvmRoute shall not be set on SessionIdGenerator element. It is
set on Engine and is inherited from there. The documentation on
jvmRoute attribute in config/sessionidgenerator.html explicitly
mentions that effect.

It ManagerBase.startInternal() there is the following code:
 sessionIdGenerator.setJvmRoute(getJvmRoute());

2) For sessionIdLength I think one shall be able to configure it on
SessionIdGenerator, so the current behaviour is a bug and is worth
to be added to Bugzilla.

The workaround is to set that attribute on Manager element. (This
contradicts documentation that says that this attribute on Manager
element is deprecated).

The fix is probably to let SessionIdGenerator to implement Lifecycle interface.

The this.sessionIdGenerator = null; assignment in
ManagerBase.stopInternal() originates from r1044874. That is a wrong
place to clear sessionIdGenerator reference. A better place would be
destroyInternal(), or just do not clear it.

The old code before r1044874 was calling randoms.clear(); there. I
think it is easier to expose that method via Lifecycle.stop().

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631730 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2014-10-14 Thread fschumacher
Author: fschumacher
Date: Tue Oct 14 12:18:09 2014
New Revision: 1631730

URL: http://svn.apache.org/r1631730
Log:
Avoid possible integer overflows reported by Coverity Scan

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1631730r1=1631729r2=1631730view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Tue Oct 
14 12:18:09 2014
@@ -850,7 +850,7 @@ public class DeltaManager extends Cluste
 //
 }
 reqNow = System.currentTimeMillis();
-isTimeout = ((reqNow - reqStart)  (1000 * 
getStateTransferTimeout()));
+isTimeout = ((reqNow - reqStart)  (1000L * 
getStateTransferTimeout()));
 } while ((!getStateTransfered())  (!isTimeout)  
(!isNoContextManagerReceived()));
 } else {
 if(getStateTransferTimeout() == -1) {
@@ -1031,7 +1031,7 @@ public class DeltaManager extends Cluste
 if (!expires  (msg == null)) {
 long replDelta = System.currentTimeMillis() - 
session.getLastTimeReplicated();
 if (session.getMaxInactiveInterval() =0 
-replDelta  (session.getMaxInactiveInterval() * 1000)) 
{
+replDelta  (session.getMaxInactiveInterval() * 
1000L)) {
 counterSend_EVT_SESSION_ACCESSED++;
 msg = new SessionMessageImpl(getName(),
  
SessionMessage.EVT_SESSION_ACCESSED,

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1631730r1=1631729r2=1631730view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Oct 14 12:18:09 2014
@@ -158,6 +158,9 @@
 Add support for the codeSessionIdGenerator/code to cluster manager
 template. (kfujino)
   /fix
+  fix
+Avoid possible integer overflows reported by Coverity Scan. 
(fschumacher)
+  /fix
 /changelog
   /subsection
   subsection name=WebSocket



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57089] New: Configuration of SessionIdGenerator element is lost on reload

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57089

Bug ID: 57089
   Summary: Configuration of SessionIdGenerator element is lost
on reload
   Product: Tomcat 8
   Version: 8.0.14
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: knst.koli...@gmail.com

From Question of new SessionIdGenerator implementation. thread on dev@,
http://tomcat.markmail.org/thread/2lic23zbhesgftld

If reloading Manager( or Context), SessionIdGenerator is cleared in
ManagerBase.stopInternal() and re-created in ManagerBase.startInternal().

Expected: If there is SessionIdGenerator element in a Manager element,
restarting a web application should preserve the options set on it.

Actual: Any configuration options specified on SessionIdGenerator
configuration element are lost.

Workaround
---
A workaround is to specify attributes such as sessionIdLength on Manager
element.

Fix

The fix is probably to let SessionIdGenerator to implement Lifecycle interface.

The this.sessionIdGenerator = null; assignment in ManagerBase.stopInternal()
originates from r1044874. The old code before r1044874 was calling
randoms.clear(); there. I think it is easier to expose that clear method via
Lifecycle.stop().

Technically, there was no bug in r1044874 itself, as that was just an internal
implementation change. It have not exposed SessionIdGenerator as a
configuration element.

The ability configure session id generator via an XML element was added later
in r1619056.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Question of new SessionIdGenerator implementation.

2014-10-14 Thread Konstantin Kolinko
2014-10-14 16:17 GMT+04:00 Konstantin Kolinko knst.koli...@gmail.com:
 2014-10-14 10:12 GMT+04:00 Keiichi Fujino kfuj...@apache.org:
 I have a question of new SessionIdGenerator implementation.
 If reloading Manager( or Context), SessionIdGenerator is re-created based
 on sessionIdGeneratorClass that is cached to Manager.
 However, attributes of jvmRoute and sessionIdLength are default value.
 I think these attributes are need to take over when reloading.
 Or another workaround?

 Looking at ManagerBase.startInternal(), I think that

 1) jvmRoute shall not be set on SessionIdGenerator element. It is
 set on Engine and is inherited from there. The documentation on
 jvmRoute attribute in config/sessionidgenerator.html explicitly
 mentions that effect.

 It ManagerBase.startInternal() there is the following code:
  sessionIdGenerator.setJvmRoute(getJvmRoute());

 2) For sessionIdLength I think one shall be able to configure it on
 SessionIdGenerator, so the current behaviour is a bug and is worth
 to be added to Bugzilla.

 The workaround is to set that attribute on Manager element. (This
 contradicts documentation that says that this attribute on Manager
 element is deprecated).

 The fix is probably to let SessionIdGenerator to implement Lifecycle 
 interface.

 The this.sessionIdGenerator = null; assignment in
 ManagerBase.stopInternal() originates from r1044874. That is a wrong
 place to clear sessionIdGenerator reference. A better place would be
 destroyInternal(), or just do not clear it.

 The old code before r1044874 was calling randoms.clear(); there. I
 think it is easier to expose that method via Lifecycle.stop().

I filed
https://issues.apache.org/bugzilla/show_bug.cgi?id=57089

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57091] New: Websockets cannot be used in Windows applet plugin environments based on Oracle Java7

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57091

Bug ID: 57091
   Summary: Websockets cannot be used in Windows applet plugin
environments based on Oracle Java7
   Product: Tomcat 8
   Version: 8.0.14
  Hardware: PC
Status: NEW
  Severity: critical
  Priority: P2
 Component: WebSocket
  Assignee: dev@tomcat.apache.org
  Reporter: niklas+apa...@appli.se

When using the Tomcat8 Websockets implementation in a Windows JRE 1.7.0_67
applet environment an AccessControlException occurs even though a policy
allowing everything is in charge.

Exception in thread anInnocuousThread java.security.AccessControlException:
access denied (java.lang.RuntimePermission setContextClassLoader)
at java.security.AccessControlContext.checkPermission(Unknown Source)
at java.security.AccessController.checkPermission(Unknown Source)
at java.lang.SecurityManager.checkPermission(Unknown Source)
at sun.plugin2.applet.AWTAppletSecurityManager.checkPermission(Unknown
Source)
at java.lang.Thread.setContextClassLoader(Unknown Source)
at
org.apache.tomcat.websocket.AsyncChannelGroupUtil$AsyncIOThreadFactory.newThread(AsyncChannelGroupUtil.java:112)
at java.util.concurrent.ThreadPoolExecutor$Worker.init(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.addWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.execute(Unknown Source)
at
org.apache.tomcat.util.threads.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:161)
at
org.apache.tomcat.util.threads.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:141)
at sun.nio.ch.AsynchronousChannelGroupImpl.executeOnPooledThread(Unknown
Source)
at sun.nio.ch.Invoker.invokeIndirectly(Unknown Source)
at sun.nio.ch.Invoker.invoke(Unknown Source)
at sun.nio.ch.Invoker.invoke(Unknown Source)
at
sun.nio.ch.WindowsAsynchronousSocketChannelImpl$ReadTask.completed(Unknown
Source)
at sun.nio.ch.Iocp$EventHandlerTask.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
at sun.misc.InnocuousThread.run(Unknown Source)

The problem is actually in the JVM which installs a null protection domain
which fails every access checked operation.  Apparantly Oracle won't fix this,
according to https://issues.apache.org/jira/browse/SSHD-332, but there is a
workaround which is fairly easy.  It is modelled after the fix to the SSHD one
found in the link above.

Index:
/d/sd0h/h/niklas/java/workspace-1/Tomcat8/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
===
---
/d/sd0h/h/niklas/java/workspace-1/Tomcat8/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
   (revision 1630809)
+++
/d/sd0h/h/niklas/java/workspace-1/Tomcat8/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
   (working copy)
@@ -18,6 +18,8 @@

 import java.io.IOException;
 import java.nio.channels.AsynchronousChannelGroup;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.SynchronousQueue;
 import java.util.concurrent.ThreadFactory;
@@ -106,12 +108,16 @@
 private AtomicInteger count = new AtomicInteger(0);

 @Override
-public Thread newThread(Runnable r) {
-Thread t = new Thread(r);
-t.setName(WebSocketClient-AsyncIO- + count.incrementAndGet());
-t.setContextClassLoader(this.getClass().getClassLoader());
-t.setDaemon(true);
-return t;
+public Thread newThread(final Runnable r) {
+return (Thread)AccessController.doPrivileged(new
PrivilegedActionObject() {
+public Object run() {
+Thread t = new Thread(r);
+t.setName(WebSocketClient-AsyncIO- +
count.incrementAndGet());
+t.setContextClassLoader(this.getClass().getClassLoader());
+t.setDaemon(true);
+return t;
+}
+});
 }
 }
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-10-14 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 29 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20141014.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/comm
 
ons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20141014.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20141014.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20141014.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-19.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar

setproxy:

downloadzip:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 5.9-SNAPSHOT on 2913 files
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java:213:
 Line matches the illegal pattern '\s+$'.
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/cluster-manager.xml:244:
 Line matches the illegal pattern '\s+$'.

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:542: Got 2 errors and 0 
warnings.

Total time: 29 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20141014120117, vmgump.apache.org:vmgump:20141014120117
Gump E-mail Identifier (unique within run) #1.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631771 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2014-10-14 Thread fschumacher
Author: fschumacher
Date: Tue Oct 14 14:28:03 2014
New Revision: 1631771

URL: http://svn.apache.org/r1631771
Log:
Merged revision 1631730 from tomcat/trunk:
Avoid possible integer overflows reported by Coverity Scan

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1631730

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1631771r1=1631770r2=1631771view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
Tue Oct 14 14:28:03 2014
@@ -847,7 +847,7 @@ public class DeltaManager extends Cluste
 //
 }
 reqNow = System.currentTimeMillis();
-isTimeout = ((reqNow - reqStart)  (1000 * 
getStateTransferTimeout()));
+isTimeout = ((reqNow - reqStart)  (1000L * 
getStateTransferTimeout()));
 } while ((!getStateTransfered())  (!isTimeout)  
(!isNoContextManagerReceived()));
 } else {
 if(getStateTransferTimeout() == -1) {
@@ -1025,7 +1025,7 @@ public class DeltaManager extends Cluste
 if (!expires  (msg == null)) {
 long replDelta = System.currentTimeMillis() - 
session.getLastTimeReplicated();
 if (session.getMaxInactiveInterval() =0  
-replDelta  (session.getMaxInactiveInterval() * 1000)) 
{
+replDelta  (session.getMaxInactiveInterval() * 
1000L)) {
 counterSend_EVT_SESSION_ACCESSED++;
 msg = new SessionMessageImpl(getName(),
  
SessionMessage.EVT_SESSION_ACCESSED, 

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1631771r1=1631770r2=1631771view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Oct 14 14:28:03 2014
@@ -69,6 +69,13 @@
   /fix
 /changelog
   /subsection
+  subsection name=Cluster
+changelog
+  fix
+Avoid possible integer overflows reported by Coverity Scan. 
(fschumacher)
+  /fix
+/changelog
+  /subsection
   subsection name=WebSocket
 changelog
   fix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631798 - in /tomcat/trunk/java/org/apache/catalina: AsyncDispatcher.java Authenticator.java Cluster.java Contained.java

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 15:42:24 2014
New Revision: 1631798

URL: http://svn.apache.org/r1631798
Log:
Start the long process of fixing the Java 8 Javadoc warnings for the non-API 
packages.

Modified:
tomcat/trunk/java/org/apache/catalina/AsyncDispatcher.java
tomcat/trunk/java/org/apache/catalina/Authenticator.java
tomcat/trunk/java/org/apache/catalina/Cluster.java
tomcat/trunk/java/org/apache/catalina/Contained.java

Modified: tomcat/trunk/java/org/apache/catalina/AsyncDispatcher.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/AsyncDispatcher.java?rev=1631798r1=1631797r2=1631798view=diff
==
--- tomcat/trunk/java/org/apache/catalina/AsyncDispatcher.java (original)
+++ tomcat/trunk/java/org/apache/catalina/AsyncDispatcher.java Tue Oct 14 
15:42:24 2014
@@ -28,6 +28,11 @@ public interface AsyncDispatcher {
  * Perform an asynchronous dispatch. The method does not check if the
  * request is in an appropriate state for this; it is the caller's
  * responsibility to check this.
+ * @param request  The request object to pass to the dispatch target
+ * @param response The response object to pass to the dispatch target
+ * @throws ServletException if thrown by the dispatch target
+ * @throws IOException  if an I/O error occurs while processing the
+ *  dispatch
  */
 public void dispatch(ServletRequest request, ServletResponse response)
 throws ServletException, IOException;

Modified: tomcat/trunk/java/org/apache/catalina/Authenticator.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Authenticator.java?rev=1631798r1=1631797r2=1631798view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Authenticator.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Authenticator.java Tue Oct 14 
15:42:24 2014
@@ -35,13 +35,16 @@ public interface Authenticator {
 /**
  * Authenticate the user making this request, based on the login
  * configuration of the {@link Context} with which this Authenticator is
- * associated.  Return codetrue/code if any specified constraint has
- * been satisfied, or codefalse/code if we have created a response
- * challenge already.
+ * associated.
  *
  * @param request Request we are processing
  * @param response Response we are populating
  *
+ * @return codetrue/code if any specified constraints have been
+ * satisfied, or codefalse/code if one more constraints were 
not
+ * satisfied (in which case an authentication challenge will have
+ * been written to the response).
+ *
  * @exception IOException if an input/output error occurs
  */
 public boolean authenticate(Request request, HttpServletResponse response)

Modified: tomcat/trunk/java/org/apache/catalina/Cluster.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Cluster.java?rev=1631798r1=1631797r2=1631798view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Cluster.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Cluster.java Tue Oct 14 15:42:24 2014
@@ -72,6 +72,8 @@ public interface Cluster {
  *
  * @param name Name (key) of the application with which the manager is
  * associated
+ *
+ * @return The newly created Manager instance
  */
 public Manager createManager(String name);
 

Modified: tomcat/trunk/java/org/apache/catalina/Contained.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Contained.java?rev=1631798r1=1631797r2=1631798view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Contained.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Contained.java Tue Oct 14 15:42:24 
2014
@@ -14,11 +14,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
 package org.apache.catalina;
 
-
 /**
  * pDecoupling interface which specifies that an implementing class is
  * associated with at most one strongContainer/strong instance./p
@@ -28,15 +25,13 @@ package org.apache.catalina;
  */
 public interface Contained {
 
-
-//-- Properties
-
-
 /**
- * Return the codeContainer/code with which this instance is associated
- * (if any); otherwise return codenull/code.
+ * Get the {@link Container} with which this instance is associated.
+ *
+ * @return The Container with which this instance is associated or
+ * codenull/code if not associated with a Container
  */
-public Container getContainer();
+Container 

svn commit: r1631817 - in /tomcat/trunk: java/org/apache/tomcat/websocket/WsWebSocketContainer.java webapps/docs/changelog.xml

2014-10-14 Thread remm
Author: remm
Date: Tue Oct 14 17:04:45 2014
New Revision: 1631817

URL: http://svn.apache.org/r1631817
Log:
Fix client subprotocol handling (pass protocol names from the annotation).

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java?rev=1631817r1=1631816r2=1631817view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Tue 
Oct 14 17:04:45 2014
@@ -159,6 +159,7 @@ public class WsWebSocketContainer
 ClientEndpointConfig config = builder.
 decoders(Arrays.asList(annotation.decoders())).
 encoders(Arrays.asList(annotation.encoders())).
+
preferredSubprotocols(Arrays.asList(annotation.subprotocols())).
 build();
 return connectToServer(ep, config, path);
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1631817r1=1631816r2=1631817view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Oct 14 17:04:45 2014
@@ -175,6 +175,9 @@
 Extend support for the codepermessage-deflate/code extension to the
 client implementation. (markt)
   /add
+  fix
+Fix client subprotocol handling. (remm)
+  /fix
 /changelog
   /subsection
   subsection name=Web applications



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631818 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

2014-10-14 Thread remm
Author: remm
Date: Tue Oct 14 17:05:08 2014
New Revision: 1631818

URL: http://svn.apache.org/r1631818
Log:
Use constant strings for header names.

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java?rev=1631818r1=1631817r2=1631818view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java Tue 
Oct 14 17:05:08 2014
@@ -180,10 +180,10 @@ public class UpgradeUtil {
 getWebSocketAccept(key));
 if (subProtocol != null  subProtocol.length()  0) {
 // RFC6455 4.2.2 explicitly states  is not valid here
-resp.setHeader(Sec-WebSocket-Protocol, subProtocol);
+resp.setHeader(Constants.WS_PROTOCOL_HEADER_NAME, subProtocol);
 }
 if (!transformations.isEmpty()) {
-resp.setHeader(Sec-WebSocket-Extensions, 
responseHeaderExtensions.toString());
+resp.setHeader(Constants.WS_EXTENSIONS_HEADER_NAME, 
responseHeaderExtensions.toString());
 }
 
 WsHandshakeRequest wsRequest = new WsHandshakeRequest(req);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot exception in ASF Buildbot on tomcat-trunk

2014-10-14 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/546

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1631818
Blamelist: markt,remm

BUILD FAILED: exception upload_2

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631839 - /tomcat/trunk/webapps/docs/web-socket-howto.xml

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:03:15 2014
New Revision: 1631839

URL: http://svn.apache.org/r1631839
Log:
Update WebSocket version

Modified:
tomcat/trunk/webapps/docs/web-socket-howto.xml

Modified: tomcat/trunk/webapps/docs/web-socket-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/web-socket-howto.xml?rev=1631839r1=1631838r2=1631839view=diff
==
--- tomcat/trunk/webapps/docs/web-socket-howto.xml (original)
+++ tomcat/trunk/webapps/docs/web-socket-howto.xml Tue Oct 14 19:03:15 2014
@@ -38,7 +38,7 @@
 /section
 
 section name=Application development
-pTomcat implements the Java WebSocket 1.0 API defined by a
+pTomcat implements the Java WebSocket 1.1 API defined by a
href=http://www.jcp.org/en/jsr/detail?id=356;JSR-356/a./p
 
 pThere are several example applications that demonstrate how the WebSocket 
API



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631842 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/web-socket-howto.xml

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:13:12 2014
New Revision: 1631842

URL: http://svn.apache.org/r1631842
Log:
Update WebSocket version

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1631839

Modified: tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml?rev=1631842r1=1631841r2=1631842view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml Tue Oct 14 19:13:12 
2014
@@ -38,7 +38,7 @@
 /section
 
 section name=Application development
-pTomcat implements the Java WebSocket 1.0 API defined by a
+pTomcat implements the Java WebSocket 1.1 API defined by a
href=http://www.jcp.org/en/jsr/detail?id=356;JSR-356/a./p
 
 pThere are several example applications that demonstrate how the WebSocket 
API



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631843 - in /tomcat/sandbox/trunk-maven-layout: pom.xml tomcat-webapps/ROOT/pom.xml tomcat-webapps/docs/pom.xml

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:16:14 2014
New Revision: 1631843

URL: http://svn.apache.org/r1631843
Log:
Apply latest patch from Pierre Viret

Modified:
tomcat/sandbox/trunk-maven-layout/pom.xml
tomcat/sandbox/trunk-maven-layout/tomcat-webapps/ROOT/pom.xml
tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml

Modified: tomcat/sandbox/trunk-maven-layout/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/trunk-maven-layout/pom.xml?rev=1631843r1=1631842r2=1631843view=diff
==
--- tomcat/sandbox/trunk-maven-layout/pom.xml (original)
+++ tomcat/sandbox/trunk-maven-layout/pom.xml Tue Oct 14 19:16:14 2014
@@ -393,7 +393,7 @@
 !-- define properties for the resource filter --
 version.major8/version.major
 version.minor0/version.minor
-version.build13/version.build
+version.build15/version.build
 version.patch0/version.patch
 version.suffix-SNAPSHOT/version.suffix
 
version${version.major}.${version.minor}.${version.build}${version.suffix}/version

Modified: tomcat/sandbox/trunk-maven-layout/tomcat-webapps/ROOT/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/trunk-maven-layout/tomcat-webapps/ROOT/pom.xml?rev=1631843r1=1631842r2=1631843view=diff
==
--- tomcat/sandbox/trunk-maven-layout/tomcat-webapps/ROOT/pom.xml (original)
+++ tomcat/sandbox/trunk-maven-layout/tomcat-webapps/ROOT/pom.xml Tue Oct 14 
19:16:14 2014
@@ -53,6 +53,24 @@
 /executions
 /plugin   
 plugin
+artifactIdmaven-antrun-plugin/artifactId
+executions
+execution
+idrename-RELEASE-NOTES/id
+phaseprocess-resources/phase
+goals
+goalrun/goal
+/goals
+configuration
+target
+move 
file=${project.build.directory}/generated-resources/RELEASE-NOTES 
+  
tofile=${project.build.directory}/generated-resources/RELEASE-NOTES.txt /
+/target
+/configuration
+/execution
+/executions
+/plugin
+plugin
 artifactIdmaven-war-plugin/artifactId
 configuration
 webResources

Modified: tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml?rev=1631843r1=1631842r2=1631843view=diff
==
--- tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml (original)
+++ tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml Tue Oct 14 
19:16:14 2014
@@ -29,8 +29,47 @@
 packagingwar/packaging
 
 build
+resources
+resource
+directorysrc/main/webapp/directory
+targetPath${webapp.generated.resources}/targetPath
+includes
+includeimages/**/include
+includeWEB-INF/**/include
+includeappdev/*.txt/include
+includeappdev/sample/**/include
+includearchitecture/**/include
+include**/*.html/include
+/includes
+excludes
+excludearchitecture/*.xml/exclude
+/excludes
+/resource
+/resources
 plugins
 plugin
+artifactIdmaven-dependency-plugin/artifactId
+executions
+execution
+idcopy-global-resources/id
+phasegenerate-sources/phase
+goals
+goalunpack/goal
+/goals
+configuration
+artifactItems
+artifactItem
+groupIdorg.apache.tomcat/groupId
+artifactIdglobal-resources/artifactId
+
includesRELEASE-NOTES,RUNNING.txt,BUILDING.txt/includes  
+/artifactItem
+/artifactItems
+
outputDirectory${webapp.generated.resources}/outputDirectory
+/configuration
+/execution
+/executions
+/plugin 
+plugin
 groupIdorg.codehaus.mojo/groupId
 artifactIdxml-maven-plugin/artifactId
 executions

svn commit: r1631845 - in /tomcat/trunk/java/org/apache/catalina/webresources: JarResourceSet.java JarWarResourceSet.java TomcatURLStreamHandlerFactory.java

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:21:04 2014
New Revision: 1631845

URL: http://svn.apache.org/r1631845
Log:
Java 8 Javadoc issues for o.a.c.webresources package

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/JarResourceSet.java
tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java

tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java

Modified: tomcat/trunk/java/org/apache/catalina/webresources/JarResourceSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/JarResourceSet.java?rev=1631845r1=1631844r2=1631845view=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/JarResourceSet.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/JarResourceSet.java Tue 
Oct 14 19:21:04 2014
@@ -55,6 +55,9 @@ public class JarResourceSet extends Abst
  *  org.apache.catalina.WebResourceSet} where
  *  resources will be served from. E.g. for a
  *  resource JAR, this would be 
META-INF/resources
+ *
+ * @throws IllegalArgumentException if the webAppMount or internalPath is
+ * not valid (valid paths must start with '/')
  */
 public JarResourceSet(WebResourceRoot root, String webAppMount, String 
base,
 String internalPath) throws IllegalArgumentException {

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java?rev=1631845r1=1631844r2=1631845view=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java 
Tue Oct 14 19:21:04 2014
@@ -56,6 +56,9 @@ public class JarWarResourceSet extends A
  *  org.apache.catalina.WebResourceSet} where
  *  resources will be served from. E.g. for a
  *  resource JAR, this would be 
META-INF/resources
+ *
+ * @throws IllegalArgumentException if the webAppMount or internalPath is
+ * not valid (valid paths must start with '/')
  */
 public JarWarResourceSet(WebResourceRoot root, String webAppMount,
 String base, String archivePath, String internalPath)

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java?rev=1631845r1=1631844r2=1631845view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java
 Tue Oct 14 19:21:04 2014
@@ -34,6 +34,8 @@ public class TomcatURLStreamHandlerFacto
  * Obtain a reference to the singleton instance. It is recommended that
  * callers check the value of {@link #isRegistered()} before using the
  * returned instance.
+ *
+ * @return A reference to the singleton instance
  */
 public static TomcatURLStreamHandlerFactory getInstance() {
 getInstanceInternal(true);
@@ -93,6 +95,8 @@ public class TomcatURLStreamHandlerFacto
  * Release references to any user provided factories that have been loaded
  * using the provided class loader. Called during web application stop to
  * prevent memory leaks.
+ *
+ * @param classLoader The class loader to release
  */
 public static void release(ClassLoader classLoader) {
 IteratorURLStreamHandlerFactory iter = 
instance.userFactories.iterator();
@@ -130,6 +134,9 @@ public class TomcatURLStreamHandlerFacto
  * {@link URL#setURLStreamHandlerFactory(URLStreamHandlerFactory)} and
  * Tomcat needs to register a handler, provide a mechanism to allow
  * applications to register their own handlers.
+ *
+ * @param factory The user provided factory to add to the factories Tomcat
+ *has alredy registered
  */
 public void addUserFactory(URLStreamHandlerFactory factory) {
 userFactories.add(factory);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57091] Websockets cannot be used in Windows applet plugin environments based on Oracle Java7

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57091

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mark Thomas ma...@apache.org ---
Does this still work if you narrow the doPrivileged() block to just the
setContextClassLoader() call? If so provide an updated patch and I'll apply it.
If not, why not?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 49939] Expose a method via JMX which empties the webapp file cache

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49939

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mark Thomas ma...@apache.org ---
This has been fixed in 8.0.x for 8.0.15 omwards. I do not intend to back-port
the feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56397] Establish parallel Maven-based build process

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397

--- Comment #37 from Mark Thomas ma...@apache.org ---
Patch applied. I still don't see the scripts or the conf directory being
created.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631851 - in /tomcat/trunk: java/org/apache/catalina/webresources/mbeans-descriptors.xml webapps/docs/changelog.xml

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:38:42 2014
New Revision: 1631851

URL: http://svn.apache.org/r1631851
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49939
Expose the method that clears the static resource cache for a web application 
via JMX

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/mbeans-descriptors.xml
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/mbeans-descriptors.xml?rev=1631851r1=1631850r2=1631851view=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/mbeans-descriptors.xml 
Tue Oct 14 19:38:42 2014
@@ -87,6 +87,12 @@
  type=long
 writeable=true/
 
+operation name=clear
+description=Clears all cached content from the cache.
+ impact=ACTION
+ returnType=void
+/operation
+
   /mbean
 
 /mbeans-descriptors

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1631851r1=1631850r2=1631851view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Oct 14 19:38:42 2014
@@ -63,6 +63,10 @@
 optionally include (enabled by default) the values of key environment
 variables. (markt)
   /add
+  add
+bug49939/bug: Expose the method that clears the static resource
+cache for a web application via JMX. (markt)
+  /add
   fix
 bug55951/bug: Allow cookies to use UTF-8 encoded values in HTTP
 headers. This requires the use of the RFC6265



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631852 - /tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:39:27 2014
New Revision: 1631852

URL: http://svn.apache.org/r1631852
Log:
Whitespace police

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java?rev=1631852r1=1631851r2=1631852view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/ClusterManagerBase.java 
Tue Oct 14 19:39:27 2014
@@ -210,7 +210,6 @@ public abstract class ClusterManagerBase
  // Ignore
 }
 }
-   
 }
 
 /**



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1631858 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Transformation.java WsSession.java server/UpgradeUtil.java server/WsFrameServer.java server/WsServerContainer.java

2014-10-14 Thread markt
Author: markt
Date: Tue Oct 14 19:54:42 2014
New Revision: 1631858

URL: http://svn.apache.org/r1631858
Log:
Java 8 Javadoc issues for o.a.t.websocket package

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/Transformation.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFrameServer.java
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Transformation.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/Transformation.java?rev=1631858r1=1631857r2=1631858view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/Transformation.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/Transformation.java Tue Oct 
14 19:54:42 2014
@@ -30,6 +30,7 @@ public interface Transformation {
 
 /**
  * Sets the next transformation in the pipeline.
+ * @param t The next transformation
  */
 void setNext(Transformation t);
 
@@ -52,6 +53,9 @@ public interface Transformation {
 /**
  * Obtain the extension that describes the information to be returned to 
the
  * client.
+ *
+ * @return The extension information that describes the parameters that 
have
+ * been agreed for this transformation
  */
 Extension getExtensionResponse();
 
@@ -63,6 +67,11 @@ public interface Transformation {
  * @param rsv   The reserved bits for the frame currently being
  *  processed
  * @param dest  The buffer in which the data is to be written
+ *
+ * @return The result of trying to read more data from the transform
+ *
+ * @throws IOException If an I/O error occurs while reading data from the
+ * transform
  */
 TransformationResult getMoreData(byte opCode, boolean fin, int rsv, 
ByteBuffer dest) throws IOException;
 

Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java?rev=1631858r1=1631857r2=1631858view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Tue Oct 14 
19:54:42 2014
@@ -106,10 +106,34 @@ public class WsSession implements Sessio
  * at the time this constructor is called will be used when calling
  * {@link Endpoint#onClose(Session, CloseReason)}.
  *
- * @param localEndpoint
- * @param wsRemoteEndpoint
- * @param negotiatedExtensions
- * @throws DeploymentException
+ * @param localEndpointThe end point managed by this code
+ * @param wsRemoteEndpoint The other / remote endpoint
+ * @param wsWebSocketContainer The container that created this session
+ * @param requestUri   The URI used to connect to this endpoint or
+ * codenull/code is this is a client 
session
+ * @param requestParameterMap  The parameters associated with the request
+ * that initiated this session or
+ * codenull/code if this is a client 
session
+ * @param queryString  The query string associated with the request
+ * that initiated this session or
+ * codenull/code if this is a client 
session
+ * @param userPrincipalThe principal associated with the request
+ * that initiated this session or
+ * codenull/code if this is a client 
session
+ * @param httpSessionIdThe HTTP session ID associated with the
+ * request that initiated this session or
+ * codenull/code if this is a client 
session
+ * @param negotiatedExtensions The agreed extensions to use for this 
session
+ * @param subProtocol  The agreed subprotocol to use for this
+ * session
+ * @param pathParameters   The path parameters associated with the
+ * request that initiated this session or
+ * codenull/code if this is a client 
session
+ * @param secure   Was this session initiated over a secure
+ * connection?
+ * @param endpointConfig   The configuration information for the
+ * endpoint
+ * @throws DeploymentException if an invalid encode is specified
  */
 public WsSession(Endpoint localEndpoint,

buildbot success in ASF Buildbot on tomcat-trunk

2014-10-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/547

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1631839
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57091] Websockets cannot be used in Windows applet plugin environments based on Oracle Java7

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57091

--- Comment #2 from Niklas Hallqvist niklas+apa...@appli.se ---
(In reply to Mark Thomas from comment #1)
 Does this still work if you narrow the doPrivileged() block to just the
 setContextClassLoader() call? If so provide an updated patch and I'll apply
 it. If not, why not?

Actually I haven't tested that, I may do that toorrow localtime (UTC+2).
But... I know for a fact that the AccessController failed other operations
before that, inside the Thread constructor, but the exceptions were masked by
inner try-clauses.
In a normal AccessController setup they wouldn't have failed, which is why I
covered the whole thing in the doPrivileged.

As the problem is really that the method is called with the wrong
AccessController setup established for all of the duraton, I thought it most
safe to actually cover all of the code, even if not strictly required at this
moment.

But as I said, I may do the tests tomorrow.

I have a testcase btw, but in order to run it you need to sign the code and
trust the ceritifcate in the browser which will run the test.  If you want it I
can make a package.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56425] Unable to find unambiguous method in class String

2014-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56425

lafleche lafle...@amazon.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
Version|7.0.53  |7.0.55
 Resolution|FIXED   |---

--- Comment #3 from lafleche lafle...@amazon.com ---
Can I see the commit where this bug was fixed?

I ran into this bug when upgrading from 7.0.50 to 7.0.55.

I was looking at the latest code for BeanELResolver.java and Util.java.

At a glance, it looks like:

getWrapper() does a bunch of fancy things including type coercion
getMethod() only looks for a perfect match.

I don't see BeanELResolver calling getWrapper() anywhere, only getMethod().

This matches the behaviour I'm seeing, where I get MethodNotFoundExceptions
forr mappings like:

doFoo(Integer bar) - doFoo(int bar)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-10-14 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 25 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20141015.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/comm
 
ons-exec-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20141015.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20141015.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20141015.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-19.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar

setproxy:

downloadzip:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 5.9-SNAPSHOT on 2913 files
[checkstyle] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/cluster-manager.xml:244:
 Line matches the illegal pattern '\s+$'.

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:542: Got 1 errors and 0 
warnings.

Total time: 25 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20141015000147, vmgump.apache.org:vmgump:20141015000147
Gump E-mail Identifier (unique within run) #6.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-10-14 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 6 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 33 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141015-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar
 -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20141015/lib 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20141015.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141015-native-src.tar.gz
 -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false
  
-Dtest.openssl.path=/srv/gump/public/workspace/openssl/dest-20141015/bin/openssl
 -Dexecute.test.apr=true -Dexecute.test.bio=false -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar
 
-Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/build/hamcrest-all-20141015.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja