svn commit: r1651043 - in /tomcat/trunk: java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/upgrade/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/websocket/server/ test/org/apache/ca

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 08:59:42 2015 New Revision: 1651043 URL: http://svn.apache.org/r1651043 Log: A further round of refactoring of writes. Primary change is the use of socketWriteBuffer by default for all writes Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

svn commit: r1651044 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 08:59:48 2015 New Revision: 1651044 URL: http://svn.apache.org/r1651044 Log: Checkpoint - Fix NIO2 deadlock Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL:

svn commit: r1651045 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 08:59:53 2015 New Revision: 1651045 URL: http://svn.apache.org/r1651045 Log: Complete a TODO - Ensure a blocking call to doWrite() always empties the buffer or times out - Remove flip parameter from doWrite() as it is no longer required Modified:

svn commit: r1651046 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 08:59:59 2015 New Revision: 1651046 URL: http://svn.apache.org/r1651046 Log: No need to return value from doWrite so remove it allowing slightly simpler code. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Rémy Maucherat
2015-01-09 19:26 GMT+01:00 Mark Thomas ma...@apache.org: The proposed 8.0.17 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.17 Rémy

Re: Performance change

2015-01-12 Thread Rémy Maucherat
2015-01-11 20:40 GMT+01:00 Mark Thomas ma...@apache.org: Just for info, I have found that none of the non-blocking IO (including that used by the WebSocket impl) was using the socket write buffer. I'm making good progress refactoring things so everything is buffered by default but it has

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Felix Schumacher
Am 09.01.2015 um 19:26 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.17 release is now available for voting. The changes since 8.0.16 are: - Fix a RequestListener regression - Fix a bug in NIO2 with sending 100-Continue responses The main changes since 8.0.15 are: - Correct a regression

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Konstantin Kolinko
2015-01-09 21:26 GMT+03:00 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.17 release is now available for voting. The proposed 8.0.17 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.0.17 Unit tests pass for all 4 connectors with 32-bit JDK 7u72 on

svn commit: r1651116 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java webapps/docs/changelog.xml

2015-01-12 Thread fschumacher
Author: fschumacher Date: Mon Jan 12 15:22:16 2015 New Revision: 1651116 URL: http://svn.apache.org/r1651116 Log: Enable custom context class when using embedded tomcat Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

svn commit: r1651062 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Protocol.java Http11AprProtocol.java Http11Nio2Protocol.java Http11NioProtocol.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 11:16:13 2015 New Revision: 1651062 URL: http://svn.apache.org/r1651062 Log: Pull up getter/setter for useSendfile Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java

svn commit: r1651063 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java Http11Nio2Processor.java Http11Nio2Protocol.java Http11NioProcessor.java Http11Nio

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 11:16:19 2015 New Revision: 1651063 URL: http://svn.apache.org/r1651063 Log: Remove a cast. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java

Re: Currently ignored WebSocket tests

2015-01-12 Thread Mark Thomas
On 08/01/2015 16:44, Rémy Maucherat wrote: 2015-01-08 16:56 GMT+01:00 Mark Thomas ma...@apache.org: There are a couple of WebSocket tests that are currently commented out in org.apache.tomcat.websocket.pojo.TestEncodingDecoding I've been looking into why the currently fail. Failing test

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Mark Thomas
On 09/01/2015 18:26, Mark Thomas wrote: The proposed Apache Tomcat 8.0.17 release is now available for voting. The changes since 8.0.16 are: - Fix a RequestListener regression - Fix a bug in NIO2 with sending 100-Continue responses The main changes since 8.0.15 are: - Correct a

Re: JDK 9 images are now modular with JDK 9 Early Access build 41

2015-01-12 Thread Rory O'Donnell
Hi Mark, Have you been able to test Tomcat with JDK 9 modular images, would appreciate any feedback you might have ? Rgds,Rory On 09/12/2014 08:36, Rory O'Donnell wrote: Hi Mark/Mladen, The initial changesets for JEP 220: Modular Run-Time Images [1] are available with JDK 9 early-access

[Bug 57282] request process UML diagram seems outdated

2015-01-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #13 from Mark Thomas ma...@apache.org --- Broadly it looks OK but the detail around the Pipelines isn't right. Calls to getFirst() are missing and some method names shown don't exist. Also methods are being called on the wrong

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-01-12 Thread Bill Barker
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150112-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

[GitHub] tomcat pull request: now json is fashion

2015-01-12 Thread ahu0605
GitHub user ahu0605 opened a pull request: https://github.com/apache/tomcat/pull/15 now json is fashion The class should support data json You can merge this pull request into a Git repository by running: $ git pull https://github.com/ahu0605/tomcat patch-1 Alternatively you

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Martin Grigorov
On Fri, Jan 9, 2015 at 7:26 PM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 8.0.17 release is now available for voting. The changes since 8.0.16 are: - Fix a RequestListener regression - Fix a bug in NIO2 with sending 100-Continue responses The main changes since 8.0.15

svn commit: r1651120 - in /tomcat/trunk: java/org/apache/catalina/ha/context/ReplicatedContext.java test/org/apache/catalina/ha/ test/org/apache/catalina/ha/context/ test/org/apache/catalina/ha/contex

2015-01-12 Thread fschumacher
Author: fschumacher Date: Mon Jan 12 15:29:47 2015 New Revision: 1651120 URL: http://svn.apache.org/r1651120 Log: Don't add orderedLibs attribute if it is null. ReplicatedContext will fail otherwise. Avoid NPE on shutdown of ReplicatedContext. Added:

[GitHub] tomcat pull request: now json is fashion

2015-01-12 Thread markt-asf
Github user markt-asf commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69624704 This pull request is declined. Even ignoring the poor quality of this pull request, supporting JSON formatted data is an application concern, not a container concern.

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Christopher Schultz
Mark, On 1/9/15 1:26 PM, Mark Thomas wrote: The proposed Apache Tomcat 8.0.17 release is now available for voting. The changes since 8.0.16 are: - Fix a RequestListener regression - Fix a bug in NIO2 with sending 100-Continue responses The main changes since 8.0.15 are: - Correct a

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Jeanfrancois Arcand
On 2015-01-09 1:26 PM, Mark Thomas wrote: The proposed 8.0.17 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.17 Tested WebSocket + AsyncContext -- Jeanfrancois - To unsubscribe, e-mail:

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-01-12 Thread Bill Barker
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150112-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

svn commit: r1651219 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/UpgradeServletOutputStream.java tomcat/websocket/server/WsRemoteEndpointImplServer.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 22:35:19 2015 New Revision: 1651219 URL: http://svn.apache.org/r1651219 Log: Fix some flushing issues identified when running the Autobhan WebSocket test suite Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServletOutputStream.java

svn commit: r1651235 - /tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 23:51:27 2015 New Revision: 1651235 URL: http://svn.apache.org/r1651235 Log: Remove over-ridden method that has an identical implementation in the super class. Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java Modified:

[Bug 57437] New: got error while start tomcat server in windows

2015-01-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57437 Bug ID: 57437 Summary: got error while start tomcat server in windows Product: Tomcat 7 Version: unspecified Hardware: PC Status: NEW Severity: blocker

[GitHub] tomcat pull request: now json is fashion

2015-01-12 Thread ahu0605
Github user ahu0605 commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69689061 but when i push content type - json,there is some bug , 4 ex :data is json {\id\:\asd\},the value will be a Map key, request.getPamaterMap () the key is {id:asd},

svn commit: r1651232 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java http11/Http11AprProtocol.java http11/Http11Nio2Protocol.java http11/Http11NioProtocol.java

2015-01-12 Thread markt
Author: markt Date: Mon Jan 12 23:38:24 2015 New Revision: 1651232 URL: http://svn.apache.org/r1651232 Log: Better parameter name Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2015-01-12 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-01-12 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration.

svn commit: r1651280 - in /tomcat/trunk/test/org/apache/catalina: ha/context/TestReplicatedContext.java startup/TestTomcat.java

2015-01-12 Thread kkolinko
Author: kkolinko Date: Tue Jan 13 05:41:52 2015 New Revision: 1651280 URL: http://svn.apache.org/r1651280 Log: Checkstyle: 1) Missing Apache License header 2) Imports order Modified: tomcat/trunk/test/org/apache/catalina/ha/context/TestReplicatedContext.java

svn commit: r1651279 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ java/org/apache/catalina/ha/authenticator/ java/org/apache/catalina/ha/session/ test/org/apache/catalina/ha/context/

2015-01-12 Thread kkolinko
Author: kkolinko Date: Tue Jan 13 05:37:55 2015 New Revision: 1651279 URL: http://svn.apache.org/r1651279 Log: svn:eol-style=native Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnListener.java (props changed)

svn commit: r1651281 - in /tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha: authenticator/ClusterSingleSignOnListener.java session/ReplicatedSessionListener.java

2015-01-12 Thread kkolinko
Author: kkolinko Date: Tue Jan 13 05:45:39 2015 New Revision: 1651281 URL: http://svn.apache.org/r1651281 Log: svn:eol-style=native Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java (props changed)

[GitHub] tomcat pull request: now json is fashion

2015-01-12 Thread martin-g
Github user martin-g commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69703890 When you POST JSON data you should use http://docs.oracle.com/javaee/6/api/javax/servlet/ServletRequest.html#getReader() to consume the body and parse it as you find