The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1357
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58015
--- Comment #2 from Mark Thomas ---
That was fun.
I found a bunch of edge case bugs in the web application class loader in this
area that should all now be fixed in trunk.
It is getting late here so I'll back-port the fixes to earlier version
Author: markt
Date: Tue Jun 9 22:42:29 2015
New Revision: 1684550
URL: http://svn.apache.org/r1684550
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58015
Delegate and filter() should be used consistently everywhere delegation is
possible to ensure consistent behaviour of the class load
Author: markt
Date: Tue Jun 9 22:38:06 2015
New Revision: 1684549
URL: http://svn.apache.org/r1684549
Log:
Fix a bug that prevented filter() form working correctly (it only returned true
for classes in sub-packages of the listed packaged, but not classes located in
the packages themselves)
Mod
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1356
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSc
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1355
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Tue Jun 9 20:51:40 2015
New Revision: 1684529
URL: http://svn.apache.org/r1684529
Log:
Add JASPIC API classes to the classes for which the web application class
loader will always delegate first.
Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBas
Author: markt
Date: Tue Jun 9 20:50:31 2015
New Revision: 1684527
URL: http://svn.apache.org/r1684527
Log:
Add javax.websocket.* to the classes for which the web application class loader
will always delegate first (so the classes provided by Tomcat cannot be
overridden).
Modified:
tomcat/t
Author: markt
Date: Tue Jun 9 20:49:08 2015
New Revision: 1684526
URL: http://svn.apache.org/r1684526
Log:
The validate() method is unnecessary.
Test 0.2 in loadClass(String, boolean) already ensures that Java SE classes can
not be overridden and does so in a way that doesn't require a list of p
Author: markt
Date: Tue Jun 9 20:16:50 2015
New Revision: 1684516
URL: http://svn.apache.org/r1684516
Log:
Fix regression in r1684505
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=58015
--- Comment #1 from Mark Thomas ---
I haven't tested this (yet) but the code to prevent loading of Servlet API
classes from the web app is still present.
jarsToSkip is completely unrelated to this feature.
--
You are receiving this mail beca
https://bz.apache.org/bugzilla/show_bug.cgi?id=58015
Bug ID: 58015
Summary: servlet-api.jar from WAR files not being excluded
Product: Tomcat 8
Version: 8.0.23
Hardware: PC
OS: Linux
Status: NEW
Severity:
Author: markt
Date: Tue Jun 9 19:40:46 2015
New Revision: 1684508
URL: http://svn.apache.org/r1684508
Log:
Check stream IDs do not go backwards
Modified:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_1.java
Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_
Author: markt
Date: Tue Jun 9 19:39:22 2015
New Revision: 1684507
URL: http://svn.apache.org/r1684507
Log:
Need to update the max remote stream when a new one is created
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyot
Author: markt
Date: Tue Jun 9 19:26:08 2015
New Revision: 1684505
URL: http://svn.apache.org/r1684505
Log:
Differentiate between retrieving an existing stream and creating a new one.
Start to add the 5.1.1 tests
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java
tomcat/
Author: markt
Date: Tue Jun 9 19:19:01 2015
New Revision: 1684503
URL: http://svn.apache.org/r1684503
Log:
Correct name (copy/paste error)
Modified:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.j
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1353
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Tue Jun 9 16:58:21 2015
New Revision: 1684476
URL: http://svn.apache.org/r1684476
Log:
Remove unnecessary write. The previous ping triggers the failure and -
depending on the system - the server may drop the connection before part 2 is
written. If that happens it triggers a
https://bz.apache.org/bugzilla/show_bug.cgi?id=56576
Corey Puffalt changed:
What|Removed |Added
CC||cpj...@yeroc.ca
--- Comment #1 from Co
Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110393102
1) I haven't reviewed the build.xml changes since I don't want to start
building this JAR until the API is correct.
2) Patch was incomplete. Applied along with addit
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1350
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedu
Author: markt
Date: Tue Jun 9 14:49:41 2015
New Revision: 1684441
URL: http://svn.apache.org/r1684441
Log:
Fix line lengths and imports
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthC
Author: markt
Date: Tue Jun 9 14:45:24 2015
New Revision: 1684440
URL: http://svn.apache.org/r1684440
Log:
Revert original line lengths patch - it included refactoring that did not pass
review
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java
Modified:
Author: markt
Date: Tue Jun 9 14:41:05 2015
New Revision: 1684439
URL: http://svn.apache.org/r1684439
Log:
Line lengths missed in a previous commit.
Modified:
tomcat/trunk/java/javax/security/auth/message/callback/GroupPrincipalCallback.java
tomcat/trunk/java/javax/security/auth/messag
Author: markt
Date: Tue Jun 9 14:37:53 2015
New Revision: 1684438
URL: http://svn.apache.org/r1684438
Log:
Line lengths
Patch by fjodorver
Modified:
tomcat/trunk/java/javax/security/auth/message/ClientAuth.java
tomcat/trunk/java/javax/security/auth/message/MessagePolicy.java
tomcat/t
Author: markt
Date: Tue Jun 9 14:17:19 2015
New Revision: 1684433
URL: http://svn.apache.org/r1684433
Log:
Remove some additional blank lines
Modified:
tomcat/trunk/java/javax/security/auth/message/callback/CallerPrincipalCallback.java
tomcat/trunk/java/javax/security/auth/message/call
Author: markt
Date: Tue Jun 9 14:15:34 2015
New Revision: 1684431
URL: http://svn.apache.org/r1684431
Log:
Remove @version from JASPIC API
Patch by fjodorver
Modified:
tomcat/trunk/java/javax/security/auth/message/AuthException.java
tomcat/trunk/java/javax/security/auth/message/AuthStatu
Author: markt
Date: Tue Jun 9 13:43:15 2015
New Revision: 1684421
URL: http://svn.apache.org/r1684421
Log:
Enable ignored test now handling for stream errors has been implemented.
More clarifications around sub-states for closed streams (these need some unit
tests)
Modified:
tomcat/trunk/ja
Author: markt
Date: Tue Jun 9 13:35:54 2015
New Revision: 1684417
URL: http://svn.apache.org/r1684417
Log:
Errors on stream zero are always connection errors
Modified:
tomcat/trunk/java/org/apache/coyote/http2/FrameType.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/FrameType.java
Author: markt
Date: Tue Jun 9 13:35:30 2015
New Revision: 1684416
URL: http://svn.apache.org/r1684416
Log:
Fix comment
Modified:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
URL:
http://svn
Author: markt
Date: Tue Jun 9 13:26:54 2015
New Revision: 1684414
URL: http://svn.apache.org/r1684414
Log:
Fix failing tests after merging checks
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHand
Author: markt
Date: Tue Jun 9 13:01:01 2015
New Revision: 1684411
URL: http://svn.apache.org/r1684411
Log:
Merge check methods
Modified:
tomcat/trunk/java/org/apache/coyote/http2/FrameType.java
tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java
tomcat/trunk/java/org/apache/co
https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: markt
Date: Tue Jun 9 11:56:52 2015
New Revision: 1684394
URL: http://svn.apache.org/r1684394
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
Ensure web application class loader is unbound. Includes:
- only bind/unbind if the valve is attached to a Host or Engine
- narrow sc
https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
--- Comment #6 from Remy Maucherat ---
Very good point about the host, thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-
Author: markt
Date: Tue Jun 9 11:42:52 2015
New Revision: 1684385
URL: http://svn.apache.org/r1684385
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
Ensure web application class loader is unbound. Includes:
- only bind/unbind if the valve is attached to a Host or Engine
- narrow sc
Author: markt
Date: Tue Jun 9 11:39:22 2015
New Revision: 1684383
URL: http://svn.apache.org/r1684383
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
Ensure web application class loader is unbound. Includes:
- only bind/unbind if the valve is attached to a Host or Engine
- narrow sc
https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
--- Comment #5 from Mark Thomas ---
At the Host level the context class loaders are set in the StandardHostValve
which is the basic Valve - i.e. always the last one in the chain. Therefore the
clsss loader switching will be required for Hosts a
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010
Mark Thomas changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
2015-06-09 11:53 GMT+02:00 Konstantin Kolinko :
> 2015-06-08 15:37 GMT+03:00 Mark Thomas :
> > All,
> >
> > I'm not particularly happy with the current error handling (based around
> > Http2Exception) and as I work my way through the spec in detail I am
> > coming across cases that are becoming in
https://bz.apache.org/bugzilla/show_bug.cgi?id=58009
--- Comment #3 from Mark Thomas ---
'Not found' results are cached as well. I suspect the application code is
checking that the file exists, discovering that it doesn't (which is cached),
ading the file (outside of the WebResources impl) and th
https://bz.apache.org/bugzilla/show_bug.cgi?id=57966
Mark Thomas changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEEDINFO
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REOPENED
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1347
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSc
Author: markt
Date: Tue Jun 9 09:55:10 2015
New Revision: 1684368
URL: http://svn.apache.org/r1684368
Log:
Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioCha
2015-06-08 15:37 GMT+03:00 Mark Thomas :
> All,
>
> I'm not particularly happy with the current error handling (based around
> Http2Exception) and as I work my way through the spec in detail I am
> coming across cases that are becoming increasingly difficult to handle
> cleanly.
>
> I think I have
Author: markt
Date: Tue Jun 9 09:51:54 2015
New Revision: 1684367
URL: http://svn.apache.org/r1684367
Log:
Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/NioCha
Author: markt
Date: Tue Jun 9 09:48:46 2015
New Revision: 1684366
URL: http://svn.apache.org/r1684366
Log:
Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioChannel.java
Modified: tomcat/trunk/java/org/apache/to
https://bz.apache.org/bugzilla/show_bug.cgi?id=57530
--- Comment #4 from Konstantin Kolinko ---
(In reply to Violeta Georgieva from comment #3)
Interesting.
This fix looks like having a too wide scope for a single failing test, but I am
OK with it.
Setting the system property affects all the t
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
Mark Thomas changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
--- Comment #7 from Mark Thomas ---
The previous fix applied equally to HTTP and HTTPS. I'll do another code
review.
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265
Mark Thomas changed:
What|Removed |Added
CC||carl...@gmail.com
--- Comment #6 from Ma
https://bz.apache.org/bugzilla/show_bug.cgi?id=58011
Mark Thomas changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
On 09/06/2015 09:46, Konstantin Kolinko wrote:
> 2015-06-08 20:57 GMT+03:00 :
>> Author: markt
>> Date: Mon Jun 8 17:57:05 2015
>> New Revision: 1684233
>>
>> URL: http://svn.apache.org/r1684233
>> Log:
>> Rename ErrorCode -> Error
>>
>> Added:
>> tomcat/trunk/java/org/apache/coyote/http2/Err
2015-06-08 20:57 GMT+03:00 :
> Author: markt
> Date: Mon Jun 8 17:57:05 2015
> New Revision: 1684233
>
> URL: http://svn.apache.org/r1684233
> Log:
> Rename ErrorCode -> Error
>
> Added:
> tomcat/trunk/java/org/apache/coyote/http2/Error.java
> - copied, changed from r1683410,
> tomcat/
https://bz.apache.org/bugzilla/show_bug.cgi?id=57530
--- Comment #3 from Violeta Georgieva ---
Hi,
What do you think if we add the code below.
Currently "Expect" header is restricted and because of this it is not added as
request property.
If we set "sun.net.http.allowRestrictedHeaders" to "true
Author: kkolinko
Date: Tue Jun 9 08:35:12 2015
New Revision: 1684353
URL: http://svn.apache.org/r1684353
Log:
Correct typo in a method name
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.ja
57 matches
Mail list logo
