Re: Consider support for the Servlet profile of JSR 196 (JASPIC) in Tomcat 7.0.x
On 10/06/2015 16:43, Arjan Tijms wrote:
Hi,
On Wed, Jun 10, 2015 at 3:28 PM, markt [via Tomcat]
ml-node+s10n5035887...@n6.nabble.com wrote:
I don't really understand what the requirement is here. Can you expand /
point me to the part of the spec?
It's simply that from within a SAM you can forward/include to a Servlet
using a dispatcher, such that the output of that Servlet is inserted in the
response.
Thanks for the clarification. You can do that easily from a Valve in a
couple of lines of code. No need for extra internal plumbing that I can see.
Mark
It's in section 3.8.3.4 of the JASPIC spec:
3.8.3.4
Forwards and Includes by Server Authentication Modules
The message processing runtime must support the acquisition and use of
RequestDispatcher objects by authentication modules within their processing
of validateRequest.
Under the constraints defined by RequestDispatcher, authentication modules
must be able to forward and include using the request and response objects
passed in MessageInfo. In particular, an authentication module must be able
to acquire a RequestDispatcher from the request obtained from MessageInfo,
and uses it to forward the request (and response) to a login form.
Authentication modules should catch and rethrow as an AuthException any
exception thrown by these methods.
A test/example showing this in practice is the following:
https://github.com/javaee-samples/javaee7-samples/tree/master/jaspic/dispatching
Specifically, this code shows both an include and a forward done by a SAM:
public AuthStatus validateRequest(MessageInfo messageInfo, Subject
clientSubject, Subject serviceSubject) throws AuthException {
try {
HttpServletRequest request = (HttpServletRequest)
messageInfo.getRequestMessage();
HttpServletResponse response = (HttpServletResponse)
messageInfo.getResponseMessage();
if (include.equals(request.getParameter(dispatch))) {
request.getRequestDispatcher(/includedServlet)
.include(request, response);
// Do nothing, required protocol when returning SUCCESS
handler.handle(new Callback[] { new
CallerPrincipalCallback(clientSubject, (Principal) null) });
// When using includes, the response stays open and the main
// resource can also write to the response
return SUCCESS;
} else {
request.getRequestDispatcher(/forwardedServlet)
.forward(request, response);
// MUST NOT invoke the resource, so CAN NOT return SUCCESS
here.
return SEND_CONTINUE;
}
} catch (IOException | ServletException |
UnsupportedCallbackException e) {
throw (AuthException) new AuthException().initCause(e);
}
}
Sounds good. Thanks for the tip.
You're welcome ;)
Kind regards,
Arjan Tijms
Cheers,
mark
-
To unsubscribe, e-mail: [hidden email]
http:///user/SendEmail.jtp?type=nodenode=5035887i=0
For additional commands, e-mail: [hidden email]
http:///user/SendEmail.jtp?type=nodenode=5035887i=1
--
If you reply to this email, your message will be added to the discussion
below:
http://tomcat.10.x6.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-Tomcat-7-0-x-tp4993387p5035887.html
To unsubscribe from Consider support for the Servlet profile of JSR 196
(JASPIC) in Tomcat 7.0.x, click here
http://tomcat.10.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_codenode=4993387code=YXJqYW4udGlqbXNAZ21haWwuY29tfDQ5OTMzODd8LTM3MzU5NTg0OA==
.
NAML
http://tomcat.10.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewerid=instant_html%21nabble%3Aemail.namlbase=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespacebreadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
--
View this message in context:
http://tomcat.10.x6.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-Tomcat-7-0-x-tp4993387p5035891.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
JASPIC Implementation pointers
(primarily for Fjodor but feel free to comment as you see fit) Consensus to date is that a Valve will be the best integration point. Given that the implementation will need access to Tomcat's internals, I'd suggest either use the existing org.apache.catalina.authenticator package or create a new org.apache.catalina.jaspic package I can think of a couple of different ways for you to get started. Feel free pick one (or more) of these or choose your own. 1. AuthConfigFactory - Create the Tomcat specific AuthConfigFactoryImpl (just stub out the methods to start with - Fix the various issues with AuthConfigFactory - Replace the stubs with actual implementations and provide any additional supporting code as you go. 2. Authenticator - Create a JaspicAuthenticator class (will need to be a Valve). - To start just have the Valve pass the request/response down the pipeline - Register a new web.xml authentication method JASPIC-BASIC and link it to the new Valve the same way the BasicAuthenticator is linked to the BASIC authenticaton method. - Implement BASIC auth using the JASPIC API, providing any necessary supporting code as you go. - Keep in mind that this Valve is going to have to support any JASPIC authentication module but don't worry too much about getting Valve architecture right first time. You can always refactor things later As always, if you have any questions feel free to ask them on the dev list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot exception in ASF Buildbot on tomcat-trunk
The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1367 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1684910 Blamelist: markt BUILD FAILED: exception upload_2 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1684910 - in /tomcat/trunk: java/org/apache/coyote/http2/ test/org/apache/coyote/http2/
Author: markt
Date: Thu Jun 11 14:51:28 2015
New Revision: 1684910
URL: http://svn.apache.org/r1684910
Log:
Add unit tests for section 5.2
Fix a bug where the end of stream flag was incorrectly set when flow control
was applied to the response body after it had been fully written by the app but
before it had been fully written to the client.
Added:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_2.java (with
props)
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/Stream.java
tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1684910r1=1684909r2=1684910view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Thu Jun
11 14:51:28 2015
@@ -453,7 +453,7 @@ public class Http2UpgradeHandler extends
}
-void writeBody(Stream stream, ByteBuffer data, int len) throws IOException
{
+void writeBody(Stream stream, ByteBuffer data, int len, boolean finished)
throws IOException {
if (log.isDebugEnabled()) {
log.debug(sm.getString(upgradeHandler.writeBody, connectionId,
stream.getIdentifier(),
Integer.toString(data.remaining(;
@@ -462,7 +462,7 @@ public class Http2UpgradeHandler extends
byte[] header = new byte[9];
ByteUtil.setThreeBytes(header, 0, len);
header[3] = FrameType.DATA.getIdByte();
-if (stream.getOutputBuffer().isFinished()) {
+if (finished) {
header[4] = FLAG_END_OF_STREAM;
stream.sentEndOfStream();
if (!stream.isActive()) {
Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Stream.java?rev=1684910r1=1684909r2=1684910view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Stream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Stream.java Thu Jun 11 14:51:28
2015
@@ -275,11 +275,11 @@ public class Stream extends AbstractStre
private final ByteBuffer buffer = ByteBuffer.allocate(8 * 1024);
private volatile long written = 0;
-private volatile boolean finished = false;
+private volatile boolean closed = false;
@Override
public int doWrite(ByteChunk chunk) throws IOException {
-if (finished) {
+if (closed) {
// TODO i18n
throw new IllegalStateException();
}
@@ -293,7 +293,7 @@ public class Stream extends AbstractStre
if (len 0 !buffer.hasRemaining()) {
// Only flush if we have more data to write and the buffer
// is full
-flush();
+flush(true);
}
}
written += offset;
@@ -301,6 +301,10 @@ public class Stream extends AbstractStre
}
public void flush() throws IOException {
+flush(false);
+}
+
+private void flush(boolean writeInProgress) throws IOException {
if (!coyoteResponse.isCommitted()) {
coyoteResponse.sendHeaders();
}
@@ -348,7 +352,8 @@ public class Stream extends AbstractStre
decrementWindowSize(thisWrite);
// Do the write
-handler.writeBody(Stream.this, buffer, thisWrite);
+handler.writeBody(Stream.this, buffer, thisWrite,
+!writeInProgress closed left == thisWrite);
left -= thisWrite;
buffer.position(buffer.position() + thisWrite);
}
@@ -360,12 +365,12 @@ public class Stream extends AbstractStre
return written;
}
-public void finished() {
-finished = true;
+public void close() {
+closed = true;
}
-public boolean isFinished() {
-return finished;
+public boolean isClosed() {
+return closed;
}
/**
@@ -373,7 +378,7 @@ public class Stream extends AbstractStre
* response has no body.
*/
public boolean hasNoBody() {
-return ((written == 0) finished);
+return ((written == 0) closed);
}
}
Modified: tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
URL:
svn commit: r1684943 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
Author: remm
Date: Thu Jun 11 16:49:56 2015
New Revision: 1684943
URL: http://svn.apache.org/r1684943
Log:
Fix loop that occurred with NIO (and could cause issues with APR as well) with
a closed connection during keepalive.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java?rev=1684943r1=1684942r2=1684943view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java Thu Jun
11 16:49:56 2015
@@ -16,6 +16,7 @@
*/
package org.apache.coyote.http11;
+import java.io.EOFException;
import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
@@ -729,9 +730,12 @@ public class Http11InputBuffer implement
if (nRead 0) {
lastValid = pos + nRead;
return true;
+} else if (nRead 0) {
+throw new EOFException(sm.getString(iib.eof.error));
+} else {
+return false;
}
-return false;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1684947 - in /tomcat/trunk/java/org/apache/coyote: ajp/AjpProcessor.java http11/Http11InputBuffer.java
Author: remm
Date: Thu Jun 11 17:04:37 2015
New Revision: 1684947
URL: http://svn.apache.org/r1684947
Log:
Read the algorithm, and look at the callers, AJP could be affected as well.
Elsewhere there are checks for -1. It is a bit risky to check only on -1
though, but it should work.
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1684947r1=1684946r2=1684947view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Thu Jun 11
17:04:37 2015
@@ -1532,6 +1532,8 @@ public class AjpProcessor extends Abstra
left = left - read;
start = start + read;
}
+} else if (read == -1) {
+throw new EOFException();
}
return read 0;
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java?rev=1684947r1=1684946r2=1684947view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java Thu Jun
11 17:04:37 2015
@@ -730,7 +730,7 @@ public class Http11InputBuffer implement
if (nRead 0) {
lastValid = pos + nRead;
return true;
-} else if (nRead 0) {
+} else if (nRead == -1) {
throw new EOFException(sm.getString(iib.eof.error));
} else {
return false;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1368 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1684943 Blamelist: remm Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57974] getOpenSessions() bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=57974
--- Comment #1 from dstojkov dstojkov2...@yahoo.fr ---
Actually the endpoint share all the sessions with others Endpoints no matter if
it is through login/password or not.
I dont know how you implemented it but this should be something like:
...
private MapEndpoint, ListSessions endPointMappers
...
SetSessions getSessions(Endpoint ep) {
synchronized(lock) {
return new TreeSet(endPointMappers.get(ep));
}
}
Any fix in view ? Or at least a comment on this ? This make the use of
websockets a true nightmare
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58023] New: Memory Leak in WebappClassLoader
https://bz.apache.org/bugzilla/show_bug.cgi?id=58023
Bug ID: 58023
Summary: Memory Leak in WebappClassLoader
Product: Tomcat 7
Version: 7.0.59
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: m...@interact.com.br
Memory leak occur because a reference of entry.manifest is never removed.
Problem:
1 - ${class}.class.getResource( ${resource.name1} );
2 - JarFile load a manifest.
3- resourceEntries put a new ResourceEntry with a manifest reference.
4 - ${class}.class.getResource( ${resource.name2} );
5 - resourceEntries put a new ResourceEntry with a manifest reference. Manifest
contains ~20MB, but, no problem because the JarFile is the same reference. In
other words, only one Manifest in the Heap space.
6 - wait for 9 milliseconds.
7 - ${class}.class.getResource( ${resource.name3} );
8 - WebappClassLoader.closeJARs because time is elapsed 9 milliseconds and
load a new JarFile instances.
9 - JarFile load a new manifest.
10 - resourceEntries put a new ResourceEntry with a new manifest reference.
11 - wait for 9 milliseconds
...
And this will be memory leak in little time (See resourceEntries.png).
In attachment, a scenario to simulate this problem.
PS.: A jar file need to be signed for accelerate leak, because of
Manifest.entries ~5MB (see manifests.png) retained heap (in test case, but, my
real app is ~20MB).
I attached the heap dump used in this test case (heap.zip).
Solution:
Always release the manifest reference.
Workaround:
public class WebappClassLoader
extends
org.apache.catalina.loader.WebappClassLoader
{
@Override
public InputStream getResourceAsStream( String name )
{
InputStream in = super.getResourceAsStream( name );
ResourceEntry entry = resourceEntries.get( name );
if ( entry != null )
{
// prevent a memory leak
entry.manifest = null;
entry.certificates = null;
}
return in;
}
@Override
public URL getResource( String name )
{
URL url = super.getResource( name );
ResourceEntry entry = resourceEntries.get( name );
if ( entry != null )
{
// prevent a memory leak
entry.manifest = null;
entry.certificates = null;
}
return url;
}
}
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1684864 - in /tomcat/trunk/test/org/apache/coyote/http2: Http2TestBase.java TestHttp2Section_4_1.java TestHttp2Section_4_2.java TestHttp2Section_4_3.java TestHttp2Section_5_1.java
Author: markt
Date: Thu Jun 11 12:25:12 2015
New Revision: 1684864
URL: http://svn.apache.org/r1684864
Log:
Simplify
Modified:
tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_1.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_3.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_1.java
Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java?rev=1684864r1=1684863r2=1684864view=diff
==
--- tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java Thu Jun 11
12:25:12 2015
@@ -263,6 +263,7 @@ public abstract class Http2TestBase exte
input = new TestInput(is);
output = new TestOutput();
parser = new Http2Parser(-1, input, output);
+hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
}
Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_1.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_1.java?rev=1684864r1=1684863r2=1684864view=diff
==
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_1.java
(original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_1.java Thu Jun
11 12:25:12 2015
@@ -38,8 +38,6 @@ public class TestHttp2Section_4_1 extend
@Test
public void testUnknownFrameType() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
http2Connect();
os.write(UNKNOWN_FRAME);
os.flush();
@@ -54,8 +52,6 @@ public class TestHttp2Section_4_1 extend
@Test
public void testReservedBitIgnored() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java?rev=1684864r1=1684863r2=1684864view=diff
==
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
(original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java Thu Jun
11 12:25:12 2015
@@ -30,8 +30,6 @@ public class TestHttp2Section_4_2 extend
@Test
public void testFrameSizeLimitsTooBig() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
@@ -67,8 +65,6 @@ public class TestHttp2Section_4_2 extend
@Test
public void testFrameTypeLimitsTooBig() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
@@ -97,8 +93,6 @@ public class TestHttp2Section_4_2 extend
@Test
public void testFrameTypeLimitsTooSmall() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
@@ -126,8 +120,6 @@ public class TestHttp2Section_4_2 extend
@Test
public void testFrameTypeLimitsStream() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_3.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_3.java?rev=1684864r1=1684863r2=1684864view=diff
==
--- tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_3.java
(original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_3.java Thu Jun
11 12:25:12 2015
@@ -32,8 +32,6 @@ public class TestHttp2Section_4_3 extend
@Test
public void testHeaderDecodingError() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
@@ -59,8 +57,6 @@ public class TestHttp2Section_4_3 extend
@Test
public void testHeaderContinuationContiguous() throws Exception {
-hpackEncoder = new
HpackEncoder(ConnectionSettings.DEFAULT_HEADER_TABLE_SIZE);
-
// HTTP2 upgrade
http2Connect();
@@ -85,8 +81,6 @@ public class TestHttp2Section_4_3
[Bug 57974] getOpenSessions() bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=57974 dstojkov dstojkov2...@yahoo.fr changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58010] Class file are not getting compiled with debuginfo while setting classdebuginfo in jasper ant task
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010 --- Comment #5 from Vasantharaju vasa@gmail.com --- I tried with classDebugInfo as well the issue still persists . Let us know for more information or samples -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58010] Class file are not getting compiled with debuginfo while setting classdebuginfo in jasper ant task
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010 --- Comment #4 from Vasantharaju vasa@gmail.com --- Even is the flag misspelled the default behavior for jasper is to compile class files with debuginfo as per documentation. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1685032 - /tomcat/trunk/build.xml
Author: billbarker
Date: Fri Jun 12 04:30:08 2015
New Revision: 1685032
URL: http://svn.apache.org/r1685032
Log:
Allow Gump to use the newer version of checkstyle
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1685032r1=1685031r2=1685032view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Fri Jun 12 04:30:08 2015
@@ -540,8 +540,12 @@
description=Uses Checkstyle tool to perform style check for the source
code
!-- Required so we can cache checkstyle results --
mkdir dir=${tomcat.output}/res/checkstyle/
+available property=checkstyletask.properties
resource=checkstyletask.properties
+ classpath=${checkstyle.jar} value=checkstyletask.properties/
+available property=checkstyletask.properties
resource=com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties
+ classpath=${checkstyle.jar}
value=com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties/
-taskdef resource=checkstyletask.properties
+taskdef resource=${checkstyletask.properties}
classpath=${checkstyle.jar} /
checkstyle config=res/checkstyle/checkstyle.xml
fileset dir=.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1685035 - /tomcat/tc7.0.x/trunk/build.xml
Author: billbarker
Date: Fri Jun 12 04:34:11 2015
New Revision: 1685035
URL: http://svn.apache.org/r1685035
Log:
Allow Gump to use the newer version of checkstyle
Modified:
tomcat/tc7.0.x/trunk/build.xml
Modified: tomcat/tc7.0.x/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1685035r1=1685034r2=1685035view=diff
==
--- tomcat/tc7.0.x/trunk/build.xml (original)
+++ tomcat/tc7.0.x/trunk/build.xml Fri Jun 12 04:34:11 2015
@@ -520,8 +520,12 @@
description=Uses Checkstyle tool to perform style check for the source
code
!-- Required so we can cache checkstyle results --
mkdir dir=${tomcat.output}/res/checkstyle/
+available property=checkstyletask.properties
resource=checkstyletask.properties
+ classpath=${checkstyle.jar} value=checkstyletask.properties/
+available property=checkstyletask.properties
resource=com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties
+ classpath=${checkstyle.jar}
value=com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties/
-taskdef resource=checkstyletask.properties
+taskdef resource=${checkstyletask.properties}
classpath=${checkstyle.jar} /
checkstyle config=res/checkstyle/checkstyle.xml
fileset dir=.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1685033 - /tomcat/tc8.0.x/trunk/build.xml
Author: billbarker
Date: Fri Jun 12 04:32:40 2015
New Revision: 1685033
URL: http://svn.apache.org/r1685033
Log:
Allow Gump to use the newer version of checkstyle
Modified:
tomcat/tc8.0.x/trunk/build.xml
Modified: tomcat/tc8.0.x/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/build.xml?rev=1685033r1=1685032r2=1685033view=diff
==
--- tomcat/tc8.0.x/trunk/build.xml (original)
+++ tomcat/tc8.0.x/trunk/build.xml Fri Jun 12 04:32:40 2015
@@ -531,8 +531,12 @@
description=Uses Checkstyle tool to perform style check for the source
code
!-- Required so we can cache checkstyle results --
mkdir dir=${tomcat.output}/res/checkstyle/
+available property=checkstyletask.properties
resource=checkstyletask.properties
+ classpath=${checkstyle.jar} value=checkstyletask.properties/
+available property=checkstyletask.properties
resource=com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties
+ classpath=${checkstyle.jar}
value=com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties/
-taskdef resource=checkstyletask.properties
+taskdef resource=${checkstyletask.properties}
classpath=${checkstyle.jar} /
checkstyle config=res/checkstyle/checkstyle.xml
fileset dir=.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Consider support for the Servlet profile of JSR 196 (JASPIC) in Tomcat 7.0.x
Hi, David! Is the hope that these existing forms of auth will be ported and plugged in through the JASPIC support? That would be quite excellent if so. Yes, this is our main goal, actually. Implementing JASPIC is only part of my GSOC project. -- Thanks, Fjodor
[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 10 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.0.x-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-8.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:commons-beanutils-gump-20150605.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:commons-cli-gump-20150605.jar:commons-lang3-gump-20150605.xml:commons-logging-gump-20150605.jar:commons-logging-api-gump-20150605.jar:/srv/gump/packages/guava/guava-18.0.jar - Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle [taskdef] Could not load definitions from resource checkstyletask.properties. It could not be found. BUILD FAILED /srv/gump/public/workspace/tomcat-8.0.x/build.xml:537: Problem: failed to create task or type checkstyle Cause: The name is undefined. Action: Check the spelling. Action: Check that any custom tasks/types have been declared. Action: Check that any presetdef/macrodef declarations have taken place. Total time: 1 second - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2015061205, vmgump.apache.org:vmgump:2015061205 Gump E-mail Identifier (unique within run) #25. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 10 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 2 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:commons-beanutils-gump-20150605.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:commons-cli-gump-20150605.jar:commons-lang3-gump-20150605.xml:commons-logging-gump-20150605.jar:commons-logging-api-gump-20150605.jar:/srv/gump/packages/guava/guava-18.0.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [taskdef] Could not load definitions from resource checkstyletask.properties. It could not be found. BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:546: Problem: failed to create task or type checkstyle Cause: The name is undefined. Action: Check the spelling. Action: Check that any custom tasks/types have been declared. Action: Check that any presetdef/macrodef declarations have taken place. Total time: 2 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2015061205, vmgump.apache.org:vmgump:2015061205 Gump E-mail Identifier (unique within run) #26. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 10 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 3 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:commons-beanutils-gump-20150605.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:commons-cli-gump-20150605.jar:commons-lang3-gump-20150605.xml:commons-logging-gump-20150605.jar:commons-logging-api-gump-20150605.jar:/srv/gump/packages/guava/guava-18.0.jar - Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-7.0.x/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/build/temp compile-prepare: download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle [taskdef] Could not load definitions from resource checkstyletask.properties. It could not be found. BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:526: Problem: failed to create task or type checkstyle Cause: The name is undefined. Action: Check the spelling. Action: Check that any custom tasks/types have been declared. Action: Check that any presetdef/macrodef declarations have taken place. Total time: 2 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2015061205, vmgump.apache.org:vmgump:2015061205 Gump E-mail Identifier (unique within run) #24. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
