Re: Time for Tomcat 7.0.63?

Hi, 2015-06-23 20:53 GMT+03:00 Christopher Schultz ch...@christopherschultz.net : All, Some recent bugs have been fixed and there is some community demand for 7.0.63. e.g. https://bz.apache.org/bugzilla/show_bug.cgi?id=57783 Violetta, are you up for another release? I want to fix this

svn commit: r1687193 - /tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java

Author: markt Date: Wed Jun 24 08:02:34 2015 New Revision: 1687193 URL: http://svn.apache.org/r1687193 Log: Add unit tests for rst frames Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java (with props) Added:

[Bug 58074] New: Memory leak - session serialization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58074 Bug ID: 58074 Summary: Memory leak - session serialization Product: Tomcat 7 Version: 7.0.62 Hardware: PC Status: NEW Severity: minor Priority: P2

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1446 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1687184 - in /tomcat/trunk/test/org/apache/coyote/http2: Http2TestBase.java TestHttp2Section_6_2.java

Author: markt Date: Wed Jun 24 07:53:55 2015 New Revision: 1687184 URL: http://svn.apache.org/r1687184 Log: Use constants Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_2.java Modified:

svn commit: r1687183 - /tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java

Author: markt Date: Wed Jun 24 07:53:20 2015 New Revision: 1687183 URL: http://svn.apache.org/r1687183 Log: Add unit tests for priority frames Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java (with props) Added:

[Bug 57700] Exception in a LifecycleListener on Context makes webapp unreachable in spite of subsequent successful startups

https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 --- Comment #4 from Violeta Georgieva violet...@apache.org --- Hi, I succeeded to reproduce the scenario on all Tomcat versions. The issue is the following: - The implementation of Manager web app invokes HostConfig to deploy the web

svn commit: r1687251 - /tomcat/tc8.0.x/trunk/webapps/docs/rewrite.xml

Author: remm Date: Wed Jun 24 12:34:07 2015 New Revision: 1687251 URL: http://svn.apache.org/r1687251 Log: Port 58052: Clarify that some newer additions from the mod_rewrite documentation are not supported in Tomcat. Modified: tomcat/tc8.0.x/trunk/webapps/docs/rewrite.xml Modified:

svn commit: r1687250 - /tomcat/trunk/webapps/docs/rewrite.xml

Author: remm Date: Wed Jun 24 12:33:24 2015 New Revision: 1687250 URL: http://svn.apache.org/r1687250 Log: 58052: Clarify that some newer additions from the mod_rewrite documentation are not supported in Tomcat. Modified: tomcat/trunk/webapps/docs/rewrite.xml Modified:

buildbot exception in ASF Buildbot on tomcat-trunk

The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1448 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58074] Memory leak - session serialization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58074 Mark Thomas ma...@apache.org changed: What|Removed |Added Resolution|--- |INVALID

[Bug 57700] Exception in a LifecycleListener on Context makes webapp unreachable in spite of subsequent successful startups

https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 --- Comment #5 from Mark Thomas ma...@apache.org --- I'm wary of changing the order since it might break something else. How about a finally block? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57700] Exception in a LifecycleListener on Context makes webapp unreachable in spite of subsequent successful startups

https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 --- Comment #8 from Remy Maucherat r...@apache.org --- Would be fine then, but +1 for the finally. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1687242 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

Author: markt Date: Wed Jun 24 11:58:57 2015 New Revision: 1687242 URL: http://svn.apache.org/r1687242 Log: Differentiate between failure modes. Handling is currently identical but it won't be once BZ 58031 is addressed. Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java

[Bug 58052] RewriteValve: Implement additional RewriteRule directive capabilities

https://bz.apache.org/bugzilla/show_bug.cgi?id=58052 --- Comment #5 from Remy Maucherat r...@apache.org --- I have documented explicitly the difference with the current mod_rewrite in that area. -- You are receiving this mail because: You are the assignee for the bug.

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1449 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 57700] Exception in a LifecycleListener on Context makes webapp unreachable in spite of subsequent successful startups

https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 --- Comment #7 from Violeta Georgieva violet...@apache.org --- (In reply to Mark Thomas from comment #5) I'm wary of changing the order since it might break something else. How about a finally block? +1 (In reply to Remy Maucherat from

[Bug 57700] Exception in a LifecycleListener on Context makes webapp unreachable in spite of subsequent successful startups

https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 --- Comment #6 from Remy Maucherat r...@apache.org --- I agree it will have side effects, like maybe mapping requests while the context is being deployed ? A finally seems better but even that would still change the current behavior (previously

svn commit: r1687361 - /tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java

Author: markt Date: Wed Jun 24 20:26:17 2015 New Revision: 1687361 URL: http://svn.apache.org/r1687361 Log: Fix typo Modified: tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java Modified: tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java URL:

svn commit: r1687369 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

Author: markt Date: Wed Jun 24 21:01:24 2015 New Revision: 1687369 URL: http://svn.apache.org/r1687369 Log: Remove unnecessary code Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java URL:

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1450 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1687278 - in /tomcat/trunk/test/org/apache/coyote/http2: Http2TestBase.java TestHttp2Section_5_2.java TestHttp2Section_5_3.java TestHttp2Section_5_5.java

Author: markt Date: Wed Jun 24 13:55:44 2015 New Revision: 1687278 URL: http://svn.apache.org/r1687278 Log: Make writing the settings frame unit tests easier. Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1452 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1453 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1687268 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

Author: violetagg Date: Wed Jun 24 13:40:34 2015 New Revision: 1687268 URL: http://svn.apache.org/r1687268 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 ADD_CHILD_EVENT must be sent even when there are failures during child's start, thus MapperListener will be added as

svn commit: r1687261 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/filters/ java/org/apache/tomcat/util/http/ test/org/apache/catalina/conn

Author: markt Date: Wed Jun 24 13:26:06 2015 New Revision: 1687261 URL: http://svn.apache.org/r1687261 Log: Make the (first) reason parameter parsing failed available as a request attribute and then use it to provide a better status code via the FailedRequstFilter (if configured). Modified:

[Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 --- Comment #10 from Mark Thomas ma...@apache.org --- I've patched trunk (9.0.x) to make the reason for the failure available as a request attribute that the FailedRequestFilter can then use to provide a better status code to the client. I'll

Re: [Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

On 24/06/2015 14:43, Violeta Georgieva wrote: Hi Mark, 2015-06-24 16:27 GMT+03:00 bugzi...@apache.org: https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 --- Comment #10 from Mark Thomas ma...@apache.org --- I've patched trunk (9.0.x) to make the reason for the failure available as a

Re: [Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

Mark, On 6/24/15 9:57 AM, Mark Thomas wrote: On 24/06/2015 14:43, Violeta Georgieva wrote: Hi Mark, 2015-06-24 16:27 GMT+03:00 bugzi...@apache.org: https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 --- Comment #10 from Mark Thomas ma...@apache.org --- I've patched trunk (9.0.x) to

Re: [Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

Hi Mark, 2015-06-24 16:27 GMT+03:00 bugzi...@apache.org: https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 --- Comment #10 from Mark Thomas ma...@apache.org --- I've patched trunk (9.0.x) to make the reason for the failure available as a request attribute that the FailedRequestFilter can

[Bug 58074] Memory leak - session serialization

https://bz.apache.org/bugzilla/show_bug.cgi?id=58074 --- Comment #2 from qed...@gmail.com --- (In reply to Mark Thomas from comment #1) A profiler confirms that there is no memory leak here. weak references != memory leaks. GC will clear them as/if necessary to relieve memory pressure. I must

svn commit: r1687292 - /tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettings.java

Author: markt Date: Wed Jun 24 14:15:32 2015 New Revision: 1687292 URL: http://svn.apache.org/r1687292 Log: Correct error code Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettings.java Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettings.java URL:

Re: Time for Tomcat 7.0.63?

Violeta, On 6/24/15 2:34 AM, Violeta Georgieva wrote: Hi, 2015-06-23 20:53 GMT+03:00 Christopher Schultz ch...@christopherschultz.net : All, Some recent bugs have been fixed and there is some community demand for 7.0.63. e.g. https://bz.apache.org/bugzilla/show_bug.cgi?id=57783

svn commit: r1687342 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java

Author: markt Date: Wed Jun 24 18:45:59 2015 New Revision: 1687342 URL: http://svn.apache.org/r1687342 Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Propchange: tomcat/tc7.0.x/trunk/

[Bug 57546] Memory Leak in SecureNioChannel

https://bz.apache.org/bugzilla/show_bug.cgi?id=57546 --- Comment #14 from Mark Thomas ma...@apache.org --- (In reply to Paul Gaylie from comment #13) Created attachment 32854 [details] Screen Shot from hprof Guys, Please consider using a more gender neutral form of address when addressing

svn commit: r1687340 - /tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java

Author: markt Date: Wed Jun 24 18:44:18 2015 New Revision: 1687340 URL: http://svn.apache.org/r1687340 Log: Fix FindBugs warning. Don't use != with Strings Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Modified:

svn commit: r1687341 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java

Author: markt Date: Wed Jun 24 18:45:20 2015 New Revision: 1687341 URL: http://svn.apache.org/r1687341 Log: Fix FindBugs warning. Don't use != with Strings Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java

Re: [Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

2015-06-24 18:37 GMT+03:00 Christopher Schultz ch...@christopherschultz.net : Mark, On 6/24/15 9:57 AM, Mark Thomas wrote: On 24/06/2015 14:43, Violeta Georgieva wrote: Hi Mark, 2015-06-24 16:27 GMT+03:00 bugzi...@apache.org: https://bz.apache.org/bugzilla/show_bug.cgi?id=58031

[Bug 57700] Exception in a LifecycleListener on Context makes webapp unreachable in spite of subsequent successful startups

https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 Violeta Georgieva violet...@apache.org changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1687333 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java webapps/docs/changelog.xml

Author: violetagg Date: Wed Jun 24 17:33:17 2015 New Revision: 1687333 URL: http://svn.apache.org/r1687333 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 Merged revision 1687268 from tomcat/trunk: ADD_CHILD_EVENT must be sent even when there are failures during child's start, thus

svn commit: r1687334 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java webapps/docs/changelog.xml

Author: violetagg Date: Wed Jun 24 17:37:39 2015 New Revision: 1687334 URL: http://svn.apache.org/r1687334 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57700 Merged revision 1687268 from tomcat/trunk: ADD_CHILD_EVENT must be sent even when there are failures during child's start, thus

[Bug 57546] Memory Leak in SecureNioChannel

https://bz.apache.org/bugzilla/show_bug.cgi?id=57546 Paul Gaylie paul.gay...@gmail.com changed: What|Removed |Added CC|

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/689 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/302 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot exception in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a build exception on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/303 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1687350 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

Author: markt Date: Wed Jun 24 19:37:02 2015 New Revision: 1687350 URL: http://svn.apache.org/r1687350 Log: Fix logic Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java URL:

svn commit: r1687351 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

Author: markt Date: Wed Jun 24 19:44:51 2015 New Revision: 1687351 URL: http://svn.apache.org/r1687351 Log: Correct boundary condition Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

svn commit: r1687352 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Wed Jun 24 19:45:46 2015 New Revision: 1687352 URL: http://svn.apache.org/r1687352 Log: Add some more false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1454 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1687346 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

Author: markt Date: Wed Jun 24 19:10:57 2015 New Revision: 1687346 URL: http://svn.apache.org/r1687346 Log: Fix FindBugs warnings. activeRemoteStreamCount wasn't thread safe. Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified:

svn commit: r1687349 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/PrincipalGroupCallback.java

Author: markt Date: Wed Jun 24 19:26:00 2015 New Revision: 1687349 URL: http://svn.apache.org/r1687349 Log: Fix copy/paste error spotted by FindBugs Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/PrincipalGroupCallback.java Modified: