svn commit: r1703774 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/util/LifecycleSupport.java

Author: markt Date: Fri Sep 18 08:51:59 2015 New Revision: 1703774 URL: http://svn.apache.org/viewvc?rev=1703774=rev Log: Clean-up. No functional change. Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/util/LifecycleSupport.java Modified:

[Bug 58371] Data races on field org.apache.tomcat.util.buf.MessageBytes.hasStrValue & strValue

https://bz.apache.org/bugzilla/show_bug.cgi?id=58371 --- Comment #3 from Mark Thomas --- *** Bug 58399 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[Bug 58399] Data race on field org.apache.tomcat.util.buf.ByteChunk.charset

https://bz.apache.org/bugzilla/show_bug.cgi?id=58399 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1703784 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 09:04:20 2015 New Revision: 1703784 URL: http://svn.apache.org/viewvc?rev=1703784=rev Log: Fix checkstyle warning Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/305 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58397] Data race on field org.apache.catalina.tribes.transport.nio.PooledParallelSender.connected

https://bz.apache.org/bugzilla/show_bug.cgi?id=58397 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 58398] Data race on field org.apache.catalina.util.LifecycleSupport.listeners

https://bz.apache.org/bugzilla/show_bug.cgi?id=58398 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1703778 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/util/LifecycleSupport.java webapps/docs/changelog.xml

Author: markt Date: Fri Sep 18 08:56:11 2015 New Revision: 1703778 URL: http://svn.apache.org/viewvc?rev=1703778=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58398 Simplify the code and fix a data race (listeners should have been volatile) Modified:

svn commit: r1703785 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 09:04:59 2015 New Revision: 1703785 URL: http://svn.apache.org/viewvc?rev=1703785=rev Log: Fix checkstyle warning Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Propchange:

svn commit: r1703772 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

Author: markt Date: Fri Sep 18 08:50:33 2015 New Revision: 1703772 URL: http://svn.apache.org/viewvc?rev=1703772=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58398 Simplify the code and fix a data race (listeners should have been volatile) Modified:

svn commit: r1703763 - in /tomcat/trunk/java/org/apache/catalina/tribes/transport: AbstractSender.java nio/PooledParallelSender.java

Author: markt Date: Fri Sep 18 08:22:11 2015 New Revision: 1703763 URL: http://svn.apache.org/viewvc?rev=1703763=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58397 Remove unnecessary duplicated connected field and fix a rare data race on close. Modified:

svn commit: r1703765 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/transport/AbstractSender.java java/org/apache/catalina/tribes/transport/nio/PooledParallelSender.java webapps/docs/c

Author: markt Date: Fri Sep 18 08:33:20 2015 New Revision: 1703765 URL: http://svn.apache.org/viewvc?rev=1703765=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58397 Remove unnecessary duplicated connected field and fix a rare data race on close. Modified: tomcat/tc8.0.x/trunk/

[Bug 58400] Data race on field org.apache.tomcat.util.net.NioEndpoint$KeyAttachment.cometNotify

https://bz.apache.org/bugzilla/show_bug.cgi?id=58400 Mark Thomas changed: What|Removed |Added Resolution|--- |DUPLICATE

[Bug 58396] Data race on field org.apache.tomcat.util.net.NioEndpoint$Poller.nextExpiration

https://bz.apache.org/bugzilla/show_bug.cgi?id=58396 --- Comment #2 from Mark Thomas --- *** Bug 58400 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[Bug 58401] Potential data race inside the data array used in org.apache.catalina.tribes.io.ChannelData & org.apache.catalina.tribes.membership.MemberImpl

https://bz.apache.org/bugzilla/show_bug.cgi?id=58401 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 58395] Data races inside org.apache.catalina.tribes.membership.MemberImpl

https://bz.apache.org/bugzilla/show_bug.cgi?id=58395 --- Comment #2 from Mark Thomas --- *** Bug 58401 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/308 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot failure in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/138 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1703815 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

Author: markt Date: Fri Sep 18 12:04:39 2015 New Revision: 1703815 URL: http://svn.apache.org/viewvc?rev=1703815=rev Log: Rename to avoid naming overlap in StandardContext Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java Modified:

svn commit: r1703825 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/core/TestStandardContextResources.java

Author: markt Date: Fri Sep 18 12:47:26 2015 New Revision: 1703825 URL: http://svn.apache.org/viewvc?rev=1703825=rev Log: Fix test broken by fix for BZ 58373 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java

svn commit: r1703821 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/core/TestStandardContextResources.java

Author: markt Date: Fri Sep 18 12:41:19 2015 New Revision: 1703821 URL: http://svn.apache.org/viewvc?rev=1703821=rev Log: Fix test broken by fix for BZ 58373 Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

buildbot exception in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a build exception on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/139 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.11-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20150918.jar:/srv/gump/packages

[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.11-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20150918.jar:/srv/gump

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

Hi Mark, I think these are false positives because the completion handler is only called after the IO operation completes. There is an implicit happens-before order here. I have fixed these false positives recently. That's why I didn't report them in BZ. Could you try the latest version of

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently updated. If that's the case, then it's probably a real race and I have to take a closer look. Thanks, Yilong On Fri, Sep 18, 2015 at 7:43 AM, Mark Thomas wrote: > On 18/09/2015 15:27, Yilong Li wrote: > > Hi

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

On 18/09/2015 15:51, Yilong Li wrote: > Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently > updated. If that's the case, then it's probably a real race and I have to > take a closer look. Downloaded at around 10.30 UTC today. The races looked plausible. There was an obvious

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/312 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

On 18/09/2015 15:27, Yilong Li wrote: > Hi Mark, > > I think these are false positives because the completion handler is only > called after the IO operation completes. There is an implicit > happens-before order here. I have fixed these false positives recently. > That's why I didn't report them

svn commit: r1703844 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/juli/AsyncFileHandler.java webapps/docs/changelog.xml

Author: markt Date: Fri Sep 18 13:34:39 2015 New Revision: 1703844 URL: http://svn.apache.org/viewvc?rev=1703844=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58412 Ensure correct method and package names are logged. Modified: tomcat/tc8.0.x/trunk/ (props changed)

[Bug 58412] AsyncFileHandler logs package and method name as null.null

https://bz.apache.org/bugzilla/show_bug.cgi?id=58412 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1703850 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 13:42:21 2015 New Revision: 1703850 URL: http://svn.apache.org/viewvc?rev=1703850=rev Log: More thread-safety Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Propchange:

svn commit: r1703853 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ObjectReader.java

Author: markt Date: Fri Sep 18 13:48:31 2015 New Revision: 1703853 URL: http://svn.apache.org/viewvc?rev=1703853=rev Log: More thread-safety Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ObjectReader.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/310 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1703842 - /tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java

Author: markt Date: Fri Sep 18 13:27:36 2015 New Revision: 1703842 URL: http://svn.apache.org/viewvc?rev=1703842=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58412 Ensure correct method and package names are logged. Modified:

svn commit: r1703857 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/transport/SenderState.java

Author: markt Date: Fri Sep 18 13:52:41 2015 New Revision: 1703857 URL: http://svn.apache.org/viewvc?rev=1703857=rev Log: More thread-safety Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/SenderState.java Propchange:

svn commit: r1703862 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 14:06:40 2015 New Revision: 1703862 URL: http://svn.apache.org/viewvc?rev=1703862=rev Log: Fix another data race Code clean-up Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

svn commit: r1703849 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 13:41:34 2015 New Revision: 1703849 URL: http://svn.apache.org/viewvc?rev=1703849=rev Log: More thread-safety Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Modified:

svn commit: r1703852 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 13:45:39 2015 New Revision: 1703852 URL: http://svn.apache.org/viewvc?rev=1703852=rev Log: More thread-safety Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Propchange:

svn commit: r1703851 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 13:44:41 2015 New Revision: 1703851 URL: http://svn.apache.org/viewvc?rev=1703851=rev Log: More thread-safety Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Modified:

svn commit: r1703860 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

Author: markt Date: Fri Sep 18 14:04:34 2015 New Revision: 1703860 URL: http://svn.apache.org/viewvc?rev=1703860=rev Log: Fix another data race Code clean-up Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Modified:

svn commit: r1703865 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsFrameClient.java WsSession.java

Author: markt Date: Fri Sep 18 14:12:41 2015 New Revision: 1703865 URL: http://svn.apache.org/viewvc?rev=1703865=rev Log: Fix various data races reported by RV-Predict. Mostly caused by completion handlers that execute in a new thread Modified:

buildbot exception in ASF Buildbot on tomcat-trunk

The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/309 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1703854 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/io/ObjectReader.java

Author: markt Date: Fri Sep 18 13:49:05 2015 New Revision: 1703854 URL: http://svn.apache.org/viewvc?rev=1703854=rev Log: More thread-safety Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/io/ObjectReader.java Propchange:

svn commit: r1703856 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/SenderState.java

Author: markt Date: Fri Sep 18 13:52:01 2015 New Revision: 1703856 URL: http://svn.apache.org/viewvc?rev=1703856=rev Log: More thread-safety Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/SenderState.java Modified:

svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession.jav

Author: markt Date: Fri Sep 18 14:14:18 2015 New Revision: 1703866 URL: http://svn.apache.org/viewvc?rev=1703866=rev Log: Fix various data races reported by RV-Predict. Mostly caused by completion handlers that execute in a new thread Modified: tomcat/tc8.0.x/trunk/ (props changed)

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/311 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

New Coverity Scan

Hi, I uploaded new scan [1] (against Tomcat 8 trunk). Regards, Violeta [1] https://scan.coverity.com/projects/apache-tomcat

svn commit: r1703890 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java

Author: markt Date: Fri Sep 18 15:34:30 2015 New Revision: 1703890 URL: http://svn.apache.org/viewvc?rev=1703890=rev Log: Test case for bug 58414. This passes without any changes. Is there something else going on? Modified:

[Bug 58414] Can not transfer empty string through Web Socket

https://bz.apache.org/bugzilla/show_bug.cgi?id=58414 --- Comment #1 from Mark Thomas --- I've been able to reproduce this with some edits to the chat example that ships with Tomcat. Working on a fix now. -- You are receiving this mail because: You are the assignee for the

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

Yes, you are right. These are real. I didn't rerun the entire test suite after fixing the obvious false positives. Yilong On Fri, Sep 18, 2015 at 7:58 AM, Mark Thomas wrote: > On 18/09/2015 15:51, Yilong Li wrote: > > Are you using the 1.7-SNAPSHOT downloaded recently? It's

buildbot success in ASF Buildbot on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/142 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The