Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Ognjen Blagojevic

Mark,

On 15.11.2015 13:42, Mark Thomas wrote:

   * SSLTest also reports that APR/native does not serve full certificate
chain; instead, it serves only server certificate. The same APR config
serves full chain with Tomcat 8.0.28 + Native 1.2.2, so it seems to be a
regression. Not serving full chain might be a problem for some clients
-- browsers will probably work, but other clients may fail to establish
TLS connection.


Hmm. I'm sure this was working at one point. I'll retest it.


Tomcat 8 docs lists APR Connector attribute "SSLCertificateChainFile" 
[1]. Tomcat 9 docs, does not list such attribute (neither in "SSL 
Support - SSLHostConfig", "SSL Support - Certificate" nor "SSL Support - 
Connector - APR/Native (deprecated)"). I also check the class 
SSLHostConfigCertificate, and couldn't find a field for the chain.


-Ognjen

[1] 
http://tomcat.apache.org/tomcat-8.0-doc/config/http.html#SSL_Support_-_APR/Native


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Mark Thomas
On 16/11/2015 15:59, Ognjen Blagojevic wrote:
> Mark,
> 
> On 15.11.2015 13:42, Mark Thomas wrote:
>>>* SSLTest also reports that APR/native does not serve full
>>> certificate
>>> chain; instead, it serves only server certificate. The same APR config
>>> serves full chain with Tomcat 8.0.28 + Native 1.2.2, so it seems to be a
>>> regression. Not serving full chain might be a problem for some clients
>>> -- browsers will probably work, but other clients may fail to establish
>>> TLS connection.
>>
>> Hmm. I'm sure this was working at one point. I'll retest it.
> 
> Tomcat 8 docs lists APR Connector attribute "SSLCertificateChainFile"
> [1]. Tomcat 9 docs, does not list such attribute (neither in "SSL
> Support - SSLHostConfig", "SSL Support - Certificate" nor "SSL Support -
> Connector - APR/Native (deprecated)"). I also check the class
> SSLHostConfigCertificate, and couldn't find a field for the chain.

You use the same attribute as for the cert. i.e. you provide the full
chain rather than just the cert.

docs might need updating to make that clear.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58596] Add Patch Binary -- Running.txt says tomcat is a JAVA application and doesn't use Environment Variables.

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58596

--- Comment #3 from Konstantin Kolinko  ---
Clarified in 6.0 as well, for 6.0.45

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-8-trunk

2015-11-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/274

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1714580
Blamelist: kkolinko

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58610] Oracle DB connections not releasing from connection pool in Tomcat 8

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58610

Chuck Caldarale  changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58610] Oracle DB connections not releasing from connection pool in Tomcat 8

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58610

--- Comment #3 from RajKaruna  ---
Konstantin Kolinko.. you are a life saver for me... Works like a charm...

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58610] Oracle DB connections not releasing from connection pool in Tomcat 8

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58610

RajKaruna  changed:

   What|Removed |Added

 Resolution|INVALID |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1714583 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 12:45:11 2015
New Revision: 1714583

URL: http://svn.apache.org/viewvc?rev=1714583=rev
Log:
Add changelog entry for r1714185 and correct a typo.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Nov 16 12:45:11 2015
@@ -1,2 +1,2 @@
-/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712899,1712903,1712906,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114
 
,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342
 

buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-11-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/273

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1714573
Blamelist: kkolinko

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Rémy Maucherat
2015-11-15 16:36 GMT+01:00 Martin Grigorov :

> 1)
> ERROR - AtmosphereFramework- AtmosphereFramework exception
> java.lang.IllegalStateException: A filter or servlet of the current chain
> does not support asynchronous operations.
> at org.apache.catalina.connector.Request.startAsync(Request.java:1571)
> at
>
> org.apache.catalina.connector.RequestFacade.startAsync(RequestFacade.java:1037)
> at
> org.atmosphere.cpr.AtmosphereRequest.startAsync(AtmosphereRequest.java:723)
> at
>
> org.atmosphere.container.Servlet30CometSupport.suspend(Servlet30CometSupport.java:93)
> at
>
> org.atmosphere.container.Servlet30CometSupport.service(Servlet30CometSupport.java:68)
> at
>
> org.atmosphere.cpr.AtmosphereFramework.doCometSupport(AtmosphereFramework.java:2078)
> at org.atmosphere.cpr.AtmosphereServlet.doPost(AtmosphereServlet.java:198)
>
> Is it a good idea (and possible) to print which filter or servlet is not
> properly configured? For better debug info.
>

This is not a new feature, and this was not refactored. Adding more details
like the class name is quite difficult with the way this is done at the
moment, it would need a full rewrite [and most likely some regressions].
Not worth it IMO.

>
> 2)
> java.lang.NullPointerException
> at
> org.apache.catalina.connector.Request.getServletContext(Request.java:1559)
> at org.apache.catalina.connector.Request.getContextPath(Request.java:1894)
> at
>
> org.apache.catalina.connector.RequestFacade.getContextPath(RequestFacade.java:783)
> at
>
> org.atmosphere.cpr.AtmosphereRequest.getContextPath(AtmosphereRequest.java:359)
> at
>
> javax.servlet.http.HttpServletRequestWrapper.getContextPath(HttpServletRequestWrapper.java:150)
> at
> org.apache.wicket.atmosphere.EventBus$2.getContextPath(EventBus.java:473)
> at
>
> org.apache.wicket.protocol.http.servlet.ServletWebRequest.getContextRelativeUrl(ServletWebRequest.java:184)
> at
>
> org.apache.wicket.protocol.http.servlet.ServletWebRequest.(ServletWebRequest.java:112)
> at
>
> org.apache.wicket.protocol.http.servlet.ServletWebRequest.(ServletWebRequest.java:82)
>
> I believe this issue has been discussed before. Either here or in
> Atmosphere forums.
>
> Full stack trace please ? The context is null so either no context was
mapped or the request has already been recycled. I'm not convinced adding
too many null checks would really help.

Rémy


[Bug 58610] Oracle DB connections not releasing from connection pool in Tomcat 8

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58610

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Konstantin Kolinko  ---
Try adding closeMethod="close" to your 

https://tomcat.apache.org/tomcat-8.0-doc/config/globalresources.html#Resource_Definitions

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




svn commit: r1714570 - in /tomcat/tc6.0.x/trunk: ./ RUNNING.txt webapps/docs/changelog.xml

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 12:16:36 2015
New Revision: 1714570

URL: http://svn.apache.org/viewvc?rev=1714570=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58596
Clarify how environment variables are used.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/RUNNING.txt
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Nov 16 12:16:36 2015
@@ -1,3 +1,3 @@
-/tomcat/tc7.0.x/trunk:1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968,1666989,1668541
 
,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1714000,1714005
-/tomcat/tc8.0.x/trunk:1637685,1637709,1640674,1641726,1641729-1641730,1643513,1643539,1643571,1643581-1643582,1644018,1648816,1656300,1658801-1658803,1658811,1659522,1663997,1664175,1665086,1666967,1666988,1668634,1669801,1676556,1681182,1681840,1681864,1685827,1689921,1693108,1694291,1694427,1694873,1696379,1701944,1710347,1712618,1712655,1713998,1714004
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,656018,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770
 
809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,890265
 

svn commit: r1714573 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 12:28:45 2015
New Revision: 1714573

URL: http://svn.apache.org/viewvc?rev=1714573=rev
Log:
Move changelog entry for BZ 57799 to sort entries bug number.

Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1714573=1714572=1714573=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Nov 16 12:28:45 2015
@@ -61,6 +61,11 @@
 not EL in JSP attributes is processed as if it uses JSP attribute
 quoting. By default, EL does not use JSP attribute quoting. (markt)
   
+  
+57799: InputStream.available() was causing an IO operation
+to occur even in blocking mode, which caused problems with NIO2.
+(remm)
+  
   
 Extend the fix for 58228 to include
 ServletContext.getRealPath(). (markt)
@@ -144,11 +149,6 @@
 for REST APIs. (violetagg)
   
   
-57799: InputStream.available() was causing an IO operation
-to occur even in blocking mode, which caused problems with NIO2.
-(remm)
-  
-  
 58578: Avoid NPE accessing cookies during access logging
 for request that had no context mapping. (remm)
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1714580 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 12:41:37 2015
New Revision: 1714580

URL: http://svn.apache.org/viewvc?rev=1714580=rev
Log:
Add changelog entry for r1714038 and correct a typo.
Expand changelog entry for FindBugs to make it more clear. (Some support for 
FindBugs was already there: res/findbugs/filter-false-positives.xml)

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Nov 16 12:41:37 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
 
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657
 
609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1666387,1666494,1666496,1666552,1
 
666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-1684527,1684549-1684550,1685556,1685591,168573
 

[Bug 58614] New: summary

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58614

Bug ID: 58614
   Summary: summary
   Product: Tomcat 6
   Version: 6.0.44
  Hardware: PC
   URL: http://pointer to a web site where the problem is seen
OS: Windows XP
Status: NEW
  Severity: blocker
  Priority: P1
 Component: Servlet & JSP API
  Assignee: dev@tomcat.apache.org
  Reporter: iambibek...@gmail.com
CC: iambibek...@gmail.com

test 123...

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Christopher Schultz
Mark,

On 11/12/15 7:12 PM, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.0.M1 release is now available for voting.
> 
> This is the first milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 8.0.x branch are:
> - Requires Java 8
> - BIO, Comet and Windows Itanium support have been removed
> - Support for TLS virtual hosting, ALPN, HTTP/2 and OpenSSL with
>   NIO/NIO2 has been added
> - Lots of internal refactoring to support the above changes
> 
> For full details, see the changelog:
> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M1/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1054/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcattags/TOMCAT_9_0_0_M1/
> 
> The proposed 9.0.0.M1 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M1

Only tested the build/unit tests so far: builds on Linux.

Interesting to note that tcnative 1.2.x "requires" OpenSSL 1.0.2 - and
says so during "configure", but does not fail to configure/build/run. Is
1.0.2 truly a requirement? If so, the build probably ought to break.

* Environment
*  Java (build): java version "1.8.0_60" Java(TM) SE Runtime
Environment (build 1.8.0_60-b27) Java HotSpot(TM) 64-Bit Server VM
(build 25.60-b23, mixed mode)
*  Java (test): java version "1.8.0_60" Java(TM) SE Runtime
Environment (build 1.8.0_60-b27) Java HotSpot(TM) 64-Bit Server VM
(build 25.60-b23, mixed mode)
*  OS:   Linux 2.6.32-312-ec2 x86_64
*  cc:   cc (Debian 4.7.2-5) 4.7.2
*  make: GNU Make 3.81
*  OpenSSL:  OpenSSL 1.0.1e 11 Feb 2013
*  APR:  1.4.6
*
* Valid MD5 signature for apache-tomcat-9.0.0.M1.zip
* Valid GPG signature for apache-tomcat-9.0.0.M1.zip
* Valid MD5 signature for apache-tomcat-9.0.0.M1.tar.gz
* Valid GPG signature for apache-tomcat-9.0.0.M1.tar.gz
* Valid MD5 signature for apache-tomcat-9.0.0.M1.exe
* Valid GPG signature for apache-tomcat-9.0.0.M1.exe
* Valid MD5 signature for apache-tomcat-9.0.0.M1-src.zip
* Valid GPG signature for apache-tomcat-9.0.0.M1-src.zip
* Valid MD5 signature for apache-tomcat-9.0.0.M1-src.tar.gz
* Valid GPG signature for apache-tomcat-9.0.0.M1-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
*
* Tests that failed:
* org.apache.catalina.session.TestStandardSessionIntegration.APR.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
* org.apache.tomcat.util.http.TestMimeHeadersIntegration.NIO2.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt

The tribes stuff always fails for me. The OpenSSL ciphers tests are
almost certainly due to version mismatch/configuration mismatch. Session
tests fail because some of those tests require clustering (which I

Re: A step by step guide to try out the HTTP/2 feature in tomcat9

2015-11-16 Thread Christopher Schultz
Huxing,

On 11/16/15 3:14 AM, Huxing Zhang wrote:
> Following is a step by step guide for those who are interested in trying out 
> the HTTP/2 feature in tomcat9,
> Please correct me if anything is wrong.
> 
> Prerequisite:
> * JDK8: suppose you've already installed
> * tomcat 9.0.0.M1: 
> Please download from 
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M1/ 
> (a release candidate which is calling for votes.)
> * openssl 1.0.2d:
> For Unix:
> 1) build from source code:
> wget https://www.openssl.org/source/openssl-1.0.2d.tar.gz
> tar -xf openssl-1.0.2d.tar.gz
> cd openssl-1.0.2d
> ./config -fPIC --prefix=/path/to/openssl/
> make
> (sudo) make install
> 
> For Mac OSX
> 1) build from source code:
> wget https://www.openssl.org/source/openssl-1.0.2d.tar.gz
> tar -xf openssl-1.0.2d.tar.gz
> cd openssl-1.0.2d
> ./Configure darwin64-x86_64-cc --prefix=/path/to/openssl shared
> make
> (sudo) make install
> 2) obtain from brew (recommended, but not tried yet)

+1 for brew, though it wants to install a bunch of things that might
surprise you (I originally used to install gpg, I think). It *does*
allow you to install any number of OpenSSL versions side-by-side,
though. If you use brew to install multiple OpenSSLs, you'll want to
specify which one you are using when building tcnative. You'll want to
point --with-ssl at /usr/local/Cellar/openssl/[version]

Current version of OpenSSL available through Brew is 1.0.2d.

> * apr 1.4.0+ (latest version is 1.5.2)
> build apr 1.5.2 from scratch if not installed:
> download source code from https://apr.apache.org/download.cgi
> tar -xf apr-1.5.2.tar.gz
> cd apr-1.5.2
> ./configure
> make
> (sudo) make install
> * tomcat native 1.2.2 (require apr 1.4.0+)
> For Windows: 
> please download the binary release from 
> http://tomcat.apache.org/download-native.cgi
> or build from source code(not tried yet)
> 
> For Unix/Mac OSX
> download the source code from: http://tomcat.apache.org/download-native.cgi 
> tar -xf tomcat-native-1.2.2-src.tar.gz
> cd tomcat-native-1.2.2-src/native
> ./configure --with-apr=/path/to/apr --with-ssl=/path/to/openssl
> make
> (sudo) make install
> 
> * Genearte self-signed certificate:
> /path/to/openssl req -x509 -newkey rsa:2048 -keyout /var/tmp/private-key.pem 
> -out /var/tmp/cert.pem -days 365
> (with passphrase: tomcat)
> 
> Tomcat side configurations(APR connector)
> 1. configure setenv.sh
> CATALINA_OPTS="$CATALINA_OPTS -Djava.library.path=/path/to/your/tcnative/lib"
> 2. configure server.xml
>  protocol="org.apache.coyote.http11.Http11Nio2Protocol"
>maxThreads="150" SSLEnabled="true">
> 
> 
>   certificateFile="/var/tmp/cert.pem"
>  certificateKeyPassword="tomcat"
>  type="RSA" />
> 
> 
> 3. start tomcat
> 4. visit https://localhost:8443/examples/servlets/serverpush/simpleimage 
> You should see the image if everything is all right.
> 
> Tomcat side configurations(NIO/NIO2 connector, take NIO2 as an example)
> 1. configure server.xml
>  
> sslImplementationName="org.apache.tomcat.util.net.openssl.OpenSSLImplementation"
>maxThreads="150" SSLEnabled="true">
> 
> 
>   certificateFile="/var/tmp/cert.pem"
>  certificateKeyPassword="tomcat"
>  type="RSA" />
> 
> 
> 2. start tomcat
> 3. visit https://localhost:8443/examples/servlets/serverpush/simpleimage
> You should see the image if everything is all right.
> 
> NOTES:
> * HTTP/2 is not supported for non-secured protocol currently.

I'm no expert, but I thought that h2c was supported.

> * HTTP/2 is not supported for JSSE implementation currently.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Bug 58615] New: test

2015-11-16 Thread Mark Thomas
On 16/11/2015 20:25, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58615



>   Reporter: iambibek...@gmail.com

I've disabled this idiot's Bugzilla account.

> CC: t.takeuchi.t...@gmail.com

And this one too.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Ognjen Blagojevic

Mark,
Chris,

On 16.11.2015 17:15, Mark Thomas wrote:

Tomcat 8 docs lists APR Connector attribute "SSLCertificateChainFile"
[1]. Tomcat 9 docs, does not list such attribute (neither in "SSL
Support - SSLHostConfig", "SSL Support - Certificate" nor "SSL Support -
Connector - APR/Native (deprecated)"). I also check the class
SSLHostConfigCertificate, and couldn't find a field for the chain.


You use the same attribute as for the cert. i.e. you provide the full
chain rather than just the cert.


Ok, my initial testing was with the attribute SSLCertificateChainFile, 
which was deprecated.


Now I tried to add chain to server certificate file, but it does not 
work for me, either. I still get the warning that certificate chain is 
incomplete. I tried those two configurations, both of them serve only 
server cert:










File "cert-with-chain.pem" contains three certificates -- first the 
server certificate, and then two intermediate sertificates.


I also tried changing certificate order (first the intermediate 
certificates, then server cert) but that results with 
"error:0B080074:x509 certificate routines:X509_check_private_key:key 
values mismatch", so I guess server certificate must be the first one.


-Ognjen

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Christopher Schultz
Ognjen,

On 11/14/15 7:29 PM, Ognjen Blagojevic wrote:
>   * SSLTest also reports that APR/native does not serve full certificate
> chain; instead, it serves only server certificate. The same APR config
> serves full chain with Tomcat 8.0.28 + Native 1.2.2, so it seems to be a
> regression. Not serving full chain might be a problem for some clients
> -- browsers will probably work, but other clients may fail to establish
> TLS connection.

What is your TLS configuration?

>   * It seems that it is not possible anymore to use attribute "digest"
> in realms. It would be nice if that is mentioned in release
> announcement. I guess quite a number of people uses Realms with digest,
> and they will need to adjust the config before switching to 9.0.0.

"digest" should still work

>   * Tomcat 9 uses DBCP2, so attribute names for connection pool are
> different now (e.g. maxActive -> maxTotal). It would be nice to also add
> that to the announcement.

Tomcat 8 also uses DBCP2, and this is mentioned in the 7->8 guide:
http://tomcat.apache.org/migration-8.html#Database_Connection_Pooling

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58614] summary

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58614

bibek  changed:

   What|Removed |Added

 Resolution|INVALID |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58614] summary

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58614

mgrigorov  changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

--- Comment #1 from mgrigorov  ---
BugZilla is not playground. Please do not create such tickets! Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58614] summary

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58614

mgrigorov  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58615] New: test

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58615

Bug ID: 58615
   Summary: test
   Product: Tomcat 6
   Version: 6.0.44
  Hardware: PC
OS: Windows NT
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: iambibek...@gmail.com
CC: t.takeuchi.t...@gmail.com

test

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58615] test

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58615

Chuck Caldarale  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Chuck Caldarale  ---
Bugzilla is not a playground.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58610] Oracle DB connections not releasing from connection pool in Tomcat 8

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58610

Michael Osipov <1983-01...@gmx.net> changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Michael Osipov <1983-01...@gmx.net> ---
Oracle 10g is dead and out of support. Why are you still relying on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1714567 - /tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 12:01:18 2015
New Revision: 1714567

URL: http://svn.apache.org/viewvc?rev=1714567=rev
Log:
Convert test class to JUnit 4 and fix warnings

For a record:
The test testDataSendASYNC() is known to fail.
java.lang.AssertionError: Checking success messages. expected:<1> but 
was:<1576>
at org.junit.Assert.assertEquals(Assert.java:555)
at 
org.apache.catalina.tribes.test.channel.TestDataIntegrity.testDataSendASYNCM(TestDataIntegrity.java:127)

What is needed to fix it is TBD. In Tomcat 7 build.xml these tests are excluded 
from testsuite runs with



Modified:

tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java

Modified: 
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java?rev=1714567=1714566=1714567=diff
==
--- 
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
 (original)
+++ 
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
 Mon Nov 16 12:01:18 2015
@@ -16,15 +16,19 @@
  */
 package org.apache.catalina.tribes.test.channel;
 
-import junit.framework.TestCase;
 import java.io.Serializable;
-import java.util.Random;
 import java.util.Arrays;
+import java.util.Random;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
 import org.apache.catalina.tribes.ChannelListener;
 import org.apache.catalina.tribes.Member;
 import org.apache.catalina.tribes.group.GroupChannel;
-import org.apache.catalina.tribes.test.channel.TestDataIntegrity.Listener;
-import 
org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor;
 import 
org.apache.catalina.tribes.group.interceptors.MessageDispatch15Interceptor;
 
 /**
@@ -37,15 +41,16 @@ import org.apache.catalina.tribes.group.
  * @author not attributable
  * @version 1.0
  */
-public class TestDataIntegrity extends TestCase {
+public class TestDataIntegrity {
 int msgCount = 500;
 int threadCount = 20;
 GroupChannel channel1;
 GroupChannel channel2;
 Listener listener1;
 int threadCounter = 0;
-protected void setUp() throws Exception {
-super.setUp();
+
+@Before
+public void setUp() throws Exception {
 channel1 = new GroupChannel();
 channel1.addInterceptor(new MessageDispatch15Interceptor());
 channel2 = new GroupChannel();
@@ -56,17 +61,19 @@ public class TestDataIntegrity extends T
 channel2.start(GroupChannel.DEFAULT);
 }
 
-protected void tearDown() throws Exception {
-super.tearDown();
+@After
+public void tearDown() throws Exception {
 channel1.stop(GroupChannel.DEFAULT);
 channel2.stop(GroupChannel.DEFAULT);
 }
-
+
+@Test
 public void testDataSendNO_ACK() throws Exception {
 System.err.println("Starting NO_ACK");
 Thread[] threads = new Thread[threadCount];
 for (int x=0; x

Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-16 Thread Ognjen Blagojevic

Chris,

On 16.11.2015 23:06, Christopher Schultz wrote:

What is your TLS configuration?


Please look at my previous reply on this thread.



   * It seems that it is not possible anymore to use attribute "digest"
in realms. It would be nice if that is mentioned in release
announcement. I guess quite a number of people uses Realms with digest,
and they will need to adjust the config before switching to 9.0.0.


"digest" should still work


For me, it doesn't work [1]. It yields:

   org.apache.tomcat.util.digester.SetPropertiesRule.begin 
[SetPropertiesRule]{Context/Realm/Realm} Setting property 'digest' to 
'SHA-512' did not find a matching property.


The webapp is started, but I cannot log in. It works fine, however, with 
nested CredentialHandler [2].


-Ognjen


[1]
  
  
  

[2]
  
  
  className="org.apache.catalina.realm.MessageDigestCredentialHandler" 
algorithm="SHA-512" />


  


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58283] Change Base Path to use (user.home) instead of absolute path

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58283

Ahmed Hosni  changed:

   What|Removed |Added

 CC||ahmedhosni...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58143] The WebppClassLoader doesn't call transformers on cached classes

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58143

Ahmed Hosni  changed:

   What|Removed |Added

 CC||ahmedhosni...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58052] RewriteValve: Implement additional RewriteRule directive capabilities

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58052

Ahmed Hosni  changed:

   What|Removed |Added

 CC||ahmedhosni...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 58433] RemoteIpValve not activated on redirect from mapping

2015-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58433

Ahmed Hosni  changed:

   What|Removed |Added

 CC||ahmedhosni...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-11-16 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 42 mins 18 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151116-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20151116/lib 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151116.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151116-native-src.tar.gz
 -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -
 Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20151116/bin/openssl
 -Dexecute.test.apr=true -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina

svn commit: r1714537 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 10:26:13 2015
New Revision: 1714537

URL: http://svn.apache.org/viewvc?rev=1714537=rev
Log:
Update comment

Modified:
tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java?rev=1714537=1714536=1714537=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Mon Nov 16 
10:26:13 2015
@@ -127,7 +127,7 @@ public class Tomcat {
 // Some logging implementations use weak references for loggers so there is
 // the possibility that logging configuration could be lost if GC runs just
 // after Loggers are configured but before they are used. The purpose of
-// this Set is to retain strong references to explicitly configured loggers
+// this Map is to retain strong references to explicitly configured loggers
 // so that configuration is not lost.
 private final Map pinnedLoggers = new HashMap<>();
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1714540 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 10:33:06 2015
New Revision: 1714540

URL: http://svn.apache.org/viewvc?rev=1714540=rev
Log:
Fix changelog entry for BZ 58596

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Nov 16 10:33:06 2015
@@ -1,2 +1,2 @@
-/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712899,1712903,1712906,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059
+/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 

svn commit: r1714535 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java

2015-11-16 Thread markt
Author: markt
Date: Mon Nov 16 10:18:09 2015
New Revision: 1714535

URL: http://svn.apache.org/viewvc?rev=1714535=rev
Log:
OpenSSL now differentiations between TLSv1 (alias for SSLv3) and TLSv1.0 
(ciphers that require TLS 1.0)

Modified:

tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java?rev=1714535=1714534=1714535=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java
 (original)
+++ 
tomcat/trunk/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java
 Mon Nov 16 10:18:09 2015
@@ -446,9 +446,9 @@ public class OpenSSLCipherConfigurationP
 addListAlias(eFZA, filterByEncryption(allCiphers, 
Collections.singleton(Encryption.FZA)));
 addListAlias(FZA, filter(allCiphers, null, 
Collections.singleton(KeyExchange.FZA), 
Collections.singleton(Authentication.FZA), 
Collections.singleton(Encryption.FZA), null, null));
 addListAlias(Constants.SSL_PROTO_TLSv1_2, filterByProtocol(allCiphers, 
Collections.singleton(Protocol.TLSv1_2)));
-addListAlias(Constants.SSL_PROTO_TLSv1_1, filterByProtocol(allCiphers, 
Collections.singleton(Protocol.SSLv3)));
-addListAlias(Constants.SSL_PROTO_TLSv1, filterByProtocol(allCiphers, 
new HashSet<>(Arrays.asList(Protocol.TLSv1, Protocol.SSLv3;
-aliases.put(Constants.SSL_PROTO_SSLv3, 
aliases.get(Constants.SSL_PROTO_TLSv1));
+addListAlias(Constants.SSL_PROTO_TLSv1_0, filterByProtocol(allCiphers, 
Collections.singleton(Protocol.TLSv1)));
+addListAlias(Constants.SSL_PROTO_SSLv3, filterByProtocol(allCiphers, 
Collections.singleton(Protocol.SSLv3)));
+aliases.put(Constants.SSL_PROTO_TLSv1, 
aliases.get(Constants.SSL_PROTO_SSLv3));
 addListAlias(Constants.SSL_PROTO_SSLv2, filterByProtocol(allCiphers, 
Collections.singleton(Protocol.SSLv2)));
 addListAlias(DH, filterByKeyExchange(allCiphers, new 
HashSet<>(Arrays.asList(KeyExchange.DHr, KeyExchange.DHd, KeyExchange.EDH;
 Set adh = filterByKeyExchange(allCiphers, 
Collections.singleton(KeyExchange.EDH));



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1714538 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2015-11-16 Thread kkolinko
Author: kkolinko
Date: Mon Nov 16 10:30:41 2015
New Revision: 1714538

URL: http://svn.apache.org/viewvc?rev=1714538=rev
Log:
Fix changelog entry for BZ 58596

Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1714538=1714537=1714538=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Nov 16 10:30:41 2015
@@ -47,8 +47,10 @@
 
   
 
-  58596: Clarify the description in RUNNING.txt of how
-  environment variables are used. (markt)
+  
+58596: Clarify the description in RUNNING.txt of how
+environment variables are used. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



A step by step guide to try out the HTTP/2 feature in tomcat9

2015-11-16 Thread Huxing Zhang
Following is a step by step guide for those who are interested in trying out 
the HTTP/2 feature in tomcat9,
Please correct me if anything is wrong.

Prerequisite:
* JDK8: suppose you've already installed
* tomcat 9.0.0.M1: 
Please download from 
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M1/ 
(a release candidate which is calling for votes.)
* openssl 1.0.2d:
For Unix:
1) build from source code:
wget https://www.openssl.org/source/openssl-1.0.2d.tar.gz
tar -xf openssl-1.0.2d.tar.gz
cd openssl-1.0.2d
./config -fPIC --prefix=/path/to/openssl/
make
(sudo) make install

For Mac OSX
1) build from source code:
wget https://www.openssl.org/source/openssl-1.0.2d.tar.gz
tar -xf openssl-1.0.2d.tar.gz
cd openssl-1.0.2d
./Configure darwin64-x86_64-cc --prefix=/path/to/openssl shared
make
(sudo) make install
2) obtain from brew (recommended, but not tried yet)

* apr 1.4.0+ (latest version is 1.5.2)
build apr 1.5.2 from scratch if not installed:
download source code from https://apr.apache.org/download.cgi
tar -xf apr-1.5.2.tar.gz
cd apr-1.5.2
./configure
make
(sudo) make install
* tomcat native 1.2.2 (require apr 1.4.0+)
For Windows: 
please download the binary release from 
http://tomcat.apache.org/download-native.cgi
or build from source code(not tried yet)

For Unix/Mac OSX
download the source code from: http://tomcat.apache.org/download-native.cgi 
tar -xf tomcat-native-1.2.2-src.tar.gz
cd tomcat-native-1.2.2-src/native
./configure --with-apr=/path/to/apr --with-ssl=/path/to/openssl
make
(sudo) make install

* Genearte self-signed certificate:
/path/to/openssl req -x509 -newkey rsa:2048 -keyout /var/tmp/private-key.pem 
-out /var/tmp/cert.pem -days 365
(with passphrase: tomcat)

Tomcat side configurations(APR connector)
1. configure setenv.sh
CATALINA_OPTS="$CATALINA_OPTS -Djava.library.path=/path/to/your/tcnative/lib"
2. configure server.xml






3. start tomcat
4. visit https://localhost:8443/examples/servlets/serverpush/simpleimage 
You should see the image if everything is all right.

Tomcat side configurations(NIO/NIO2 connector, take NIO2 as an example)
1. configure server.xml
 





2. start tomcat
3. visit https://localhost:8443/examples/servlets/serverpush/simpleimage
You should see the image if everything is all right.

NOTES:
* HTTP/2 is not supported for non-secured protocol currently.
* HTTP/2 is not supported for JSSE implementation currently.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: A step by step guide to try out the HTTP/2 feature in tomcat9

2015-11-16 Thread Mark Thomas
On 17 November 2015 00:49:00 GMT+00:00, Huxing Zhang 
 wrote:
>Chris,
>
>>> NOTES:
>>> * HTTP/2 is not supported for non-secured protocol currently.
>
>> I'm no expert, but I thought that h2c was supported.
>
>Actually I tried to configure HTTP/2 in non-secured connector, the
>configuration I tried in server.xml is as follows:
>
>protocol="org.apache.coyote.http11.Http11AprProtocol"
>   connectionTimeout="2"
>   redirectPort="8443" >
>  
>
>
>When tomcat started, I observed the following log:
>17-Nov-2015 08:35:20.149 INFO [main]
>org.apache.coyote.http11.AbstractHttp11Protocol.configureUpgradeProtocol
>The ["http-apr-8080"] connector has been configured to support HTTP
>upgrade to [h2c]
>
>However, when I tried the server push example:
>http://localhost:8080/examples/servlets/serverpush/simpleimage
>
>The following error occurred:
>
>java.lang.UnsupportedOperationException: Server push requests are not
>supported by the HTTP/1.1 protocol
>   
> org.apache.coyote.http11.Http11Processor.action(Http11Processor.java:937)
>   org.apache.coyote.Request.action(Request.java:392)
>   http2.SimpleImagePush.doGet(SimpleImagePush.java:37)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:622)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
>   
> org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)
>
>Am I missing something?
>
>Best Regards,
>Huxing
>--
>From:Christopher Schultz 
>Time:2015 Nov 17 (Tue) 06:44
>To:Tomcat Developers List 
>Subject:Re: A step by step guide to try out the HTTP/2 feature in
>tomcat9
>
>
>Huxing,
>
>On 11/16/15 3:14 AM, Huxing Zhang wrote:
>> Following is a step by step guide for those who are interested in
>trying out the HTTP/2 feature in tomcat9,
>> Please correct me if anything is wrong.
>> 
>> Prerequisite:
>> * JDK8: suppose you've already installed
>> * tomcat 9.0.0.M1: 
>> Please download from
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M1/ 
>> (a release candidate which is calling for votes.)
>> * openssl 1.0.2d:
>> For Unix:
>> 1) build from source code:
>> wget https://www.openssl.org/source/openssl-1.0.2d.tar.gz
>> tar -xf openssl-1.0.2d.tar.gz
>> cd openssl-1.0.2d
>> ./config -fPIC --prefix=/path/to/openssl/
>> make
>> (sudo) make install
>> 
>> For Mac OSX
>> 1) build from source code:
>> wget https://www.openssl.org/source/openssl-1.0.2d.tar.gz
>> tar -xf openssl-1.0.2d.tar.gz
>> cd openssl-1.0.2d
>> ./Configure darwin64-x86_64-cc --prefix=/path/to/openssl shared
>> make
>> (sudo) make install
>> 2) obtain from brew (recommended, but not tried yet)
>
>+1 for brew, though it wants to install a bunch of things that might
>surprise you (I originally used to install gpg, I think). It *does*
>allow you to install any number of OpenSSL versions side-by-side,
>though. If you use brew to install multiple OpenSSLs, you'll want to
>specify which one you are using when building tcnative. You'll want to
>point --with-ssl at /usr/local/Cellar/openssl/[version]
>
>Current version of OpenSSL available through Brew is 1.0.2d.
>
>> * apr 1.4.0+ (latest version is 1.5.2)
>> build apr 1.5.2 from scratch if not installed:
>> download source code from https://apr.apache.org/download.cgi
>> tar -xf apr-1.5.2.tar.gz
>> cd apr-1.5.2
>> ./configure
>> make
>> (sudo) make install
>> * tomcat native 1.2.2 (require apr 1.4.0+)
>> For Windows: 
>> please download the binary release from
>http://tomcat.apache.org/download-native.cgi
>> or build from source code(not tried yet)
>> 
>> For Unix/Mac OSX
>> download the source code from:
>http://tomcat.apache.org/download-native.cgi 
>> tar -xf tomcat-native-1.2.2-src.tar.gz
>> cd tomcat-native-1.2.2-src/native
>> ./configure --with-apr=/path/to/apr --with-ssl=/path/to/openssl
>> make
>> (sudo) make install
>> 
>> * Genearte self-signed certificate:
>> /path/to/openssl req -x509 -newkey rsa:2048 -keyout
>/var/tmp/private-key.pem -out /var/tmp/cert.pem -days 365
>> (with passphrase: tomcat)
>> 
>> Tomcat side configurations(APR connector)
>> 1. configure setenv.sh
>> CATALINA_OPTS="$CATALINA_OPTS
>-Djava.library.path=/path/to/your/tcnative/lib"
>> 2. configure server.xml
>> protocol="org.apache.coyote.http11.Http11Nio2Protocol"
>>maxThreads="150" SSLEnabled="true">
>> className="org.apache.coyote.http2.Http2Protocol" />
>> 
>> certificateKeyFile="/var/tmp/private-key.pem"
>>  certificateFile="/var/tmp/cert.pem"
>>  certificateKeyPassword="tomcat"
>>  type="RSA" />
>> 
>> 
>> 3. start tomcat
>> 4. visit