[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2016-09-27 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 53 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20160928.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.5-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20160928.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20160928.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-20.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 7.2-SNAPSHOT on 3086 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/changelog.xml:175: Line 
matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:534: Got 1 errors and 0 
warnings.

Total time: 53 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2016092841, vmgump.apache.org:vmgump:2016092841
Gump E-mail Identifier (unique within run) #6.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2016-09-27 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 53 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20160928.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.5-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20160928.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20160928.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-20.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.2-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 7.2-SNAPSHOT on 3012 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-8.0.x/webapps/docs/changelog.xml:171: Line 
matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-8.0.x/build.xml:545: Got 1 errors and 0 
warnings.

Total time: 52 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2016092841, vmgump.apache.org:vmgump:2016092841
Gump E-mail Identifier (unique within run) #5.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60164] Add log4j-web*.jar to tomcat.util.scan.StandardJarScanFilter.jarsToScan

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60164

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Thomas  ---
This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards
- 8.0.x for 8.0.38 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762543 - in /tomcat/tc8.0.x/trunk: ./ conf/catalina.properties webapps/docs/changelog.xml

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 19:11:57 2016
New Revision: 1762543

URL: http://svn.apache.org/viewvc?rev=1762543=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60164
Replace log4j-core*.jar with log4j-web*.jar since it is log4j-web*.jar that 
contains the ServletContainerInitializer

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/conf/catalina.properties
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 27 19:11:57 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452

svn commit: r1762542 - in /tomcat/tc8.5.x/trunk: ./ conf/catalina.properties webapps/docs/changelog.xml

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 19:11:30 2016
New Revision: 1762542

URL: http://svn.apache.org/viewvc?rev=1762542=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60164
Replace log4j-core*.jar with log4j-web*.jar since it is log4j-web*.jar that 
contains the ServletContainerInitializer

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/conf/catalina.properties
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 27 19:11:30 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503,1762505

svn commit: r1762541 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 19:10:47 2016
New Revision: 1762541

URL: http://svn.apache.org/viewvc?rev=1762541=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60164
Replace log4j-core*.jar with log4j-web*.jar since it is log4j-web*.jar that 
contains the ServletContainerInitializer

Modified:
tomcat/trunk/conf/catalina.properties
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/conf/catalina.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.properties?rev=1762541=1762540=1762541=diff
==
--- tomcat/trunk/conf/catalina.properties (original)
+++ tomcat/trunk/conf/catalina.properties Tue Sep 27 19:10:47 2016
@@ -139,7 +139,7 @@ xom-*.jar
 # The list of JARs to scan may be over-ridden at a Context level for individual
 # scan types by configuring a JarScanner with a nested JarScanFilter.
 tomcat.util.scan.StandardJarScanFilter.jarsToScan=\
-log4j-core*.jar,log4j-taglib*.jar,log4javascript*.jar,slf4j-taglib*.jar
+log4j-web*.jar,log4j-taglib*.jar,log4javascript*.jar,slf4j-taglib*.jar
 
 # String cache configuration.
 tomcat.util.buf.StringCache.byte.enabled=true

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1762541=1762540=1762541=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 27 19:10:47 2016
@@ -169,6 +169,11 @@
   
 Update the download location for Objenesis. (violetagg)
   
+  
+60164: Replace log4j-core*.jar with
+log4j-web*.jar since it is log4j-web*.jar 
that
+contains the ServletContainerInitializer. (markt) 
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60164] Add log4j-web*.jar to tomcat.util.scan.StandardJarScanFilter.jarsToScan

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60164

--- Comment #2 from Mark Thomas  ---
I've checked the 2.0 release and it is consistent with the latest version so
the proposed change makes sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762540 - in /tomcat/jk/trunk: native/iis/Makefile.amd64 native/iis/Makefile.x86 xdocs/miscellaneous/changelog.xml

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 19:00:58 2016
New Revision: 1762540

URL: http://svn.apache.org/viewvc?rev=1762540=rev
Log:
Align make files for x86 and x64

Modified:
tomcat/jk/trunk/native/iis/Makefile.amd64
tomcat/jk/trunk/native/iis/Makefile.x86
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/iis/Makefile.amd64
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/Makefile.amd64?rev=1762540=1762539=1762540=diff
==
--- tomcat/jk/trunk/native/iis/Makefile.amd64 (original)
+++ tomcat/jk/trunk/native/iis/Makefile.amd64 Tue Sep 27 19:00:58 2016
@@ -13,12 +13,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# Microsoft Developer Studio Generated NMAKE File, Based on isapi.dsp
-# Use Platform SDK:
-# SetEnv.cmd /X64 /RETAIL
-# nmake -f Makefile.amd64
-#
-
 TARGET=isapi_redirect$(SO_VERSION)
 
 CPP=cl.exe
@@ -30,8 +24,16 @@ INTDIR=.\Release_amd64
 OutDir=.\Release_amd64
 # End Custom Macros
 
+!IF "$(RECURSE)" == "0"
+
+ALL : "$(OUTDIR)\$(TARGET).dll"
+
+!ELSE
+
 ALL : "pcre_amd64" "$(OUTDIR)\$(TARGET).dll"
 
+!ENDIF
+
 !IF "$(RECURSE)" == "1"
 CLEAN :"pcre_amd64CLEAN"
 !ELSE
@@ -111,7 +113,7 @@ LINK32_OBJS= \
IF EXIST $(OUTDIR)\$(TARGET).manifest \
mt -nologo -manifest $(OUTDIR)\$(TARGET).manifest 
-outputresource:$(OUTDIR)\$(TARGET).dll;2
 
-CPP_PROJ=-nologo -MD -W3 -O2 -Ob2 -Oy- -Zi -EHsc /I "..\common" /I "pcre" /D 
"WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_AMD64_=1" -DWIN64 /D "_WIN64" /D 
"PCRE_STATIC" /D "JK_ISAPI" /D "ISAPI_EXPORTS" $(CFLAGS) /Fo"$(INTDIR)\\" 
/Fd"$(INTDIR)\isapi_redirector_src" /FD /c
+CPP_PROJ=-nologo -MD -W3 -O2 -Ob2 -Oy- -Zi -EHsc /I "..\common" /I "pcre" 
$(CFLAGS) /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_AMD64_=1" -DWIN64 /D 
"_WIN64" /D "PCRE_STATIC" /D "JK_ISAPI" /D "ISAPI_EXPORTS" /Fo"$(INTDIR)\\" 
/Fd"$(INTDIR)\isapi_redirector_src" /FD /c
 
 .c{$(INTDIR)}.obj::
$(CPP) @<<

Modified: tomcat/jk/trunk/native/iis/Makefile.x86
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/Makefile.x86?rev=1762540=1762539=1762540=diff
==
--- tomcat/jk/trunk/native/iis/Makefile.x86 (original)
+++ tomcat/jk/trunk/native/iis/Makefile.x86 Tue Sep 27 19:00:58 2016
@@ -24,21 +24,21 @@ INTDIR=.\Release_x86
 OutDir=.\Release_x86
 # End Custom Macros
 
-!IF "$(RECURSE)" == "0" 
+!IF "$(RECURSE)" == "0"
 
 ALL : "$(OUTDIR)\$(TARGET).dll"
 
-!ELSE 
+!ELSE
 
 ALL : "pcre_x86" "$(OUTDIR)\$(TARGET).dll"
 
-!ENDIF 
+!ENDIF
 
-!IF "$(RECURSE)" == "1" 
-CLEAN :"pcre_x86CLEAN" 
-!ELSE 
+!IF "$(RECURSE)" == "1"
+CLEAN :"pcre_x86CLEAN"
+!ELSE
 CLEAN :
-!ENDIF 
+!ENDIF
-@erase "$(INTDIR)\jk.res"
-@erase "$(INTDIR)\isapi_redirector_src.idb"
-@erase "$(INTDIR)\isapi_redirector_src.pdb"
@@ -73,11 +73,11 @@ CLEAN :
 if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"
 
 BSC32=bscmake.exe
-BSC32_FLAGS=/nologo /o"$(OUTDIR)\isapi.bsc" 
+BSC32_FLAGS=/nologo /o"$(OUTDIR)\isapi.bsc"
 BSC32_SBRS= \
-   
+
 LINK32=link.exe
-LINK32_FLAGS=kernel32.lib user32.lib advapi32.lib ws2_32.lib mswsock.lib 
strsafe.lib $(EXTRA_LIBS) /nologo /base:"0x6A6B" /dll /incremental:no 
/pdb:"$(OUTDIR)\$(TARGET).pdb" /debug /machine:I386 /def:".\isapi.def" 
/out:"$(OUTDIR)\$(TARGET).dll" /implib:"$(OUTDIR)\isapi_redirect.lib" 
+LINK32_FLAGS=kernel32.lib user32.lib advapi32.lib ws2_32.lib mswsock.lib 
strsafe.lib $(EXTRA_LIBS) /nologo /base:"0x6A6B" /dll /incremental:no 
/pdb:"$(OUTDIR)\$(TARGET).pdb" /debug /machine:I386 /def:".\isapi.def" 
/out:"$(OUTDIR)\$(TARGET).dll" /implib:"$(OUTDIR)\isapi_redirect.lib"
 DEF_FILE= \
".\isapi.def"
 LINK32_OBJS= \
@@ -113,40 +113,40 @@ LINK32_OBJS= \
IF EXIST $(OUTDIR)\$(TARGET).manifest \
mt -nologo -manifest $(OUTDIR)\$(TARGET).manifest 
-outputresource:$(OUTDIR)\$(TARGET).dll;2
 
-CPP_PROJ=-nologo -MD -W3 -O2 -Ob2 -Oy- -Zi -EHsc /I "..\common" /I "pcre" 
$(CFLAGS) /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "PCRE_STATIC" /D "JK_ISAPI" 
/D "ISAPI_EXPORTS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\isapi_redirector_src" /FD /c 
+CPP_PROJ=-nologo -MD -W3 -O2 -Ob2 -Oy- -Zi -EHsc /I "..\common" /I "pcre" 
$(CFLAGS) /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "PCRE_STATIC" /D "JK_ISAPI" 
/D "ISAPI_EXPORTS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\isapi_redirector_src" /FD /c
 
 .c{$(INTDIR)}.obj::
$(CPP) @<<
-   $(CPP_PROJ) $< 
+   $(CPP_PROJ) $<
 <<
 
 .cpp{$(INTDIR)}.obj::
$(CPP) @<<
-   $(CPP_PROJ) $< 
+   $(CPP_PROJ) $<
 <<
 
 .cxx{$(INTDIR)}.obj::
$(CPP) @<<
-   $(CPP_PROJ) $< 
+   $(CPP_PROJ) $<
 <<
 
 .c{$(INTDIR)}.sbr::
$(CPP) @<<
-   $(CPP_PROJ) $< 
+   $(CPP_PROJ) $<
 <<
 
 .cpp{$(INTDIR)}.sbr::
$(CPP) @<<
-   $(CPP_PROJ) $< 
+   $(CPP_PROJ) $<
 <<
 
 .cxx{$(INTDIR)}.sbr::
$(CPP) @<<
-   $(CPP_PROJ) $< 
+   $(CPP_PROJ) $<
 <<

[Bug 60173] tomcat 8 fails with non standard HPACK receiver size

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60173

--- Comment #7 from Matt  ---
ditto, thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60173] tomcat 8 fails with non standard HPACK receiver size

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60173

--- Comment #6 from patrick mcmanus  ---
awesome. thank you. I'll update the firefox bug with the release info so
anybody tripping over it will know what they need to update to.

can I ask what happens if a client advertises >64KB? I'm assuming tomcat just
uses 64 and ignores the rest but wanted to ask.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762506 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/ConnectionSettingsBase.java

2016-09-27 Thread remm 
Author: remm
Date: Tue Sep 27 15:39:29 2016
New Revision: 1762506

URL: http://svn.apache.org/viewvc?rev=1762506=rev
Log:
Cleanup

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 27 15:39:29 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503

svn commit: r1762505 - /tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java

2016-09-27 Thread remm 
Author: remm
Date: Tue Sep 27 15:37:57 2016
New Revision: 1762505

URL: http://svn.apache.org/viewvc?rev=1762505=rev
Log:
Cleanup. 64*1024 ought to be enough for everybody.

Modified:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java

Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java?rev=1762505=1762504=1762505=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java Tue 
Sep 27 15:37:57 2016
@@ -35,6 +35,7 @@ public abstract class ConnectionSettings
 protected static final int MIN_MAX_FRAME_SIZE = 1 << 14;
 protected static final int MAX_MAX_FRAME_SIZE = (1 << 24) - 1;
 protected static final long UNLIMITED = ((long)1 << 32); // Use the 
maximum possible
+protected static final int MAX_HEADER_TABLE_SIZE = 1 << 16;
 
 // Defaults
 protected static final int DEFAULT_HEADER_TABLE_SIZE = 4096;
@@ -175,8 +176,7 @@ public abstract class ConnectionSettings
 
 
 private void validateHeaderTableSize(long headerTableSize) throws T {
-// Need to put a sensible limit on this. Start with 16k (default is 4k)
-if (headerTableSize > (64 * 1024)) {
+if (headerTableSize > MAX_HEADER_TABLE_SIZE) {
 String msg = 
sm.getString("connectionSettings.headerTableSizeLimit",
 connectionId, Long.toString(headerTableSize));
 throwException(msg, Http2Error.PROTOCOL_ERROR);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60173] tomcat 8 fails with non standard HPACK receiver size

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60173

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Remy Maucherat  ---
Tomcat will now support up to 64kB, it was previously harcoded to 16kB in a
slightly hidden fashion.

This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762504 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/ConnectionSettingsBase.java webapps/docs/changelog.xml

2016-09-27 Thread remm 
Author: remm
Date: Tue Sep 27 15:30:44 2016
New Revision: 1762504

URL: http://svn.apache.org/viewvc?rev=1762504=rev
Log:
60173: Allow up to 64kB header table size.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 27 15:30:44 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374

svn commit: r1762503 - in /tomcat/trunk: java/org/apache/coyote/http2/ConnectionSettingsBase.java webapps/docs/changelog.xml

2016-09-27 Thread remm 
Author: remm
Date: Tue Sep 27 15:26:16 2016
New Revision: 1762503

URL: http://svn.apache.org/viewvc?rev=1762503=rev
Log:
60173: Allow up to 64kB header table size. Hopefully this will not keep 
increasing indefinitely.

Modified:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java?rev=1762503=1762502=1762503=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java Tue 
Sep 27 15:26:16 2016
@@ -176,7 +176,7 @@ public abstract class ConnectionSettings
 
 private void validateHeaderTableSize(long headerTableSize) throws T {
 // Need to put a sensible limit on this. Start with 16k (default is 4k)
-if (headerTableSize > (16 * 1024)) {
+if (headerTableSize > (64 * 1024)) {
 String msg = 
sm.getString("connectionSettings.headerTableSizeLimit",
 connectionId, Long.toString(headerTableSize));
 throwException(msg, Http2Error.PROTOCOL_ERROR);

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1762503=1762502=1762503=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 27 15:26:16 2016
@@ -125,6 +125,9 @@
 60174: Log instances of 
HeadersTooLargeException
 during request processing. (markt)
   
+  
+60173: Allow up to 64kB HTTP/2 header table size limit. 
(remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] JK 1.2.42

2016-09-27 Thread Mark Thomas 
Tag:
http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_42/

Source:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/

This is a maintenance release with a handful of bug fixes. It also
includes Windows binaries for IIS.

The proposed JK 1.2.42 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 1.2.42


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762492 - /tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

2016-09-27 Thread violetagg 
Author: violetagg
Date: Tue Sep 27 14:20:14 2016
New Revision: 1762492

URL: http://svn.apache.org/viewvc?rev=1762492=rev
Log:
Use ByteBuffer instead of byte array. Use the new method for writing the data - 
 SocketWrapperBase.write(boolean, ByteBuffer).

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java?rev=1762492=1762491=1762492=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java Tue Sep 
27 14:20:14 2016
@@ -69,13 +69,7 @@ public class Http11OutputBuffer implemen
 /**
  * The buffer used for header composition.
  */
-protected final byte[] headerBuffer;
-
-
-/**
- * Position in the header buffer.
- */
-protected int pos;
+protected final ByteBuffer headerBuffer;
 
 
 /**
@@ -118,7 +112,7 @@ public class Http11OutputBuffer implemen
 
 this.response = response;
 
-headerBuffer = new byte[headerBufferSize];
+headerBuffer = ByteBuffer.allocate(headerBufferSize);
 
 filterLibrary = new OutputFilter[0];
 activeFilters = new OutputFilter[0];
@@ -250,7 +244,7 @@ public class Http11OutputBuffer implemen
  * headers so the error response can be written.
  */
 void resetHeaderBuffer() {
-pos = 0;
+headerBuffer.position(0);
 }
 
 
@@ -278,7 +272,7 @@ public class Http11OutputBuffer implemen
 // Recycle response object
 response.recycle();
 // Reset pointers
-pos = 0;
+headerBuffer.position(0);
 lastActiveFilter = -1;
 responseFinished = false;
 byteCount = 0;
@@ -328,9 +322,11 @@ public class Http11OutputBuffer implemen
 protected void commit() throws IOException {
 response.setCommitted(true);
 
-if (pos > 0) {
+if (headerBuffer.position() > 0) {
 // Sending the response header buffer
-socketWrapper.write(isBlocking(), headerBuffer, 0, pos);
+headerBuffer.flip();
+socketWrapper.write(isBlocking(), headerBuffer);
+headerBuffer.position(0).limit(headerBuffer.capacity());
 }
 }
 
@@ -341,7 +337,7 @@ public class Http11OutputBuffer implemen
 public void sendStatus() {
 // Write protocol name
 write(Constants.HTTP_11_BYTES);
-headerBuffer[pos++] = Constants.SP;
+headerBuffer.put(Constants.SP);
 
 // Write status code
 int status = response.getStatus();
@@ -359,14 +355,13 @@ public class Http11OutputBuffer implemen
 write(String.valueOf(status));
 }
 
-headerBuffer[pos++] = Constants.SP;
+headerBuffer.put(Constants.SP);
 
 // The reason phrase is optional but the space before it is not. Skip
 // sending the reason phrase. Clients should ignore it (RFC 7230) and 
it
 // just wastes bytes.
 
-headerBuffer[pos++] = Constants.CR;
-headerBuffer[pos++] = Constants.LF;
+headerBuffer.put(Constants.CR).put(Constants.LF);
 }
 
 
@@ -378,11 +373,9 @@ public class Http11OutputBuffer implemen
  */
 public void sendHeader(MessageBytes name, MessageBytes value) {
 write(name);
-headerBuffer[pos++] = Constants.COLON;
-headerBuffer[pos++] = Constants.SP;
+headerBuffer.put(Constants.COLON).put(Constants.SP);
 write(value);
-headerBuffer[pos++] = Constants.CR;
-headerBuffer[pos++] = Constants.LF;
+headerBuffer.put(Constants.CR).put(Constants.LF);
 }
 
 
@@ -390,8 +383,7 @@ public class Http11OutputBuffer implemen
  * End the header block.
  */
 public void endHeaders() {
-headerBuffer[pos++] = Constants.CR;
-headerBuffer[pos++] = Constants.LF;
+headerBuffer.put(Constants.CR).put(Constants.LF);
 }
 
 
@@ -437,8 +429,7 @@ public class Http11OutputBuffer implemen
 // Writing the byte chunk to the output buffer
 int length = bc.getLength();
 checkLengthBeforeWrite(length);
-System.arraycopy(bc.getBytes(), bc.getStart(), headerBuffer, pos, 
length);
-pos = pos + length;
+headerBuffer.put(bc.getBytes(), bc.getStart(), length);
 }
 
 
@@ -453,8 +444,7 @@ public class Http11OutputBuffer implemen
 checkLengthBeforeWrite(b.length);
 
 // Writing the byte chunk to the output buffer
-System.arraycopy(b, 0, headerBuffer, pos, b.length);
-pos = pos + b.length;
+headerBuffer.put(b);
 }
 
 
@@ -482,7 +472,7 @@ public class Http11OutputBuffer implemen
 if (((c <= 31) && (c != 9)) || c == 127 || c > 255) {
 c = ' ';

svn commit: r15756 - in /dev/tomcat/tomcat-connectors/jk: ./ binaries/

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 13:50:04 2016
New Revision: 15756

Log:
Upload Tomcat connectors 1.4.2 for voting

Added:
dev/tomcat/tomcat-connectors/jk/binaries/

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip
   (with props)

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.md5

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.sha1

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip
   (with props)

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.md5

dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.sha1
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz   (with 
props)
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.asc
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.md5
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.sha1
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip   (with 
props)
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.asc
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.md5
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.sha1

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip
==
Binary file - no diff available.

Propchange: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip
--
svn:mime-type = application/octet-stream

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.asc
==
--- 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.asc
 (added)
+++ 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.asc
 Tue Sep 27 13:50:04 2016
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCAAGBQJX6neaAAoJEBDAHFovYFnnnXwQAJWm5gr8Ey2hXWXV/eNw0ZdX
+P63cZH5m3z9vAUPkAPnuFJXwl/liJSdivCP4c0cxv1D5ZcFHxRhiBEJILmlvFSi1
+FLVKtyyGK/QpQdSDgS6tKxU6imHKOadbRKtJ29Io4JNcB0Z0ghWp9zti5dxnn6An
+FAWdPYhX1hO6hlXJ2SXPpn1mG0g54Y6UAPgic17H2pE0Zq2vKBuypWbVj9uYFNaF
+3zDgSkYpBHh4WeJqSzA/tj3UzcAHqPHzL9E9RoBk91XzK+p9uAbZlvAMNXCjAd16
+WkUYcMQ7frns+hFI3ZsKbUP88imBuuqdeUaUrNDUMqQw4JT6DbEkWSJ7PalB3c76
+VnM9Ol7lbVNZbFNPQkhSq5PVeJkibFwT4b2Exhyd1V/IOrrp4Usjw5CdqwFLZITS
+KQPZNf5xvb/XjrhCiAovtHUZO+Z8620FZNCuy7MEP0STVfrI7yJoIYXJzFMHTYjH
+DRBjtDssznAfkBfvyvT2I23adQILlIKGtNlRDSlA/yuaGwQW8UWD7xmb3pHDjQBO
+P1ChCWqtITCGK8IGZLW/TERrBZ3qcYa8wrBtY3vmizNK4s2CGRJo4bbrSvcOkPww
+G4Hgi4cYULzptYQkN6XHxfwgMkCs52PmBFBiK/4f4Yo60RNUaUnmoMqcicLZUCDJ
+WLyZBbONONpoKPkBBXum
+=Y3BN
+-END PGP SIGNATURE-

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.md5
==
--- 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.md5
 (added)
+++ 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.md5
 Tue Sep 27 13:50:04 2016
@@ -0,0 +1 @@
+27cc91d4f27fdfc2358b0ff3d3472d11 *tomcat-connectors-1.2.42-windows-i386-iis.zip
\ No newline at end of file

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.sha1
==
--- 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.sha1
 (added)
+++ 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.sha1
 Tue Sep 27 13:50:04 2016
@@ -0,0 +1 @@
+f0cd5b92fcaaf7eb3f0f0bd38be0d191e9a67822 
*tomcat-connectors-1.2.42-windows-i386-iis.zip
\ No newline at end of file

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip
==
Binary file - no diff available.

Propchange: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip
--
svn:mime-type = application/octet-stream

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.asc
==
---

[Bug 60161] RewriteValve: Add more logging support similar to mod-rewrite

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60161

--- Comment #11 from Santhana Preethi  ---
Any update regarding writing RewriteValve logs based on Remy Maucherat's patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762447 - in /tomcat/jk/tags/JK_1_2_42: ./ native/common/jk_version.h

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 11:05:11 2016
New Revision: 1762447

URL: http://svn.apache.org/viewvc?rev=1762447=rev
Log:
Tag 1.2.42

Added:
tomcat/jk/tags/JK_1_2_42/
  - copied from r1762446, tomcat/jk/trunk/
Modified:
tomcat/jk/tags/JK_1_2_42/native/common/jk_version.h

Modified: tomcat/jk/tags/JK_1_2_42/native/common/jk_version.h
URL: 
http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_42/native/common/jk_version.h?rev=1762447=1762446=1762447=diff
==
--- tomcat/jk/tags/JK_1_2_42/native/common/jk_version.h (original)
+++ tomcat/jk/tags/JK_1_2_42/native/common/jk_version.h Tue Sep 27 11:05:11 2016
@@ -29,7 +29,7 @@
 #define JK_VERFIX   42
 
 /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */
-#define JK_VERISRELEASE 0
+#define JK_VERISRELEASE 1
 /* Beta number */
 #define JK_VERBETA  0
 #define JK_BETASTRING   "0"



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762446 - in /tomcat/jk/trunk: native/iis/README native/netscape/README tools/dist/binaries/windows/README.html

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 11:03:05 2016
New Revision: 1762446

URL: http://svn.apache.org/viewvc?rev=1762446=rev
Log:
Version number updates prior to tagging

Modified:
tomcat/jk/trunk/native/iis/README
tomcat/jk/trunk/native/netscape/README
tomcat/jk/trunk/tools/dist/binaries/windows/README.html

Modified: tomcat/jk/trunk/native/iis/README
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/README?rev=1762446=1762445=1762446=diff
==
--- tomcat/jk/trunk/native/iis/README (original)
+++ tomcat/jk/trunk/native/iis/README Tue Sep 27 11:03:05 2016
@@ -37,7 +37,7 @@ The steps that you need to take are:
1. Change directory to the isapi redirector plugins source directory.

2. Execute the following command:
-  nmake -f Makefile.x86 [SO_VERSION=-1.2.41]
+  nmake -f Makefile.x86 [SO_VERSION=-1.2.42]
 
 An alternative will be to open the isapi workspace file (isapi.dsw) in msdev 
and 
 build it using the build menu.

Modified: tomcat/jk/trunk/native/netscape/README
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/netscape/README?rev=1762446=1762445=1762446=diff
==
--- tomcat/jk/trunk/native/netscape/README (original)
+++ tomcat/jk/trunk/native/netscape/README Tue Sep 27 11:03:05 2016
@@ -25,7 +25,7 @@ The steps that you need to take are:
   directory or edit the nsapi.dsp and replace all $(IPLANET_HOME)
   occurrences with the real path
3. Execute the following command:
-  nmake -f Makefile.vc [SO_VERSION=-1.2.41]
+  nmake -f Makefile.vc [SO_VERSION=-1.2.42]
 
 An alternative will be to open the isapi workspace file (nsapi.dsw) in msdev 
and
 build it using the build menu.

Modified: tomcat/jk/trunk/tools/dist/binaries/windows/README.html
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/tools/dist/binaries/windows/README.html?rev=1762446=1762445=1762446=diff
==
--- tomcat/jk/trunk/tools/dist/binaries/windows/README.html (original)
+++ tomcat/jk/trunk/tools/dist/binaries/windows/README.html Tue Sep 27 11:03:05 
2016
@@ -27,7 +27,7 @@
connector to fail.
 
 
-The current stable release is 1.2.41
+The current stable release is 1.2.42
 
 See the Apache Tomcat Connectors
 http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html;>changelog



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762443 - /tomcat/jk/trunk/xdocs/news/20150101.xml

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 10:57:11 2016
New Revision: 1762443

URL: http://svn.apache.org/viewvc?rev=1762443=rev
Log:
Add release date for 1.2.41 release

Modified:
tomcat/jk/trunk/xdocs/news/20150101.xml

Modified: tomcat/jk/trunk/xdocs/news/20150101.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/news/20150101.xml?rev=1762443=1762442=1762443=diff
==
--- tomcat/jk/trunk/xdocs/news/20150101.xml (original)
+++ tomcat/jk/trunk/xdocs/news/20150101.xml Tue Sep 27 10:57:11 2016
@@ -30,7 +30,7 @@
 
 
 
-
+
 The Apache Tomcat team is proud to announce the immediate availability
of Tomcat Connectors 1.2.41. This is a maintenance and security 
release.
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762442 - in /tomcat/jk/trunk/xdocs: index.xml news/20160901.xml

2016-09-27 Thread markt 
Author: markt
Date: Tue Sep 27 10:54:59 2016
New Revision: 1762442

URL: http://svn.apache.org/viewvc?rev=1762442=rev
Log:
Add preliminary info for 1.2.42 release

Added:
tomcat/jk/trunk/xdocs/news/20160901.xml   (with props)
Modified:
tomcat/jk/trunk/xdocs/index.xml

Modified: tomcat/jk/trunk/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/index.xml?rev=1762442=1762441=1762442=diff
==
--- tomcat/jk/trunk/xdocs/index.xml (original)
+++ tomcat/jk/trunk/xdocs/index.xml Tue Sep 27 10:54:59 2016
@@ -63,12 +63,12 @@ manual is described in more detail below
 
 
 
-JK-1.2.41 
released
+JK-1.2.42 
released
 The Apache Tomcat team is proud to announce the immediate availability
-   of Tomcat Connectors 1.2.41 Stable. This release contains a security fix and
-   bug fixes for issues found in previous releases.
+   of Tomcat Connectors 1.2.42 Stable. This release contains bug fixes for
+   issues found in previous releases.

-Download the JK 1.2.41
+Download the JK 1.2.42
release.
 
 

Added: tomcat/jk/trunk/xdocs/news/20160901.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/news/20160901.xml?rev=1762442=auto
==
--- tomcat/jk/trunk/xdocs/news/20160901.xml (added)
+++ tomcat/jk/trunk/xdocs/news/20160901.xml Tue Sep 27 10:54:59 2016
@@ -0,0 +1,47 @@
+
+
+
+]>
+
+
+  
+
+  
+Apache Tomcat Connectors 
Project
+2016 News  Status
+  
+
+
+
+
+
+The Apache Tomcat team is proud to announce the immediate availability
+   of Tomcat Connectors 1.2.42. This is a maintenance release.
+
+Please see the ChangeLog
+   for a full list of changes.
+
+If you find any bugs while using this release, please fill in the
+https://bz.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%20Connectors;>Bugzilla
+Bug Report.
+
+
+
+
+

Propchange: tomcat/jk/trunk/xdocs/news/20160901.xml
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Time for JK 1.2.42 ?

2016-09-27 Thread Mark Thomas 
On 14/09/2016 19:09, Mark Thomas wrote:
> On 13/09/2016 09:27, Mark Thomas wrote:
>> All,
>>
>> It has been over 12 months since the 1.2.41 release and the changelog
>> contains some important fixes. I think it is time to start thinking
>> about a 1.2.42 release.
>>
>> I took a first pass through the open bug reports yesterday and resolved
>> the really obvious / simple ones. Any help with the remaining bugs would
>> be much appreciated.
>>
>> Would anyone like to take on the release manager role for this?
> 
> Ping :)

I guess that is a no.

Quite a few bugs have been fixed in the last few weeks and while we
could wait to fix a few more first, I think it makes sense to roll a new
release now. With that in mind I'll tag and start the release process
later today.

Mark


> 
>> As a
>> source only release, it is fairly simple. If we want to provide the
>> ISAPI binaries then it would be more work.
> 
> Good news on the binaries front. I tried building the ISAPI DLL using
> the same tool chain as we used for TC Native and it appears to work. I
> need to document the minor tweaks required but it appears to be good
> news that Visual Studio 6 is not required.
> 
> Mark
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

--- Comment #8 from Mark Thomas  ---
Debug logs may contain security sensitive data and should be used and protected
accordingly.

I am -1 on any form of filtering of debug logs. The whole point of debug
logging is to show you exactly what is going on. If Tomcat starts filtering
debug logs it could well filter out the critical information required to solve
an issue.

If Tomcat was logging security sensitive information by default then there
would be a stronger case for making a change. I'll note that in such a case,
the change would likely be to log that information at debug level.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

--- Comment #7 from Markus  ---
Would it be so bad to parse the parameters for known sensitive ones? In such
cases you could filter those out. Question is - is it easily recognizable that
it's a logon request? If so, you might call a specialized routine, which is
parsing the parameters and masks them if necessary

Best regards,
Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

--- Comment #6 from Remy Maucherat  ---
For starters, the log you pointed out in your report is simply a full dump of
the unparsed parameters as bytes. As a result, it cannot be filtered without
parsing it first, so the only option if there's a decision to fix it is to
remove that log.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

--- Comment #5 from Markus  ---
Hi, 

@Remy: didn't know that it is considered rude to re-open a bug, if I'm not
satisfied with the solution. But if it is like that I continue to discuss
without re-opening. Please excuse my wrong behavior.
I'm not saying that you need to recognize arbitrary parameters that might
contain sensitive data. But IMHO the ones that are well-known to tomcat should
be masked. Yes, it's only when turning on trace at a higher level, but this is
still a bad thing. Assume that not only the affected person is reading the logs
- this means that a second one would immediately see that password, even
without bad intentions this is not a good thing. Please consider revising your
decision

Best regards,
Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

Remy Maucherat  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #4 from Remy Maucherat  ---
Excuse me, but why is it that every single user out there feels entitled to
reopening reports all the time ? Do you not realize this is rude ? I gave an
explanation, discussion can still occur but as it is this is the current
resolution.

There is generic debug logging like this in a lot of places in Tomcat
(parameters, obviously, cookies, request line, etc). All of them can contain
sensitive data and are strictly for debug purposes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

--- Comment #3 from mgrigorov  ---
The problem here is how to recognize that a request parameter contains
sensitive information.
'j_password' is name defined in specs, so it is easy to handle.
But an application is free to use any names for its form elements and it is
impossible for the web server to decide whether something contains sensitive
data or not.
So hiding the value of `j_password` is a very special case that would solve
just some of the cases.

On the other side someone may want to see the plain value of such parameter to
be able to debug an issue related to the authentication.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

Markus  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #2 from Markus  ---
Hi, 

yes, it's not the default logging settings. But sometimes you need to check why
a logon is not working and increase the levels for tomcat loggers. Then I still
don't want to see a password logged in clear text. Someone who should not see
it could see it.

Best regards,
Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #1 from Remy Maucherat  ---
This is simply logging request parameters, and is not the default logging
configuration. I do not understand why this logging would be enabled on a
production server.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60178] New: password is logged in clear text

2016-09-27 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60178

Bug ID: 60178
   Summary: password is logged in clear text
   Product: Tomcat 7
   Version: 7.0.69
  Hardware: PC
OS: Windows NT
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: markus.tolksd...@sap.com

Hi, 

there is a trace entry that is logging the password in clear text. This should
not be done. If the user is DonaldDuck and the password is ILoveDa1sy the entry
looks like this with our custom formatter:
2016-06-01
14:57:28,329#DEBUG#org.apache.tomcat.util.http.Parameters#http-bio-443-exec-11#
 #Start processing with input
[j_username=DonaldDuck_password=ILoveDa1sy]|

Could you please fix this? Thanks!

Best regards,
Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2016-09-27 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 13 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 35 mins 21 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160927-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160927.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160927-native-src
 .tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true 
-Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160927/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace