Re: Host header validation

2017-03-28 Thread Katya Todorova
On Tue, Mar 28, 2017 at 5:45 PM, Mark Thomas wrote: > On 28/03/17 15:23, Katya Todorova wrote: > > Hi, > >> r1787662 adds Host header validation along with a fair number of unit > tests. > >> It includes a performance test which indicates - on my machine at least > >> - that

[Bug 60362] Missing reason phrase in response

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #48 from Violeta Georgieva --- Hi, (In reply to Michael Osipov from comment #47) > (In reply to Violeta Georgieva from comment #45) > > Hi, > > > > A new Connector configuration 'sendReasonPhrase' is added.

svn commit: r1789226 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/Constants.java

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 21:12:41 2017 New Revision: 1789226 URL: http://svn.apache.org/viewvc?rev=1789226=rev Log: Use Boolean#getBoolean when reading the system property. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1789222 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/Constants.java

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 21:09:41 2017 New Revision: 1789222 URL: http://svn.apache.org/viewvc?rev=1789222=rev Log: Use Boolean#getBoolean when reading the system property. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1789216 - /tomcat/tc8.5.x/trunk/java/org/apache/coyote/Constants.java

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 21:00:55 2017 New Revision: 1789216 URL: http://svn.apache.org/viewvc?rev=1789216=rev Log: Use Boolean#getBoolean when reading the system property. Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/Constants.java Modified:

svn commit: r1789201 - in /tomcat/tc6.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 19:41:26 2017 New Revision: 1789201 URL: http://svn.apache.org/viewvc?rev=1789201=rev Log: Increment version for next dev cycle Modified: tomcat/tc6.0.x/trunk/build.properties.default tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default

[VOTE] Release Apache Tomcat 6.0.52

2017-03-28 Thread Violeta Georgieva
The proposed Apache Tomcat 6.0.52 release is now available for voting. Note: This is the last Tomcat 6 release. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.52/ The Maven staging repo is:

svn commit: r18941 [2/2] - in /dev/tomcat/tomcat-6/v6.0.52: ./ bin/ bin/extras/ src/

2017-03-28 Thread violetagg
Added: dev/tomcat/tomcat-6/v6.0.52/src/apache-tomcat-6.0.52-src.tar.gz.asc == --- dev/tomcat/tomcat-6/v6.0.52/src/apache-tomcat-6.0.52-src.tar.gz.asc (added) +++

svn commit: r18941 [1/2] - in /dev/tomcat/tomcat-6/v6.0.52: ./ bin/ bin/extras/ src/

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 19:36:28 2017 New Revision: 18941 Log: Stage 6.0.52 RC Added: dev/tomcat/tomcat-6/v6.0.52/ dev/tomcat/tomcat-6/v6.0.52/KEYS dev/tomcat/tomcat-6/v6.0.52/README.html dev/tomcat/tomcat-6/v6.0.52/RELEASE-NOTES dev/tomcat/tomcat-6/v6.0.52/bin/

svn commit: r1789197 - in /tomcat/tc8.5.x/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlet4preview/http/ webapps/docs/ webapps/examples/WEB-IN

2017-03-28 Thread markt
Author: markt Date: Tue Mar 28 19:12:32 2017 New Revision: 1789197 URL: http://svn.apache.org/viewvc?rev=1789197=rev Log: Update the early access Servlet 4.0 API implementation to reflect the change in method name from getPushBuilder() to newPushBuilder() Modified:

svn commit: r1789184 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ test/org/apache/catalina/filters/

2017-03-28 Thread markt
Author: markt Date: Tue Mar 28 18:42:05 2017 New Revision: 1789184 URL: http://svn.apache.org/viewvc?rev=1789184=rev Log: Update the Servlet 4.0 API implementation to reflect the change in method name from getPushBuilder() to newPushBuilder() Modified:

svn commit: r1789179 - in /tomcat/tc6.0.x/tags/TOMCAT_6_0_52: ./ build.properties.default

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 17:01:00 2017 New Revision: 1789179 URL: http://svn.apache.org/viewvc?rev=1789179=rev Log: Tag 6.0.52 Added: tomcat/tc6.0.x/tags/TOMCAT_6_0_52/ (props changed) - copied from r1789178, tomcat/tc6.0.x/trunk/ Modified:

svn commit: r1789178 - /tomcat/tc6.0.x/trunk/build.properties.default

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 16:57:43 2017 New Revision: 1789178 URL: http://svn.apache.org/viewvc?rev=1789178=rev Log: prepare for release Modified: tomcat/tc6.0.x/trunk/build.properties.default Modified: tomcat/tc6.0.x/trunk/build.properties.default URL:

svn commit: r1789176 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 16:48:58 2017 New Revision: 1789176 URL: http://svn.apache.org/viewvc?rev=1789176=rev Log: Increment version for next dev cycle Modified: tomcat/tc7.0.x/trunk/build.properties.default tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default

[VOTE] Release Apache Tomcat 7.0.77

2017-03-28 Thread Violeta Georgieva
The proposed Apache Tomcat 7.0.77 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.77/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1128/ The svn tag is:

svn commit: r18939 [1/2] - in /dev/tomcat/tomcat-7/v7.0.77: ./ bin/ bin/embed/ bin/extras/ src/

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 16:44:29 2017 New Revision: 18939 Log: Stage 7.0.77 RC Added: dev/tomcat/tomcat-7/v7.0.77/ dev/tomcat/tomcat-7/v7.0.77/KEYS dev/tomcat/tomcat-7/v7.0.77/README.html dev/tomcat/tomcat-7/v7.0.77/RELEASE-NOTES dev/tomcat/tomcat-7/v7.0.77/bin/

svn commit: r18939 [2/2] - in /dev/tomcat/tomcat-7/v7.0.77: ./ bin/ bin/embed/ bin/extras/ src/

2017-03-28 Thread violetagg
Added: dev/tomcat/tomcat-7/v7.0.77/bin/extras/catalina-jmx-remote.jar.sha1 == --- dev/tomcat/tomcat-7/v7.0.77/bin/extras/catalina-jmx-remote.jar.sha1 (added) +++

svn commit: r1789168 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_77: ./ build.properties.default

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 15:45:23 2017 New Revision: 1789168 URL: http://svn.apache.org/viewvc?rev=1789168=rev Log: Tag 7.0.77 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_77/ (props changed) - copied from r1789164, tomcat/tc7.0.x/trunk/ Modified:

svn commit: r1789164 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 15:34:59 2017 New Revision: 1789164 URL: http://svn.apache.org/viewvc?rev=1789164=rev Log: Increment version for next dev cycle Modified: tomcat/tc8.0.x/trunk/build.properties.default tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default

[VOTE] Release Apache Tomcat 8.0.43

2017-03-28 Thread Violeta Georgieva
The proposed Apache Tomcat 8.0.43 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1127/ The svn tag is:

svn commit: r18938 [1/2] - in /dev/tomcat/tomcat-8/v8.0.43: ./ bin/ bin/embed/ bin/extras/ src/

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 15:26:54 2017 New Revision: 18938 Log: Stage 8.0.43 RC Added: dev/tomcat/tomcat-8/v8.0.43/ dev/tomcat/tomcat-8/v8.0.43/KEYS dev/tomcat/tomcat-8/v8.0.43/README.html dev/tomcat/tomcat-8/v8.0.43/RELEASE-NOTES dev/tomcat/tomcat-8/v8.0.43/bin/

svn commit: r18938 [2/2] - in /dev/tomcat/tomcat-8/v8.0.43: ./ bin/ bin/embed/ bin/extras/ src/

2017-03-28 Thread violetagg
Added: dev/tomcat/tomcat-8/v8.0.43/bin/extras/catalina-ws.jar.asc == --- dev/tomcat/tomcat-8/v8.0.43/bin/extras/catalina-ws.jar.asc (added) +++ dev/tomcat/tomcat-8/v8.0.43/bin/extras/catalina-ws.jar.asc Tue Mar 28

[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927 Huxing Zhang changed: What|Removed |Added Resolution|--- |WONTFIX

[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927 --- Comment #3 from Huxing Zhang --- (In reply to Mark Thomas from comment #2) > It has been this way since the class was first introduced some 8+ years ago. I don't know that exists for so long time until you

buildbot success in on tomcat-6-trunk

2017-03-28 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-6-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-6-trunk/builds/217 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1789155 - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/Http11AprProcessor.java coyote/http11/Http11AprProtocol.java coyote/http11/Http11NioProtocol.java tomcat/util/net/AprEndp

2017-03-28 Thread markt
Author: markt Date: Tue Mar 28 14:47:56 2017 New Revision: 1789155 URL: http://svn.apache.org/viewvc?rev=1789155=rev Log: Follow-up to r1789024 Need to add socket/processor to connection cache when sendfile is in progress so pipe-lined request is processed Add syncs to AprEndpoint so that only

Re: Host header validation

2017-03-28 Thread Mark Thomas
On 28/03/17 15:23, Katya Todorova wrote: > Hi, >> r1787662 adds Host header validation along with a fair number of unit tests. >> It includes a performance test which indicates - on my machine at least >> - that the performance impact is in the noise. I'd like to see better >> performance for full

svn commit: r1789153 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_43: ./ build.properties.default

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 14:38:21 2017 New Revision: 1789153 URL: http://svn.apache.org/viewvc?rev=1789153=rev Log: Tag 8.0.43 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_43/ (props changed) - copied from r1789148, tomcat/tc8.0.x/trunk/ Modified:

Re: Host header validation

2017-03-28 Thread Katya Todorova
Hi, > r1787662 adds Host header validation along with a fair number of unit tests. > It includes a performance test which indicates - on my machine at least > - that the performance impact is in the noise. I'd like to see better > performance for full IPv6 addresses but the current code looks to

svn commit: r1789144 - /tomcat/tc8.0.x/tags/TOMCAT_8_0_43/

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 14:02:47 2017 New Revision: 1789144 URL: http://svn.apache.org/viewvc?rev=1789144=rev Log: Drop the tag in order to pick up a fix for javadoc Removed: tomcat/tc8.0.x/tags/TOMCAT_8_0_43/ -

svn commit: r1789143 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 13:59:17 2017 New Revision: 1789143 URL: http://svn.apache.org/viewvc?rev=1789143=rev Log: Fix javadoc Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Propchange:

svn commit: r1789140 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 13:56:54 2017 New Revision: 1789140 URL: http://svn.apache.org/viewvc?rev=1789140=rev Log: Fix javadoc Modified: tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified:

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

2017-03-28 Thread Rémy Maucherat
2017-03-27 14:56 GMT+02:00 Mark Thomas : > The proposed Apache Tomcat 9.0.0.M19 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not

svn commit: r1789129 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_43: ./ build.properties.default

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 13:13:13 2017 New Revision: 1789129 URL: http://svn.apache.org/viewvc?rev=1789129=rev Log: Tag 8.0.43 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_43/ (props changed) - copied from r1789126, tomcat/tc8.0.x/trunk/ Modified:

svn commit: r1789126 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 13:06:57 2017 New Revision: 1789126 URL: http://svn.apache.org/viewvc?rev=1789126=rev Log: prepare for release Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1789095 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java

2017-03-28 Thread markt
Author: markt Date: Tue Mar 28 11:02:29 2017 New Revision: 1789095 URL: http://svn.apache.org/viewvc?rev=1789095=rev Log: Follow-up to r1788999 Need to add socket/processor to connection cache so pipe-lined request is processed Modified:

buildbot success in on tomcat-8-trunk

2017-03-28 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/971 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 60926] Servlet 4 method ApplicationContextFacade.setSessionTimeout() calls wrong method

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60926 Violeta Georgieva changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1789090 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationContextFacade.java webapps/docs/changelog.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 10:34:46 2017 New Revision: 1789090 URL: http://svn.apache.org/viewvc?rev=1789090=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60926 Ensure ApplicationContextFacade#setSessionTimeout will invoke the correct method when running Tomcat with

[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927 --- Comment #2 from Mark Thomas --- It has been this way since the class was first introduced some 8+ years ago. Users have always been able to change the names if they wish to do so. Experience has shown that changing the

svn commit: r1789085 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java

2017-03-28 Thread markt
Author: markt Date: Tue Mar 28 10:20:54 2017 New Revision: 1789085 URL: http://svn.apache.org/viewvc?rev=1789085=rev Log: Follow-up to r1788999 Need to add socket/processor to connection cache so pipe-lined request is processed Modified:

[Bug 60926] Servlet 4 method ApplicationContextFacade.setSessionTimeout() calls wrong method

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60926 Konstantin Kolinko changed: What|Removed |Added Resolution|INVALID |---

[Bug 60362] Missing reason phrase in response

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #47 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Violeta Georgieva from comment #45) > Hi, > > A new Connector configuration 'sendReasonPhrase' is added. When this > attribute is set to 'true', a reason phrase will be

Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-28 Thread Violeta Georgieva
Hi, 2017-03-27 18:13 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.13 release is now available for voting. > > The major changes compared to the 8.5.12 release are: > > - Various HTTP/2 improvements > > - Fixes for sendfile related issues that could cause subsequent

[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927 --- Comment #1 from Huxing Zhang --- One of the workaround might be: 1) call javax.management.MBeanServer#queryNames('*:type=Server', null) to get a set of possible object names. 2) iterate through all the possible

svn commit: r1789065 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2017-03-28 Thread remm
Author: remm Date: Tue Mar 28 08:15:05 2017 New Revision: 1789065 URL: http://svn.apache.org/viewvc?rev=1789065=rev Log: Better blocking for async IO. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified:

buildbot failure in on tomcat-8-trunk

2017-03-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/970 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 60926] Servlet 4 method ApplicationContextFacade.setSessionTimeout() calls wrong method

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60926 Violeta Georgieva changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1789055 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/config/systemprops.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 07:04:13 2017 New Revision: 1789055 URL: http://svn.apache.org/viewvc?rev=1789055=rev Log: A "space" in the property name is used in order to keep the "Property" column at some specified width. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1789054 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/config/systemprops.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 06:59:15 2017 New Revision: 1789054 URL: http://svn.apache.org/viewvc?rev=1789054=rev Log: A "space" in the property name is used in order to keep the "Property" column at some specified width. Modified: tomcat/tc8.0.x/trunk/ (props changed)

[Bug 60927] New: JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927 Bug ID: 60927 Summary: JMX domain name for embed tomcat is inconsistent with standard tomcat Product: Tomcat 9 Version: 9.0.0.M18 Hardware: All OS: All

svn commit: r1789052 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/config/systemprops.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 06:52:18 2017 New Revision: 1789052 URL: http://svn.apache.org/viewvc?rev=1789052=rev Log: A "space" in the property name is used in order to keep the "Property" column at some specified width. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1789051 - /tomcat/trunk/webapps/docs/config/systemprops.xml

2017-03-28 Thread violetagg
Author: violetagg Date: Tue Mar 28 06:45:23 2017 New Revision: 1789051 URL: http://svn.apache.org/viewvc?rev=1789051=rev Log: A "space" in the property name is used in order to keep the "Property" column at some specified width. Modified: tomcat/trunk/webapps/docs/config/systemprops.xml