[Bug 61171] Add port offset attribute (portOffset?) to Server configuration in server.xml

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61171

--- Comment #1 from Igal Sapir  ---
Please see https://github.com/apache/tomcat/pull/63

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #63: added portOffset attribute to server.xml per BZ-611...

[isapir]

GitHub user isapir opened a pull request:

https://github.com/apache/tomcat/pull/63

added portOffset attribute to server.xml per BZ-61171

https://bz.apache.org/bugzilla/show_bug.cgi?id=61171

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/isapir/tomcat BZ-61171b

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit f4e487789df9c98082dc18578adcd3fc79d6db49
Author: Igal Sapir 
Date:   2017-06-10T06:10:26Z

added portOffset attribute to server.xml per BZ-61171

https://bz.apache.org/bugzilla/show_bug.cgi?id=61171




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1028

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1798284
Blamelist: violetagg

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1798285 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/context.xml

[violetagg]

Author: violetagg
Date: Fri Jun  9 21:24:56 2017
New Revision: 1798285

URL: http://svn.apache.org/viewvc?rev=1798285&view=rev
Log:
Correct typo in Context Container Configuration Reference. Patch provided by 
Katya Todorova.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc7.0.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jun  9 21:24:56 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523
 
/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698,1744706,1745228,1746940,1748548,1748716,1749288,1749375,1749668-1749669,1750016,1750057,1750976,1751000,1751062,1751098,1754112,175414

svn commit: r1798284 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/context.xml

[violetagg]

Author: violetagg
Date: Fri Jun  9 21:23:21 2017
New Revision: 1798284

URL: http://svn.apache.org/viewvc?rev=1798284&view=rev
Log:
Correct typo in Context Container Configuration Reference. Patch provided by 
Katya Todorova.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jun  9 21:23:21 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687

svn commit: r1798282 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/context.xml

[violetagg]

Author: violetagg
Date: Fri Jun  9 21:18:28 2017
New Revision: 1798282

URL: http://svn.apache.org/viewvc?rev=1798282&view=rev
Log:
Correct typo in Context Container Configuration Reference. Patch provided by 
Katya Todorova.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jun  9 21:18:28 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 
8,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,

[GitHub] tomcat pull request #62: Fix config context.xml documentation about jndiExce...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/62


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1798280 - in /tomcat/trunk/webapps/docs: changelog.xml config/context.xml

[violetagg]

Author: violetagg
Date: Fri Jun  9 21:15:26 2017
New Revision: 1798280

URL: http://svn.apache.org/viewvc?rev=1798280&view=rev
Log:
Correct typo in Context Container Configuration Reference. Patch provided by 
Katya Todorova via GitHub.

This closes #62

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/context.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1798280&r1=1798279&r2=1798280&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Jun  9 21:15:26 2017
@@ -185,6 +185,10 @@
 @EJB annotation in the annotations API. Patch provided by
 Katya Todorova. (markt)
   
+  
+Correct typo in Context Container Configuration Reference.
+Patch provided by Katya Todorova. (violetagg)
+  
 
   
 

Modified: tomcat/trunk/webapps/docs/config/context.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/context.xml?rev=1798280&r1=1798279&r2=1798280&view=diff
==
--- tomcat/trunk/webapps/docs/config/context.xml (original)
+++ tomcat/trunk/webapps/docs/config/context.xml Fri Jun  9 21:15:26 2017
@@ -763,7 +763,7 @@
 createSubContext(), destroySubContext() or close() will trigger a
 javax.naming.OperationNotSupportedException as required by
 section EE.5.3.4 of the Java EE specification. This exception can be
-disabled by setting this attribute to true in which case any calls to
+disabled by setting this attribute to false in which case any calls to
 modify the JNDI context will return without making any changes
 and methods that return values will return null. If not
 specified, the specification compliant default of true 
will



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61105] Roll log files by default

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61105

--- Comment #7 from Violeta Georgieva  ---
Hi,

(In reply to Konstantin Kolinko from comment #5)
> (In reply to Violeta Georgieva from comment #3)
> > Hi,
> > 
> > What do you think about this approach?
> > https://github.com/apache/tomcat/pull/60
> > 
> 
> +public static final int DEFAULT_MAX_DAYS = 90;
> +private int maxDays = DEFAULT_MAX_DAYS;
> 
> I do not like the idea of built-in default limit in java code.
> 
> I am open to discuss whether it is feasible for Tomcat 9,
> but such built-in limit cannot be backported to stable versions (8.5 and
> earlier).
> 
> I think it is better to add limits explicitly to the default
> logging.properties configuration.
> 
> 
> +String sMaxDays = getProperty(className + ".maxDays",
> String.valueOf(DEFAULT_MAX_DAYS));
> +if (maxDays <= 0) {
> +try {
> +maxDays = Integer.parseInt(sMaxDays);
> +} catch (NumberFormatException ignore) {
> +// no-op
> +}
> +}
> 
> I think the above try/catch block is never executed, as "if (maxDays <= 0)"
> is always false, as maxDays is "90" by default.
> 
> +private DirectoryStream streamFilesForDelete() throws IOException
> {
> +FileTime maxDaysOffset = FileTime.from(Instant.now().minus(maxDays,
> ChronoUnit.DAYS));
> +return Files.newDirectoryStream(new File(directory).toPath(), path
> -> {
> +String fileName = path.getFileName().toString();
> +return fileName.startsWith(prefix) && fileName.endsWith(suffix)
> +&&
> Files.getLastModifiedTime(path).compareTo(maxDaysOffset) < 0;
> +});
> +}
> 
> I do not like the above.
> 
> 1. "fileName.startsWith(prefix)" will result in false positives.
> 
> 2. I'd prefer to test the date in the file name, not file modification date.
> 
> 
> BTW, for access logs I usually have an empty prefix, grouping the files into
> separate directories by month:
> fileDateFormat="-MM'/webappname.'-MM-dd"
> prefix=""
> suffix=".access.log"
> 
> Such feature is not implemented for JULI logging yet. If it were, the
> "fileName.startsWith(prefix)" here would be true for every file.

Thanks for the review. I prepared a new patch where I applied all your
recommendations. Can you take a look at it?

Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #62: Fix config context.xml documentation about jndiExce...

[katya-stoycheva]

GitHub user katya-stoycheva opened a pull request:

https://github.com/apache/tomcat/pull/62

Fix config context.xml documentation about jndiExceptionOnFailedWrite



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/katya-stoycheva/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 97cd679036dc0b6ec68ebcc10a569bfaf0cef08a
Author: Katya Todorova 
Date:   2017-06-09T20:39:16Z

Fix config context.xml documentation about jndiExceptionOnFailedWrite




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: RFE idea: Add port offset system property to Tomcat

[Coty Sutherland]

On Fri, Jun 9, 2017 at 12:53 PM, Igal @ Lucee.org  wrote:
> Hi,
>
> On 6/9/2017 9:47 AM, Mark Thomas wrote:
>>
>> On 09/06/2017 17:34, Romain Manni-Bucau wrote:
>>>
>>> @Mark: guess you are thinking to server.xml?
>>
>> Yes.
>>
>>> then it would have placeholder
>>> support so still a system property somehow no?
>>
>> It would have placeholder support (as do all attributes in server.xml)
>> so yes, system properties could be used - with a small edit to
>> server.xml. It would have to be on Server.
>
>
> If you open a ticket and think that it's appropriate, please tag it as
> "Beginner".

I created https://bz.apache.org/bugzilla/show_bug.cgi?id=61171. I'm
not sure what degree of difficulty this is, so I'll let mark or
someone else tag it if appropriate.

> Thanks,
>
>
> Igal
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61171] New: Add port offset attribute (portOffset?) to Server configuration in server.xml

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61171

Bug ID: 61171
   Summary: Add port offset attribute (portOffset?) to Server
configuration in server.xml
   Product: Tomcat 9
   Version: unspecified
  Hardware: PC
OS: Linux
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: csuth...@redhat.com
  Target Milestone: -

An option that would allow users to set a port offset in the configuration (or
with a system property) would be great for creating new instances on the same
machine. Such an option would prevent the need for manually updating the
connectors, etc in the server.xml for each new installation on the same host.
With this option in place, users could simply unzip multiple installs and then
start each with a different offset out of the box rather than updating multiple
places in the server.xml.

As an example of the implementation, setting the option to 100 would
add 100 to all port bindings on the server (e.g. with a vanilla
install it would cause tomcat to run on 8105, 8180, and 8109 rather than 8005,
8180, and 8009). It should also be noted that this same offset should apply to
ALL port bindings and references, include the redirectPort.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: RFE idea: Add port offset system property to Tomcat

[Igal @ Lucee.org]

Hi,

On 6/9/2017 9:47 AM, Mark Thomas wrote:

On 09/06/2017 17:34, Romain Manni-Bucau wrote:

@Mark: guess you are thinking to server.xml?

Yes.


then it would have placeholder
support so still a system property somehow no?

It would have placeholder support (as do all attributes in server.xml)
so yes, system properties could be used - with a small edit to
server.xml. It would have to be on Server.


If you open a ticket and think that it's appropriate, please tag it as 
"Beginner".


Thanks,


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: RFE idea: Add port offset system property to Tomcat

[Mark Thomas]

On 09/06/2017 17:34, Romain Manni-Bucau wrote:
> @Mark: guess you are thinking to server.xml?

Yes.

> then it would have placeholder
> support so still a system property somehow no?

It would have placeholder support (as do all attributes in server.xml)
so yes, system properties could be used - with a small edit to
server.xml. It would have to be on Server.

Mark

> 
> +1 anyway, sounds very useful!
> 
> 
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  |
> LinkedIn  | JavaEE Factory
> 
> 
> 2017-06-09 18:32 GMT+02:00 Mark Thomas :
> 
>> On 09/06/2017 16:31, Coty Sutherland wrote:
>>> Hi all,
>>>
>>> I was just doing some testing and got had an idea for spinning up new
>>> instances of tomcat. JBoss has this system property
>>> "-Djboss.socket.binding.port-offset" that I think would be useful for
>>> tomcat. As en example, setting the property to 100 on startup would
>>> add "100" to all port bindings on the server (e.g. with a vanilla
>>> install it would cause tomcat to run on 8105, 8180, and 8109). This
>>> prevents uses from having to use a fancy sed (or whatever Windows has)
>>> to update the port bindings for every new install. Does anyone else
>>> see any value to adding this feature?
>>
>> I like the idea a lot - apart from the system property part. Would this
>> still be as useful if it wasn't a system property?
>>
>> Mark
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: package trailers does not exist

[Igal @ Lucee.org]

On 6/9/2017 1:46 AM, Mark Thomas wrote:

On 08/06/17 22:59, Igal @ Lucee.org wrote:

When I set the `test` directory as a Test root dir in IntelliJ IDEA, I
get errors like:

E:\Workspace\git\tomcat\test\org\apache\coyote\http2\TestStream.java
Error:(33, 16) java: package trailers does not exist

Can anyone tell me where `trailers` is coming from?

The examples web application.


Thanks, Mark!

I added webapps/examples/WEB-INF/classes as a "Test Sources Root" and 
now it works.



Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: RFE idea: Add port offset system property to Tomcat

[Coty Sutherland]

On Fri, Jun 9, 2017 at 12:32 PM, Mark Thomas  wrote:
> On 09/06/2017 16:31, Coty Sutherland wrote:
>> Hi all,
>>
>> I was just doing some testing and got had an idea for spinning up new
>> instances of tomcat. JBoss has this system property
>> "-Djboss.socket.binding.port-offset" that I think would be useful for
>> tomcat. As en example, setting the property to 100 on startup would
>> add "100" to all port bindings on the server (e.g. with a vanilla
>> install it would cause tomcat to run on 8105, 8180, and 8109). This
>> prevents uses from having to use a fancy sed (or whatever Windows has)
>> to update the port bindings for every new install. Does anyone else
>> see any value to adding this feature?
>
> I like the idea a lot - apart from the system property part. Would this
> still be as useful if it wasn't a system property?

Yeah, sure. I think the biggest benefit is not having to manually
configure all the ports, so it could be an env var in the startup
script or some other setting somewhere. JBoss has a sysprop, so I'm
used to starting it that way, but if you like another method let me
know, I'll open an enhancement request and give it a shot.

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: RFE idea: Add port offset system property to Tomcat

[Mark Thomas]

On 09/06/2017 16:31, Coty Sutherland wrote:
> Hi all,
> 
> I was just doing some testing and got had an idea for spinning up new
> instances of tomcat. JBoss has this system property
> "-Djboss.socket.binding.port-offset" that I think would be useful for
> tomcat. As en example, setting the property to 100 on startup would
> add "100" to all port bindings on the server (e.g. with a vanilla
> install it would cause tomcat to run on 8105, 8180, and 8109). This
> prevents uses from having to use a fancy sed (or whatever Windows has)
> to update the port bindings for every new install. Does anyone else
> see any value to adding this feature?

I like the idea a lot - apart from the system property part. Would this
still be as useful if it wasn't a system property?

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: RFE idea: Add port offset system property to Tomcat

[Romain Manni-Bucau]

@Mark: guess you are thinking to server.xml? then it would have placeholder
support so still a system property somehow no?

+1 anyway, sounds very useful!


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-06-09 18:32 GMT+02:00 Mark Thomas :

> On 09/06/2017 16:31, Coty Sutherland wrote:
> > Hi all,
> >
> > I was just doing some testing and got had an idea for spinning up new
> > instances of tomcat. JBoss has this system property
> > "-Djboss.socket.binding.port-offset" that I think would be useful for
> > tomcat. As en example, setting the property to 100 on startup would
> > add "100" to all port bindings on the server (e.g. with a vanilla
> > install it would cause tomcat to run on 8105, 8180, and 8109). This
> > prevents uses from having to use a fancy sed (or whatever Windows has)
> > to update the port bindings for every new install. Does anyone else
> > see any value to adding this feature?
>
> I like the idea a lot - apart from the system property part. Would this
> still be as useful if it wasn't a system property?
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[Bug 61154] The manager applications don't start when using the Security Manager

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61154

--- Comment #5 from Mark Thomas  ---
b) is required if the class loader hierarchy is expanded to the 5.5.x structure
where common, shared and catalina class loaders are all separate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61134] Unexpected [ ] in public text on default error pages

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61134

Violeta Georgieva  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Violeta Georgieva  ---
Hi,

I applied a patch provided by Katya Todorova via GitHub PR#61.
Fixed in:
- trunk for 9.0.0.M22 onwards
- 8.5.x for 8.5.16 onwards

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1798239 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/ webapps/docs/

[violetagg]

Author: violetagg
Date: Fri Jun  9 15:54:17 2017
New Revision: 1798239

URL: http://svn.apache.org/viewvc?rev=1798239&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
Do not use '[' and ']' symbols around substituted text fragments when 
generating the default error pages. Patch provided by Katya Todorova via GitHub.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings.properties

tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties

tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties

tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jun  9 15:54:17 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 
8,1762172,176218

[GitHub] tomcat pull request #61: [Bug 61134] remove [] around text substitutes for d...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/61


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1798238 - in /tomcat/trunk: java/org/apache/catalina/valves/ webapps/docs/

[violetagg]

Author: violetagg
Date: Fri Jun  9 15:50:59 2017
New Revision: 1798238

URL: http://svn.apache.org/viewvc?rev=1798238&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
Do not use '[' and ']' symbols around substituted text fragments when 
generating the default error pages. Patch provided by Katya Todorova via GitHub.

This closes #61

Modified:
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties?rev=1798238&r1=1798237&r2=1798238&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties Fri 
Jun  9 15:50:59 2017
@@ -29,7 +29,9 @@ accessLogValve.invalidPortType=Invalid p
 accessLogValve.writeFail=Failed to write log message [{0}]
 
 # Error report valve
-errorReportValve.statusHeader=HTTP Status [{0}] \u2013 [{1}]
+# Default error page should not have '[' ']' symbols around substituted text 
fragments.
+# https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
+errorReportValve.statusHeader=HTTP Status {0} \u2013 {1}
 errorReportValve.type=Type
 errorReportValve.exceptionReport=Exception Report
 errorReportValve.statusReport=Status Report

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties?rev=1798238&r1=1798237&r2=1798238&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties Fri 
Jun  9 15:50:59 2017
@@ -17,7 +17,9 @@ accessLogValve.closeFail = No pude cerra
 accessLogValve.openDirFail = No pude crear directorio [{0}] para historiales 
de acceso
 accessLogValve.rotateFail = No pude rotar historial de acceso
 # Error report valve
-errorReportValve.statusHeader = Estado HTTP [{0}] \u2013 [{1}]
+# Default error page should not have '[' ']' symbols around substituted text 
fragments.
+# https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
+errorReportValve.statusHeader = Estado HTTP {0} \u2013 {1}
 errorReportValve.type=Tipo
 errorReportValve.exceptionReport = Informe de Excepci\u00F3n
 errorReportValve.statusReport = Informe de estado

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties?rev=1798238&r1=1798237&r2=1798238&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties Fri 
Jun  9 15:50:59 2017
@@ -14,7 +14,9 @@
 # limitations under the License.
 
 # Error report valve
-errorReportValve.statusHeader=\u00c9tat HTTP [{0}] \u2013 [{1}]
+# Default error page should not have '[' ']' symbols around substituted text 
fragments.
+# https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
+errorReportValve.statusHeader=\u00c9tat HTTP {0} \u2013 {1}
 errorReportValve.type=Type
 errorReportValve.exceptionReport=Rapport d''exception
 errorReportValve.statusReport=Rapport d''\u00e9tat

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties?rev=1798238&r1=1798237&r2=1798238&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties Fri 
Jun  9 15:50:59 2017
@@ -15,7 +15,9 @@
 
 
jdbcAccessLogValve.exception=\u30a2\u30af\u30bb\u30b9\u30a8\u30f3\u30c8\u30ea\u306e\u633f\u5165\u3092\u5b9f\u884c\u4e2d\u306e\u4f8b\u5916\u3067\u3059
 # Error report valve
-errorReportValve.statusHeader=HTTP\u30b9\u30c6\u30fc\u30bf\u30b9 [{0}] - [{1}]
+# Default error page should not have '[' ']' symbols around substituted text 
fragments.
+# https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
+errorReportValve.statusHeader=HTTP\u30b9\u30c6\u30fc\u30bf\u30b9 {0} - {1}
 
errorReportValve.statusReport=\u30b9\u30c6\u30fc\u30bf\u30b9\u30ec\u30dd\u30fc\u30c8
 errorReportValve.message=\u30e1\u30c3\

RFE idea: Add port offset system property to Tomcat

[Coty Sutherland]

Hi all,

I was just doing some testing and got had an idea for spinning up new
instances of tomcat. JBoss has this system property
"-Djboss.socket.binding.port-offset" that I think would be useful for
tomcat. As en example, setting the property to 100 on startup would
add "100" to all port bindings on the server (e.g. with a vanilla
install it would cause tomcat to run on 8105, 8180, and 8109). This
prevents uses from having to use a fancy sed (or whatever Windows has)
to update the port bindings for every new install. Does anyone else
see any value to adding this feature?



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: asyncError() is not valid while in Async state DISPATCHING

[Violeta Georgieva]

Hi,

2017-06-09 17:25 GMT+03:00 Mark Thomas :
>
> On 09/06/17 12:41, Mark Thomas wrote:
> > On 05/06/17 09:38, Violeta Georgieva wrote:
> >
> > 
> >
> >> Try with this test
> >>
https://github.com/violetagg/tomcat/commit/53564d4e73496cb3badcaaab81a1314cf2ed750d
> >
> > Thanks. That clarifies things a lot.
> >
> > It boils down to what should happen when an I/O error occurs reading
> > from the request or writing to the response on an non-container thread.
>
> 
>
> > I'm currently on the fence between calling this an application error
> > (the non-container thread should not call dispatch after an I/O error)
> > and trying to figure out if there is a way we could handle this.
> >
> > I'm currently looking at the code to see what the options might be. Did
> > you have a patch in mind? We also need to be careful that we don't end
> > up with multiple container threads trying to handle the same async
request.
>
> I've spent some time working through the various possible combinations
> of events and have concluded it is impossible to completely fix this
> without imposing additional requirements on applications that the
> specification doesn't mention.
>
> However, I believe that we can do better than the current
> implementation. What I have on mind would:
>
> - always trigger AsyncListener.onError() for all listeners
> - generally, process the complete() dispatch() call from the
>   AsyncListener rather than any from the non-container thread
> - generally, throw an ISE if complete() or dispatch() is called
>   from the non-container thread after that thread experiences an I/O
>error
> - leave a small timing window where it was possible that the complete()
>   or dispatch() from the non-container thread would be used rather than
>   from the AsyncListener. In that case the AsyncListener would see the
>   ISE but any remaining AsyncListener instances would still be called
>
> I don't see a way of doing better than this without spec changes /
> clarifications.
>
> WDYT?

+1
I'm able to test the new behavior with my real web app.

Thanks, Violeta

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

[Bug 61154] The manager applications don't start when using the Security Manager

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61154

--- Comment #4 from Konstantin Kolinko  ---
(In reply to Mark Thomas from comment #3)
> 
> My thinking so far has reached the point of wondering if the privileged flag
> on the context makes any sense at all when not running under a
> SecurityManager.

[1]
http://tomcat.apache.org/tomcat-8.5-doc/config/context.html#Common_Attributes

AFAIK, the "privileged" flag on Context has two effects [1]:

a) allow this context to use container servlets

b) change the context's parent class loader to be the Server class loader
rather than the Shared class loader

Anything else?


I think that the permission to use servlets ("a)") does not make sense when
running without SecurityManager.

An idea: replace it with an explicit Permission to access specific container
servlets? Manager web application needs only a subset of those servlets.


The classloader hierarchy effect ("b)") is important regardless of
SecurityManager, but there is no actual need for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #61: [Bug 61134] remove [] around text substitutes for d...

[katya-stoycheva]

GitHub user katya-stoycheva opened a pull request:

https://github.com/apache/tomcat/pull/61

[Bug 61134] remove [] around text substitutes for default error pages

partial revert of 
https://svn.apache.org/viewvc?view=revision&revision=1792132

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/katya-stoycheva/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #61


commit ae80ca599c220145f336e2836ee35d8299fb2902
Author: Katya Todorova 
Date:   2017-06-09T14:46:39Z

[Bug 61134] remove [] around text substitutes for default error pages 
(partial revert of r1792132)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: asyncError() is not valid while in Async state DISPATCHING

[Mark Thomas]

On 09/06/17 12:41, Mark Thomas wrote:
> On 05/06/17 09:38, Violeta Georgieva wrote:
> 
> 
> 
>> Try with this test
>> https://github.com/violetagg/tomcat/commit/53564d4e73496cb3badcaaab81a1314cf2ed750d
> 
> Thanks. That clarifies things a lot.
> 
> It boils down to what should happen when an I/O error occurs reading
> from the request or writing to the response on an non-container thread.



> I'm currently on the fence between calling this an application error
> (the non-container thread should not call dispatch after an I/O error)
> and trying to figure out if there is a way we could handle this.
> 
> I'm currently looking at the code to see what the options might be. Did
> you have a patch in mind? We also need to be careful that we don't end
> up with multiple container threads trying to handle the same async request.

I've spent some time working through the various possible combinations
of events and have concluded it is impossible to completely fix this
without imposing additional requirements on applications that the
specification doesn't mention.

However, I believe that we can do better than the current
implementation. What I have on mind would:

- always trigger AsyncListener.onError() for all listeners
- generally, process the complete() dispatch() call from the
  AsyncListener rather than any from the non-container thread
- generally, throw an ISE if complete() or dispatch() is called
  from the non-container thread after that thread experiences an I/O
   error
- leave a small timing window where it was possible that the complete()
  or dispatch() from the non-container thread would be used rather than
  from the AsyncListener. In that case the AsyncListener would see the
  ISE but any remaining AsyncListener instances would still be called

I don't see a way of doing better than this without spec changes /
clarifications.

WDYT?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Documentation Contribution: Tomcat Container Managed Security

[Adrian Bartlett]

Hi Mark,

The documentation that is already been published, has been designed to add
value to your existing documentation.

The example in this section:
http://tomcat.apache.org/tomcat-8.5-doc/realm-howto.html#Example_Application,
has been visualised in these dashboards:
https://design.codelytics.io/tomcat/security-login-form and
https://design.codelytics.io/tomcat/security-login.

The example in this section:
http://tomcat.apache.org/tomcat-9.0-doc/jndi-datasource-examples-howto.html#MySQL_DBCP_Example,
has been visualised with these dashboards:
https://design.codelytics.io/tomcat/jdbc-initialisation and
https://design.codelytics.io/tomcat/jdbc-query.

We could possibly show an image of the sequence diagram at the respective
locations, which when clicked, would open a new tab with the full
visualisation. The reader could explore the visualisation to get a more
though understanding of the topic at hand. Alternatively a more integrated
approach might be to open an embedded iFrame, and when the user had
finished, the user could close the iFrame and continue reading.

If we integrated those two pieces and you found that users engaged with
this content, then maybe we could extend it out to cover different areas.

Regards
Adrian.


On Wed, Jun 7, 2017 at 7:45 AM, Mark Thomas  wrote:

> On 03/06/17 04:00, Adrian Bartlett wrote:
> > Thanks for your feedback Mark. Its been a while, but I made some updates
> to
> > address your comments. And the updated dashboards are here:
> > * https://design.codelytics.io/tomcat/security-login-form
> > * https://design.codelytics.io/tomcat/security-login
> >
> > If I was to work with one of Tomcat's expert/senior contributors, we
> could
> > document the entire Tomcat architecture. An example of a dashboard more
> at
> > the architectural level is here:
> > https://design.codelytics.io/tomcat/jdbc-query. Notice in the sequence
> > diagram how the objects have been grouped into packages, which enables a
> > higher level of abstraction at the architectural level.
> >
> > This documentation would give new contributors the ability:
> > * To get up to speed quickly on the inner workings of Tomcat, and
> > contributing sooner
> > * To better align their work with Tomcat's existing architecture
> >
> > Users could also read the documentation to gain a greater understanding
> of
> > Tomcat, and improved ability to self serve.
> >
> > We could tie the documentation generation into your CI/CD system, so the
> > documentation was always up to date and hosted on your own servers.
> >
> > If you think this can add value, send through an email of someone
> > interested in helping. And we can go about capturing Tomcat's important
> > concepts.
>
> I'm probably one of the worst people to ask if this would be useful
> since I'm pretty familiar with most of the Tomcat code base. Some input
> from people newer to Tomcat and still finding their way around some
> areas would be better placed to point your efforts in the most useful
> direction.
>
> Mark
>
>
> >
> > I have been using Tomcat since 1999 and would be tickled pink if I could
> > help out in this way.
> >
> >
> >
> > On Fri, Mar 10, 2017 at 10:18 PM, Mark Thomas  wrote:
> >
> >> On 10/03/17 11:19, Adrian Bartlett wrote:
> >>> Hi All,
> >>>
> >>> I documented the:  */jsp/security/protected/index.html*,  example that
> >>> comes bundled with Tomcat. It is documented using Sequence Diagrams and
> >>> Class Diagrams in the following two dashboards:
> >>> https://design.codelytics.io/?dashboardId=tomcat.cms.login_form
> >>> https://design.codelytics.io/?dashboardId=tomcat.cms.login
> >>>
> >>> If you feel that this type of documentation is useful for Tomcat users
> >> and
> >>> developers. I can document other aspects of Tomcat, like Realms,
> >> Connection
> >>> Pooling, Valves etc.
> >>
> >> Anything that helps users understand how things like this work is good.
> >>
> >> I found the UI a little clunky and my personal preference is to see more
> >> information on the screen at once.
> >>
> >> You need to include part 2 of the security constraint in the excerpt
> >> from web.xml in the intro.
> >>
> >> I suggest asking for feedback on the users list to see which areas are
> >> of greatest interest.
> >>
> >> Kind regards,
> >>
> >> Mark
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: asyncError() is not valid while in Async state DISPATCHING

[Mark Thomas]

On 05/06/17 09:38, Violeta Georgieva wrote:



> Try with this test
> https://github.com/violetagg/tomcat/commit/53564d4e73496cb3badcaaab81a1314cf2ed750d

Thanks. That clarifies things a lot.

It boils down to what should happen when an I/O error occurs reading
from the request or writing to the response on an non-container thread.

The Servlet spec is silent on the issue. There are some requirements
starting with the last bullet at the bottom of page 2-16 of the final
3.1 specification but they relate to errors during the call to dispatch.

Tomcat's current behaviour is to:
- rethrow the exception so it is visible to the non-container thread
- expect the non-container thread to exit without further I/O or calls
  to the async API
- invoke the async error handling mechanism that will in turn call
  complete() or dispatch()

Also, the reason this is the way it is is to ensure that when there is
an I/O error, the correct clean-up is performed by the container (e.g.
correctly tracking the current connection count).

The problem in the test case occurs when the non-container thread
catches the error and calls dispatch before the invocation of the async
error handling has taken effect.

The lack of specification in this area is a real problem. If we leave it
up to the non-container thread to do the clean-up, many won't. If we
always have the container do the clean-up, it is likely to conflict with
non-container threads that try to do the same.

I'm currently on the fence between calling this an application error
(the non-container thread should not call dispatch after an I/O error)
and trying to figure out if there is a way we could handle this.

I'm currently looking at the code to see what the options might be. Did
you have a patch in mind? We also need to be careful that we don't end
up with multiple container threads trying to handle the same async request.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60461] SIGSEGV in SSLSocket.getInfos

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60461

--- Comment #31 from Ludovic Pénet  ---
Maybe I did something really stupid, but I get : 

jsvc.exec: symbol lookup error:
/usr/share/java/tomcat-base_senateurs-commun/libtcnative-1.so.0.2.12: undefined
symbol: assert

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61154] The manager applications don't start when using the Security Manager

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61154

--- Comment #3 from Mark Thomas  ---
I was heading in the direction of B. However, I don't see a simple solution
that works equally well with and without a SecurityManager.

My thinking so far has reached the point of wondering if the privileged flag on
the context makes any sense at all when not running under a SecuirtyManager.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: package trailers does not exist

[Mark Thomas]

On 08/06/17 22:59, Igal @ Lucee.org wrote:
> When I set the `test` directory as a Test root dir in IntelliJ IDEA, I
> get errors like:
> 
> E:\Workspace\git\tomcat\test\org\apache\coyote\http2\TestStream.java
> Error:(33, 16) java: package trailers does not exist
> Error:(90, 49) java: cannot find symbol
>   symbol:   class ResponseTrailers
>   location: class org.apache.coyote.http2.TestStream
> 
> https://github.com/apache/tomcat/blob/trunk/test/org/apache/coyote/http2/TestStream.java#L33
> 
> 
> Can anyone tell me where `trailers` is coming from?

The examples web application.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org