[Bug 61253] Tomcat's Digester silently ignore's failed property replacement

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61253

Coty Sutherland  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Coty Sutherland  ---
Fixed in:

- trunk for 9.0.0.M25 onwards
- 8.5.x for 8.5.19 onwards
- 8.0.x for 8.0.46 onwards
- 7.0.x for 7.0.80 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1802642 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/digester/Digester.java webapps/docs/changelog.xml

2017-07-21 Thread csutherl
Author: csutherl
Date: Fri Jul 21 19:52:13 2017
New Revision: 1802642

URL: http://svn.apache.org/viewvc?rev=1802642&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61253

Add warn message when Digester.updateAttributes throws an exception instead of 
ignoring it.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jul 21 19:52:13 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020
 
/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,174

svn commit: r1802641 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/digester/Digester.java webapps/docs/changelog.xml

2017-07-21 Thread csutherl
Author: csutherl
Date: Fri Jul 21 19:51:01 2017
New Revision: 1802641

URL: http://svn.apache.org/viewvc?rev=1802641&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61253

Add warn message when Digester.updateAttributes throws an exception instead of 
ignoring it.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jul 21 19:51:01 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1

svn commit: r1802640 - in /tomcat/tc8.5.x/trunk: java/org/apache/tomcat/util/digester/Digester.java webapps/docs/changelog.xml

2017-07-21 Thread csutherl
Author: csutherl
Date: Fri Jul 21 19:49:01 2017
New Revision: 1802640

URL: http://svn.apache.org/viewvc?rev=1802640&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61253

Add warn message when Digester.updateAttributes throws an exception instead of 
ignoring it.

Modified:
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1802640&r1=1802639&r2=1802640&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java Fri 
Jul 21 19:49:01 2017
@@ -1988,7 +1988,7 @@ public class Digester extends DefaultHan
 newAttrs.setValue(i, newValue);
 }
 } catch (Exception e) {
-// ignore - let the attribute have its original value
+log.warn("Attribute [" + newAttrs.getLocalName(i) + "] failed 
to update and remains [" + value + "].", e);
 }
 }
 

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1802640&r1=1802639&r2=1802640&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Fri Jul 21 19:49:01 2017
@@ -52,6 +52,10 @@
 other class loader resources) when the web application is deployed in a
 packed WAR file. (markt)
   
+  
+61253: Add warn message when Digester.updateAttributes
+throws an exception instead of ignoring it. (csutherl)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1802639 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java webapps/docs/changelog.xml

2017-07-21 Thread csutherl
Author: csutherl
Date: Fri Jul 21 19:45:38 2017
New Revision: 1802639

URL: http://svn.apache.org/viewvc?rev=1802639&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61253

Add warn message when Digester.updateAttributes throws an exception instead of 
ignoring it.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1802639&r1=1802638&r2=1802639&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Fri Jul 21 
19:45:38 2017
@@ -1923,7 +1923,7 @@ public class Digester extends DefaultHan
 newAttrs.setValue(i, newValue);
 }
 } catch (Exception e) {
-// ignore - let the attribute have its original value
+log.warn("Attribute [" + newAttrs.getLocalName(i) + "] failed 
to update and remains [" + value + "].", e);
 }
 }
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1802639&r1=1802638&r2=1802639&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Jul 21 19:45:38 2017
@@ -58,6 +58,10 @@
 work directory for improved performance when deploying packed WAR 
files.
 (markt)
   
+  
+61253: Add warn message when Digester.updateAttributes
+throws an exception instead of ignoring it. (csutherl)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762

--- Comment #5 from Jesse  ---
We have actually implemented letsencrypt in our application.  We allow users to
configure new domains that our application will respond to over SSL, and we
give them the option to provide their own certificate or the application can
generate (and auto-renew) for them via letsencrypt.

I do agree that this request would align well with the needs of tomcat
supporting letsencrypt, although my request is actually to provide the public
methods so our application can control things as necessary to leverage
letsencrypt or user provided certificates at runtime.  Those same methods could
likely be used by more generic letsencrypt support as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Download pages cgi on tomcat.a.o site are broken

2017-07-21 Thread Mark Thomas
On 18/07/2017 19:47, Rainer Jung wrote:
> Am 18.07.2017 um 20:32 schrieb Rainer Jung:
>> Am 18.07.2017 um 20:26 schrieb Rainer Jung:



>>> So the web server behind 62.210.60.236 seems to have a config problem.
>>>
>>> Should I report to infra?
>>
>> Interestingly using the URI /download.cgi from the httpd project works
>> on that web server, but the same URI for apr.apache.org does not. Also
>> the URI /download_jmeter.cgi from the JMeter project does not work.
> 
> I now noticed a five days old mail on the infra mailing list maybe
> triggered by a similar observation. I added the above info. The OP
> reported 5 days ago, that for him the problem went away after touching
> the page once without change.
> 
> I did not find an existing INFRA Jira issue for it.

I spent some time looking at this without much luck. Fortunately, the
infra staff were available, they took a look and it has been fixed.

Yah for Infra.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.18

2017-07-21 Thread Martin Grigorov
On Tue, Jul 18, 2017 at 3:58 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.18 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Enable TLS connectors to use Java key stores that contain multiple
>   keys where each key has a separate password. Based on a patch by Frank
>   Taffelt.
>
> - Make asynchronous error handling more robust. In particular ensure
>   that onError() is called for any registered AsyncListeners after an
>   I/O error on a non-container thread.
>
> - Sync SSL session access for the APR connector to prevent errors when
>   accessing the session.
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1144/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/
>
> The proposed 8.5.18 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.18
>


Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M24

2017-07-21 Thread Mark Thomas
On 18/07/17 12:43, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.0.M24 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> Note that the 9.0.0.M23 release vote was cancelled due to a regression.
> 
> The major changes compared to the 9.0.0.M22 release are:
> 
> - Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting
>   down cleanly.
> 
> - Add LoadBalancerDrainingValve, a Valve designed to reduce the amount
>   of time required for a node to drain its authenticated users.
> 
> - When generating JSP runtime error messages that quote the relevant JSP
>   source code, switch from using the results of the JSP page parsing
>   process to using the JSR 045 source map data to identify the correct
>   part of the JSP source from the stack trace. This significantly
>   reduces the memory footprint of Jasper in development mode, provides a
>   small performance improvement for error page generation and enables
>   source quotes to continue to be provided after a Tomcat restart.
> 
> - Add support for a Tomcat specific deployment descriptor,
>   /WEB-INF/tomcat-web.xml
> 
> Along with lots of other bug fixes and improvements.
> 
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M24/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1143/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M24/
> 
> The proposed 9.0.0.M24 release is:
> [X] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M24

Sorry, another regression around static file handling and encoding
differences.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.18

2017-07-21 Thread Mark Thomas
On 18/07/17 14:58, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.18 release is now available for voting.
> 
> The major changes compared to the 8.5.16 release are:
> 
> - Enable TLS connectors to use Java key stores that contain multiple
>   keys where each key has a separate password. Based on a patch by Frank
>   Taffelt.
> 
> - Make asynchronous error handling more robust. In particular ensure
>   that onError() is called for any registered AsyncListeners after an
>   I/O error on a non-container thread.
> 
> - Sync SSL session access for the APR connector to prevent errors when
>   accessing the session.
> 
> 
> Along with lots of other bug fixes and improvements.
> 
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1144/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/
> 
> The proposed 8.5.18 release is:
> [X] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.18

Sorry, another regression around static file handling and encoding
differences.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M24

2017-07-21 Thread Martin Grigorov
On Tue, Jul 18, 2017 at 1:43 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M24 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> Note that the 9.0.0.M23 release vote was cancelled due to a regression.
>
> The major changes compared to the 9.0.0.M22 release are:
>
> - Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting
>   down cleanly.
>
> - Add LoadBalancerDrainingValve, a Valve designed to reduce the amount
>   of time required for a node to drain its authenticated users.
>
> - When generating JSP runtime error messages that quote the relevant JSP
>   source code, switch from using the results of the JSP page parsing
>   process to using the JSR 045 source map data to identify the correct
>   part of the JSP source from the stack trace. This significantly
>   reduces the memory footprint of Jasper in development mode, provides a
>   small performance improvement for error page generation and enables
>   source quotes to continue to be provided after a Tomcat restart.
>
> - Add support for a Tomcat specific deployment descriptor,
>   /WEB-INF/tomcat-web.xml
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M24/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1143/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M24/
>
> The proposed 9.0.0.M24 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M24
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 61322] Http11Processor.disableKeepAlivePercentage not work after code change in 60319

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61322

--- Comment #2 from Colin  ---
Another issue I found:
With below server configuration:



>From document of Connector.executor, if I use Executor in Connector(so not use
internalExecutor), maxThreads and other thread pool related properties will
ignored(so return -1), but I found Connector's service thread count still
limited by Connector.maxThreads.
e.g. in above example, the executor has 4 threads, but in my test, only 2
clients connected and both keep alived and no more client can connect.

Please also help to check this issue. I use 7.0.75 in my tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 61322] Http11Processor.disableKeepAlivePercentage not work after code change in 60319

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61322

--- Comment #1 from Colin  ---
I found this issue in some of my customer environment, our application use 200
threads, and some customer have more than 300 clients, so about 100+ client
can't connect to server.

After some check, I found all thread blocked on keep-alive state and trying to
read next request from socket.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 61322] Http11Processor.disableKeepAlivePercentage not work after code change in 60319

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61322

Colin  changed:

   What|Removed |Added

 CC||song6...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 61322] New: Http11Processor.disableKeepAlivePercentage not work after code change in 60319

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61322

Bug ID: 61322
   Summary: Http11Processor.disableKeepAlivePercentage not work
after code change in 60319
   Product: Tomcat 7
   Version: 7.0.79
  Hardware: PC
OS: Linux
Status: NEW
  Severity: critical
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: song6...@gmail.com
  Target Milestone: ---

After code change in 60319, connector attributes will be reported as -1 when an
Executor is in use.

But in Http11Processor.disableKeepAlive(), we still use
endpoint.getMaxThreads() to get max threads allowed, and when use a Executor,
this returns -1, and disableKeepAlive() always return false in this case.

This issue exist from 7.0.73 to 7.0.79.


Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60762] Enhancement: Add support for runtime SNI changes in tomcat-embed

2017-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60762

Ralf Hauser  changed:

   What|Removed |Added

 CC||hau...@acm.org

--- Comment #4 from Ralf Hauser  ---
Might be useful to implement letsencrypt - see also

http://people.apache.org/~schultz/ApacheCon NA 2017/Let's Encrypt Apache
Tomcat.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org